[Libreoffice-bugs] [Bug 108709] cli_ assemblies are not correctly versioned

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108709

Adolfo Jayme  changed:

   What|Removed |Added

   Keywords|needsDevAdvice  |
 Whiteboard|target:6.0.0 target:5.4.2   |target:6.0.0 target:5.4.1
   |target:5.4.1|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 98705] Reduce starting time on Windows by removing GetCaseCorrectPathName usage

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=98705

Xisco Faulí  changed:

   What|Removed |Added

   Assignee|aasthaagrra...@gmail.com|libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112036] New: Align no longer allows aligning to an existing object

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112036

Bug ID: 112036
   Summary: Align no longer allows aligning to an existing object
   Product: LibreOffice
   Version: 5.4.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kurt.fitz...@gmail.com

The align command (Modify->Align->Align ) used to function by taking the
selected group of objects and aligning the the group to the first object
selected.  This way a complex series of alignments could be created by bringing
in one object at a time and aligning it to other parts of the group.  Now
aligning always moves every object selected, ruining the spacing on all of
them.  This makes the whole feature exactly useless since it ruins any relative
spacing you have created with the objects you are trying to align to.

Please revert this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104527] [META] DOC bug tracker

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104527
Bug 104527 depends on bug 32991, which changed state.

Bug 32991 Summary: FORMATTING: Tables Alignment lost when exporting to DOC and 
loading in MS Word
https://bugs.documentfoundation.org/show_bug.cgi?id=32991

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sw/source

2017-08-25 Thread Justin Luth
 sw/source/filter/ww8/wrtww8.cxx |   22 --
 1 file changed, 20 insertions(+), 2 deletions(-)

New commits:
commit fde332fc9d59102749dbeb20f4e78e2233152e1b
Author: Justin Luth 
Date:   Fri Aug 25 17:53:58 2017 -0400

tdf#32991 DOCexport: MSO-compatible table justification

Although LO could round-trip the files, MSO didn't open
them properly, indicating both import and export differences.

There are two table justification codes: sprmTJc and sprmTJc90.
LO appears to treat sprmTJc90 as the WW8 version, but actually
both are valid.  TJc is the LOGICAL justification - meaning that
it is affected by RTL/LTR settings.  TJc90 is the PHYSICAL
justification, regardless of BiDi.
https://msdn.microsoft.com/en-us/library/dd951612(v=office.12).aspx

Based on testing results, it appears that MSO REQUIRES TJc codes.
If it isn't defined, MSO uses the default value of TJc:LEFT, and
ignores TJc90 code. It appears that MSO always writes out
both codes if they aren't the default values.

This patch only deals with the export difference.

Change-Id: Id722261acab7ae6c0b7d808be75fc3452c2255d8
Reviewed-on: https://gerrit.libreoffice.org/41584
Tested-by: Jenkins 
Reviewed-by: Justin Luth 

diff --git a/sw/source/filter/ww8/wrtww8.cxx b/sw/source/filter/ww8/wrtww8.cxx
index 942d6b047487..6beaeaefe3fe 100644
--- a/sw/source/filter/ww8/wrtww8.cxx
+++ b/sw/source/filter/ww8/wrtww8.cxx
@@ -2218,13 +2218,31 @@ void WW8AttributeOutput::TableOrientation( 
ww8::WW8TableNodeInfoInner::Pointer_t
  text::RelOrientation::FRAME == rVert.GetRelationOrient())
 )
 {
+const bool bIsRTL = m_rWW8Export.TrueFrameDirection(*pFormat) == 
SvxFrameDirection::Horizontal_RL_TB;
 sal_Int16 eHOri = rHori.GetHoriOrient();
 switch (eHOri)
 {
 case text::HoriOrientation::CENTER:
+m_rWW8Export.InsUInt16( NS_sprm::sprmTJc ); //logical 
orientation required for MSO
+m_rWW8Export.InsUInt16( 1 );
+m_rWW8Export.InsUInt16( NS_sprm::sprmTJc90 ); //physical 
orientation required for LO
+m_rWW8Export.InsUInt16( 1 );
+break;
 case text::HoriOrientation::RIGHT:
-m_rWW8Export.InsUInt16( NS_sprm::sprmTJc90 );
-m_rWW8Export.InsUInt16( text::HoriOrientation::RIGHT == eHOri 
? 2 : 1 );
+m_rWW8Export.InsUInt16( NS_sprm::sprmTJc90 ); //required for LO
+m_rWW8Export.InsUInt16( 2 );
+if ( !bIsRTL )
+{
+m_rWW8Export.InsUInt16( NS_sprm::sprmTJc ); //required for 
MSO
+m_rWW8Export.InsUInt16( 2 );
+}
+break;
+case text::HoriOrientation::LEFT:
+if ( bIsRTL )
+{
+m_rWW8Export.InsUInt16( NS_sprm::sprmTJc ); //required for 
MSO
+m_rWW8Export.InsUInt16( 2 );
+}
 break;
 default:
 break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 32991] FORMATTING: Tables Alignment lost when exporting to DOC and loading in MS Word

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=32991

Justin L  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jl...@mail.com
   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |

--- Comment #20 from Justin L  ---
suggested fix at  https://gerrit.libreoffice.org/41584

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112035] New: Set the left and right page styles, but pages display left style on the right, right style on the left.

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112035

Bug ID: 112035
   Summary: Set the left and right page styles, but pages display
left style on the right, right style on the left.
   Product: LibreOffice
   Version: 5.2.7.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: da...@davidwid.com

Description:
I dumped out of scribus because it doesn't work.  Finishing a three hundred
page book in Libreoffice Writer.  I've set the page styles for right and left,
because when build a pdf for publication, that's utterly important.  (Recto and
verso)

So as I review the book, needing the right side pages to display to the right
of the left pages, the pages are reversed.  This is because I start with a
right page, and by default, the first pages is displayed in the first spot,
which in this case, is the left.

Now, I could put a blank page before the right page, as a clumsy hack, but I'd
rather it just work the way it is supposed to work, that when a page is styled
right, it always display to the right of a page styled left.

If we could add a "bumper" page, that is for display logistics only, that would
be nice.

Thank all of you for the work you do.

David

Steps to Reproduce:
1. Set first page to right page style, cause that's what you do for a book.
2. Following pages automatically toggle left/right/left/  as they should.
3. Arrange window to fit pages side by side (in this case 6"x9" page size), and
they are backwards, putting right styled pages onto the left side.

Actual Results:  
1. Set first page to right page style, cause that's what you do for a book.
2. Following pages automatically toggle left/right/left/  as they should.
3. Arrange window to fit pages side by side (in this case 6"x9" page size), and
they are backwards, putting right styled pages onto the left side.

Expected Results:
I expect the right styled page(s) to display on the right side of the left
styled pages.  Not a crazy thing.


Reproducible: Always

User Profile Reset: No

Additional Info:
For something this apparent, I expected to find something that fixed it.  I did
not, so I'm raising the issue here.  Its just a flat out failure.  Layout
sensitive, yes, but a failure just the same.


User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like
Gecko) Chrome/60.0.3112.90 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112034] New: notebookbar: label collor didn't use system color

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112034

Bug ID: 112034
   Summary: notebookbar: label collor didn't use system color
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kain...@gmail.com

if you use a dark color theme or change to UX text color in the options, the
menubar text change but not the labels in the notebookbars.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sw/source

2017-08-25 Thread Justin Luth
 sw/source/filter/ww8/ww8par2.cxx |7 ---
 1 file changed, 7 deletions(-)

New commits:
commit c420f36d9a19bb0b9da5cefa0c1b54b60ccb41a8
Author: Justin Luth 
Date:   Fri Aug 25 15:28:54 2017 -0400

remove dead comment.

The code that this comment documented was /* ... */ commented out
in 2004 commit ed9a3e51ef9353dd028126496a1a105570dc48a2

That dead block of code was removed in 2010 commit
6eb5f64fd829338614d12212ad9c03ec616f3436
but they didn't take the comment out with it.

Change-Id: Id0ef75c09bd060e2621400492fb404eebbee6385
Reviewed-on: https://gerrit.libreoffice.org/41581
Tested-by: Jenkins 
Reviewed-by: Justin Luth 

diff --git a/sw/source/filter/ww8/ww8par2.cxx b/sw/source/filter/ww8/ww8par2.cxx
index 32b7747e669e..e2238338b95f 100644
--- a/sw/source/filter/ww8/ww8par2.cxx
+++ b/sw/source/filter/ww8/ww8par2.cxx
@@ -2410,13 +2410,6 @@ void WW8TabDesc::CalcDefaults()
 nMinCols = pR->nSwCols;
 }
 
-/*
-#i9718#
-Find the largest of the borders on cells that adjoin top bottom and remove
-the val from the top and put in on the bottom cell. I can't seem to make
-disjoint upper and lowers to see what happens there.
-*/
-
 if ((m_nMinLeft && !m_bIsBiDi && text::HoriOrientation::LEFT == m_eOri) ||
 (m_nMinLeft != -108 && m_bIsBiDi && text::HoriOrientation::RIGHT == 
m_eOri)) // Word sets the first nCenter value to -108 when no indent is used
 m_eOri = text::HoriOrientation::LEFT_AND_WIDTH; //  absolutely 
positioned
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 112019] Character style font set in Bullets and Numbering not respected for bullets

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112019

Regina Henschel  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||rb.hensc...@t-online.de
 Ever confirmed|0   |1
   Severity|normal  |enhancement

--- Comment #3 from Regina Henschel  ---
The reason is, that when selecting a character as bullet, you automatically get
a font for that character. There is no UI to remove the font information. But
you need to remove it in the file format directly. Your document has for
example


  
   
   
   
   
  

There the element  has to
be removed. Then the bullet character gets the font from the style which is
referenced in attribute text:style-name="Bullet_20_Symbols".

I set this as enhancement request to get a UI to select bullet characters
without direct formatting.

I have not examined whether the new list styles take care of this problem. But
that would be a different issue anyway.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104937] FILEOPEN: RTF: table' s columns are narrower than they should be

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104937

Miklos Vajna  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |vmik...@collabora.co.uk
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112033] New: XML Source button disabled (In Data Menu)

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112033

Bug ID: 112033
   Summary: XML Source button disabled (In Data Menu)
   Product: LibreOffice
   Version: 5.4.0.3 release
  Hardware: x86-64 (AMD64)
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gbc...@gmail.com

Description:
When editing a document, there is no way to import a "XLM Source" through the
"Data" menu as the button seems to be always disabled.

This has been reported here [1] for other users as well, on Linux and Windows
machines. It seems like a regression from last version (5.3).

[1]:
https://ask.libreoffice.org/en/question/121020/dataxml-source-button-disabled/

Steps to Reproduce:
1.Open an empty spreadsheet;
2.Click "Data" menu;
3.Try to click "XML Source".

Actual Results:  
1.Open an empty spreadsheet;
2.Click on "Data" at the top bar menu;
3.Try to click "XML Source".

Expected Results:
After clicking "XML Source" button, a new popup wind should appear.


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like
Gecko) Chrome/60.0.3112.101 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: tdf#109097 - mdds accelerating random lookups

2017-08-25 Thread Michael Meeks

On 25/08/17 16:42, Eike Rathke wrote:
> Does not sound very appealing to me. A better lookup time is certainly
> desirable by means of interpolation or binary search, but at the cost of
> insertion/deletion time that's not gonna fly.

Sure - unfortunately its not possible to do a good interpolation lookup
without the positions in there.

> We still have bottlenecks
> where inserting and especially changing type of a cell, which leads to
> shrinkage of one block and enlargement or insertion of another, can
> build up to looong waiting times. I don't have the bug number at hand
> right now, but the worst case is a Find that changes string
> cells to numeric (or vice versa) in a column of data.

Last I looked at that - we were doing find/replace horizontally which
was very wasteful - and switching it to doing things in a columnar
direction seemed to help in
https://bugs.documentfoundation.org/show_bug.cgi?id=92160

> I think these should be addressed first.

Fair cop; ultimately - re-building the column as it is replaced by
moving and appending the items to a new clean column should have a more
linear cost there I'd hope.

Any other concerns there ? ultimately the old code must have had this
linear cost too - for insertions / deletions etc. (but not for cell type
changes).

ATB,

Michael.

-- 
michael.me...@collabora.com <><, Pseudo Engineer, itinerant idiot
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: 2 commits - sw/inc sw/source

2017-08-25 Thread Michael Stahl
 sw/inc/IDocumentRedlineAccess.hxx |   12 ++--
 sw/source/core/doc/DocumentRedlineManager.cxx |   17 -
 sw/source/core/doc/doccomp.cxx|9 ++---
 sw/source/core/inc/DocumentRedlineManager.hxx |2 +-
 sw/source/core/undo/undobj.cxx|6 +++---
 sw/source/core/unocore/unocrsrhelper.cxx  |4 ++--
 6 files changed, 34 insertions(+), 16 deletions(-)

New commits:
commit 9cabd72ef14e19897f4d6f078758ac8b1aa6c02f
Author: Michael Stahl 
Date:   Fri Aug 25 22:55:22 2017 +0200

tdf#109267 sw: fix confusing return value of AppendRedline()

AppendRedline() has a boolen return value which is rather
unclear and confusing: most callers don't even check it, but
SaveMergeRedline::InsertRedline() expects "true" to mean that
its redline hasn't been deleted, whereas makeRedline()
expects "true" to mean that the redline was somehow "valid",
even if it has been deleted and merged with an existing one.

The "bMerged" variable in AppendRedline(), which is the source
of the confusion, was introduced with commit
81286906d0b76a3b6c4443378877828290c3e5f0 "docx import fixes
for: redlines".

Split these differing expectations into different return
values of a new enum type.

Change-Id: If81631bde49ee52a249f5ba1dd64ab8e92fffaf7

diff --git a/sw/inc/IDocumentRedlineAccess.hxx 
b/sw/inc/IDocumentRedlineAccess.hxx
index ac5d017eda4c..3f42f32d98ea 100644
--- a/sw/inc/IDocumentRedlineAccess.hxx
+++ b/sw/inc/IDocumentRedlineAccess.hxx
@@ -159,15 +159,23 @@ public:
 
 virtual bool IsInRedlines(const SwNode& rNode) const = 0;
 
+enum class AppendResult { IGNORED, MERGED, APPENDED };
 /** Append a new redline
 
-@param pPtr
+@param pNewRedl redline to insert
 
 @param bCallDelete
+if set, then for a new DELETE redline that is inserted so that it
+overlaps an existing INSERT redline with the same author, the
+overlapping range is deleted, i.e. the new DELETE removes
+existing INSERT for that range
 
 @returns
+APPENDED if pNewRedl is still alive and was appended
+MERGED if pNewRedl was deleted but has been merged with existing 
one
+IGNORED if pNewRedl was deleted and ignored/invalid
 */
-virtual bool AppendRedline(/*[in]*/SwRangeRedline* pPtr, /*[in]*/bool 
bCallDelete) = 0;
+virtual AppendResult AppendRedline(/*[in]*/SwRangeRedline* pNewRedl, 
/*[in]*/bool bCallDelete) = 0;
 
 virtual bool AppendTableRowRedline(/*[in]*/SwTableRowRedline* pPtr, 
/*[in]*/bool bCallDelete) = 0;
 virtual bool AppendTableCellRedline(/*[in]*/SwTableCellRedline* pPtr, 
/*[in]*/bool bCallDelete) = 0;
diff --git a/sw/source/core/doc/DocumentRedlineManager.cxx 
b/sw/source/core/doc/DocumentRedlineManager.cxx
index 1a62a0b04c64..1d9a24be3153 100644
--- a/sw/source/core/doc/DocumentRedlineManager.cxx
+++ b/sw/source/core/doc/DocumentRedlineManager.cxx
@@ -1,4 +1,3 @@
-
 /* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
 /*
  * This file is part of the LibreOffice project.
@@ -730,7 +729,8 @@ Behaviour of Delete-Redline:
   other Insert is overlapped by
   the Delete
 */
-bool DocumentRedlineManager::AppendRedline( SwRangeRedline* pNewRedl, bool 
bCallDelete )
+IDocumentRedlineAccess::AppendResult
+DocumentRedlineManager::AppendRedline(SwRangeRedline* pNewRedl, bool const 
bCallDelete)
 {
 bool bMerged = false;
 CHECK_REDLINE( *this )
@@ -792,7 +792,7 @@ bool DocumentRedlineManager::AppendRedline( SwRangeRedline* 
pNewRedl, bool bCall
 ( pNewRedl->GetContentIdx() == nullptr ) )
 {   // Do not insert empty redlines
 delete pNewRedl;
-return false;
+return AppendResult::IGNORED;
 }
 bool bCompress = false;
 SwRedlineTable::size_type n = 0;
@@ -1706,7 +1706,9 @@ bool DocumentRedlineManager::AppendRedline( 
SwRangeRedline* pNewRedl, bool bCall
 }
 CHECK_REDLINE( *this )
 
-return ( nullptr != pNewRedl ) || bMerged;
+return (nullptr != pNewRedl)
+? AppendResult::APPENDED
+: ((bMerged) ? AppendResult::MERGED : AppendResult::IGNORED);
 }
 
 bool DocumentRedlineManager::AppendTableRowRedline( SwTableRowRedline* 
pNewRedl, bool )
diff --git a/sw/source/core/doc/doccomp.cxx b/sw/source/core/doc/doccomp.cxx
index 6dc6fb18db2d..1acbe7a9f306 100644
--- a/sw/source/core/doc/doccomp.cxx
+++ b/sw/source/core/doc/doccomp.cxx
@@ -1751,7 +1751,9 @@ void CompareData::SetRedlinesToDoc( bool bUseDocInfo )
 }
 
 do {
-if( rDoc.getIDocumentRedlineAccess().AppendRedline( new 
SwRangeRedline( aRedlnData, *pTmp ), true) &&
+if (IDocumentRedlineAccess::AppendResult::APPENDED ==
+

[Libreoffice-bugs] [Bug 83946] [META] Tracking changes issues

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=83946
Bug 83946 depends on bug 109267, which changed state.

Bug 109267 Summary: Assertion failed when undoing delete inside redline insert
https://bugs.documentfoundation.org/show_bug.cgi?id=109267

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105537] [META] Assertion failed crashes

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105537
Bug 105537 depends on bug 109267, which changed state.

Bug 109267 Summary: Assertion failed when undoing delete inside redline insert
https://bugs.documentfoundation.org/show_bug.cgi?id=109267

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 109267] Assertion failed when undoing delete inside redline insert

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=109267

Michael Stahl  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |rosemary.s...@gmail.com
   |desktop.org |

--- Comment #6 from Michael Stahl  ---
okay, proceeded as proposed in comment #4 and comment #5

so i guess we can call this fixed now

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: binaryurp/source

2017-08-25 Thread Stephan Bergmann
 binaryurp/source/proxy.cxx |4 ++--
 binaryurp/source/proxy.hxx |6 --
 2 files changed, 6 insertions(+), 4 deletions(-)

New commits:
commit e9d64ca080ed0cf2dcb56be13bee1bffbff880fd
Author: Stephan Bergmann 
Date:   Fri Aug 25 20:32:22 2017 +0200

Replace use of oslInterlockedCount with std::atomic

The assumption in using std::size_t is that every acquisition can be 
associated
with a unique memory location in the local address space, so the counter 
cannot
overflow.

Change-Id: I0d004a81d9bf52cf07d13481d9024fcc10b6db6d
Reviewed-on: https://gerrit.libreoffice.org/41580
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/binaryurp/source/proxy.cxx b/binaryurp/source/proxy.cxx
index 1834968fa50b..699037f915dd 100644
--- a/binaryurp/source/proxy.cxx
+++ b/binaryurp/source/proxy.cxx
@@ -76,13 +76,13 @@ Proxy::Proxy(
 
 
 void Proxy::do_acquire() {
-if (osl_atomic_increment(_) == 1) {
+if (++references_ == 1) {
 bridge_->resurrectProxy(*this);
 }
 }
 
 void Proxy::do_release() {
-if (osl_atomic_decrement(_) == 0) {
+if (--references_ == 0) {
 bridge_->revokeProxy(*this);
 }
 }
diff --git a/binaryurp/source/proxy.hxx b/binaryurp/source/proxy.hxx
index 5ad8cee120dc..e8ed0fea2dad 100644
--- a/binaryurp/source/proxy.hxx
+++ b/binaryurp/source/proxy.hxx
@@ -22,7 +22,9 @@
 
 #include "sal/config.h"
 
-#include "osl/interlck.h"
+#include 
+#include 
+
 #include "rtl/ref.hxx"
 #include "rtl/ustring.hxx"
 #include "typelib/typedescription.h"
@@ -78,7 +80,7 @@ private:
 rtl::Reference< Bridge > bridge_;
 OUString oid_;
 com::sun::star::uno::TypeDescription type_;
-oslInterlockedCount references_;
+std::atomic references_;
 };
 
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'private/jmux/scheduler-fixes' - 45 commits - basegfx/source canvas/Library_canvastools.mk canvas/source comphelper/source compilerplugins/clang cui/source dbacc

2017-08-25 Thread Jan-Marek Glogowski
Rebased ref, commits from common ancestor:
commit e6c29a0585237ebea3b2b962ff517f202ce6154d
Author: Jan-Marek Glogowski 
Date:   Fri Aug 25 22:03:47 2017 +0200

OSX fix ODK example builds with enabled SIP

The "System Integrity Protection”, introduced in macOS El Capitan,
strips DYLD_* environment variables from all calls of software in
/bin and /usr/bin.

As a workaround we copy the shell to a temporary file and use it
in our "sub-make" calls to build the examples.

Change-Id: I3f07492782d56e153e8fcdea605a042ec1898276

diff --git a/odk/CustomTarget_build-examples.mk 
b/odk/CustomTarget_build-examples.mk
index 81ac3a1437c6..f7dc1db1e30d 100644
--- a/odk/CustomTarget_build-examples.mk
+++ b/odk/CustomTarget_build-examples.mk
@@ -93,6 +93,11 @@ ifneq ($(gb_SUPPRESS_TESTS),)
@true
 else
$(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),CHK,1)
+ifeq (MACOSX,$(OS))
+   $(eval ODK_BUILD_SHELL := $(shell $(gb_MKTEMP)))
+   cp /bin/sh "$(ODK_BUILD_SHELL)"
+   chmod 0700 "$(ODK_BUILD_SHELL)"
+endif
(saved_library_path=$${$(gb_Helper_LIBRARY_PATH_VAR)} && . $< \
 $(if $(filter MACOSX,$(OS)),, \
 && $(gb_Helper_LIBRARY_PATH_VAR)=$$saved_library_path) \
@@ -100,11 +105,16 @@ else
 UserInstallation=$(call gb_Helper_make_url,$(call 
gb_CustomTarget_get_workdir,odk/build-examples)/user) \
 $(foreach my_dir,$(my_example_dirs), \
 && (cd $(INSTDIR)/$(SDKDIRNAME)/examples/$(my_dir) \
-&& printf 'yes\n' | LC_ALL=C make))) \
+&& printf 'yes\n' | LC_ALL=C make \
+$(if $(filter MACOSX,$(OS)), SHELL=$(ODK_BUILD_SHELL), 
 \
 >$(call gb_CustomTarget_get_workdir,odk/build-examples)/log 2>&1 \
 || (RET=$$? \
+$(if $(filter MACOSX,$(OS)), && rm -f $(ODK_BUILD_SHELL) , ) \
 && cat $(call gb_CustomTarget_get_workdir,odk/build-examples)/log \
 && exit $$RET)
+ifeq (MACOSX,$(OS))
+   -rm -f $(ODK_BUILD_SHELL)
+endif
 endif
 
 $(call gb_CustomTarget_get_workdir,odk/build-examples)/setsdkenv: \
commit b3792403105376c68b23b4309d5aec6b8db80d76
Author: Jan-Marek Glogowski 
Date:   Fri Aug 25 14:52:38 2017 +0200

Disable ScHeaderFooterTextCursor scenario test

Just like the ScHeaderFooterTextObj, it depends on weak referenced
objects, which might be gone / cleaned up at test time.

Change-Id: I52503646c51b0915df11f5c7f90c16208e45879a

diff --git a/sc/qa/unoapi/sc_4.sce b/sc/qa/unoapi/sc_4.sce
index bf05df96ac04..cb40680ac35f 100644
--- a/sc/qa/unoapi/sc_4.sce
+++ b/sc/qa/unoapi/sc_4.sce
@@ -29,12 +29,13 @@
 # ported to cppunit -o sc.ScHeaderFieldObj
 -o sc.ScHeaderFieldsObj
 -o sc.ScHeaderFooterContentObj
--o sc.ScHeaderFooterTextCursor
 # SHF_TextObj is composed of SHF_TextData, which has a weak reference to
 # SHF_ContentObj, which itself has three references to SHF_TextObj.
 # The css::text::XTextRange test fails often when the weak SHF_ContentObj is
 # already gone. If just this test is disabled, later tests of this object fail
 # too, so this disables the whole interface.
+# Same for ScHeaderFooterTextCursor.
+# -o sc.ScHeaderFooterTextCursor
 # -o sc.ScHeaderFooterTextObj
 -o sc.ScIndexEnumeration_CellAnnotationsEnumeration
 -o sc.ScIndexEnumeration_CellAreaLinksEnumeration
commit 6de0719d840158f31c54e3259db4f3e23469acb7
Author: Jan-Marek Glogowski 
Date:   Fri Aug 25 11:12:24 2017 +0200

Cleanup dbaccess module makefile

Change-Id: Ic379a8362bb25fb1635c9900bbf247c8f2943c74

diff --git a/dbaccess/Module_dbaccess.mk b/dbaccess/Module_dbaccess.mk
index d9f80fc11540..cb0292beb748 100644
--- a/dbaccess/Module_dbaccess.mk
+++ b/dbaccess/Module_dbaccess.mk
@@ -32,36 +32,29 @@ $(eval $(call gb_Module_add_l10n_targets,dbaccess,\
 ))
 
 ifneq ($(OS),IOS)
-ifeq ($(ENABLE_FIREBIRD_SDBC),TRUE)
-$(eval $(call gb_Module_add_check_targets,dbaccess,\
-CppunitTest_dbaccess_firebird_test \
-))
-endif
 
 $(eval $(call gb_Module_add_check_targets,dbaccess,\
CppunitTest_dbaccess_dialog_save \
CppunitTest_dbaccess_empty_stdlib_save \
CppunitTest_dbaccess_nolib_save \
CppunitTest_dbaccess_macros_test \
-   $(if $(ENABLE_JAVA), \
-   CppunitTest_dbaccess_RowSetClones) \
 ))
 
 ifeq ($(ENABLE_JAVA),TRUE)
+
 $(eval $(call gb_Module_add_check_targets,dbaccess,\
+CppunitTest_dbaccess_RowSetClones) \
 CppunitTest_dbaccess_hsqldb_test \
 ))
-endif
 
 # This runs a suite of performance tests on embedded firebird and HSQLDB.
 # Instructions on running the test can be found in 
qa/unit/embeddedb_performancetest
 ifeq ($(ENABLE_FIREBIRD_SDBC),TRUE)
-ifeq ($(ENABLE_JAVA),TRUE)
 $(eval $(call gb_Module_add_check_targets,dbaccess,\
+CppunitTest_dbaccess_firebird_test \
 CppunitTest_dbaccess_embeddeddb_performancetest \
 ))
 endif
-endif
 
 $(eval $(call 

[Libreoffice-commits] core.git: writerperfect/CppunitTest_writerperfect_epubexport.mk writerperfect/qa writerperfect/source

2017-08-25 Thread Miklos Vajna
 writerperfect/CppunitTest_writerperfect_epubexport.mk|2 
 writerperfect/qa/unit/EPUBExportTest.cxx |   57 ---
 writerperfect/qa/unit/data/writer/epubexport/2pages.fodt |   14 +++
 writerperfect/source/writer/EPUBExportFilter.cxx |6 +
 4 files changed, 68 insertions(+), 11 deletions(-)

New commits:
commit 1584d5215cd38be1f7cf14efbfac2e08ef4a0705
Author: Miklos Vajna 
Date:   Fri Aug 25 17:46:20 2017 +0200

EPUB export: allow custom split method

Default is split on heading, but this allows e.g. split on page break
instead.

Change-Id: Ie392fc76f91d60029c7e5f2a0adc55cb18f6157d
Reviewed-on: https://gerrit.libreoffice.org/41577
Tested-by: Jenkins 
Reviewed-by: Miklos Vajna 

diff --git a/writerperfect/CppunitTest_writerperfect_epubexport.mk 
b/writerperfect/CppunitTest_writerperfect_epubexport.mk
index 00a49a522805..a74de9ebc7fd 100644
--- a/writerperfect/CppunitTest_writerperfect_epubexport.mk
+++ b/writerperfect/CppunitTest_writerperfect_epubexport.mk
@@ -28,7 +28,9 @@ $(eval $(call 
gb_CppunitTest_use_libraries,writerperfect_epubexport, \
 ))
 
 $(eval $(call gb_CppunitTest_use_externals,writerperfect_epubexport,\
+epubgen \
 libxml2 \
+revenge \
 ))
 
 $(eval $(call 
gb_CppunitTest_use_external,writerperfect_epubexport,boost_headers))
diff --git a/writerperfect/qa/unit/EPUBExportTest.cxx 
b/writerperfect/qa/unit/EPUBExportTest.cxx
index 859e98374cb5..f6e0d756fd25 100644
--- a/writerperfect/qa/unit/EPUBExportTest.cxx
+++ b/writerperfect/qa/unit/EPUBExportTest.cxx
@@ -7,6 +7,8 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
+#include 
+
 #include 
 #include 
 #include 
@@ -34,20 +36,26 @@ class EPUBExportTest : public test::BootstrapFixture, 
public unotest::MacrosTest
 uno::Reference mxComponentContext;
 uno::Reference mxComponent;
 utl::TempFile maTempFile;
+xmlDocPtr mpXmlDoc = nullptr;
+uno::Reference mxZipFile;
 
 public:
 void setUp() override;
 void tearDown() override;
 void registerNamespaces(xmlXPathContextPtr ) override;
 void createDoc(const OUString , const 
uno::Sequence );
+/// Returns an XML representation of the stream named rName in the 
exported package.
+xmlDocPtr parseExport(const OUString );
 void testOutlineLevel();
 void testMimetype();
 void testEPUB2();
+void testPageBreakSplit();
 
 CPPUNIT_TEST_SUITE(EPUBExportTest);
 CPPUNIT_TEST(testOutlineLevel);
 CPPUNIT_TEST(testMimetype);
 CPPUNIT_TEST(testEPUB2);
+CPPUNIT_TEST(testPageBreakSplit);
 CPPUNIT_TEST_SUITE_END();
 };
 
@@ -64,6 +72,12 @@ void EPUBExportTest::tearDown()
 if (mxComponent.is())
 mxComponent->dispose();
 
+if (mpXmlDoc)
+{
+xmlFreeDoc(mpXmlDoc);
+mpXmlDoc = nullptr;
+}
+
 test::BootstrapFixture::tearDown();
 }
 
@@ -85,6 +99,14 @@ void EPUBExportTest::createDoc(const OUString , const 
uno::SequencestoreToURL(maTempFile.GetURL(), 
aMediaDescriptor.getAsConstPropertyValueList());
+mxZipFile = 
packages::zip::ZipFileAccess::createWithURL(mxComponentContext, 
maTempFile.GetURL());
+}
+
+xmlDocPtr EPUBExportTest::parseExport(const OUString )
+{
+uno::Reference xInputStream(mxZipFile->getByName(rName), 
uno::UNO_QUERY);
+std::shared_ptr 
pStream(utl::UcbStreamHelper::CreateStream(xInputStream, true));
+return parseXmlStream(pStream.get());
 }
 
 void EPUBExportTest::testOutlineLevel()
@@ -92,11 +114,10 @@ void EPUBExportTest::testOutlineLevel()
 createDoc("outline-level.fodt", {});
 
 // Make sure that the output is split into two.
-uno::Reference xNameAccess = 
packages::zip::ZipFileAccess::createWithURL(mxComponentContext, 
maTempFile.GetURL());
-CPPUNIT_ASSERT(xNameAccess->hasByName("OEBPS/sections/section0001.xhtml"));
+CPPUNIT_ASSERT(mxZipFile->hasByName("OEBPS/sections/section0001.xhtml"));
 // This failed, output was a single section.
-CPPUNIT_ASSERT(xNameAccess->hasByName("OEBPS/sections/section0002.xhtml"));
-
CPPUNIT_ASSERT(!xNameAccess->hasByName("OEBPS/sections/section0003.xhtml"));
+CPPUNIT_ASSERT(mxZipFile->hasByName("OEBPS/sections/section0002.xhtml"));
+CPPUNIT_ASSERT(!mxZipFile->hasByName("OEBPS/sections/section0003.xhtml"));
 }
 
 void EPUBExportTest::testMimetype()
@@ -113,6 +134,10 @@ void EPUBExportTest::testMimetype()
 OString aActual(static_cast(aMemoryStream.GetBuffer()) + 38, 
aExpected.getLength());
 // This failed: actual data was some garbage, not the uncompressed mime 
type.
 CPPUNIT_ASSERT_EQUAL(aExpected, aActual);
+
+mpXmlDoc = parseExport("OEBPS/content.opf");
+// Default is EPUB3.
+assertXPath(mpXmlDoc, "/opf:package", "version", "3.0");
 }
 
 void EPUBExportTest::testEPUB2()
@@ -124,13 +149,25 @@ void EPUBExportTest::testEPUB2()
 }));
 createDoc("hello.fodt", aFilterData);
 
-

[Libreoffice-commits] core.git: 3 commits - basegfx/source

2017-08-25 Thread Michael Stahl
 basegfx/source/matrix/b3dhommatrix.cxx|   13 ++--
 basegfx/source/polygon/b2dpolygon.cxx |   31 --
 basegfx/source/polygon/b2dpolypolygon.cxx |9 ++--
 3 files changed, 27 insertions(+), 26 deletions(-)

New commits:
commit 64ced968cc82b552e178da033e7a3b5af6996ae1
Author: Michael Stahl 
Date:   Fri Aug 25 20:56:28 2017 +0200

basegfx: remove global ImplB2DPolyPolygon

Change-Id: I6035aaf8aabf71062bb63a4d416c253378fb4756

diff --git a/basegfx/source/polygon/b2dpolypolygon.cxx 
b/basegfx/source/polygon/b2dpolypolygon.cxx
index 9c6b1eb50fe9..eaed3bacdc54 100644
--- a/basegfx/source/polygon/b2dpolypolygon.cxx
+++ b/basegfx/source/polygon/b2dpolypolygon.cxx
@@ -21,7 +21,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 
 #include 
@@ -170,11 +169,9 @@ public:
 
 namespace basegfx
 {
-namespace { struct DefaultPolyPolygon: public 
rtl::Static {}; }
 
-B2DPolyPolygon::B2DPolyPolygon() :
-mpPolyPolygon(DefaultPolyPolygon::get())
+B2DPolyPolygon::B2DPolyPolygon()
+: mpPolyPolygon()
 {
 }
 
@@ -325,7 +322,7 @@ namespace basegfx
 
 void B2DPolyPolygon::clear()
 {
-mpPolyPolygon = DefaultPolyPolygon::get();
+*mpPolyPolygon = ImplB2DPolyPolygon();
 }
 
 bool B2DPolyPolygon::isClosed() const
commit 7e911e9cd469d30369c213aa529675b3f7c4f0e8
Author: Michael Stahl 
Date:   Fri Aug 25 20:51:22 2017 +0200

basegfx: remove global ImplB2DPolygon

Change-Id: Ibd97ba1d7cc4e04203142057c47a74034cc4f70f

diff --git a/basegfx/source/polygon/b2dpolygon.cxx 
b/basegfx/source/polygon/b2dpolygon.cxx
index 00eaa89d1282..aa528ad861ac 100644
--- a/basegfx/source/polygon/b2dpolygon.cxx
+++ b/basegfx/source/polygon/b2dpolygon.cxx
@@ -23,7 +23,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -632,7 +631,24 @@ public:
 }
 }
 
-ImplB2DPolygon& operator=( const ImplB2DPolygon& ) = delete;
+ImplB2DPolygon& operator=(const ImplB2DPolygon& rOther)
+{
+if (this != )
+{
+mpControlVector.reset();
+mpBufferedData.reset();
+maPoints = rOther.maPoints;
+mbIsClosed = rOther.mbIsClosed;
+if (rOther.mpControlVector && rOther.mpControlVector->isUsed())
+{
+mpControlVector.reset( new 
ControlVectorArray2D(*rOther.mpControlVector) );
+
+if(!mpControlVector->isUsed())
+mpControlVector.reset();
+}
+}
+return *this;
+}
 
 sal_uInt32 count() const
 {
@@ -1091,17 +1107,12 @@ public:
 
 namespace basegfx
 {
-namespace
-{
-struct DefaultPolygon: public rtl::Static {};
-}
-
 B2DPolygon::B2DPolygon()
-:   mpPolygon(DefaultPolygon::get())
+: mpPolygon()
 {}
 
 B2DPolygon::B2DPolygon(std::initializer_list aPoints)
-: mpPolygon(DefaultPolygon::get())
+: mpPolygon()
 {
 for (const basegfx::B2DPoint& rPoint : aPoints)
 {
@@ -1432,7 +1443,7 @@ namespace basegfx
 
 void B2DPolygon::clear()
 {
-mpPolygon = DefaultPolygon::get();
+*mpPolygon = ImplB2DPolygon();
 }
 
 bool B2DPolygon::isClosed() const
commit 0157f98861d589caa60f1ef3dacebb0137d23afe
Author: Michael Stahl 
Date:   Fri Aug 25 20:27:34 2017 +0200

basegfx: remove global 3D IdentityMatrix thread safety hazard

On a tinderbox, CppunitTest_chart2_export crashed in
basegfx::B3DHomMatrix::isEqual(), with other threads in other basegfx
code.

The UnsafeRefCountingPolicy on the global IdentityMatrix is likely the
problem.

Change-Id: Ib142c6f286453d61bd948fb0c184cd68fd313b0f

diff --git a/basegfx/source/matrix/b3dhommatrix.cxx 
b/basegfx/source/matrix/b3dhommatrix.cxx
index 1a88c8b5c777..e6a2bd3b4f88 100644
--- a/basegfx/source/matrix/b3dhommatrix.cxx
+++ b/basegfx/source/matrix/b3dhommatrix.cxx
@@ -17,7 +17,6 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include 
 #include 
 #include 
 #include 
@@ -30,11 +29,8 @@ namespace basegfx
 {
 };
 
-namespace { struct IdentityMatrix : public rtl::Static< 
B3DHomMatrix::ImplType,
-IdentityMatrix > 
{}; }
-
-B3DHomMatrix::B3DHomMatrix() :
-mpImpl( IdentityMatrix::get() ) // use common identity matrix
+B3DHomMatrix::B3DHomMatrix()
+: mpImpl() // identity
 {
 }
 
@@ -81,15 +77,12 @@ namespace basegfx
 
 bool B3DHomMatrix::isIdentity() const
 {
-if(mpImpl.same_object(IdentityMatrix::get()))
-return true;
-
 return mpImpl->isIdentity();
 }
 
 void 

[Libreoffice-bugs] [Bug 109258] Tooling allows (and thus code has) duplicate string entries for translation

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=109258

--- Comment #28 from mi...@filmsi.net ---
*** Bug 111878 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 111878] LO5403rel&5411rc1: In Calc localized function descriptions and data types are in English

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=111878

mi...@filmsi.net changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #9 from mi...@filmsi.net ---
Hi, the reason for this is now known, as it is described more widely in bug
109258.
It is not corrected in 5.3.6.1, as those po files did not massively change
until the 5.4 was released. So it will be fixed, presumably, with 5.4.1.2.
So I am closing this bug as a duplicate of bug 109258.

*** This bug has been marked as a duplicate of bug 109258 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112022] Writer repeatedly crashing for no apparent reason

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112022

--- Comment #9 from Sam  ---
Note that these crashes do not occur at startup but "out of the blue", for no
apparent reason -- I haven't found a way yet to reproduce them. Sometimes
several hours' work cause no problems, and then suddenly a crash strikes.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 111878] LO5403rel&5411rc1: In Calc localized function descriptions and data types are in English

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=111878

--- Comment #8 from Jacques Guilleron  ---
Created attachment 135800
  --> https://bugs.documentfoundation.org/attachment.cgi?id=135800=edit
Function wizard

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 111878] LO5403rel&5411rc1: In Calc localized function descriptions and data types are in English

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=111878

Jacques Guilleron  changed:

   What|Removed |Added

 CC||guillero...@aol.com

--- Comment #7 from Jacques Guilleron  ---
Hi miles,

I get the same issues you show in your sreenshots with LO 5.4.0.3 on Windows 7.
These are corrected in LO 5.3.6.1 available at
http://dev-builds.libreoffice.org/pre-releases/
Can you try it?
I join a sreenshot taken in slovenian UI on LO 5.3.6.1 Windows 7 

Jacques

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112022] Writer repeatedly crashing for no apparent reason

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112022

--- Comment #8 from Sam  ---
(In reply to Julien Nabet from comment #5)
> About Java, could you open a "Terminal" and give the result of:
> java -version

Done (JDK):

java version "1.8.0_144"
Java(TM) SE Runtime Environment (build 1.8.0_144-b01)
Java HotSpot(TM) 64-Bit Server VM (build 25.144-b01, mixed mode)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 111809] New Calc split buttons to add/remove columns/ rows should remember last used option/feature

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=111809

V Stuart Foote  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #3 from V Stuart Foote  ---
Adding the third "Cell operations" button is reasonable. Then splitting the Row
and Column buttons to provide drop list selection but also retain last last
action for a single-click repeat, and decorating button with icon for the
current state (like we did for the color and save buttons) would restore UX.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 111809] New Calc split buttons to add/remove columns/ rows should remember last used option/feature

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=111809

V Stuart Foote  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #3 from V Stuart Foote  ---
Adding the third "Cell operations" button is reasonable. Then splitting the Row
and Column buttons to provide drop list selection but also retain last last
action for a single-click repeat, and decorating button with icon for the
current state (like we did for the color and save buttons) would restore UX.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: compilerplugins/clang

2017-08-25 Thread Stephan Bergmann
 compilerplugins/clang/redundantcast.cxx |   14 ++
 1 file changed, 14 insertions(+)

New commits:
commit c5616014bb288b89610b8b59b9515a06577a8c41
Author: Stephan Bergmann 
Date:   Fri Aug 25 20:21:25 2017 +0200

loplugin:redundantcast: suppress warnings in reworked glibc assert macro

Change-Id: I20be230b3ff5d11395f33a9896d0a575c3051fb7

diff --git a/compilerplugins/clang/redundantcast.cxx 
b/compilerplugins/clang/redundantcast.cxx
index 03e48f8fe261..19393e0c6449 100644
--- a/compilerplugins/clang/redundantcast.cxx
+++ b/compilerplugins/clang/redundantcast.cxx
@@ -439,6 +439,20 @@ bool 
RedundantCast::VisitCXXStaticCastExpr(CXXStaticCastExpr const * expr) {
 {
 return true;
 }
+// Suppress warnings from static_cast in C++ definition of assert in
+//  "assert: Support types
+// without operator== (int) [BZ #21972]":
+if (t1->isBooleanType() && t2->isBooleanType()) {
+auto loc = expr->getLocStart();
+if (compiler.getSourceManager().isMacroBodyExpansion(loc)
+&& (Lexer::getImmediateMacroName(
+loc, compiler.getSourceManager(), compiler.getLangOpts())
+== "assert"))
+{
+return true;
+}
+}
 report(
 DiagnosticsEngine::Warning,
 ("static_cast from %0 %1 to %2 %3 is redundant%select{| or should be"
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 111809] New Calc split buttons to add/remove columns/ rows should remember last used option/feature

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=111809

--- Comment #2 from Gerry  ---
Thank you jay for your response. I understand your point that there are too
many options for group buttons. However, there are IMHO still usability
problems with these two buttons.

I see three main issues with the current implementation:
(1) It mixes (very) frequently used features with substantially less frequently
used features.
(2) In order to access a feature, it always requires two mouseclicks. This is a
usability problem for the frequently used features. Frequent features should
require a minimum number of mouse clicks.
(3) The current two buttons duplicate the features "Up", "Down", "Left",
"Right", "Random Number". This doesn't really make sense and confuses people.

-> Compared to the previous implementation, the frequently used features are
less well accessible.

Hence, I suggest:
Make three out of the two current buttons
(1) ROW button (that remembers the last used feature) with the features:
"insert row below", "insert row above", "delete row" | "hide row", "show row" |
"row height", "optimal height"
(2) COLUMN button (that remembers the last used feature): "insert column
right", "insert column left", "delete column" | "hide column", "show column" |
"column width", "optimal width"
(3) Cell operations button: making accessible the other features: "up", "down",
"left", "right", "random number"

There is already another split button for the features "freeze first row", 
"freeze first column". One could add the feature "row break" and "column break"
there.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 111088] Moving a 3d object around in Draw seems to be slower and more CPU consuming compared to 5.1.6.2

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=111088

--- Comment #3 from Telesto  ---
Hmm, not sure why I reported this. The only thing I can think of the endless
Threads which are created and destroyed again within a millisecond time-frame (
osl_createSuspendedThread)(process and thread activity in Process Monitor)

Could be nothing at all

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112032] New: App crashes on Android 7.0 on slide switching and more

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112032

Bug ID: 112032
   Summary: App crashes on Android 7.0 on slide switching and more
   Product: Impress Remote
   Version: 2.2.3
  Hardware: All
OS: Android
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Android app
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kuklins...@gmail.com

Description:
Crashes if I try to move one slide forward, if I try to do it from the slide
selector. Furthermore, it crashes if I connect with the app before starting the
presentation.

Steps to Reproduce:
1. Open the app
2. Start the presentation
3. Connect
4. Touch the slide

Actual Results:  
android.os.NetworkOnMainThreadException
at
android.os.StrictMode$AndroidBlockGuardPolicy.onNetwork(StrictMode.java:1303)
at java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:111)
at java.net.SocketOutputStream.write(SocketOutputStream.java:157)
at sun.nio.cs.StreamEncoder.writeBytes(StreamEncoder.java:221)
at sun.nio.cs.StreamEncoder.implFlushBuffer(StreamEncoder.java:291)
at sun.nio.cs.StreamEncoder.implFlush(StreamEncoder.java:295)
at sun.nio.cs.StreamEncoder.flush(StreamEncoder.java:141)
at java.io.OutputStreamWriter.flush(OutputStreamWriter.java:229)
at java.io.BufferedWriter.flush(BufferedWriter.java:254)
at
org.libreoffice.impressremote.communication.CommandsTransmitter.writeCommand(CommandsTransmitter.java:44)
at
org.libreoffice.impressremote.communication.CommandsTransmitter.setCurrentSlide(CommandsTransmitter.java:61)
at
org.libreoffice.impressremote.fragment.slides.SlidesGridFragment.changeCurrentSlide(SlidesGridFragment.java:94)
at
org.libreoffice.impressremote.fragment.slides.SlidesGridFragment.onItemClick(SlidesGridFragment.java:89)
at android.widget.AdapterView.performItemClick(AdapterView.java:310)
at android.widget.AbsListView.performItemClick(AbsListView.java:1155)
at android.widget.AbsListView$PerformClick.run(AbsListView.java:3148)
at android.widget.AbsListView$3.run(AbsListView.java:4091)
at android.os.Handler.handleCallback(Handler.java:751)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:154)
at android.app.ActivityThread.main(ActivityThread.java:6195)
at java.lang.reflect.Method.invoke(Native Method)
at
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:874)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:764)


Expected Results:
The presentation moves one slide forward.


Reproducible: Always

User Profile Reset: No, because the app was freshly installed.

Additional Info:


User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:55.0) Gecko/20100101
Firefox/55.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 42112] Fileopen: Diagram from particular DOC file not properly visible until 2-click open or edit as embedded document , but on close also wrong preview

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=42112

--- Comment #26 from Timur  ---
Created attachment 135799
  --> https://bugs.documentfoundation.org/attachment.cgi?id=135799=edit
Embedded DOC from "The doc file to test" saved in MSO

I guess it's oversight to mark this as EMF-WMF, because it's not. 
It's embedded grouped diagram that opens fine in another Writer window where it
can be edited. And embedded looks like a key to me because that document itself
loads fine in LO. 
Now with LO 6.0+ it can also be closed and have object updated in the original
Writer document.
Normally it's important whether it's created in Word or modified in OO, but
it's not so relevant because Word opens it fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103859] [META] EMF/WMF (Enhanced/Windows Metafile) bugs and enhancements

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103859

Timur  changed:

   What|Removed |Added

 Depends on|42112   |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=42112
[Bug 42112] Fileopen: Diagram from particular DOC file not properly visible
until 2-click open or edit as embedded document, but on close also wrong
preview
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 42112] Fileopen: Diagram from particular DOC file not properly visible until 2-click open or edit as embedded document , but on close also wrong preview

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=42112

Timur  changed:

   What|Removed |Added

 Blocks|103859  |
Summary|WMF/EMF from particular DOC |Fileopen: Diagram from
   |file not properly loaded|particular DOC file not
   |and shapes not visible  |properly visible until
   |(workaround : comment #14)  |2-click open or edit as
   ||embedded document, but on
   ||close also wrong preview


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103859
[Bug 103859] [META] EMF/WMF (Enhanced/Windows Metafile) bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 109121] Text Colors Incorrect with Windows 10 High Contrast; Tools> Options>LibreOffce>Application Colors Fixes It Temporarily

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=109121

Buovjaga  changed:

   What|Removed |Added

   Keywords|bibisectRequest, regression |
Version|4.4.7.2 release |4.3.0.4 release

--- Comment #2 from Buovjaga  ---
Unfortunately we only have Windows bibisect repos to 4.3 branch point and the
bug already exists in Version: 4.3.0.0.beta1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112031] New: Docx file cannot be open

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112031

Bug ID: 112031
   Summary: Docx file cannot be open
   Product: LibreOffice
   Version: 5.2.1.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: chandrakuma...@yahoo.com

Description:
SAXParseException  Docx file cannot be open

Steps to Reproduce:
1.file cannot open
2.
3.

Actual Results:  
file not opening

Expected Results:
please help opening this file


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36
(KHTML, like Gecko) Chrome/60.0.3112.101 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - sw/qa xmloff/source

2017-08-25 Thread Michael Stahl
 sw/qa/core/data/odt/fail/82fff64a-0a21-4b09-bbdc-2914a5a150f0.odt |binary
 xmloff/source/style/xmlnumfi.cxx  |5 +
 2 files changed, 5 insertions(+)

New commits:
commit 1e264bb2bf0dc9d173abff02a078f089669d95cd
Author: Michael Stahl 
Date:   Thu Aug 24 13:56:35 2017 +0200

tdf#111934 xmloff: ODF import: self-referential conditional style crash

It's invalid input and also causes stack overflow.

(cherry picked from commit 9fe857b7bd126ff4856fc4689d375881653b97a2)

tdf#111934: add document for filters-tests
Thanks to infostu...@gmail.com for the document; unfortunately git
tells me that i can't set the commit author to just an email address.
(cherry picked from commit 6e090b4272b8fa12d2032ff0c0ea4bfb24c0d2d2)

Change-Id: Ie0b9dcaefcfcf254326151f345f4802ed66b994d
Reviewed-on: https://gerrit.libreoffice.org/41536
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/qa/core/data/odt/fail/82fff64a-0a21-4b09-bbdc-2914a5a150f0.odt 
b/sw/qa/core/data/odt/fail/82fff64a-0a21-4b09-bbdc-2914a5a150f0.odt
new file mode 100644
index ..7d823df75213
Binary files /dev/null and 
b/sw/qa/core/data/odt/fail/82fff64a-0a21-4b09-bbdc-2914a5a150f0.odt differ
diff --git a/xmloff/source/style/xmlnumfi.cxx b/xmloff/source/style/xmlnumfi.cxx
index d4805317fb89..7ba9e711f40f 100644
--- a/xmloff/source/style/xmlnumfi.cxx
+++ b/xmloff/source/style/xmlnumfi.cxx
@@ -1660,6 +1660,11 @@ sal_Int32 
SvXMLNumFormatContext::CreateAndInsert(SvNumberFormatter* pFormatter)
 {
 SvXMLNumFormatContext* pStyle = const_cast( 
static_cast(pStyles->FindStyleChildContext(
 XML_STYLE_FAMILY_DATA_STYLE, aMyConditions[i].sMapName)));
+if (this == pStyle)
+{
+SAL_INFO("xmloff.style", "invalid style:map references containing 
style");
+pStyle = nullptr;
+}
 if (pStyle)
 {
 if ((pStyle->PrivateGetKey() > -1)) // don't reset pStyle's 
bRemoveAfterUse flag
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - 6 commits - canvas/source external/libxml2 readlicense_oo/license sc/source sw/qa sw/source

2017-08-25 Thread Michael Stahl
 canvas/source/cairo/cairo_textlayout.cxx   
|2 
 canvas/source/vcl/textlayout.cxx   
|2 
 
external/libxml2/0001-Fix-buffer-size-checks-in-xmlSnprintfElementContent.patch.1
  |  116 
 external/libxml2/0001-Fix-handling-of-parameter-entity-references.patch.1  
|  287 
 external/libxml2/0001-Fix-type-confusion-in-xmlValidateOneNamespace.patch.1
|   43 
 
external/libxml2/0001-Increase-buffer-space-for-port-in-HTTP-redirect-supp.patch.1
 |   31 
 external/libxml2/0001-Prevent-unwanted-external-entity-reference.patch.1   
|   35 
 external/libxml2/UnpackedTarball_xml2.mk   
|5 
 readlicense_oo/license/CREDITS.fodt
| 9111 +-
 sc/source/core/tool/scmatrix.cxx   
|   17 
 sw/qa/extras/ooxmlexport/data/tdf98700_keepWithNext.odt
|binary
 sw/qa/extras/ooxmlexport/ooxmlexport9.cxx  
|9 
 sw/source/core/doc/DocumentContentOperationsManager.cxx
|3 
 sw/source/filter/ww8/docxattributeoutput.cxx   
|6 
 14 files changed, 5192 insertions(+), 4475 deletions(-)

New commits:
commit abfc3e252b19fb3cc6736182e27a53ef0252e7a7
Author: Michael Stahl 
Date:   Wed Aug 23 12:10:38 2017 +0200

libxml2: bunch of CVE fixes

Change-Id: Ic786fef17cbdb574c342925a4c57875123ef3151
(cherry picked from commit 486d3b214c270fbd2651a0b0895d600e0f647750)
Reviewed-on: https://gerrit.libreoffice.org/41460
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 
(cherry picked from commit 706ff0383f865b67d97bffb7f47e54645517c484)

diff --git 
a/external/libxml2/0001-Fix-buffer-size-checks-in-xmlSnprintfElementContent.patch.1
 
b/external/libxml2/0001-Fix-buffer-size-checks-in-xmlSnprintfElementContent.patch.1
new file mode 100644
index ..047c88d943a7
--- /dev/null
+++ 
b/external/libxml2/0001-Fix-buffer-size-checks-in-xmlSnprintfElementContent.patch.1
@@ -0,0 +1,116 @@
+From 932cc9896ab41475d4aa429c27d9afd175959d74 Mon Sep 17 00:00:00 2001
+From: Nick Wellnhofer 
+Date: Sat, 3 Jun 2017 02:01:29 +0200
+Subject: [PATCH] Fix buffer size checks in xmlSnprintfElementContent
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+xmlSnprintfElementContent failed to correctly check the available
+buffer space in two locations.
+
+Fixes bug 781333 (CVE-2017-9047) and bug 781701 (CVE-2017-9048).
+
+Thanks to Marcel Böhme and Thuan Pham for the report.
+---
+ result/valid/781333.xml |  5 +
+ result/valid/781333.xml.err |  3 +++
+ result/valid/781333.xml.err.rdr |  6 ++
+ test/valid/781333.xml   |  4 
+ valid.c | 20 +++-
+ 5 files changed, 29 insertions(+), 9 deletions(-)
+ create mode 100644 result/valid/781333.xml
+ create mode 100644 result/valid/781333.xml.err
+ create mode 100644 result/valid/781333.xml.err.rdr
+ create mode 100644 test/valid/781333.xml
+
+diff --git a/result/valid/781333.xml b/result/valid/781333.xml
+new file mode 100644
+index ..45dc451d
+--- /dev/null
 b/result/valid/781333.xml
+@@ -0,0 +1,5 @@
++
++
++]>
++
+diff --git a/result/valid/781333.xml.err b/result/valid/781333.xml.err
+new file mode 100644
+index ..b401b49a
+--- /dev/null
 b/result/valid/781333.xml.err
+@@ -0,0 +1,3 @@
++./test/valid/781333.xml:4: element a: validity error : Element a content does 
not follow the DTD, expecting ( ..., got 
++
++^
+diff --git a/result/valid/781333.xml.err.rdr b/result/valid/781333.xml.err.rdr
+new file mode 100644
+index ..5ff56992
+--- /dev/null
 b/result/valid/781333.xml.err.rdr
+@@ -0,0 +1,6 @@
++./test/valid/781333.xml:4: element a: validity error : Element a content does 
not follow the DTD, expecting ( ..., got 
++
++^
++./test/valid/781333.xml:5: element a: validity error : Element a content does 
not follow the DTD, Expecting more child
++
++^
+diff --git a/test/valid/781333.xml b/test/valid/781333.xml
+new file mode 100644
+index ..b29e5a68
+--- /dev/null
 b/test/valid/781333.xml
+@@ -0,0 +1,4 @@
++
++]>
++
+diff --git a/valid.c b/valid.c
+index 19f84b82..9b2df56a 100644
+--- a/valid.c
 b/valid.c
+@@ -1262,22 +1262,23 @@ xmlSnprintfElementContent(char *buf, int size, 
xmlElementContentPtr content, int
+ case XML_ELEMENT_CONTENT_PCDATA:
+ strcat(buf, "#PCDATA");
+   break;
+-  case XML_ELEMENT_CONTENT_ELEMENT:
++  case XML_ELEMENT_CONTENT_ELEMENT: {
++int qnameLen = xmlStrlen(content->name);
++
++  if (content->prefix != NULL)
++qnameLen += 

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sw/qa xmloff/source

2017-08-25 Thread Michael Stahl
 sw/qa/core/data/odt/fail/82fff64a-0a21-4b09-bbdc-2914a5a150f0.odt |binary
 xmloff/source/style/xmlnumfi.cxx  |5 +
 2 files changed, 5 insertions(+)

New commits:
commit f07bb0fed885f7a13c08f2bc3203e727db7cef1c
Author: Michael Stahl 
Date:   Thu Aug 24 13:56:35 2017 +0200

tdf#111934 xmloff: ODF import: self-referential conditional style crash

It's invalid input and also causes stack overflow.

(cherry picked from commit 9fe857b7bd126ff4856fc4689d375881653b97a2)

tdf#111934: add document for filters-tests
Thanks to infostu...@gmail.com for the document; unfortunately git
tells me that i can't set the commit author to just an email address.
(cherry picked from commit 6e090b4272b8fa12d2032ff0c0ea4bfb24c0d2d2)

Change-Id: Ie0b9dcaefcfcf254326151f345f4802ed66b994d
Reviewed-on: https://gerrit.libreoffice.org/41535
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/qa/core/data/odt/fail/82fff64a-0a21-4b09-bbdc-2914a5a150f0.odt 
b/sw/qa/core/data/odt/fail/82fff64a-0a21-4b09-bbdc-2914a5a150f0.odt
new file mode 100644
index ..7d823df75213
Binary files /dev/null and 
b/sw/qa/core/data/odt/fail/82fff64a-0a21-4b09-bbdc-2914a5a150f0.odt differ
diff --git a/xmloff/source/style/xmlnumfi.cxx b/xmloff/source/style/xmlnumfi.cxx
index ccd8158ead14..85c6cfe47289 100644
--- a/xmloff/source/style/xmlnumfi.cxx
+++ b/xmloff/source/style/xmlnumfi.cxx
@@ -1692,6 +1692,11 @@ sal_Int32 
SvXMLNumFormatContext::CreateAndInsert(SvNumberFormatter* pFormatter)
 {
 SvXMLNumFormatContext* pStyle = const_cast( 
static_cast(pStyles->FindStyleChildContext(
 XML_STYLE_FAMILY_DATA_STYLE, aMyConditions[i].sMapName)));
+if (this == pStyle)
+{
+SAL_INFO("xmloff.style", "invalid style:map references containing 
style");
+pStyle = nullptr;
+}
 if (pStyle)
 {
 if ((pStyle->PrivateGetKey() > -1)) // don't reset pStyle's 
bRemoveAfterUse flag
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: 2 commits - hwpfilter/source sw/source

2017-08-25 Thread Caolán McNamara
 hwpfilter/source/drawing.h   |2 --
 hwpfilter/source/hiodev.cxx  |3 ++-
 sw/source/filter/ww8/ww8scan.cxx |2 +-
 3 files changed, 3 insertions(+), 4 deletions(-)

New commits:
commit 682f05f0b04f0f6949fbd220140964006dd7cbe6
Author: Caolán McNamara 
Date:   Thu Aug 10 16:56:13 2017 +0100

ofz#2899 increment pos before check, like all the other cases

Change-Id: Id49f747e36f767a3e82fc3610959eb94015a93d7
Reviewed-on: https://gerrit.libreoffice.org/40984
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/hwpfilter/source/drawing.h b/hwpfilter/source/drawing.h
index 4f990b0de813..0b8191a24a5b 100644
--- a/hwpfilter/source/drawing.h
+++ b/hwpfilter/source/drawing.h
@@ -318,8 +318,6 @@ static bool LoadCommonHeader(HWPDrawingObject * hdo, 
unsigned short * link_info)
 
 static HWPDrawingObject *LoadDrawingObject(void)
 {
-fprintf(stderr, "LoadDrawingObject\n");
-
 HWPDrawingObject *hdo, *head, *prev;
 
 unsigned short link_info;
diff --git a/hwpfilter/source/hiodev.cxx b/hwpfilter/source/hiodev.cxx
index 4df1344ea8df..91477a265d72 100644
--- a/hwpfilter/source/hiodev.cxx
+++ b/hwpfilter/source/hiodev.cxx
@@ -305,9 +305,10 @@ bool HMemIODev::setCompressed(bool )
 
 bool HMemIODev::read1b(unsigned char )
 {
+++pos;
 if (pos <= length)
 {
-out = ptr[pos++];
+out = ptr[pos - 1];
 return true;
 }
 return false;
commit 35bac83ed2b5d48233c653cc7dc4eab5c234f7ac
Author: Caolán McNamara 
Date:   Mon Aug 7 19:24:37 2017 +0100

ofz#2877: crash in SVTB16Short

sal_uInt16 wraparound

Change-Id: Ifd791bdd5f1b96576fdd4ca6665bb972fb8b1e4c
Reviewed-on: https://gerrit.libreoffice.org/40848
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/filter/ww8/ww8scan.cxx b/sw/source/filter/ww8/ww8scan.cxx
index 5d82f5d61706..726d2094c31f 100644
--- a/sw/source/filter/ww8/ww8scan.cxx
+++ b/sw/source/filter/ww8/ww8scan.cxx
@@ -3493,7 +3493,7 @@ bool WW8PLCFx_SEPX::Find4Sprms(sal_uInt16 nId1,sal_uInt16 
nId2,sal_uInt16 nId3,s
 bool bFound = false;
 
 sal_uInt8* pSp = pSprms.get();
-sal_uInt16 i=0;
+size_t i = 0;
 while (i + maSprmParser.MinSprmLen() <= nSprmSiz)
 {
 // Sprm found?
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 103859] [META] EMF/WMF (Enhanced/Windows Metafile) bugs and enhancements

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103859

Buovjaga  changed:

   What|Removed |Added

 Depends on||112030


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=112030
[Bug 112030] EMF gradients are blocky on Linux
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112030] New: EMF gradients are blocky on Linux

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112030

Bug ID: 112030
   Summary: EMF gradients are blocky on Linux
   Product: LibreOffice
   Version: 5.2.7.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Keywords: bibisectRequest, regression
  Severity: normal
  Priority: medium
 Component: filters and storage
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: todven...@suomi24.fi
Blocks: 103859

Download attachment 67335 from bug 55058 and open on Linux.

The gradients are not blocky on 3.6.

Armin said they look the same on 5.2 and current, I confirm blockiness on 5.4
and master.

Arch Linux 64-bit
Version 3.6.7.2 (Build ID: e183d5b)

Arch Linux 64-bit, KDE Plasma 5
Version: 6.0.0.0.alpha0+
Build ID: 485fcd4f367ebdf5a7494976424e64c7c68ff450
CPU threads: 8; OS: Linux 4.12; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on August 25th 2017


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103859
[Bug 103859] [META] EMF/WMF (Enhanced/Windows Metafile) bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: 4 commits - filter/source sal/textenc sw/qa vcl/source

2017-08-25 Thread Caolán McNamara
 filter/source/graphicfilter/itiff/itiff.cxx |2 +-
 sal/textenc/tcvtkr6.tab |4 ++--
 sw/qa/extras/ww8export/ww8export2.cxx   |1 +
 vcl/source/app/svmain.cxx   |   25 -
 4 files changed, 20 insertions(+), 12 deletions(-)

New commits:
commit 969838675cfd42bdfc27ee12d796dece59c3d5a3
Author: Caolán McNamara 
Date:   Fri Aug 4 09:45:40 2017 +0100

ofz#2852 korean table entries start at 0xF not 0x7

Change-Id: Iaf3ed48d0eb0e5a57770af057c565a7310bb96d4
Reviewed-on: https://gerrit.libreoffice.org/40761
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sal/textenc/tcvtkr6.tab b/sal/textenc/tcvtkr6.tab
index de68d624f8b2..e03f3405e811 100644
--- a/sal/textenc/tcvtkr6.tab
+++ b/sal/textenc/tcvtkr6.tab
@@ -388,7 +388,7 @@ static ImplUniToDBCSHighTab const aKSC5601DBCSHighTab[256] =
 { 0x07, 0xFE, aImplUniToDBCSTab_KSC5601_5D },   /* 0x5D */
 { 0x02, 0xFB, aImplUniToDBCSTab_KSC5601_5E },   /* 0x5E */
 { 0x01, 0xFF, aImplUniToDBCSTab_KSC5601_5F },   /* 0x5F */
-{ 0x07, 0xFB, aImplUniToDBCSTab_KSC5601_60 },   /* 0x60 */
+{ 0x0F, 0xFB, aImplUniToDBCSTab_KSC5601_60 },   /* 0x60 */
 { 0x01, 0xFF, aImplUniToDBCSTab_KSC5601_61 },   /* 0x61 */
 { 0x00, 0xFF, aImplUniToDBCSTab_KSC5601_62 },   /* 0x62 */
 { 0x01, 0xF7, aImplUniToDBCSTab_KSC5601_63 },   /* 0x63 */
@@ -1020,7 +1020,7 @@ static ImplUniToDBCSHighTab const aJOHABDBCSHighTab[256] =
 { 0x07, 0xFE, aImplUniToDBCSTab_JOHAB_5D }, /* 0x5D */
 { 0x02, 0xFB, aImplUniToDBCSTab_JOHAB_5E }, /* 0x5E */
 { 0x01, 0xFF, aImplUniToDBCSTab_JOHAB_5F }, /* 0x5F */
-{ 0x07, 0xFB, aImplUniToDBCSTab_JOHAB_60 }, /* 0x60 */
+{ 0x0F, 0xFB, aImplUniToDBCSTab_JOHAB_60 }, /* 0x60 */
 { 0x01, 0xFF, aImplUniToDBCSTab_JOHAB_61 }, /* 0x61 */
 { 0x00, 0xFF, aImplUniToDBCSTab_JOHAB_62 }, /* 0x62 */
 { 0x01, 0xF7, aImplUniToDBCSTab_JOHAB_63 }, /* 0x63 */
commit c2e7df1ce8ba50b2179904963e825315785585e4
Author: Caolán McNamara 
Date:   Fri Jul 28 10:07:50 2017 +0100

ofz#2766 ensure palette is large enough for all colors

Change-Id: I4669b473f5975ac74a37025f7c936f13bcfea420
Reviewed-on: https://gerrit.libreoffice.org/40511
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/filter/source/graphicfilter/itiff/itiff.cxx 
b/filter/source/graphicfilter/itiff/itiff.cxx
index f785ab5a7666..65db2efaa6d9 100644
--- a/filter/source/graphicfilter/itiff/itiff.cxx
+++ b/filter/source/graphicfilter/itiff/itiff.cxx
@@ -1128,7 +1128,6 @@ void TIFFReader::MakePalCol()
 nNumColors = nLargestPixelIndex + 1;
 }
 
-pAcc->SetPaletteEntryCount(nNumColors);
 for (sal_uInt32 i = 0; i < nNumColors; ++i)
 {
 sal_uInt32 nVal = ( i * 255 / ( nNumColors - 1 ) ) & 0xff;
@@ -1139,6 +1138,7 @@ void TIFFReader::MakePalCol()
 xColorMap[nNumColors - i - 1] = n0RGB;
 }
 }
+pAcc->SetPaletteEntryCount(std::max(nNumColors, 
pAcc->GetPaletteEntryCount()));
 for (sal_uInt32 i = 0; i < nNumColors; ++i)
 {
 pAcc->SetPaletteColor(i, BitmapColor( (sal_uInt8)( xColorMap[ i ] 
>> 16 ),
commit 5e975f671bc37d837d66e712ea064809daf51288
Author: Caolán McNamara 
Date:   Fri Aug 25 10:39:21 2017 +0100

coverity#1416668 Uncaught exception

Change-Id: Ibc2be8fe44295a8ea08105549448609e00262740
Reviewed-on: https://gerrit.libreoffice.org/41560
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/source/app/svmain.cxx b/vcl/source/app/svmain.cxx
index 1b88fc290157..a8e42ad394d7 100644
--- a/vcl/source/app/svmain.cxx
+++ b/vcl/source/app/svmain.cxx
@@ -322,15 +322,22 @@ bool InitVCL()
 pSVData->mpApp->Init();
 }
 
-//Now that uno has been bootstrapped we can ask the config what the UI 
language is so that we can
-//force that in as $LANGUAGE. That way we can get gtk to render widgets RTL
-//if we have a RTL UI in an otherwise LTR locale and get gettext using 
externals (e.g. python)
-//to match their translations to our preferred UI language
-OUString 
aLocaleString(SvtSysLocaleOptions().GetRealUILanguageTag().getGlibcLocaleString(".UTF-8"));
-if (!aLocaleString.isEmpty())
-{
-OUString envVar("LANGUAGE");
-osl_setEnvironment(envVar.pData, 

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - ec/d7e16c6d6277530879ed11e752d000248c56c7

2017-08-25 Thread Caolán McNamara
 ec/d7e16c6d6277530879ed11e752d000248c56c7 |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 90f239e073fa6534d6cbff702c94e7d71ed4de6b
Author: Caolán McNamara 
Date:   Fri Aug 25 18:33:23 2017 +0100

Notes added by 'git notes add'

diff --git a/ec/d7e16c6d6277530879ed11e752d000248c56c7 
b/ec/d7e16c6d6277530879ed11e752d000248c56c7
new file mode 100644
index ..55932f87fbb9
--- /dev/null
+++ b/ec/d7e16c6d6277530879ed11e752d000248c56c7
@@ -0,0 +1 @@
+merged as: afa71c58f13726a76f7b0d46b6e834403ac8f97b
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sc/source

2017-08-25 Thread Caolán McNamara
 sc/source/ui/dataprovider/dataprovider.cxx |9 +
 1 file changed, 5 insertions(+), 4 deletions(-)

New commits:
commit 90beace1e0a67027f4830510840b4aff14bb
Author: Caolán McNamara 
Date:   Fri Aug 25 10:33:40 2017 +0100

coverity#1416669 Uninitialized scalar field

Change-Id: Ibc202057c50391bb82779c82616f628060041fb9
Reviewed-on: https://gerrit.libreoffice.org/41559
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/source/ui/dataprovider/dataprovider.cxx 
b/sc/source/ui/dataprovider/dataprovider.cxx
index f7631107abf2..75a3111bd475 100644
--- a/sc/source/ui/dataprovider/dataprovider.cxx
+++ b/sc/source/ui/dataprovider/dataprovider.cxx
@@ -57,10 +57,11 @@ std::unique_ptr 
DataProvider::FetchStreamFromURL(const OUString& rURL,
 }
 
 ExternalDataSource::ExternalDataSource(const OUString& rURL,
-const OUString& rProvider, ScDocument* pDoc):
-maURL(rURL),
-maProvider(rProvider),
-mpDoc(pDoc)
+const OUString& rProvider, ScDocument* pDoc)
+: maURL(rURL)
+, maProvider(rProvider)
+, mnUpdateFrequency(0.0)
+, mpDoc(pDoc)
 {
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 111894] PaletteManager::LoadPalettes() leaks memory

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=111894

--- Comment #4 from Telesto  ---
Another example where PaletteManager::LoadPalettes() is leaking:
1. Open Writer
2. Add a table with a few cells
3. Open the context menu (for me right click) -> Table properties -> Background
Tab --> Select a cell color
4. Select a different cell repeat step 3.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: offapi/com

2017-08-25 Thread Damjan Jovanovic
 offapi/com/sun/star/sdbc/SQLException.idl |2 --
 1 file changed, 2 deletions(-)

New commits:
commit afa71c58f13726a76f7b0d46b6e834403ac8f97b
Author: Damjan Jovanovic 
Date:   Wed Aug 16 16:26:08 2017 +

Remove some incorrect API documentation for the

com.sun.star.sdbc.SQLException ErrorCode field.

Patch by: me

(cherry picked from commit ecd7e16c6d6277530879ed11e752d000248c56c7)

Change-Id: I45fb25f1447fd6d37a38e80879de663ab3dbba99
Reviewed-on: https://gerrit.libreoffice.org/41568
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/offapi/com/sun/star/sdbc/SQLException.idl 
b/offapi/com/sun/star/sdbc/SQLException.idl
index f34f7964eb37..bd2658334467 100644
--- a/offapi/com/sun/star/sdbc/SQLException.idl
+++ b/offapi/com/sun/star/sdbc/SQLException.idl
@@ -50,8 +50,6 @@ published exception SQLException: 
com::sun::star::uno::Exception
 
 /** returns an integer error code that is specific to each vendor.  
Normally this will
 be the actual error code returned by the underlying database.
-A chain to the next Exception.  This can be used to provide additional
-error information.
  */
 longErrorCode;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 112013] impossible to run V5.35 after install; impossible to save file in V5.4 ==> crash

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112013

Telesto  changed:

   What|Removed |Added

 Status|NEW |UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112028] ReleasePoolHolder() doesn't completely release all objects

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112028

Telesto  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||tele...@surfxs.nl
 Ever confirmed|0   |1

--- Comment #4 from Telesto  ---
Confirming with 5.4.1.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 6d/d83d1c6c5c580d14ca3d0458be4020603ba118

2017-08-25 Thread Caolán McNamara
 6d/d83d1c6c5c580d14ca3d0458be4020603ba118 |1 +
 1 file changed, 1 insertion(+)

New commits:
commit f9f51a75264e7953021be8b9ca853455e2c33c0b
Author: Caolán McNamara 
Date:   Fri Aug 25 18:26:46 2017 +0100

Notes added by 'git notes add'

diff --git a/6d/d83d1c6c5c580d14ca3d0458be4020603ba118 
b/6d/d83d1c6c5c580d14ca3d0458be4020603ba118
new file mode 100644
index ..d8fb3501315f
--- /dev/null
+++ b/6d/d83d1c6c5c580d14ca3d0458be4020603ba118
@@ -0,0 +1 @@
+merged as: 3f84390f585cf71331a77ab5ca632cacaf3ad7b9
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 6b/62e035d388ce14630da65d63db5a216e1848e7

2017-08-25 Thread Caolán McNamara
 6b/62e035d388ce14630da65d63db5a216e1848e7 |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 3849da44905debe88ca64ec43379f55800243134
Author: Caolán McNamara 
Date:   Fri Aug 25 18:24:46 2017 +0100

Notes added by 'git notes add'

diff --git a/6b/62e035d388ce14630da65d63db5a216e1848e7 
b/6b/62e035d388ce14630da65d63db5a216e1848e7
new file mode 100644
index ..987f049f7e5e
--- /dev/null
+++ b/6b/62e035d388ce14630da65d63db5a216e1848e7
@@ -0,0 +1 @@
+merged as: 8e246b5cccadbac1e6d6c39fcd2a872727683f75
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: ridljar/com

2017-08-25 Thread Damjan Jovanovic
 ridljar/com/sun/star/uno/UnoRuntime.java |   14 +-
 1 file changed, 13 insertions(+), 1 deletion(-)

New commits:
commit 3f84390f585cf71331a77ab5ca632cacaf3ad7b9
Author: Damjan Jovanovic 
Date:   Sun Aug 20 06:22:29 2017 +

i#32546# - Java UnoRuntime.getUniqueKey/generateOid do not work reliably

In the Java UNO bridge, UnoRuntime.generateOid() generated the
object-specific part of the OID using java.lang.Object.hashCode(),
which is only 32 bits long, and is commonly overriden and could thus
return values from an even smaller range, so OID collisions were quite
likely.

This changes UnoRuntime.generateOid() to use 128 bit UUIDs for the
object-specific part of the OID, and store these in an object => oid
java.util.WeakHashMap, making OID collisions almost impossible.

Patch by: me
Suggested by: Stephan Bergmann (stephan dot bergmann dot secondary at
googlemail dot com)

(cherry picked from commit 6dd83d1c6c5c580d14ca3d0458be4020603ba118)

Change-Id: I8e851a7a69ac2defefa15e9a00118d8f9fc0da95
Reviewed-on: https://gerrit.libreoffice.org/41576
Reviewed-by: Stephan Bergmann 
Reviewed-by: Noel Grandin 
Tested-by: Jenkins 

diff --git a/ridljar/com/sun/star/uno/UnoRuntime.java 
b/ridljar/com/sun/star/uno/UnoRuntime.java
index 1cba9d8b0258..99da56aa9ea8 100644
--- a/ridljar/com/sun/star/uno/UnoRuntime.java
+++ b/ridljar/com/sun/star/uno/UnoRuntime.java
@@ -23,6 +23,8 @@ import java.lang.reflect.Array;
 import java.lang.reflect.Constructor;
 import java.util.ArrayList;
 import java.util.Iterator;
+import java.util.UUID;
+import java.util.WeakHashMap;
 
 import com.sun.star.lib.uno.typedesc.FieldDescription;
 import com.sun.star.lib.uno.typedesc.TypeDescription;
@@ -106,7 +108,16 @@ public class UnoRuntime {
 if (object instanceof IQueryInterface) {
 oid = ((IQueryInterface) object).getOid();
 }
-return oid == null ? object.hashCode() + oidSuffix : oid;
+if (oid == null) {
+synchronized (oidMap) {
+ oid = oidMap.get(object);
+ if (oid == null) {
+ oid = UUID.randomUUID().toString() + oidSuffix;
+ oidMap.put(object, oid);
+ }
+}
+}
+return oid;
 }
 
 /**
@@ -690,6 +701,7 @@ public class UnoRuntime {
 private final IBridge bridge;
 }
 
+private static final WeakHashMap oidMap = new 
WeakHashMap();
 private static final String uniqueKeyHostPrefix
 = Integer.toString(new Object().hashCode(), 16) + ":";
 private static final Object uniqueKeyLock = new Object();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 111760] Crash when closing the save dialog after the main window ( gtk3)

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=111760

--- Comment #11 from Armin Le Grand (CIB)  ---
Bonjour Jean-Baptiste,

need to check deeper, but at least there is a mechanism now that would allow to
fix that task.

Regrads, Armin (alg)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 111332] Formulas not localized

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=111332

--- Comment #18 from Jacques Guilleron  ---
Hi all,

All localization issues are solved in french UI of
LO 5.3.6.1 Build ID: 686f202eff87ef707079aeb7f485847613344eb7
Threads CPU : 2; Version de l'OS :Windows 6.1; UI Render : par défaut; Moteur
de mise en page : nouveau; 
Locale : fr-FR (fr_FR); Calc: CL
It seems to be the same with italian and german UI.
I only verified formulas translation in those languages.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 111723] Area dialog: Dialog does not remember which tab page was openned last time

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=111723

Tamás Zolnai  changed:

   What|Removed |Added

   Keywords||difficultyBeginner,
   ||easyHack, skillCpp
 CC||mentoring@documentfoundatio
   ||n.org

--- Comment #2 from Tamás Zolnai  ---
Let's turn this into a easy hack. The code is here:
cui/source/tabpages/tabarea.cxx

An example dialog which works as expected is not Position and Size dialog in
the same context menu). It's code is here:
cui/source/tabpages/transfrm.cxx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112017] FILEOPEN: Crash with Application Error when opening file with nested draw elements

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112017

--- Comment #8 from Julien Nabet  ---
Created attachment 135798
  --> https://bugs.documentfoundation.org/attachment.cgi?id=135798=edit
bt from xml error

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93245] add buttons to increase / decrease font size (speaker notes)

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93245

Adolfo Jayme  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Adolfo Jayme  ---
→ NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108381] [META] Notes view bugs and enhancements

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108381
Bug 108381 depends on bug 108926, which changed state.

Bug 108926 Summary: Notes placeholder text boxes not shown in PPTs
https://bugs.documentfoundation.org/show_bug.cgi?id=108926

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 55058] List of EMF import bugs with examples

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=55058

--- Comment #30 from mathog  ---
My most recent EMF, EMF+, and WMF test files have been uploaded, along with
images of each made on Windows XP using "Windows Preview".  In many instances
to see what is actually going on, for instance line end treatments, it is
necessary to zoom in with the actual viewer.  Current versions of Inkscape can
also be used to view the EMF and WMF files and it is, to the best of my
ability, 1:1 with the Windows XP Preview image.  Inkscape does not yet have
EMF+ display.  The code to generate these test files and other related EMF,
EMF+, WMF code is at:

  https://sourceforge.net/projects/libuemf/

If anybody reading this knows how to properly handle files containing mixtures
of EMF and EMF+ records please contact me or post a link to the section of the
relevant Microsoft documentation.  An EMF document may contain an object
described in both EMF and EMF+ records and there is no obvious way to determine
which EMF object description corresponds to which EMF+ object description.  So
as far as I can tell it seems the only safe thing to do is to either render
just the EMF records or just the EMF+ records.  However, some applications
(like some versions of PowerPoint) will render everything in a diagram to an
EMF file as both EMF and EMF+ records except the text, which is EMF only.  So
that the EMF+ description in the EMF file is always incomplete.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 66792] UI: Better integration of font styles into the toolbar

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=66792

Adolfo Jayme  changed:

   What|Removed |Added

URL||https://alistapart.com/arti
   ||cle/user-interfaces-for-var
   ||iable-fonts

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 66792] UI: Better integration of font styles into the toolbar

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=66792

Adolfo Jayme  changed:

   What|Removed |Added

URL||https://alistapart.com/arti
   ||cle/user-interfaces-for-var
   ||iable-fonts

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 112017] FILEOPEN: Crash with Application Error when opening file with nested draw elements

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112017

--- Comment #7 from Julien Nabet  ---
Oups + this:
warn:sw.uno:13512:1:sw/source/filter/xml/xmltexti.cxx:188: SwXTextCursor
missing
warn:xmloff:13512:1:xmloff/source/core/xmlerror.cxx:169: An error or a warning
has occurred during XML import/export!
Error-Id: 0x20040004
Flags: 2 ERROR
Class: 4 API
Number: 4
Parameters:
0: com.sun.star.drawing.RectangleShape
Exception-Message: 
Position:
Public Identifier: 
System Identifier: 
Row, Column: 7,0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112017] FILEOPEN: Crash with Application Error when opening file with nested draw elements

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112017

--- Comment #6 from Julien Nabet  ---
As indicated in the bt, I noticed this log on console:
warn:sw.uno:13512:1:sw/source/filter/xml/xmltexti.cxx:188: SwXTextCursor
missing

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112017] FILEOPEN: Crash with Application Error when opening file with nested draw elements

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112017

Julien Nabet  changed:

   What|Removed |Added

   Keywords||haveBacktrace
   Severity|normal  |major

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112017] FILEOPEN: Crash with Application Error when opening file with nested draw elements

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112017

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #5 from Julien Nabet  ---
Created attachment 135797
  --> https://bugs.documentfoundation.org/attachment.cgi?id=135797=edit
bt with debug symbols

On pc Debian x86-64 with master sources updated today, I could reproduce this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 55058] List of EMF import bugs with examples

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=55058

--- Comment #29 from mathog  ---
Created attachment 135796
  --> https://bugs.documentfoundation.org/attachment.cgi?id=135796=edit
WMF test file, version 0.2.2, in Windows Preview

WMF test file, version 0.2.2, as seen in Windows XP Preview

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 55058] List of EMF import bugs with examples

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=55058

--- Comment #28 from mathog  ---
Created attachment 135795
  --> https://bugs.documentfoundation.org/attachment.cgi?id=135795=edit
WMF test file, version 0.2.2

WMF test file, version 0.2.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 55058] List of EMF import bugs with examples

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=55058

--- Comment #27 from mathog  ---
Created attachment 135794
  --> https://bugs.documentfoundation.org/attachment.cgi?id=135794=edit
EMF+ test file, version 0.2.1, in Windows Preview

EMF+ test file, version 0.2.1, as seen in Windows XP Preview

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 55058] List of EMF import bugs with examples

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=55058

--- Comment #26 from mathog  ---
Created attachment 135793
  --> https://bugs.documentfoundation.org/attachment.cgi?id=135793=edit
EMF+ test file, version 0.2.1

EMF+ test file, version 0.2.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 55058] List of EMF import bugs with examples

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=55058

mathog  changed:

   What|Removed |Added

  Attachment #67336|0   |1
is obsolete||

--- Comment #25 from mathog  ---
Created attachment 135792
  --> https://bugs.documentfoundation.org/attachment.cgi?id=135792=edit
EMF test file, version 0.2.2 in Windows Preview

Windows XP Preview of 0.2.2 EMF test file.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 55058] List of EMF import bugs with examples

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=55058

mathog  changed:

   What|Removed |Added

  Attachment #67335|0   |1
is obsolete||
 Attachment #116589|0   |1
is obsolete||

--- Comment #24 from mathog  ---
Created attachment 135791
  --> https://bugs.documentfoundation.org/attachment.cgi?id=135791=edit
EMF test file, version 0.2.2

Most recent EMF test file.  Pure EMF, no EMF+.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 55058] List of EMF import bugs with examples

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=55058

--- Comment #23 from Buovjaga  ---
(In reply to Armin Le Grand (CIB) from comment #22)
> Looks pretty much the same on 5.2 and current, indeed has nothing to do with
> EMF+ stuff, but is an older error in EMF import - which itself was never
> complete or error-free.

Aargh, you are right: I see the problem with 5.4 on Linux (but not on 3.6). I
should open a new report for the regression.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 55058] List of EMF import bugs with examples

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=55058

--- Comment #22 from Armin Le Grand (CIB)  ---
Looks pretty much the same on 5.2 and current, indeed has nothing to do with
EMF+ stuff, but is an older error in EMF import - which itself was never
complete or error-free.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 55058] List of EMF import bugs with examples

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=55058

--- Comment #21 from Armin Le Grand (CIB)  ---
Short check with the Metafile-to-Primitive converter: The file from comment 14
indeed is a pure emf file, containing no EMF+ parts at all. Thus it should look
identical in older versions, checking...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 55058] List of EMF import bugs with examples

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=55058

--- Comment #20 from Patrick Jaap  ---
The broken gradients of attachment 67335 are produced by a
MetaActionType::BMPSCALE which is really strange. Either the MetaAction
contains a broken Bitmap or the subsequent BitmapPrimitive2D does something
wrong. It has definitely nothing to do with EMF+ gradients.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: unoxml/source

2017-08-25 Thread Michael Stahl
 unoxml/source/dom/documentbuilder.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit ae3ba018bfe066854fd787e2938441e4cc1316e1
Author: Michael Stahl 
Date:   Fri Aug 25 13:31:25 2017 +0200

unoxml: CDocumentBuilder: just catch all Exception

Turns out that XErrorHandler can throw SAXException too, which isn't
derived from RuntimeException.

Change-Id: Ib853805259b5b32a979e4f9a20297975431dee08

diff --git a/unoxml/source/dom/documentbuilder.cxx 
b/unoxml/source/dom/documentbuilder.cxx
index e8eb6097c23d..0b5aa5d583d7 100644
--- a/unoxml/source/dom/documentbuilder.cxx
+++ b/unoxml/source/dom/documentbuilder.cxx
@@ -292,7 +292,7 @@ namespace DOM
 
pDocBuilder->getErrorHandler()->warning(::css::uno::Any(saxex));
 }
 }
-catch (const css::uno::RuntimeException )
+catch (const css::uno::Exception )
 {
 // Protect lib2xml from UNO Exception
 SAL_WARN("unoxml",
@@ -326,7 +326,7 @@ namespace DOM
 pDocBuilder->getErrorHandler()->error(::css::uno::Any(saxex));
 }
 }
-catch (const css::uno::RuntimeException )
+catch (const css::uno::Exception )
 {
 // Protect lib2xml from UNO Exception
 SAL_WARN("unoxml",
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Changes to 'private/tbsdy/workbench'

2017-08-25 Thread Chris Sherlock
New branch 'private/tbsdy/workbench' available with the following commits:
commit 47cbb049118c3414341e4ec6dfb77e55813549ac
Author: Chris Sherlock 
Date:   Fri Aug 25 20:57:23 2017 +1000

sal workbench: add signal handler example

Change-Id: I074e07158492676b5a5ff4690e6069054fdf1ed9

commit 531717c045bee150ca3f4f2e3b503ddf59f784f9
Author: Chris Sherlock 
Date:   Mon Aug 14 00:09:51 2017 +1000

sal workben: remove failed experiment

Change-Id: Idf6a421377b1ca21326adff2b9c87e9794c65dda

commit f97280728c951d102490e17e490c32a15dd37ec5
Author: Chris Sherlock 
Date:   Mon Aug 14 00:04:20 2017 +1000

sal workben: set and get an environment variable

Change-Id: Ifcd5eaf2fbc75752e574081dc736ecf4529e5d22

commit d63b7b5daf14ebc1c1fa0529f0f8a9947b4c0431
Author: Chris Sherlock 
Date:   Sun Aug 13 22:55:47 2017 +1000

sal workben: Demonstrate osl_terminateProcess()

Change-Id: I5e7ed1cd08c2d426151afaf4de620b4412c6e9b1

commit 422be01974efd15b734e5818207a2afe9c9b6b47
Author: Chris Sherlock 
Date:   Sun Jul 30 01:31:11 2017 +1000

sal workben: Demonstrate osl_executeProcess()

Change-Id: I7b6e3d89601b78deec7e78f5817a4980b4007ebf

commit ed27ae7dc5088b2d1867ca75f3e57e3ad120ec8e
Author: Chris Sherlock 
Date:   Sat Jul 29 22:46:20 2017 +1000

sal workben: add osl_getCommandArg() and osl_getCommandArgCount()

Change-Id: I624b5454c5e8f86997b35ffc3f8680e353f48006

commit f663c411f20550d3b882aee85f04407e27d292a5
Author: Chris Sherlock 
Date:   Sat Jul 29 02:19:46 2017 +1000

sal workben: demonstrate osl_getProcessInfo()

Change-Id: I366871e6ecc4c768891a6bc9273e84b080cf080c

commit 7cb0fc8ca2ec5bce4900c7d9731d2543481319e5
Author: Chris Sherlock 
Date:   Sat Jul 29 01:50:38 2017 +1000

sal workben: demonstrate osl_getProcessWorkingDir()

Change-Id: I61798ca229bc1078ae075ff119c472d616e995c5

commit a5057557878df2986a9c758d7e094912ce24dcb7
Author: Chris Sherlock 
Date:   Thu Jul 27 22:05:36 2017 +1000

sal workben: sal/config.h example

Change-Id: I8ee9196a743aa9d2fe60308b9883d00e2fc21dcc

commit 66269788a1708d1c79886e823edc2dbe770cc082
Author: Chris Sherlock 
Date:   Thu Jul 27 21:17:23 2017 +1000

sal workben: alloca() example

Change-Id: I387b06065d9ceabfba477ac76a34fd6992c654f8

commit 4fe986ca7260f6c22d4094c47cd1ad0890814221
Author: Chris Sherlock 
Date:   Thu Jul 27 00:11:50 2017 +1000

sal workben: examples of SAL_N_ELEMENTS, SAL_BOUND and SAL_STRINGIFY

Change-Id: Ie1ad3f75ae38697023ef36c851c8b41b713551b0

commit 84105511babfffdd332b9fc5aa407c19a00fb7d9
Author: Chris Sherlock 
Date:   Sun Jul 23 19:15:13 2017 +1000

sal workben: SAL_IMPLEMENT_MAIN and SAL_IMPLEMENT_MAIN_WITH_ARGS examples

Change-Id: I1c04eb6428fbf7998cfdf1c89ab2594c0af4c765

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: writerperfect/Library_wpftwriter.mk writerperfect/source

2017-08-25 Thread Miklos Vajna
 writerperfect/Library_wpftwriter.mk  |2 
 writerperfect/source/writer/exp/txtparai.cxx |   17 -
 writerperfect/source/writer/exp/txtstyli.cxx |   90 +++
 writerperfect/source/writer/exp/txtstyli.hxx |   44 +
 writerperfect/source/writer/exp/xmlfmt.cxx   |   37 +++
 writerperfect/source/writer/exp/xmlfmt.hxx   |   36 ++
 writerperfect/source/writer/exp/xmlimp.cxx   |8 ++
 writerperfect/source/writer/exp/xmlimp.hxx   |4 -
 8 files changed, 235 insertions(+), 3 deletions(-)

New commits:
commit bb4e52096db668533bae40f5155749a9986108a2
Author: Miklos Vajna 
Date:   Fri Aug 25 16:12:03 2017 +0200

EPUB export: add support for page breaks

EPUB_SPLIT_METHOD is still hardcoded to HEADING, so while we send the
page break info to librevenge now, it's ignored on that end.

This requies basic infrastructure for automatic styles.

Change-Id: Ibafead0dedd9dbfa6223a9c701a62611ba2671fd
Reviewed-on: https://gerrit.libreoffice.org/41573
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins 

diff --git a/writerperfect/Library_wpftwriter.mk 
b/writerperfect/Library_wpftwriter.mk
index 9cbef7f31309..67c1d999f887 100644
--- a/writerperfect/Library_wpftwriter.mk
+++ b/writerperfect/Library_wpftwriter.mk
@@ -78,6 +78,8 @@ $(eval $(call gb_Library_add_exception_objects,wpftwriter,\
writerperfect/source/writer/exp/XMLBase64ImportContext \
writerperfect/source/writer/exp/XMLTextFrameContext \
writerperfect/source/writer/exp/txtparai \
+   writerperfect/source/writer/exp/txtstyli \
+   writerperfect/source/writer/exp/xmlfmt \
writerperfect/source/writer/exp/xmlictxt \
writerperfect/source/writer/exp/xmlimp \
writerperfect/source/writer/exp/xmlmetai \
diff --git a/writerperfect/source/writer/exp/txtparai.cxx 
b/writerperfect/source/writer/exp/txtparai.cxx
index 600709d9fec8..e669cf89edf8 100644
--- a/writerperfect/source/writer/exp/txtparai.cxx
+++ b/writerperfect/source/writer/exp/txtparai.cxx
@@ -124,10 +124,23 @@ void XMLParaContext::startElement(const OUString 
&/*rName*/, const css::uno::Ref
 for (sal_Int16 i = 0; i < xAttribs->getLength(); ++i)
 {
 const OUString  = xAttribs->getNameByIndex(i);
-if (rAttributeName != "text:style-name")
+const OUString  = xAttribs->getValueByIndex(i);
+if (rAttributeName == "text:style-name")
+{
+// Reference to an automatic style, try to look it up.
+auto itStyle = mrImport.GetAutomaticStyles().find(rAttributeValue);
+if (itStyle == mrImport.GetAutomaticStyles().end())
+continue;
+
+// Apply properties directly, librevenge has no notion of 
automatic styles.
+librevenge::RVNGPropertyList::Iter itProp(itStyle->second);
+for (itProp.rewind(); itProp.next();)
+aPropertyList.insert(itProp.key(), itProp());
+}
+else
 {
 OString sName = OUStringToOString(rAttributeName, 
RTL_TEXTENCODING_UTF8);
-OString sValue = OUStringToOString(xAttribs->getValueByIndex(i), 
RTL_TEXTENCODING_UTF8);
+OString sValue = OUStringToOString(rAttributeValue, 
RTL_TEXTENCODING_UTF8);
 aPropertyList.insert(sName.getStr(), sValue.getStr());
 }
 }
diff --git a/writerperfect/source/writer/exp/txtstyli.cxx 
b/writerperfect/source/writer/exp/txtstyli.cxx
new file mode 100644
index ..a7460a47c1b6
--- /dev/null
+++ b/writerperfect/source/writer/exp/txtstyli.cxx
@@ -0,0 +1,90 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include "txtstyli.hxx"
+
+#include "xmlimp.hxx"
+
+using namespace com::sun::star;
+
+namespace writerperfect
+{
+namespace exp
+{
+
+/// Handler for .
+class XMLParagraphPropertiesContext : public XMLImportContext
+{
+public:
+XMLParagraphPropertiesContext(XMLImport , XMLStyleContext );
+
+void SAL_CALL startElement(const OUString , const 
css::uno::Reference ) override;
+
+private:
+XMLStyleContext 
+};
+
+XMLParagraphPropertiesContext::XMLParagraphPropertiesContext(XMLImport 
, XMLStyleContext )
+: XMLImportContext(rImport)
+, mrStyle(rStyle)
+{
+}
+
+void XMLParagraphPropertiesContext::startElement(const OUString &/*rName*/, 
const css::uno::Reference )
+{
+for (sal_Int16 i = 0; i < xAttribs->getLength(); ++i)
+{
+OString sName = OUStringToOString(xAttribs->getNameByIndex(i), 
RTL_TEXTENCODING_UTF8);
+OString sValue = OUStringToOString(xAttribs->getValueByIndex(i), 

[Libreoffice-bugs] [Bug 55058] List of EMF import bugs with examples

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=55058

--- Comment #19 from Buovjaga  ---
(In reply to Patrick Jaap from comment #18)
> Hi, attachment 67335 [details] does not contain any EMF+ records, it is just
> pure EMF. But I can take a look into the EMF parsing, there seems to be
> something wrong with the color choice.

It is weird.. I am seeing the blockiness on Linux but not on Windows (build
from 24th).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: tdf#109097 - mdds accelerating random lookups

2017-08-25 Thread Eike Rathke
Hi Dennis,

On Thursday, 2017-08-24 15:33:26 +0530, Dennis Francis wrote:

> One way to improve the situation is
> to store absolute
> position of first element of each block in the block instead of the block
> size member. This
> can improve the lookup time up to log(log(N)) using linear interpolation
> search or at least log(N)
> if we fallback to binary search after a few initial passes of
> linear-interpolation search.
> 
> Down side of this approach is that in the worst case, insert/deletes incur
> O(N) cost because
> absolute positions stored in each block subsequent to the delete/insert
> block have to be changed,
> but this still would be way better than old cell storage case when there
> was no concept of blocks.

Does not sound very appealing to me. A better lookup time is certainly
desirable by means of interpolation or binary search, but at the cost of
insertion/deletion time that's not gonna fly. We still have bottlenecks
where inserting and especially changing type of a cell, which leads to
shrinkage of one block and enlargement or insertion of another, can
build up to looong waiting times. I don't have the bug number at hand
right now, but the worst case is a Find that changes string
cells to numeric (or vice versa) in a column of data. I think these
should be addressed first.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Care about Free Software, support the FSFE https://fsfe.org/support/?erack


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 55058] List of EMF import bugs with examples

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=55058

--- Comment #18 from Patrick Jaap  ---
Hi, attachment 67335 does not contain any EMF+ records, it is just pure EMF.
But I can take a look into the EMF parsing, there seems to be something wrong
with the color choice.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: [GSoC] Replace EditEngine binary clipboard with ODF filter - Project Status - Varun Dhall

2017-08-25 Thread Eike Rathke
Hi Varun,

On Thursday, 2017-08-24 06:51:32 +0530, Varun Dhall wrote:

> During last 12 weeks I worked on my GSoC project "Replace EditEngine binary
> clipboard with ODF filter". I have successfully completed the project and
> all my changes are merged into the master.

Great, congratulations!

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Care about Free Software, support the FSFE https://fsfe.org/support/?erack


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 109121] Text Colors Incorrect with Windows 10 High Contrast; Tools> Options>LibreOffce>Application Colors Fixes It Temporarily

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=109121

Buovjaga  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
Version|5.3.4.2 release |4.4.7.2 release
 Ever confirmed|0   |1

--- Comment #1 from Buovjaga  ---
Repro already in 4.4, but not in 3.5. Maybe I should try to bibisect later.

For testers: to enable High contrast, search for High contrast in the menu in
Win 10.

Win 10
3.5.0

Version: 4.4.7.2
Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600
Locale: fi_FI

Version: 6.0.0.0.alpha0+ (x64)
Build ID: 8d74698f407de0b02826777d5cb3f5aca2fd50f1
CPU threads: 4; OS: Windows 6.19; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2017-08-24_23:26:55
Locale: fi-FI (fi_FI); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 111088] Moving a 3d object around in Draw seems to be slower and more CPU consuming compared to 5.1.6.2

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=111088

Buovjaga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #2 from Buovjaga  ---
I tested with 5.0 vs. 6.0 and 5.0 used about 6% more CPU. 26% peak vs. 20%
peak.
What sort of percentages are you seeing?

Win 10
Version: 5.0.2.2 (x64)
Build ID: 37b43f919e4de5eeaca9b9755ed688758a8251fe
Locale: en-US (fi_FI)

Version: 6.0.0.0.alpha0+ (x64)
Build ID: 8d74698f407de0b02826777d5cb3f5aca2fd50f1
CPU threads: 4; OS: Windows 6.19; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2017-08-24_23:26:55
Locale: fi-FI (fi_FI); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 109219] Mailmerge: cannot use CSV as Address List with MM Wizard in Windows

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=109219

Buovjaga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #1 from Buovjaga  ---
I had three previous lists and OK was available.

Win 10
Version: 6.0.0.0.alpha0+ (x64)
Build ID: 8d74698f407de0b02826777d5cb3f5aca2fd50f1
CPU threads: 4; OS: Windows 6.19; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2017-08-24_23:26:55
Locale: fi-FI (fi_FI); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: instsetoo_native/inc_openoffice

2017-08-25 Thread Matthias Seidel
 instsetoo_native/inc_openoffice/windows/msi_languages/Control.ulf |   22 
+-
 1 file changed, 11 insertions(+), 11 deletions(-)

New commits:
commit 8e246b5cccadbac1e6d6c39fcd2a872727683f75
Author: Matthias Seidel 
Date:   Sun Jul 23 18:02:29 2017 +

Deleted whitespace

(cherry picked from commit 6b62e035d388ce14630da65d63db5a216e1848e7)

Change-Id: I7e0c7edf12a30daec35d9461f0be12b6d07fddc3
Reviewed-on: https://gerrit.libreoffice.org/41575
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 

diff --git a/instsetoo_native/inc_openoffice/windows/msi_languages/Control.ulf 
b/instsetoo_native/inc_openoffice/windows/msi_languages/Control.ulf
index 4d39022a8a27..121a7f49e486 100644
--- a/instsetoo_native/inc_openoffice/windows/msi_languages/Control.ulf
+++ b/instsetoo_native/inc_openoffice/windows/msi_languages/Control.ulf
@@ -53,7 +53,7 @@ en-US = "Cancel"
 en-US = "Specify a network location for the server image of the product."
 
 [OOO_CONTROL_20]
-en-US = "Enter the network location or click Change to browse to a location.  
Click Install to create a server image of [ProductName] at the specified 
network location or click Cancel to exit the wizard."
+en-US = "Enter the network location or click Change to browse to a location. 
Click Install to create a server image of [ProductName] at the specified 
network location or click Cancel to exit the wizard."
 
 [OOO_CONTROL_21]
 en-US = "{}Network Location"
@@ -368,7 +368,7 @@ en-US = " >"
 en-US = "{}Welcome to the Patch for [ProductName]"
 
 [OOO_CONTROL_162]
-en-US = "The Installation Wizard will install the Patch for [ProductName] on 
your computer.  To continue, click Update."
+en-US = "The Installation Wizard will install the Patch for [ProductName] on 
your computer. To continue, click Update."
 
 [OOO_CONTROL_163]
 en-US = "< "
@@ -500,7 +500,7 @@ en-US = " >"
 en-US = "{}Welcome to the Installation Wizard for [ProductName]"
 
 [OOO_CONTROL_218]
-en-US = "[ProductName] Setup is preparing the Installation Wizard which will 
guide you through the program setup process.  Please wait."
+en-US = "[ProductName] Setup is preparing the Installation Wizard which will 
guide you through the program setup process. Please wait."
 
 [OOO_CONTROL_219]
 en-US = "< "
@@ -668,7 +668,7 @@ en-US = "To select a different version, click "Change". 
Otherwise click "Cancel"
 en-US = "To select a different folder, click "Change"."
 
 [OOO_CONTROL_308]
-en-US  = "Install [ProductName] to:"
+en-US = "Install [ProductName] to:"
 
 [OOO_CONTROL_309]
 en-US = "If you are just trying out [ProductName], you probably don't want 
this to happen, so leave the boxes unchecked."
@@ -680,23 +680,23 @@ en-US = "No languages have been selected for 
installation. Click OK, then select
 en-US = "No applications have been selected for installation. Click OK, then 
select one or more applications for installation."
 
 [OOO_CONTROL_319]
-en-US  = "Create a start link on desktop"
+en-US = "Create a start link on desktop"
 
 [OOO_CONTROL_321]
-en-US  = "Load [ProductName] during system start-up"
+en-US = "Load [ProductName] during system start-up"
 
 [OOO_CONTROL_322]
-en-US  = "Some files that need to be updated are currently in use."
+en-US = "Some files that need to be updated are currently in use."
 
 [OOO_CONTROL_323]
-en-US  = "The following applications are using files that need to be updated 
by this setup. You can let Installation Wizard close them and attempt to 
restart them or reboot the machine later."
+en-US = "The following applications are using files that need to be updated by 
this setup. You can let Installation Wizard close them and attempt to restart 
them or reboot the machine later."
 
 [OOO_CONTROL_324]
-en-US  = "{}Files in Use"
+en-US = "{}Files in Use"
 
 [OOO_CONTROL_325]
-en-US  = "Cancel"
+en-US = "Cancel"
 
 [OOO_CONTROL_326]
-en-US  = "OK"
+en-US = "OK"
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 108726] PDF insertion regressions in 5.4

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108726

--- Comment #9 from V Stuart Foote  ---
(In reply to sergio.callegari from comment #8)
> > I think return of break would requires enhancement as in bug 106581 to use 
> > Skia graphics with the pdfium filtered PDF.
> 
> Wouldn't it be possible, at least for the time being, leaving in place and
> leveraging the 5.3 codepath for the "break", until it is possible to switch
> to use Skia graphics with the pdfium filtered PDF?
> 

As in your original posting in bug 104648, _no_. 

Miklos' work on an "insert as image" capability (resolving bug 89727) and then
moving it to a pdfium based filter simply does not support it.

> > A PDF file filter import opened into into Draw still support the "break".
> 
> If you "open" the pdf file with draw, in opposition to "inserting" it into
> an existing draw document, then the conversion into native LibO objects is
> automatic (opposed to showing the image rendered by pdfium), which is why
> the "break" action remains supported, I think.
> 

Yes that is correct, but the PDF structure is lost losing fidelity when
printing or reexporting out of the saved ODF drawing.

> Indeed, the possibility of getting this behavior through the "opening" of
> the pdf document in draw is a useful workaround for the lack of "break"
> option when inserting the pdf image in an existing drawing/presentation.
> Another workaround is to open in inkscape, save as emf and insert the emf
> that supports the break action. Still, it seems a bit more complex than
> desirable and a bit inconsistent to have break on all vector formats (svg,
> emf, wmf, native metafile), but PDF.

There are better ghostscript based PDF conversions than Inkscape--but that is
one approach.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 110985] windows taskbar is over LibreOffice in fullscreen mode

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=110985

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
Version|5.4.0.3 release |3.5.0 release
 Ever confirmed|0   |1

--- Comment #2 from Buovjaga  ---
Repro. Shows quite well with Calc.

Win 10
LibreOffice 3.5.0rc3 
Build ID: 7e68ba2-a744ebf-1f241b7-c506db1-7d53735

Version: 6.0.0.0.alpha0+ (x64)
Build ID: 8d74698f407de0b02826777d5cb3f5aca2fd50f1
CPU threads: 4; OS: Windows 6.19; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2017-08-24_23:26:55
Locale: fi-FI (fi_FI); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112022] Writer repeatedly crashing for no apparent reason

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112022

--- Comment #7 from Alex Thurgood  ---
Currently there are several main possibilities for crashing on startup :

1) graphics chip switching problems (discrete/dedicated, especially certain
Intel/Nvidia combinations);

2) no recognized Java JDK - you mention your Java version but don't say whether
it is a JDK or a JRE - you *need* a JDK

3) incorrect permmissions - check to see whether the xattr bit is correctly set
- if LibreOffice was installed without bypassing Gatekeeper security (even
though it is a signed bundle), the xattr bit can be set and cause LO to crash
on startup.

4) Screen display resolution / HiDPI support if outputting to a separate
screen.

5) VoiceOver / Assistive Technology options, or apps that use these functions
like Dragon Dictate.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 111894] PaletteManager::LoadPalettes() leaks memory

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=111894

Telesto  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #3 from Telesto  ---
(In reply to Alex Thurgood from comment #2)
> (In reply to Telesto from comment #1)
> > Thanks for filling the bug. However, it seems a was focusing to much on the
> > leak detection. Instruments is indicating a leak, but the memory usage in
> > general isn't structurally increasing as far I can tell. So there is a
> > change that this is the same as bug 105500 comment 14
> 
> Even though some of the memory is released from
> PaletteManager::LoadPalettes, overal memory consumption continues to increase

Confirming -> setting to new.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89589] Change the size and position of the window display presentation.

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89589

Buovjaga  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108741] [META] Shapes bugs and enhancements

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108741

Aron Budea  changed:

   What|Removed |Added

 Depends on||112029


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=112029
[Bug 112029] FILESAVE, DOC: AutoShape arrow direction changes after roundtrip
in Writer
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112029] FILESAVE, DOC: AutoShape arrow direction changes after roundtrip in Writer

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112029

Aron Budea  changed:

   What|Removed |Added

Version|6.0.0.0.alpha0+ Master  |5.4.0.3 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104527] [META] DOC bug tracker

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104527

Aron Budea  changed:

   What|Removed |Added

 Depends on||112029


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=112029
[Bug 112029] FILESAVE, DOC: AutoShape arrow direction changes after roundtrip
in Writer
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112029] New: FILESAVE, DOC: AutoShape arrow direction changes after roundtrip in Writer

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112029

Bug ID: 112029
   Summary: FILESAVE, DOC: AutoShape arrow direction changes after
roundtrip in Writer
   Product: LibreOffice
   Version: 6.0.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: bibisectRequest, filter:doc, regression
  Severity: normal
  Priority: medium
 Component: filters and storage
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ba...@caesar.elte.hu
Blocks: 104527, 108741

Created attachment 135790
  --> https://bugs.documentfoundation.org/attachment.cgi?id=135790=edit
Sample DOC with an arrow (AutoShape)

Open the attached DOC file, it contains a single arrow, an AutoShape copied
from the bugdoc in bug 109251 (attachment 134757).
Save it again as DOC, and open the saved file.

=> The direction changed slightly.

Observed in LO 5.4.0.3 / Windows 7.
Not observed in LO 5.3.0.3.
=> regression


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104527
[Bug 104527] [META] DOC bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=108741
[Bug 108741] [META] Shapes bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 36175] Cells keep date autoformat incorrectly

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=36175

--- Comment #18 from Eike Rathke  ---
If one enters a formula, pre-existing formatting will not be discarded unless
it was Boolean. The reason is that internally date+time is only a date serial
number and any number can be formatted as date+time (value in days since null
date, so 0.5 == 12 hours). In case of =4/5 the actual value 0.8 formatted as
date+time is 1899-12-30 19:12:00

We maybe could check if the final result of a calculation of a newly entered
formula expression could actually be a date and remove a date format if not,
but that somehow sounds like overkill and again could be error prone and wrong
in cases where some numeric calculation is done and the user actually wanted
the result be formatted as date.

Fwiw, Excel behaves the same and keeps the date format.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105500

Alex Thurgood  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||1894

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 111894] PaletteManager::LoadPalettes() leaks memory

2017-08-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=111894

Alex Thurgood  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||5500

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


  1   2   3   >