[Bug 158642] Dark mode: "Text boundaries" set to "automatic" obscure the cursor when line is empty
https://bugs.documentfoundation.org/show_bug.cgi?id=158642 --- Comment #5 from John --- I was not able to reproduce this issue: Version: 24.2.0.3 (X86_64) / LibreOffice Community Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1 CPU threads: 24; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 76208] Frame border settings ignored
https://bugs.documentfoundation.org/show_bug.cgi?id=76208 --- Comment #12 from John --- I was unable to reproduce this bug in this version: Version: 24.2.0.3 (X86_64) / LibreOffice Community Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1 CPU threads: 24; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
core.git: cui/source
cui/source/options/treeopt.cxx | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) New commits: commit 3b50600e8f817409f5a21249871d9f82728e4987 Author: Gabor Kelemen AuthorDate: Fri Mar 29 22:20:08 2024 +0100 Commit: Thorsten Behrens CommitDate: Tue Apr 9 07:45:39 2024 +0200 Use some nicer assert string Change-Id: I49b5950a63b7c1decb07f3093e8962fc3eada0bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165569 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/cui/source/options/treeopt.cxx b/cui/source/options/treeopt.cxx index 5fe43e57f6ab..6ab767bb8044 100644 --- a/cui/source/options/treeopt.cxx +++ b/cui/source/options/treeopt.cxx @@ -1841,7 +1841,7 @@ void OfaTreeOptionsDialog::writerOptions(const std::vector& vPageId) sal_uInt16 nPageId = 0; OUString aFactory = getCurrentFactory_Impl( m_xFrame ); -DBG_ASSERT( GetModuleIdentifier( m_xFrame ) == aFactory, "S H I T!!!" ); +DBG_ASSERT( GetModuleIdentifier( m_xFrame ) == aFactory, "This should not happen" ); SvtModuleOptions aModuleOpt; if ( aModuleOpt.IsModuleInstalled( SvtModuleOptions::EModule::WRITER ) ) @@ -1901,7 +1901,7 @@ void OfaTreeOptionsDialog::writerWebOptions(const std::vector& vPage sal_uInt16 nPageId = 0; OUString aFactory = getCurrentFactory_Impl( m_xFrame ); -DBG_ASSERT( GetModuleIdentifier( m_xFrame ) == aFactory, "S H I T!!!" ); +DBG_ASSERT( GetModuleIdentifier( m_xFrame ) == aFactory, "This should not happen" ); SvtModuleOptions aModuleOpt; if ( aModuleOpt.IsModuleInstalled( SvtModuleOptions::EModule::WRITER ) ) @@ -1955,7 +1955,7 @@ void OfaTreeOptionsDialog::calcOptions(const std::vector& vPageId) sal_uInt16 nPageId = 0; OUString aFactory = getCurrentFactory_Impl( m_xFrame ); -DBG_ASSERT( GetModuleIdentifier( m_xFrame ) == aFactory, "S H I T!!!" ); +DBG_ASSERT( GetModuleIdentifier( m_xFrame ) == aFactory, "This should not happen" ); SvtModuleOptions aModuleOpt; // Calc options @@ -1995,7 +1995,7 @@ void OfaTreeOptionsDialog::impressOptions(const std::vector& vPageId sal_uInt16 nPageId = 0; OUString aFactory = getCurrentFactory_Impl( m_xFrame ); -DBG_ASSERT( GetModuleIdentifier( m_xFrame ) == aFactory, "S H I T!!!" ); +DBG_ASSERT( GetModuleIdentifier( m_xFrame ) == aFactory, "This should not happen" ); SvtModuleOptions aModuleOpt; // Impress options @@ -2035,7 +2035,7 @@ void OfaTreeOptionsDialog::drawOptions(const std::vector& vPageId) sal_uInt16 nPageId = 0; OUString aFactory = getCurrentFactory_Impl( m_xFrame ); -DBG_ASSERT( GetModuleIdentifier( m_xFrame ) == aFactory, "S H I T!!!" ); +DBG_ASSERT( GetModuleIdentifier( m_xFrame ) == aFactory, "This should not happen" ); SvtModuleOptions aModuleOpt; // Draw options @@ -2076,7 +2076,7 @@ void OfaTreeOptionsDialog::mathOptions(const std::vector& vPageId) sal_uInt16 nPageId = 0; OUString aFactory = getCurrentFactory_Impl( m_xFrame ); -DBG_ASSERT( GetModuleIdentifier( m_xFrame ) == aFactory, "S H I T!!!" ); +DBG_ASSERT( GetModuleIdentifier( m_xFrame ) == aFactory, "This should not happen" ); SvtModuleOptions aModuleOpt; // Math options
[Bug 157214] [CRASH] Segmentation fault in kf5 + Wayland (/lib/x86_64-linux-gnu/libQt5WaylandClient.so.5)
https://bugs.documentfoundation.org/show_bug.cgi?id=157214 Michael Weghorn changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #11 from Michael Weghorn --- (In reply to Rafael Lima from comment #10) > Yeah, I can confirm that it does not crash when I comment out these two > environment variables. I didn't know this trick, thanks for pointing it out. Thanks for confirming. > This bug is actually a pain when building and testing LO on my second > machine, where I run Wayland on Plasma 5.27... at least by commenting these > lines, I can get around this issue. It is indeed. Other workarounds are using a different VCL plugin (e.g. SAL_USE_VCLPLUGIN=qt6 ) or forcing the use of the X11/xcb QT platform plugin instead of the native Wayland one ( QT_QPA_PLATFORM=xcb ). > I agree that this is an upstream bug. But isn't Plasma 5.27 an LTS? So maybe > it should be a good idea to report this issue upstream. Without analyzing further, I'd rather expect this to be a Qt issue. The KDE community still has a "patch collection" for Qt 5, but since the issue doesn't cause any user-visible issues in a "normal" setup, my assumption is that the most likely way to actually get a fix would be to analyze in more detail and either identify what commit fixed this for Qt 6 and suggest a backport, or come up with a fix oneself. I wouldn't feel able to create a proper bug report without spending more time. And while this is indeed annoying when using Wayland, my personal focus is more on qt6 than kf5/qt5 when it comes to non-critical things. > I haven't built LO using Plasma 6 yet... so I can't tell whether the problem > is there too. I have only tested the PPA version of LO under Plasma 6, but > using the kf5 backend, since qt6 isn't being shipped yet in the PPA. Do you see the issue with kf5 with that PPA? (My initial assumption would be no, as I'd expect that to be a release build, where the environment variables causing the crash shouldn't be set.) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160592] Cannot Save as PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=160592 --- Comment #1 from Mike Kaganski --- 1. There must be a PDF export button on the toolbar. 2. There should be File->Export->Export as PDF menu item. Please provide a screenshot of your user interface with File->Export menu expanded. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160364] soffice --convert-to gives "Secure coding is not enabled for restorable state!" warning
https://bugs.documentfoundation.org/show_bug.cgi?id=160364 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160582] FILEOPEN: CSV, locale setting is not preserved in the import window (regression tdf#152336)
https://bugs.documentfoundation.org/show_bug.cgi?id=160582 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.
[Bug 153306] Cursor leftovers keep being displayed when using Skia Vulkan/Metal
https://bugs.documentfoundation.org/show_bug.cgi?id=153306 --- Comment #28 from John --- I was not able to replicate this on my setup. I'm using a 1440p monitor on windows with the following version: Version: 24.2.0.3 (X86_64) / LibreOffice Community Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1 CPU threads: 24; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_DE); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160032] MASTER Document -- updating linked documents automatically: different setting for master documents (on opening)
https://bugs.documentfoundation.org/show_bug.cgi?id=160032 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160589] Charts are not updated after data entry if freezing of columns or rows is activated
https://bugs.documentfoundation.org/show_bug.cgi?id=160589 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160032] MASTER Document -- updating linked documents automatically: different setting for master documents (on opening)
https://bugs.documentfoundation.org/show_bug.cgi?id=160032 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 160361] Export Preview Support
https://bugs.documentfoundation.org/show_bug.cgi?id=160361 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160360] Syntax Highlighting for Markdown
https://bugs.documentfoundation.org/show_bug.cgi?id=160360 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160345] Slow rendering of filled polygon
https://bugs.documentfoundation.org/show_bug.cgi?id=160345 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160273] Writing direction with rotated text in cell is inconsistent
https://bugs.documentfoundation.org/show_bug.cgi?id=160273 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160353] List images in order of document appearance in navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=160353 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160273] Writing direction with rotated text in cell is inconsistent
https://bugs.documentfoundation.org/show_bug.cgi?id=160273 --- Comment #6 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157446] Not responding after opening the app, is the Windows Update the cause?
https://bugs.documentfoundation.org/show_bug.cgi?id=157446 --- Comment #7 from QA Administrators --- Dear Rosyad, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157325] Copying from an excel (From Excel 2019 program) to CSV (opened in Calc 7.5.6.2)
https://bugs.documentfoundation.org/show_bug.cgi?id=157325 --- Comment #2 from QA Administrators --- Dear Baranyai Zsolt, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157408] LibreOffice - Writer crashed when two databases (ods-files) are involved in one serial-letter.
https://bugs.documentfoundation.org/show_bug.cgi?id=157408 --- Comment #3 from QA Administrators --- Dear Benjamin B., This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Bug 155354] Hidden field isn't hidden
https://bugs.documentfoundation.org/show_bug.cgi?id=155354 --- Comment #6 from QA Administrators --- Dear davent, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Bug 99725] FILEOPEN RTF layout problem with footer (Normal view not showing some text)
https://bugs.documentfoundation.org/show_bug.cgi?id=99725 --- Comment #10 from QA Administrators --- Dear Óvári, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 99724] FILEOPEN RTF layout problem with footer
https://bugs.documentfoundation.org/show_bug.cgi?id=99724 --- Comment #11 from QA Administrators --- Dear Óvári, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 148174] FILEOPEN DOCX Ref field incorrect with "Paragraph # in full context" and "Relative position of paragraph" enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=148174 --- Comment #2 from QA Administrators --- Dear Gabor Kelemen (allotropia), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 148171] FILEOPEN DOCX PageRef field with "Position of paragraph" option incorrectly imported
https://bugs.documentfoundation.org/show_bug.cgi?id=148171 --- Comment #2 from QA Administrators --- Dear Gabor Kelemen (allotropia), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 97947] FILEOPEN RTF layout problem with table
https://bugs.documentfoundation.org/show_bug.cgi?id=97947 --- Comment #8 from QA Administrators --- Dear Óvári, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 148173] FILEOPEN DOCX Ref field incorrect with "Paragraph # from marked paragraph" and "Relative position of paragraph" enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=148173 --- Comment #2 from QA Administrators --- Dear Gabor Kelemen (allotropia), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 147463] Clicking on field link scrolls to page, but focuses only 1/3 of the page in question
https://bugs.documentfoundation.org/show_bug.cgi?id=147463 --- Comment #6 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 132215] .uno:EditStyle does not do anything in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=132215 --- Comment #6 from QA Administrators --- Dear Julien Nabet, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 131599] Jumping to beginning of next page does not center view logically
https://bugs.documentfoundation.org/show_bug.cgi?id=131599 --- Comment #7 from QA Administrators --- Dear Stapler, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 106859] DOCX formulas : greek letters not imported correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=106859 --- Comment #10 from QA Administrators --- Dear Pierre C, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159393] Writer shutdown after a Ctrl-Enter for new page in document
https://bugs.documentfoundation.org/show_bug.cgi?id=159393 --- Comment #4 from John --- This issue does not seem to be present in this version of LibreOffice Writer: Version: 24.2.0.3 (X86_64) / LibreOffice Community Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1 CPU threads: 24; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_DE); UI: en-US Calc: CL threaded I was not able to reproduce the bugs and page breaks were inserted as expected. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158850] Font Size in Menubar not Changeable
https://bugs.documentfoundation.org/show_bug.cgi?id=158850 --- Comment #2 from John --- This does not appear to be an issue in my version of LibreOffice. It behaves as expected as far as I can tell. I recommend following the steps that were commented previously and trying a new version. Version: 24.2.0.3 (X86_64) / LibreOffice Community Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1 CPU threads: 24; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_DE); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160273] Writing direction with rotated text in cell is inconsistent
https://bugs.documentfoundation.org/show_bug.cgi?id=160273 --- Comment #5 from Csábi Frigyes --- (In reply to Stéphane Guillou (stragu) from comment #4) > (In reply to V Stuart Foote from comment #2) > > You are mixing Table/Table Cell *text orientation* up with Character *text > > rotation*. > > > > Different attributes! > > > > Table layout BTLR is different to TBRL -- the 90 left rotation happens to > > match the layout of the BTLR orientation. Simply put, the 270 right > > rotation does not match layout of TBRL orientation. > > > > IMHO => NAB > I agree with Stuart here. Character rotation is a character effect, not a > whole-paragraph or whole-cell tool. > > (In reply to Csábi Frigyes from comment #3) > > Hmm, yes you are right, the 270 rotation is still left to right. My problem > > is, that it is very hard to read. And if i try to change it to right to left > > (Ctrl + Shift + D in Windows) it messes up the text. Would you consider this > > as a bug? > Why would you change an LTR script to RTL direction? In this case, the > character rotation and the writing direction features would be both > missused. If you want the text contained in a table cell to be read by > tilting your head to the right, cell rotation has to be used. What is wrong > with using cell rotation? Yes, using cell rotation would be the more convenient, but it raises a problem mentioned in Bug 160271, which seems to be considered NAB. Not to mention another issue. We have to work with merged AND rotated cells, and they dont break "well" when they continue on multiple pages, leaving sometimes half of the page empty (Even with allowing row breaking). Rotating the text instead of the cell fixes this as well. -- You are receiving this mail because: You are the assignee for the bug.
core.git: xmloff/source
xmloff/source/core/xmlexp.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 432c866072aa62cf90168d569dc56cbc7269bcda
Author: Taichi Haradaguchi <20001...@ymail.ne.jp>
AuthorDate: Mon Apr 8 15:38:44 2024 +0200
Commit: Taichi Haradaguchi <20001...@ymail.ne.jp>
CommitDate: Tue Apr 9 01:46:04 2024 +0200
Revert "Fix typo"
This reverts commit 659051b7aa7eb9a142d044693409631cfa319b40.
Reason for revert: "fo" is the "formatting objects" namespace in ODF, not a
typo for "for".
Change-Id: If2bef82b9aacb32a125728f548db4d85bee3ed56
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165838
Tested-by: Jenkins
Reviewed-by: Taichi Haradaguchi <20001...@ymail.ne.jp>
diff --git a/xmloff/source/core/xmlexp.cxx b/xmloff/source/core/xmlexp.cxx
index b04c42cb0432..140b264f6d41 100644
--- a/xmloff/source/core/xmlexp.cxx
+++ b/xmloff/source/core/xmlexp.cxx
@@ -982,7 +982,7 @@ void SvXMLExport::AddLanguageTagAttributes( sal_uInt16
nPrefix, sal_uInt16 nPref
{
if (getSaneDefaultVersion() >= SvtSaveOptions::ODFSVER_012)
AddAttribute( nPrefixRfc, XML_RFC_LANGUAGE_TAG,
rLanguageTag.getBcp47());
-// Also in case of non-pure-ISO tag store best matching for: attributes
+// Also in case of non-pure-ISO tag store best matching fo: attributes
// for consumers not handling *:rfc-language-tag, ensuring that only
// valid ISO codes are stored. Here the bWriteEmpty parameter has no
// meaning.
[Bug 160590] Impress crashes when skia is enabled without software rendering: EXC_CRASH (SIGABRT)
https://bugs.documentfoundation.org/show_bug.cgi?id=160590 --- Comment #2 from Patrick Luby (volunteer) --- (In reply to V Stuart Foote from comment #1) > Meaning probably that Skia Metal accelerated graphics are not supported on > your GPU. Actually rather common and why the raster framed "software" > rendering is fallback/default. So far, we only disable Skia/Raster for the following 2 GPU families: AMD Radeon Pro 5300M AMD Radeon Pro 5500M Reading the crash log in attachment #193575, it is LibreOffice's "Skia hang detector" code that is forcing LibreOffice to crash. That code monitors batches of calls into Skia and, if a batch doesn't finish within a few seconds or so, that code forces LibreOffice to crash. So, I assume that Skia/Metal has one or more very, very slow or hanging operations on the Intel HD Graphics 6000 GPU. Should I add that to the above "disable Skia/Raster" list? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160590] Impress crashes when skia is enabled without software rendering: EXC_CRASH (SIGABRT)
https://bugs.documentfoundation.org/show_bug.cgi?id=160590 V Stuart Foote changed: What|Removed |Added CC||guibomac...@gmail.com, ||vsfo...@libreoffice.org --- Comment #1 from V Stuart Foote --- Meaning probably that Skia Metal accelerated graphics are not supported on your GPU. Actually rather common and why the raster framed "software" rendering is fallback/default. IMHO if the Skia vector GPU rendering fails, NOT OUR BUG. Hardware, Driver or a mix of the two. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160591] FILESAVE PPTX: blue shape turns white, white text turns black
https://bugs.documentfoundation.org/show_bug.cgi?id=160591 Gerald Pfeifer changed: What|Removed |Added Keywords||bibisectRequest, regression -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160591] FILESAVE PPTX: blue shape turns white, white text turns black
https://bugs.documentfoundation.org/show_bug.cgi?id=160591 --- Comment #1 from Gerald Pfeifer --- Created attachment 193577 --> https://bugs.documentfoundation.org/attachment.cgi?id=193577=edit Visual comparison: PowerPoint (left) - Impress after saving as PPTX (right) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160591] New: FILESAVE PPTX: blue shape turns white, white text turns black
https://bugs.documentfoundation.org/show_bug.cgi?id=160591
Bug ID: 160591
Summary: FILESAVE PPTX: blue shape turns white, white text
turns black
Product: LibreOffice
Version: 24.8.0.0 alpha0+ Master
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: Impress
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: ger...@pfeifer.com
Created attachment 193576
--> https://bugs.documentfoundation.org/attachment.cgi?id=193576=edit
Sample slide (PPTX)
1. Open the attached PPTX document in Impress.
Looks pretty much like in PowerPoint!
2. Save from Impress as PPTX under a different name.
3. Restart Impress and open the just saved document.
4. Yikes!
a. The white text in the center ("Am Dam Des") is now black.
b. The copyright notice in the lower left corner turned from white
to black, too.
c. The central element changed from blue to white.
Item 4.a and 4.b, text changing from white to black is a regression;
Version: 7.5.6.0.0+ (X86_64) / LibreOffice Community
Build ID: 0a5c49aa4f65c8e661f7da3934ab9bea8cacf662
CPU threads: 12; OS: Linux 6.8; UI render: default; VCL: gtk3
does not have it.
Full extent seen with
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 30c6e51fc9cb0fa864e1755271343d847fcced25
CPU threads: 12; OS: Linux 6.8; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
--
You are receiving this mail because:
You are the assignee for the bug.
core.git: i18npool/inc i18npool/source
i18npool/inc/breakiterator_unicode.hxx |3 +-
i18npool/inc/calendar_gregorian.hxx |2 -
i18npool/source/breakiterator/breakiterator_cjk.cxx | 10
i18npool/source/breakiterator/breakiterator_th.cxx |2 -
i18npool/source/breakiterator/breakiterator_unicode.cxx |7 ++---
i18npool/source/calendar/calendar_gregorian.cxx | 19 +++-
i18npool/source/calendar/calendar_hijri.cxx |2 -
i18npool/source/calendar/calendar_jewish.cxx|2 -
8 files changed, 23 insertions(+), 24 deletions(-)
New commits:
commit 8dacc3e636ff85f7f2edb971ff6e269ed031aaaf
Author: Arnaud VERSINI
AuthorDate: Mon Apr 8 11:13:40 2024 +0200
Commit: Noel Grandin
CommitDate: Mon Apr 8 23:18:31 2024 +0200
i18npool : use OUString literal
Change-Id: I202f09303fd385cfcaa468411d0fae8b1707cf88
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165884
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/i18npool/inc/breakiterator_unicode.hxx
b/i18npool/inc/breakiterator_unicode.hxx
index d468a2ebf941..d2cf5339f7d8 100644
--- a/i18npool/inc/breakiterator_unicode.hxx
+++ b/i18npool/inc/breakiterator_unicode.hxx
@@ -70,7 +70,8 @@ public:
virtual css::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames()
override;
protected:
-const char *cBreakIterator, *lineRule;
+OUString cBreakIterator;
+const char *lineRule;
/** Used as map value. */
struct BI_ValueData
diff --git a/i18npool/inc/calendar_gregorian.hxx
b/i18npool/inc/calendar_gregorian.hxx
index 1ee7cabaab1e..e19698875f85 100644
--- a/i18npool/inc/calendar_gregorian.hxx
+++ b/i18npool/inc/calendar_gregorian.hxx
@@ -102,7 +102,7 @@ protected:
const Era *eraArray;
std::unique_ptr body;
rtl::Reference mxNatNum;
-const char* cCalendar;
+OUString cCalendar;
css::lang::Locale aLocale;
sal_uInt32 fieldSet;
sal_Int16 fieldValue[FIELD_INDEX_COUNT];
diff --git a/i18npool/source/breakiterator/breakiterator_cjk.cxx
b/i18npool/source/breakiterator/breakiterator_cjk.cxx
index 00dc5e9db0f6..22ac459a72a4 100644
--- a/i18npool/source/breakiterator/breakiterator_cjk.cxx
+++ b/i18npool/source/breakiterator/breakiterator_cjk.cxx
@@ -34,7 +34,7 @@ namespace i18npool {
BreakIterator_CJK::BreakIterator_CJK()
{
-cBreakIterator = "com.sun.star.i18n.BreakIterator_CJK";
+cBreakIterator = u"com.sun.star.i18n.BreakIterator_CJK"_ustr;
}
Boundary SAL_CALL
@@ -146,7 +146,7 @@ BreakIterator_zh::BreakIterator_zh()
m_oDict.emplace("zh");
assert(hangingCharacters.pData);
hangingCharacters =
LocaleDataImpl::get()->getHangingCharacters(LOCALE("zh", "CN"));
-cBreakIterator = "com.sun.star.i18n.BreakIterator_zh";
+cBreakIterator = u"com.sun.star.i18n.BreakIterator_zh"_ustr;
}
//
@@ -157,7 +157,7 @@ BreakIterator_zh_TW::BreakIterator_zh_TW()
m_oDict.emplace("zh");
assert(hangingCharacters.pData);
hangingCharacters =
LocaleDataImpl::get()->getHangingCharacters(LOCALE("zh", "TW"));
-cBreakIterator = "com.sun.star.i18n.BreakIterator_zh_TW";
+cBreakIterator = u"com.sun.star.i18n.BreakIterator_zh_TW"_ustr;
}
//
@@ -169,7 +169,7 @@ BreakIterator_ja::BreakIterator_ja()
m_oDict->setJapaneseWordBreak();
assert(hangingCharacters.pData);
hangingCharacters =
LocaleDataImpl::get()->getHangingCharacters(LOCALE("ja", "JP"));
-cBreakIterator = "com.sun.star.i18n.BreakIterator_ja";
+cBreakIterator = u"com.sun.star.i18n.BreakIterator_ja"_ustr;
}
//
@@ -179,7 +179,7 @@ BreakIterator_ko::BreakIterator_ko()
{
assert(hangingCharacters.pData);
hangingCharacters =
LocaleDataImpl::get()->getHangingCharacters(LOCALE("ko", "KR"));
-cBreakIterator = "com.sun.star.i18n.BreakIterator_ko";
+cBreakIterator = u"com.sun.star.i18n.BreakIterator_ko"_ustr;
}
}
diff --git a/i18npool/source/breakiterator/breakiterator_th.cxx
b/i18npool/source/breakiterator/breakiterator_th.cxx
index 531107b2a102..8d9245a4bf62 100644
--- a/i18npool/source/breakiterator/breakiterator_th.cxx
+++ b/i18npool/source/breakiterator/breakiterator_th.cxx
@@ -34,7 +34,7 @@ namespace i18npool {
*/
BreakIterator_th::BreakIterator_th()
{
-cBreakIterator = "com.sun.star.i18n.BreakIterator_th";
+cBreakIterator = u"com.sun.star.i18n.BreakIterator_th"_ustr;
// to improve performance, alloc big enough memory in construct.
m_aNextCellIndex.assign(512, 0);
m_aPreviousCellIndex.assign(512, 0);
diff --git a/i18npool/source/breakiterator/breakiterator_unicode.cxx
b/i18npool/source/breakiterator/breakiterator_unicode.cxx
index 4927a82293fc..0caca6ab31ce 100644
--- a/i18npool/source/breakiterator/breakiterator_unicode.cxx
+++
core.git: chart2/source dbaccess/source include/vcl sc/source sd/source svx/source sw/source vcl/source
chart2/source/controller/main/ChartController_Tools.cxx |6 -
dbaccess/source/ui/misc/TableCopyHelper.cxx | 15 +--
dbaccess/source/ui/tabledesign/TEditControl.cxx |5 -
include/vcl/transfer.hxx|4
sc/source/ui/app/transobj.cxx |4
sc/source/ui/view/gridwin.cxx |2
sc/source/ui/view/viewfun3.cxx | 24 ++---
sc/source/ui/view/viewfun4.cxx |4
sc/source/ui/view/viewfun5.cxx |9 --
sd/source/ui/view/sdview3.cxx | 36 ++--
svx/source/gallery2/galtheme.cxx|4
sw/source/uibase/dochdl/swdtflvr.cxx|9 --
vcl/source/treelist/transfer.cxx| 67 +++-
13 files changed, 78 insertions(+), 111 deletions(-)
New commits:
commit e7bb3a52067c426eedffddf86e7d5f0903562da2
Author: Noel Grandin
AuthorDate: Sun Apr 7 20:23:26 2024 +0100
Commit: Noel Grandin
CommitDate: Mon Apr 8 23:16:25 2024 +0200
cid#1596254 Null pointer dereferences in GetSotStorageStream
Re-arrange the calling convention to make it obvious that
a valid stream is the same as a good (true) result.
Change-Id: I974b023a8e7231e70ab649628fdbe43c33001e5b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165874
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/chart2/source/controller/main/ChartController_Tools.cxx
b/chart2/source/controller/main/ChartController_Tools.cxx
index 539516de7466..5774ff1350d4 100644
--- a/chart2/source/controller/main/ChartController_Tools.cxx
+++ b/chart2/source/controller/main/ChartController_Tools.cxx
@@ -266,8 +266,7 @@ void ChartController::executeDispatch_Paste()
{
if ( aDataHelper.HasFormat( SotClipboardFormatId::DRAWING ) )
{
-std::unique_ptr xStm;
-if ( aDataHelper.GetSotStorageStream(
SotClipboardFormatId::DRAWING, xStm ) )
+if (std::unique_ptr xStm =
aDataHelper.GetSotStorageStream( SotClipboardFormatId::DRAWING) )
{
xStm->Seek( 0 );
Reference< io::XInputStream > xInputStream( new
utl::OInputStreamWrapper( *xStm ) );
@@ -284,8 +283,7 @@ void ChartController::executeDispatch_Paste()
else if ( aDataHelper.HasFormat( SotClipboardFormatId::SVXB ) )
{
// graphic exchange format (graphic manager bitmap format?)
-std::unique_ptr xStm;
-if( aDataHelper.GetSotStorageStream( SotClipboardFormatId::SVXB,
xStm ))
+if (std::unique_ptr xStm =
aDataHelper.GetSotStorageStream( SotClipboardFormatId::SVXB ))
{
TypeSerializer aSerializer(*xStm);
aSerializer.readGraphic(aGraphic);
diff --git a/dbaccess/source/ui/misc/TableCopyHelper.cxx
b/dbaccess/source/ui/misc/TableCopyHelper.cxx
index 9da2cb100f3d..5d22c90468c8 100644
--- a/dbaccess/source/ui/misc/TableCopyHelper.cxx
+++ b/dbaccess/source/ui/misc/TableCopyHelper.cxx
@@ -180,16 +180,15 @@ void OTableCopyHelper::pasteTable( SotClipboardFormatId
_nFormatId
try
{
DropDescriptor aTrans;
-bool bOk;
if ( _nFormatId != SotClipboardFormatId::RTF )
-bOk =
_rTransData.GetSotStorageStream(SotClipboardFormatId::HTML
,aTrans.aHtmlRtfStorage);
+aTrans.aHtmlRtfStorage =
_rTransData.GetSotStorageStream(SotClipboardFormatId::HTML);
else
-bOk =
_rTransData.GetSotStorageStream(SotClipboardFormatId::RTF,aTrans.aHtmlRtfStorage);
+aTrans.aHtmlRtfStorage =
_rTransData.GetSotStorageStream(SotClipboardFormatId::RTF);
aTrans.nType= E_TABLE;
aTrans.bHtml= SotClipboardFormatId::HTML == _nFormatId;
aTrans.sDefaultTableName = GetTableNameForAppend();
-if ( !bOk || !copyTagTable(aTrans,false,_xConnection) )
+if ( !aTrans.aHtmlRtfStorage ||
!copyTagTable(aTrans,false,_xConnection) )
m_pController->showError(SQLException(DBA_RES(STR_NO_TABLE_FORMAT_INSIDE),
*m_pController, "S1000", 0, Any()));
}
catch(const SQLException&)
@@ -254,16 +253,12 @@ bool OTableCopyHelper::copyTagTable(const
TransferableDataHelper& _aDroppedData
bool bHtml = _aDroppedData.HasFormat(SotClipboardFormatId::HTML);
if ( bHtml || _aDroppedData.HasFormat(SotClipboardFormatId::RTF) )
{
-bool bOk;
-if ( bHtml )
-bOk = _aDroppedData.GetSotStorageStream(SotClipboardFormatId::HTML
,_rAsyncDrop.aHtmlRtfStorage);
-else
-bOk =
_aDroppedData.GetSotStorageStream(SotClipboardFormatId::RTF,_rAsyncDrop.aHtmlRtfStorage);
+_rAsyncDrop.aHtmlRtfStorage = _aDroppedData.GetSotStorageStream(bHtml
? SotClipboardFormatId::HTML :
[Bug 160305] Export WebP : does not support transparency
https://bugs.documentfoundation.org/show_bug.cgi?id=160305 --- Comment #3 from Archie Cobbs --- Just a note... Bug #160588 was marked as a duplicate of this bug, but bug #160588 describes TWO problems, only one of which duplicates this bug (WEBP with white background instead of transparent). So in order not to lose track of the OTHER problem, I'm reproducing it here. My apologies if these are somehow actually the same bug - if so ignore this comment. The OTHER bug is that text in an PNG export loses its color (i.e., becomes transparent) when "Include transparency" is checked, but when "Include transparency" is not checked. 1. Open bug-example.odg in Draw 2. Export -> PNG -> Include transparency 3. [BUG] Notice text in image is missing color -> see png-with-transparency.png See bug #160588 for the test case. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160580] Provide config option for "Wraparound" of next/previous sheet shortcut in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=160580 --- Comment #5 from a...@patternjugglers.co.nz --- (In reply to ady from comment #4) > (In reply to alex from comment #3) > > To clarify, I am not suggesting a new shortcut to go to the first/last sheet > > - just that the former behaviour of the next/previous shortcuts be made > > available in some way. > > The request is clear. It would be some advance experimental setting, buried > within some not-so-obvious dialogue. > > OTOH, since there are no shortcuts available for "go to first/last > worksheets", having the possibility to assign a shortcut would be less > "advance/experimental". > > I was just taking part of your comment 0 and suggesting a possible > alternative way to solve the UX problem. > > > > > the buttons in the GUI > > retain this behaviour, and it existed prior to 24.2, so it's hard to imagine > > it needs something totally new built. > > For some users, the arrow UI icons to go to first/prior/next/last worksheet > are always grayed out, not clickable. You can click on a specific worksheet > tab, but not on the arrows. This is a separate bug report, but somewhat > related to this request. > > > > > Regarding exposing something new in the customise list, perhaps a separate > > entry for "next sheet - wrap at last" might be comprehensible to users? > > The functions I mentioned in my comment 2 would be "to first (work)sheet" > and "to last (work)sheet". These do not exist, AFAIK. Whether these would > deserve to be added, or to provide whichever alternative to this request, it > is for the UX Team and other devs to evaluate. Thanks for the extra info - I realise we're mostly agreeing and hope some improvement can come from the discussion! -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160305] Export WebP : does not support transparency
https://bugs.documentfoundation.org/show_bug.cgi?id=160305 m_a_riosv changed: What|Removed |Added CC||archie.co...@gmail.com --- Comment #2 from m_a_riosv --- *** Bug 160588 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160588] FILESAVE: Transparency-related bugs with export to PNG and WEBP
https://bugs.documentfoundation.org/show_bug.cgi?id=160588 m_a_riosv changed: What|Removed |Added Resolution|--- |DUPLICATE CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |RESOLVED --- Comment #4 from m_a_riosv --- *** This bug has been marked as a duplicate of bug 160305 *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158420] com.sun.star.text.ContentIndex seems to be missing boolean to enable AdditionalStyles
https://bugs.documentfoundation.org/show_bug.cgi?id=158420 --- Comment #3 from Olivier Hallot --- (In reply to Buovjaga from comment #2) > (In reply to jimmy1 from comment #1) > > I found out that the boolean I'm searching for is: > > `CreateFromLevelParagraphStyles`. > > > > Enabling this property works, but I had to dig into the LibreOffice source > > code to find it. It's missing within the official docs. > > > > So my follow-up question is: could this be added to the documentation? > > Yeah, I can't find it in https://api.libreoffice.org/docs/idl/ref/index.html The argument seems to be LevelParagraphStyles in https://api.libreoffice.org/docs/idl/ref/servicecom_1_1sun_1_1star_1_1text_1_1ContentIndex.html -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160580] Provide config option for "Wraparound" of next/previous sheet shortcut in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=160580 --- Comment #4 from ady --- (In reply to alex from comment #3) > To clarify, I am not suggesting a new shortcut to go to the first/last sheet > - just that the former behaviour of the next/previous shortcuts be made > available in some way. The request is clear. It would be some advance experimental setting, buried within some not-so-obvious dialogue. OTOH, since there are no shortcuts available for "go to first/last worksheets", having the possibility to assign a shortcut would be less "advance/experimental". I was just taking part of your comment 0 and suggesting a possible alternative way to solve the UX problem. > > the buttons in the GUI > retain this behaviour, and it existed prior to 24.2, so it's hard to imagine > it needs something totally new built. For some users, the arrow UI icons to go to first/prior/next/last worksheet are always grayed out, not clickable. You can click on a specific worksheet tab, but not on the arrows. This is a separate bug report, but somewhat related to this request. > > Regarding exposing something new in the customise list, perhaps a separate > entry for "next sheet - wrap at last" might be comprehensible to users? The functions I mentioned in my comment 2 would be "to first (work)sheet" and "to last (work)sheet". These do not exist, AFAIK. Whether these would deserve to be added, or to provide whichever alternative to this request, it is for the UX Team and other devs to evaluate. -- You are receiving this mail because: You are the assignee for the bug.
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
15 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1596278: Null pointer dereferences (FORWARD_NULL)
*** CID 1596278: Null pointer dereferences (FORWARD_NULL)
/sw/source/core/text/frmform.cxx: 1205 in
SwTextFrame::FormatAdjust(SwTextFormatter &, WidowsAndOrphans &,
o3tl::strong_int, bool)()
1199 nNew = 0;
1200 }
1201 else if (!bEmptyWithSplitFly)
1202 {
1203 // Do not split immediately in the beginning of page
(unless there is an at-para or
1204 // at-char or at-page fly, which pushes the rest down)
>>> CID 1596278: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "pBodyFrame" to "hasAtPageFly", which dereferences
>>> it.
1205 if (isFirstVisibleFrameInBody(this) && !hasFly(this) &&
!hasAtPageFly(pBodyFrame))
1206 nNew = 0;
1207 }
1208 }
1209
1210 if ( nNew )
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DOVq3_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtlPTtwlLm0LVNz3b0CKB7cFDFIk0k2thRDBo3nZcFupaXqV493hgw-2Fl3onk-2FssT3N05Vk0hTGK1WN0aWq7a0zbfChKTMPg-2F20R8sbH8UhQ2yNsd-2BisYfJG4M66fXujPTZET58sbQSW5rWAtEOA-2FghnAs5P-2FQWwJSwNw9iubDqwmk-3D
[Bug 160590] New: Impress crashes when skia is enabled without software rendering: EXC_CRASH (SIGABRT)
https://bugs.documentfoundation.org/show_bug.cgi?id=160590 Bug ID: 160590 Summary: Impress crashes when skia is enabled without software rendering: EXC_CRASH (SIGABRT) Product: LibreOffice Version: 24.2.1.2 release Hardware: x86-64 (AMD64) OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: graphics stack Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: libre...@sguazz.it Created attachment 193575 --> https://bugs.documentfoundation.org/attachment.cgi?id=193575=edit Apple crash report Hello, I am trying all libreoffice options in order to get more performance on my MacBook Air. Every time I activate skia and remove the software rendering, the application crashes. This is my hardware details: Model: MacBookAir7,2, BootROM 489.0.0.0.0, 2 processors, Dual-Core Intel Core i5, 1,8 GHz, 8 GB, SMC 2.27f2 Graphics: Intel HD Graphics 6000, Intel HD Graphics 6000, Built-In Display: Color LCD, 1440 x 900 (Widescreen eXtended Graphics Array Plus), Main, MirrorOff, Online The Apple crash report (attached to this bug) displays this stack trace: thread 0:: Dispatch queue: com.apple.main-thread 0 libsystem_kernel.dylib 0x7ff80f3a mach_msg_trap + 10 1 libsystem_kernel.dylib 0x7ff80f999ca8 mach_msg + 56 2 IOKit 0x7ff812389a7c io_connect_method + 387 3 IOKit 0x7ff812389889 IOConnectCallMethod + 186 4 IOAccelerator 0x7ff81837898f ioAccelResourceFinalize + 165 5 CoreFoundation 0x7ff80fb6a046 _CFRelease + 244 6 Metal 0x7ff8183a7e62 -[MTLIOAccelResource dealloc] + 278 7 Metal 0x7ff8183a7d3f -[MTLIOAccelBuffer dealloc] + 333 8 libskialo.dylib0x10cae954b GrMtlBuffer::onRelease() + 43 9 libskialo.dylib0x10c9e8a3f GrGpuResource::release() + 15 10 libskialo.dylib0x10c9fb647 GrResourceCache::notifyARefCntReachedZero(GrGpuResource*, GrIORef::LastRemovedRef) + 567 [...] Thank you, Giuseppe -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160582] FILEOPEN: CSV, locale setting is not preserved in the import window (regression tdf#152336)
https://bugs.documentfoundation.org/show_bug.cgi?id=160582 ady changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #2 from ady --- Using 24.8 alpha built 2024-04-08, I can confirm that the regional setting in the import dialog is taken from menu Tools > Options > Languages and Locales > (Formats) Locale setting. I modified both the UI language and the Locale setting Options to different values. After restarting LO, the "Locale" setting in the import dialog changed according to the "Locale setting:" field used in Options. I have not tested the other field in the import dialog, "Character set". Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 748561425774fa40ab685fed80d113f7e8301158 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160399] Print Preview freezes with whole row merged in large spreadsheet
https://bugs.documentfoundation.org/show_bug.cgi?id=160399 --- Comment #13 from Telesto --- @Stéphane Guillou Would you mind to test this? It's still slow for me regardless all the effort put into it on Windows - similar as described in comment 8 - when using "Deelnemers en Plaatsnummers Fout" (I haven't retested it on mac) Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 748561425774fa40ab685fed80d113f7e8301158 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 101522] [META] Media playback bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101522 --- Comment #24 from Julia --- This valuable insight is a treasure trove for anyone looking to expand their knowledge. Receiving such detailed insights is truly enriching, and I'm eagerly looking forward to delving deeper into this fascinating subject matter. https://reminimod.com/ -- You are receiving this mail because: You are the assignee for the bug.
core.git: unotest/source
unotest/source/embindtest/embindtest.js | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
New commits:
commit c16f7ca43bb338f23895733ee499505ee6a6e72e
Author: Stephan Bergmann
AuthorDate: Mon Apr 8 15:15:33 2024 +0200
Commit: Stephan Bergmann
CommitDate: Mon Apr 8 21:16:23 2024 +0200
Fix indentation
Change-Id: I985562995714c04c569e3a794cf748443ed02865
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165886
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/unotest/source/embindtest/embindtest.js
b/unotest/source/embindtest/embindtest.js
index 410b3886be6d..8c0ee0138828 100644
--- a/unotest/source/embindtest/embindtest.js
+++ b/unotest/source/embindtest/embindtest.js
@@ -539,11 +539,11 @@ Module.addOnPostRun(function() {
console.assert(test.isDouble(uno.org.libreoffice.embindtest.Constants.Double));
try {
test.throwRuntimeException();
- } catch (e) {
- console.assert(e.name === 'com::sun::star::uno::RuntimeException');
- console.assert(e.message === undefined); //TODO
- //TODO: console.assert(e.Message.startsWith('test'));
- }
+} catch (e) {
+console.assert(e.name === 'com::sun::star::uno::RuntimeException');
+console.assert(e.message === undefined); //TODO
+//TODO: console.assert(e.Message.startsWith('test'));
+}
});
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s
cinkeys+=0=break: */
[Bug 160589] Charts are not updated after data entry if freezing of columns or rows is activated
https://bugs.documentfoundation.org/show_bug.cgi?id=160589 Robert Großkopf changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||rob...@familiegrosskopf.de Ever confirmed|0 |1 OS|Windows (All) |All Keywords||regression --- Comment #1 from Robert Großkopf --- Have changed the value in C3 of first table from 25 to 40. Refreshes immediately in Version: 7.6.4.1 (X86_64) / LibreOffice Community Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1 CPU threads: 6; OS: Linux 6.4; UI render: default; VCL: kf5 (cairo+xcb) Locale: de-DE (de_DE.UTF-8); UI: de-DE Calc: threaded Doesn't refresh in LO 24.2.2.2 on the same system (OpenSUSE 14.6 64bit rpm Linux). Have to press F9 to recalculate. Set this one to NEW and regression -- You are receiving this mail because: You are the assignee for the bug.
[Bug 100497] The information dr3d:vpn is not evaluated in case of parallel projection
https://bugs.documentfoundation.org/show_bug.cgi?id=100497 --- Comment #10 from Regina Henschel --- Still not implemented in Version: 7.6.4.1 (X86_64) / LibreOffice Community Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1 CPU threads: 32; OS: Windows 10.0 Build 22631; UI render: default; VCL: win Locale: de-DE (de_DE); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 148251] Use std::swap instead of using temporary values
https://bugs.documentfoundation.org/show_bug.cgi?id=148251 --- Comment #14 from Commit Notification --- AmandaQuaresmaCoutinho committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ccebd10bc4bea1e65b606a054db3f98ab07850cf tdf#148251 Use std::swap instead of using temporary values It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
core.git: embedserv/source extensions/test
embedserv/source/embed/tracker.cxx | 15 +++--
extensions/test/ole/AxTestComponents/Basic.cpp | 28 ++---
2 files changed, 11 insertions(+), 32 deletions(-)
New commits:
commit ccebd10bc4bea1e65b606a054db3f98ab07850cf
Author: AmandaQuaresmaCoutinho
AuthorDate: Thu Apr 4 19:46:32 2024 +0200
Commit: Ilmari Lauhakangas
CommitDate: Mon Apr 8 20:45:39 2024 +0200
tdf#148251 Use std::swap instead of using temporary values
Change-Id: I7629d86b8f85a493bd3ad6b9c465a81c746b1dab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165802
Tested-by: Jenkins
Tested-by: Ilmari Lauhakangas
Reviewed-by: Ilmari Lauhakangas
diff --git a/embedserv/source/embed/tracker.cxx
b/embedserv/source/embed/tracker.cxx
index 2a502671bb63..fb331dfa1478 100644
--- a/embedserv/source/embed/tracker.cxx
+++ b/embedserv/source/embed/tracker.cxx
@@ -201,17 +201,10 @@ void winwrap::TransformRect(LPRECT rect,HWND pWnd,HWND
pWndClipTo)
static void NormalizeRect(LPRECT rp)
{
-if(rp->left > rp->right) {
-UINT tmp = rp->left;
-rp->left = rp->right;
-rp->right = tmp;
-}
-
-if(rp->top > rp->bottom) {
-UINT tmp = rp->top;
-rp->top = rp->bottom;
-rp->bottom = tmp;
-}
+if(rp->left > rp->right)
+std::swap(rp->left, rp->right);
+if(rp->top > rp->bottom)
+std::swap(rp->top, rp->bottom);
}
diff --git a/extensions/test/ole/AxTestComponents/Basic.cpp
b/extensions/test/ole/AxTestComponents/Basic.cpp
index 85fbb649f923..6195aba0a6f0 100644
--- a/extensions/test/ole/AxTestComponents/Basic.cpp
+++ b/extensions/test/ole/AxTestComponents/Basic.cpp
@@ -116,34 +116,26 @@ STDMETHODIMP CBasic::inObject(IDispatch *val)
STDMETHODIMP CBasic::inoutBool(VARIANT_BOOL* val)
{
-VARIANT_BOOL aBool = *val;
-*val = m_bool;
-m_bool = aBool;
+std::swap(*val, m_bool);
return S_OK;
}
STDMETHODIMP CBasic::inoutByte(unsigned char* val)
{
-unsigned char aByte = *val;
-*val = m_byte;
-m_byte = aByte;
+std::swap(*val, m_byte);
return S_OK;
}
STDMETHODIMP CBasic::inoutShort(short *val)
{
-short aShort = *val;
-*val = m_short;
-m_short = aShort;
+std::swap(*val, m_short);
return S_OK;
}
STDMETHODIMP CBasic::inoutLong(long *val)
{
-long aLong = *val;
-*val = m_long;
-m_long = aLong;
+std::swap(*val, m_long);
return S_OK;
}
@@ -159,17 +151,13 @@ STDMETHODIMP CBasic::inoutString(BSTR *val)
STDMETHODIMP CBasic::inoutFloat(float *val)
{
-float aFloat = *val;
-*val = m_float;
-m_float = aFloat;
+std::swap(*val, m_float);
return S_OK;
}
STDMETHODIMP CBasic::inoutDouble(double *val)
{
-double aDouble = *val;
-*val = m_double;
-m_double = aDouble;
+std::swap(*val, m_double);
return S_OK;
}
@@ -1033,9 +1021,7 @@ STDMETHODIMP CBasic::outCurrency(CY* val)
STDMETHODIMP CBasic::inoutCurrency(CY* val)
{
-CY tmp = *val;
-*val = m_cy;
-m_cy = tmp;
+std::swap(*val, m_cy);
return S_OK;
}
[Bug 160580] Provide config option for "Wraparound" of next/previous sheet shortcut in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=160580 --- Comment #3 from a...@patternjugglers.co.nz --- To clarify, I am not suggesting a new shortcut to go to the first/last sheet - just that the former behaviour of the next/previous shortcuts be made available in some way. The change made in 24.2 alters long standing things that work:just hold down CTRL-PGDN and you end up at the last sheet. If you really need to get there fast, move to the mouse button. Both options give a certain outcome, while the new reaction of the shortcut is to create uncertainty about which sheet will be active. I don't understand any of the architecture, but the buttons in the GUI retain this behaviour, and it existed prior to 24.2, so it's hard to imagine it needs something totally new built. Regarding exposing something new in the customise list, perhaps a separate entry for "next sheet - wrap at last" might be comprehensible to users? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 143781] [META] Development- and code-related bug reports and tasks
https://bugs.documentfoundation.org/show_bug.cgi?id=143781 Bug 143781 depends on bug 159719, which changed state. Bug 159719 Summary: SfxItemPool::IsInRange crash: save and reload in Impress or Draw https://bugs.documentfoundation.org/show_bug.cgi?id=159719 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159719] SfxItemPool::IsInRange crash: save and reload in Impress or Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=159719 Armin Le Grand changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |armin.le.gr...@me.com |desktop.org | Status|NEW |ASSIGNED --- Comment #13 from Armin Le Grand --- @ilmari.lauhakan...@libreoffice.org: Thanks for checking! -- You are receiving this mail because: You are the assignee for the bug.
[Bug 81880] Ability to search Gallery for graphics by description
https://bugs.documentfoundation.org/show_bug.cgi?id=81880 Buovjaga changed: What|Removed |Added CC||ilmari.lauhakangas@libreoff ||ice.org --- Comment #15 from Buovjaga --- Can this be closed as fixed now? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 99414] Windows File Browser displays "OpenOffice" as file type to csv format (calc)
https://bugs.documentfoundation.org/show_bug.cgi?id=99414 --- Comment #9 from robomurphy98 --- Still happens in version 7.6 and 24.2. -- You are receiving this mail because: You are the assignee for the bug.
Re: ESC meeting minutes: 2024-04-04
On 05/04/2024 16:38, Olivier Hallot wrote: HI On 4/4/24 11:35, Miklos Vajna wrote: + Guides + WIP + xml:id (https://docs.oasis-open.org/office/OpenDocument/v1.3/os/part3-schema/OpenDocument-v1.3-os-part3-schema.html#__RefHeading__1419430_253892949) + Is it implemented/used in LO? + It's implement in Writer, but only for a fraction of the elements allowed by the schema (Michael S) + should work for and other metadata-related ones + see https://wiki.documentfoundation.org/Documentation/DevGuide/OfficeDev/RDF_metadata#RDF_metadata + bottom of the page has the details, can generate an ID using the API / by a macro + would be helpful for translation as well (Olivier) + also on the TDF wiki these days (Thorsten) One of the open issue I have is to document the page Tool -Option - Writer - Comparison. AFAIK, it was created in a GSoC project at OO.org times. Is this page related to the xml:id topic I raised in the ESC meeting? Any recollections welcome. Thanks for the advise no, these are rsids and do not identify the element they are applied to https://gsoc-tzvetelina.blogspot.com/2009_06_01_archive.html
[Bug 147132] Flatten Basic function implementations
https://bugs.documentfoundation.org/show_bug.cgi?id=147132 --- Comment #22 from Commit Notification --- AmandaQuaresmaCoutinho committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/bb89fe7ab67c1476b6cf250f236bd5b643a77c6e tdf#147132 Flatten Basic function implementations It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
core.git: basic/source
basic/source/runtime/methods1.cxx | 42 +-
1 file changed, 15 insertions(+), 27 deletions(-)
New commits:
commit bb89fe7ab67c1476b6cf250f236bd5b643a77c6e
Author: AmandaQuaresmaCoutinho
AuthorDate: Mon Apr 1 02:22:52 2024 +0200
Commit: Ilmari Lauhakangas
CommitDate: Mon Apr 8 19:29:34 2024 +0200
tdf#147132 Flatten Basic function implementations
Change-Id: Ife7a94cdfa8b31ba2a2bcbdf28c9620bbc5348ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165641
Tested-by: Jenkins
Tested-by: Ilmari Lauhakangas
Reviewed-by: Ilmari Lauhakangas
diff --git a/basic/source/runtime/methods1.cxx
b/basic/source/runtime/methods1.cxx
index b4f7dfb5fd9a..57d95b93a526 100644
--- a/basic/source/runtime/methods1.cxx
+++ b/basic/source/runtime/methods1.cxx
@@ -279,15 +279,11 @@ void SbRtl_CDec(StarBASIC *, SbxArray & rPar, bool)
void SbRtl_CDate(StarBASIC *, SbxArray & rPar, bool) // JSM
{
double nVal = 0.0;
-if (rPar.Count() == 2)
-{
-SbxVariable* pSbxVariable = rPar.Get(1);
-nVal = pSbxVariable->GetDate();
-}
-else
-{
-StarBASIC::Error( ERRCODE_BASIC_BAD_ARGUMENT );
-}
+if (rPar.Count() != 2)
+return StarBASIC::Error( ERRCODE_BASIC_BAD_ARGUMENT );
+
+SbxVariable* pSbxVariable = rPar.Get(1);
+nVal = pSbxVariable->GetDate();
rPar.Get(0)->PutDate(nVal);
}
@@ -323,15 +319,11 @@ void SbRtl_CDbl(StarBASIC *, SbxArray & rPar, bool) //
JSM
void SbRtl_CInt(StarBASIC *, SbxArray & rPar, bool) // JSM
{
sal_Int16 nVal = 0;
-if (rPar.Count() == 2)
-{
-SbxVariable* pSbxVariable = rPar.Get(1);
-nVal = pSbxVariable->GetInteger();
-}
-else
-{
-StarBASIC::Error( ERRCODE_BASIC_BAD_ARGUMENT );
-}
+if (rPar.Count() != 2)
+return StarBASIC::Error( ERRCODE_BASIC_BAD_ARGUMENT );
+
+SbxVariable* pSbxVariable = rPar.Get(1);
+nVal = pSbxVariable->GetInteger();
rPar.Get(0)->PutInteger(nVal);
}
@@ -478,15 +470,11 @@ void SbRtl_Green(StarBASIC *, SbxArray & rPar, bool)
void SbRtl_Blue(StarBASIC *, SbxArray & rPar, bool)
{
if (rPar.Count() != 2)
-{
-StarBASIC::Error( ERRCODE_BASIC_BAD_ARGUMENT );
-}
-else
-{
-sal_Int32 nRGB = rPar.Get(1)->GetLong();
-nRGB &= 0x00FF;
-rPar.Get(0)->PutInteger(static_cast(nRGB));
-}
+return StarBASIC::Error( ERRCODE_BASIC_BAD_ARGUMENT );
+
+sal_Int32 nRGB = rPar.Get(1)->GetLong();
+nRGB &= 0x00FF;
+rPar.Get(0)->PutInteger(static_cast(nRGB));
}
[Bug 160589] New: Charts are not updated after data entry if freezing of columns or rows is activated
https://bugs.documentfoundation.org/show_bug.cgi?id=160589 Bug ID: 160589 Summary: Charts are not updated after data entry if freezing of columns or rows is activated Product: LibreOffice Version: 24.2.0.1 rc Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: dschei...@gmail.com Created attachment 193574 --> https://bugs.documentfoundation.org/attachment.cgi?id=193574=edit Sample file with several charts - with and without frozen columns/rows Charts should always update immediately when the data changes, without another command being executed. If column freezing or row freezing or both are used on a worksheet, the data is only updated after using "Recalculate" F9, or after changing the worksheet or scrolling to another cell range. If you have several charts on a worksheet with frozen columns and you click on one of the charts and then click again in a cell, this chart is updated immediately. The second chart will not. If you switch worksheets and return, all charts will not be updated immediately. I have not noticed the same behavior under Linux. After entering data and pressing Enter, the program was not updated immediately. However, if you made a second movement with the cursor keys, it was then updated. My System: Version: 24.2.0.1 (X86_64) / LibreOffice Community Build ID: b4d45829793cddfe67b58a53f495528c75738d8a CPU threads: 8; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win Locale: en-US (de_DE); UI: en-US Calc: threaded My tests under LO 7.6.6.3 or older behaved normally. Immediate update! -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160481] Cut does not work on chart title text
https://bugs.documentfoundation.org/show_bug.cgi?id=160481 raal changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||r...@post.cz --- Comment #3 from raal --- Confirm with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: dff57d2b4f5abd1b51ebfb0015339471f61e72f9 CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded Jumbo -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160492] libcdr: recent CorelDraw files are not loaded
https://bugs.documentfoundation.org/show_bug.cgi?id=160492 raal changed: What|Removed |Added Product|LibreOffice |Document Liberation Project Version|24.2.2.2 release|unspecified Component|filters and storage |libcdr CC||r...@post.cz -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160588] FILESAVE: Transparency-related bugs with export to PNG and WEBP
https://bugs.documentfoundation.org/show_bug.cgi?id=160588 --- Comment #3 from Archie Cobbs --- Created attachment 193573 --> https://bugs.documentfoundation.org/attachment.cgi?id=193573=edit webp-without-transparency.webp -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160588] FILESAVE: Transparency-related bugs with export to PNG and WEBP
https://bugs.documentfoundation.org/show_bug.cgi?id=160588 --- Comment #2 from Archie Cobbs --- Created attachment 193572 --> https://bugs.documentfoundation.org/attachment.cgi?id=193572=edit png-with-transparency.png -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160588] FILESAVE: Transparency-related bugs with export to PNG and WEBP
https://bugs.documentfoundation.org/show_bug.cgi?id=160588 --- Comment #1 from Archie Cobbs --- Created attachment 193571 --> https://bugs.documentfoundation.org/attachment.cgi?id=193571=edit png-without-transparency.png -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160588] New: FILESAVE: Transparency-related bugs with export to PNG and WEBP
https://bugs.documentfoundation.org/show_bug.cgi?id=160588 Bug ID: 160588 Summary: FILESAVE: Transparency-related bugs with export to PNG and WEBP Product: LibreOffice Version: 24.2.2.2 release Hardware: ARM OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: archie.co...@gmail.com Created attachment 193570 --> https://bugs.documentfoundation.org/attachment.cgi?id=193570=edit The ODG test file I'm using this build: https://git.libreoffice.org/core/+log/d56cc158d8a96260b836f100ef4b4ef25d6f1a01 The exports of PNG and WEBP have some bugs. To reproduce: 1. Open bug-example.odg in Draw 2. Export -> PNG -> Do not include transparency 3. Notice image appears normal -> see png-without-transparency.png 4. Export -> PNG -> Include transparency 5. [BUG] Notice text in image is missing color -> see png-with-transparency.png 6. Export -> WEBP 7. [BUG] Notice there is no option for "Include transparency" 8. Notice image appears normal -> see webp-without-transparency.webp -- You are receiving this mail because: You are the assignee for the bug.
core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ef802f7dbeee84262b56ab72079cd1c3a40784e0 Author: Olivier Hallot AuthorDate: Mon Apr 8 13:44:16 2024 -0300 Commit: Gerrit Code Review CommitDate: Mon Apr 8 18:44:16 2024 +0200 Update git submodules * Update helpcontent2 from branch 'master' to 8db831e3f0dce474924168d18e4f8d23fc29f731 - tdf#160179 Recalculate row height at load times + refactor Change-Id: I0a81e254a8c40487d6ca559860c02ec1f4f44912 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165890 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 4c741dd9f01c..8db831e3f0dc 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 4c741dd9f01c329e58fe6c5ae6cfcf7570c5a8c7 +Subproject commit 8db831e3f0dce474924168d18e4f8d23fc29f731
help.git: source/text
source/text/shared/optionen/01060900.xhp | 74 ++-
1 file changed, 45 insertions(+), 29 deletions(-)
New commits:
commit 8db831e3f0dce474924168d18e4f8d23fc29f731
Author: Olivier Hallot
AuthorDate: Mon Apr 8 12:49:41 2024 -0300
Commit: Olivier Hallot
CommitDate: Mon Apr 8 18:44:16 2024 +0200
tdf#160179 Recalculate row height at load times
+ refactor
Change-Id: I0a81e254a8c40487d6ca559860c02ec1f4f44912
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165890
Tested-by: Jenkins
Reviewed-by: Olivier Hallot
diff --git a/source/text/shared/optionen/01060900.xhp
b/source/text/shared/optionen/01060900.xhp
index ae6ca2244a..56cea987cb 100644
--- a/source/text/shared/optionen/01060900.xhp
+++ b/source/text/shared/optionen/01060900.xhp
@@ -20,13 +20,13 @@
-Formula
+Formula
/text/shared/optionen/01060900.xhp
-
+
formula options;formula syntax
formula options;separators
formula options;reference syntax in string
parameters
@@ -40,67 +40,83 @@
recalculating;formula options
recalculating;large spreadsheet files
loading;large spreadsheet files
+loading;optimal row height
+optimal row height;recalculation
-
-
+
+
Formula
-Defines formula syntax options and loading options for %PRODUCTNAME
Calc.
+Defines
formula syntax options and loading options for %PRODUCTNAME
Calc.
Formula options
Formula syntax
-There are
three options. Let's see it by example. In a sample spreadsheet there are two
worksheets, Sheet1 and Sheet2. In A1 cell of Sheet1 there is a reference to C4
cell of Sheet2.
+There are three options.
Let's see it by example. In a sample spreadsheet there are two worksheets,
Sheet1 and Sheet2. In A1 cell of Sheet1 there is a reference to C4 cell of
Sheet2.
-Calc A1 - This is the default of %PRODUCTNAME
Calc. The reference will be =$Sheet2.C4
+Calc A1
- This is the default of %PRODUCTNAME Calc. The reference will be =$Sheet2.C4
-Excel A1 - This is the default of Microsoft
Excel. The reference will be =Sheet2!C4
+Excel
A1 - This is the default of Microsoft Excel. The reference will be =Sheet2!C4
-Excel R1C1 - This is the relative row/column
addressing, known from Microsoft Excel. The reference will be =Sheet2!R[3]C[2]
+Excel
R1C1 - This is the relative row/column addressing, known from Microsoft
Excel. The reference will be =Sheet2!R[3]C[2]
Use English function names
-In
%PRODUCTNAME Calc function names can be localized. By default, the check box is
off, which means the localized function names are used. Checking this check box
will swap localized function names with the English ones. This change takes
effect in all of the following areas: formula input and display, function
wizard, and formula tips. You can of course uncheck it to go back to the
localized function names.
+In %PRODUCTNAME Calc
function names can be localized. By default, the check box is off, which means
the localized function names are used. Checking this check box will swap
localized function names with the English ones. This change takes effect in all
of the following areas: formula input and display, function wizard, and formula
tips. You can of course uncheck it to go back to the localized function
names.
Separators
-This
option group lets you configure separators in your formula expressions. This
comes in handy when, for instance, you want to separate your function
parameters by commas (,) instead of semicolons (;).
-For
example, instead of =SUM(A1;B1;C1) you can type =SUM(A1,B1,C1).
-Likewise,
you can also change the column and row separators for in-line arrays.
Previously, an in-line array used semicolons (;) as the column separators and
the pipe symbols (|) as the row separators, so a typical in-line array
expression looked like this for a 5 x 2 matrix array:
-={1;2;3;4;5|6;7;8;9;10}
-By
changing the column separators to commas (,) and the row separators to
semicolons (;), the same expression will look like this:
-={1,2,3,4,5;6,7,8,9,10}
+This option group lets you
configure separators in your formula expressions. This comes in handy when, for
instance, you want to separate your function parameters by commas (,) instead
of semicolons (;).
+For example, instead of
=SUM(A1;B1;C1) you can type =SUM(A1,B1,C1).
+Likewise, you can also
change the column and row separators for in-line arrays. Previously, an in-line
array used semicolons (;) as the column separators and the pipe symbols (|) as
the row separators, so a typical in-line array expression looked like this for
a 5 x 2 matrix array:
+={1;2;3;4;5|6;7;8;9;10}
+
[Bug 160587] New: Crash in: salhelper::Thread::launch()
https://bugs.documentfoundation.org/show_bug.cgi?id=160587 Bug ID: 160587 Summary: Crash in: salhelper::Thread::launch() Product: LibreOffice Version: 24.2.1.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: dcyoung...@frontiernet.net This bug was filed from the crash reporting server and is br-fcbc1d68-5d1e-4fb6-80a8-0bc6c31540a8. = This is PORTABLE version 24.2.1.2 but installed on non-portable media(hard drive). Opened existing spreadsheet from a non-root directory. Changed view to second sheet. Made changes to a chart in area of data range, stretched image. Changed view to first sheet. "Save as", entered a name. Got windows message: application has stopped working. Same thing happens with simple "Save". This has been happening with older versions, not necessarily every save, some work. 23G+ free space on HD. CLUE: On older versions sometimes get "general failure" message. Do not have accurate saved info on these. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 101704] Allow extensions to register their own button within a tab in the Notebookbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101704 --- Comment #14 from Szymon Kłos --- The problem is that current Notebookbar architecture and how it work makes it extremely hard to customize... There is no "api" for that. Requirement about adding buttons to existing tabs intersects with general customization of notebookbar - adding / removing items from Customization dialog. I was thinking about that in the past. I think the only complete solution would require lot of work and significant change in the approach to building notebookbar. It needs to be more like our toolbars - build from the definition created using some xml / JSON . Then we can modify the list to add something and it means it is possible to dynamically add something to it (currently not possible, you can only hide item). It has also tradeoff - it will be less flexible on the fly (you will need some coding to get new type of a notebookbar layout). Currently it is possible to just edit .ui file in Glade to do anything. We did mistake when planning - we set as a priority usage of .ui file to make it easy to modify by developers/designers (but in fact it's not easy! Andreas knows something about it :) ). But we should rather focus on providing best experience for the end user as a priority - real customization as a requirement. That is what I think from a time perspective :) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 154715] "Edit Fields" for cross-reference fields should open on the type, format, and selection of the inserted field
https://bugs.documentfoundation.org/show_bug.cgi?id=154715 --- Comment #14 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/843b3abd2ab05c66533b12ef6a4b155247f99e58 Resolves: tdf#154715 don't use last-used field setting when editing field It will be available in 24.2.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 154715] "Edit Fields" for cross-reference fields should open on the type, format, and selection of the inserted field
https://bugs.documentfoundation.org/show_bug.cgi?id=154715 Commit Notification changed: What|Removed |Added Whiteboard|target:24.8.0 |target:24.8.0 target:24.2.3 -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'libreoffice-24-2' - sw/source
sw/source/ui/fldui/fldref.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 843b3abd2ab05c66533b12ef6a4b155247f99e58
Author: Caolán McNamara
AuthorDate: Sun Apr 7 20:40:39 2024 +0100
Commit: Xisco Fauli
CommitDate: Mon Apr 8 17:44:21 2024 +0200
Resolves: tdf#154715 don't use last-used field setting when editing field
If we are inserting a field it makes sense to use the last-used
settings, but if we are editing an existing field we naturally want to
populate with the current field.
Here we have IsRefresh used twice as a condition, one inside the other.
But if was true in the outer use, it will also be true in the inner
(this duplication exists all the way back to the initial commit) because
GetUserData() has no side effect.
IsRefresh is only true during EditNewField (which is the case of using
the "next/back" button to go to edit another field). So even before this
change if you click next and then back (assuming there is another field
to move to) then you then get the right results
Skip restoring the last-used settings in the EditField case, replace
the outer !IsRefresh() with !IsFieldEdit()
Change-Id: I4224302171d2e8d02a0f1e0efc9fdada5ada9d7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165876
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
(cherry picked from commit db609a58df7be082de7d5a20a2a924789d6a64a1)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165840
Reviewed-by: Xisco Fauli
diff --git a/sw/source/ui/fldui/fldref.cxx b/sw/source/ui/fldui/fldref.cxx
index a08715c8ca3c..434e10a6a2f2 100644
--- a/sw/source/ui/fldui/fldref.cxx
+++ b/sw/source/ui/fldui/fldref.cxx
@@ -268,7 +268,7 @@ void SwFieldRefPage::Reset(const SfxItemSet* )
nFieldDlgFormatSel = 0;
sal_uInt16 nFormatBoxPosition = USHRT_MAX;
-if( !IsRefresh() )
+if( !IsFieldEdit() )
{
sal_Int32 nIdx{ 0 };
const OUString sUserData = GetUserData();
[Bug 160179] [LOCALHELP] Add description for expert configuration "RecalcOptimalRowHeightMode" options
https://bugs.documentfoundation.org/show_bug.cgi?id=160179 Olivier Hallot changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |olivier.hallot@libreoffice. |desktop.org |org -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160586] LibreOffice 7.6 does not load under Windows 10 64 bit.
https://bugs.documentfoundation.org/show_bug.cgi?id=160586 510jrb2...@gmail.com changed: What|Removed |Added CC||510jrb2...@gmail.com --- Comment #1 from 510jrb2...@gmail.com --- Created attachment 193569 --> https://bugs.documentfoundation.org/attachment.cgi?id=193569=edit Window troubleshooting report. Windows 10 reports the the soffice file installed under LO 7.6 is "incompatible" and thus will not load. With respect to the "choose file" tab above, I've listed a Writer file which won't open under 7.6. The browser does not list 7.6 on the Desktop. But the icon does show there. JRB -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'libreoffice-24-2' - sc/qa sc/source
sc/qa/unit/data/ods/tdf160369_groupshape.ods |binary
sc/qa/unit/scshapetest.cxx | 68 +++
sc/source/core/data/drwlayer.cxx |4 +
sc/source/filter/xml/xmlexprt.cxx| 41 +++-
4 files changed, 100 insertions(+), 13 deletions(-)
New commits:
commit 4e04b442e037a2f679b4cfe26c3e6b1c66ee8642
Author: Regina Henschel
AuthorDate: Sat Apr 6 14:59:38 2024 +0200
Commit: Xisco Fauli
CommitDate: Mon Apr 8 17:31:42 2024 +0200
tdf#160369 Do not broadcast temporarily group change
The position and size of a group needs to be temporarily changed when
saving because ODF does not treat hidden rows/cols as zero, but LO does.
After saving, these changes have to be undone. The error was that the
restore was performed with GetGeoDate/SetGeoData. But SetGeoData
includes a broadcast that triggeres recalculations that should not be
performed here. Now the change and restore are both done with NbcMove
and NbcResize.
The import had set a 'logical rectangle', but that is nonsense for a
group, because a group does not have a 'logical rectangle'.
For a group, none of the special corrections in
ScDrawLayer::InitializeCellAnchoredObj are needed.
Change-Id: I00adf39e8302492822d2900e41242d188e84
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165872
Tested-by: Jenkins
Reviewed-by: Regina Henschel
(cherry picked from commit 1e1b1d46155163380252093d9d2868351236ce0e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165839
Reviewed-by: Xisco Fauli
diff --git a/sc/qa/unit/data/ods/tdf160369_groupshape.ods
b/sc/qa/unit/data/ods/tdf160369_groupshape.ods
new file mode 100644
index ..8c26fe8ce582
Binary files /dev/null and b/sc/qa/unit/data/ods/tdf160369_groupshape.ods differ
diff --git a/sc/qa/unit/scshapetest.cxx b/sc/qa/unit/scshapetest.cxx
index 5e4827005388..c5b4b098c80e 100644
--- a/sc/qa/unit/scshapetest.cxx
+++ b/sc/qa/unit/scshapetest.cxx
@@ -1231,6 +1231,74 @@ CPPUNIT_TEST_FIXTURE(ScShapeTest,
testTdf160003_copy_page_anchored)
CPPUNIT_ASSERT_EQUAL(size_t(1), pPage->GetObjCount());
}
+CPPUNIT_TEST_FIXTURE(ScShapeTest, testTdf160369_groupshape)
+{
+// The document contains a group spanning range C5:F12. It is currently
anchored to page to
+// make sure its position does not change. When the group was anchored 'To
Cell' and rows or
+// columns were hidden before the group, saving changed the anchor
position and anchor
+// offset. This happened both with using 'resize with cell' and not.
+createScDoc("ods/tdf160369_groupshape.ods");
+
+// Get document and group object
+ScDocument* pDoc = getScDoc();
+SdrObject* pObj = lcl_getSdrObjectWithAssert(*pDoc, 0);
+
+// Anchor group 'To Cell (resize with cell)' to prepare the test.
+ScDrawLayer::SetCellAnchoredFromPosition(*pObj, *pDoc, 0 /*SCTAB*/, true
/*bResizeWithCell*/);
+
+// Hide rows 3 and 4 (UI number), which are before the group
+// Hide column D, which is inside the group
+pDoc->SetRowHidden(2, 3, 0, true);
+pDoc->SetDrawPageSize(0); // trigger recalcpos, otherwise shapes are not
changed
+pDoc->SetColHidden(3, 3, 0, true);
+pDoc->SetDrawPageSize(0);
+
+// Get geometry of the group
+ScDrawObjData* pObjData = ScDrawLayer::GetObjData(pObj);
+ScAddress aOrigStart = (*pObjData).maStart;
+ScAddress aOrigEnd = (*pObjData).maEnd;
+tools::Rectangle aOrigRect = pObj->GetSnapRect();
+
+// Save document but do not reload. Saving alone had already caused the
error.
+save("calc8");
+
+// Get geometry of the group again
+ScDrawObjData* pAfterObjData = ScDrawLayer::GetObjData(pObj);
+ScAddress aAfterStart = (*pAfterObjData).maStart;
+ScAddress aAfterEnd = (*pAfterObjData).maEnd;
+tools::Rectangle aAfterRect = pObj->GetSnapRect();
+
+// verify Orig equals After
+CPPUNIT_ASSERT_EQUAL(aOrigStart, aAfterStart);
+CPPUNIT_ASSERT_EQUAL(aOrigEnd, aAfterEnd);
+CPPUNIT_ASSERT_RECTANGLE_EQUAL_WITH_TOLERANCE(aOrigRect, aAfterRect, 1);
+
+// The same but with saveAndReload.
+createScDoc("ods/tdf160369_groupshape.ods");
+pDoc = getScDoc();
+pObj = lcl_getSdrObjectWithAssert(*pDoc, 0);
+ScDrawLayer::SetCellAnchoredFromPosition(*pObj, *pDoc, 0 /*SCTAB*/, true
/*bResizeWithCell*/);
+pDoc->SetRowHidden(2, 3, 0, true);
+pDoc->SetDrawPageSize(0); // trigger recalcpos, otherwise shapes are not
changed
+pDoc->SetColHidden(3, 3, 0, true);
+pDoc->SetDrawPageSize(0);
+
+saveAndReload("calc8");
+
+// Verify geometry is same as before save
+pDoc = getScDoc();
+pObj = lcl_getSdrObjectWithAssert(*pDoc, 0);
+pAfterObjData = ScDrawLayer::GetObjData(pObj);
+aAfterStart = (*pAfterObjData).maStart;
+aAfterEnd = (*pAfterObjData).maEnd;
+aAfterRect = pObj->GetSnapRect();
+
+// verify Orig equals After
+
[Bug 160319] Calc: add constraints on Format Cells - Format Code
https://bugs.documentfoundation.org/show_bug.cgi?id=160319 --- Comment #3 from ady --- FWIW, I never typed either "General" nor "Standard" in the Custom Code box. I either select the General/Standard item from the list, or simply delete the content of the Box and [ENTER] / click OK. When the content of the Custom Code Box is deleted and confirmed (by OK or [ENTER]), the resulting code is General/Standard. @Timur, Perhaps this is not working in the same way in some languages (other than those I am used to use in spreadsheets)? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160370] [META] Grouped objects
https://bugs.documentfoundation.org/show_bug.cgi?id=160370 Bug 160370 depends on bug 160369, which changed state. Bug 160369 Summary: Group anchored to cell below hidden row moves to next cell at save (+ visual left behind, so seems unselectable) https://bugs.documentfoundation.org/show_bug.cgi?id=160369 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 107943] [META] Save bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107943 Bug 107943 depends on bug 160369, which changed state. Bug 160369 Summary: Group anchored to cell below hidden row moves to next cell at save (+ visual left behind, so seems unselectable) https://bugs.documentfoundation.org/show_bug.cgi?id=160369 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 87740] [META] Anchor and text wrapping bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=87740 Bug 87740 depends on bug 160369, which changed state. Bug 160369 Summary: Group anchored to cell below hidden row moves to next cell at save (+ visual left behind, so seems unselectable) https://bugs.documentfoundation.org/show_bug.cgi?id=160369 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159719] SfxItemPool::IsInRange crash: save and reload in Impress or Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=159719 Commit Notification changed: What|Removed |Added Whiteboard||target:24.8.0 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159719] SfxItemPool::IsInRange crash: save and reload in Impress or Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=159719 --- Comment #12 from Commit Notification --- Armin Le Grand (allotropia) committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b4626d809b50f1d5c1aa8a9644dd3913f5b15503 tdf#159719 reset SfxPoolItemHolder when Pool changes It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
core.git: sfx2/source
sfx2/source/control/request.cxx |5 +
1 file changed, 5 insertions(+)
New commits:
commit b4626d809b50f1d5c1aa8a9644dd3913f5b15503
Author: Armin Le Grand (allotropia)
AuthorDate: Mon Apr 8 11:03:00 2024 +0200
Commit: Armin Le Grand
CommitDate: Mon Apr 8 17:16:49 2024 +0200
tdf#159719 reset SfxPoolItemHolder when Pool changes
Change-Id: Ic2724c6e03acaa8cfc74dc2aadfac6b13d8561c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165883
Tested-by: Jenkins
Tested-by: Ilmari Lauhakangas
Reviewed-by: Ilmari Lauhakangas
Reviewed-by: Armin Le Grand
diff --git a/sfx2/source/control/request.cxx b/sfx2/source/control/request.cxx
index 9406ce8b9fd3..e58475c325f1 100644
--- a/sfx2/source/control/request.cxx
+++ b/sfx2/source/control/request.cxx
@@ -109,7 +109,12 @@ void SfxRequest_Impl::SetPool( SfxItemPool *pNewPool )
{
if ( pPool )
EndListening( pPool->BC() );
+
+// tdf#159719 reset SfxPoolItemHolder
+aRetVal = SfxPoolItemHolder();
+
pPool = pNewPool;
+
if ( pNewPool )
StartListening( pNewPool->BC() );
}
[Bug 152336] Improve CSV field separator detection/behavior when several separators are selected on import
https://bugs.documentfoundation.org/show_bug.cgi?id=152336 --- Comment #14 from ady --- (In reply to Mike Kaganski from comment #13) > (In reply to m_a_riosv from comment #12) > > This is a very important issue. Please file it as a regression bug. That is now tdf#160582. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 152336] Improve CSV field separator detection/behavior when several separators are selected on import
https://bugs.documentfoundation.org/show_bug.cgi?id=152336 ady changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=16 ||0582 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160582] FILEOPEN: CSV, locale setting is not preserved in the import window (regression tdf#152336)
https://bugs.documentfoundation.org/show_bug.cgi?id=160582 ady changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||2336 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 108912] [META] Sheet-level bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108912 ady changed: What|Removed |Added Depends on||160580 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160580 [Bug 160580] Provide config option for "Wraparound" of next/previous sheet shortcut in Calc -- You are receiving this mail because: You are the assignee for the bug.
[Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=98259 ady changed: What|Removed |Added Depends on||160580 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160580 [Bug 160580] Provide config option for "Wraparound" of next/previous sheet shortcut in Calc -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160580] Provide config option for "Wraparound" of next/previous sheet shortcut in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=160580 ady changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||6311 CC||heiko.tietze@documentfounda ||tion.org, ||sorot...@gmail.com Blocks||98259, 108912 Hardware|x86-64 (AMD64) |All --- Comment #2 from ady --- While I agree with the request to have a keyboard shortcut(s) to go to the first/last worksheet(s), there are several problems with the request, unfortunately. The first problem to bind a keyboard shortcut to "navigate/go to first worksheet" (and another shortcut for the last worksheet) is that the function is not defined/listed in the Customize list. I am not sure, but I believe a new UNO command would be needed? The "second" problem related to this request is that the arrows that should allow to navigate to first/prior/next/last worksheets are not working. STR: 1. New Calc. 2. Add 3 (empty) worksheets. 3. Try to use the arrow "icons" to navigate to first/prior/next/last worksheets by clicking on any of them. > the arrows are all grayed out. AFAIR, these never worked. There is probably some bug report about this other issue. While this "second" issue is about mouse interaction instead of using the keyboard, these are probably related/connected in some area. Since this request is a consequence of tdf#156311, I am CC'ing Denis Sorotnik and Heiko. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=98259 [Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=108912 [Bug 108912] [META] Sheet-level bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160575] The "x" to close a document near the upper right hand corner is not seen when multiple documents are open
https://bugs.documentfoundation.org/show_bug.cgi?id=160575 V Stuart Foote changed: What|Removed |Added Version|24.8.0.0 alpha0+ Master |Inherited From OOo CC||vsfo...@libreoffice.org Severity|normal |enhancement Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from V Stuart Foote --- Interesting, closing all but the last open document (of any module) restores the closing 'X' of the final document. It also will "expose" the 'LibreOffice Update Available' icon. The 'X' close clickable icon button of any one document in a current session seems worth implementing. Though keyboard (e.g. +w) or by menu does provide the action. But this seems to have been inherited. Behavior present back to the 3.3.0 build. Did OOo ever support the 'X' close button when more than one document is open? =-testing-= Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 30c6e51fc9cb0fa864e1755271343d847fcced25 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded Version: 24.2.2.1 (X86_64) / LibreOffice Community Build ID: bf759d854b5ab45b6ef0bfd22e51c6dc4fb8b882 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: default; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded Version: 7.6.5.1 (X86_64) / LibreOffice Community Build ID: 7d3edae2c3c6b0c6667bcb9e3f9988f28eb82295 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded Version: 7.5.9.2 (X86_64) / LibreOffice Community Build ID: cdeefe45c17511d326101eed8008ac4092f278a9 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded Version: 6.4.7.2 (x64) Build ID: 639b8ac485750d5696d7590a72ef1b496725cfb5 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: GL; VCL: win; Locale: en-US (en_US); UI-Language: en-US Calc: CL LibreOffice 3.3.0 OOO330m19 (Build:6) tag libreoffice-3.3.0.4 -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'libreoffice-24-2' - 2 commits - svgio/CppunitTest_svgio.mk svgio/CppunitTest_svgio_tools.mk svgio/inc svgio/Library_svgio.mk svgio/qa svgio/source vcl/inc vcl/qa vcl/source vcl/workb
svgio/CppunitTest_svgio.mk|1
svgio/CppunitTest_svgio_tools.mk |1
svgio/Library_svgio.mk|2
svgio/inc/svgdocument.hxx |6 -
svgio/inc/svgnode.hxx |7 +
svgio/inc/svgswitchnode.hxx | 55 +++
svgio/inc/svgtoken.hxx|1
svgio/qa/cppunit/SvgImportTest.cxx| 23
svgio/qa/cppunit/data/tdf160386.svg | 16 +++
svgio/source/svgreader/svgdocumenthandler.cxx |9 +
svgio/source/svgreader/svgnode.cxx| 44 +++-
svgio/source/svgreader/svgswitchnode.cxx | 129 ++
svgio/source/svgreader/svgtoken.cxx |1
vcl/inc/font/LogicalFontInstance.hxx |3
vcl/inc/impfontcache.hxx |8 -
vcl/inc/impglyphitem.hxx |6 -
vcl/qa/cppunit/logicalfontinstance.cxx| 43 ++--
vcl/source/font/LogicalFontInstance.cxx | 50 --
vcl/source/font/fontcache.cxx |4
vcl/source/gdi/CommonSalLayout.cxx|6 -
vcl/source/gdi/pdfwriter_impl.cxx |4
vcl/source/gdi/sallayout.cxx | 24 ++--
vcl/source/outdev/font.cxx|4
vcl/workben/listglyphs.cxx|2
24 files changed, 367 insertions(+), 82 deletions(-)
New commits:
commit 6f4a949c07eb06345df08c722f8e59e97888a499
Author: Mike Kaganski
AuthorDate: Fri Mar 29 20:15:06 2024 +0500
Commit: Xisco Fauli
CommitDate: Mon Apr 8 16:56:31 2024 +0200
tdf#160430: Fix glyph bounds calculation, and use basegfx::B2DRectangle
... instead of tools::Rectangle.
Several problems were there:
1. First, a horizontal bounding rectangle was calculated, with due
rounding; and then the result was rotated, and after that, rounded
again. That made the resulting rotated rectangle coordinates very
imprecise.
2. Also, ceil/floor was applied without normalization; and in case
of rotated font, that meant, that sometimes the range could be not
expanded to cover partially covered pixels, but instead collapsed.
3. The rotation to angles other than 90 degree multiples was done
incorrectly, resulting in cut off parts of characters.
4. For 90 degrees, the imprecise result of sin/cos converted 0.0
into values like 3e-16, which then could be ceil'ed up to 1.
Using B2DRectangle and its transform allows to simplify and fix
the calculations easily, and avoids premature rounding. Render of
rotated text of small size is more stable with this change.
Change-Id: Idffd74b9937feb2418ab76a8d325fdaf4ff841b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165553
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
Reviewed-by: Mike Kaganski
(cherry picked from commit 8962141a12c966b2d891829925e6203bf8d51852)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165619
Reviewed-by: Xisco Fauli
diff --git a/vcl/inc/font/LogicalFontInstance.hxx
b/vcl/inc/font/LogicalFontInstance.hxx
index 40d3c57c4e67..73ba2e26a2b1 100644
--- a/vcl/inc/font/LogicalFontInstance.hxx
+++ b/vcl/inc/font/LogicalFontInstance.hxx
@@ -22,6 +22,7 @@
#include
#include
+#include
#include
#include
#include
@@ -100,7 +101,7 @@ public: // TODO: make data members private
vcl::font::PhysicalFontFace* GetFontFace() { return m_pFontFace.get(); }
const ImplFontCache* GetFontCache() const { return mpFontCache; }
-bool GetGlyphBoundRect(sal_GlyphId, tools::Rectangle&, bool) const;
+bool GetGlyphBoundRect(sal_GlyphId, basegfx::B2DRectangle&, bool) const;
virtual bool GetGlyphOutline(sal_GlyphId, basegfx::B2DPolyPolygon&, bool)
const = 0;
basegfx::B2DPolyPolygon GetGlyphOutlineUntransformed(sal_GlyphId) const;
diff --git a/vcl/inc/impfontcache.hxx b/vcl/inc/impfontcache.hxx
index 5ea19b05d9a5..4d197003b279 100644
--- a/vcl/inc/impfontcache.hxx
+++ b/vcl/inc/impfontcache.hxx
@@ -21,10 +21,10 @@
#include
+#include
#include
#include
#include
-#include
#include "font/FontSelectPattern.hxx"
#include "glyphid.hxx"
@@ -59,7 +59,7 @@ struct GlyphBoundRectCacheHash
}
};
-typedef o3tl::lru_map GlyphBoundRectCache;
class ImplFontCache
@@ -86,8 +86,8 @@ public:
LogicalFontInstance* pLogicalFont,
int nFallbackLevel, OUString& rMissingCodes );
-bool GetCachedGlyphBoundRect(const LogicalFontInstance *, sal_GlyphId,
tools::Rectangle &);
-void CacheGlyphBoundRect(const LogicalFontInstance *, sal_GlyphId,
tools::Rectangle &);
+bool GetCachedGlyphBoundRect(const LogicalFontInstance*, sal_GlyphId,
basegfx::B2DRectangle&);
+void CacheGlyphBoundRect(const LogicalFontInstance*, sal_GlyphId,
basegfx::B2DRectangle&);
voidInvalidate();
};
diff
core.git: Branch 'libreoffice-24-2' - vcl/source
vcl/source/gdi/sallayout.cxx |8
1 file changed, 4 insertions(+), 4 deletions(-)
New commits:
commit beff8cb9344f13ddbcdc667ad6b73d2d405fa21d
Author: Aron Budea
AuthorDate: Sat Apr 6 22:48:07 2024 +0200
Commit: Xisco Fauli
CommitDate: Mon Apr 8 16:55:48 2024 +0200
tdf#160342 Unwanted space before end of line when printing
Also adjust some numeric literals to reflect they're
floating point values in the expressions.
Regression from 172b500ccbc8dac0496cc2936a9bcca793c0b594.
Change-Id: I8281ba7c7d480135471ba94b11d447d76fd33063
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165860
Tested-by: Jenkins
Reviewed-by: Aron Budea
(cherry picked from commit 357f07bfd96da6cca87fcf0ef339495c2fea6937)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165836
Reviewed-by: خالد حسني
Reviewed-by: Xisco Fauli
diff --git a/vcl/source/gdi/sallayout.cxx b/vcl/source/gdi/sallayout.cxx
index af281127ba86..d052ab53221b 100644
--- a/vcl/source/gdi/sallayout.cxx
+++ b/vcl/source/gdi/sallayout.cxx
@@ -292,7 +292,7 @@ void GenericSalLayout::Justify(double nNewWidth)
std::vector::iterator pGlyphIter;
// count stretchable glyphs
int nStretchable = 0;
-double nMaxGlyphWidth = 0;
+double nMaxGlyphWidth = 0.0;
for(pGlyphIter = m_GlyphItems.begin(); pGlyphIter != pGlyphIterRight;
++pGlyphIter)
{
if( !pGlyphIter->IsInCluster() )
@@ -303,7 +303,7 @@ void GenericSalLayout::Justify(double nNewWidth)
// move rightmost glyph to requested position
nOldWidth -= pGlyphIterRight->origWidth();
-if( nOldWidth <= 0 )
+if( nOldWidth <= 0.0 )
return;
if( nNewWidth < nMaxGlyphWidth)
nNewWidth = nMaxGlyphWidth;
@@ -312,10 +312,10 @@ void GenericSalLayout::Justify(double nNewWidth)
// justify glyph widths and positions
double nDiffWidth = nNewWidth - nOldWidth;
-if( nDiffWidth >= 0) // expanded case
+if( nDiffWidth >= 0.0 ) // expanded case
{
// expand width by distributing space between glyphs evenly
-int nDeltaSum = 0;
+double nDeltaSum = 0.0;
for( pGlyphIter = m_GlyphItems.begin(); pGlyphIter != pGlyphIterRight;
++pGlyphIter )
{
// move glyph to justified position
[Bug 158556] DOCX Document That Opens/Loads Extremely Slowly
https://bugs.documentfoundation.org/show_bug.cgi?id=158556 --- Comment #19 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/4126c6b94e87f7ad2a1aa93d66bbb3edf67ec790 tdf#158556 speedup docx load It will be available in 24.2.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
