Re: [Libreoffice] [PUSHED][PATCH] SwSelBoxes: svarray - std::map

2011-11-24 Thread Caolán McNamara
On Thu, 2011-11-24 at 15:58 +, Caolán McNamara wrote: On Thu, 2011-11-24 at 23:19 +0900, Daisuke Nishino wrote: I'm not sure if this is related to the problem, but I found an obvious mistake. I hope this patch fixes it. I'm sorry for inconvenience. aha, excellent. That clear's

Re: [Libreoffice] minutes of tech. steering call ...

2011-11-25 Thread Caolán McNamara
On Thu, 2011-11-24 at 23:38 +0100, Bjoern Michaelsen wrote: However, we are not so much interested in interactively working with soffice in the subsequenttest. Rather than return to the 60s I'd still like to have an interactive debugger :-) C. ___

Re: [Libreoffice] [PUSHED][PATCH] SwSelBoxes: svarray - std::map

2011-11-25 Thread Caolán McNamara
On Fri, 2011-11-25 at 11:32 +0100, Michael Stahl wrote: On 24/11/11 21:35, Caolán McNamara wrote: On Thu, 2011-11-24 at 15:58 +, Caolán McNamara wrote: On Thu, 2011-11-24 at 23:19 +0900, Daisuke Nishino wrote: I'm not sure if this is related to the problem, but I found an obvious

[Libreoffice] [PUSHED][PATCH] Spelling: Spechial - Special

2011-11-25 Thread Caolán McNamara
On Fri, 2011-11-25 at 10:35 -0800, Mike Whiteley wrote: Should replace all misspellings of Spechial to Special. Spechial - Special SPECHIAL - SPECIAL Pushed, thanks for this. Reading the original spelling made me smile :-) C. ___ LibreOffice

Re: [Libreoffice] windows make dev-install, was build break in smoketestoo_native : LibO_*_install-arc_en-US.zip: No such file or directory

2011-11-25 Thread Caolán McNamara
On Fri, 2011-11-25 at 04:59 +0800, xuanyong.yang wrote: Hello! I got the following error in make dev-install . Any ideas? and I didn't make any changes in the code, just trying to build the master on winxp Yangxuanyong@mbp /cygdrive/x/lo $ /opt/lo/bin/make dev-install -o build Hmm, this

[Libreoffice] [PUSHED][Patch] Unreachable code ?

2011-11-25 Thread Caolán McNamara
On Wed, 2011-11-16 at 17:34 +0530, Muthu Subramanian K wrote: Hi, I have attached a trivial code removal with this mail. Marking as pushed as change is in-tree. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] Tinderbox failure, last success: 2011-11-18 20:05:29

2011-11-28 Thread Caolán McNamara
On Mon, 2011-11-28 at 11:09 +0100, Jan Holesovsky wrote: And the winner is... Miklos! Thank you for the fix, changing onmouseover to onclick for the Close button did it. Looking forward to meeting you at the conference (or earlier) to keep my promise :-) Yah, *crowd cheers*. C.

Re: [Libreoffice] Assertions and Logging

2011-11-28 Thread Caolán McNamara
On Mon, 2011-11-28 at 12:51 +0100, Michael Stahl wrote: finally, i have deployed our new aborting assertions for some definitely wrong cases in SwIndex: http://cgit.freedesktop.org/libreoffice/core/commit/?id=0d2a6999fc320843e4db0c99d961414416a8451c And I have abort on make subsequentcheck in

Re: [Libreoffice] Changes in default artwork - heads-up for 'official' TDF build providers

2011-11-29 Thread Caolán McNamara
On Tue, 2011-11-29 at 11:43 +0100, Thorsten Behrens wrote: Hi there, since the TDF trademark policy [http://wiki.documentfoundation.org/TradeMark_Policy] is rather light on the use of LibreOffice, but puts constraints on the use of the TDF mark, I've just switched our default branding

Re: [Libreoffice] Assertions and Logging

2011-11-29 Thread Caolán McNamara
On Mon, 2011-11-28 at 22:59 +0100, Michael Stahl wrote: tests in sw run for me with this, please try it out: http://cgit.freedesktop.org/libreoffice/core/commit/?id=59e298823019093ee788104c2e95cb0c7b145d05 Works for me(tm). *mumble*, paragraph anchored graphics are a pain anyway. I Would

Re: [Libreoffice] [PUSHED] [PATCH] Fix Kashida justification when there is no Kashida glyph

2011-11-29 Thread Caolán McNamara
On Mon, 2011-11-28 at 21:26 +0200, Khaled Hosny wrote: Anyway, the font can be obtained from here[1], and I'm attaching a test file that shows this issue. [1] https://sourceforge.net/projects/amiri/files/ Great, thanks. Added it as a test doc as

Re: [Libreoffice] [PUSHED] Fix for fdo39748 Easy hack: Cleanup extensions list

2011-11-29 Thread Caolán McNamara
On Tue, 2011-11-29 at 10:31 +, Michael Meeks wrote: Hi Olivier, Caolan - after the 'word count' victim dialog, it seems that the extensions dialog has a foul nightmare of manual size calulation all over it ;-) cf. the ~90 lines of: Bah, just weeping with sadness with my recent

Re: [Libreoffice] LoadComponentFromUrl misuse lead to crash

2011-11-29 Thread Caolán McNamara
On Mon, 2011-11-28 at 18:22 +0100, Laurent Godard wrote: Hi here is a summary of the bug i encounter, present in all LibO versions (master, 344, 322), but safe in OOo321 inside a macro, i launch a stardesktop.loadComponentFromUrl(firstArg, ...). if firstArg is an URL, starting with

Re: [Libreoffice] In writer some close button does not work anymore

2011-12-06 Thread Caolán McNamara
On Tue, 2011-12-06 at 13:25 +0100, Jean-Baptiste Faure wrote: Le 06/12/2011 13:13, Caolán McNamara a écrit : I suggest we revert my change on the 3-5 branch when that opens in a little while, we don't need this change right now for 3-5, and do an alternative fix on master. You certainly

[Libreoffice] [REVIEW][PATCH] crash releaseTimer on NULL mpPresTimer

2011-12-06 Thread Caolán McNamara
http://cgit.freedesktop.org/libreoffice/core/commit/?id=d57887eaad534ca51fc4975918fab66b2f93633d Reproducer at https://bugzilla.redhat.com/show_bug.cgi?id=759647 I see that the mpPresTimer in slideshow is reset when dispose is called. However a scopeGuard can still try and call releaseTimer on

[Libreoffice] [PUSHED] minor idl fixes

2011-12-06 Thread Caolán McNamara
On Wed, 2011-12-07 at 00:02 +0100, Tomas Hlavaty wrote: Hi all, attached is a patch to fix some broken IDL files. Looks sane to me, pushed, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] module wizards build is broken

2011-12-06 Thread Caolán McNamara
On Tue, 2011-12-06 at 13:49 +0100, Jean-Baptiste Faure wrote: Hi all, it's me or the build of the module wizards is broken today ? I did a fresh build : autogen.sh - make clean - make fetch - make The problem seems to be in pyfax_pyuno should be ok now I think. C.

Re: [Libreoffice] [PATCH] [NOT_URGENT] Some OSL cleanup

2011-12-07 Thread Caolán McNamara
On Wed, 2011-12-07 at 12:04 +0100, Arnaud Versini wrote: /12/7 Stephan Bergmann sberg...@redhat.com since we would not care about glibc 1, anyway, the || should be replaced with a I think. done now. C. ___ LibreOffice mailing list

Re: [Libreoffice] [ANNOUNCE] Branch libreoffice-3-5 created

2011-12-07 Thread Caolán McNamara
On Wed, 2011-12-07 at 10:53 +, Michael Meeks wrote: + tripple cross-company code review for features until nearer RC1 + exceptions: artwork, unit-tests until RC1 FWIW, I don't personally feel that triple reviews have to require cross-company reviewers, just that when we're in a

Re: [Libreoffice] Hyperlink data ...

2011-12-07 Thread Caolán McNamara
On Wed, 2011-12-07 at 12:10 +, Michael Meeks wrote: Hi there, It'd be lovely to have some thoughts on whether we should merge your patch in: https://bugs.freedesktop.org/show_bug.cgi?id=41255 HFD HyperLink Field Data overrides field contents sooner rather than

Re: [Libreoffice] candidate for a new python section in SDK examples page

2011-12-07 Thread Caolán McNamara
On Wed, 2011-12-07 at 17:07 +0100, Miklos Vajna wrote: In short, it checks if there is a funcion named g_ImplementationHelper in actual python-module-name. g_ImplementationHelper can be googled for, or opengroked. Its the magic smoke which pyuno queries to find out what services a python

[Libreoffice] [RESOLVED][PATCH] Make find-german-comments exit when given soon-to-be-removed dirs

2011-12-08 Thread Caolán McNamara
On Fri, 2011-12-02 at 23:59 +0100, Philipp Weissenbacher wrote: Hi all, Michael Meeks suggested in an earlier mail that find-german-comments should warn the user if they try to use it within soon-to-be-removed directories. This patch make f-g-c spit out an error message and quit when trying

Re: [Libreoffice] odd ND_FOONODE bits was fdo#42147: fix crash

2011-12-09 Thread Caolán McNamara
On Fri, 2011-12-09 at 09:44 +0400, Ivan Timofeev wrote: 08.12.2011 23:36, Ivan Timofeev пишет: This is not a fix for the mentioned bug, the proper fix was http://cgit.freedesktop.org/libreoffice/core/commit/?id=3524727db0f3cfecf3a47046795c527808c10c3e which is now backported to 3-4. I

Re: [Libreoffice] odd ND_FOONODE bits was fdo#42147: fix crash

2011-12-09 Thread Caolán McNamara
On Fri, 2011-12-09 at 13:31 +0100, Michael Stahl wrote: On 09/12/11 12:34, Caolán McNamara wrote: Looking at your original patch anyway it looks right to me. Can't cast something whose NodeType is ND_CONTENTNODE which is a superset of the ND_TEXTNODE bits to a SwTxtNode seeing

Re: [Libreoffice] odd ND_FOONODE bits was fdo#42147: fix crash

2011-12-09 Thread Caolán McNamara
On Fri, 2011-12-09 at 14:20 +0100, Lubos Lunak wrote: There are no SwCntntNode instances, that can be quite easily checked by explicitly marking the dtor as pure virtual. And even enforced, if that's the idea, I could commit that. Seems sane, worth a shot. substances and

Re: [Libreoffice] What is bibisect? And what is it doing in my office?

2011-12-09 Thread Caolán McNamara
On Fri, 2011-12-09 at 14:59 +0100, Bjoern Michaelsen wrote: http://people.canonical.com/~bjoern/bibisect-3.5.lzma contains: - 53 complete office installs between the creation of the core repo and the -3-5 branchoff (thats 5000 commits) - at 450MB each, that would be ~22GB total -

[Libreoffice] [PUSHED][PATCH 1/4] fdo38832 Replace ImplAccelTable with std::map

2011-12-12 Thread Caolán McNamara
On Sat, 2011-12-10 at 19:23 +0100, Marcel Metz wrote: Hello lo-devs, This patch series replaces some DECLARE_TABLE macros with the std::map equivalent. Looks good to me. Thanks for this, pushed now. C. ___ LibreOffice mailing list

Re: [Libreoffice] [PUSHED][PATCH 1/4] fdo38832 Replace ImplAccelTable with std::map

2011-12-12 Thread Caolán McNamara
On Mon, 2011-12-12 at 16:05 +, Caolán McNamara wrote: On Sat, 2011-12-10 at 19:23 +0100, Marcel Metz wrote: Hello lo-devs, This patch series replaces some DECLARE_TABLE macros with the std::map equivalent. Looks good to me. Thanks for this, pushed now. oh wait... - else

[Libreoffice] [PUSHED][PATCH 2/4] Replace Table with std::map

2011-12-12 Thread Caolán McNamara
On Sat, 2011-12-10 at 19:24 +0100, Marcel Metz wrote: --- cui/source/dialogs/pastedlg.cxx | 20 cui/source/inc/pastedlg.hxx |4 ++-- 2 files changed, 14 insertions(+), 10 deletions(-) Looks good, pushed, thanks for this :-) C.

Re: [Libreoffice] [PUSHED][PATCH 1/4] fdo38832 Replace ImplAccelTable with std::map

2011-12-12 Thread Caolán McNamara
On Mon, 2011-12-12 at 20:10 +0400, Ivan Timofeev wrote: i.e. ! is missed in replacement. Indeed, fixed up now. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED][PATCH 3/4] Replace _SvxForbiddenCharacterTable_Impl with std::map

2011-12-12 Thread Caolán McNamara
On Sat, 2011-12-10 at 19:24 +0100, Marcel Metz wrote: --- cui/source/options/optasian.cxx | 73 +++ 1 files changed, 36 insertions(+), 37 deletions(-) Looks reasonable, pushed now, thanks for this. C. p.s. I made one mod of DBG_ASSERT(pImp, language

[Libreoffice] [PUSHED][PATCH 4/4] Replace Table with std::map

2011-12-12 Thread Caolán McNamara
On Sat, 2011-12-10 at 19:24 +0100, Marcel Metz wrote: --- svl/source/misc/inettype.cxx | 38 ++ 1 files changed, 22 insertions(+), 16 deletions(-) Looks good, even turns out far more readable with all those pesky casts removed. Pushed now, thanks for

[Libreoffice] symbol visibility, windows, 3-5

2011-12-15 Thread Caolán McNamara
Looking at fdo#43422 and now looking at fdo#43707 I see that for some reason we are not exporting component_getFactory symbols under windows from some dmake-built uno libs. Anyone know when these last worked ? C. ___ LibreOffice mailing list

Re: [Libreoffice] symbol visibility, windows, 3-5

2011-12-15 Thread Caolán McNamara
On Thu, 2011-12-15 at 12:43 +, Caolán McNamara wrote: Looking at fdo#43422 and now looking at fdo#43707 I see that for some reason we are not exporting component_getFactory symbols under windows from some dmake-built uno libs. Anyone know when these last worked ? Alright, tracked down

Re: [Libreoffice] unit-test dependencies (Re: Tests on release build)

2011-12-15 Thread Caolán McNamara
On Thu, 2011-12-15 at 13:56 +0100, Michael Stahl wrote: we wouldn't have this problem if these were subsequenttests but then no one would run them :-), I still feel its far better to try and track down and fix the dependency or parallel test problem, whatever it is, then move things into a

Re: [Libreoffice] libicudata ICU data info

2011-12-16 Thread Caolán McNamara
On Thu, 2011-12-15 at 23:44 +0100, Eike Rathke wrote: Given that only systems where ICU doesn't already exist (Windows and?) would benefit from this it's surely a benevolent task for some merciful soul ;-) While distro packagers can get away with a system-icu alright, our universal Linux

Re: [Libreoffice] [REVIEW] [Fwd: Fwd: gcc 4.6.2]

2011-12-20 Thread Caolán McNamara
On Tue, 2011-12-20 at 10:13 +0100, Petr Mladek wrote: Hi Rafael, fixes for 3.4.5-rc2 need triple review, so I forward this mail to the mailing list. We've seen this problem recently with our rawhide gcc as well and 3.4.X, though 3.5.X doesn't seem to have the problem (though whether that

Re: [Libreoffice] LoadComponentFromUrl misuse lead to crash

2011-12-20 Thread Caolán McNamara
On Tue, 2011-11-29 at 13:58 +0100, Laurent Godard wrote: Hi caolan Can you attach a demo ? here is a macro showing the problem just change the myFile.ods so that it points to a file of your filestem Checked this locally (finally), and I get no crash. I get a unsupported url dialog

Re: [Libreoffice] gcc 4.6.2 + boost 1.48.0 and unordered_map assignment operator const issues [was gcc 4.6.2]

2011-12-21 Thread Caolán McNamara
On Tue, 2011-12-20 at 09:30 +, Caolán McNamara wrote: On Tue, 2011-12-20 at 10:13 +0100, Petr Mladek wrote: Hi Rafael, fixes for 3.4.5-rc2 need triple review, so I forward this mail to the mailing list. We've seen this problem recently with our rawhide gcc as well and 3.4.X

Re: [Libreoffice] [PATCH][PUSHED] Remove obsolete IsWin95A function

2011-12-21 Thread Caolán McNamara
On Mon, 2011-11-07 at 17:27 +0100, Jesús Corrius wrote: What does actually IsWin95A() return on today's systems? If it's true, then the whole if() is true. But I don't have any Windows system to test this on, and I don't really dare to just guess, as the 'return TRUE' part is a clear

Re: [Libreoffice] .: 2 commits - vcl/inc vcl/source writerfilter/inc writerfilter/source

2011-12-22 Thread Caolán McNamara
On Thu, 2011-12-22 at 08:51 +, Michael Meeks wrote: On Thu, 2011-12-22 at 01:50 +0100, Miklos Vajna wrote: removed are methods necessary for the XML dump writerfilter creates when built using dbglevel=2. I wonder if Caolan could build with dbglevel=2 with callcatcher so the

Re: [Libreoffice] [MacOS] Starting dev-install is hairy

2011-12-22 Thread Caolán McNamara
On Thu, 2011-12-22 at 20:33 +1300, James C wrote: I submitted a patch with git send-email. I presume that it is awaiting moderation. hmm, maybe not, probably worth extracting it with git format-patch and try sending it as a manual attachment. Even if it is in moderation, might be a while over

Re: [Libreoffice] [REVIEW] fdo#40482 sw: view options changed by printing

2011-12-22 Thread Caolán McNamara
On Wed, 2011-12-21 at 17:11 +0100, Michael Stahl wrote: i'd like to have the fix for $SUBJECT in 3.4.5, it is a regression introduced in 3.4.2 or 3.4.3, am too lazy to check which. http://cgit.freedesktop.org/libreoffice/core/commit/?id=89d2733e16ae6233deea6bef3193bd45c89b854c Bah :-(. Well,

[Libreoffice] [PUSHED][PATCH] Fix for fdo43460 Part XV getLength() to isEmpty()

2011-12-22 Thread Caolán McNamara
On Wed, 2011-12-21 at 20:01 -0200, Olivier Hallot wrote: Please find attached a partial fix for Easy Hack FDO43460 Pushed now, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] .: sot/Library_sot.mk

2012-01-04 Thread Caolán McNamara
On Tue, 2012-01-03 at 17:26 +0100, Michael Stahl wrote: wonder if it would make sense to define NOMINMAX globally in windows.mk probably, unless there is some other godawful chunk of windows specific code hidden somewhere which falls over and dies if it *isn't* a macro :-) C.

Re: [Libreoffice] [REVIEW] Patch for Same expression on both sides of '' in basegfx module

2012-01-04 Thread Caolán McNamara
On Tue, 2012-01-03 at 20:05 +0100, Eike Rathke wrote: Hi julien2412, On Wednesday, 2011-12-28 13:13:43 -0800, julien2412 wrote: On cppcheck report, there were 2 Same expression on both sides of '' on b2dpolypolygoncutter.cxx I don't know how this part works so I recognize it's just

[Libreoffice] [REVIEW][3-5] sequence of unfortunate writer ole object in headers problems

2012-01-05 Thread Caolán McNamara
So https://bugs.freedesktop.org/show_bug.cgi?id=43867 is a most annoying bug with a crash on mailmerging documents that contain ole objects in headers. I'd like to get the following into 3-5. Immediate crash is fixed by

[Libreoffice] [PUSHED] Replace ByteString with rtl::OString

2012-01-05 Thread Caolán McNamara
On Wed, 2012-01-04 at 23:06 +0100, Chr. Rossmanith wrote: I've finished genprnpsp.cxx and had to touch some related files as well (but didn't finish them yet). After a review and removing some unnecessary rtl:: prefices I'd like to push this modified patch. Watch out for String::Copy, i.e.

Re: [Libreoffice] Removing LibO on Windows ...

2012-01-05 Thread Caolán McNamara
On Thu, 2012-01-05 at 16:25 +0200, Tor Lillqvist wrote: IMO this doesn't make any sense: if your PC is low spec you don't _want_ this; if your PC is high spec you don't _need_ this I can't believe it. Finally somebody who agrees with me on this (and I am not being ironic), and it's Pedro

[Libreoffice] [REVIEW][3-5] fdo#44219 RHEL-4 buildbot doesn't have FT_Library_SetLcdFilter

2012-01-06 Thread Caolán McNamara
So the support for setting it isn't compiled in, so the result when deployed on a recent Ubuntu is that you get weird-ass lcdfilter colour effects around letters. Proposed fix is to hack in dlsyming FT_Library_SetLcdFilter (when dlsym functions are available) as the fallback, which seems to work.

Re: [Libreoffice] Doxygen for C/C++ URE Documentation

2012-01-06 Thread Caolán McNamara
On Thu, 2012-01-05 at 20:11 +0100, Stephan Bergmann wrote: On 01/04/2012 03:30 PM, Stephan Bergmann wrote: If there are no objections, I will commit this to master later this week. Done, http://cgit.freedesktop.org/libreoffice/core/commit/?id=58ab12acf576a765ec47cc2753ba57643e51d653

Re: [Libreoffice] [REVIEW 3-5] [PUSHED 3-5] request to cherry pick fix for fdo44172

2012-01-06 Thread Caolán McNamara
On Fri, 2012-01-06 at 09:45 +0100, David Tardon wrote: On Thu, Jan 05, 2012 at 03:31:02PM -0500, August Sodora wrote: http://cgit.freedesktop.org/libreoffice/core/commit/?id=25e84ee95954a28d9a6a1b346e6673a9a6de71cc Hi, I am pretty sure the original intent was rtl::OUStringBuffer

Re: [Libreoffice] About enabling Icedove addressbook connection for Base

2012-01-06 Thread Caolán McNamara
On Fri, 2012-01-06 at 10:04 +0100, Alexander Thurgood wrote: Well the default user profile on Mac is generally stored here : /Users/username/Library/Thunderbird/Profiles/xyz.default Excellent, that's the bit of into I wanted to check. So, the mac getConfigDir code is... #define

[Libreoffice] [REVIEW][3-5] looking for .mozilla/.thunderbird under .config dir

2012-01-06 Thread Caolán McNamara
As julien points out, we're using osl::Security::getConfigDir to find the right dir to look for .mozilla and .thunderbird etc underneath. getConfigDir uses XDG_CONFIG_DIR thesedays, but moz never did that, so I reckon we should cherry-pick

Re: [Libreoffice] Doxygen for C/C++ URE Documentation

2012-01-06 Thread Caolán McNamara
On Fri, 2012-01-06 at 11:47 +0100, Michael Stahl wrote: we still use that for IDL docu (and don't forget cosv module) damn :-( its such a big-ass chunk of code I was hopeful it was a goner. C. ___ LibreOffice mailing list

Re: [Libreoffice] minutes of ESC call ...

2012-01-06 Thread Caolán McNamara
On Thu, 2012-01-05 at 17:43 +, Michael Meeks wrote: + upgrade the internal cairo to latest stable to fix theme crasher (Fridrich) + side-effect: https://bugs.freedesktop.org/show_bug.cgi?id=44219 + in-progress (Caolan, Michael) done. C.

Re: [Libreoffice] About enabling Icedove addressbook connection for Base

2012-01-06 Thread Caolán McNamara
On Fri, 2012-01-06 at 12:03 +0100, Alexander Thurgood wrote: It is directly in the user Library folder, not Applications Support. For some reason, Thunderbird does not behave like Firefox, and does not put its configdir in Applications Support. Sure, but connectivity has... {

Re: [Libreoffice] [PATCH] About enabling Icedove addressbook connection for Base

2012-01-09 Thread Caolán McNamara
On Fri, 2012-01-06 at 14:27 -0800, julien2412 wrote: Last thing : I don't know if the change in extensions/source/abpilot/abspilot.src is useful or even right. Does the patch seem ok ? (if yes, i can commit and push it on master) Looks sane to me, go for it. C.

[Libreoffice] [PUSHED][PATCH] Replace (Byte)String with rtl::O(U)String

2012-01-10 Thread Caolán McNamara
On Tue, 2012-01-10 at 13:13 +0100, Chr. Rossmanith wrote: Hi, some more replacements for reviewing. Looks good to me, pushed now. Though I decided to just replace EqualsIgnoreCaseAscii with equalsIgnoreAsciiCase because those matchFoo things can be tricky. C.

Re: [Libreoffice] [PATCH] proposed fix for fdo#44283

2012-01-11 Thread Caolán McNamara
On Tue, 2012-01-10 at 13:38 -0800, julien2412 wrote: I replaced 0 by BROWSER_INVALIDID, it compiles and seems to work. I propose this patch : http://nabble.documentfoundation.org/file/n3648948/patch.txt patch.txt Reading your patch and also

[Libreoffice] [REVIEW][3-4] fdo#44078 boxes shown for glyph fallback with DejaVu Sans ExtraLight (he/ar)

2012-01-11 Thread Caolán McNamara
https://bugs.freedesktop.org/show_bug.cgi?id=44078 http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5id=25b90909a7a22f6900abbe9df12570a24e528c9a I've done a bit more work to fix more of the root problem in master, but the above is a minimal and should-be-safe workaround to

[Libreoffice] FATToVFat_Impl: desktop/source/app/appsys.*: windows

2012-01-12 Thread Caolán McNamara
These can be removed right ?, I mean, I don't see any use of them anywhere or anything using appsys.hxx, so appsys.hxx and appsys.cxx could be completely removed as far as I can see. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] unit test concept for draw/impress

2012-01-13 Thread Caolán McNamara
On Fri, 2012-01-13 at 06:10 +0100, Markus Mohrhard wrote: The advantage of the svg file is that it represents the visual representation extremely good and we ca easily compare it againts an reference svg file. How about pdf ? which has the advantage that all the apps can print to pdf, so can

Re: [Libreoffice] [PATCH] Drop XLFD support from fontmanager

2012-01-13 Thread Caolán McNamara
On Fri, 2012-01-13 at 13:19 +0200, Khaled Hosny wrote: XLFD support was removed in commit 269f91c (#i110171) except for parsing fonts.dir and fonts.alias. I don't think this makes much sense in fontconfig era, and dropping it simplifies the font manager a bit (I don't even think we use server

[Libreoffice] [PUSHED][PATCH] Replace (Byte)String with rtl::O(U)String

2012-01-13 Thread Caolán McNamara
On Thu, 2012-01-12 at 15:25 +0100, Chr. Rossmanith wrote: Hi, another bit of replacements for reviewing. Looks fine to me, pushed now. Could quibble about not converting converting xub_StrLen to sal_Int32 while you're at it. C. ___ LibreOffice

[Libreoffice] [PUSHED, partial][PATCH] Replace getLength() with isEmpty() in vcl/generic/fontmanager

2012-01-13 Thread Caolán McNamara
On Thu, 2012-01-12 at 15:29 +0100, Chr. Rossmanith wrote: Hi, while replacing ByteString with OString I came across some getLength() calls which might be replaced with isEmpty() Pushed the bits which aren't OUStringBuffers. C. ___ LibreOffice

Re: [Libreoffice] [PATCH] Simple fix for fontconfig.cxx to review (from cppcheck report)

2012-01-16 Thread Caolán McNamara
On Sun, 2012-01-15 at 09:48 +0400, Ivan Timofeev wrote: AFAIK in arithmetic bools are concerted to int so that true-1 and false-0. Then, the result is converted back to bool (because the function returns bool) so that 0-false and 'any other value'-true. So return bool1 - bool2 can be

[Libreoffice] embedded nulls in SvStream::ReadLine

2012-01-16 Thread Caolán McNamara
In tools/qa/cppunit/test_stream.cxx:Test I added test_readline and after poking around adding some edge-cases I see that Stream::ReadLine has the odd quirk that it ignores embedded nulls in lines it reads, i.e. foo\0bar\n is read as foobar, not foo\0bar or even foo. That seems kind of odd to me.

Re: [Libreoffice] new configmgr access API ...

2012-01-16 Thread Caolán McNamara
On Mon, 2012-01-16 at 09:18 +0100, Stephan Bergmann wrote: The UNO concept is to thread the (one and only) component context instance through the code Does the configmgr need the component context just for Components::getExternalValue, which I imagine is to handle stuff like

Re: [Libreoffice] About Same expression on both sides of '||' in LockEntrySequence.cxx

2012-01-16 Thread Caolán McNamara
On Sun, 2012-01-15 at 09:04 -0800, julien2412 wrote: First, I thought about just replacing the above line by this one : if ( !pCtx-hasType || !pCtx-hasScope ) I have no idea, but http://rfc-ref.org/RFC-TEXTS/2518/chapter23.html has... !ELEMENT lockentry (lockscope, locktype) !ELEMENT

[Libreoffice] [PUSHED][PATCH]Removed FormatterBase::SetFieldText(String const, unsigned char) listed in unusedcode.easy

2012-01-16 Thread Caolán McNamara
On Sat, 2012-01-14 at 23:55 +0100, Mariusz Dykierek wrote: Code is contributed under the LGPLv3+ / MPL pushed now as http://cgit.freedesktop.org/libreoffice/core/commit/?id=d2d730f65774564f27f3f5a0d3a1ee94db21c47f, thanks for this. C. p.s. I added removing SetFieldText from the header as

Re: [Libreoffice] [PATCH] proposed fix for fdo#44040 (seems iterator issue only)

2012-01-16 Thread Caolán McNamara
On Sat, 2012-01-14 at 11:17 -0800, julien2412 wrote: Hello, I propose the attached patch for fdo#44040 (see https://bugs.freedesktop.org/attachment.cgi?id=55580) Since I could have missed something, I would like your opinion about this. Does this work ? I worry (maybe I'm out of date on

Re: [Libreoffice] [PATCH] proposed fix for fdo#44040 (seems iterator issue only)

2012-01-16 Thread Caolán McNamara
On Mon, 2012-01-16 at 12:33 -0800, julien2412 wrote: You're right Caolan, I checked there : http://en.cppreference.com/w/cpp/container/map/erase I didn't know that it was a recent feature, just thought it was useful, so I didn't think about checking it existed :-) I'm trying right now to

[Libreoffice] [PUSHED][PATCH] Removing unused code

2012-01-16 Thread Caolán McNamara
On Mon, 2012-01-16 at 12:26 +0100, Alexander Bergmann wrote: --- sax/source/tools/fshelper.cxx | 48 - unusedcode.easy |4 --- 2 files changed, 0 insertions(+), 52 deletions(-) Looks good to me. Pushed now, thanks for these. As

Re: [Libreoffice] rounding problem with twips in writer

2012-01-17 Thread Caolán McNamara
On Tue, 2012-01-17 at 09:57 +0100, Winfried Donkers wrote: This is caused by MM100 to TWIP conversion. An A4 page is 210mm, 11906twip. The calculated document width is 210mm, 11907twip. Do you know where the code is that calculates 11907 as the result ? Does anyone have suggestions how to

Re: [Libreoffice] uno.RuntimeException when convert ODT to HTML

2012-01-17 Thread Caolán McNamara
On Mon, 2012-01-16 at 21:09 -0200, Gabriel Monnerat wrote: Hello everybody, I am trying convert one document(ODT to HTML) using one web service written in Python. self.document_loaded.dispose() uno.RuntimeException: illegal object given! No idea, probably need to be able to provide a

Re: [Libreoffice] [REVIEW] fdo#43932: try to fix paper tray settings

2012-01-17 Thread Caolán McNamara
On Fri, 2012-01-13 at 22:22 +0400, Ivan Timofeev wrote: Hi there, https://bugs.freedesktop.org/show_bug.cgi?id=43932 this patch partially reverts http://cgit.freedesktop.org/libreoffice/core/commit/?id=4cc5448ed82f13bb107695b65f39589df1e46cb9 because the following change made the option

Re: [Libreoffice] rounding problem with twips in writer

2012-01-17 Thread Caolán McNamara
On Tue, 2012-01-17 at 13:03 +0100, Winfried Donkers wrote: This is caused by MM100 to TWIP conversion. An A4 page is 210mm, 11906twip. The calculated document width is 210mm, 11907twip. Do you know where the code is that calculates 11907 as the result ? No. I know that: -a macro

Re: [Libreoffice] [PATCH] Replace (Byte)String with O(U)String

2012-01-17 Thread Caolán McNamara
On Tue, 2012-01-17 at 11:06 +0100, Chr. Rossmanith wrote: Hi, an excursion from vcl to unotools was necessary. Could someone please review this little patch? xub_StrLen is replaced as well with sal_Int32. You'll have to change the callers of RecodeString

[Libreoffice] [REVIEW][3-5] artificial italic and vertical/rotated text

2012-01-23 Thread Caolán McNamara
I'd like to get http://cgit.freedesktop.org/libreoffice/core/commit/?id=8f23e9813daae808aa2a81250b5e414dc57a3394 into 3-5. Fixes (seems to anyway) the out-of-order glyph rotation and skew-for-artifical-bold, i.e. https://bugs.freedesktop.org/show_bug.cgi?id=44856 Test case of

Re: [Libreoffice] validation documents for writer

2012-01-23 Thread Caolán McNamara
On Sun, 2012-01-22 at 12:28 +0200, Noel Grandin wrote: I thought someone was running a test-bot that downloaded all of the documents from bugzilla and loaded them? This would be ./bin/get-bugzilla-attachments-by-mimetype but its currently tuned for the mime-types I was interested in collecting

[Libreoffice] [PUSHED]PATCH] Same expression on both sides of || in if condition at libreoffice@lists.freedesktop.org (cppcheck)

2012-01-23 Thread Caolán McNamara
On Sun, 2012-01-22 at 23:21 +0100, Mariusz Dykierek wrote: I guess this is what author intended. Yeah, well with Minutes-Nanosec anyway, looks like the intention. Pushed now, thanks for this. C. ___ LibreOffice mailing list

[Libreoffice] [PUSHED][PATCH] A copy-paste bug detected by cppcheck at sdext/source/presenter/PresenterTimer.cxx:512

2012-01-23 Thread Caolán McNamara
On Sun, 2012-01-22 at 22:25 +0100, Mariusz Dykierek wrote: Attached patch fixes a copy-paste error in the condition. Seconds used twice instead of Hours. Ah indeed, good catch, looks good to me. Pushed now, thanks for this. C. ___ LibreOffice

[Libreoffice] [PUSHED][REVIEW] fdo#44983 Fix RTF import of \paperh and \paperw

2012-01-23 Thread Caolán McNamara
On Sun, 2012-01-22 at 21:56 +0100, Miklos Vajna wrote: Hi, See http://cgit.freedesktop.org/libreoffice/core/commit/?id=c39e891d4dc963d2cac9843b426494e4dc490278 Could somebody sign-off and push to -3-5, please? Looks sane to me, pushed to 3-5 now. C.

Re: [Libreoffice] [PATCH] Removed nonexistent items from unusedcode.easy

2012-01-23 Thread Caolán McNamara
On Sun, 2012-01-22 at 11:41 +0100, Mariusz Dykierek wrote: Hi, Attached patch removes from unusedcode.easy a number of methods that cannot be found in the sources within the core directory. Can someone more experienced than I am confirm that items: - CIcc*::* - boost::gregorian::*

Re: [Libreoffice] Easyhack : updating biblio.odb

2012-01-23 Thread Caolán McNamara
On Sat, 2012-01-21 at 12:36 -0800, julien2412 wrote: Hello again, I discussed about it on IRC, there's nothing to do . I updated the completed task page to remove this task. I must have made something wrong with git or else but I don't want to do this task again. These were the two

Re: [Libreoffice] [PATCH] proposed fix for fdo#44040 (seems iterator issue only)

2012-01-23 Thread Caolán McNamara
On Tue, 2012-01-17 at 11:40 -0800, julien2412 wrote: There was an extra semicolon after the while on the patch. Even if i re read several times the code, I just missed it too and needed gdb to see it ! Now it works better :-) *groan*, that was dumb of me. Do you want to commit/push it

Re: [Libreoffice] About fdo#42543

2012-01-23 Thread Caolán McNamara
On Sat, 2011-11-26 at 08:29 -0800, julien2412 wrote: Hello, By taking a look at the bug fdo#42543 (major/high NEW Report Designer Wizard missing Label display and editing capability) Is this still busted btw ? C. ___ LibreOffice mailing list

Re: [Libreoffice] Found duplicate branches for if and else in dbtree.cxx

2012-01-23 Thread Caolán McNamara
On Fri, 2012-01-20 at 23:53 -0800, julien2412 wrote: I took a look at the git history, it's been there since the initial commit on 2000. So either the if(bTable) is useless or something's missing. I have no clues, but seeing as its been like that since pre 2000, might as well just remove the

Re: [Libreoffice] DisposedException on storeToURL

2012-01-23 Thread Caolán McNamara
On Mon, 2011-11-07 at 11:35 -0500, Grover Blue wrote: I filed the following bug, but I'm hoping to get some help a bit sooner. https://bugs.freedesktop.org/show_bug.cgi?id=42314 Works for me unfortunately. Would need a standalone reproducer program I think, e.g. backtrace suggests that

Re: [Libreoffice] LO and address book wizard

2012-01-23 Thread Caolán McNamara
On Mon, 2011-11-21 at 11:39 -0500, Arno Teigseth wrote: Hi Anyone else having trouble with adding address books to Libreoffice (File-Wizard-Address book). I'm getting SDBC error on my system, _git master LO_ on linux mint 11. Have both thunderbird (repo) and evolution (repo) installed.

[Libreoffice] [PUSHED][REVIEW] Re: minor problems with format - page - organizer

2012-01-23 Thread Caolán McNamara
On Sat, 2012-01-07 at 21:37 +0200, Lior Kaplan wrote: Pushed Just marking this thread as pushed and both items apparently resolved. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] starmath / cppunit breakage in master

2010-12-29 Thread Caolán McNamara
On Sat, 2010-12-25 at 13:43 +0100, Miklos Vajna wrote: On Fri, Dec 24, 2010 at 01:41:56PM +, Caolán McNamara caol...@redhat.com wrote: Try now again, there was one cppunit header included outside those guard. I've moved it inside the guards now. Does that now work ? No, I get

Re: [Libreoffice] starmath / cppunit breakage in master

2011-01-04 Thread Caolán McNamara
On Tue, 2011-01-04 at 04:08 +0100, Miklos Vajna wrote: Hi, Looks like there is something similar in sc as well Do you still have this problem. If so can you attach your config.log. At the moment in head I think we should be preferring the boost::unordered_map as the backend. C.

[Libreoffice] [COMPLETED] Re: [PATCH] RTL_CONSTASCII_USTRINGPARAM in sw and toolkit

2011-01-04 Thread Caolán McNamara
On Sat, 2010-12-25 at 13:29 +0100, Julien Nabet wrote: I'm not sure but perhaps they're the last replaces we can do. So it would be the end of this easy task. Someone to confirm (or not !) ? I found a few in regexp, one in sd, one in sw and one in extensions and changed those. Reviewing

Re: [Libreoffice] segfault in libqa_unit.so test

2011-01-04 Thread Caolán McNamara
On Thu, 2010-12-16 at 12:57 +0100, Thomas Klausner wrote: The build on NetBSD currently fails with: Entering /disk/2/archive/libreoffice/sc/qa/unit -- - start unit test #1 on library ../../unxbsdx3.pro/lib/libqa_unit.so

Re: [Libreoffice] [PATCH] Removed dependencies on tools/solar.h

2011-01-04 Thread Caolán McNamara
On Tue, 2011-01-04 at 10:11 -0600, Norbert Thiebaud wrote: 2/ the aforementioned problem means that we would need to use sal_uIntPtr and not sal_uInt32 to convert ULONG, in order to maintain ABI. maybe we could wait for a major version boundary and officially define ULONG as uint32_t I

Re: [Libreoffice] starmath / cppunit breakage in master

2011-01-04 Thread Caolán McNamara
On Tue, 2011-01-04 at 18:05 +0100, Miklos Vajna wrote: On Tue, Jan 04, 2011 at 12:39:21PM +, Caolán McNamara caol...@redhat.com wrote: Do you still have this problem. If so can you attach your config.log. At the moment in head I think we should be preferring the boost::unordered_map

Re: [Libreoffice] starmath / cppunit breakage in master

2011-01-04 Thread Caolán McNamara
On Tue, 2011-01-04 at 19:15 +0100, Miklos Vajna wrote: I'm attaching the new build output where I guess the real error is: /usr/include/boost/unordered/detail/hash_table_impl.hpp:197:54: error: 'forward' is not a member of '_STL' Aha, well that makes more sense anyway. C++0x compiler, boost

Re: [Libreoffice] [PATCH] set RPATH correctly in the internal ICU

2011-01-05 Thread Caolán McNamara
On Wed, 2011-01-05 at 20:22 +0100, Petr Mladek wrote: Hi, our build service found broken RPATH in libicudata.so.42.1 That libicudata is the biggest nuisance, causes all sorts of problems on different platforms. Rather an odd use of an elf file as data storage IIRC and manually created by icu

<    1   2   3   4   5   6   7   8   9   10   >