Re: [Libreoffice] [PATCH] Remove TCPP support

2011-02-17 Thread Caolán McNamara
On Thu, 2011-02-17 at 10:34 +0100, Thomas Arnhold wrote: Ah, forgot one. All looks good, go for it. CSET is probably also complete foo IIRC. Though I don't know to what it referred. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] [REVIEW] Properly update column and row header selections. (fdo#34383)

2011-02-18 Thread Caolán McNamara
On Thu, 2011-02-17 at 22:59 -0500, Kohei Yoshida wrote: I'd like to cherry-pick this commit http://cgit.freedesktop.org/libreoffice/calc/commit/?id=f3df9f8674d559d38b638396cd48c9eb8f0ecca6 into libreoffice-3-3 branch, and ... into libreoffice-3-3-1 branch as well. The fix is very low

[Libreoffice] windows dll search order and cppunit

2011-02-21 Thread Caolán McNamara
So, my understanding on reading http://msdn.microsoft.com/en-us/library/ms682586%28v=vs.85%29.aspx is that there isn't a way to skip/override searching first in The directory from which the application loaded. which I believe means that... PATH=/local/bin:/path/to/solver/bin

Re: [Libreoffice] Removed ASSERT_ID and errhdl.[ch]xx

2011-02-21 Thread Caolán McNamara
On Mon, 2011-02-21 at 18:20 +0100, Thomas Arnhold wrote: SW_DLLPUBLIC void AssertFail( USHORT, const sal_Char* ); With this removed I changed the API, right? Sure, but only an internal API, the external API, i.e. the bits that extensions link to, are a subset of the ones in the ure clone dir.

Re: [Libreoffice] [PATCH] Remove SCO references in ure

2011-02-21 Thread Caolán McNamara
On Fri, 2011-02-18 at 11:37 +0100, Francois Tigeot wrote: This patch gets rid of some remaining SCO tests. Go ahead and push this yourself now. What's strange is that there were references in sal/osl/os2/ It seems the os2/ files are a straight copy of the unx/ files Yeah, this is common in

[Libreoffice] [PUSHED] Re: [EasyHacks] Protocol capitalization

2011-02-21 Thread Caolán McNamara
On Mon, 2011-02-21 at 08:59 +0100, Sébastien Le Ray wrote: Hi list, Here are two patch regarding the Easy Hack Improve Autocorrect capitalize first word in sentence (on the wiki). First one improves french autocorrection for non breaking space before : when you enter a protocol. Oh

Re: [Libreoffice] windows dll search order and cppunit

2011-02-21 Thread Caolán McNamara
On Mon, 2011-02-21 at 09:40 -0700, Tor Lillqvist wrote: deliver cppunit not into the normal solver/bin dir, but into e.g. solver/bin/other or something That was exactly my thought, too. Will implement next week once I am back from a short vacation, unless somebody beats me to it. Pushed

[Libreoffice] [PUSHED] Re: Easy Hack

2011-02-22 Thread Caolán McNamara
On Sun, 2011-02-13 at 09:12 +0100, Bálint Dózsa wrote: Hy Miklos, Thank you for the help. Here is the correction patch Looks reasonable to me, pushed now, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] [PATCH] Removed bug reporter and date

2011-02-22 Thread Caolán McNamara
On Tue, 2011-02-22 at 12:18 +0100, Christina Roßmanith wrote: ...now with attachment. These are all good, you should go ahead and push them yourself. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] modules to remove? javainstaller2, crashrep

2011-02-22 Thread Caolán McNamara
On Sun, 2011-02-13 at 21:00 +0100, Andras Timar wrote: Hi, components/javainstaller2 and components/crashrep are not built for LibreOffice. AFAIK javainstaller2 is used only by the commercial product (StarOffice/OOO). Removed this now. javainstaller2 is gone. Holding onto crashrep for

[Libreoffice] [PUSHED] Re: EasyHacks: Re-animated tests in ure/sal/osl

2011-02-22 Thread Caolán McNamara
Looks good, pushed now. I added the missing bit of the TO-DO for copying the batch.sh/.bat files into the local bin dir. I didn't debug/enable the commented out tests, but the batch/script one might work now, worth having a check of that now again. I tried a test windows build as well, but looks

[Libreoffice] [PUSHED] Re: Corrected EasyHacks: Re-animated tests in sal/qa/osl

2011-02-22 Thread Caolán McNamara
On Mon, 2011-02-21 at 22:41 +0100, Wilhelm Pflüger wrote: Now I attach a corrected patch (without the whitespace changes). I hope that this doesn't confuse additionaly I was reading the old one, so this is effectively pushed now. Thanks for this. C.

Re: [Libreoffice] binfilter, filter co: some questions

2011-02-22 Thread Caolán McNamara
On Tue, 2011-02-22 at 20:25 +0100, Pierre-André Jacquod wrote: A lot of theses if are typically like: else if (aFltName.EqualsAscii(pFilterLotus)) { DBG_BF_ASSERT(0, STRIP); } binfilter should only contain filter for StarOffice format, isn't it? It may contain support

[Libreoffice] [PUSHED] Re: [PATCH] [EasyHacks] Improve Autocorrect TWo initial capitals

2011-02-23 Thread Caolán McNamara
On Tue, 2011-02-22 at 20:27 +0100, Sébastien Le Ray wrote: Hi list, Attached patch modifies TWo CApitals autocorrect by making it spellcheck-aware. If you add TDs to your dictionary it won't be corrected to Tds anymore Most excellent. That's great :-), you can move it to the fixed list,

Re: [Libreoffice] Need help with failing cppunit tests

2011-02-23 Thread Caolán McNamara
On Wed, 2011-02-23 at 09:46 +0100, Francois Tigeot wrote: For now, I'm focussing on sc/qa/unit. Because your log shows OK (10) before it falls over and dies, I believe that the tests themselves are passing, and you are dying on exit. Could be a few reasons for that, I suppose the first one to

[Libreoffice] [PUSHED] Re: Reanimated test sal/qa/rtl/alloc

2011-02-23 Thread Caolán McNamara
On Tue, 2011-02-22 at 23:10 +0100, Wilhelm Pflüger wrote: Looks good, thanks for this, Pushed now. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Need help with failing cppunit tests

2011-02-24 Thread Caolán McNamara
On Thu, 2011-02-24 at 09:30 +0100, Francois Tigeot wrote: Next, I ran the command by hand and ... ResId without ResMgr created terminate called Running it manually in this scenario you don't have STAR_RESOURCEPATH set, see the makefile.mk C. ___

Re: [Libreoffice] [PATCH] Remove include of no more existent errhdl.hxx

2011-02-24 Thread Caolán McNamara
On Wed, 2011-02-23 at 08:46 +0100, Sébastien Le Ray wrote: Hi list, This patch removes an include which prevent debug build of sw I believe the affected dir has been removed now entirely, so redundant I guess now. C. ___ LibreOffice mailing list

Re: [Libreoffice] Assertion failure in osl_process.cxx

2011-02-24 Thread Caolán McNamara
On Wed, 2011-02-23 at 15:21 +0100, Francois Tigeot wrote: Having updated my tree to the latest master, the build now fails in ure/sal/qa/osl/process/osl_process.cxx : - Expression: compare_merged_environments(different_child_env_vars) - osl_execProc_merged_child_environment So to make it

[Libreoffice] [PUSHED] Re: [PATCH] Remove comment

2011-02-24 Thread Caolán McNamara
On Wed, 2011-02-23 at 22:17 +0100, Michael Lefevre wrote: Go on with comments suppression. Looks good, pushed, thanks for this. Are these patches submitted under our recommended LGPv3+/MPL combo ? (http://www.documentfoundation.org/develop/) C. ___

Re: [Libreoffice] Question about buiding

2011-02-24 Thread Caolán McNamara
On Thu, 2011-02-24 at 17:15 +0100, Luuk wrote: i dont have much experiance with GIT, so it tried following instruction from: http://wiki.documentfoundation.org/Development/How_to_build building was succesfull, :-) :-) when i execute: $ install/program/soffice it says: LibreOffice 3.3

Re: [Libreoffice] [PATCH] Fix replacement of $filename$ in GTK SaveAs dialogs

2011-02-24 Thread Caolán McNamara
On Thu, 2011-02-24 at 09:57 -0500, Kevin Hunter wrote: please do spit it back to me with, you should implement it this way instead OString baseName = OString(OUStringToOString( aFileObj.getName(INetURLObject::LAST_SEGMENT, true, INetURLObject::DECODE_WITH_CHARSET),

Re: [Libreoffice] [PATCH] fdo#34663 crasher

2011-02-24 Thread Caolán McNamara
On Thu, 2011-02-24 at 19:16 +, Noel Power wrote: If someone could review this for 3.3 branch that would be great This looks good if you want to apply it to 3.3. I wonder however if that's the right bugid, https://bugs.freedesktop.org/show_bug.cgi?id=34664 is You are not authorized to access

[Libreoffice] [PUSHED] Re: [PATCH] Fix replacement of $filename$ in GTK SaveAs dialogs

2011-02-24 Thread Caolán McNamara
On Thu, 2011-02-24 at 14:30 -0500, Kevin Hunter wrote: Interesting. From a different background, I worry about _all_ input. I don't know the API or internals well enough to say one way or the other, but there's no (mild) security concern here? Like giving a potentially unsanitized string

Re: [Libreoffice] Assertion failure in osl_process.cxx

2011-02-24 Thread Caolán McNamara
On Thu, 2011-02-24 at 18:49 +0100, Francois Tigeot wrote: Here you go. Hmm, I think this just boils down to that the order of environ variables is undefined after putenv. Pull and try again, and if it still fails, try dmake dbglevel=2 again and attach that output. C.

Re: [Libreoffice] Build fails without gdb installed

2011-02-24 Thread Caolán McNamara
On Thu, 2011-02-24 at 22:12 +0100, Thomas Arnhold wrote: This dependency is new, maybe because some tests got enabled. I think configure should check for gdb and turn this test on/off. It only does this if the environmental variables DEBUGCPPUNIT or debugcppunit are set. Those aren't

[Libreoffice] [PUSHED] Re: [Patch][EasyHack] Fix fdo#32376 Set default color to the current one in toolbar popups

2011-02-25 Thread Caolán McNamara
On Sat, 2011-02-12 at 02:57 +0900, KUROSAWA, Takeshi wrote: Hi, Here is a patch to fix bug 32376: Bug 32376 - [EasyHack] Set default color to the current one in toolbar popups https://bugs.freedesktop.org/show_bug.cgi?id=32376 With this patch, color selection popups remember previously

Re: [Libreoffice] Nonsense comments?

2011-02-25 Thread Caolán McNamara
On Fri, 2011-02-25 at 20:37 +0100, Christina Roßmanith wrote: I'd suggest to remove the comments. It always follows the pattern Seems reasonable, though this reminds me... timar: po files can have translator-comments in them to help translators about ambiguous terms/words, while the .src/.sdf

Re: [Libreoffice] Mac - Python scripts not visible / executable in Macros manager

2011-02-26 Thread Caolán McNamara
On Sat, 2011-02-26 at 15:11 +0100, Christian Lohmaier wrote: Hi Alexander, *, Looking at the files I found the cause, the g_exportedScripts isn't working correctly, it hides all methods. Without looking at it, this sounds sort of related to the fix for CVE-2010-0395 but that was done a long

Re: [Libreoffice] Need help with failing cppunit tests

2011-02-28 Thread Caolán McNamara
On Mon, 2011-02-28 at 20:07 +0100, Francois Tigeot wrote: Program received signal SIGSEGV, Segmentation fault. 0x000801535510 in ?? () (gdb) bt #0 0x000801535510 in ?? () #1 0x0008010b7db9 in __cxa_finalize (dso=0x0) at /usr/src/lib/libc/../libc/stdlib/atexit.c:178 #2

Re: [Libreoffice] OString += OString + char ... ?

2011-02-28 Thread Caolán McNamara
On Sun, 2011-02-27 at 04:27 -0500, Kevin Hunter wrote: Is that + operator expected to work with an O*String and a single character? From analysis with Sébastien Le Ray, it looks like what's happening is that the b OString is converted to sal_Char *, and the compiler uses int( '\n' ) (=10)

Re: [Libreoffice] [PATCH] Code cleanliness

2011-03-01 Thread Caolán McNamara
On Tue, 2011-03-01 at 13:04 +0100, Christina Roßmanith wrote: Hi Guillaume, partly pushed - only waiting for an information how to handle #n123456# bugids #n123456# bugids are Novell bugids, typically publically available, e.g. #n672421# - https://bugzilla.novell.com/show_bug.cgi?id=672421

Re: [Libreoffice] Tooltip source

2011-03-01 Thread Caolán McNamara
On Tue, 2011-03-01 at 10:05 +0100, Zongbo Zhang wrote: Hi, Could anyone here please tell me: 1. where I can find the source code for tooltips of 'deletion' and 'insertion'? So, technique for finding these is basically... find . -name *.src -exec grep STRING {} /dev/null \; which gives...

Re: [Libreoffice] [PATCH] Code cleanliness

2011-03-01 Thread Caolán McNamara
On Tue, 2011-03-01 at 19:38 +0100, Thomas Arnhold wrote: If someone has more info feel free to add :) I made a list of the ones typically in use here: http://wiki.documentfoundation.org/Development/FAQ#What_are_those_.23i.23.2Ffdo.23.2Fetc._comments C.

Re: [Libreoffice] OString += OString + char ... ?

2011-03-01 Thread Caolán McNamara
On Mon, 2011-02-28 at 22:50 +0100, Sébastien Le Ray wrote: Le Mon, 28 Feb 2011 21:45:36 +, Caolán McNamara caol...@redhat.com a écrit : On Sun, 2011-02-27 at 04:27 -0500, Kevin Hunter wrote: Three possibilities I guess, 1) remove the explicit, but I'm sure its there due to some

Re: [Libreoffice] [REVIEW] rudimentary handling for odd/even section breaks

2011-03-02 Thread Caolán McNamara
On Wed, 2011-03-02 at 12:46 +, Noel Power wrote: Hi Caolán On 04/02/11 10:14, Noel Power wrote: fix for https://bugzilla.novell.com/show_bug.cgi?id=659361 fix here http://cgit.freedesktop.org/libreoffice/writer/commit/?id=da0006a1b5d7be8411d6fbb0190c1c4d44809458 can I take it

Re: [Libreoffice] Mac - Python scripts not visible / executable in Macros manager

2011-03-02 Thread Caolán McNamara
On Sat, 2011-02-26 at 16:45 +0100, Christian Lohmaier wrote: I don't see what's wrong - python people around? this is basis-link/program/pythonscript.py at around line 360: for assignee in node.nodes: if assignee.name == 'g_exportedScripts':

Re: [Libreoffice] LO-SDK problem with Exception.hxx

2011-03-04 Thread Caolán McNamara
On Fri, 2011-03-04 at 11:35 +0100, Sergey wrote: Hello, I am trying to build my report generator with LibreOffice SDK and it fails because it can't find com/sun/star/uno/Exception.hxx Exception.hxx or Exception.hpp ? I suspect that its Exception.hpp because thats the #include in

Re: [Libreoffice] LO-SDK problem with Exception.hxx

2011-03-04 Thread Caolán McNamara
On Fri, 2011-03-04 at 12:19 +0100, Jonathan Aquilina wrote: I know not to long ago Caolan there were issues with trying to compile with gcc 4.5 is that still the case? I don't know of any gcc 4.5 issues. Was building with it regularly until a few weeks ago when I moved over to gcc 4.6.0 C.

Re: [Libreoffice] [PATCH] renamed MACASSGN_TEXTBAUST - MACASSGN_AUTOTEXT

2011-03-04 Thread Caolán McNamara
On Mon, 2011-02-28 at 10:36 +0100, Christina Roßmanith wrote: Sorry - I accidentally pushed that patch while I pushed some translation patches. So if there are any objections please explain, how I can undo this... I doubt there's any objections. Seems fine, but you could use e.g. git-revert

Re: [Libreoffice] Compiler warnings ICC

2011-03-04 Thread Caolán McNamara
On Wed, 2011-03-02 at 20:33 +0100, Kenneth Venken wrote: Hi, there are a lot of compiler warnings when building ICC. It seems that building ICC consists of extracting I guess we generally don't care that much about compiler warnings in the external modules that contain source we didn't

Re: [Libreoffice] be-BY and ns locale codes in LibreOffice

2011-03-07 Thread Caolán McNamara
On Sun, 2011-03-06 at 10:51 +0100, Andras Timar wrote: Hi, Do you know why 'be-BY' code was used in LibreOffice instead of simpler form 'be' (Belarusian)? We should follow the bcp47 guidelines as much as possible IMO, which boils down to keep them as short as possible, and only as long as

Re: [Libreoffice] http://openoffice.org/bugzilla/show_bug.cgi?id=3959 -- Outline view

2011-03-07 Thread Caolán McNamara
On Sat, 2011-03-05 at 02:50 -0500, Marc Paré wrote: I am just re-reading my to-do list of LibreOffice in Academia and one of the oldest feature request is this one. I believe 8 years in request. Do you think that this feature request will ever have a chance at being accepted? As with

Re: [Libreoffice] Mac - Python scripts not visible / executable in Macros manager

2011-03-07 Thread Caolán McNamara
On Thu, 2011-03-03 at 01:07 +0100, Christian Lohmaier wrote: Yes, I wonder why it fails here :-( Gagh, that's frustrating. Can you stick a try: except: block around it and see if an exception is throw, and if so print what it is, e.g. http://docs.python.org/library/traceback.html C.

Re: [Libreoffice] Mac - Python scripts not visible / executable in Macros manager

2011-03-07 Thread Caolán McNamara
On Mon, 2011-03-07 at 16:02 +0100, Christian Lohmaier wrote: The Tuple is a Node-type, that in turn contains a nodes attribute, iterating over those nodes works, so the fix is: - for item in node.expr: + for item in node.expr.nodes: Groan, right, gotcha. The Tuple isn't a tuple. I suggest

Re: [Libreoffice] Mac - Python scripts not visible / executable in Macros manager

2011-03-07 Thread Caolán McNamara
On Mon, 2011-03-07 at 16:37 +0100, Christian Lohmaier wrote: pushed as bef88b2 - so yes, please push also to release-branch, then close https://bugs.freedesktop.org/show_bug.cgi?id=33355 done. C. ___ LibreOffice mailing list

Re: [Libreoffice] No full justification in master?

2011-03-07 Thread Caolán McNamara
On Wed, 2011-03-02 at 16:03 +0200, Khaled Hosny wrote: On Tue, Mar 01, 2011 at 05:19:36PM +0100, Thomas Arnhold wrote: Hi Khaled, On 03/01/2011 05:10 PM, Khaled Hosny wrote: In locally built libreoffice master I can't get full justification; text is kept left aligned. I tested with

Re: [Libreoffice] Need help with failing cppunit tests

2011-03-07 Thread Caolán McNamara
On Mon, 2011-03-07 at 13:49 +0100, Francois Tigeot wrote: Maybe, maybe not. The cppunit tests build long chains of destructors which may not be present in a real-world situation. Nah, the real-world list is staggering long :-) I've not yet encountered a single LibreOffice crash. FWIW they'd

Re: [Libreoffice] [PATCH] Gentoo patches from old build repository for master

2011-03-07 Thread Caolán McNamara
On Mon, 2011-03-07 at 19:03 +0100, Hanno Meyer-Thurow wrote: 1. Do not add compiler default include and library path: potentially build against different version of system library than requested by the user (i.e., /usr/local/lib vs /usr/lib). Report:

Re: [Libreoffice] [PATCH] Gentoo patches from old build repository for master

2011-03-08 Thread Caolán McNamara
On Mon, 2011-03-07 at 22:54 +0100, Hanno Meyer-Thurow wrote: On Mon, 07 Mar 2011 20:44:04 + Caolán McNamara caol...@redhat.com wrote: On Mon, 2011-03-07 at 19:03 +0100, Hanno Meyer-Thurow wrote: 1. Do not add compiler default include and library path: potentially build against

Re: [Libreoffice] Using LibreOffice Editor as a widget in a third-party application

2011-03-08 Thread Caolán McNamara
On Tue, 2011-03-08 at 21:46 +0530, Sankar P wrote: Hi, Is it possible to use LibreOffice editor as a widget for my application ? Probably suboptiomal, but FWIW there's a) the officebean for java in bean don't know how well that works b) the nsplugin/plugin stuff in extensions intended to

[Libreoffice] [PUSHED] Re: [PATCH] Add non blank characters in Writter properties dialog.

2011-03-08 Thread Caolán McNamara
On Fri, 2011-03-04 at 21:52 +0100, Arnaud Versini wrote: Hello, This patch add non blank characters count in Properties in Writter. Looks like this slipped through the cracks, file-properties-statistics of course, and show the same data as available from the word count dialog. Thanks for

Re: [Libreoffice] [PATCH] Gentoo patches from old build repository for master

2011-03-08 Thread Caolán McNamara
On Tue, 2011-03-08 at 19:48 +0100, Hanno Meyer-Thurow wrote: I was thinking more that osl_getHomeDir/getConfigDir should return osl_getTempDirURL as a fallback if they can't get any other result ? Just for clarification, I do not want to add the sal-sandbox.dff hack but rather a silly

Re: [Libreoffice] [PATCH] Gentoo patches from old build repository for master

2011-03-09 Thread Caolán McNamara
On Tue, 2011-03-08 at 22:41 +0100, Hanno Meyer-Thurow wrote: I guess/hope that is a nobrainer now. Sure, looks harmless. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Problem in module bean

2011-03-09 Thread Caolán McNamara
On Wed, 2011-03-09 at 10:05 +, Wols Lists wrote: OMG - this is a long time ago !!! But I've just managed to get back to it and run this. The diagnosis is spot on - cannot find -ljawt. Digging further, it looks like it's looking for it in solenv/unxlngx6 or solver/330 or

Re: [Libreoffice] Using LibreOffice Editor as a widget in a third-party application

2011-03-09 Thread Caolán McNamara
On Wed, 2011-03-09 at 18:29 +0530, Sankar P wrote: I was actually trying to implement a basic offline blog editor, such that we can use LibreOffice (editor) to compose blogs and then publish them to blogger/wordpress etc. If you want to hack LibreOffice to be a useful blogging tool, then

Re: [Libreoffice] [PUSHED] remove unused declaration - an unlikely fix for armel segfault in regcomp

2011-03-09 Thread Caolán McNamara
On Wed, 2011-03-09 at 10:46 +0200, Jani Monoses wrote: On 01/29/2011 03:04 PM, Caolán McNamara wrote: On Thu, 2011-01-27 at 20:13 +0200, Jani Monoses wrote: What about using GCC atomic builtins like in the attached patch? Excellent, the pthread fallback always niggled me. Sorry

[Libreoffice] [PUSHED] Re: [PATCH] remove SVX_LIGHT macro

2011-03-09 Thread Caolán McNamara
On Tue, 2011-03-08 at 23:13 +0100, Xavier ALT wrote: Hi guys, Attached patchs about removing the unused SVX_LIGHT macro - easy hacks (under LGPLv3+/MPL). Can somebody review it? Looks good, thanks for this. Pushed now. C. ___ LibreOffice mailing

[Libreoffice] [PUSHED] Re: framework::DropdownToolbarController: dispatch does not get selected item text

2011-03-09 Thread Caolán McNamara
On Wed, 2011-02-23 at 19:57 +0100, Dietmar wrote: Here you are: https://bugs.freedesktop.org/show_bug.cgi?id=34635 So, the code has changed a good lot since the original OOo bug was reported. But looking through the current call of GetText in dropdownboxtoolbarcontroller.cxx as far as I can

Re: [Libreoffice] Using LibreOffice Editor as a widget in a third-party application

2011-03-09 Thread Caolán McNamara
On Wed, 2011-03-09 at 22:08 +0530, Sankar P wrote: Thanks for the help. I will see if I can do something over the weekend. The main stopping point for me to give any patch to LO is its sheer build-size. Well, the oooblogger stuff is all in python, so, in theory at least, just needs

Re: [Libreoffice] Fonts trouble in Math formulas

2011-03-11 Thread Caolán McNamara
On Fri, 2011-03-11 at 18:07 +0300, Alexander wrote: Hi ! I get problem when type/edit formulas in LO. Trouble in all version LO up to currently (3.3.2rc1). I use Debian. In OOo all Ok. And what version of OOo ?, this might simply be having an older opensymbol font installed somewhere

Re: [Libreoffice] Daily Build broken on Mac

2011-03-11 Thread Caolán McNamara
On Fri, 2011-03-11 at 09:46 -0600, Norbert Thiebaud wrote: Looks like a icu4c-aix.patch, unsurprisingly ;-), does not apply anymore I think I fixed that patch earlier. Though there seems to be another problem on mac as well. We also however a tricky windows problem, we munge the .vcproj

[Libreoffice] [PUSHED] Re: [PATCH] 1/2 fdo#34896 make color palette size consistent

2011-03-11 Thread Caolán McNamara
On Mon, 2011-03-07 at 18:20 +0100, Xavier ALT wrote: Le 06/03/2011 10:31, Xavier ALT a écrit : Hi, This patch series fix make the color palette size consistent everywhere. Related to bug fdo#34896 (https://bugs.freedesktop.org//show_bug.cgi?id=34896) Looks good to me, pushed now.

[Libreoffice] [PUSHED] Re: [PATCH] 2/2 fdo#34896 make color palette size consistent

2011-03-11 Thread Caolán McNamara
On Sun, 2011-03-06 at 10:33 +0100, Xavier ALT wrote: second patch. Also looks good, pushed, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] nullptr, was: Suggestion: Let's switch to using MSVC2010 on Windows for master

2011-03-14 Thread Caolán McNamara
On Mon, 2011-03-14 at 04:07 -0600, Tor Lillqvist wrote: is nullptr supported in the gcc versions used on other platforms? So is it better to just use 0 cast to the appropriate pointer type instead? AFAIK nullptr is part of c++0x and available on gcc = 4.6.0 in c++0x as a built-in. It might be

Re: [Libreoffice] l10n based on PO files

2011-03-14 Thread Caolán McNamara
On Sun, 2011-03-13 at 22:09 +0100, Andras Timar wrote: The 'translations' module at http://cgit.freedesktop.org/~timar/translations/ is fully functional now. Currently only two languages are imported, Czech and Hungarian. What's the 1000 meter view on this, i.e. the .sdf containing l10n is

Re: [Libreoffice] Rewiew needed for pythonscript.py patch (new try)

2011-03-14 Thread Caolán McNamara
On Sat, 2011-03-12 at 23:43 +0100, Julien Nabet wrote: And now, ladies and gentlemen, the patch ! :-) Why the addition of a uri = expandUri( name ) into replaceByName ?, i.e. this hunk @@ -962,8 +964,9 @@ class PythonScriptProvider( unohelper.Base, XBrowseNode, XScriptProvider, XNameC

Re: [Libreoffice] Rewiew needed for pythonscript.py patch (new try)

2011-03-14 Thread Caolán McNamara
On Mon, 2011-03-14 at 12:56 +, serv serva wrote: Hello, I added this because of a warning (error) with pychecker. On the contrary of the other blocks, the variable uri wasn't declared and initialized whereas it was used in this block. Ah, i see it now, its a use of that uri inside the

Re: [Libreoffice] Paste not working, paste special first row is empty

2011-03-14 Thread Caolán McNamara
On Sat, 2011-03-12 at 11:25 +0100, Kálmán „KAMI” Szalai wrote: Hi LibreOffice Bug Hunters! I am hitting this problem time by time. However I have no safe way to always reproduce it, I ask you to try to fix it in the next main release: The ideal bug is reproducible, has a short test-case and

[Libreoffice] [PUSHED] Re: [PATCH] Translate an error message

2011-03-14 Thread Caolán McNamara
On Mon, 2011-03-07 at 04:27 +0100, Martin Kepplinger wrote: This translates an error message from german to english. Looks good, pushed, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[Libreoffice] [PUSHED] Re: [PATCH 1/2] Remove reference to unavailable bugtrackers

2011-03-14 Thread Caolán McNamara
On Mon, 2011-03-07 at 12:25 +0100, Martin Kepplinger wrote: This removes references to some internel bugtrackers that are (according to http://wiki.documentfoundation.org/Development/FAQ ) not available to the community in writer/starmath. I see you pushed these already, as an aside, in case

Re: [Libreoffice] [PATCH] Remove most of dead code in libs-core

2011-03-14 Thread Caolán McNamara
On Tue, 2011-03-08 at 21:06 +0100, Xisco Faulí wrote: Hello, I've been working on removing dead code in libs-core for a while ago. I'd say libs-core it's now 98-99% dead code free. I'm reading through these at the moment, so taking a lock on review, there's quite a few of them ;-) I'm not

Re: [Libreoffice] Fonts trouble in Math formulas

2011-03-15 Thread Caolán McNamara
On Tue, 2011-03-15 at 12:13 +0100, Petr Mladek wrote: Mailing list is not the best place to organize, prioritize, and track bug reports. Sorry, off list we determined that this is https://bugs.freedesktop.org/show_bug.cgi?id=30729 i.e. the bugs that affects OOo and LibO where if the old

Re: [Libreoffice] Fonts trouble in Math formulas

2011-03-15 Thread Caolán McNamara
On Tue, 2011-03-15 at 13:36 +, Michael Meeks wrote: Fun indeed :-) this seems to happen quite a lot. I wonder if there is some way we can clobber this by forcing the path in some hard way, or does that give lots of vile per-platform problems. The (probable) right way is to pull the

Re: [Libreoffice] User Profile dialog

2011-03-15 Thread Caolán McNamara
On Tue, 2011-03-15 at 16:06 +0100, Zongbo Zhang wrote: Hi all, Could anyone here please tell me where can I find the source code portion that is in charge of the User Data dialog of the Writer? What dialog ?, typically can find these with, e.g. find . -name *.src -exec grep english_string {}

Re: [Libreoffice] User Profile dialog

2011-03-15 Thread Caolán McNamara
On Tue, 2011-03-15 at 16:45 +0100, Zongbo Zhang wrote: Hello, Thanks a lot for the reply, I am looking for the Tools-options-User Data. under the Writer. cui/source/options/optgenrl.src contain the string/layout for that dialog, and cui/source/options/optgenrl.cxx is its implementation. C.

Re: [Libreoffice] Fix Bug 32559

2011-03-15 Thread Caolán McNamara
On Wed, 2011-03-09 at 15:50 +0100, Bálint Dózsa wrote: Hi, Here is the correction patch This looks reasonable so far, though it might be better to avoid hardcoding a case KEY_F3 | KEY_SHIFT to run this stuff, and instead move it around a bit to make it configurable, (though that seems like a

Re: [Libreoffice] [PUSHED] remove unused declaration - an unlikely fix for armel segfault in regcomp

2011-03-15 Thread Caolán McNamara
On Wed, 2011-03-09 at 20:54 +0200, Jani Monoses wrote: On 03/09/2011 06:01 PM, Caolán McNamara wrote: On Wed, 2011-03-09 at 10:46 +0200, Jani Monoses wrote: On 01/29/2011 03:04 PM, Caolán McNamara wrote: On Thu, 2011-01-27 at 20:13 +0200, Jani Monoses wrote: What about using GCC atomic

Re: [Libreoffice] nullptr, was: Suggestion: Let's switch to using MSVC2010 on Windows for master

2011-03-15 Thread Caolán McNamara
On Tue, 2011-03-15 at 18:58 +0100, Jesús Corrius wrote: Have you looked at what I did for Python to compile it with VS2010? It looks like the same problem. In this case icu 4.6 comes with vc2010 .vcxproj files, but we'd like to build it with vc2008. Any of (gnu)make files, nmake stuff or

Re: [Libreoffice] ICU Build breakage in master on OSX

2011-03-15 Thread Caolán McNamara
On Tue, 2011-03-15 at 18:29 +0100, Alexander Thurgood wrote: -DU_CC=\ccache gcc-4.0\ Looking at icuinfo.cpp, it doesn't look like there is a problem with the double quoting around the printf statements The compiler is probably seeing basically... -DU_CC=ccache as the define Sticking a

Re: [Libreoffice] [PATCH] remove String with OUString

2011-03-16 Thread Caolán McNamara
On Wed, 2011-03-16 at 13:55 +0100, Xisco Faulí wrote: Hello, It's the first time I do it so I searched for previous commits in order to get a referent. i couldn't find any example for String.AssignAscii so I replace it with OUStringBuffer.appendAscii. Yeah, that's probably the best route.

Re: [Libreoffice] l10n based on PO files

2011-03-16 Thread Caolán McNamara
On Wed, 2011-03-16 at 08:42 -0600, Tor Lillqvist wrote: Or, just have LibreOffice set a LANGUAGE environment variable to correspond to its current UI language before invoking the libintl functions. There's a hack in the gtk fpicker (source/unx/gnome/SalGtkPicker.cxx) to do the above, we should

Re: [Libreoffice] Fix Bug 32559

2011-03-16 Thread Caolán McNamara
On Wed, 2011-03-16 at 21:45 +0100, Bálint Dózsa wrote: Hi, Here is a modification. (Shift+F3 is not hardcoded) Cool, this looks good stuff on first glance. Probably a few open questions around handling the e.g. annotation shell for using it inside those insert-comment things, and whether it

[Libreoffice] need some acks for 3-3 and fdo#35405 es thesaurus crash

2011-03-18 Thread Caolán McNamara
See https://bugs.freedesktop.org/show_bug.cgi?id=35405 and fix of http://cgit.freedesktop.org/libreoffice/libs-extern/commit/?h=libreoffice-3-3id=896c49083aec918b0710f9c62f2f775a53f28057 I'd like to backport this rather mythes trivial crasher fix to 3-3-2 C.

[Libreoffice] [PUSHED] Re: [PATCH] Fix and enable more unit tests in sal/qa/rtl

2011-03-18 Thread Caolán McNamara
On Thu, 2011-03-17 at 14:50 +0100, Theo van Klaveren wrote: Hello again, More unit test hacking. Only the ones that work are enabled. Looks good, pushed, thanks for these. Some questions that are coming up: - Some unit tests contain .xsce files that seem to be used to tell told the old

[Libreoffice] [feature] cairo text rendering, now with lcdfiltering

2011-03-18 Thread Caolán McNamara
I recently modified the cairo text rendering (in VCL) to use cairo_ft_font_face_create_for_pattern instead of cairo_ft_font_face_create_for_ft_face which means that LibreOffice gets the same lcdfilter/coloured subpixeling out of the box that other fontconfig+cairo using apps get when the

Re: [Libreoffice] SwItemPropertySet

2011-03-18 Thread Caolán McNamara
On Wed, 2011-03-16 at 20:59 +0100, Christina Roßmanith wrote: Hi, during removal of comments it became obvious that SwItemPropertySet::FillItem always returns sal_FALSE. Further searching for SwItemPropertySet with grok only finds it in unomap.hxx and unomap.cxx Yeah, I agree it seems

[Libreoffice] Review requests for mailmerge to email fixes

2011-03-18 Thread Caolán McNamara
There's a cluster of messy mail merge related bugs. https://bugs.freedesktop.org/show_bug.cgi?id=32553 https://bugs.freedesktop.org/show_bug.cgi?id=31792 https://bugs.freedesktop.org/show_bug.cgi?id=34187 and I'd like backport three concrete and fairly trivial fixes which address the

[Libreoffice] [PUSHED] Re: Fix Bug 32559

2011-03-21 Thread Caolán McNamara
On Sat, 2011-03-19 at 15:12 +0100, Bálint Dózsa wrote: I did tentatively the modification for calc, and draw. It works for me. So, all pushed, thanks for these and your work. There are some potential improvements, e.g. the case rotation works off a counter which on the face of it would seem

Re: [Libreoffice] [PUSHED] Re: Fix Bug 32559

2011-03-21 Thread Caolán McNamara
On Mon, 2011-03-21 at 17:36 +0100, Bálint Dózsa wrote: I will try to change this. So we need to detect the current case of the word. When the word is APPLE: nF3ShiftCounter=2; When the word is Apple: nF3ShiftCounter=1; And when the word is apple: nF3ShiftCounter=0; basically yeah, and

Re: [Libreoffice] Compiled failed in sw

2011-03-22 Thread Caolán McNamara
On Tue, 2011-03-22 at 10:14 +0100, Miklos Vajna wrote: On Tue, Mar 22, 2011 at 01:57:29AM +0100, Miklos Vajna vmik...@frugalware.org wrote: No, I got sw to build with gnumake already, though I get the same error after the last pull. I just started a full rebuild; if it's there, it worths

Re: [Libreoffice] Disabling unit tests building?

2011-03-22 Thread Caolán McNamara
On Tue, 2011-03-22 at 01:48 -0500, Norbert Thiebaud wrote: I think the issue here is that if you make the top level default target (all) mean 'build-only' you decrease the odd of the tests being covered. As a data point, post-merge of new build system stuff, passive component registration and

Re: [Libreoffice] Deliver and build tree size

2011-03-22 Thread Caolán McNamara
On Mon, 2011-03-21 at 14:32 +0100, Bjoern Michaelsen wrote: Hi all, I just enabled striping on link for gbuild on Linux unless you explicitly requested symbols, by setting SYMBOL/SYMBOLS or DEBUG:

Re: [Libreoffice] Deliver and build tree size

2011-03-22 Thread Caolán McNamara
On Tue, 2011-03-22 at 12:28 +0100, Bjoern Michaelsen wrote: +1 in general. Maybe we should stick with ENABLE_SYMBOLS (which is the usual configure convention) and get rid of the SYMBOL/SYMBOLS variables, although is a bit more to type when one uses make -sr ENABLE_SYMBOLS=TRUE. Your choice. I

[Libreoffice] linux.mk and ppc, arm, etc and gmake build

2011-03-22 Thread Caolán McNamara
So, the new solenv/gbuild/platform/linux.mk only supports x86 and x86_64, no ppc, no arm, etc. e.g. -DX86/-DX86_64 and, DLLPOSTFIX of lx/li etc. We factored out the older dmake ones a while ago, so its not too hard to see the little bits that are different per-platform. I suggest that I stick

Re: [Libreoffice] [PATCH] [PUSHED] remove String with OUString

2011-03-22 Thread Caolán McNamara
On Tue, 2011-03-22 at 08:11 +0100, David Tardon wrote: On Tue, Mar 15, 2011 at 01:10:58PM +0100, Xisco Faulí wrote: Hello, It's the first time I do it so I searched for previous commits in order to get a referent. i couldn't find any example for String.AssignAscii so I replace it

Re: [Libreoffice] [PATCH] [PUSHED] remove String with OUString

2011-03-22 Thread Caolán McNamara
On Tue, 2011-03-22 at 16:39 +, Caolán McNamara wrote: among others Yeah, the catch is that there's a hierarchy of virtual methods in there, we can't change *some* of the signatures on impls of a specific virtual method we need to change all or none. I'll have to revert this for a bit because

Re: [Libreoffice] typos in configure script

2011-03-22 Thread Caolán McNamara
On Tue, 2011-03-22 at 20:38 +0100, Christina Roßmanith wrote: Hi, I think it should read some packagers may wish (instead of with) to build without. and template (instead of temaplte). Is configure built from configure.in? Yes, make your changes in configure.in C.

Re: [Libreoffice] Assertion failure in osl_process.cxx

2011-03-22 Thread Caolán McNamara
On Tue, 2011-03-22 at 16:59 +0100, Xisco Faulí wrote: Hello, I've just tried to build libreoffice and I get the same problem. First I pulled it, then export VALGRIND=memcheck and finally make check. hmm, with VALGRIND=memcheck there is indeed a diff between child and parent environments,

Re: git branch audit ...

2012-07-19 Thread Caolán McNamara
On Wed, 2012-07-18 at 17:51 +0100, Michael Meeks wrote: origin/feature/cmclayouttrans A work in progress, to munge translating .ui files into our localization mechanism. Extraction of translatables done, re-insertion still a to-do :-) C. ___

<    3   4   5   6   7   8   9   10   11   12   >