Re: [Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM in sw and toolkit

2010-12-27 Thread David Tardon
On Sat, Dec 25, 2010 at 01:17:12PM +0100, Julien Nabet wrote: Hello, Here are 2 patches for RTL_CONSTASCII_USTRINGPARAM in sw and toolkit Compiling was ok with HAVE_CXX0X forced (since I've got gcc 4.5.1) Julien (LGPLv3+ / MPL) Pushed, thanks! D.

Re: [Libreoffice] [PATCH] typo fix in helppacks.ulf

2010-12-27 Thread David Tardon
On Sun, Dec 19, 2010 at 07:59:57PM +0100, Andras Timar wrote: Hi, Please review and commit. Thanks, Andras Pushed, thanks! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] [PATCH] cppcheck cleaning in svx

2010-12-29 Thread David Tardon
On Mon, Dec 27, 2010 at 10:22:19PM +0100, Julien Nabet wrote: Hello, Here is a patch for cppcheck cleaning in svx Compiling was ok (Sorry for the last message, i forgot to put the attachment). Julien (LGPLv3+ / MPL) Pushed. D. ___

Re: [Libreoffice] [PATCH] [PUSHED] cppcheck cleaning in svx

2010-12-29 Thread David Tardon
___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] RTL_CONSTASCII_USTRINGPARAM in sw and toolkit

2010-12-29 Thread David Tardon
___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] typo fix in helppacks.ulf

2010-12-29 Thread David Tardon
___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] code cleanup and fix typos in comments

2010-12-29 Thread David Tardon
___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] cppcheck prefix operator in components

2010-12-29 Thread David Tardon
___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] cppcheck cleaning in vcl

2011-01-03 Thread David Tardon
On Thu, Dec 30, 2010 at 06:43:12PM +0100, Julien Nabet wrote: Hello, Here is a patch for cppcheck cleaning in vcl Compiling was ok. I'm not sure if what I did about realloc pb in the file : vcl/unx/source/gdi/xlfd_attr.cxx was sufficient (even correct !). If Enlarge() failed, Insert()

Re: [Libreoffice] [PATCH] [PUSHED] cppcheck cleaning in vcl

2011-01-03 Thread David Tardon
On Tue, Jan 04, 2011 at 08:23:36AM +0100, David Tardon wrote: On Thu, Dec 30, 2010 at 06:43:12PM +0100, Julien Nabet wrote: Hello, Here is a patch for cppcheck cleaning in vcl Compiling was ok. I'm not sure if what I did about realloc pb in the file : vcl/unx/source/gdi

Re: [Libreoffice] [PATCH] [PUSHED] new cppcheck cleaning in svx

2011-01-03 Thread David Tardon
On Fri, Dec 31, 2010 at 03:04:29PM +0100, Julien Nabet wrote: Hello, Here is a new patch for cppcheck cleaning in svx Compiling was ok I have no more this pb : [./svdotxln.cxx:67]: (style) The class 'ImpSdrObjTextLink' does not have a constructor. Julien (LGPLv3+ / MPL) commit

Re: [Libreoffice] Bogus comments removal from VCL Unix

2011-01-04 Thread David Tardon
On Sat, Jan 01, 2011 at 02:51:47PM +0200, Roth Robert wrote: Patch co-licensed as usual under LGPLv3+, GPLv3+ and MPL licenses. Patch made for the VCL directory, I think that's the libs-gui repository. Robert Pushed, thanks! D. ___ LibreOffice

Re: [Libreoffice] [PATCH] CppCheck cleanliness in bootstrap

2011-01-05 Thread David Tardon
On Tue, Jan 04, 2011 at 10:41:26PM +0100, Guillaume Poussel wrote: Hi everybody, I've started to look at the huge listhttp://libreoffice.boldandbusted.com/of defects that Cpp Check show. I have corrected few things in bootstrap. The rest should be false positive or errors in dmake/ folder.

Re: [Libreoffice] [PATCH] [PUSHED] CppCheck cleanliness in bootstrap

2011-01-05 Thread David Tardon
On Wed, Jan 05, 2011 at 09:10:51AM +0100, David Tardon wrote: On Tue, Jan 04, 2011 at 10:41:26PM +0100, Guillaume Poussel wrote: Hi everybody, I've started to look at the huge listhttp://libreoffice.boldandbusted.com/of defects that Cpp Check show. I have corrected few things

Re: [Libreoffice] [PATCH] Remove DECLARE_LIST( EditList, AppWIn*)

2011-01-06 Thread David Tardon
On Wed, Jan 05, 2011 at 11:05:02AM +, Noel Power wrote: Hi Joseph On -10/01/37 20:59, Joseph Powers wrote: The attached patch compiles and stands up to my limited testing; however, it's a large patch and touches a lot of sensitive code so I want someone with better knowledge of the

Re: [Libreoffice] [PATCH] some changes for better performance, writer.

2011-01-09 Thread David Tardon
On Tue, Jan 10, 2006 at 08:09:17PM -0300, Kayo Hamid wrote: diff --git a/sw/source/core/access/acccell.cxx b/sw/source/core/access/acccell.cxx index dbd1b51..2479c5c 100644 --- a/sw/source/core/access/acccell.cxx +++ b/sw/source/core/access/acccell.cxx @@ -121,7 +121,7 @@

Re: [Libreoffice] [PATCH] some changes for better performance, writer.

2011-01-09 Thread David Tardon
On Mon, Jan 10, 2011 at 06:32:40AM +0100, David Tardon wrote: On Tue, Jan 10, 2006 at 08:09:17PM -0300, Kayo Hamid wrote: diff --git a/sw/source/core/access/acccell.cxx b/sw/source/core/access/acccell.cxx index dbd1b51..2479c5c 100644 --- a/sw/source/core/access/acccell.cxx +++ b/sw

Re: [Libreoffice] segfault in libqa_unit.so test

2011-01-09 Thread David Tardon
On Fri, Jan 07, 2011 at 09:52:31AM +, Caolán McNamara wrote: On Fri, 2011-01-07 at 03:21 +0100, Thomas Klausner wrote: Is that the end of the build? Yup, good news. (Where did the nice graphics go? ;) ) Thank you! How do we continue with this? Well, make dev-install and see

Re: [Libreoffice] [PUSHED, partial] Re: [PATCH] new cppcheck cleaning in cppu and cppuhelper + error in compilation

2011-01-12 Thread David Tardon
On Wed, Jan 12, 2011 at 01:12:19PM +, Caolán McNamara wrote: On Tue, 2011-01-11 at 23:17 +0100, Julien Nabet wrote: It's better with the attachments :-) Hum, it all looks good except for the operator=, I mean, it compiles but I don't think it *should* compile :-) it is changing the

Re: [Libreoffice] Debug build of sw vs system-libxml

2011-01-12 Thread David Tardon
On Thu, Jan 13, 2011 at 01:15:25AM +0100, Miklos Vajna wrote: Hi, I needed the attached patch to get a debug build of the sw module. Does it look sane and I can push it or do you have a better idea? The error message I get is included in the commit message. I put it to sw.mk after

Re: [Libreoffice] css::table::BorderLine vs BorderLine2

2011-01-15 Thread David Tardon
On Fri, Jan 14, 2011 at 02:45:06PM +0100, Cédric Bosdonnat wrote: Hello David, all, I just saw this commit: http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=0d209ac289dd5c79da6950b4c01b0cec9b7fbe6d I would like to have no BorderLine object created, but only BorderLine2: this

Re: [Libreoffice] This will Blow you Away . Must Read !

2011-01-16 Thread David Tardon
On Fri, Jan 14, 2011 at 04:00:02PM -0600, Conchita Aldridge wrote: Hi My name is Conchita I am sending you this E-mail to inform you of this One–of-a-kind System that is widely the fastest growing talk on the Internet. No Gimmicks, No Get-rich-quick Schemes, Just a

Re: [Libreoffice] [REVIEW] Sun Microsystems to TDF - fdo#31191

2011-01-17 Thread David Tardon
On Mon, Jan 17, 2011 at 12:02:46AM +0100, Rene Engelhard wrote: Hi, On Sun, Jan 16, 2011 at 09:17:39PM +0100, Andras Timar wrote: A localizer found a reference to Sun Microsystems in a .desktop file on Linux. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=33191 Commit (master):

Re: [Libreoffice] [PATCH] [PUSHED] Cppcheck cleaning on oox

2011-01-17 Thread David Tardon
On Sun, Jan 16, 2011 at 10:00:47PM +0100, Julien Nabet wrote: Hello, Here is a patch for some cppcheck cleaning on oox Pushed, thanks! In the file : oox/source/drawingml/chart/objectformatter.cxx in the line 930, there is this function void EffectFormatter::convertFormatting(

Re: [Libreoffice] NEW [PATCH] i#116187: report left/right page margin setting ignored on Unix 64 bit

2011-01-21 Thread David Tardon
On Fri, Jan 21, 2011 at 08:25:40AM +0100, Lionel Elie Mamane wrote: On Sat, Jan 15, 2011 at 08:00:05PM +, Caolán McNamara wrote: On Sat, 2011-01-15 at 05:59 +0100, Lionel Elie Mamane wrote: Does not fit release blocker criteria, but would still be *very* nice to have for the release, as

Re: [Libreoffice] 2 questions

2011-01-21 Thread David Tardon
On Fri, Jan 21, 2011 at 08:18:45AM +0100, Julien Nabet wrote: I try to debug the problem of the Alt key for Linux (when Alt key is released, it opens the file menu) I think (I'm not sure) the problem is in vcl in the unx part (since it impacts only Linux not Windows and I don't know for Macs).

Re: [Libreoffice] Break Failure with Application::ShowHelpStatusText()

2011-01-23 Thread David Tardon
On Fri, Jan 21, 2011 at 08:28:11AM -0800, Joseph Powers wrote: It looks like this wasn't removed from some of the test code in bootstrap/automation/util. I need to go to work and wont be back home until late Saturday so, so I don't have time to fix. Just wanted to give someone a heads up. I

Re: [Libreoffice] [PATCH] [PUSHED] ure: Some fixes to documentation (part 1)

2011-01-24 Thread David Tardon
On Sun, Jan 23, 2011 at 12:40:11PM +0200, Aurimas Fišeras wrote: Affected folders: offapi/com/sun/star/accessibility - offapi/com/sun/star/embed Fixes many spelling errors (checked with en_US spell checker). Unifies spelling of some common words. Replaces single quotes ('') with double

Re: [Libreoffice] [PATCH] [PUSHED] Translations of comments in writer/sw/inc

2011-01-24 Thread David Tardon
On Mon, Jan 24, 2011 at 06:51:55PM +0100, Christoph Herzog wrote: From ac1f5f1b8160c32dffb7d05b93d8b4b4f72ffe47 Mon Sep 17 00:00:00 2001 From: Christoph Herzog rho...@googlemail.com Date: Mon, 24 Jan 2011 18:48:46 +0100 Subject: [PATCH] Translations of comments in writer/sw/inc Excellent!

Re: [Libreoffice] [PATCH] [PUSHED] Removed unused codes and fix some typos

2011-01-24 Thread David Tardon
On Tue, Jan 25, 2011 at 05:05:43AM +0900, Takeshi Abe wrote: Hi, They were in impress. Cheers, -- Takeshi Abe Pushed, thanks! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] [PATCH] [PUSHED] Translations of comments is sw/inc.

2011-01-24 Thread David Tardon
On Mon, Jan 24, 2011 at 10:26:47PM +0100, Christoph Herzog wrote: From 5d52db1773557702eace21fab78fce4c6fe39f3c Mon Sep 17 00:00:00 2001 From: Christoph Herzog rho...@googlemail.com Date: Mon, 24 Jan 2011 22:18:42 +0100 Subject: [PATCH] Translations of comments is sw/inc. patch (as always)

Re: [Libreoffice] Build issue with cppu

2011-01-25 Thread David Tardon
On Tue, Jan 25, 2011 at 11:17:26AM +0530, surensp...@gmail.com wrote: Hi Dave, On Tue, Jan 25, 2011 at 10:42 AM, David Dumaresq dfdumar...@gmail.com wrote: I suggest you take a look at the advice under The Build Failed... What can I do? here,

Re: [Libreoffice] [Libreoffice-commits] .: vcl/source

2011-01-25 Thread David Tardon
On Tue, Jan 25, 2011 at 10:10:05AM -0500, Kevin Hunter wrote: At 9:42am -0500 Tue, 25 Jan 2011, David Tardon wrote: vcl/source/fontsubset/cff.cxx |4 1 file changed, 4 deletions(-) New commits: commit a1f7b2515a6bd09a5569735a1269a9a4029d2d5c Author: David Tardondtar

Re: [Libreoffice] [PATCH] ww8: silence debug output with dbglevel=1

2011-01-27 Thread David Tardon
On Thu, Jan 27, 2011 at 01:04:00PM +0100, Miklos Vajna wrote: Hi David, You recently had this dbglevel change. Here is a patch that brings the ww8 codebase in sync with this: - #if OSL_DEBUG_LEVEL 0 - #if OSL_DEBUG_LEVEL 1 - OSL_TRACE() is already guarded with #if OSL_DEBUG_LEVEL 1, so

Re: [Libreoffice] LibreOffice and (La)Tex

2011-01-30 Thread David Tardon
On Fri, Jan 28, 2011 at 02:52:24AM +0300, Alexander wrote: When user insert formula, LO can be use LaTeX and make vector graphics (SVG ? Or may be EPS), keep LaTeX source, put vector graphics in ODx and display it. This does system-independent. In ODx can keep preamble and user can edit

Re: [Libreoffice] [PUSHED] cleanup on writer

2011-01-30 Thread David Tardon
-// OD 09.01.2003 #i6467# - adjust view shell option to the same as for print +// adjust view shell option to the same as for print We generally want to leave the #iX#-style comments around, as they point to the publicly accessible OpenOffice.org issue tracker. OTOH, the #X#

Re: [Libreoffice] How to use gprof on LibO?

2011-01-31 Thread David Tardon
On Sat, Jan 29, 2011 at 03:50:37PM +0100, Soeren Moeller wrote: Hi In our effort of replacing deprecated data types from tools/ by std:: types we would like to use gprof for profiling (to choose the right data types). But unfortunately, we don't know to set the -pg flag, export

Re: [Libreoffice] [Fwd: [PATCH] new De-Java-ised flat XML export]

2011-02-02 Thread David Tardon
Hi, Peter, +/* + * FLABridge provides some obscure attribute mangling to wordml2000 import/export filters. + * In the long run, you might want to replace this with an XSLT extension function. + */ +class FLABridge : public WeakImplHelper1 DocumentHandlerAdapter +

Re: [Libreoffice] [PATCH] [PUSHED] DBG_ASSERT - OSL_ENSURE (dbaccess)

2011-02-03 Thread David Tardon
On Thu, Feb 03, 2011 at 12:42:41AM +0100, Kenneth Venken wrote: Hi, this patch replaces all occurrences of DBG_ASSERT with OSL_ENSURE in dbacces. Thanks. In addition, I changed several #ifdef DBG_UTIL lines enclosing declarations of variables/functions accessed in the debug macros to #if

Re: [Libreoffice] [PATCH] [PUSHED] Remove comments (writer)

2011-02-03 Thread David Tardon
On Wed, Feb 02, 2011 at 08:46:07PM +0900, Suguru Hirahara wrote: Hi, please review this one. changes are available under LGPLv3+ / MPL. I reverted the hunks removing @author OD from class/function descriptions. I think we do not want to remove these. D.

Re: [Libreoffice] [PATCH] [PUSHED] DBG_ASSERT - OSL_ENSURE (dbaccess)

2011-02-03 Thread David Tardon
On Thu, Feb 03, 2011 at 01:41:19AM -0700, Tor Lillqvist wrote: Thanks. In addition, I changed several #ifdef DBG_UTIL lines enclosing declarations of variables/functions accessed in the debug macros to #if OSL_DEBUG_LEVEL 0 Is that something we can/should do in general everywhere?

Re: [Libreoffice] template missing

2011-02-06 Thread David Tardon
On Sun, Feb 06, 2011 at 06:57:00PM -0500, Arno Teigseth wrote: Hi This might be a corner case, but I have this problem: To not have to go through the import template process every time I change a template, I symlinked it. So, Is there any reason why you cannot just import the template and

Re: [Libreoffice] template missing

2011-02-07 Thread David Tardon
On Mon, Feb 07, 2011 at 02:10:13AM -0500, Arno Teigseth wrote: On Mon, 2011-02-07 at 07:44 +0100, David Tardon wrote: ... exists yet, it just points to a nonexistent file. LibO sees the (symlink) file, so it doesn't allow to import a template with the same name, but it cannot open

Re: [Libreoffice] [PATCH] [PUSHED] Remove bogus comments

2011-02-07 Thread David Tardon
On Sat, Feb 05, 2011 at 05:20:29PM -0500, Antoine Proulx wrote: Hi, Here's a patch who removes bogus comments. It's released under the LGPLv3+ / MPL. Antoine Hi, Antoine, bug references like #XX# point to private Sun bugtracker, therefore they are of no value to us (as opposite to

Re: [Libreoffice] EasyHacks: Make existing tests work (ure/sal)

2011-02-07 Thread David Tardon
On Sat, Feb 05, 2011 at 11:45:47PM +0100, Wilhelm Pflüger wrote: Attached please find some changes to make tests in ure/sal work. One test fails and breaks the build though - if this is unwanted you may revert the change to ure/sal/prj/build.lst. (This is not exactly what is intended by

Re: [Libreoffice] [PUSHED] EasyHacks: Make existing tests work (ure/sal)

2011-02-07 Thread David Tardon
Forgot to mark as PUSHED. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] EasyHacks: Make existing tests work

2011-02-07 Thread David Tardon
On Sat, Feb 05, 2011 at 11:32:18PM +0100, Wilhelm Pflüger wrote: Find attached changes to lib-gui/comphelper to get some tests working again. These patches are LGPLv3+/MPL. This is my first contribution in this project - so don't hesitate with critics if its not the common procedure. You

Re: [Libreoffice] [libreoffice] [PUSHED] EasyHacks: Reanimating more tests in ure/sal

2011-02-08 Thread David Tardon
On Sun, Feb 06, 2011 at 11:10:07PM +0100, Wilhelm Pflüger wrote: More reanimated tests. The osl/file part is not satisfying. I had to switch off some tests in osl_old_test_file.cxx. Maybe it is not worth to keep it. These patches are LGPLv3+/MPL. Nice work! I have a couple of comments,

Re: [Libreoffice] issue with Borderline structure

2011-02-08 Thread David Tardon
On Mon, Feb 07, 2011 at 09:22:50PM +0100, Dietmar wrote: I am having an issue with my extension Borderliner written in Java. It works fine with Oracle OOo, but does not with Go-OO and LO. Yes, we know already: https://bugs.freedesktop.org/show_bug.cgi?id=33397 . D.

Re: [Libreoffice] [PATCH] [PUSHED] Corrected typo in names of four swriter classes

2011-02-08 Thread David Tardon
On Mon, Feb 07, 2011 at 09:30:47PM +0100, Christoph Herzog wrote: From c70749b0ae94c606f87398b36f7a8a4aa4ae9fb1 Mon Sep 17 00:00:00 2001 From: Christoph Herzog rho...@googlemail.com Date: Mon, 7 Feb 2011 21:20:16 +0100 Subject: [PATCH] Corrected typo in names of four swriter classes Checked

Re: [Libreoffice] [PUSHED] patch lib-core/eventattacher

2011-02-08 Thread David Tardon
On Mon, Feb 07, 2011 at 10:20:55PM +0100, Rob Snelders wrote: Hi, Here is a small patch which translates the comments in the eventattacher from German to English Thanks, pushed! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] compilation and bundled extensions

2011-02-14 Thread David Tardon
On Sun, Feb 13, 2011 at 09:26:47PM +, Caolán McNamara wrote: caolanm-dtardon: Which reminds me, when i did this I didn't seem to get the python, beanshell, rhino scripting extensions (not that I really want the beanshell, rhino ones, but I did want the python one) I probably forgot to add

Re: [Libreoffice] [PATCH] DECLARE_LIST(TOXControlList, Control*) to std::vectorControl* in sw.

2011-02-14 Thread David Tardon
On Sun, Feb 13, 2011 at 11:40:17PM +, Rafael Dominguez wrote: Well the patch is related to sw, tab entries in Insert-Indexes and Tables - Indexes and Tables. Looks good on a glance, but lifetime of the ptrs seem to be bound to that of the container, so I suggest using boost::ptr_vector

Re: [Libreoffice] [PATCH] [PUSHED] fixed spelling menues - menus

2011-02-15 Thread David Tardon
On Sun, Feb 13, 2011 at 08:42:42PM +0100, Christina Roßmanith wrote: diff --git a/svtools/source/config/menuoptions.cxx b/svtools/source/config/menuoptions.cxx index a12f1e0..4e814a7 100644 --- a/svtools/source/config/menuoptions.cxx +++ b/svtools/source/config/menuoptions.cxx @@ -62,13

Re: [Libreoffice] [PATCH] [PUSHED] fixed spelling menues - menus

2011-02-16 Thread David Tardon
On Wed, Feb 16, 2011 at 07:56:06AM +0100, David Tardon wrote: On Sun, Feb 13, 2011 at 08:42:42PM +0100, Christina Roßmanith wrote: diff --git a/svtools/source/config/menuoptions.cxx b/svtools/source/config/menuoptions.cxx index a12f1e0..4e814a7 100644 --- a/svtools/source/config

Re: [Libreoffice] [PATCH] [PUSHED] unused variable in writer/uno

2011-02-17 Thread David Tardon
On Thu, Feb 17, 2011 at 03:27:08AM -0500, Kevin Hunter wrote: Hullo List, A simpleton patch removing unused variables in writer/uno. Good catch, thanks! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] [PATCH] [PUSHED] fixed spelling menues - menus

2011-02-17 Thread David Tardon
On Wed, Feb 16, 2011 at 12:48:14PM +0100, David Tardon wrote: On Wed, Feb 16, 2011 at 07:56:06AM +0100, David Tardon wrote: On Sun, Feb 13, 2011 at 08:42:42PM +0100, Christina Roßmanith wrote: diff --git a/svtools/source/config/menuoptions.cxx b/svtools/source/config/menuoptions.cxx

Re: [Libreoffice] [PATCH] [PUSHED] fixed spelling menues - menus

2011-02-17 Thread David Tardon
On Wed, Feb 16, 2011 at 10:29:34PM +0100, Christina Roßmanith wrote: Hi David, Am 16.02.2011 07:56, schrieb David Tardon: On Sun, Feb 13, 2011 at 08:42:42PM +0100, Christina Roßmanith wrote: diff --git a/svtools/source/config/menuoptions.cxx b/svtools/source/config/menuoptions.cxx index

Re: [Libreoffice] [PATCH] [PUSHED] redundant pointer check

2011-02-17 Thread David Tardon
On Thu, Feb 17, 2011 at 04:14:35AM -0500, Kevin Hunter wrote: Hullo List, Simpleton patch to remove a redundant if-block. Looks reasonable, pushed. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] [REVIEW] fdo#32552 (alt key opens File-menu)

2011-02-17 Thread David Tardon
On Thu, Feb 17, 2011 at 11:29:53AM +, Michael Meeks wrote: Hi Julien, On Tue, 2011-02-15 at 22:22 +0100, Julien Nabet wrote: Here is small patch to close the tracker 32552 (alt key opens File-menu). I wonder how this interacts / complements: commit

Re: [Libreoffice] [REVIEW] [PUSHED] fdo#32552 (alt key opens File-menu)

2011-02-17 Thread David Tardon
On Tue, Feb 15, 2011 at 10:22:07PM +0100, Julien Nabet wrote: Hello, Here is small patch to close the tracker 32552 (alt key opens File-menu). I removed the block quoted in the comments, it compiles but I didn't test it. I use Gnome and so Gtk on my Debian. Hi, in that case you most

Re: [Libreoffice] compilation and bundled extensions

2011-02-17 Thread David Tardon
On Mon, Feb 14, 2011 at 10:20:27AM +0100, David Tardon wrote: On Sun, Feb 13, 2011 at 09:26:47PM +, Caolán McNamara wrote: caolanm-dtardon: Which reminds me, when i did this I didn't seem to get the python, beanshell, rhino scripting extensions (not that I really want the beanshell

Re: [Libreoffice] [PUSHED] Re: [PATCH] DECLARE_LIST(TOXControlList, Control*) to std::vectorControl* in sw.

2011-02-18 Thread David Tardon
On Thu, Feb 17, 2011 at 11:36:27PM +0100, Jan Holesovsky wrote: The main thing that I changed was that in some cases you used vector...::iterator it = another_iterator + 1; This is not correct, operator+() is not defined on std::vector, so the result might be not what you'd expect; similarly

Re: [Libreoffice] Patch handling guideline

2011-02-22 Thread David Tardon
On Tue, Feb 22, 2011 at 07:59:52PM +0100, Pierre-André Jacquod wrote: for applying, I would propose: git am which takes over user / date / commit message from the send message. Should we generally use the --signoff option in order to let a trace of who has pushed this? git already tracks

Re: [Libreoffice] Build failure in DbAdminImpl.cxx

2011-02-26 Thread David Tardon
On Fri, Feb 25, 2011 at 12:03:32PM +0100, Francois Tigeot wrote: Hi, I've got some compilations errors due to recent changes in dbaccess/source/ui/dlg/DbAdminImpl.cxx : /home/ftigeot/Projects/LibreOffice/bootstrap/clone/base/dbaccess/source/ui/dlg/DbAdminImpl.cxx:1000: error:

Re: [Libreoffice] Compilation failed in libs-gui/toolkit

2011-02-28 Thread David Tardon
On Sun, Feb 27, 2011 at 01:31:36PM +0100, Julien Nabet wrote: Hello, I've got a compilation error in libs-gui/toolkit. Entering /home/maryline/compile-libreoffice/libo/toolkit/uiconfig/layout dmake: Warning: -- Found file corresponding to virtual target [message-box.xml]. dmake:

Re: [Libreoffice] Revert some changing from last commit

2011-02-28 Thread David Tardon
On Sun, Feb 27, 2011 at 09:18:14PM +0100, Xisco Faulí wrote: In a previous commit, OSL_ASSERT were changed into OSL_FAIL but 2 of them created the build fail. No, these changes are correct. You are probably missing the definition of OSL_FAIL (which I added over the weekend), in which case you

Re: [Libreoffice] Errors in LibreOffice

2011-03-06 Thread David Tardon
On Sun, Mar 06, 2011 at 09:39:15AM +0100, Stefan Lindel wrote: Hi, where can i submit errors in LibreOffice? https://bugs.freedesktop.org/enter_bug.cgi?product=LibreOffice D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] Compilation failed in sd part.

2011-03-06 Thread David Tardon
On Sun, Mar 06, 2011 at 10:18:04PM +0100, Julien Nabet wrote: Hello, After this command today : make clean ./autogen.sh make I've got an error in sd part. Hi, try to remove sd/unxlngi6.pro . It should build again after that. D. ___ LibreOffice

Re: [Libreoffice] [PATCH] [PUSHED] Make the sal/qa/sal unit test build and use it

2011-03-15 Thread David Tardon
On Thu, Mar 10, 2011 at 11:48:14AM +0100, Theo van Klaveren wrote: Please let me know if the patch is okay like this, because I'm new to this whole git thing. It already ate all my patches earlier today. Pushed, thanks! D. ___ LibreOffice mailing

Re: [Libreoffice] EasyHacks: Reanimated tests in ure/codemaker

2011-03-15 Thread David Tardon
On Fri, Mar 11, 2011 at 01:05:53AM +0100, Wilhelm Pflüger wrote: From 3bffa7b2a431686eeedd7859eaba1ce22671d474 Mon Sep 17 00:00:00 2001 Message-Id: 3bffa7b2a431686eeedd7859eaba1ce22671d474.1299801754.git.wilhelm.pflue...@web.de From: Wilhelm Pflueger wilhelm.pflue...@web.de Date: Fri, 11

Re: [Libreoffice] [PUSHED] EasyHacks: Reanimated tests in ure/codemaker

2011-03-15 Thread David Tardon
On Tue, Mar 15, 2011 at 08:48:03AM +0100, David Tardon wrote: On Fri, Mar 11, 2011 at 01:05:53AM +0100, Wilhelm Pflüger wrote: From 3bffa7b2a431686eeedd7859eaba1ce22671d474 Mon Sep 17 00:00:00 2001 Message-Id: 3bffa7b2a431686eeedd7859eaba1ce22671d474.1299801754.git.wilhelm.pflue

Re: [Libreoffice] [PUSHED] EasyHacks: Reanimated tests in ure/cppuhelper/qa

2011-03-15 Thread David Tardon
On Sat, Mar 12, 2011 at 06:41:02PM +0100, Wilhelm Pflüger wrote: I attach some other reanimated tests. I had to deactivate the test 'test_weak.cxx' in prj/build.lst. This test failed with 'error 139' - this is typically a segfault during test execution, oops. I had no time to investigate

Re: [Libreoffice] need some acks for 3-3 and fdo#35405 es thesaurus crash

2011-03-18 Thread David Tardon
On Fri, Mar 18, 2011 at 09:25:39AM +, Caolán McNamara wrote: See https://bugs.freedesktop.org/show_bug.cgi?id=35405 and fix of http://cgit.freedesktop.org/libreoffice/libs-extern/commit/?h=libreoffice-3-3id=896c49083aec918b0710f9c62f2f775a53f28057 I'd like to backport this rather mythes

Re: [Libreoffice] [PATCH] [PUSHED] Fix and enable more unit tests in sal/qa/rtl

2011-03-18 Thread David Tardon
On Thu, Mar 17, 2011 at 02:50:54PM +0100, Theo van Klaveren wrote: Hello again, More unit test hacking. Only the ones that work are enabled. Pushed, thanks! Some questions that are coming up: - Some unit tests contain .xsce files that seem to be used to tell told the old unit testing

Re: [Libreoffice] Move DBG_ERROR[1-9] to OSL_TRACE

2011-03-21 Thread David Tardon
On Fri, Mar 18, 2011 at 08:53:36PM +0100, Thomas Arnhold wrote: Hi, some days ago I converted all DBG_ERROR[1-9], which had a printf like format string, to OSL_TRACE. David Tardon pointed me out that this slightly changed the behavior, because the according OSL variant of DBG_ERROR

Re: [Libreoffice] [PATCH] [PUSHED] remove String with OUString

2011-03-22 Thread David Tardon
On Tue, Mar 15, 2011 at 01:10:58PM +0100, Xisco Faulí wrote: Hello, It's the first time I do it so I searched for previous commits in order to get a referent. i couldn't find any example for String.AssignAscii so I replace it with OUStringBuffer.appendAscii. Yeah, that is good. I only

Re: [Libreoffice] GreaseMonkey script for OOo bugs fixed in LO has been updated

2011-03-22 Thread David Tardon
On Mon, Mar 21, 2011 at 05:23:17PM +0100, Cedric Bosdonnat wrote: Hi all, The title says it all... The old version wasn't useful anymore since OpenOffice switched to Kenai and bugzilla. The GreaseMonkey script has been updated for the new bugzilla. It can be fetched here, like before:

Re: [Libreoffice] [PATCH] [PUSHED] Delete last SVX_LIGHT usage

2011-03-22 Thread David Tardon
On Mon, Mar 21, 2011 at 10:18:41PM +0100, Michael Lefevre wrote: Xavier SVX_LIGHT deletion forgot just on occurence. This patch delete the last one. Pushed, thanks! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] [PATCH] [PUSHED] Remove DECLARE_LIST( FmCtrlModelList, XInterface* ).

2011-03-22 Thread David Tardon
Pushed, thanks! One thing, though: we prefer to use real name for author. Could you change this in your ~/.gitconfig, please? git config --global user.name Real Name will do the trick. D. ___ LibreOffice mailing list

Re: git branch audit ...

2012-07-19 Thread David Tardon
On Thu, Jul 19, 2012 at 10:08:30AM +0200, Bjoern Michaelsen wrote: On Wed, Jul 18, 2012 at 05:51:44PM +0100, Michael Meeks wrote: origin/feature/tail_build seems to be a integrated/obsolete branch by dtardon Yes, it has been integrated. Sorry, I have forgotten about than one entirely. D.

[Libreoffice-commits] .: Branch 'feature/gbuild_a11y' - 0 commits -

2012-07-19 Thread David Tardon
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'feature/gbuild_components' - 0 commits -

2012-07-19 Thread David Tardon
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'feature/gbuild_conversions' - 0 commits -

2012-07-19 Thread David Tardon
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'feature/gbuild_merge' - 0 commits -

2012-07-19 Thread David Tardon
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'feature/gbuild_scp2' - 0 commits -

2012-07-19 Thread David Tardon
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'feature/gbuild_shell' - 0 commits -

2012-07-19 Thread David Tardon
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'feature/gbuild_sdext' - 0 commits -

2012-07-19 Thread David Tardon
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'feature/gbuild_testtools' - 0 commits -

2012-07-19 Thread David Tardon
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'feature/tail_build' - 0 commits -

2012-07-19 Thread David Tardon
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: sw/source

2012-07-19 Thread David Tardon
sw/source/core/fields/authfld.cxx |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) New commits: commit 859018061956b1937c7be3809a9858cbd610fa9c Author: David Tardon dtar...@redhat.com Date: Thu Jul 19 14:00:55 2012 +0200 fdo#52241 remove just one entry Change-Id

[REVIEW: 3-6-0] fdo#55241 updating of indexes is broken

2012-07-19 Thread David Tardon
Hi all, commit 859018061956b1937c7be3809a9858cbd610fa9c fixes yet another STL conversion bug (no offense meant, Noel--your work is much appreciated). As a side note: I have to admire the ingenuity of authors of the TOX implementation in Writer, whose glorious idea to define virtual operator==

Re: [REVIEW: 3-6 3-6-0] fdo#55241 updating of indexes is broken

2012-07-19 Thread David Tardon
On Thu, Jul 19, 2012 at 02:36:48PM +0200, Lubos Lunak wrote: On Thursday 19 of July 2012, David Tardon wrote: Hi all, commit 859018061956b1937c7be3809a9858cbd610fa9c fixes yet another STL conversion bug +1 But I have no idea to which branch you have already committed this (git

Re: minutes of ESC call ...

2012-07-19 Thread David Tardon
Hi, On Thu, Jul 19, 2012 at 04:50:28PM +0100, Michael Meeks wrote: * cppunit / build issues (Stephan/Moggi/Michael) + indifferent about --disable-xmlsec + only intended for iOS / Android currently, should not be used on Linux. + configure

Re: [PATCH] cleaning before = assignment lotuswordpro/source/filter/xfilter/xfparastyle.cxx

2012-07-19 Thread David Tardon
Hi, On Thu, Jul 19, 2012 at 02:03:39PM -0700, julien2412 wrote: Thank you David for the hint! I re read the An in-depth explanation part of http://stackoverflow.com/questions/3279543/what-is-the-copy-and-swap-idiom/3279550#3279550, it's great ! I understood when and above all how the memory

[Libreoffice-commits] .: mdds/0001-help-compiler-select-the-right-overload-of-vector-in.patch mdds/makefile.mk

2012-07-20 Thread David Tardon
-of-vector-in.patch new file mode 100644 index 000..fd43c1a --- /dev/null +++ b/mdds/0001-help-compiler-select-the-right-overload-of-vector-in.patch @@ -0,0 +1,52 @@ +From 900cbea3ec067833b4284584f6dfa5502dc36de8 Mon Sep 17 00:00:00 2001 +From: David Tardon dtar...@redhat.com +Date: Fri, 20 Jul 2012

Re: Changes needed for LibreOffice 4

2012-07-20 Thread David Tardon
On Fri, Jul 20, 2012 at 06:33:20PM +0200, john malc wrote: Hi, I have some ideas : 3. kick Draw and Math-parts out of LO. Either make it as plugin or just kill it. 1) nobody uses it (Math Latex; Draw photoshop, corel, gimp etc.); Can we see the numbers, please? 2) installer can

[Libreoffice-commits] .: idlc/prj

2012-07-22 Thread David Tardon
idlc/prj/build.lst |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 00f4aabc86f35ea2f12d21cb6e69b0a794ef8d4d Author: David Tardon dtar...@redhat.com Date: Sun Jul 22 08:06:33 2012 +0200 fix typo Change-Id: I663127446e7d9a38693ce46a7a42b5bec8cb8d51

Re: gbuild deps: removed header

2012-07-23 Thread David Tardon
Hi, On Sun, Jul 22, 2012 at 09:01:45PM +0200, Matúš Kukan wrote: Hi all, Should gbuild dependencies survive removed header ? Yes, ideally :-) Something like: touch solver/*/inc/foo.h +#include foo.h e.g. in salhelper/source/condition.cxx make gb_FULLDEPS=T salhelper Now

[Libreoffice-commits] .: 2 commits - filter/inc filter/source svx/inc

2012-07-23 Thread David Tardon
commits: commit 4d05a50182587ee2c63b6911206cbd6c3287c180 Author: David Tardon dtar...@redhat.com Date: Mon Jul 23 10:33:36 2012 +0200 mark more one-param ctors as explicit Change-Id: Idf923e4a1e81a2e2e9c7107e4b6725bd9eb33e38 diff --git a/filter/inc/filter/msfilter/msdffimp.hxx b/filter

<    1   2   3   4   5   6   7   8   9   10   >