Re: [Libreoffice] .: sc/qa sc/source

2012-01-11 Thread Kohei Yoshida
Hi Michael, On Wed, 2012-01-11 at 13:51 +0100, Michael Stahl wrote: hi Kohei, i get an assertion in the smoketest because of this commit: #0 sal_detail_logFormat(level = SAL_DETAIL_LOG_LEVEL_WARN, area = 0x7f75465b5032 legacy.tools, where = 0x7f75465b57e0

Re: [Libreoffice] [REVIEW][3-4] fdo#44078 boxes shown for glyph fallback with DejaVu Sans ExtraLight (he/ar)

2012-01-12 Thread Kohei Yoshida
On Thu, 2012-01-12 at 11:08 +, Caolán McNamara wrote: We probably need a wiki dashboard Perhaps we could add such info to this wiki page: http://wiki.documentfoundation.org/Development/Patch_Handling_Guideline Best, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc

Re: [Libreoffice] [PATCH] ScColumn - convert array to vector

2012-01-13 Thread Kohei Yoshida
performance quite a bit. Once I check that bit, and if nothing else is wrong, I'll commit this to master. Thanks a lot for your patch. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] [PATCH] ScColumn - convert array to vector

2012-01-13 Thread Kohei Yoshida
one more time, and I'll push to master. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] ScColumn - convert array to vector

2012-01-13 Thread Kohei Yoshida
On Fri, 2012-01-13 at 15:27 -0500, Kohei Yoshida wrote: Let me do a thorough review of your patch one more time, and I'll push to master. Unfortunately one of the filters-test fails on master, after applying the patch. The crash occurs in ScColumn::CloneCell, at line 824 which is switch

Re: [Libreoffice] [PATCH] ScColumn - convert array to vector

2012-01-13 Thread Kohei Yoshida
On Fri, 2012-01-13 at 17:00 -0500, Kohei Yoshida wrote: On Fri, 2012-01-13 at 15:27 -0500, Kohei Yoshida wrote: Let me do a thorough review of your patch one more time, and I'll push to master. Unfortunately one of the filters-test fails on master, after applying the patch. The crash

Re: [Libreoffice] There is no round() in msvc library (fdo#44173)

2012-01-15 Thread Kohei Yoshida
Hi there, On Sun, Jan 15, 2012 at 1:04 PM, Tim Hardeck thard...@suse.de wrote: But if ::boost::math::iround will be used in other places or if there is already another usable round function - what does Calc use? Calc uses rtl::math::round from sal module (in sal/inc/rtl/math.hxx). My

Re: [Libreoffice] CPU eating after opening a password protected macro library

2012-01-18 Thread Kohei Yoshida
, he's already done some profiling to figure it out, but got some roadblocks. Regards, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [Libreoffice] [PATCH] [PUSHED] Dead code removal

2012-01-18 Thread Kohei Yoshida
files in tools. Looks like someone else has got to it first. Thanks, Kohei [1] http://wiki.documentfoundation.org/Development/Patch_Handling_Guideline -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice

Re: [Libreoffice] [PATCH] [PUSHED] #fdo39428 Remove/audit SvStream operator/(long)

2012-01-18 Thread Kohei Yoshida
list. Thanks for your patches. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEWED 3-5] [PUSHED 3-5] fdo#44896 german text cut off

2012-01-18 Thread Kohei Yoshida
On Wed, 2012-01-18 at 23:52 +0100, Andras Timar wrote: Hi, http://cgit.freedesktop.org/libreoffice/core/commit/?id=225647779959d24cfdaea62968f518cc52533a90 Pushed to -3-5 with my sign-off. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc

Re: [Libreoffice] minutes of ESC call ...

2012-01-19 Thread Kohei Yoshida
name loud enough. :-P Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Problem with clipboard paste in 3.5

2012-01-19 Thread Kohei Yoshida
if that makes any difference. Failing that, most of the clipboard handling code for unix platform is located under vcl/generic/dtrans. HTH, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

Re: [Libreoffice] [PATCH V2] replace open-coded array with std::vector in ScColumn

2012-01-20 Thread Kohei Yoshida
of curiosity, what was the problem that was causing the unit test to fail with your earlier patch? Best, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org

Re: [Libreoffice] [PATCH V2] replace open-coded array with std::vector in ScColumn

2012-01-20 Thread Kohei Yoshida
, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEWED] [PUSHED 3-4] [PUSHED 3-5] fdo#45032 Calc export to HTML

2012-01-23 Thread Kohei Yoshida
with graphics failed Pushed to both -3-4 and -3-5 branches with my sign-off. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEWED][PUSHED 3-5][PUSHED3-4] resolved rhbz#783556 crash in Calc interpreter

2012-01-23 Thread Kohei Yoshida
for external reference matrix. Looks good. Pushed to both -3-4 and -3-5 branches with my sign-off. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [Libreoffice] sc_unoapi failure

2012-01-23 Thread Kohei Yoshida
On Mon, 2012-01-23 at 11:51 -0500, Kohei Yoshida wrote: maItems.erase(maItems.end() - 1); Thanking a bit further, maybe changing that to maItems.erase(maItems.begin() + nIndex); should fix the crash? -- Kohei Yoshida, LibreOffice hacker, Calc

[Libreoffice] [REVIEW][3-5] Fix for pivot table refresh problem

2012-01-23 Thread Kohei Yoshida
by Markus' new UNO API test, which was also affected by my earlier change. Review and sign-off appreciated. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org

[Libreoffice] [REVIEW][3-5] Fix pivot table's date and number grouping

2012-01-23 Thread Kohei Yoshida
Hi there, I would like http://cgit.freedesktop.org/libreoffice/core/commit/?id=2c659e692a17cc10d364a2304bead9403fc6bdde to be backported to the 3-5 branch. It fixes https://bugs.freedesktop.org/show_bug.cgi?id=45067 Review and sign-off appreciated. Kohei -- Kohei Yoshida, LibreOffice

Re: [Libreoffice] [REVIEW][3-5] Fix pivot table's date and number grouping

2012-01-24 Thread Kohei Yoshida
it properly we'd have to make more invasive changes, and definitely not for 3.5. -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW][3-5] Fix for pivot table refresh problem

2012-01-24 Thread Kohei Yoshida
it in the UI though? Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] sc_unoapi failure

2012-01-24 Thread Kohei Yoshida
element on cell deletion... I should've spotted this during review. This is a disadvantage of reviewing a large patch. :-/ Maybe that's what's causing the crash? Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list

Re: [Libreoffice] [REVIEW][3-5] Fix for pivot table refresh problem

2012-01-24 Thread Kohei Yoshida
On Tue, 2012-01-24 at 09:49 -0500, Kohei Yoshida wrote: It seems that your patch does not fix the problem in 3-5. I tested with sc/qa/extras/testdocuments/ScDataPilotTableObj.ods similar and changed B6 but refresh does not work except if you force to create the cache. Does it at least

Re: [Libreoffice] [PATCH] UX New layout Move/Copy sheet in calc

2011-01-03 Thread Kohei Yoshida
. Yeah we'll leave this a future project too. Thanks a lot for your patch. :-) Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [Libreoffice] [PATCH] [PUSHED] provide the long prefix '--' for options, e.g., --help

2011-01-03 Thread Kohei Yoshida
styles and updating the cmdline help to promote --foo style options. Thanks a lot! Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [Libreoffice] [PATCH] [PUSHED] Translated comments from German to English.

2011-01-03 Thread Kohei Yoshida
manually from your post. Thanks a lot! Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Removed dependencies on tools/solar.h

2011-01-03 Thread Kohei Yoshida
replaced that with sal_uInt32. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] cppcheck at writer, performance.

2011-01-03 Thread Kohei Yoshida
to be test++, understand? In those use cases it makes no difference whether it's a post- or pre-increment. It matters only when its return value is stored used. I pushed your patch to master. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] starmath / cppunit breakage in master

2011-01-03 Thread Kohei Yoshida
be no difference whether it's system or internal, since mdds is just a collection of header files with no libraries to build or link against. From the looks of the log file, it *may* have some issues with gcc 4.5.x's implementation of unordered_map, but I'm not sure 100%... Kohei -- Kohei Yoshida, LibreOffice

Re: [Libreoffice] [PATCH] Removed dependencies on tools/solar.h

2011-01-04 Thread Kohei Yoshida
Hi Norbert, On Tue, 2011-01-04 at 01:57 -0600, Norbert Thiebaud wrote: On Mon, Jan 3, 2011 at 10:36 PM, Kohei Yoshida kyosh...@novell.com wrote: On Mon, 2011-01-03 at 21:47 +0100, Soeren Moeller wrote: Hi I have removed dependencies on tools/solar.h in some files in sc (according

Re: [Libreoffice] [PATCH] Removed dependencies on tools/solar.h

2011-01-04 Thread Kohei Yoshida
* types that are exported to extensions. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Better font substitution in Japanese locale in 3.3 branch

2011-01-04 Thread Kohei Yoshida
I consider that a safe enough change for 3.3. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Sign-off request

2011-01-04 Thread Kohei Yoshida
Could someone please give me a quick sign-off of this https://bugs.freedesktop.org/show_bug.cgi?id=32823 for 3.3? Thanks. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice

Re: [Libreoffice] unopkg --suppress-license

2011-01-04 Thread Kohei Yoshida
file in undisclosed location has in it. So, I'm with you on that. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [Libreoffice] [PATCH] Removed dependencies on tools/solar.h in drawpage.hxx/.cxx

2011-01-05 Thread Kohei Yoshida
, not sal_Bool nor BOOL (though the default value is for some reason set to sal_False instead of false, which should really be fixed...), which provides another reason to use bool, not sal_Bool. Thanks! Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] [PATCH] [PUSHED] Translated comments from German to English

2011-01-05 Thread Kohei Yoshida
On Tue, 2011-01-04 at 22:26 +0100, Christina Roßmanith wrote: ...some more translations. Nice work! Pushed. -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

Re: [Libreoffice] [PATCH] Removed dependencies on tools/solar.h in drawpage.hxx/.cxx

2011-01-06 Thread Kohei Yoshida
the attachment symbols to look for incoming patches, but I can adopt.) Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [Libreoffice] sign off for cherry-pick fix for crash on exit after using search in calc

2011-01-06 Thread Kohei Yoshida
it to a local static ensures it gets dtored before that. I can sign off on this. I believe this code was originally my patch and Eike changed it a bit. I remember this one. Nothing weird about this change, so looks good to me. :-) Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh

[Libreoffice] Bug 32790 fixed - please review

2011-01-08 Thread Kohei Yoshida
Hi there, I've just fixed and attached a patch to https://bugs.freedesktop.org/show_bug.cgi?id=32790 intended for 3.3. I would appreciate it if someone who is experienced in the writer mail merge code to review and approve this. Thanks a lot! Kohei

Re: [Libreoffice] [PATCH] cui: make it possible to bind F13/F14/F15/F16 to a function

2011-01-08 Thread Kohei Yoshida
Hi Miklos, On Sat, Jan 8, 2011 at 9:51 AM, Miklos Vajna vmik...@frugalware.org wrote: OK to push to master? Yeah, looks indeed trivial. Let's push this baby. Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] [PATCH] Changed String to OUString in funcdesc.hxx

2011-01-10 Thread Kohei Yoshida
. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Changed String to OUString in funcdesc.hxx

2011-01-10 Thread Kohei Yoshida
( ScCompiler::GetNativeSymbol( static_castOpCode( aRes.GetId(; either. Also the line below that the patch is trying to remove is not there either. So, something weird is definitely going on. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] [PATCH] Changed String to OUString in funcdesc.hxx

2011-01-10 Thread Kohei Yoshida
On Mon, 2011-01-10 at 20:38 -0500, Kohei Yoshida wrote: Hmm... I tried apply your two patches against sc, but they don't apply cleanly in global.cxx. I took a closer look, and looks like the patches are missing some changes you've apparently made. Can you double-check your patches and see

Re: [Libreoffice] [PATCH] [PUSHED] Changed String to OUString in funcdesc.hxx

2011-01-10 Thread Kohei Yoshida
Forgot to use a [PUSHED] tag in the subject... :-P -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Build error in sc from libreoffice-3.3.0.3 tag

2011-01-13 Thread Kohei Yoshida
On Thu, 2011-01-13 at 16:46 +0100, Miklos Vajna wrote: Hi, The build ends with: Entering /var/tmp/fst/src/libreoffice-build-3.3.0.3/build/libreoffice-3.3.0.3/sc/source/filter/excel Compiling: sc/source/filter/excel/colrowst.cxx I guess you are using mdds 0.5.x on the 3.3 branch? The

[Libreoffice] Patch review

2011-01-13 Thread Kohei Yoshida
appreciated. The 0001 is a pure git revert commit, whereas the 0002 is an application of a patch I generated between the pre- and post-merge commit. Git has a special handling of reverting merge commits, so I decided to do the revert this way. Thanks. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc

Re: [Libreoffice] [PATCH] UX New layout Move/Copy sheet in calc

2011-01-13 Thread Kohei Yoshida
/?id=7d439aeba0682452b287c30995e2553e956b4dd1 Did I miss anything else!? Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [Libreoffice] patch review

2011-01-14 Thread Kohei Yoshida
On Fri, 2011-01-14 at 12:12 +, Caolán McNamara wrote: Need a review of attached to fix https://bugs.freedesktop.org/show_bug.cgi?id=32633 for libreoffice-3-3-0. Looks simple sane. I'd say go for it. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

[Libreoffice] [REVIEW REQUEST] fdo#33112

2011-01-14 Thread Kohei Yoshida
-- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW REQUEST] fdo#33112

2011-01-14 Thread Kohei Yoshida
/dbaccess/uiconfig/dbtdata/menubar/menubar.xml ./components/extensions/source/bibliography/uiconfig/sbibliography/menubar/menubar.xml Good point! I've attached two additional patches to cover the extensions and sw modules. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] [PATCH] Replaced deprecated types in funcdesc

2011-01-18 Thread Kohei Yoshida
/tool/callform.cxx and used it in funcdesc. Translated some comments and changed some indentations on the way. Please review and apply I've reviewed applied it, with a little bit of follow-up mods to clean things up a bit. Thanks a lot! Kohei -- Kohei Yoshida, LibreOffice hacker, Calc

Re: [Libreoffice] [PATCHSET] [PUSHED, partial] calc - removal of dead code

2011-01-18 Thread Kohei Yoshida
#include vcl/msgbox.hxx //--- Other than that, the rest have been applied pushed. Thanks a lot! Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

Re: [Libreoffice] WaE patch for sc filter

2011-01-18 Thread Kohei Yoshida
that to sal_False. All pushed to master. Thanks a lot! Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] WaE patch for sc filter

2011-01-18 Thread Kohei Yoshida
. All pushed to master. Thanks a lot. :-) Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] Make --help and --version work even without $DISPLAY

2011-01-18 Thread Kohei Yoshida
, but I guess I didn't fix it correctly wrt the DISPLAY setting. ;-) Thanks a lot for the right fix. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

Re: [Libreoffice] Calc crash when save as xls

2011-01-19 Thread Kohei Yoshida
On Wed, 2011-01-19 at 08:50 -0500, Kohei Yoshida wrote: On Wed, 2011-01-19 at 14:04 +0700, Tantai Tanakanok wrote: Hi all, I have successfully built LibreOffice 3.3.0 OOO330m18 (Build:4) on Ubuntu 10.04. I try to save xls from Calc. After clicking the “Keep Current Format” button

[Libreoffice] Help on several critical bugs for the Japanese users

2011-01-19 Thread Kohei Yoshida
-- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] creating a i18n.Collator service for calc's unit test

2011-01-19 Thread Kohei Yoshida
. In my understanding the soffice process locates service via services.rdb, which doesn't yet exist during the build process esp at the time when the building of the sc module finishes. So, I have no idea how best to go about this. Does anyone else have any clues? TIA, Kohei -- Kohei Yoshida

[Libreoffice] [REVIEW] fix for incorrect cell attribute import from xls

2011-01-20 Thread Kohei Yoshida
document in Excel. 2) Put a border around cell A4. 3) Save it. 4) Open it in Calc. Now cells A1:A4 all have the borders. This is for the libreoffice-3-3 branch, not the libreoffice-3-3-0, so I need one person to review this and sign off on this. TIA, Kohei -- Kohei Yoshida, LibreOffice hacker

[Libreoffice] [REVIEW] cherry-picking a fix to 3.3

2011-01-20 Thread Kohei Yoshida
someone please review the change and give me a sign-off if it's good? The change is very safe, and I hope that's apparent in the commit above. TIA, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list

[Libreoffice] Named range in DataPilot

2011-01-21 Thread Kohei Yoshida
a new table using a range name as the data source yet. I may work on this at a later time once I have some idea of what UI change is required. BTW, while working on this, I've discovered fixed a weird data-pilot refresh issue. I thought I'd mention. Testing appreciated. Kohei -- Kohei

Re: [Libreoffice] [PATCH] [PUSHED, partial] Some comments and basic cleanup in sc

2011-01-24 Thread Kohei Yoshida
. Could you revise 0001 and 0003 and resend them? Thanks! Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED, partial] Some comments and basic cleanup in sc

2011-01-24 Thread Kohei Yoshida
to an agreement. So I've decided to push your other patches meanwhile. We can fix them afterward if we so decide. Thanks, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice

Re: [Libreoffice] [PATCH] [PUSHED, partial] Some comments and basic cleanup in sc

2011-01-25 Thread Kohei Yoshida
On Tue, 2011-01-25 at 00:27 -0600, Norbert Thiebaud wrote: On Mon, Jan 24, 2011 at 1:24 PM, Kohei Yoshida kyosh...@novell.com wrote: On Mon, 2011-01-24 at 18:32 +0100, Soeren Moeller wrote: Hi Thanks for pushing 0002 and 0004. In the doxygen documentation on http://www.stack.nl

Re: [Libreoffice] Crash in master: Sum button in sc

2011-01-25 Thread Kohei Yoshida
clean; ./g pull; make; make dev-install. Yup, this is perfectly reproducible. Anyway, it would be great if you could get a backtrace output from gdb to see where the crash occurs. Let me know if you need additional help. Best, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh

Re: [Libreoffice] [PUSHED] Crash in master: Sum button in sc

2011-01-26 Thread Kohei Yoshida
On Wed, 2011-01-26 at 23:59 +0100, Soeren Moeller wrote: Thanks for the answer. I now used gdb to locate the segfault, and found it to happen when ScViewFunc called ScRangeList.front() with an empty range list, which resulted in a segfault while trying to retrieve the first element of the

Re: [Libreoffice] Rationale for replacing Java with anything but c++ (was Re: web based libre office)

2011-01-28 Thread Kohei Yoshida
by now (sure looks like it), but perhaps you can pick up his basic ideas or (license permitting) his code to start from. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] Run soffice -env:UserInstallation=$(URL) to get LO OSX Portable

2011-01-28 Thread Kohei Yoshida
. Perhaps you can try something like file:///Users/gand/PortableLO/3 or something like that. I don't have Mac to verify, so I'm just making an educated guess. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list

Re: [Libreoffice] [PATCH] EasyHacks 4.13 - get rid of macros from svarray.hxx

2011-01-28 Thread Kohei Yoshida
. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] EasyHacks 4.13 - get rid of macros from svarray.hxx

2011-01-28 Thread Kohei Yoshida
On Fri, 2011-01-28 at 10:50 -0500, Kohei Yoshida wrote: Thanks for your patches. Oh yeah, I almost forgot. ;-) You don't need to remove all trailing whitespaces in those files you modify, as that would create unnecessary hunks making it harder for us to review your patches. I thought

Re: [Libreoffice] [PATCH] [PUSHED] EasyHacks 4.13 - get rid of macros from svarray.hxx

2011-01-28 Thread Kohei Yoshida
On Fri, 2011-01-28 at 10:57 -0500, Kohei Yoshida wrote: Oh yeah, I almost forgot. ;-) And I forgot to put [PUSHED] to the subject line ;-) Perhaps I need more caffeine Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] [PATCH] EasyHacks 4.13 - get rid of macros from svarray.hxx

2011-01-28 Thread Kohei Yoshida
On Fri, 2011-01-28 at 17:03 +, Nigel Hawkins wrote: On Fri, 2011-01-28 at 10:50 -0500, Kohei Yoshida wrote: Here, you've changed the semantics of the code. I've fixed that to push_back(nTab+i) which is probably what we need to do here. Sorry. My bad. Not a problem. I eventually

Re: [Libreoffice] SCID_NEWDOCUMENT

2011-01-28 Thread Kohei Yoshida
transfer code), but we can probably remove the majority of them. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] SCID_NEWDOCUMENT

2011-01-28 Thread Kohei Yoshida
of SCID_NEWDOCUMENT in binfilter/inc/bf_sc/rechead.hxx, so we can still safely remove the one in sc/inc/rechead.hxx without affecting binfilter. The same applies to other SCID_* too. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] [PATCH] [PUSHED] Easy hacks: remove double line spacing

2011-01-28 Thread Kohei Yoshida
On Fri, 2011-01-28 at 22:46 +0100, Christina Roßmanith wrote: Hi, I removed the double line spacings in one file. Hope the resulting style is ok. If so, I'll continue :-) Easy one. :-) Pushed. -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] A file to show 8192 discontinuities crashes Calc

2011-01-28 Thread Kohei Yoshida
. While RC3 did fix this temporarily by pulling Oracle's fix for this from OOo, it also did cause a serious regression so we decided to pull it out. Plus it was a pretty large, invasive change, which also made me feel uncomfortable taking at that late RC stage. Kohei -- Kohei Yoshida, LibreOffice

Re: [Libreoffice] [PATCH] Cleaned up in dpsave.hxx/.cxx

2011-01-31 Thread Kohei Yoshida
... macros (supposedly from tools/debug), are those still used/meaningful? I don't use them, and I don't mind them gone. Feel free to remove them. ;-) Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list

Re: [Libreoffice] [PATCH] Call-catcher: removed unused functions in calc

2011-02-01 Thread Kohei Yoshida
the one method you'd commented out. That one appears to be unused. I'm build-testing it in debug mode right now. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

Re: [Libreoffice] [PATCH] [PUSHED] Call-catcher: removed unused functions in calc

2011-02-01 Thread Kohei Yoshida
On Tue, 2011-02-01 at 09:31 -0500, Kohei Yoshida wrote: I'm build-testing it in debug mode right now. Done. build debug=t also builds fine. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list

Re: [Libreoffice] [PATCH] avoid ambiguous else

2011-02-02 Thread Kohei Yoshida
have r Cheers, -- Takeshi Abe ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] [PATCH] avoid ambiguous else

2011-02-02 Thread Kohei Yoshida
when eType != SC_CAT_CONTENT I have no idea how the compiler parses that block of code as it is indeed ambiguous. But I'm more in favor of interpreting it based on the indent levels than how the compiler might be parsing it. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] [PATCH] [PUSHED] Convert tools/list.hxx usage to std::list

2011-02-02 Thread Kohei Yoshida
talked about this on IRC, I don't like the idea of replacing one macro with another, even if the documentation page claims this to be a good-behaving macro. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list

Re: [Libreoffice] [PATCH] avoid ambiguous else

2011-02-02 Thread Kohei Yoshida
On Wed, 2011-02-02 at 23:27 +0100, Thomas Arnhold wrote: Oh, I think this was a mistake o mine. I removed the brackets, didn't really thought, that the else statement could be associated with the inner if. I attached the patch to bring the brackets back. No worries I'd already put the fix in

Re: [Libreoffice] [PATCH] [PUSHED] Removed unused functions in calc 2

2011-02-02 Thread Kohei Yoshida
, so it's okay to skip those files for now. Regards, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] HTML formatting in comments?

2011-02-03 Thread Kohei Yoshida
neutral on this; they don't bother me when I read them, but I don't personally use them. So, no strong opinion from me. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] Fwd: [tdf-discuss] feature request, calc cell content copy behaviour

2011-02-07 Thread Kohei Yoshida
#Allow_copy_and_paste_of_multiple_ranges Added to Easy Hacks page. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] BUG: Auto filter

2011-02-07 Thread Kohei Yoshida
accurate - in fact, please file a bug report here: FYI, this is already an easy hack task. http://wiki.documentfoundation.org/Development/Easy_Hacks#Allow_one_autofilter_per_sheet.2C_not_per_document Anyone interested? Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] Issues for pivot tables ... where to post

2011-02-08 Thread Kohei Yoshida
bugzilla, and please assign that directly to me. I'm working on the data pilot code right now to fix several issues I discovered have been broken since 3.3. So, it's nice to know any regressions to data pilot while I'm at it. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] How to make cell with list data validation, a combo box

2011-02-08 Thread Kohei Yoshida
filtering options. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] Remove obsolete Hyperlink Bar from calc

2011-02-08 Thread Kohei Yoshida
be making one patch per app/module. Gotcha. I like your strategy. Go for it! Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [Libreoffice] [PUSHED] translated parts of German comment in svtools/inc/ruler.hxx

2011-02-08 Thread Kohei Yoshida
On Tue, 2011-02-08 at 23:15 +0100, Tobias Rosenberger wrote: this patch is LGPLv3+/MPL. Thanks! Pushed. -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

Re: [Libreoffice] [PUSHED] patch translating comments

2011-02-08 Thread Kohei Yoshida
Looks like someone has already applied this patch. Setting [PUSHED] tag in the subject line. -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org

Re: [Libreoffice] [PATCH] [PUSHED] Get rid of SvBytes/SvSvULongs in SwUndoDelNum

2011-02-08 Thread Kohei Yoshida
guys. Thanks a lot. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Fwd: [tdf-discuss] Problem with linking external sheets in CALC

2011-02-08 Thread Kohei Yoshida
. Or could someone to make a sugestion to the developers to fix it So, what's broken in the current implementation? Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

Re: [Libreoffice] Fwd: [tdf-discuss] Problem with linking external sheets in CALC

2011-02-08 Thread Kohei Yoshida
On Tue, 2011-02-08 at 23:16 -0500, Kohei Yoshida wrote: On Mon, 2011-02-07 at 20:19 +0700, Nguyen Vu Hung wrote: Hi OP and Kohei-san, FYI, consider this as a nasty hack or a bug? Well, if the sheet name of an external document changes, of course it will break links. Nothing we can do

Re: [Libreoffice] adding easy hacks ...

2011-02-09 Thread Kohei Yoshida
On Wed, 2011-02-09 at 06:38 +, Michael Meeks wrote: On Mon, 2011-02-07 at 23:05 -0500, Kohei Yoshida wrote: http://wiki.documentfoundation.org/Development/Easy_Hacks#Allow_copy_and_paste_of_multiple_ranges Added to Easy Hacks page. So - to make it truly 'Easy' - an easy hack

Re: [Libreoffice] Issues for pivot tables ... where to post

2011-02-11 Thread Kohei Yoshida
On Fri, 2011-02-11 at 11:47 +0100, Cor Nouws wrote: Hi Kohei, Kohei Yoshida wrote (08-02-11 16:10) On Tue, 2011-02-08 at 13:23 +0100, Cor Nouws wrote: Someone writes about an issue in OOo/Lo 330, that was not present in OOo 321. Is it better to post that in Bugzilla or in the OOo

[Libreoffice] [REVIEW] Takao font support for 3.3.1.

2011-02-11 Thread Kohei Yoshida
understand correctly Takao font is used by several Linux distros as the default Japanese UI font, so getting that font recognized properly is pretty important. The change is pretty simple and IMO non-intrusive. Thanks, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] Fwd: [tdf-discuss] feature request, calc cell content copy behaviour

2011-02-12 Thread Kohei Yoshida
On Tue, 2011-02-08 at 11:13 +0700, Nguyen Vu Hung wrote: On Tue, Feb 8, 2011 at 11:05 AM, Kohei Yoshida kyosh...@novell.com wrote: On Mon, 2011-02-07 at 02:29 +0700, Nguyen Vu Hung wrote: m$ excel allows content in cells a1, a3, a5 to be selected and copied to a7, a9, a11

<    1   2   3   4   5   6   7   8   9   10   >