Re: [Libreoffice] Fwd: [tdf-discuss] feature request, calc cell content copy behaviour

2011-02-14 Thread Kohei Yoshida
On Mon, 2011-02-14 at 09:44 -0500, Kohei Yoshida wrote: On Sun, 2011-02-13 at 17:35 +1100, Simon Cropper wrote: The behaviour that I am talking about is... 1. Insert value into A1, select the cell with the mouse so it is highlighted then copy with Ctrl-C 2. Select 3 or more other cells

Re: [Libreoffice] [PATCH] [PUSHED] Remove legacy Addin functions from calc

2011-02-14 Thread Kohei Yoshida
On Mon, 2011-02-14 at 13:40 +, Alfonso Eusebio wrote: Thanks all for the input! For what I can see, the quoted comment was introduced by Kurt Zenker in Sep-2006. ROT13 and the other date management functions present in the calc/addin code seem to be part of the newer (UNO based?)

[Libreoffice] How to build a multi-lang installer on Windows

2011-02-16 Thread Kohei Yoshida
separate installers, instead of one that contains both languages, and he says that the ja installer still sets the UI language to be English. Is there any specific steps one has to take in order to build a multi-lang installer? TIA, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] [PATCH] [PUSHED] Translation of German comment in libs-core/desktop

2011-02-16 Thread Kohei Yoshida
Accidentally replied only to Albert (not used to using gmail to manage mailing lists). This patch is pushed to master. Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Remove dead code

2011-02-17 Thread Kohei Yoshida
On Thu, 2011-02-17 at 10:34 +0100, Bálint Dózsa wrote: Hi, I have removed some dead code form /xmloff. My code is under the LGPLv3+/MPL dual license. Pushed to master (with a little bit of modification). Thanks a lot. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] [PATCH] [PUSHED] Removed unused methods

2011-02-17 Thread Kohei Yoshida
that in your commit. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] mso-dumper moved to its own repository

2011-02-17 Thread Kohei Yoshida
-- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] Properly update column and row header selections. (fdo#34383)

2011-02-17 Thread Kohei Yoshida
On Thu, 2011-02-17 at 22:59 -0500, Kohei Yoshida wrote: I'd like to cherry-pick this commit http://cgit.freedesktop.org/libreoffice/calc/commit/?id=f3df9f8674d559d38b638396cd48c9eb8f0ecca6 into libreoffice-3-3 branch, and (if I can gather enough sign-off's) into libreoffice-3-3-1 branch

Re: [Libreoffice] [PUSHED] Re: [PATCH] DECLARE_LIST(TOXControlList, Control*) to std::vectorControl* in sw.

2011-02-18 Thread Kohei Yoshida
, but not guaranteed.) It's better (and safer) to use std::advance to advance the iterator position, or ++ or -- if it's only a change of one position. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list

Re: [Libreoffice] [REVIEW] Properly update column and row header selections. (fdo#34383)

2011-02-18 Thread Kohei Yoshida
On Fri, 2011-02-18 at 10:40 +, Caolán McNamara wrote: On Thu, 2011-02-17 at 22:59 -0500, Kohei Yoshida wrote: I'd like to cherry-pick this commit http://cgit.freedesktop.org/libreoffice/calc/commit/?id=f3df9f8674d559d38b638396cd48c9eb8f0ecca6 into libreoffice-3-3 branch

Re: [Libreoffice] [PATCH] [PUSH] Translate german comments

2011-02-18 Thread Kohei Yoshida
On Fri, 2011-02-18 at 12:13 +0100, Martin Kepplinger wrote: Translated german comments in /writer/sw/source/ui/app/appenv.cxx to english. Nice work. :-) Pushed to master. This is my first patch to libreoffice. Welcome to our team! Looking forward to more patches from you in the future. :-)

Re: [Libreoffice] [PATCH] [PUSH] Translate german comments

2011-02-18 Thread Kohei Yoshida
On Fri, 2011-02-18 at 11:29 -0500, Kohei Yoshida wrote: On Fri, 2011-02-18 at 12:13 +0100, Martin Kepplinger wrote: Translated german comments in /writer/sw/source/ui/app/appenv.cxx to english. Nice work. :-) Pushed to master. Actually, can you confirm that your patch is submitted under

Re: [Libreoffice] [PATCH] [writer/sw/source/ui/app] Translate german comments

2011-02-18 Thread Kohei Yoshida
On Fri, 2011-02-18 at 13:16 +0100, Martin Kepplinger wrote: Translated the german comments to english an fixed minor coding style issues in apphdl.cxx and applab.cxx As with your other patch, please confirm that your patch is under LGPLv3 +/MPL dual license. Thanks! Kohei

Re: [Libreoffice] [PATCH] [PUSH] Translate german comments

2011-02-18 Thread Kohei Yoshida
without mentioning of the license, we may just assume that it is under the same license as with his previous patches. But that's sort of a gray area. Should I resend the patch? No need to re-send your patch. Just mentioning it on the list will be sufficient. Kohei -- Kohei Yoshida, LibreOffice

Re: [Libreoffice] [PATCH] [PUSHED] [writer/sw/source/ui/app] Translate german comments

2011-02-18 Thread Kohei Yoshida
On Fri, 2011-02-18 at 17:48 +0100, Martin Kepplinger wrote: Am 2011-02-18 17:34, schrieb Kohei Yoshida: On Fri, 2011-02-18 at 13:16 +0100, Martin Kepplinger wrote: Translated the german comments to english an fixed minor coding style issues in apphdl.cxx and applab.cxx As with your

Re: [Libreoffice] [REVIEW] Properly update column and row header selections. (fdo#34383)

2011-02-18 Thread Kohei Yoshida
On Fri, 2011-02-18 at 11:01 -0500, Kohei Yoshida wrote: Are their two more brave folks with sharp eyes who can take a quick look and see if the change makes sense for the 3.3.1 branch as well? :-) OTOH, it's probably not a good idea to cherry-pick this to 3.3.1, since we are trying to push RC2

Re: [Libreoffice] [PATCH] Cleaning include headers in calc, removing tool/list.hxx

2011-02-18 Thread Kohei Yoshida
...@gmail.com To set your correct name you can run git config --global user.name Rafael Dominguez and this will get reflected in your next commit and thereafter. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing

Re: [Libreoffice] [PATCH] [PUSHED] Cleaning include headers in calc, removing tool/list.hxx

2011-02-18 Thread Kohei Yoshida
On Fri, 2011-02-18 at 15:58 -0500, Kohei Yoshida wrote: But it would be nice if you could set your correct name so that the commit record contains your real name. Right now the commit shows your identity as npcdoom venccsra...@gmail.com For this commit I fixed the author name for you

Re: [Libreoffice] [PATCH] [PUSHED] Removed commented code

2011-02-18 Thread Kohei Yoshida
Hi Christina, On Fri, Feb 18, 2011 at 4:21 PM, Christina Roßmanith chrrossman...@web.de wrote: Hi, I've removed some lines of commented code in libs-core/connectivity/source/drivers/file/  FResultSet.cxx  FStatement.cxx  fanalyzer.cxx  fcomp.cxx Looks all good. Pushed. I had to change

Re: [Libreoffice] external references with OFFSET function cause a crash

2011-02-21 Thread Kohei Yoshida
On Mon, 2011-02-21 at 22:47 +0900, Takeshi Abe wrote: Any thought? Try the latest master. This (the crasher) has already been fixed there. Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] external references with OFFSET function cause a crash

2011-02-21 Thread Kohei Yoshida
On Tue, 2011-02-22 at 00:14 +0900, Takeshi Abe wrote: Hi Kohei, On Mon, 21 Feb 2011 09:52:37 -0500, Kohei Yoshida kyosh...@novell.com wrote: Try the latest master. This (the crasher) has already been fixed there. hmm, do you mean 39647f4711af6a6d50ff58754004874ec42265ce ? Then we have

Re: [Libreoffice] external references with OFFSET function cause a crash

2011-02-21 Thread Kohei Yoshida
On Mon, 2011-02-21 at 10:26 -0500, Kohei Yoshida wrote: On Tue, 2011-02-22 at 00:14 +0900, Takeshi Abe wrote: Hi Kohei, On Mon, 21 Feb 2011 09:52:37 -0500, Kohei Yoshida kyosh...@novell.com wrote: Try the latest master. This (the crasher) has already been fixed there. hmm, do you

Re: [Libreoffice] Is testing/testautomation really needed ?

2011-02-21 Thread Kohei Yoshida
who are scanning for old, unmerged patches (like me) from the large pile of emails on the list... Thanks, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

[Libreoffice] Patch handling guideline

2011-02-21 Thread Kohei Yoshida
, those patches probably comprise roughly ~30% of all incoming patches. I'd like to know what others think of the current situation, and if there is a good way to handle this. Feedback appreciated. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] [PATCH] [PUSHED] Translation of German comment in libs-core/uui

2011-02-21 Thread Kohei Yoshida
-- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Is testing/testautomation really needed ?

2011-02-21 Thread Kohei Yoshida
On Mon, 2011-02-21 at 18:16 +0100, Francois Tigeot wrote: On Mon, Feb 21, 2011 at 11:28:19AM -0500, Kohei Yoshida wrote: On Fri, 2011-02-18 at 10:28 +0100, Francois Tigeot wrote: There's some value in that. I've attached a small patch instead ;) Looks like someone has already applied

Re: [Libreoffice] [PATCH] Conditional compilation of legacy Addin mechanism in calc

2011-02-21 Thread Kohei Yoshida
On Sat, 2011-02-19 at 09:33 +, Alfonso Eusebio wrote: Hi, Please find attached patches for the conditional removal of legacy calc addins. As always, these changes are made available under LGPLv3+/MPL. Kohei, I have used a macro definition to conditionally compile the code in/out.

Re: [Libreoffice] Please review our patch for Bug 33089 – Calc export of non-gregorian date to Excel loses format

2011-02-21 Thread Kohei Yoshida
provide a little more context to the patch? Thanks! Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Translation of German comment in libs-core/svx/source/dialog/

2011-02-21 Thread Kohei Yoshida
comment, be sure to remove the lower part of the original commit frame (the part that begins with |* and everything until the */ on the next line). Thanks, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing

Re: [Libreoffice] [PATCH] [PUSHED] Translate german comments of writer/sw/source/ui/cctrl

2011-02-21 Thread Kohei Yoshida
simply by running 'git am' command. That's the preferred way because git format-patch preserves the commit message and the committer information as well as it handles changes in binary blobs. These are something the conventional patch format does not handle. Kohei -- Kohei Yoshida, LibreOffice

Re: [Libreoffice] [PATCH] [writer/sw/source/ui/app] Translate comments of docsh

2011-02-22 Thread Kohei Yoshida
-- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [writer/sw/source/ui/app] Translate comments of docsh

2011-02-22 Thread Kohei Yoshida
On Tue, 2011-02-22 at 09:46 -0500, Kevin Hunter wrote: At 9:40am -0500 Tue, 22 Feb 2011, Kohei Yoshida wrote: This is another useful tip for patch integrators. From my own experience of handling patches sent by git send-mail, sometimes they don't attach the patch as an attachment

Re: [Libreoffice] [PUSHED] Remove bogus comment

2011-02-22 Thread Kohei Yoshida
On Tue, 2011-02-22 at 23:19 +0100, Michaël Lefèvre wrote: Hye, I'm joining the fun. Here's my first time to git, and first patch for Libreoffice. Welcome to the club! Pushed to master. Looking forward to more patches from you in the future. Kohei -- Kohei Yoshida, LibreOffice hacker

Re: [Libreoffice] Patch handling guideline

2011-02-23 Thread Kohei Yoshida
this option when committing changes to stable branches, where it requires one or more developers to sign off on commits. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice

Re: [Libreoffice] git am - German keywords

2011-02-24 Thread Kohei Yoshida
On Thu, 2011-02-24 at 15:29 +0100, Martin Kepplinger wrote: Am 2011-02-23 21:35, schrieb Kohei Yoshida: On Wed, 2011-02-23 at 21:11 +0100, Christina Roßmanith wrote: Hi, does anybody know whether git am relies on the keywords subject: or is Betreff: (the German equivalent) valid

Re: [Libreoffice] [PATCH] Remove using namespace ::rtl in sc

2011-02-24 Thread Kohei Yoshida
On Thu, 2011-02-24 at 15:30 +, Caolán McNamara wrote: On Thu, 2011-02-24 at 10:11 -0500, Kohei Yoshida wrote: On Thu, 2011-02-24 at 15:26 +0100, Julien Nabet wrote: 2) must we remove all the rtl:: stuff ? If you mean using namespace rtl;, yes, because that could cause conflict

Re: [Libreoffice] Comment-translation of writer/sw/source/ui/config

2011-02-24 Thread Kohei Yoshida
send-email --thread --no-change-reply-to does, which the guideline mentions. http://wiki.documentfoundation.org/Development/Patch_Handling_Guideline under Send patches as attachments or use git send-email. We need to either continue allowing this, or change the guideline. Kohei -- Kohei Yoshida

Re: [Libreoffice] Comment-translation of writer/sw/source/ui/config

2011-02-24 Thread Kohei Yoshida
On Thu, 2011-02-24 at 21:31 +0100, Pierre-André Jacquod wrote: On 02/24/2011 08:33 PM, Kohei Yoshida wrote: On Thu, 2011-02-24 at 19:46 +0100, Jonathan Aquilina wrote: Martin i think it would be easier as well as not to end up having ur email black listed for sending out large amounts

[Libreoffice] [REVIEW] Backport to libreoffice-3-3

2011-03-02 Thread Kohei Yoshida
://bugs.freedesktop.org/show_bug.cgi?id=34831 Just to highlight that many users seem to hit this problem in 3.3, hence the need to backport to the 3.3 branch. Sorry about the renaming of a function that may make reviewing of this patch a bit harder. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh

[Libreoffice] [REVIEW] fix for a chart crasher

2011-03-02 Thread Kohei Yoshida
, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Macro maded with Macrosoft Office

2011-03-02 Thread Kohei Yoshida
are largely bound to the internal component model of the application, and because Excel and Calc do have different component models their macros are also structured differently. HTH, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

[Libreoffice] [REVIEW] Volatile function fix for 3.3.x

2011-03-02 Thread Kohei Yoshida
/commit/?id=3ac33327631408ddc0025ac87f339e23a5746564 http://cgit.freedesktop.org/libreoffice/calc/commit/?id=a61620da9c3e13c665d99dc3c8267086c8bfe641 which cancel out most of the changes and leaves only the attached change. It's a very safe change, for a real useful bug fix. Kohei -- Kohei

Re: [Libreoffice] [REVIEW] fix for a chart crasher

2011-03-03 Thread Kohei Yoshida
should definitely look into why the negative value occurs in the first place, but this change is still necessary regardless of the outcome. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice

Re: [Libreoffice] [REVIEW] fix for a chart crasher

2011-03-03 Thread Kohei Yoshida
for this other than to say that this practice was probably largely inspired by Java, which doesn't have unsigned integer types. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice

Re: [Libreoffice] [REVIEWED] Volatile function fix for 3.3.x

2011-03-03 Thread Kohei Yoshida
On Thu, 2011-03-03 at 09:24 +, Michael Meeks wrote: Hi Kohei, On Wed, 2011-03-02 at 23:52 -0500, Kohei Yoshida wrote: I'd like to backport another fix from master to libreoffice-3-3. The change is very simple, as attached patch shows. But that alone fixes https

Re: [Libreoffice] [REVIEW] Backport to libreoffice-3-3

2011-03-03 Thread Kohei Yoshida
On Thu, 2011-03-03 at 17:46 +0100, Thorsten Behrens wrote: Kohei Yoshida wrote: I'd like to cherry-pick the following commit http://cgit.freedesktop.org/libreoffice/calc/commit/?id=63f695b8cf3572c2697abcfe99e2e7d5da923e9b to the libreoffice-3-3 branch. This fixes https

Re: [Libreoffice] [REVIEW] fix for a chart crasher

2011-03-03 Thread Kohei Yoshida
. Even with this change, though, the displayed graph showed on difference. So, no data loss here. Now, can someone please sign off of this, or is this change still too risky or questionable? :-) Thanks, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] [PATCH] Remove useless comment

2011-03-05 Thread Kohei Yoshida
Hi Korrawit, First of all, I appreciate you spending time to send us your first patch. It's always nice to see someone new joining us. :-) Regarding your patch --- a/chart2/inc/pch/precompiled_chart2.hxx +++ b/chart2/inc/pch/precompiled_chart2.hxx @@ -26,7 +26,7 @@ *

Re: [Libreoffice] [REVIEWED] paralel build problem sfx2/workben/custompanel

2011-03-05 Thread Kohei Yoshida
Hi Petr, On Fri, Mar 4, 2011 at 11:32 AM, Petr Mladek pmla...@suse.cz wrote: In each case, it does not block the build and should not cause any harm. Yup, looks innocuous enough I trust your judgment on this. Pushed to libreoffice-3-3 with my sign-off.

Re: [Libreoffice] [PATCH] [PUSHED] One bool mistake in msfilter

2011-03-05 Thread Kohei Yoshida
Hi Arnaud, On Fri, Mar 4, 2011 at 7:17 AM, Arnaud Versini arnaud.vers...@gmail.com wrote: Hello, This verry small patch replace BOOL by bool for bRetValue. Thanks. Pushed to master. Can I replace all BOOL from msfilter to bool? Sure, why not. But please don't do a blind replacement of all

Re: [Libreoffice] [PATCH] OpenOffice.org - %PRODUCTNAME in Extension Manager

2011-03-05 Thread Kohei Yoshida
Hi Andras, On Sat, Mar 5, 2011 at 10:39 AM, Andras Timar tima...@gmail.com wrote: Hi, It was reported on l10n list that Extension Manager source still contains OpenOffice.org instead of LibreOffice. The attached patch replaces OpenOffice.org to %PRODUCTNAME. The patch looks good to me.

Re: [Libreoffice] Remove using namespace ::rtl

2011-03-05 Thread Kohei Yoshida
Hi Julien, On Thu, Mar 3, 2011 at 4:53 PM, Julien Nabet serval2...@yahoo.fr wrote: Hello, I finished the removing of using namespace ::rtl except in binfilters. (there were no compilation pb with my Linux env, hope it's the case with Windows and Mac envs). Even if binfilters is going to be

Re: [Libreoffice] [REVIEW] fix for a chart crasher

2011-03-07 Thread Kohei Yoshida
On Thu, 2011-03-03 at 21:43 -0500, Kohei Yoshida wrote: Now, can someone please sign off of this, or is this change still too risky or questionable? :-) Are we absolutely clear that this is too risky to be signed off for 3.3.2, or is this being overlooked? Kohei -- Kohei Yoshida

Re: [Libreoffice] [REVIEWED] fix for a chart crasher

2011-03-07 Thread Kohei Yoshida
On Mon, 2011-03-07 at 14:08 +, Michael Meeks wrote: Hi Kohei, On Wed, 2011-03-02 at 16:19 -0500, Kohei Yoshida wrote: Please review this commit http://cgit.freedesktop.org/libreoffice/calc/commit/?id=1e3b1a7a8c939a0ae08a14d5efdd65b17355dae9 Looks fine to me, notwithstanding

Re: [Libreoffice] Question about using namespace ::com::sun::star::uno

2011-03-07 Thread Kohei Yoshida
made replacements for using namespace ::rtl. Then, my preference is to *not* remove using namespace ::com::sun::star::uno across the board, but only when using that causes some build issues on some platforms. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] Question about using namespace ::com::sun::star::uno

2011-03-07 Thread Kohei Yoshida
removing the css.uno namespace. :-/ If the easy hack specifies removal of using namespace com::sun::star::uno, then I'm okay with that. But it will involve a lot of files, for sure. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] Question about using namespace ::com::sun::star::uno

2011-03-07 Thread Kohei Yoshida
On Mon, 2011-03-07 at 20:39 +0100, Bjoern Michaelsen wrote: On Mon, 07 Mar 2011 10:45:08 -0500 Kohei Yoshida kyosh...@novell.com wrote: Even with using namespace ::com::sun::star::uno, it's not clear that we want to remove this from all source files. I would rather we decide on a file

[Libreoffice] [REVIEW] Fix for formula reference breakage during file save.

2011-03-07 Thread Kohei Yoshida
the referenced cell, and invalidates the sheets they are on. Review would be appreciated. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com commit e98dd6643b15a156dbf3574343f3c076ad7ac277 Author: Kohei Yoshida kyosh...@novell.com Date: Mon Mar 7 18:40:10 2011 -0500 Properly

Re: [Libreoffice] Approaches to enable international number format import/export in Calc

2011-03-07 Thread Kohei Yoshida
-- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Approaches to enable international number format import/export in Calc

2011-03-07 Thread Kohei Yoshida
On Tue, 2011-03-08 at 00:04 -0500, Kohei Yoshida wrote: So what do you think? Given the above, to me the choice is clear. The only issue is that, we may already have lost an window of opportunity to do it the right way for 3.4. So, we may have to take your patch for 3.4, and work on my

Re: [Libreoffice] Calc Standard Filter behaviour

2011-03-09 Thread Kohei Yoshida
things in the bugzilla itself if it's very trivial. Hope this helps. And let us know if you need help. Best, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

Re: [Libreoffice] Calc Standard Filter behaviour

2011-03-09 Thread Kohei Yoshida
obviously). Don't know whether this helped ... It did. The idea of removing auto completion would never have occurred to me otherwise. ;-) Tibby, what do you think? Does this sound reasonable? Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] Important fixes for Calc filters

2011-03-09 Thread Kohei Yoshida
them into our master branch after the merge is complete. I'd love to look into that myself, but my table is already getting full for 3.4 So, no guarantees. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice

Re: [Libreoffice] Add ICU 4.6 to services.openoffice.org

2011-03-09 Thread Kohei Yoshida
Hi Martin, On Wed, Mar 9, 2011 at 11:32 PM, Martin Hosken martin_hos...@sil.org wrote: Could someone copy http://download.icu-project.org/files/icu4c/4.6/icu4c-4_6-src.tgz to http://hg.services.openoffice.org/binaries/43e56b71c407be5154de681eaa646a4a-icu4c-4_6-src.tgz No one has access to

Re: [Libreoffice] Calc Standard Filter behaviour

2011-03-10 Thread Kohei Yoshida
rather have a larger chunk done at once. Yes, both looks good. And I love a single line solution! But before I commit your patches, we'd like to confirm that you are submitting your patches under LGPLv3+/MPL dual licenses. On Wed, Mar 9, 2011 at 3:36 PM, Kohei Yoshida kyosh...@novell.com wrote

Re: [Libreoffice] [PUSHED] Calc Standard Filter behaviour

2011-03-11 Thread Kohei Yoshida
On Fri, 2011-03-11 at 09:35 +, Tibby Lickle wrote: On Fri, Mar 11, 2011 at 2:48 AM, Kohei Yoshida kyosh...@novell.com wrote: But before I commit your patches, we'd like to confirm that you are submitting your patches under LGPLv3+/MPL dual licenses

Re: [Libreoffice] [PUSHED] Calc Standard Filter behaviour

2011-03-11 Thread Kohei Yoshida
On Fri, 2011-03-11 at 10:01 -0500, Kohei Yoshida wrote: On Fri, 2011-03-11 at 09:35 +, Tibby Lickle wrote: On Fri, Mar 11, 2011 at 2:48 AM, Kohei Yoshida kyosh...@novell.com wrote: But before I commit your patches, we'd like to confirm that you

Re: [Libreoffice] [Patch] allow one anonymous db range per sheet in calc

2011-03-21 Thread Kohei Yoshida
On Tue, 2011-03-22 at 00:22 +0100, Markus Mohrhard wrote: Ok, thanks for your advice. I will rework it but suggest that the static method will be placed in ScDBCollection. Ah, yes. My finger slipped. I meant to type ScDB*, not ScDP*. :-P So many ScFooCollection in Calc core... Glad

[Libreoffice] Excel 2003 XML format

2011-03-23 Thread Kohei Yoshida
Hi list, In light of this bug report https://bugs.freedesktop.org/show_bug.cgi?id=35543 I'd like to know if anybody has an opinion about this problem. Honestly I would LOVE to remove all of our current XSLT-based filters since they cause major performance issues not scalable at all. XSLT is

Re: [Libreoffice] Excel 2003 XML format

2011-03-23 Thread Kohei Yoshida
On Wed, 2011-03-23 at 16:33 +0100, Jonathan Aquilina wrote: Kohei Is it possible to have a universal system that opens all types of microsoft formats that we support? No. Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] Excel 2003 XML format

2011-03-23 Thread Kohei Yoshida
On Wed, 2011-03-23 at 16:03 +, Michael Meeks wrote: Hi Kohei, On Wed, 2011-03-23 at 10:06 -0400, Kohei Yoshida wrote: https://bugs.freedesktop.org/show_bug.cgi?id=35543 I'd like to know if anybody has an opinion about this problem. Honestly I would LOVE to remove all of our

Re: [Libreoffice] Excel 2003 XML format

2011-03-23 Thread Kohei Yoshida
Hi Peter, Thanks for your detailed status update. On Wed, Mar 23, 2011 at 3:04 PM, Peter Jentsch pj...@guineapics.de wrote: So, I guess I'll be able to provide a patch that completely replaces that Java bases XSLT transformations with C++/libxslt based ones in a reasonable timeframe ... but!

[Libreoffice-commits] .: Branch 'feature/matrix-new-backend' - 2 commits - sc/inc sc/source

2012-07-18 Thread Kohei Yoshida
: Kohei Yoshida kohei.yosh...@gmail.com Date: Wed Jul 18 15:06:45 2012 -0400 Pass contiguous cell data as an array to matrix. This is faster. It's generally faster to pass an array of elements to matrix than passing them individually. Change-Id

[Libreoffice-commits] .: Branch 'feature/matrix-new-backend' - sc/source

2012-07-18 Thread Kohei Yoshida
sc/source/core/tool/interpr5.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 39b790bbbec4cbea4e51e0a380bdb16faccbce55 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Wed Jul 18 15:10:54 2012 -0400 Added comment. Change-Id

[Libreoffice-commits] .: Branch 'feature/matrix-new-backend' - sc/source

2012-07-18 Thread Kohei Yoshida
sc/source/core/tool/scmatrix.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 7e8d977556a474f1e25467f70bba2cf3e1ab484d Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Wed Jul 18 17:14:35 2012 -0400 This should be bool. Change-Id

[Libreoffice-commits] .: Branch 'feature/matrix-new-backend' - sc/source

2012-07-18 Thread Kohei Yoshida
sc/source/core/tool/interpr5.cxx | 104 +++ 1 file changed, 51 insertions(+), 53 deletions(-) New commits: commit 6cadf53a4add7a6bca5054dfa69705e50552a4fb Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Wed Jul 18 17:35:18 2012 -0400 Specify

Re: C++11 in LibreOffice

2012-07-19 Thread Kohei Yoshida
On Thu, Jul 19, 2012 at 7:45 AM, Michael Stahl mst...@redhat.com wrote: i don't believe an office suite will benefit all that much from sophisticated compiler optimizations; It's certainly your opinion. But I tend think that, any binary generated from a compiler could use the benefit of

mdds to be updated to 0.6.0

2012-07-19 Thread Kohei Yoshida
the work finishes. Best, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: mdds/makefile.mk mdds/mdds_0.5.3.patch mdds/mdds_0.6.0.patch ooo.lst.in

2012-07-19 Thread Kohei Yoshida
e5e5c0c0c4b9c369543f09ab44e9d3c87dc93ca1 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Thu Jul 19 13:36:05 2012 -0400 Update mdds package to 0.6.0. It builds for me. Change-Id: I3f35f6f607e4a2fc40c6ecb5a52682cbc934 diff --git a/mdds/makefile.mk b/mdds/makefile.mk index

Re: mdds to be updated to 0.6.0

2012-07-19 Thread Kohei Yoshida
On 07/19/2012 11:13 AM, Kohei Yoshida wrote: I'll let you guys know when the work finishes. Done. Pushed to master. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

Re: Replacing ScMatrix's backend

2012-07-19 Thread Kohei Yoshida
On 07/16/2012 08:33 PM, Kohei Yoshida wrote: FYI, I'm working on replacing the backend implementation of ScMatrix to using a new container to achieve better performance. I won't go into the details (since that would be boring), but just to say that I'll be modifying heavily the implementation

[Libreoffice-commits] .: sc/source

2012-07-19 Thread Kohei Yoshida
sc/source/core/tool/scmatrix.cxx |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit 52022b5f82385b28687bf46424d0d24be1964a4a Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Thu Jul 19 15:49:44 2012 -0400 Let's see if stripping the const here will fix

[Libreoffice-commits] .: sc/source

2012-07-19 Thread Kohei Yoshida
sc/source/core/tool/scmatrix.cxx |5 + 1 file changed, 1 insertion(+), 4 deletions(-) New commits: commit 15929afc1a0da30ece4b193f4d2cf327886eb440 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Thu Jul 19 16:14:07 2012 -0400 Revert Let's see if stripping the const here

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf2' - 0 commits -

2012-07-19 Thread Kohei Yoshida
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] Changes to 'feature/gsoc-calc-perf2'

2012-07-19 Thread Kohei Yoshida
New branch 'feature/gsoc-calc-perf2' available with the following commits: commit eb00ef223ff39a8baebe7cefd7e37a2b013f9da3 Author: Daniel Bankston daniel.e.banks...@gmail.com Date: Sat Jul 14 00:53:07 2012 -0500 Revert Fix for ods matrix import performance This reverts commit

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

2012-07-20 Thread Kohei Yoshida
Do not set ScSetStringParam::mbSetTextCellFormat=true for SetString() that slightly changed behavior, the nColFormat==SC_COL_TEXT case is handled separately anyway. Change-Id: I0a0f9472801dcb02af77d6eaf90170309a41e9a8 Signed-off-by: Kohei Yoshida kohei.yosh...@gmail.com

Re: [REVIEW 3-6, 3-6-0] [PUSHED 3-6] resolved fdo#52205 do not force all text cells in CSV import

2012-07-20 Thread Kohei Yoshida
the original issue that the old behavior was intended to fix, so I think it's safe to keep the new behavior. Pushed to the -3-6 branch with my sign-off. We need 2 more sign-offs to push this to the -3-6-0 branch (I assume?). Kohei -- Kohei Yoshida, LibreOffice hacker, Calc

Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument

2012-07-20 Thread Kohei Yoshida
On 07/20/2012 10:04 AM, Caolán McNamara wrote: On Thu, 2012-07-19 at 17:58 +0200, Markus Mohrhard wrote: Hey Eike, Kohei, 2012/7/19 Kohei Yoshida kohei.yosh...@gmail.com: I'm also not fully convinced of this patch. This behavior has been in Libreoffice since the start so IMHO it is more

Re: Changes needed for LibreOffice 4

2012-07-20 Thread Kohei Yoshida
on that for 3.7 (one of Daniel's GSOC tasks). So, it's safe to remove it IMO. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: sc/source

2012-07-20 Thread Kohei Yoshida
sc/source/core/tool/scmatrix.cxx | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) New commits: commit 87404d2671e78225aa91ead79ebf7191f6317a16 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Fri Jul 20 23:31:06 2012 -0400 It's much faster to pass value array in one

Re: C++11 in LibreOffice

2012-07-20 Thread Kohei Yoshida
this structure. Also, ScMatrix's new backend now uses it. My hope is to use ScMatrix as a test-drive and try to get all its kinks sorted out before using this to store cells in ScColumn. Best, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc

mdds::multi_type_vector (was: Re: C++11 in LibreOffice)

2012-07-23 Thread Kohei Yoshida
++ with only -Os flag. I haven't tested it with any other optimization flags that gcc provides. Best, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org

Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument

2012-07-23 Thread Kohei Yoshida
On 07/23/2012 11:36 AM, Eike Rathke wrote: Hi Kohei, On Friday, 2012-07-20 10:10:48 -0400, Kohei Yoshida wrote: I'll add this configuration option during 3.7 cycle if this can wait until 3.7. If you guys need it earlier than that I could work on it and push it as a late feature if it's

[Libreoffice-commits] .: Branch 'libreoffice-3-6-0' - sc/source

2012-07-23 Thread Kohei Yoshida
, fdo#52340 (cherry picked from commit 669784c6653732fd2ad43024332957d5df5652bb) Change-Id: I7c4cb1a5f31ba9e37a280af2243a13c57914cb2f Signed-off-by: Eike Rathke er...@redhat.com Signed-off-by: Michael Meeks michael.me...@suse.com Signed-off-by: Kohei Yoshida kohei.yosh

[Libreoffice-commits] .: Branch 'feature/matrix-new-backend' - 0 commits -

2012-07-23 Thread Kohei Yoshida
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] Changes to 'feature/calc-empty-string-config'

2012-07-23 Thread Kohei Yoshida
New branch 'feature/calc-empty-string-config' available with the following commits: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'feature/calc-empty-string-config' - 0 commits -

2012-07-23 Thread Kohei Yoshida
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] Changes to 'feature/calc-empty-string-config'

2012-07-23 Thread Kohei Yoshida
New branch 'feature/calc-empty-string-config' available with the following commits: commit 972064f5d10ba1decaed5dfb1b115b846b5a89f6 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Mon Jul 23 17:49:03 2012 -0400 Add new formula config option in the UI for treat empty string as zero

[Libreoffice-commits] .: Branch 'feature/calc-empty-string-config' - sc/inc sc/source

2012-07-23 Thread Kohei Yoshida
a4c0a7c0abe44e782e7ec6459bab3f1e524c6d05 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Mon Jul 23 18:10:08 2012 -0400 Using ScCalcConfig throughout saves quite a bit of code. Change-Id: I697b03d603a99cdb58c31d78447bbed10230311e diff --git a/sc/inc/formulaopt.hxx b/sc/inc/formulaopt.hxx index

[Libreoffice-commits] .: Branch 'feature/calc-empty-string-config' - 5 commits - officecfg/registry sc/source

2012-07-23 Thread Kohei Yoshida
- sc/source/ui/optdlg/calcoptionsdlg.hxx |2 5 files changed, 54 insertions(+), 21 deletions(-) New commits: commit 1a37fe6ac99b8520ee2f47dfcb0d8eadcfbe6802 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Mon Jul 23 21:17:53 2012 -0400 Unused parameter

<    1   2   3   4   5   6   7   8   9   10   >