[Libreoffice-commits] .: sc/inc sc/source

2012-07-03 Thread Kohei Yoshida
sc/inc/dpitemdata.hxx |1 + sc/source/core/data/dpcache.cxx|2 ++ sc/source/core/data/dpitemdata.cxx |6 ++ 3 files changed, 9 insertions(+) New commits: commit f2ac4ff6600a7d20a519e9ef9e6bcd8157288f63 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Tue Jul

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/inc sc/source

2012-07-03 Thread Kohei Yoshida
sc/inc/dpitemdata.hxx |1 + sc/source/core/data/dpcache.cxx|2 ++ sc/source/core/data/dpitemdata.cxx |6 ++ 3 files changed, 9 insertions(+) New commits: commit 6d91eaaf8695da3f0da767f2669fcc650e9a76a5 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Tue Jul

[Libreoffice-commits] .: sc/inc sc/source

2012-07-05 Thread Kohei Yoshida
/ui/docshell/dbdocfun.cxx |1 13 files changed, 119 insertions(+) New commits: commit fa2b7eff2d40b6455970b521306c5961e4e3cec4 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Thu Jul 5 11:17:19 2012 -0400 fdo#51266: Sync dimension members in several places upon refresh

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/inc sc/source

2012-07-05 Thread Kohei Yoshida
/ui/docshell/dbdocfun.cxx |1 13 files changed, 119 insertions(+) New commits: commit fcc90b132168405e5a862fa4db8cfdcdcf632f65 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Thu Jul 5 11:17:19 2012 -0400 fdo#51266: Sync dimension members in several places upon refresh

[Libreoffice-commits] .: 2 commits - sc/source

2012-07-05 Thread Kohei Yoshida
sc/source/core/data/dpcache.cxx | 22 +- sc/source/core/data/dpsave.cxx |1 - 2 files changed, 21 insertions(+), 2 deletions(-) New commits: commit 6747dd33754a15e7d9f5aae01bb8299b6a05e365 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Thu Jul 5 16:08:36 2012

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - 2 commits - sc/source

2012-07-05 Thread Kohei Yoshida
sc/source/core/data/dpcache.cxx | 22 +- sc/source/core/data/dpsave.cxx |1 - 2 files changed, 21 insertions(+), 2 deletions(-) New commits: commit 3988c35c9635dfc38f6a2125e5664f60f164951b Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Thu Jul 5 16:08:36 2012

[Libreoffice-commits] .: 2 commits - sc/inc sc/source

2012-07-06 Thread Kohei Yoshida
/dpsdbtab.cxx |3 ++- sc/source/core/data/dpshttab.cxx |3 ++- sc/source/core/data/dptabres.cxx |1 - 9 files changed, 18 insertions(+), 11 deletions(-) New commits: commit fad3a6bbddaf003d185d248d232e65b94939963b Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Fri Jul 6 12:49:35 2012

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - 2 commits - sc/inc sc/source

2012-07-06 Thread Kohei Yoshida
/dpsdbtab.cxx |3 ++- sc/source/core/data/dpshttab.cxx |3 ++- sc/source/core/data/dptabres.cxx |1 - 9 files changed, 18 insertions(+), 11 deletions(-) New commits: commit 3a2863afd428958ea1ec78b4dc9971c73f704741 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Fri Jul 6 12:49:35 2012

[Libreoffice-commits] .: sc/qa

2012-07-06 Thread Kohei Yoshida
sc/qa/unit/ucalc.cxx | 89 +++ 1 file changed, 89 insertions(+) New commits: commit 2758492a670618262bd42e3b938f3fdf2e9141a2 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Fri Jul 6 16:46:09 2012 -0400 New unit test for pivot table's

[Libreoffice-commits] .: sc/source

2012-07-07 Thread Kohei Yoshida
sc/source/core/data/column3.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 6935b6d9bc08ccb780bd80254ba9b26caf6ab27e Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Sat Jul 7 08:02:55 2012 -0400 fdo#43109: Don't check for simple number when text format

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

2012-07-07 Thread Kohei Yoshida
sc/source/core/data/column3.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ccd4a408683062185802f7635836a49cdb692cf9 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Sat Jul 7 08:02:55 2012 -0400 fdo#43109: Don't check for simple number when text format

Re: Proposal/Prototype support for fill in character in Calc Number Format Strings

2012-07-09 Thread Kohei Yoshida
support in LibreOffice 3.5.3 on my Ubuntu 12.04 (i686) box. Now I would like to announce this to the people taking care of the LibreOffice development. I saw in the http://listarchives.documentfoundation.org/www/discuss/msg05149.html your signature, which reads: Kohei Yoshida

[Libreoffice-commits] .: sc/qa

2012-07-09 Thread Kohei Yoshida
sc/qa/unit/ucalc.cxx |9 + 1 file changed, 9 insertions(+) New commits: commit ebc60c3297ae464898f6135e4cc5a652fb53b935 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Mon Jul 9 10:12:53 2012 -0400 Unit test for string input with custom string handling policy

[Libreoffice-commits] .: sc/qa

2012-07-09 Thread Kohei Yoshida
sc/qa/extras/sceditfieldobj-cell.cxx | 40 ++- 1 file changed, 39 insertions(+), 1 deletion(-) New commits: commit 54e592926be7410bbd44b1482288305ea568073a Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Mon Jul 9 10:59:18 2012 -0400 UNO API test

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sc/source

2012-07-09 Thread Kohei Yoshida
: I4f10654f4015b38f7ddba9d6727e06806f1d6b77 Signed-off-by: Kohei Yoshida kohei.yosh...@gmail.com diff --git a/sc/source/ui/dbgui/filtdlg.cxx b/sc/source/ui/dbgui/filtdlg.cxx index 93ad302..c744d85 100644 --- a/sc/source/ui/dbgui/filtdlg.cxx +++ b/sc/source/ui/dbgui/filtdlg.cxx @@ -318,7 +318,31 @@ void

Re: [REVIEWED 3-5] [PUSHED 3-5] resolved rhbz#838248 init filter criteria string

2012-07-09 Thread Kohei Yoshida
On Mon, Jul 9, 2012 at 1:07 PM, Eike Rathke er...@redhat.com wrote: Hi, Please review and cherry-pick to 3-5 http://cgit.freedesktop.org/libreoffice/core/commit/?id=32a254be64fbce1fc7b0a9ecae358ce71a56f1d9 fixes https://bugzilla.redhat.com/show_bug.cgi?id=838248 Makes sense. Pushed to 3-5

Re: Trigger Filter Dialog

2012-07-10 Thread Kohei Yoshida
-- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Trigger Filter Dialog

2012-07-10 Thread Kohei Yoshida
On 07/10/2012 04:08 PM, Kohei Yoshida wrote: On 07/10/2012 03:59 PM, Joel Madero wrote: I'm working on the bug but can't really test anything because I can't figure out how to force the dialog to appear. Appreciate any guidance (or a file that will trigger it). Seeing that dialog means

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf2' - 0 commits -

2012-07-11 Thread Kohei Yoshida
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] Changes to 'feature/gsoc-calc-perf2'

2012-07-11 Thread Kohei Yoshida
New branch 'feature/gsoc-calc-perf2' available with the following commits: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Calc's tab colors and GTK tabs

2012-07-11 Thread Kohei Yoshida
. Does anybody who is more familiar with GTK have any idea about this? I hope this can be fixed rather trivially. Thanks, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

[Libreoffice-commits] .: sc/source

2012-07-11 Thread Kohei Yoshida
sc/source/ui/unoobj/docuno.cxx | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) New commits: commit efccf50664bb56733b2216ee4be887b8b3579351 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Thu Jul 12 00:09:03 2012 -0400 fdo#51852: Temporary, band-aid fix

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

2012-07-11 Thread Kohei Yoshida
sc/source/ui/unoobj/docuno.cxx | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) New commits: commit 34314ec5eaf7d7ac42f902b91e334fae22300c8b Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Thu Jul 12 00:09:03 2012 -0400 fdo#51852: Temporary, band-aid fix

Re: Calc's tab colors and GTK tabs

2012-07-12 Thread Kohei Yoshida
On Wed, Jul 11, 2012 at 9:42 PM, Kohei Yoshida kohei.yosh...@gmail.com wrote: Hi there, I just noticed that, on master, tabs are rendered natively when using GTK backend, which is nice, and I like it a lot. Unfortunately this broke Calc's tab color feature. Now, I'm not too familiar

Re: C++11 in LibreOffice

2012-07-16 Thread Kohei Yoshida
Forgot to reply all in this gmail web interface... On Mon, Jul 16, 2012 at 12:22 PM, Kohei Yoshida kohei.yosh...@gmail.com wrote: On Mon, Jul 16, 2012 at 12:15 PM, János Uray uray.ja...@gmail.com wrote: I have a simple question. Can I use C++11 in LibreOffice development? Or at least some

Re: C++11 in LibreOffice

2012-07-16 Thread Kohei Yoshida
On Mon, Jul 16, 2012 at 12:35 PM, János Uray uray.ja...@gmail.com wrote: Thank you. It's not a happy answer though. I hoped that there are at least some little features in the intersection of the C++11-knowledge of the supported compilers. The most problematic ones are the gcc compiler used

[Libreoffice-commits] Changes to 'feature/matrix-new-backend'

2012-07-16 Thread Kohei Yoshida
New branch 'feature/matrix-new-backend' available with the following commits: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Replacing ScMatrix's backend

2012-07-16 Thread Kohei Yoshida
in the next few weeks. All of these will take place in the feature/matrix-new-backend branch. Please try not to modify code around ScMatrix too much until I'm done with this. Thanks a lot for your patience. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc

Re: Replacing ScMatrix's backend

2012-07-17 Thread Kohei Yoshida
On Tue, Jul 17, 2012 at 4:28 AM, Matúš Kukan matus.ku...@gmail.com wrote: I was also wondering, if it's easy to explain, what was happening some time ago in editeng/ ? It was nothing special. Just some refactoring to remove macro-based containers and duplicate enumeration values and so on. I

[Libreoffice-commits] .: Branch 'feature/matrix-new-backend' - sc/source

2012-07-17 Thread Kohei Yoshida
sc/source/core/tool/scmatrix.cxx |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) New commits: commit aa19675567a745060e6f2b14258b83b09a0187f4 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Tue Jul 17 13:39:31 2012 -0400 Don't forget to initialize the flag matrix

Re: FYI: Using the Clang compiler

2012-07-17 Thread Kohei Yoshida
by g++. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'feature/matrix-new-backend' - 2 commits - sc/inc sc/qa sc/source

2012-07-17 Thread Kohei Yoshida
sc/inc/scmatrix.hxx |2 ++ sc/qa/unit/ucalc.cxx |2 +- sc/source/core/tool/scmatrix.cxx | 22 -- 3 files changed, 23 insertions(+), 3 deletions(-) New commits: commit 55c3f3567be46155781d3cebfe3dc0a56182d067 Author: Kohei Yoshida kohei.yosh

Re: C++11 in LibreOffice

2012-07-17 Thread Kohei Yoshida
still produces more optimized binaries, then I would be reluctant to support switching to a different compiler (though my voice is only one head count, easily overruled by the majority votes when it comes down to it). Kohei -- Kohei Yoshida, LibreOffice hacker, Calc

[Libreoffice-commits] .: Branch 'feature/matrix-new-backend' - 3 commits - sc/inc sc/qa sc/source

2012-07-17 Thread Kohei Yoshida
1e33865cac30a7cd7d9696bbc91519a95a264aa0 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Tue Jul 17 15:55:38 2012 -0400 It's no longer possible to unionize value and string here... Thereby leaving a note to discourage use of ScMatrixValue. Incidentally, now all the unit test passes

[Libreoffice-commits] .: Branch 'feature/matrix-new-backend' - sc/source

2012-07-17 Thread Kohei Yoshida
sc/source/core/tool/scmatrix.cxx |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit 66f28008a5b2b9b3f4ddade252ca3fa1cfcd61c1 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Tue Jul 17 16:26:14 2012 -0400 Turns out that C++03 doesn't support use

[Libreoffice-commits] .: Branch 'feature/matrix-new-backend' - sc/source

2012-07-17 Thread Kohei Yoshida
sc/source/core/tool/scmatrix.cxx | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) New commits: commit 536ba826092e5ae02670db0e69c4761e25f790f3 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Tue Jul 17 16:44:17 2012 -0400 Some cleanup and comments. Change

[Libreoffice-commits] .: Branch 'feature/matrix-new-backend' - sc/source

2012-07-18 Thread Kohei Yoshida
sc/source/core/tool/scmatrix.cxx | 37 ++--- 1 file changed, 30 insertions(+), 7 deletions(-) New commits: commit e504b7113eb0c56cfe58815143a7e46f01bbcf74 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Wed Jul 18 01:54:01 2012 -0400 Reorganized code

[Libreoffice-commits] .: Branch 'feature/matrix-new-backend' - sc/source

2012-07-18 Thread Kohei Yoshida
sc/source/core/tool/scmatrix.cxx | 68 --- 1 file changed, 1 insertion(+), 67 deletions(-) New commits: commit 527482e96181b7d60dea7ad4e3759c52b5a67f9a Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Wed Jul 18 02:15:05 2012 -0400 Use macro

[Libreoffice-commits] .: Branch 'feature/matrix-new-backend' - sc/source

2012-07-18 Thread Kohei Yoshida
sc/source/core/inc/interpre.hxx |2 sc/source/core/tool/interpr5.cxx | 103 +++ 2 files changed, 32 insertions(+), 73 deletions(-) New commits: commit f6e504023c6a98ac57d5ff19863bb66c99eddd43 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Wed Jul

[Libreoffice-commits] .: Branch 'feature/matrix-new-backend' - sc/source

2012-07-18 Thread Kohei Yoshida
sc/source/core/tool/scmatrix.cxx | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) New commits: commit 5c37e5193616aefb51b10f6e997b43571a0a6eac Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Wed Jul 18 10:43:32 2012 -0400 Slightly more efficient

Re: git branch audit ...

2012-07-18 Thread Kohei Yoshida
-- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'feature/calc-multiline-input' - 0 commits -

2012-07-18 Thread Kohei Yoshida
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [PATCH] [PUSHED] Moved ScDefaultsOptions from ScDocOptions to separate class

2012-04-13 Thread Kohei Yoshida
. -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Trying to solve a crasher in editeng unit test

2012-04-13 Thread Kohei Yoshida
On Fri, Apr 13, 2012 at 8:15 AM, Caolán McNamara caol...@redhat.com wrote: Yes.  Some of my changes were an attempt to address that ok, plan b, reorganize matters so that we bootstrap the initial uno component context once before all tests, and dispose it once after all tests are complete.

Re: [PATCH] fix proposed for fdo#48683

2012-04-14 Thread Kohei Yoshida
Hi Julien, On Sat, Apr 14, 2012 at 9:59 AM, julien2412 serval2...@yahoo.fr wrote: I can commit and push on master of course but I'd like first your opinion about this since I could missed something. Yup, your fix is right on. Please push to master. I did refactor this part, and now the text

Re: [PATCH] fix proposed for fdo#48683

2012-04-14 Thread Kohei Yoshida
Hi Julien, On Sat, Apr 14, 2012 at 11:08 AM, Kohei Yoshida kohei.yosh...@gmail.com wrote: I did refactor this part, and now the text portion container manages the life cycle of stored containers.  There is no need to delete stored elements outside of it.  So, you did the right thing here

Re: [PUSHED on master] Re: [PATCH] fix proposed for fdo#48683

2012-04-14 Thread Kohei Yoshida
On Sat, Apr 14, 2012 at 12:12 PM, julien2412 serval2...@yahoo.fr wrote: Hi Kohei, First thank you for your support. I commited and pushed the fix on master, see http://cgit.freedesktop.org/libreoffice/core/commit/?id=95cc5de63b20c5986fe8f3913da86002eabd7cb1 I removed the 3 delete + moved

[REVIEW 3-5] Fix regression in rendering Thai texts

2012-04-16 Thread Kohei Yoshida
Hi there, I'd like to have http://cgit.freedesktop.org/libreoffice/core/commit/?id=e57525b61af70a6ee33c26f979e724740cca8655 cherry-picked to the 3-5 branch to fix https://bugs.freedesktop.org/show_bug.cgi?id=48431 It's also important that Bug 32530

Re: [PATCH] Bug 48140 - [EasyHack] remove uno calls from xlsx import

2012-04-17 Thread Kohei Yoshida
. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc shared-formula-test.xlsx Description: application/vnd.openxmlformats-officedocument.spreadsheetml.sheet ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org

Re: [PATCH] Bug 48140 - [EasyHack] remove uno calls from xlsx import

2012-04-17 Thread Kohei Yoshida
Hi Daniel, On Tue, 2012-04-17 at 08:45 -0400, Kohei Yoshida wrote: I'll look through your changes to see what change might have caused the shared formula import issue. This change -Reference XNamedRange xNamedRange = createNamedRangeObject( aName, rTokens, 0 ); -OSL_ENSURE

Re: [PATCH] [PUSHED] Have operators of ScViewOptions and ScPrintOptions return bool instead of int

2012-04-17 Thread Kohei Yoshida
On Tue, 2012-04-17 at 20:21 +0200, Albert Thuswaldner wrote: Hi Kohei, I have various small fixes related to Calc options in store which accumulated while poking around in this part of the code. Here is the first one. Yup. Looks good. Pushed. Kohei -- Kohei Yoshida, LibreOffice hacker

Re: [REVIEW:3-5] [PUSHED 3-5] fdo#46983 Macros: Macro to set filter in Calc does not work with .StringValue

2012-04-17 Thread Kohei Yoshida
a test for this. We should definitely have this covered by our API test. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [REVIEW 3-5] [PUSHED 3-5] resolved rhbz#813280 - Sheets cannot be moved in calc

2012-04-17 Thread Kohei Yoshida
with my sign-off. It took me a while to understand and reproduce the problem, but I did reproduce it, and verified that this change indeed fixes the bug. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice

Re: [PATCH] Removed duplicate set/get methods for initial tab count (fails while linking vbaobj.uno.so)

2012-04-17 Thread Kohei Yoshida
this SC_DLLPUBLIC thing before, but never really understood the need for that. Now I do, thanks Markus! Please find the updated patch attached. I would be okay to just push this patch as-is, but let's wait for Noel's blessing just in case. ;-) Kohei -- Kohei Yoshida, LibreOffice hacker, Calc

Re: [Libreoffice-commits] .: writerfilter/source

2012-04-18 Thread Kohei Yoshida
it in a lot of places to make MSVC warning-free. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] remove unnecessary auto_ptr complexity in chart2uno.cxx in SC moduel

2012-04-18 Thread Kohei Yoshida
a quick manual check when modifying the chart code, just to be safe Regards, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] [PUSHED] Use global constants for initial tab count bounds checking

2012-04-18 Thread Kohei Yoshida
that suffix implies that the number represents 1 past the actual max value (and makes no sense for the min value). The rest is unchanged. Best, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice

Asynchronous use of SwHTMLParser - is this needed

2012-04-19 Thread Kohei Yoshida
Hi there, I'm working on removing SvRefBase from SvParser to make its life cycle a little more easier to understand. I've checked the call sites of all of its derived classes, and in most of those call sites, we could easily replace it with scoped_ptr. The only exception is the SwHTMLParser,

Re: Asynchronous use of SwHTMLParser - is this needed

2012-04-20 Thread Kohei Yoshida
On Fri, 2012-04-20 at 13:03 +0200, Eike Rathke wrote: Hi Kohei, On Thursday, 2012-04-19 17:06:43 -0400, Kohei Yoshida wrote: My question is, do we need to keep this asynchronicity of SwHTMLParser, or is it okay to change it into a synchronous call like the rest of SvParser uses

Re: Asynchronous use of SwHTMLParser - is this needed

2012-04-20 Thread Kohei Yoshida
that SvParser does during the anync call. http://opengrok.libreoffice.org/xref/core/svtools/source/svrtf/svparser.cxx#596 I haven't wrapped my head around the logic behind these ref-count changes here, so I'm not 100% sure... Kohei -- Kohei Yoshida, LibreOffice hacker, Calc

Re: [REVIEW 3-5-3] [PUSHED 3-5-3] fdo#48856 update sheet-local named expressions correctly

2012-04-20 Thread Kohei Yoshida
://bugs.freedesktop.org/show_bug.cgi?id=48856 patch looks sane and the test doc works for me +1 I'll sign off on this as well. Pushed to the 3-5-3 branch. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: unused code

2012-04-24 Thread Kohei Yoshida
Hi Caolan, On Tue, Apr 24, 2012 at 3:22 PM, Caolán McNamara caol...@redhat.com wrote: On Tue, 2012-04-24 at 19:03 +0100, José Santiago Jiménez Sarmiento What bothers me about the unused GetNextVisPortion in editeng is that GetPrevVisPortion is not unused, and in EditView::SetSelection I

[Libreoffice-commits] .: sc/inc sc/source

2012-04-26 Thread Kohei Yoshida
sc/inc/textuno.hxx |2 - sc/source/ui/unoobj/textuno.cxx | 66 ++-- 2 files changed, 31 insertions(+), 37 deletions(-) New commits: commit 69da3e140d58a524ab43c8fbbadbd8b8bf9de262 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Thu Apr

[Libreoffice-commits] .: sc/inc sc/source

2012-04-26 Thread Kohei Yoshida
sc/inc/fielduno.hxx |7 +-- sc/source/ui/unoobj/cellsuno.cxx |5 - sc/source/ui/unoobj/fielduno.cxx | 10 +- 3 files changed, 14 insertions(+), 8 deletions(-) New commits: commit 502e11b22eef0b2cfc544790e9430406dda8321e Author: Kohei Yoshida kohei.yosh

[Libreoffice-commits] .: 2 commits - sc/source

2012-04-26 Thread Kohei Yoshida
sc/source/filter/excel/xlroot.cxx |6 +++--- sc/source/ui/unoobj/textuno.cxx |3 --- 2 files changed, 3 insertions(+), 6 deletions(-) New commits: commit ed89b3799f2b0131f2150b7762044afd4ffd8fd2 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Thu Apr 26 21:09:52 2012 -0400

[Libreoffice-commits] .: sc/source

2012-04-26 Thread Kohei Yoshida
sc/source/core/tool/defaultsoptions.cxx |1 - sc/source/core/tool/formulaopt.cxx |1 - 2 files changed, 2 deletions(-) New commits: commit faea7e4962dcfe1b2a59407bc8ad03d6ded4c6d6 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Thu Apr 26 21:41:48 2012 -0400 No need

make ENABLE_SYMBOLS=true no longer enables symbols

2012-04-27 Thread Kohei Yoshida
As the subject says, running make ENABLE_SYMBOLS=true in a module build doesn't seem to turn on symbols for that module any more. Anyone has any clue what has changed? Thanks, Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[Libreoffice-commits] .: 7 commits - sc/CppunitTest_sc_editfieldobj_cell.mk sc/CppunitTest_sc_editfieldobj_header.mk sc/Module_sc.mk sc/qa sc/source test/inc test/source

2012-04-27 Thread Kohei Yoshida
(+), 7 deletions(-) New commits: commit df92f499f963a5a4d8cb7100ea1f846bb0f91014 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Sat Apr 28 00:23:51 2012 -0400 Fixed crash on tear down during cppunit test. Change-Id: I5573e554420967d8942295cabe788a9e56835ba0 diff --git a/sc/qa

[Libreoffice-commits] .: 2 commits - sc/qa test/inc test/Library_subsequenttest.mk test/Package_inc.mk test/source

2012-04-30 Thread Kohei Yoshida
| 211 + 6 files changed, 316 insertions(+), 4 deletions(-) New commits: commit 8ac758d5490c53df5e8ec539c37af062bedc72fa Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Mon Apr 30 16:17:05 2012 -0400 Test for XPropertySet. This is still work-in-progress

[Libreoffice-commits] .: 2 commits - sc/qa test/inc test/source

2012-04-30 Thread Kohei Yoshida
4712cd34531f1f257238b5ededaa5f130db2abec Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Mon Apr 30 16:31:23 2012 -0400 Test setPropertyValue(). Change-Id: Idbad933cf5e3b297e7131e66202a0250b4c3def8 diff --git a/sc/qa/extras/sceditfieldobj-cell.cxx b/sc/qa/extras/sceditfieldobj-cell.cxx index ab3217a

Re: Cell Value xlsx import test

2012-05-01 Thread Kohei Yoshida
-- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Cell Value xlsx import test

2012-05-01 Thread Kohei Yoshida
-- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] Changes to 'feature/gsoc-calc-perf'

2012-05-02 Thread Kohei Yoshida
New branch 'feature/gsoc-calc-perf' available with the following commits: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Cell Value xlsx import test

2012-05-02 Thread Kohei Yoshida
Hi Daniel, I just saw that Michael has created a new account for you. Now on to the next step... On Tue, May 1, 2012 at 9:08 PM, Kohei Yoshida kohei.yosh...@gmail.com wrote: Once you have an account set up, we'll pick a reasonably buildable master snapshot to branch off of.  Then we'll use

Re: Cell Value xlsx import test

2012-05-04 Thread Kohei Yoshida
On Fri, 2012-05-04 at 01:32 -0500, Daniel Bankston wrote: On 05/02/2012 10:35 AM, Kohei Yoshida wrote: I just created a new feature branch feature/gsoc-calc-perf. Please check out that branch and build it. I finished building that branch to make sure it's buildable, and hopefully

[Libreoffice-commits] .: test/source

2012-05-08 Thread Kohei Yoshida
test/source/beans/xpropertyset.cxx | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) New commits: commit dc0d9e802a5a243dda684cc670e4ef1de9853fc7 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Tue May 8 11:10:21 2012 -0400 Property writable test for util::DateTime

Re: advice needed: bug44456 addition of ODF-formula datedif to calc

2012-05-08 Thread Kohei Yoshida
On Tue, May 8, 2012 at 5:23 AM, Winfried Donkers w.donk...@dci-electronics.nl wrote: Once the xlformula.cxx/lotform.cxx question has been answered, I will submit the patch. What I would suggest is to add it to xlformula.cxx, but leave out lotform.cxx (for now). Kohei

[Libreoffice-commits] .: officecfg/registry sc/inc sc/sdi sc/source

2012-05-08 Thread Kohei Yoshida
|4 - sc/source/ui/view/editsh.cxx |8 +++ 9 files changed, 59 insertions(+), 3 deletions(-) New commits: commit cd708b56dc614a3e81921f1b28d3102264dfa53a Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Tue May 8 16:08:02 2012 -0400

Re: [PATCH] - WKS date format bug fix ...

2012-05-08 Thread Kohei Yoshida
On Tue, May 8, 2012 at 4:31 PM, Michael Meeks michael.me...@suse.com wrote: Nice fix:        https://bugs.freedesktop.org/show_bug.cgi?id=44738 malingering as:        https://bugs.freedesktop.org/attachment.cgi?id=56998 I think Eike would be the better person to review this (date parsing,

[Libreoffice-commits] .: sc/source

2012-05-08 Thread Kohei Yoshida
sc/source/core/tool/editutil.cxx | 43 --- 1 file changed, 23 insertions(+), 20 deletions(-) New commits: commit 7f3f6e4709c13b15fd122d9c2bd5e474c26ca4fb Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Tue May 8 17:05:37 2012 -0400 Use the field

[Libreoffice-commits] .: 3 commits - sc/source

2012-05-09 Thread Kohei Yoshida
sc/source/ui/unoobj/fielduno.cxx | 275 --- 1 file changed, 231 insertions(+), 44 deletions(-) New commits: commit 7c99fff933a112044589874d91e226df8e0332fd Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Wed May 9 15:24:16 2012 -0400 Access

Re: Proper process to follow when pushing to feature/gsoc-calc-perf

2012-05-09 Thread Kohei Yoshida
Hi Daniel, On Wed, May 9, 2012 at 7:36 PM, Daniel Bankston daniel.dev.libreoff...@gmail.com wrote: Hi, Kohei and Markus, I understand that when dealing with the master branch, a contributing developer is supposed to send a patch to the mailing list with the subject prefixed with [PATCH].  

Re: ODF proposal for number:fill-character element (was: support for repeating format code in calc)

2012-05-10 Thread Kohei Yoshida
On Wed, 2012-05-09 at 20:53 +0200, Eike Rathke wrote: Hi, On Tuesday, 2012-04-24 21:31:41 +0200, Eike Rathke wrote: Given that I think we'd need a number:fill-character or some such attribute to go with 16.27 Data Styles

[Libreoffice-commits] .: 5 commits - editeng/inc editeng/source filter/source offapi/com sc/source sd/source

2012-05-10 Thread Kohei Yoshida
+ sc/source/ui/unoobj/fielduno.cxx| 18 +- sd/source/ui/unoidl/unomodel.cxx|6 7 files changed, 147 insertions(+), 109 deletions(-) New commits: commit eeb9212531d91e8727bc8cabf4117b36638667f9 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Fri May 11 01:53:46

Re: How to add color scales to ODF?

2012-05-11 Thread Kohei Yoshida
On Fri, May 11, 2012 at 8:53 AM, Michael Stahl mst...@redhat.com wrote: i wonder if that restriction is really necessary. IMO it is. Imagine a case where the same color scale definition is applied to non-contiguous regions, and you having to decide whether to scale those regions as if they are

Re: How to add color scales to ODF?

2012-05-11 Thread Kohei Yoshida
On Fri, May 11, 2012 at 11:50 AM, Kohei Yoshida kohei.yosh...@gmail.com wrote: My gut feeling (totally unscientific and may be illogical) tells me that wedging this information into the style section may not be the cleanest approach.  I could, however, imagine we define these color scales

[Libreoffice-commits] .: editeng/source offapi/com sc/source sd/source svx/source

2012-05-11 Thread Kohei Yoshida
/unoidl/unomodel.cxx|2 +- svx/source/unodraw/unomod.cxx |2 +- 7 files changed, 4 insertions(+), 20 deletions(-) New commits: commit ee5fc5d25fe102c30daf7d181b8181d40b85a4f3 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Fri May 11 13:03:07 2012 -0400

Re: How to add color scales to ODF?

2012-05-11 Thread Kohei Yoshida
On Fri, 2012-05-11 at 19:48 +0200, Markus Mohrhard wrote: 2012/5/11 Kohei Yoshida kohei.yosh...@gmail.com: Come to think of it, how are we dealing with these unique values, non-unique values conditions in ODF, which has similar range requirement to color scales (and data bars

[GSoC] Initial numbers on xlsx load time

2012-05-11 Thread Kohei Yoshida
Hi there, I just did a quick comparison of the load time of one large-ish xlsx document that contains a bunch of number and string cells just to see how much difference Daniel's initial changes have made. Here is the result: on the latest master branch, the file loaded in 52 seconds, whereas the

[Libreoffice-commits] .: editeng/qa

2012-05-11 Thread Kohei Yoshida
editeng/qa/unit/core-test.cxx | 139 ++ 1 file changed, 139 insertions(+) New commits: commit 8ed129b22d1d9f832011df1a7e37402fb8abdbb2 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Fri May 11 23:11:10 2012 -0400 Unit test for UNO field item

[Libreoffice-commits] .: 2 commits - editeng/inc editeng/qa editeng/source offapi/com sc/source

2012-05-14 Thread Kohei Yoshida
cf8b304af3e88e9d8b42793f079124939a616d3b Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Mon May 14 12:08:06 2012 -0400 fdo#49854: Adjust array access for the addition of color scale attribute. Or else crash would ensue... Change-Id: I537523818eae3d558c300705baf7a5d9a8fa6dd9

Re: How to add color scales to ODF?

2012-05-15 Thread Kohei Yoshida
On Tue, May 15, 2012 at 10:28 AM, Eike Rathke er...@redhat.com wrote: So, what we could do is prepare two proposals, the clean incompatible one and the ugly more compatible one ;-)  It's then up to the TC to decide. I think this is a sensible approach. However, given how slow the TC can be,

Re: How to add color scales to ODF?

2012-05-15 Thread Kohei Yoshida
that are subject to standardization. Implementations come first, then things get standardized. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

[Libreoffice-commits] .: sc/inc sc/source

2012-05-17 Thread Kohei Yoshida
(-) New commits: commit 87ed6c8480eaf0e5e3e89f00399fa214ba0dec6c Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Thu May 17 17:20:04 2012 -0400 Better string values for empty and non-empty filtering option. Change-Id: Iecfac54143676c9f0b483c4fa8deb26bf42ea16b diff --git a/sc/inc

[Libreoffice-commits] .: sc/source

2012-05-17 Thread Kohei Yoshida
: Kohei Yoshida kohei.yosh...@gmail.com Date: Thu May 17 20:58:48 2012 -0400 Support separators in the autofilter/pivot table popup window. Change-Id: Ifde9cee65b2bee731e66a200b3bf68c0e320872f diff --git a/sc/source/ui/cctrl/checklistmenu.cxx b/sc/source/ui/cctrl/checklistmenu.cxx

[Libreoffice-commits] .: sc/source

2012-05-17 Thread Kohei Yoshida
sc/source/ui/inc/gridwin.hxx |2 - sc/source/ui/view/gridwin.cxx | 46 ++ 2 files changed, 47 insertions(+), 1 deletion(-) New commits: commit 2a755c0cd61b619ed14e023ad34fc7596eafdf34 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Thu May 17

[Libreoffice-commits] .: sc/source

2012-05-17 Thread Kohei Yoshida
sc/source/ui/cctrl/checklistmenu.cxx |7 +++ 1 file changed, 7 insertions(+) New commits: commit d3289425003bf1a8d074dc82d80f50dbdd084658 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Thu May 17 22:42:31 2012 -0400 Make the window taller as appropriate. Change-Id

[Libreoffice-commits] .: sc/source

2012-05-17 Thread Kohei Yoshida
sc/source/ui/cctrl/checklistmenu.cxx |4 1 file changed, 4 deletions(-) New commits: commit 0ea1287bd9b877524706ae57c2fc32ed54fb062b Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Thu May 17 22:45:40 2012 -0400 Actually it's okay to add separator items

Re: [REVIEW-3.5] crasher fdo#45987

2012-05-18 Thread Kohei Yoshida
On Fri, May 18, 2012 at 9:14 AM, Noel Power nopo...@suse.com wrote: http://cgit.freedesktop.org/libreoffice/core/commit/?id=8b1d29bc9b00bc2730738a990023a65ab6e0219b http://cgit.freedesktop.org/libreoffice/core/commit/?id=abb26f51eea0399754cc8f5b7d7a7d648d68f630 I took it that it should

[Libreoffice-commits] .: sc/inc sc/source

2012-05-18 Thread Kohei Yoshida
1735044e9f693cde1af0d905d264c849e3fce311 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Fri May 18 12:09:54 2012 -0400 Adjust sheet fields in cells when sheet structure changes. Change-Id: I0aff738968e286df57ef7dd5b67780108cdc6c89 diff --git a/sc/inc/cell.hxx b/sc/inc/cell.hxx index 3bf2dfe

<    1   2   3   4   5   6   7   8   9   10   >