calc/chart/complex-category-column-graph-repeating-values.xls |binary
calc/chart/complex-category-column-graph.xls |binary
2 files changed
New commits:
commit 236b97ccb463340017905dc0db5d5131529cc755
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Tue Sep 25 11:53:41
Hi Tor,
On Wed, Sep 26, 2012 at 4:00 AM, Tor Lillqvist t...@iki.fi wrote:
Again, I wonder how essential / useful this whole rebasing thing is
any more in this day... But yeah, I know that suggesting we stop doing
it will bring up arguments that essentially say if it might be useful
for even
Hi there,
This is just FYI that the Windows installer from the latest master (as
of yesterday) currently fails. Here is what I get:
http://people.freedesktop.org/~kohei/win7-master-installer-fail.png
I'm not very familiar with the Windows installer implementation, so
I'm hoping someone who is
On 09/26/2012 09:21 AM, Andras Timar wrote:
2012/9/26 Kohei Yoshida kohei.yosh...@gmail.com:
Hi there,
This is just FYI that the Windows installer from the latest master (as
of yesterday) currently fails. Here is what I get:
http://people.freedesktop.org/~kohei/win7-master-installer-fail.png
and cherry-pick to 3-6?
It fixes
https://bugs.freedesktop.org/show_bug.cgi?id=47275
Thanks,
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo
, this was meant to be send to me privately, but what the heck. ;-)
I've pushed all your patches to the gnumeric-import branch (on orcus).
Thanks a lot!
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
___
LibreOffice mailing list
LibreOffice
On 09/26/2012 11:16 AM, Kohei Yoshida wrote:
Hi,
I'd like to have
http://cgit.freedesktop.org/libreoffice/core/commit/?id=5f373a002df2f083109bb7b2e0987258b6e2f9c4
backported to 3-6, and I would be willing to sign off. The problem is
that this is a Mac specific code, and I can't verify
can use my sign-off for the 3rd patch if you need to.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
what's meant by the 'Proper' function, and
2. Assuming that this is an auto-correct issue, I can't reproduce this
(on Linux, using the development build).
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
___
LibreOffice mailing list
LibreOffice
.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On Thu, Oct 4, 2012 at 2:20 PM, Markus Mohrhard
markus.mohrh...@googlemail.com wrote:
2012/10/4 Markus Mohrhard markus.mohrh...@googlemail.com:
[1]
http://cgit.freedesktop.org/libreoffice/core/commit/?id=e1dee0aaacd8e30e2949053ebf351d76bad14ac3
Best is to add also
would prevent future regression for this
particular use case.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
)
and now needs just one more sign-off.
I pushed this via gerrit.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
)
Another sign-off from me, one more needed for 3-6-3
Pushed to 3-6-3.
--
Kohei Yoshida, LibreOffice hacker, Calc
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
also to the
tool-chain? (You can still keep the lcl_ prefix if you love it.)
For the record, I hate this convention and I purposefully don't follow
it myself.
It just looks ugly. That's all my reason against it.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
On Thu, 2011-03-24 at 01:05 +0100, Bob wrote:
Hello everybody,
It's my first post on this mailing list.
Until 3 years ago, I posted regulary on french ooo lists. I return on
the french dev list but it's a nomanland ;-) only 3 messages !
I think everybody is coming on LibreOffice :-)
I
Hi Markus,
It took me a little to get to your patch, but finally I've been able to
get around to reviewing it.
On Thu, 2011-03-24 at 17:43 +0100, Markus Mohrhard wrote:
so there is the next try. I've just followed Koheis' suggestions and
made the anonymous db a part of ScTable.
So, this
build script contains
--without-junit which solved the problem for me.
Worth a try.
HTH,
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org
and extra polish, and hopefully get this piece in
for 3.4.
Regards,
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
diff --git a/sc/inc/dbcolect.hxx b/sc/inc/dbcolect.hxx
index 859b858..1b40d9e 100644
--- a/sc/inc/dbcolect.hxx
+++ b/sc/inc/dbcolect.hxx
@@ -176,6 +176,13
Hi Octavio,
Re-sending to include the list this time
On Sat, Apr 2, 2011 at 1:39 PM, Octavio Alvarez
alvar...@alvarezp.ods.org wrote:
Hi!
I cleaned and then compiled LibO master yesterday and got a problem. I did
*not* do aptitude build-dep libreoffice because it wants to install a lot
On Fri, 2011-04-01 at 21:48 -0400, Kohei Yoshida wrote:
Does anyone have any clue as to what happened? Failing that, would
anyone be interested in taking a stab at this? If no one is willing, I
will have to take a look at this at some point, but I could certain use
some help here...
I
I have no idea
whether this is a preferred route for other developers.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo
On Mon, 2011-04-04 at 12:03 -0400, Kohei Yoshida wrote:
On Fri, 2011-04-01 at 21:48 -0400, Kohei Yoshida wrote:
Does anyone have any clue as to what happened? Failing that, would
anyone be interested in taking a stab at this? If no one is willing, I
will have to take a look
On Mon, 2011-04-04 at 14:32 -0400, Kohei Yoshida wrote:
Now I'm going to figure out how to fix this...
Fixed on libreoffice-3-4. It was trivial.
Should be merged to master whenever it gets merged the next time.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
On Tue, 2011-04-05 at 12:20 +0100, Michael Meeks wrote:
On Mon, 2011-04-04 at 14:53 -0400, Kohei Yoshida wrote:
On Mon, 2011-04-04 at 14:32 -0400, Kohei Yoshida wrote:
Now I'm going to figure out how to fix this...
Fixed on libreoffice-3-4. It was trivial.
Interesting
, but I think we
need to reach our final decision by sometime toward the end of next
week. So if I were you I'd hurry up and work on submitting an easy hack
ASAP.
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
to show me a dev log... unfortunately it's only a
nice to have list :(
Well, maybe you can start working on that plino, and we will all
appreciate your effort. :-)
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice
any
attachment in your post.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Anyone who has a special mouse with horizontal wheel willing to take on
this bug?
https://bugs.freedesktop.org/show_bug.cgi?id=36380
All my mouses only have vertical wheel, and it's impossible to even
verify this bug, let alone fix this behavior.
Thanks,
Kohei
--
Kohei Yoshida, LibreOffice
find one such page that reliably reproduce this
encoding problem?
Thanks a lot,
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman
On Tue, 2011-04-19 at 18:51 +0200, Andras Timar wrote:
Hi Kohei,
2011/4/19 Kohei Yoshida kyosh...@novell.com:
https://bugs.freedesktop.org/show_bug.cgi?id=33100
but soon realized that I don't have a reproducible case. Judging by the
bug description all I need to have is the right
, and
I'd like to keep clean separation between the core code and the API
layer (so that the core code won't depend on the API to do its thing too
much).
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
understand how it can work correctly.
I'm not sure of that. It's preferable than an expert have a look to my
patch before pushed it.
I think we should ping David about your patch. The bug is currently
assigned to him.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
earlier about Smart art
functionality. How the smart art data are stored in the file format is
well documented and is available publicly, but we still can't
inter-operate this feature because we lack this functionality in the
core.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh
On Thu, 2011-04-21 at 19:03 +0200, Jonathan Aquilina wrote:
Kohei
This I think is what keeps alot of people away from open source. That
has what has kept me off OOO and LO, This is something that should
really be worked on, and something that would really give a boost to LO
in the long
On Thu, 2011-04-21 at 19:10 +0200, Jonathan Aquilina wrote:
Kohei that wasnt my intention my apologies.
That's OK. Sorry if I over-reacted.
But I hope people who aren't versed in this sort of stuff understand
that improving interop with other office suites is not just a matter of
understanding
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
. The chances of pDocShell being NULL there are next to nothing,
so it's probably fine not checking its value. I wouldn't either.
Should I send a reworked patch?
Nah. Don't bother. ;-) It's not that big deal anyway.
Thanks.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
reasonable.
So go for it. :-) To be honest I don't think any one of us is
particularly versed in this part of the code base since it's relatively
new.
And yes, the design of this over-complicated error handling is pretty
amazing in a certain way, and I'll leave at that.
Kohei
--
Kohei Yoshida
On Sun, Apr 24, 2011 at 8:55 PM, Norbert Thiebaud nthieb...@gmail.com wrote:
PS: yeah, I know. I probably re-invented the wheel... kohei's python
program to generate the nice little dep picture probably could have
done the work.
Yes, mine already does that. It has a single module mode that
On Mon, 2011-04-25 at 21:22 +0200, Markus Mohrhard wrote:
Hello,
this patch makes the excel binary import work with the unnamed db
data.
Looks good. Pushed.
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice
On Mon, 2011-04-25 at 16:27 -0400, Kohei Yoshida wrote:
On Thu, 2011-04-21 at 22:34 +0200, Markus Mohrhard wrote:
Hello,
here a short patch that reworks the
ScVbaWorksheet::getAutoFilterMode/setAutoFilterMode methods.
Ok. I had to push this first since your later patch depends
On Mon, 2011-04-25 at 22:23 +0200, Markus Mohrhard wrote:
Hello,
this patch allows to export the sheet local anonymous db data to excel
binary.
Thanks! Pushed.
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice
this myself.
Pushed to master.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
, at least I have problems on Linux
and tinderboxes have problems, too.
And I have the same problem here too, both on master and libreoffice-3-4
branch.
I'm trying to fix it, otherwise I won't have a build to work on. :-(
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
On Mon, 2011-04-25 at 21:10 -0400, Kohei Yoshida wrote:
I'm trying to fix it, otherwise I won't have a build to work on. :-(
Ok. I at least got it fixed on master, with Norbert's help.
Got it cherry-picked to the 3.4 branch as well. I hope this will fix it
all.
Kohei
--
Kohei Yoshida
, which basically translates to a bunch of solar
mutex objects in the UNO API implementations...
So, when we are implementing ref-counted objects in such code, I'd like
not to have the overhead of thread safety.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
things.
But we do need to state somewhere in bold and italic that what posts are
appropriate and what aren't, for the developer list. Otherwise the
number of such posts will only increase.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
=710ca4f56942cf8ad5f4494b2cb30250bf91438a
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
I defined a global range name
(Insert - Names - Define) and saved as Excel 2007 xlsx format, Excel
2007 opened the file but said that the content of defined name was
unreadable must be repaired. Could you perhaps look into this?
The xls binary export worked fine.
Kohei
--
Kohei Yoshida
removed by accident. Thank you both for
spotting and helping to fix it.
Thanks for the quick fix!
BTW, Markus. Please consider applying for git access to our repository.
I think you deserve it.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
://cgit.freedesktop.org/libreoffice/calc/commit/?h=libreoffice-3-4id=5051d6a1f1e239fb38c60a227046111ec438a518
But at the moment this causes run-time exception. I haven't
investigated deeper into this to find out why.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
);
boolean hasByTable ( [in] long nTab )
raises( com::sun::star::lang::IndexOutOfBoundsException );
};
What do you think about this?
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
LibreOffice
On Wed, 2011-05-04 at 11:58 -0400, Kohei Yoshida wrote:
void setNewByTable( [in] long nTab, [in]
com::sun::star::table::CellRangeAddress aRange )
raises( com::sun::star::lang::IndexOutOfBoundsException );
Actually now I prefer setByTable without the 'New'. The method could
On Wed, 2011-05-04 at 18:23 +0200, Markus Mohrhard wrote:
I'm fine with nearly everything. And your suggestion looks even a bit
better than mine, except for the setByTable method.
I was thinking about adding the table index too, but stumbled over the
case when the table index does not match
On Wed, 2011-05-04 at 18:55 +0200, Markus Mohrhard wrote:
At the moment there is no case where this happens, but there may be
someone in the future who will think of this as a good idea to solve a
problem. It's the same reason made me write the lines that check for
the index of the table: as
etc. here eg. Jim Bob j...@bob.org ]
with your name (without the brackets []). Other than that, I have no
other comments.
Good work!
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
LibreOffice
All,
I just noticed that we now have NEEDINFO as one of the status values.
We were previously setting NEEDINFO in the whiteboard to indicate the
bug needs more info from the reporter, but maybe we can start using the
NEEDINFO status for that instead.
Just FYI,
Kohei
--
Kohei Yoshida
On Wed, 2011-05-04 at 21:09 -0400, Kohei Yoshida wrote:
All,
I just noticed that we now have NEEDINFO as one of the status values.
We were previously setting NEEDINFO in the whiteboard to indicate the
bug needs more info from the reporter, but maybe we can start using the
NEEDINFO status
look
for his blessing.
BTW, I love how you replaced some of those sal_Bool stuff to real
bool. ;-)
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http
think it's okay to push this one as I don't see
anything alarming. Bubli, Muthu, please stream if I'm wrong. :-)
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http
CHART_ADDRESS_CONV_WORKAROUND macro guard. But alas, now that macro
guard is taken away...
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo
.
It looks good to me. I also tested its run-time behavior, and it
doesn't seem to cause any loops (for me).
Thanks for looking into this BTW. Really appreciated. :-)
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice
, is being able to build without totally having en-US resources that
important?
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman
On Mon, 2011-05-09 at 14:46 +0530, Anurag Jain wrote:
Thank you for replying.
Yeah I've got the things working now. Thanks to shm_get in IRC , he
helped me out with it. :)
Great. Sorry I wasn't able to give you a help on this. And Thanks
Norbert and Michael for helping him out.
Kohei
point in there to see who instaniates it 3
times, and trace back from there.
Great to see you working on this, BTW.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http
Hi there,
I'd like to have the attached patch committed for 3.4. It fixes
https://bugs.freedesktop.org/show_bug.cgi?id=36933
Per rule, I need to have one sign-off in order to commit this to the 3.4
branch.
Review appreciated.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh
if someone (either Bjoern or
David) can give it a quick check I'd appreciate it.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo
On Tue, 2011-05-10 at 10:43 +0100, Michael Meeks wrote:
On Mon, 2011-05-09 at 23:09 -0400, Kohei Yoshida wrote:
I'd like to have the attached patch committed for 3.4. It fixes
Works fine for me on master; I've cherry picked it for you.
https://bugs.freedesktop.org/show_bug.cgi?id
quite easy to get out. Just do
cd sw
git checkout -f (or git reset --hard origin/master)
cd ..
and run ./g pull -r again. But make sure that you do that only in the
sw module.
HTH,
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
with that report.chart media type instead of the regular
opendocument.chart one?
Thanks a bunch,
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org
Please review the attached patch to suppress warning with MSVC
compiler. Thanks.
Kohei
0001-Let-s-not-change-the-signature-of-UNO-call-prefer-st.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
I'd like to commit the attached patch to the 3.4 branch. This was
discovered by the unit test which failed when an empty matrix element
didn't have a value of 0.0. As it turned out, I was initializing the
higher 4 bytes via 32-bit pointer but the lower 4 bytes were left
un-initialized, which
On Fri, 2011-05-13 at 03:53 +0530, Anurag Jain wrote:
Hello There,
I'm posting here the git diff of the work I've done till now.
@Kohei Since I do not want to disturb my master branch I'm here
pasting the diff only. Please create a feature branch and apply it, so
that I can clone that
On Thu, 2011-05-12 at 23:27 -0400, Kohei Yoshida wrote:
On Fri, 2011-05-13 at 03:53 +0530, Anurag Jain wrote:
Hello There,
I'm posting here the git diff of the work I've done till now.
@Kohei Since I do not want to disturb my master branch I'm here
pasting the diff only. Please create
than that commit (back
in the go-oo times which means you need to dig up the history of the
actual patch file itself in the 'build' repository).
Anyway, in the latest master I've already made changes to make the code
the way it should be.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh
be nRow instead of nC in the initialisation of
bRowRel:
No, that code is correct. In the Excel binary format, both column and
row flags are stored in the (unused) higher bits of the column index
bytes.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
lots of bugs reports regarding Excel import
filter bugs. So I assume that's correct.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org
Hi Christina,
On Sat, May 14, 2011 at 4:11 PM, Chr. Rossmanith chrrossman...@gmx.de wrote:
Hi,
it seems that the public methods (GetEingPos, GetEingabeCol, GetEingabeRow
and GetEingabeTab) of class ConverterBase are not used? Could someone please
double check, then I'll remove them.
Yup. I
the risk involved.
I'm working on cleaning up this area to make debugging less painful
FWIW.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http
be assured that code in
this area is a bit messy, so don't feel bad if you have hard time
understanding the logic of the current code.
Best,
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
LibreOffice
On Wed, 2011-05-11 at 11:15 -0400, Kohei Yoshida wrote:
Hi there,
While investigating this
https://bugs.freedesktop.org/show_bug.cgi?id=36339
Does anyone have any clue how a chart in a calc document could end up
with that report.chart media type instead of the regular
is
appreciated.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
diff --git a/filter/source/config/fragments/filters/chart8.xcu b/filter/source/config/fragments/filters/chart8.xcu
index c3700ac..e0f3036 100644
--- a/filter/source/config/fragments/filters/chart8.xcu
+++ b/filter/source
, but they are not the
regressions I was referring to in the release notes.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
involves timer handler, it was rather difficult to
write unit test for it. Hopefully my run-time test is sufficient to get
the patch included.
I appreciate your review and/or rubber-stamping. ;-)
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
From
On Tue, 2011-05-17 at 10:24 +0100, Michael Meeks wrote:
On Mon, 2011-05-16 at 22:14 -0400, Kohei Yoshida wrote:
1. Promote the chart8 filter as the preferred filter for the
chart2.Document type. This can be done by the attached
chart8-is-preferred-for-chart-document.diff patch
, and this
may mess that up, or perhaps it may not.
Well - it sounds like the ORB is pretty messy anyway :-) so ... can it
really make it much worse if it crashes the whole app left and right ?
Heh. I'm absolutely fine with that. ;-)
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh
On Fri, 2011-05-13 at 12:43 +0200, Jacek Wolszczak wrote:
Resubmitting the mail in case it got lost somewhere in the spam filter.
Just let you know that I've reviewed and checked in the first of your
patches. I haven't had a chance to review your 2nd and 3rd ones but I
plan to do that shortly
The attached patch fixes a crasher reported in
https://bugs.freedesktop.org/show_bug.cgi?id=37252
The original code always assumed that the find call on the map
container always finds a match (as it didn't check against the end
iterator after the call returns), but apparently in some cases no
Hi Norbert,
On Tue, May 17, 2011 at 10:52 PM, Norbert Thiebaud nthieb...@gmail.com wrote:
+1
Looks sane to me.
Thanks. Pushed to the -3-4 branch with your sign-off.
Kohei
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
On Tue, 2011-05-17 at 23:21 -0430, Rafael Dominguez wrote:
Fix accessing vector out of its boundaries preventing possible crash,
this is for 3.4 branch and master.
Looks good. Pushed to master, and to -3-4 branch with my sign-off.
Thanks a lot.
Kohei
--
Kohei Yoshida, LibreOffice hacker
On Tue, 2011-05-17 at 17:24 -0400, Kohei Yoshida wrote:
Just let you know that I've reviewed and checked in the first of your
patches. I haven't had a chance to review your 2nd and 3rd ones but I
plan to do that shortly (unless someone beats me to it).
The 2nd and 3rd patches are now
On Fri, 2011-05-13 at 12:43 +0200, Jacek Wolszczak wrote:
BTW, do you think I should create a bug in bugzilla for align ASSERT (
friends) macro foo easy hack?
Hmm... This I'm not sure. I don't have a strong opinion either way.
Bjoern?
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh
On Tue, 2011-05-17 at 23:57 -0400, Kohei Yoshida wrote:
Hi Norbert,
On Tue, May 17, 2011 at 10:52 PM, Norbert Thiebaud nthieb...@gmail.com
wrote:
+1
Looks sane to me.
Thanks. Pushed to the -3-4 branch with your sign-off.
Shoot. I didn't realize we already branched. Can I get two
On Wed, 2011-05-18 at 12:08 +0100, Noel Power wrote:
On 17/05/11 17:04, Kohei Yoshida wrote:
Hi there,
The attached patch fixes the crasher reported in the following bug:
https://bugs.freedesktop.org/show_bug.cgi?id=37226
and also several other usage of standard algorithms which I
On Wed, 2011-05-18 at 09:00 +0200, Katarina Machalkova wrote:
Shoot. I didn't realize we already branched. Can I get two more
sign-offs for the -3-4-0 branch too?
+1 from me
Thanks everyone. I just pushed this to the -3-4-0 branch as well.
Kohei
--
Kohei Yoshida, LibreOffice hacker
already when I signed off and pushed Rafael's patch (since it was
already committed locally and pushing Rafael's also pushed mine with
it). ;-)
So, let me just use that as my excuse for picking my version this time
around. ;-)
Thanks a lot,
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh
to me. You have my
sign-off.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On Wed, 2011-05-18 at 11:18 -0400, Kohei Yoshida wrote:
Hi Michael,
On Wed, 2011-05-18 at 06:23 +0100, Michael Meeks wrote:
Fixes a potential crash on shutdown with gtk+ - prolly been there for
years, would love to have the attached cherry-picked to the
libreoffice-3-4 branch
On Tue, 2011-05-17 at 12:04 -0400, Kohei Yoshida wrote:
The attached patch fixes the crasher reported in the following bug:
https://bugs.freedesktop.org/show_bug.cgi?id=37226
And if possible. I'd like to have two more sign-off's so that we can
put this in for 3.4. It's a crasher bug, so
701 - 800 of 5163 matches
Mail list logo
