[PATCH] sal_Bool - bool in comphelper

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/762 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/62/762/1 sal_Bool - bool in comphelper Change-Id: Id9f4aef6c7453cebd83dcaedf2ad7427e03cc960 --- M

[PATCH] sal_Bool - bool in comphelper

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/763 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/63/763/1 sal_Bool - bool in comphelper Change-Id: Ib7f2a10a4ff0227a5d5c137602c3c2f353334d24 --- M

[PATCH] String-OUString in SVL::SvNumberFormat calendar methods

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/772 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/72/772/1 String-OUString in SVL::SvNumberFormat calendar methods Change-Id: I6fe904d25a0675d881ee7c1d761e9af87e23a69d ---

[PATCH] String-OUString in svl::SvNumberFormat::GetMappedFormatstri...

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/770 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/770/1 String-OUString in svl::SvNumberFormat::GetMappedFormatstring method Change-Id:

[PATCH] String-OUString in svl::ImpSvNumFor::GetNewCurrencySymbol m...

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/771 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/71/771/1 String-OUString in svl::ImpSvNumFor::GetNewCurrencySymbol method Change-Id:

[PATCH] String-OUString in tools::ErrorContext

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/769 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/769/1 String-OUString in tools::ErrorContext Change-Id: Ibd0cd3e8d7281b5abde420df5cc1d51e9354069c --- M

[PATCH] fdo#46808, convert sdb::QueryDesigner to new style

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3031 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/31/3031/1 fdo#46808, convert sdb::QueryDesigner to new style Change-Id: I694dd16920304d0f07369e97c87a4a97b92eadeb --- M

[PATCH] fix for fdo#61801

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2553 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/53/2553/1 fix for fdo#61801 ... crash on Tools - Options - LibreOffice - Personalization - Select Background Image The

[PATCH] fix 'DEBUGCPPUNIT=TRUE make subsequenttest'

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1532 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/32/1532/1 fix 'DEBUGCPPUNIT=TRUE make subsequenttest' When running a unit test under GDB, we do not want to prefix the

[PATCH] Create OUString::valueInt, valueBool and valueChar function ...

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1625 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/25/1625/1 Create OUString::valueInt, valueBool and valueChar function templates. Cleans up the call sites by hiding the

[PATCH] Java cleanup in mediawiki extension

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3430 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/30/3430/1 Java cleanup in mediawiki extension - remove unnecessary casts - convert Hashtable-Map and Vector-ArrayList -

[PATCH] Java cleanup, remove unnecessary casts

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3431 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/31/3431/1 Java cleanup, remove unnecessary casts Change-Id: Id12089bc7df16631737e6acaee0973fb91dd953f --- M

[PATCH] Java cleanup, remove the rest of the unnecessary casts

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3432 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/32/3432/1 Java cleanup, remove the rest of the unnecessary casts Change-Id: Ia61d250f6b3711abc29569c5ece38a6f87e38daa ---

[PATCH] Java cleanup, use generics in calls to UnoRuntime#queryInter...

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3433 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/33/3433/1 Java cleanup, use generics in calls to UnoRuntime#queryInterface A handful of places wrap the call to

[PATCH] Java cleanup - static fields that should not be static

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3555 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/55/3555/1 Java cleanup - static fields that should not be static Somebody appears to have been confused about the purpose

[PATCH] Fix compilation of Spreadsheet odk example

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3565 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/65/3565/1 Fix compilation of Spreadsheet odk example because of change to XDataPilotsResults IDL in commit

[PATCH] Java cleanup - reduce use of global fields

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3567 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/3567/1 Java cleanup - reduce use of global fields This field does not need to be global, it is returned from the

[PATCH] Java cleanup - use generics to reduce casting

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3568 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/3568/1 Java cleanup - use generics to reduce casting More queryInterface related cleanup. Change-Id:

[PATCH] Java cleanup, use generic containers where possible

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3569 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/3569/1 Java cleanup, use generic containers where possible Change-Id: Icd830004de3e121f5b96393e7d7b447775833419 --- M

[PATCH] Create conversion constructor for Reference

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3613 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/13/3613/1 Create conversion constructor for Reference makes UNO code less noisy. Change-Id:

[PATCH] Clang cleanup, unaligned if statement

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3677 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/77/3677/1 Clang cleanup, unaligned if statement The extra semi-colons were confusing clang. Just remove the macro, it's

[PATCH] Clang cleanup, unused mutex variables

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3678 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/78/3678/1 Clang cleanup, unused mutex variables Some of these were doing nothing useful at all. I removed those. A couple

[PATCH] fdo#46808, Convert some XMultiServiceFactory to XComponentCo...

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3681 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/81/3681/1 fdo#46808, Convert some XMultiServiceFactory to XComponentContext The new constructor is not happy with forward

[ABANDONED] fdo#46808, Convert some XMultiServiceFactory to XComponentCo...

Noel Grandin has abandoned this change. Change subject: fdo#46808, Convert some XMultiServiceFactory to XComponentContext .. Patch Set 1: Abandoned This got somehow mixed up with another change. -- To view, visit

[PATCH] Convert usage of SfxPtrArray to std::vector

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3356 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/56/3356/1 Convert usage of SfxPtrArray to std::vector Change-Id: I38664f59e4cfa7354196437901175c9ef9aa9006 --- M

[PATCH] Convert SfxPtrArray to std::vector in SfxTabDialogItem

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3358 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/58/3358/1 Convert SfxPtrArray to std::vector in SfxTabDialogItem Also simplify the use-site, we don't need to new it.

[PATCH] Convert SfxObjectUIArr_Impl from SfxPtrArr to std::vector

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3359 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/59/3359/1 Convert SfxObjectUIArr_Impl from SfxPtrArr to std::vector Also - remove dead class definition SfxIFConfig_Impl,

[PATCH] Convert SfxViewFactoryArr_Impl from SfxPtrArray to std::vect...

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3360 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/60/3360/1 Convert SfxViewFactoryArr_Impl from SfxPtrArray to std::vector Change-Id:

[PATCH] remove dead code

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3361 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/61/3361/1 remove dead code Change-Id: I18b203f9647e2fd5199a2d15f4be67c99f7def5d --- D sfx2/source/inc/mnucfga.hxx M

[PATCH] Convert SfxChildList_Impl from SfxPtrArr to std::vector

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3388 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/3388/1 Convert SfxChildList_Impl from SfxPtrArr to std::vector and simplify use site Change-Id:

[PATCH] Convert SfxChildWindows_Impl from SfxPtrArr to std::vector

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3390 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/90/3390/1 Convert SfxChildWindows_Impl from SfxPtrArr to std::vector - also remove dead struct SfxSplitWin_Impl

[PATCH] remove dead class SfxResourceManager

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3393 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/93/3393/1 remove dead class SfxResourceManager Change-Id: I33590e7907c593d821e2eafda0e04c76c8b99879 --- D

[PATCH] Convert SfxShellStack_Impl from SfxPtrArr to std::vector

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3394 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/94/3394/1 Convert SfxShellStack_Impl from SfxPtrArr to std::vector Change-Id: I1ffd615a505029242a87337c9ef42c8156c42d70

[PATCH] remove dead code minstack.hxx

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3397 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/97/3397/1 remove dead code minstack.hxx Change-Id: I67a7a4c51188187c1ab234f8e9d2634eb018badf --- M sfx2/Package_inc.mk D

[PATCH] Convert SmFontPickList from SfxPtrArr to std::vector

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3398 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/98/3398/1 Convert SmFontPickList from SfxPtrArr to std::vector - removing SmPickList in the process, since it's only used

[PATCH] remove dead class SfxPtrAr and it's header sfx/inc/sfx2/mina...

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3399 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/99/3399/1 remove dead class SfxPtrAr and it's header sfx/inc/sfx2/minarray.hxx Change-Id:

[PATCH] Convert SwDrawTextInfo.pText from XubString to OUString

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3417 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/17/3417/1 Convert SwDrawTextInfo.pText from XubString to OUString Change-Id: Ie567feb315a018a1f5bd794a4d12435865e67ec4

[PATCH] Remove code associated with psprint::CompatMetricOverride se...

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3824 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/24/3824/1 Remove code associated with psprint::CompatMetricOverride service We don't actually have any implementations of

[PATCH] move DBG_UNHANDLED_EXCEPTION out of line

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3988 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/3988/1 move DBG_UNHANDLED_EXCEPTION out of line makes it easier to set a breakpoint on it. Plus it's getting a little

[PATCH] Use the new type-checking Reference constructor to reduce co...

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4001 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/01/4001/1 Use the new type-checking Reference constructor to reduce code noise Also create a Clang compiler plugin to

[PUSHED] Use the new type-checking Reference constructor to reduce co...

Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4001 Approvals: Noel Grandin: Verified; Looks good to me, approved LibreOffice gerrit bot: Verified -- To view, visit

[PATCH] fix awt::UnoControlModelDialog crash

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4013 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/13/4013/1 fix awt::UnoControlModelDialog crash ...in commit 6c61b20a8d4a6dcac28801cde82a211fb7e30654, Convert

[PATCH] fix for unused return value.

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4140 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/4140/1 fix for unused return value. This code was introduced by: commit d09dd8986436f17717443823ef18bd8552fdf408