On 03/19/2011 12:00 PM, Aurimas Fišeras wrote:
Patch is contributed under the LGPLv3+ / MPL.
Thanks, but this was already fixed by David.
Thomas
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
On 03/19/2011 10:59 AM, Aurimas Fišeras wrote:
Patch is contributed under the LGPLv3+ / MPL.
One got already fixed by David. I adopted the other one as David did
with OSL_FAIL. I set you as author, because you pointed it out. Thanks!
Now it's really pushed. Only had problems to apply on cursor.cxx due to
m101 merge. Should be fixed. Thanks!
Thomas
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Hi Christina,
On 03/20/2011 12:47 PM, Christina Roßmanith wrote:
the definition of _OLD_FILE_IMPL is commented out in
basic/source/inc/runtime.hxx. So I could remove the parts which are
#ifdef'ed with _OLD_FILE_IMPL and remove the #ifndef _OLD_FILE_IMPL
statements? Or could _OLD_FILE_IMPL get
Hi,
only short note from me: You won't find all wrong chmod'ed files with
the help of extensions. For example in bootstrap, there are the file
post_download or download. These need to be executable.
You could check for these files if you do head -n1 FILE and look if
this first line has a
Hi Folks,
as Markus stated in dc05a825e71316e6f602e5c8dfcd3d10ecb6252f those
string cleanups aren't save. I've had the illusion, that by compiling
and quick checking all of it got tested (mostly by compiling). Because
there were complains, if I removed too much. I didn't touch things like
Hi Eike,
On 07/19/2012 09:29 PM, Eike Rathke wrote:
Some values are used as results of calculations, for example for the
specific case of the Navigator (SCSTR_CONTENT_GRAPHIC, ...) the
resources are obtained in a loop based on SCSTR_CONTENT_ROOT, see
sc/source/ui/navipi/content.cxx
/DocumentRenderer.hrc |1
store/workben/t_store.cxx |1
vcl/inc/win/saldata.hxx |5 +
7 files changed, 90 insertions(+)
New commits:
commit e9b19eebb9041f817dedd558117bce7bf6fbb70e
Author: Thomas Arnhold tho
xmloff/inc/xmloff/txtprmap.hxx |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit db4f5372cb2d83ba9263071978ef837de847a689
Author: Thomas Arnhold tho...@arnhold.org
Date: Sat Jul 28 19:56:19 2012 +0200
Partially revert hrc cleanup: Remove unused resource
(-)
New commits:
commit e2b7dc3fcd8cc926d54ddcca0d268fbd3b123a7f
Author: Thomas Arnhold tho...@arnhold.org
Date: Sun Jul 29 14:41:00 2012 +0200
Partially revert Remove unused defines
This partially reverts 278000a28b8eceb8528ebdcf1d601de8192979e8
http://lists.freedesktop.org
/inc/toolkit/helper/property.hxx | 14 +-
6 files changed, 36 insertions(+), 16 deletions(-)
New commits:
commit 10ada83716e7c7d591d2c7d5c19cc5920db38faf
Author: Thomas Arnhold tho...@arnhold.org
Date: Sun Jul 29 19:22:59 2012 +0200
Partially revert Remove unused defines
basctl/source/basicide/baside2.cxx |1
basctl/source/basicide/baside2b.cxx |1
basctl/source/basicide/basides2.cxx |1
basctl/source/basicide/brkdlg.cxx|1
/svt_ehdl.cxx|3 ---
binfilter/bf_svtools/source/numbers/svt_zforlist.cxx |3 ---
6 files changed, 20 deletions(-)
New commits:
commit b4f09b1d25687bc648231f9fd52528d7fd6a053c
Author: Thomas Arnhold tho...@arnhold.org
Date: Mon Jul 30 05:11:21 2012 +0200
fdo#48549 Remove Sound
Hi all,
so I reverted some stuff. The rest looks still sane to me (despite the
fact that it's a huge removal ;).
So string problems should not occur due to these changes, because all
removals where a resource id was set in the hrc and the string in the
src file - and at a first look were
framework/inc/classes/filtercachedata.hxx | 62 --
1 file changed, 62 deletions(-)
New commits:
commit 98e697dcb02b2864a7d701656ba160a7070d5501
Author: Thomas Arnhold tho...@arnhold.org
Date: Mon Jul 30 18:24:06 2012 +0200
cleanup filtercachedata.hxx
| 57 ---
binfilter/inc/bf_svx/txencbox.hxx | 28 ---
10 files changed, 244 deletions(-)
New commits:
commit 6d93be1f8e80df2b2fc30b0b3397405480fca7bc
Author: Thomas Arnhold tho...@arnhold.org
Date: Tue Jul 31 00:16:51 2012 +0200
Remove unused
791071825969a40a454ed2b9806ec8b5c3b08fe9
Author: Thomas Arnhold tho...@arnhold.org
Date: Wed Aug 1 18:34:24 2012 +0200
Remove unused code: those classes are unused
Change-Id: Ibf41655d40c9534629bbb0dd5ae600791b42922d
diff --git a/autodoc/inc/ary/idl/i_namelookup.hxx
b/autodoc/inc/ary
c04c2114d91596464807d026c9fee6953817
Author: Thomas Arnhold tho...@arnhold.org
Date: Sun Aug 5 20:31:29 2012 +0200
Remove unused macros
Change-Id: I184a7f9c65dd762407b2431d9c6557e718b954b2
diff --git a/UnoControls/source/base/registercontrols.cxx
b/UnoControls/source/base
binfilter/inc/bf_basic/sbxcore.hxx | 15
binfilter/inc/bf_sfx2/docfac.hxx | 128 -
2 files changed, 143 deletions(-)
New commits:
commit e238a59430ce1f2e45469faf14d9c0a4d151b60e
Author: Thomas Arnhold tho...@arnhold.org
Date: Sun Aug 5 20:31:14
|4
binfilter/inc/bf_sw/unotxdoc.hxx |4
39 files changed, 7 insertions(+), 710 deletions(-)
New commits:
commit 2e6a7e83cf7e5e05968b12d8c74ae238cc9e50ba
Author: Thomas Arnhold tho...@arnhold.org
Date: Tue Aug 7 15:45:05 2012 +0200
remove
salhelper/source/timer.cxx |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit 389c315032e5eb18016e9a81207747fe0cdb5217
Author: Thomas Arnhold tho...@arnhold.org
Date: Wed Aug 8 14:17:47 2012 +0200
fix build
Change-Id
d1d1079c087329d647dee89627e8d830e2b496f0
Author: Thomas Arnhold tho...@arnhold.org
Date: Fri Aug 10 04:10:03 2012 +0200
callcatcher: strip string methods down
Change-Id: Ibbe214d69068cbfaf8ae667ba96fa677e7a9242a
diff --git a/binfilter/bf_svtools/source/misc/tl_strascii.cxx
b/binfilter/bf_svtools/source/misc
582e06f71c63d70189e1ecd4fe365c541648cf83
Author: Thomas Arnhold tho...@arnhold.org
Date: Mon Aug 13 16:55:38 2012 +0200
unusedcode.easy: remove unused code
Change-Id: I87e7264ffd3086796aaa8e136c2f9b77fde7b74f
diff --git a/sot/source/sdstor/storage.cxx b/sot/source/sdstor/storage.cxx
index eb3880d..56a3679
Hi,
I checked these changes against en_US and de_DE as I commited the changes.
Here's the second change which has to do with Petr's mentioned one:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=2233aa52da14ec85331aee1163b885fe9a9fb507
I tested 3.5.4rc4 on Windows with de_DE (libo and
cba811c7b8b50e04236ee9022d0ca94c0b8cd7ad Mon Sep 17 00:00:00 2001
From: Thomas Arnhold tho...@arnhold.org
Date: Mon, 4 Jun 2012 18:21:58 +0200
Subject: [PATCH] fdo#50415 and fdo#34638 Fix Shortcut names are not localized
on Linux
This partially reverts commit 2233aa52da14ec85331aee1163b885fe9a9fb507
Before the keyboard
Hi,
this patch removes some dead code. Please could someone review it,
especially the part at sc/source/ui/view/tabvwsha.cxx, to be sure it's save.
Thanks!
Thomas
From 7f40dccf502691b02fecbc7614c1d505924e889c Mon Sep 17 00:00:00 2001
From: Thomas Arnhold tho...@arnhold.org
Date: Thu, 7 Jun
Hi Daniel,
many thanks! This was some kind to fast forward ;) Didn't see the
rInfoItem.GetNumberFormatter()-DeleteEntry() call.
Thanks! Pushed.
Thomas
On 06/07/2012 06:25 PM, Daniel Bankston wrote:
On 06/07/2012 10:34 AM, Thomas Arnhold wrote:
Hi,
this patch removes some dead code
, 34 deletions(-)
New commits:
commit 96caa3b7aea151744c5fa9ba4a4a940817e12531
Author: Thomas Arnhold tho...@arnhold.org
Date: Thu Jun 7 18:26:35 2012 +0200
dead code: unused Biff virtuals
Change-Id: I67ac9c0f3c7d6cd4c6c17e774fc11655341a3d4f
diff --git a/sc/source/filter/inc
Arg sorry for this...
On Thu, 07 Jun 2012 18:35:05 -0500, Daniel Bankston wrote:
On 06/07/2012 05:05 PM, David Ostrovsky wrote:
Hi,
this patch solves WaE unused pDoc parameter in
ScTabViewShell::UpdateNumberFormatter.
I have no idea, why I'm getting it now, git blame says that the
last
|2
--
binfilter/bf_xmloff/source/style/xmloff_PageHeaderFooterContext.cxx|1 -
101 files changed, 110 deletions(-)
New commits:
commit 0cff3b6c626493ce1d52a39e838e5033d15d6f64
Author: Thomas Arnhold tho...@arnhold.org
Date: Sat Jun 9 04:39:21 2012 +0200
Remove
/svx_dialdll.cxx |2 --
binfilter/bf_svx/source/xoutdev/svx_xattr2.cxx |2 --
15 files changed, 31 deletions(-)
New commits:
commit 67c0af8c290f84582cfba9a79b022c34d2173dd6
Author: Thomas Arnhold tho...@arnhold.org
Date: Sat Jun 9 04:51:47 2012 +0200
Remove superfluous
commits:
commit a241e2c5c49068fba7be1a16c2705adbbc0b0cfc
Author: Thomas Arnhold tho...@arnhold.org
Date: Sat Jun 9 04:58:38 2012 +0200
Remove superfluous empty lines on top
More than two lines are removed for readability.
Change-Id: I0f38f7dcb198f64c1c3c5bbdcb5fa05f026ed771
(-)
New commits:
commit a4bcfd41e332202297dc0b45f5f3b0fba8e91e2e
Author: Thomas Arnhold tho...@arnhold.org
Date: Sat Jun 9 05:54:56 2012 +0200
Remove superfluous include comments
Change-Id: If8c37d94bbb76e3e5a8060f378a768e4866da604
diff --git a/binfilter/bf_svtools/source/items1
/source/string/strascii.cxx |3 ---
13 files changed, 63 deletions(-)
New commits:
commit 24aa9c16b8e37d63d120901ed04846190490abba
Author: Thomas Arnhold tho...@arnhold.org
Date: Sat Jun 9 05:54:42 2012 +0200
Remove superfluous include comments
Change-Id
Hi,
these two methods don't do anything. So remove them and the calls
(core+binfilter).
Thomas
From 3987772ea80d3113ef3b623f8c7b4432d3bb50ac Mon Sep 17 00:00:00 2001
From: Thomas Arnhold tho...@arnhold.org
Date: Sat, 9 Jun 2012 06:32:31 +0200
Subject: [PATCH] Remove non-functional Hide
Mon Sep 17 00:00:00 2001
From: Thomas Arnhold tho...@arnhold.org
Date: Sat, 9 Jun 2012 06:43:18 +0200
Subject: [PATCH] Remove unused InterceptChildWindowKeyDown
- InterceptChildWindowKeyDown never gets called
- so mbInterceptChildWindowKeyDown doesn't get changed
- at ImplInterceptChildWindowKeyDown
sdext/source/presenter/PresenterAccessibility.cxx |2 +-
vcl/generic/glyphs/gcach_layout.cxx |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit cfe98a1305202419f224a31e54cd37e64401fa4f
Author: Thomas Arnhold tho...@arnhold.org
Date: Sat Jun 9 12
vcl/unx/generic/app/saldisp.cxx |2 --
1 file changed, 2 deletions(-)
New commits:
commit 2432083b50ea7481247c303187bb3922714f93d5
Author: Thomas Arnhold tho...@arnhold.org
Date: Sun Jun 10 17:36:05 2012 +0200
Remove bogus header
Thanks to Rene Engelhard for pointing this out
Please could someone sign this for inclusion in libreoffice-3-5 and 3-6?
http://cgit.freedesktop.org/libreoffice/core/commit/?id=2432083b50ea7481247c303187bb3922714f93d5
Thanks!
On 06/10/2012 04:04 PM, Rene Engelhard wrote:
On Sun, Jun 10, 2012 at 03:37:19PM +0200, Thomas Arnhold wrote
|2 +-
7 files changed, 1 insertion(+), 41 deletions(-)
New commits:
commit da38cd454a7d32b92dbdd1dd0abdce27c4ee2327
Author: Thomas Arnhold tho...@arnhold.org
Date: Mon Jun 11 22:05:04 2012 +0200
Remove unused InterceptChildWindowKeyDown: further cleanup
Change-Id
. They are represented in
many po files. Is there an easier way to remove them or only per regex/sed?
Thomas
On 06/11/2012 05:26 PM, Caolán McNamara wrote:
On Sat, 2012-06-09 at 06:36 +0200, Thomas Arnhold wrote:
Hi,
these two methods don't do anything. So remove them and the calls
(core
vcl/inc/win/saldata.hxx |5 -
1 file changed, 5 deletions(-)
New commits:
commit 06d358fea294617d8618e9cf6fadb1f162fd6014
Author: Thomas Arnhold tho...@arnhold.org
Date: Mon Jun 11 22:16:59 2012 +0200
Remove unused InterceptChildWindowKeyDown: further cleanup
Change-Id
sw/source/ui/docvw/docvw.hrc |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 22a5dfb94918cbade4800122c75d88ae73e39240
Author: Thomas Arnhold tho...@arnhold.org
Date: Mon Jun 11 22:54:26 2012 +0200
build fix: restore STR_CHAIN_OK
Change-Id
Hi Michael,
Hi Caolán,
yes, I will do this :) Starting next week.
Thomas
On 06/12/2012 10:56 AM, Michael Meeks wrote:
On Mon, 2012-06-11 at 23:10 +0100, Caolán McNamara wrote:
- STR_DOC_LOADING and STR_CHAIN_OK were unused. They are represented in
many po files. Is there an easier way to
: Thomas Arnhold tho...@arnhold.org
Date: Fri Jun 15 15:39:37 2012 +0200
Remove obsolete stuff
* inetdef is unused
* PCH is dead
Change-Id: Ied87246c69cb64800b25b34edc760659285728aa
diff --git a/binfilter/bf_offmgr/source/offapp/app/makefile.mk
b/binfilter/bf_offmgr/source
: Thomas Arnhold tho...@arnhold.org
Date: Fri Jun 22 10:52:19 2012 +0200
Remove empty or non-called methods
empty:
ClearTip
implOnShapeInserted
ImpCopyMarkedPoints
ImpMakeDragAttr
ImpCopyMarkedPoints
ImpMakeDragAttr
ImpDelDragAttr
ImpMakeCreateAttr
(-)
New commits:
commit c09b4f2ec35b80e40cb87b76eda82460e80c10b4
Author: Thomas Arnhold tho...@arnhold.org
Date: Thu Jun 21 19:39:37 2012 +0200
Remove empty Reader::SetNoOutlineNum
Change-Id: Id752931575694f3ce83948326720a25af4fdfb5f
diff --git a/binfilter/bf_sw/source/filter/basflt
tools/inc/tools/rtti.hxx | 27 ---
1 file changed, 27 deletions(-)
New commits:
commit 9a906437fc4f1c20a1420009cfa5d9fceacc51a4
Author: Thomas Arnhold tho...@arnhold.org
Date: Sun Jun 24 18:13:56 2012 +0200
Remove some unused macros
Change-Id
toolkit/src2xml/src.lst |1 -
1 file changed, 1 deletion(-)
New commits:
commit 6a07013f155ff2e24e13a2188951070b5af4befa
Author: Thomas Arnhold tho...@arnhold.org
Date: Wed Jun 27 13:38:24 2012 +0200
Remove non-existing schedule.src
Change-Id
insertion(+), 125 deletions(-)
New commits:
commit e4812b0d9ce2527bd3fe314010e540f6411539b3
Author: Thomas Arnhold tho...@arnhold.org
Date: Thu Jun 28 12:36:35 2012 +0200
Remove PCH traces
Change-Id: I2c39feaaab0b41af107a22baeaab48713539
diff --git a/binfilter/bf_sch/source/ui
binfilter/bf_sch/source/ui/docshell/makefile.mk |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
New commits:
commit 791329fd1d2e14c4fb9a3120b0d9947899bb3f98
Author: Thomas Arnhold tho...@arnhold.org
Date: Fri Jun 29 11:39:10 2012 +0200
Fix build
Didn't see
, 180 deletions(-)
New commits:
commit 1136fa4fc40cba46272e06b529064a02a140803f
Author: Thomas Arnhold tho...@arnhold.org
Date: Mon Jul 2 06:28:57 2012 +0200
Remove unused defines
Change-Id: Ibc46eb4565d4df88e83882045b2ed6d31e487d16
diff --git a/chart2/source/controller/dialogs
svx/inc/svx/gallery.hxx | 134
sw/inc/cmdid.h |3 -
2 files changed, 137 deletions(-)
New commits:
commit 2d3a9c51055a285a2ac8d45e3ef31d248362589b
Author: Thomas Arnhold tho...@arnhold.org
Date: Mon Jul 2 21:02:19 2012 +0200
64517292c92cb1a28880a31e335726744ec7c82d
Author: Thomas Arnhold tho...@arnhold.org
Date: Mon Jul 2 21:30:12 2012 +0200
hrc cleanup: Remove include guards
Also add some missing include guards.
Change-Id: I320a3c017ca65d34f2cd516849bcde3dec9b33f1
diff --git a/basctl/inc/basidesh.hrc b
| 106
15 files changed, 666 deletions(-)
New commits:
commit d8c91a5276bca967ab7ea81b0bddd2503a32e50b
Author: Thomas Arnhold tho...@arnhold.org
Date: Tue Jul 3 11:48:49 2012 +0200
hrc cleanup: Remove unused hrc files
Change-Id
Hi,
I recently removed the unused throbber.src.
See:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=0d53a8336bd6b55fb89873ce7e2cd623468f282e
For me it doesn't make a difference between images*.zip. If I unzip it
and search for spinner-* it's always the same result:
Hello Stefan, Michael,
yes a throbber is used in the extension manager.
See:
http://opengrok.libreoffice.org/xref/core/extensions/source/update/check/updatehdl.cxx#1328
http://opengrok.libreoffice.org/xref/core/toolkit/source/controls/spinningprogress.cxx#77
I've attached a list of all spinner
To be sure I reverted the change.
On Tue, 03 Jul 2012 19:26:35 +0200, Stefan Knorr wrote:
Hello Thomas, Michael,
AFAIK, LibO uses a throbber in its extension manager, e.g. when
looking
for extension updates. I believe the application update checker also
uses a throbber.
I can't really say if
vcl/source/src/throbber.src | 106
1 file changed, 106 insertions(+)
New commits:
commit e1c6c2fb32e59441441843247402ac744683e3d4
Author: Thomas Arnhold tho...@arnhold.org
Date: Thu Jul 5 17:55:55 2012 +0200
Revert Remove unused throbber.src
-
sc/source/ui/docshell/docsh8.cxx |2
sc/source/ui/docshell/impex.cxx| 18 ---
14 files changed, 2 insertions(+), 401 deletions(-)
New commits:
commit b8d065e94aba1dd94ae1bbe33e8ac32c74944e70
Author: Thomas Arnhold tho...@arnhold.org
Date: Sat Jul 7 02:44:15 2012 +0200
Remove
files changed, 283 deletions(-)
New commits:
commit fc01739951de6bab7f40361dbe4f49bdb59caede
Author: Thomas Arnhold tho...@arnhold.org
Date: Sat Jul 7 02:59:09 2012 +0200
hrc cleanup: Remove commented out lines in hidother.src files
Change-Id
| 66 --
sc/source/ui/navipi/navipi.src | 25 ---
sc/source/ui/src/scstring.src| 254 ---
9 files changed, 532 deletions(-)
New commits:
commit 527e8f61868210c54bdad650f16390bda03c4353
Author: Thomas Arnhold tho...@arnhold.org
binfilter/bf_starmath/source/starmath_mathml.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit 933e6e9aa02ccc5428bb23e9e9ad0a2662e22c29
Author: Thomas Arnhold tho...@arnhold.org
Date: Thu Jul 12 14:39:52 2012 +0200
Fix build
Change-Id
|6 --
sw/inc/helpid.h |9 -
uui/source/ids.hrc |2 --
14 files changed, 141 deletions(-)
New commits:
commit abdaf7e5f8d3600b1e0e251bb9b78670f0af0aed
Author: Thomas Arnhold tho...@arnhold.org
Date: Sat Jul 14 20:01:43 2012 +0200
Hi Stephan,
thanks for fixing this! Yes, I didn't see the rFont arg... All of this
changeset was some kind of dumb. Sorry for this.
Thomas
On 03/13/2012 11:19 AM, Stephan Bergmann wrote:
commit 40c0ff75d2a0f987454b068a663908e6d9b87b9b
Author: Stephan Bergmann sberg...@redhat.com
Date: Tue
Hi Bjoern,
to answer Norbert's question about signalKeysChanged - this was removed
with: 9a7605b8f08dfcfbc99bc0c635014eac8e41e932
Thomas
On 04/26/2012 12:46 AM, Bjoern Michaelsen wrote:
Hi there,
I just adjusted 04b9c2f633f0be1b676933943bdd0b1dc58b5471 from master for
cherry-pick on -3-5
Hi,
all my contributions, past and future, to LibreOffice are licensed
under the terms of the MPL / LGPLv3+.
Thomas
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
From 91563824581c9125edc8d1b478d57804d2d4e405 Mon Sep 17 00:00:00 2001
From: Thomas Arnhold tho...@arnhold.org
Date: Mon, 20 Aug 2012 07:26:17 +0200
Subject: [PATCH] remove two unused methods
Change-Id: Ib71b21246af0815d349ba1e5fca3613b86b9c12d
---
binfilter/bf_sfx2/source/appl/sfx2_app.cxx
Hi,
I like your patches for the new smooth shadow.
I looked around the other LibO apps like Impress or Draw. They have this
shadow already, but it's not as width as in Writer and it's on all
sides. Maybe we should do it in Writer as in Draw and Impress. Looks
better I think. Here is what I mean:
Hi,
I've seen the latest About LibreOffice window from master, which is
pretty awesome. There is a link Contributer credits to the online
version of the credits. At Help-LibreOffice Credits there is a link to
the offline CREDITS.odt which is out of sync with the online version.
Question is:
Hi,
it would be nice if this commit could be cherry-picked on
libreoffice-3-4-1, because without it a debug build will fail at cui:
http://cgit.freedesktop.org/libreoffice/components/commit/?id=3764b31aae43883c6b13b91c6ad8d0daa59f4ba5
Thomas
___
Thanks!
On 07/06/2011 12:04 PM, Thorsten Behrens wrote:
Thomas Arnhold wrote:
it would be nice if this commit could be cherry-picked on
libreoffice-3-4-1, because without it a debug build will fail at
cui
Cherry-picked to libreoffice-3-4. Don't think 3-4-1 makes too much
sense
On 07/04/2011 09:14 PM, Thorsten Behrens wrote:
Question is: Is Help-Libreoffice Credits menu entry necessary at
all if there's a link to it within the about window? I don't think
so. If we remove it, we could remove CREDITS.odt as well. Or at
least we need to sync them.
Hm, given the wide
Hi,
I've found out, that there's a whole directory doubled in the tree:
libs-gui/sax/test/sax and extensions/test/sax
I think the first one is the desired and the second could be removed. Or
is it intened, that libs-gui/sax/test/sax is an internal sax test and
extensions/test/sax is the one
Hi Caolán,
I've got it compiled and pushed this to master. As next step I'll check
if it does something useful.
Thomas
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
handling as resizing is
correctly working out of the box with newer Sawfish versions (checked it
with 1.8.1).
Thomas
From 716757b7789877575784b68c32c52603ea4baa23 Mon Sep 17 00:00:00 2001
From: Thomas Arnhold tho...@arnhold.org
Date: Wed, 20 Jul 2011 23:52:21 +0200
Subject: [PATCH] Kill dtwm/cde
I'm not really sure. I could bring those enum values back. This enum is
only used once at:
http://opengrok.libreoffice.org/xref/libs-gui/vcl/unx/generic/app/saldisp.cxx#871
Strangely SAL_WM is empty on my PC (gnome).
So maybe I let the enums untouched and only remove the uses of dtwm,
olwm,
Here is the output of PrintInfo():
Environment
$XENVIRONMENT
$DISPLAY:0.0
$SAL_VISUAL
$SAL_FONTPATH
$SAL_NOSEGV
$SAL_IGNOREXERRORS
$SAL_PROPERTIES
Hi Jan, Hi Jacek,
script approach sounds good. I've used them for conversion from DBG_ to
OSL_ already. Should be absolutely no problem to dump DBG_{C,D}TOR with it.
If it's ok I'm doing this. Should be done in some 10 minutes + building.
Just give me the cue to ;)
Thomas
On 07/21/2011
So I let the enums untouched. It's all pushed to master.
There is a strange vendor list at saldisp.cxx. I think some stuff is
very outdated, but I have no possibility to check it on Sun etc.
http://opengrok.libreoffice.org/xref/libs-gui/vcl/unx/generic/app/saldisp.cxx#362
This vendor stuff
On 07/21/2011 09:49 PM, Francois Tigeot wrote:
Why does LO tinker with window managers in the first place ?
Maybe from times where you had to do so (various X servers and
implementations) and the idea of StarOffice as all-in-one desktop tool ;)
Thomas
Hi,
I've added a new profile for nss/moz to get it build with a linux kernel
3.0:
http://cgit.freedesktop.org/libreoffice/libs-extern-sys/commit/?id=64609b5e174e44bfc49c29cb871d057af740edeb
Please cherry-pick this on the libreoffice-3-4 branch.
Thomas
On 07/26/2011 11:40 AM, Michael Meeks wrote:
Hi Thomas,
On Mon, 2011-07-25 at 19:42 +0200, Thomas Arnhold wrote:
An additional comment: Problem without this fix is, that you won't be
able to compile Libreoffice (3.4) on a plattform with newest kernel. I
think this means it's a blocker
On 07/27/2011 02:35 PM, Robert Nagy wrote:
I would like to ask my fellow developers to be more careful
about merging and _touching_ files at all that they don't
understand. During the last two days I had to fix several
problems that were introduced by merging changes, hell I
even found files
So I removed this Property checks for various vendors with commit
http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?id=6b344d2654eb6a87f6e759376e7ee988f1a52761
If someone needs this back, feel free to do so (only jobset.{h,c}xx was
a mis-merge, sorry for that).
Thomas
On 07/29/2011 11:01 AM, Miklos Vajna wrote:
On Wed, Jul 27, 2011 at 03:53:18PM +0200, Thomas Arnholdtho...@arnhold.org
wrote:
I think this was not intended. Simple solution would be to add some
' HEAD' .* '===' .* ' master' stuff to git hooks. So
git would block commits with conflicts.
On 07/29/2011 01:37 PM, Miklos Vajna wrote:
On Fri, Jul 29, 2011 at 11:46:21AM +0200, Thomas Arnholdtho...@arnhold.org
wrote:
Yeah, I've already found that file. Strangely we already have such a
check:
http://cgit.freedesktop.org/libreoffice/bootstrap/tree/git-hooks/pre-commit#n61
Oh, now I
On 07/29/2011 12:05 PM, Caolán McNamara wrote:
If a destructor is listed in unused.easy as unused then its probably
after detecting a leak if at least one of the constructors is used, i.e.
construction without destruction somewhere.
Thanks! You mean HttpRequest::~HttpRequest, right? I'm still
On 07/29/2011 02:23 PM, Caolán McNamara wrote:
On Fri, 2011-07-29 at 13:52 +0200, Thomas Arnhold wrote:
On 07/29/2011 12:05 PM, Caolán McNamara wrote:
If a destructor is listed in unused.easy as unused then its probably
after detecting a leak if at least one of the constructors is used, i.e
Hi Marty,
On 08/02/2011 12:02 AM, Marty Jack wrote:
If there is a way to do site-local patches in your workflow between
the unpacking and the building steps, I haven't found it documented.
I beg you to think this over and decide to do something about it.
I've already fixed this in master and
tools-options-security-macro security-low : open
libo/smoketestdoc/PLATFORM/bin/smoketestdoc.sxw and click the run
button.
The error in smoketest is (write test results):
assertion caught: Error: sentence indices out of range From File
On 08/03/2011 05:51 PM, Caolán McNamara wrote:
What are your configure options for me to see if I can replicate this ?
Looks like evilness which should be fixed.
./autogen.sh --enable-python=internal \
--enable-debug --enable-dbgutil \
--without-junit --without-java \
--with-num-cpus=2
On 08/04/2011 01:56 PM, Caolán McNamara wrote:
For this one at least, the assert itself was bogus for the empty
paragraph case, fixed with
http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=ba6440349db1bd688c08369dd2b30f5dd012d339
Nice! Works fine!
Thomas
Hi,
I've recently seen some changes, which removed unnecessary NULL checks
for delete commands with the form:
-if (pTextPContext)
-delete pTextPContext;
+delete pTextPContext;
Codebase is full with these. I've attached a little perl script which
should solve this conversion.
Thanks for fixing it :)
On 02/22/2012 02:43 PM, Lubos Lunak wrote:
On Tuesday 21 of February 2012, Stephan Bergmann wrote:
On 02/21/2012 08:57 PM, Thomas Arnhold wrote:
commit 45ad6029e1422c659e627bb30ecda50ccb61060c
...
@@ -174,12 +174,7 @@ static sal_Bool lcl_IsLess( const ScDPDataMember
On 19.03.2013 00:02, Norbert Thiebaud wrote:
On Mon, Mar 18, 2013 at 11:17 AM, Lubos Lunak l.lu...@suse.cz wrote:
On Monday 18 of March 2013, Tor Lillqvist wrote:
Sounds great to me too; though of course I'd prefer to keep the diff
smaller and not replace all the header guards:
#ifndef
, explicit OUString is necessary only with return and ? such as
return OUString(bla bla bla);
and
aOUString = bCond ? OUString(String_true) : OUString(String_false);
Olivier
Em 19-03-2013 05:26, Thomas Arnhold (via Code Review) escreveu:
Hi,
I have submitted a patch for review:
https
/qa/cppunittests/odiapi/testProperty.cxx |2 -
writerfilter/source/dmapper/DomainMapper_Impl.cxx |2 -
46 files changed, 94 insertions(+), 101 deletions(-)
New commits:
commit 5bb4a2ba1d8a6b98720868786e552aa8fd2a22eb
Author: Thomas Arnhold tho
Hi,
if someone has problems while rebasing due to this huge change, please
use the attached script to do my change on your branch.
Thomas
On 19.03.2013 10:00, Thomas Arnhold (via Code Review) wrote:
Hi,
Thank you for your patch! It has been merged to LibreOffice.
If you are interested
cppuhelper/inc/cppuhelper/propertysetmixin.hxx |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
New commits:
commit 5e2fd3b3c96362368a516f59555a42450126be85
Author: Thomas Arnhold tho...@arnhold.org
Date: Wed Mar 20 03:29:03 2013 +0100
this should be enough
Change-Id
101 - 200 of 1027 matches
Mail list logo
