[PUSHED] enable binary package option for a set of 'stable' libraries

2013-08-17 Thread David Ostrovsky (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4765 Approvals: LibreOffice gerrit bot: Verified David Ostrovsky: Verified; Looks good to me, approved -- To view, visit

[PATCH] enable binary package option for a set of 'stable' libraries

2013-08-16 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot, Thorsten Behrens, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/4765 to look at the new patch set (#2). Change subject: enable binary package option for a set of 'stable' libraries

[PUSHED] add french QA list to CC, also fix Reply-To address

2013-06-24 Thread David Ostrovsky (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4471 Approvals: David Ostrovsky: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4471 To unsubscribe,

[PUSHED] migrate check_index test from Java to Python

2013-06-17 Thread David Ostrovsky (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4310 Approvals: David Ostrovsky: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4310 To unsubscribe,

[PATCH] Delete unused sal tests

2013-06-17 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4326 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/26/4326/1 Delete unused sal tests Change-Id: Iba1eeb8d8fd0582f216b7552dc9ae21b69e66b4e --- D

[PATCH] Migrate CheckFields unit test to python

2013-06-15 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4294 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/94/4294/1 Migrate CheckFields unit test to python Change-Id: Ia765b37888b4095a735015e792f06fc89201d1a3 --- M

[ABANDONED] fix python unit test invocation for MSVC

2013-05-23 Thread David Ostrovsky (via Code Review)
David Ostrovsky has abandoned this change. Change subject: fix python unit test invocation for MSVC .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/3728 To unsubscribe, visit

[ABANDONED] selectively disable applications from the suite

2013-05-22 Thread David Ostrovsky (via Code Review)
David Ostrovsky has abandoned this change. Change subject: selectively disable applications from the suite .. Patch Set 4: Abandoned there are problems with tests with this approach -- To view, visit

[PATCH] fix python unit test invocation for MSVC

2013-05-01 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3728 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/28/3728/1 fix python unit test invocation for MSVC Change-Id: Ib6836e7609e0c268f91b04a8ca8618a15dfdae82 --- M

[PATCH] fix WaE with system libhunspell

2013-04-26 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3618 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/18/3618/1 fix WaE with system libhunspell Change-Id: I6d943136ef189a57bc5fa95530c76b0226ba874d --- M

[RESTORED] selectively disable applications from the suite

2013-04-22 Thread David Ostrovsky (via Code Review)
David Ostrovsky has restored this change. Change subject: selectively disable applications from the suite .. Patch Set 1: Restored -- To view, visit https://gerrit.libreoffice.org/2778 To unsubscribe, visit

[PATCH] clean up PythonTests

2013-04-19 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3478 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/78/3478/1 clean up PythonTests Change-Id: I8dc937df02efb686bf19d6606b9b42b6f0abf742 --- M sw/Module_sw.mk R

[PUSHED libreoffice-4-0] curl: link against the internal NSS if SYSTEM_NSS=NO

2013-04-18 Thread David Ostrovsky (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3463 Approvals: David Ostrovsky: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3463 To unsubscribe,

[PUSHED] pyuno_loader::CreateInstance: delete the initial PyThreadSta...

2013-04-18 Thread David Ostrovsky (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3452 Approvals: David Ostrovsky: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3452 To unsubscribe,

[PUSHED] python3: disable check in PyThreadState_Swap

2013-04-18 Thread David Ostrovsky (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3453 Approvals: David Ostrovsky: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3453 To unsubscribe,

[PUSHED] set up python unit test infrastructure

2013-04-08 Thread David Ostrovsky (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3214 Approvals: David Ostrovsky: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3214 To unsubscribe,

[PUSHED] move Python tests in-process

2013-04-08 Thread David Ostrovsky (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3215 Approvals: David Ostrovsky: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3215 To unsubscribe,

[ABANDONED] selectively disable applications from the suite

2013-04-05 Thread David Ostrovsky (via Code Review)
David Ostrovsky has abandoned this change. Change subject: selectively disable applications from the suite .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/2778 To unsubscribe, visit

[ABANDONED] set up python unit test infrastructure

2013-04-05 Thread David Ostrovsky (via Code Review)
David Ostrovsky has abandoned this change. Change subject: set up python unit test infrastructure .. Patch Set 2: Abandoned -- To view, visit https://gerrit.libreoffice.org/3128 To unsubscribe, visit

[PATCH] set up python unit test infrastructure

2013-03-30 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3128 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/28/3128/1 set up python unit test infrastructure Extract boostraping code from convwatch.py to unotest.py. Use python

[PUSHED libreoffice-4-0] fdo#55814 SwDoc::UpdateExpFlds: hiding the last section may ...

2013-03-20 Thread David Ostrovsky (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2876 Approvals: David Ostrovsky: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2876 To unsubscribe,

[PATCH] remove unused code svtools/bmpmaker

2013-03-20 Thread David Ostrovsky (via Code Review)
David Ostrovsky has created a new patch set by issuing a rebase in Gerrit (#4). Change subject: remove unused code svtools/bmpmaker .. remove unused code svtools/bmpmaker Investigated the usage of bmpmaker for fdo#39445,

[PATCH] add suport for new JVM versions

2013-03-20 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2884 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/84/2884/1 add suport for new JVM versions Change-Id: I751e67aefabbb895490cdb8ea4cb522f19d23715 --- M

[PATCH] make gcc-wrapper work even with ccache

2013-03-19 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2857 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/57/2857/1 make gcc-wrapper work even with ccache Change-Id: If97cc4f2af2adb6af1217cf7b095d0f0f7831bca --- M

[PUSHED] make gcc-wrapper work even with ccache

2013-03-19 Thread David Ostrovsky (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2857 Approvals: LibreOffice gerrit bot: Verified David Ostrovsky: Verified; Looks good to me, approved -- To view, visit

[ABANDONED] install a toolchain for man page, html pdf files

2013-03-13 Thread David Ostrovsky (via Code Review)
David Ostrovsky has abandoned this change. Change subject: install a toolchain for man page, html pdf files .. Patch Set 3: Abandoned Apparently not interesting -- To view, visit https://gerrit.libreoffice.org/2068 To

[ABANDONED prod] add -2/+2 to categorie 'VRIF' for buildbot verification

2013-03-13 Thread David Ostrovsky (via Code Review)
David Ostrovsky has abandoned this change. Change subject: add -2/+2 to categorie 'VRIF' for buildbot verification .. Patch Set 2: Abandoned Abandon after 1 month inactivity -- To view, visit

[ABANDONED prod] sql script to customize the Review -1 and -2 messages

2013-03-13 Thread David Ostrovsky (via Code Review)
David Ostrovsky has abandoned this change. Change subject: sql script to customize the Review -1 and -2 messages .. Patch Set 1: Abandoned Already applied in prod -- To view, visit https://gerrit.libreoffice.org/2158 To

[ABANDONED] Try to fix fdo#55814 by reverting bb6bd1ff9

2013-03-13 Thread David Ostrovsky (via Code Review)
David Ostrovsky has abandoned this change. Change subject: Try to fix fdo#55814 by reverting bb6bd1ff9 .. Patch Set 2: Abandoned didn't work that way -- To view, visit https://gerrit.libreoffice.org/2613 To unsubscribe,

[PUSHED] use system python for building if possible

2013-03-12 Thread David Ostrovsky (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2563 Approvals: David Ostrovsky: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2563 To unsubscribe,

[PUSHED] solenv: remove versionlist.hrc

2013-03-12 Thread David Ostrovsky (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2677 Approvals: Michael Stahl: Looks good to me, approved David Ostrovsky: Verified; Looks good to me, approved -- To view, visit

[PUSHED] fdo#61726: rename report-builder package to org.libreoffice....

2013-03-11 Thread David Ostrovsky (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2578 Approvals: David Ostrovsky: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2578 To unsubscribe,

[PATCH] fdo#61726: rename report-builder package to org.libreoffice....

2013-03-10 Thread David Ostrovsky (via Code Review)
Hello Stephan Bergmann, LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2578 to look at the new patch set (#5). Change subject: fdo#61726: rename report-builder package to org.libreoffice.report

[PATCH] fdo#61726: rename report-builder package to org.libreoffice....

2013-03-10 Thread David Ostrovsky (via Code Review)
Hello Stephan Bergmann, LibreOffice gerrit bot, I'd like you to reexamine a rebased change. Please visit https://gerrit.libreoffice.org/2578 to look at the new rebased patch set (#6). Change subject: fdo#61726: rename report-builder package to org.libreoffice.report

[PATCH] fdo#61726: rename report-builder package to org.libreoffice....

2013-03-10 Thread David Ostrovsky (via Code Review)
Hello Stephan Bergmann, LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2578 to look at the new patch set (#7). Change subject: fdo#61726: rename report-builder package to org.libreoffice.report

[PATCH] always use system python for building

2013-03-09 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2563 to look at the new patch set (#2). Change subject: always use system python for building .. always use

[PATCH] always use system python for building

2013-03-09 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a rebased change. Please visit https://gerrit.libreoffice.org/2563 to look at the new rebased patch set (#3). Change subject: always use system python for building

[PATCH] always use system python for building

2013-03-09 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2563 to look at the new patch set (#4). Change subject: always use system python for building .. always use

[PATCH] Fixes fdo#55814 by reverting bb6bd1ff9

2013-03-09 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2613 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/13/2613/1 Fixes fdo#55814 by reverting bb6bd1ff9 This commit revert bb6bd1ff9cd3eecec7eb2cd7bd0a4dcef584c903. After

[PATCH] fdo#61726: rename report-builder package org.libreoffice.ext...

2013-03-07 Thread David Ostrovsky (via Code Review)
Hello Stephan Bergmann, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2578 to look at the new patch set (#2). Change subject: fdo#61726: rename report-builder package org.libreoffice.ext.report

[PATCH] fdo#61726: rename report-builder package to org.libreoffice....

2013-03-07 Thread David Ostrovsky (via Code Review)
Hello Stephan Bergmann, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2578 to look at the new patch set (#3). Change subject: fdo#61726: rename report-builder package to org.libreoffice.ext.report

[PATCH] fdo#61726: rename report-builder package to org.libreoffice....

2013-03-07 Thread David Ostrovsky (via Code Review)
Hello Stephan Bergmann, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2578 to look at the new patch set (#4). Change subject: fdo#61726: rename report-builder package to org.libreoffice.ext.report

[PATCH] fdo#61726: rename report-builder package org.libreoffice.ext...

2013-03-06 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2578 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/78/2578/1 fdo#61726: rename report-builder package org.libreoffice.ext.report To prevent future collisions with uno's own

[PATCH] remove minor.mk

2013-03-02 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot, Michael Stahl, I'd like you to reexamine a rebased change. Please visit https://gerrit.libreoffice.org/2491 to look at the new rebased patch set (#2). Change subject: remove minor.mk ..

[PATCH] fix build with --disable-scripting option

2013-03-02 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2510 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/10/2510/1 fix build with --disable-scripting option Change-Id: I98dbd3e46c81e1dd056d6e88dc1e526b5af456f5 --- M

[PATCH] Add new dialog to Query Design View

2013-03-02 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a rebased change. Please visit https://gerrit.libreoffice.org/2508 to look at the new rebased patch set (#2). Change subject: Add new dialog to Query Design View ..

[PUSHED] remove minor.mk

2013-03-02 Thread David Ostrovsky (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2491 Approvals: LibreOffice gerrit bot: Verified David Ostrovsky: Verified; Looks good to me, approved -- To view, visit

[PUSHED] Correct spelling errors in comments.

2013-03-02 Thread David Ostrovsky (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2509 Approvals: David Ostrovsky: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2509 To unsubscribe,

[PUSHED] [PUSHED] convert moz to gbuild and add to tail_build

2013-02-24 Thread David Ostrovsky (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2349 Approvals: David Ostrovsky: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2349 To unsubscribe,

[PATCH] instsetoo_native: convert to gbuild

2013-02-24 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot, Matúš Kukan, I'd like you to reexamine a rebased change. Please visit https://gerrit.libreoffice.org/2242 to look at the new rebased patch set (#13). Change subject: instsetoo_native: convert to gbuild

[PUSHED] [PUSHED] instsetoo_native: convert to gbuild

2013-02-24 Thread David Ostrovsky (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2242 Approvals: LibreOffice gerrit bot: Verified David Ostrovsky: Verified; Looks good to me, approved -- To view, visit

[PUSHED] [PUSHED] add solenv to tail_build

2013-02-24 Thread David Ostrovsky (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2373 Approvals: LibreOffice gerrit bot: Verified David Ostrovsky: Verified; Looks good to me, approved -- To view, visit

[PATCH] instsetoo_native: convert to gbuild

2013-02-23 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot, Matúš Kukan, I'd like you to reexamine a rebased change. Please visit https://gerrit.libreoffice.org/2242 to look at the new rebased patch set (#11). Change subject: instsetoo_native: convert to gbuild

[PATCH] convert moz to gbuild and add to tail_build

2013-02-23 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a rebased change. Please visit https://gerrit.libreoffice.org/2349 to look at the new rebased patch set (#6). Change subject: convert moz to gbuild and add to tail_build

[PATCH] convert moz to gbuild and add to tail_build

2013-02-23 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2349 to look at the new patch set (#7). Change subject: convert moz to gbuild and add to tail_build .. convert

[PATCH] convert moz to gbuild and add to tail_build

2013-02-23 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2349 to look at the new patch set (#8). Change subject: convert moz to gbuild and add to tail_build .. convert

[PATCH] instsetoo_native: convert to gbuild

2013-02-21 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot, Matúš Kukan, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2242 to look at the new patch set (#2). Change subject: instsetoo_native: convert to gbuild ..

[PATCH] instsetoo_native: convert to gbuild

2013-02-21 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot, Matúš Kukan, I'd like you to reexamine a rebased change. Please visit https://gerrit.libreoffice.org/2242 to look at the new rebased patch set (#3). Change subject: instsetoo_native: convert to gbuild

[PATCH] convert odk to gbuild and add to tail_build

2013-02-21 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2288 to look at the new patch set (#8). Change subject: convert odk to gbuild and add to tail_build .. convert

[PATCH] instsetoo_native: convert to gbuild

2013-02-21 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot, Matúš Kukan, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2242 to look at the new patch set (#4). Change subject: instsetoo_native: convert to gbuild ..

[PATCH] instsetoo_native: convert to gbuild

2013-02-21 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot, Matúš Kukan, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2242 to look at the new patch set (#5). Change subject: instsetoo_native: convert to gbuild ..

[PATCH] convert odk to gbuild and add to tail_build

2013-02-20 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2288 to look at the new patch set (#2). Change subject: convert odk to gbuild and add to tail_build .. convert

[PATCH] convert odk to gbuild and add to tail_build

2013-02-20 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2288 to look at the new patch set (#3). Change subject: convert odk to gbuild and add to tail_build .. convert

[PUSHED] [PUSHED] convert sysui to gbuild and add to tail_build

2013-02-17 Thread David Ostrovsky (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2192 Approvals: LibreOffice gerrit bot: Verified David Ostrovsky: Verified; Looks good to me, approved -- To view, visit

[PUSHED] proposal: move towards killing UNOLIBS_OOO and merge libs to...

2013-02-16 Thread David Ostrovsky (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2169 Approvals: David Ostrovsky: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2169 To unsubscribe,

[PATCH] fix cross compiling with icu 50.1.2

2013-02-12 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2112 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/12/2112/1 fix cross compiling with icu 50.1.2 Change-Id: Ib112a2d3f9a75890591137a78b46be982b7d43df --- M configure.ac 1

[PUSHED] xmlsecurity: remove obsolete tools directory

2013-02-11 Thread David Ostrovsky (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1608 Approvals: LibreOffice gerrit bot: Verified David Ostrovsky: Verified; Looks good to me, approved -- To view, visit

[PUSHED] convert setup_native to gbuild and add to tail_build

2013-02-09 Thread David Ostrovsky (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2063 Approvals: David Ostrovsky: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2063 To unsubscribe,

[PATCH] ORowSetValue: move float and double to union

2013-02-07 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2021 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/21/2021/1 ORowSetValue: move float and double to union Change-Id: Ic5de8ad2cf9ef1143b1a5468e5fc5c9974aca5ec --- M

[PATCH libreoffice-4-0] fdo#57417: remove LDAP choice from non windows platform

2013-02-07 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2022 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/22/2022/1 fdo#57417: remove LDAP choice from non windows platform Change-Id: I0557a7c9cf0d18fbe5620ef8869bb83d0a6a7904

[PATCH] O(U)String::valueOf don't duplicate code

2013-02-05 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1992 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/92/1992/1 O(U)String::valueOf don't duplicate code Change-Id: I586fca181f63999a8f2d19d600b69f6788fd61d9 --- M

[PUSHED] write double/float via union with unsigned type for strict-a...

2013-02-05 Thread David Ostrovsky (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1990 Approvals: David Ostrovsky: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1990 To unsubscribe,

[PATCH] add OUString::toUInt64()

2013-02-04 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1980 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/80/1980/1 add OUString::toUInt64() Change-Id: I2051e161219d424d2c2b69faf6f939cfe21fa5f7 --- M sal/inc/rtl/ustring.h M

[PATCH] Strings: boolean() as a replacement for valueOf(sal_Bool)

2013-02-04 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1981 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/81/1981/1 Strings: boolean() as a replacement for valueOf(sal_Bool) valueOf(?) has been superseded by number(?).

[PATCH] fdo#57417: remove LDAP choice from non windows platform

2013-02-04 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1983 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/83/1983/1 fdo#57417: remove LDAP choice from non windows platform Change-Id: I0557a7c9cf0d18fbe5620ef8869bb83d0a6a7904

Change in core[master]: WITH_LANG: add en-US if it is missing

2013-01-29 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1919 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/19/1919/1 WITH_LANG: add en-US if it is missing Change-Id: Ie12913691fa3d01bc7ad2fc0c108821d0937d250 --- M configure.ac 1

[PATCH] handle void* to sal_Int64 as real sal_Int64 in ORowSetValue

2012-11-25 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1164 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/64/1164/1 handle void* to sal_Int64 as real sal_Int64 in ORowSetValue Change-Id:

[PATCH] enable ado driver unit test again

2012-11-07 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1004 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/04/1004/1 enable ado driver unit test again The problem is that ado driver creates a link file in the tree leaving it

[PATCH] add --enable-symbols-only as a syntactic sugar

2012-11-03 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/975 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/75/975/1 add --enable-symbols-only as a syntactic sugar Change-Id: Ib8a28c6162f47526d6bb33f81f53835cd11894b2 --- M

[PATCH] don't activate magic linking option per default: -Wl,-S

2012-10-31 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/949 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/49/949/1 don't activate magic linking option per default: -Wl,-S The build should not be smarter then it should, at least

don't activate magic linking option per default: -Wl,-S

2012-10-31 Thread David Ostrovsky (via Code Review)
David Ostrovsky has abandoned this change. Change subject: don't activate magic linking option per default: -Wl,-S .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/949 To unsubscribe, visit

[PATCH] fix ambigous template error on VS 2010

2012-10-26 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/914 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/14/914/1 fix ambigous template error on VS 2010 No constructor could take the source type, or constructor overload

[PATCH] fixing VS 2010 error: OutDir property must end with a traili...

2012-10-24 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/905 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/05/905/1 fixing VS 2010 error: OutDir property must end with a trailing slash Change-Id:

[PATCH] gbuildification of ct2n

2012-10-18 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/884 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/84/884/1 gbuildification of ct2n Change-Id: I98ca1bb2af19d99a7a908991cf27a148ee84c543 --- M Makefile.top M

[PUSHED] comment translations german-english sd fusel.cxx and fusel....

2012-10-15 Thread David Ostrovsky (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/869 Approvals: David Ostrovsky: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/869 To unsubscribe,

[PATCH] gbuildification of expat

2012-10-13 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/867 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/867/1 gbuildification of expat Change-Id: I3b3aa40f39ef82c70f6f28790b582c83e48bdf76 --- M config_host.mk.in M

[PATCH] gbuildification of jpeg

2012-10-11 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/856 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/56/856/1 gbuildification of jpeg Change-Id: I466f13f1132103bc20b9918411a54fd3106f4553 --- M Makefile.top M

[PATCH] beanshell clean content of d.lst

2012-10-08 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/838 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/38/838/1 beanshell clean content of d.lst Change-Id: I2aac9018efa36f24f15088b7702903a422b4a910 --- M beanshell/prj/d.lst 1

[PATCH] mork driver: add list tables and unit test

2012-10-08 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/841 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/41/841/1 mork driver: add list tables and unit test Change-Id: I594b24341eb38c05523f578c1dc2e43d90544f30 --- A

[PATCH] WORK IN PROGRESS gbuildification of jfreereport

2012-10-04 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/761 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/61/761/1 WORK IN PROGRESS gbuildification of jfreereport TODO: 1. add new function gb_ExternalProject_use_packege(s) an

[PATCH] gbuildification of beanshell

2012-10-02 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/745 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/45/745/1 gbuildification of beanshell Change-Id: I1b71796ca95500efeffe5e01dba3e73711f920e7 --- M Makefile.top M

[PATCH] gbuildification of languagetool

2012-10-02 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/753 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/53/753/1 gbuildification of languagetool It is not clear how to remove a file: REMOVE_FILES=openoffice/images/dialogh.png.

[PATCH] gbuildification of saxon

2012-09-30 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/739 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/39/739/1 gbuildification of saxon Change-Id: Ic54337f4279daf78b099aab368eade5a6143f586 --- M Makefile.top M

[PATCH] migrate readlicense_oo to gbuild

2012-09-23 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/676 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/76/676/1 migrate readlicense_oo to gbuild Change-Id: I8698d2da889d74a9f806c01f520ac0cbcca67b03 --- M Makefile.top M

[PATCH] introduce new option --disable-cve-tests

2012-09-19 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/653 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/53/653/1 introduce new option --disable-cve-tests Change-Id: I288638c4a70396ccb7354b20e901aa0c46ffe442 --- M

[PATCH] prevent mozilla on non Windows platforms to be enabled

2012-09-18 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/637 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/37/637/1 prevent mozilla on non Windows platforms to be enabled Change-Id: I54144005e6a284326b45a34eb958d170e872471e --- M

[PATCH] mork driver implementation

2012-09-17 Thread David Ostrovsky (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/635 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/35/635/1 mork driver implementation This is a preparation for merge into master, feature/mork branch is obsoslete and