[PATCH] i#108348 API CHANGE: add IsUTC to css.util.DateTime etc.

2013-07-15 Thread Eike Rathke (via Code Review)
Hello Lionel Elie Mamane, LibreOffice gerrit bot, Michael Stahl, Michael Meeks, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/4833 to look at the new patch set (#5). Change subject: i#108348 API CHANGE: add IsUTC to css.util.DateTime etc.

[PUSHED] i#108348 API CHANGE: add IsUTC to css.util.DateTime etc.

2013-07-15 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4833 Approvals: Eike Rathke: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4833 To unsubscribe, visit

[PUSHED] Remove commented out code

2013-06-18 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4332 Approvals: Eike Rathke: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4332 To unsubscribe, visit

[PATCH libreoffice-4-0] resolved fdo#65082 RATE function should not find roots = -1

2013-06-17 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4327 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/27/4327/1 resolved fdo#65082 RATE function should not find roots = -1 Limit RATE to roots -1.0, which is what also Excel

[PATCH libreoffice-3-6] resolved fdo#65082 RATE function should not find roots = -1

2013-06-17 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4328 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/28/4328/1 resolved fdo#65082 RATE function should not find roots = -1 Limit RATE to roots -1.0, which is what also Excel

[PUSHED] fdo#43460 use isEmpty()

2013-06-16 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4307 Approvals: Eike Rathke: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4307 To unsubscribe, visit

[PUSHED] fdo#64977 Adding Tibetan Language Support

2013-06-12 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4197 Approvals: Eike Rathke: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4197 To unsubscribe, visit

[PATCH libreoffice-4-0] resolved fdo#63805 max day of month of the intended month

2013-05-17 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3938 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/38/3938/1 resolved fdo#63805 max day of month of the intended month Since 6619955e72c1c2f29a32e82478d19147c0d7610a

[PATCH libreoffice-3-6] resolved fdo#63805 max day of month of the intended month

2013-05-17 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3939 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/39/3939/1 resolved fdo#63805 max day of month of the intended month Since 6619955e72c1c2f29a32e82478d19147c0d7610a

[PATCH libreoffice-4-0] obtain days in month from non-normalized date, fdo#63805 rel...

2013-05-17 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3946 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/46/3946/1 obtain days in month from non-normalized date, fdo#63805 related Change-Id:

[PATCH libreoffice-3-6] obtain days in month from non-normalized date, fdo#63805 rel...

2013-05-17 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3947 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/47/3947/1 obtain days in month from non-normalized date, fdo#63805 related Change-Id:

[PATCH libreoffice-3-6] resolved fdo#56772 keep track of HTML ON/OFF tokens

2013-05-16 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3926 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/26/3926/1 resolved fdo#56772 keep track of HTML ON/OFF tokens Regression introduced with

[PATCH libreoffice-4-0] resolved fdo#56772 keep track of HTML ON/OFF tokens

2013-05-16 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3925 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/25/3925/1 resolved fdo#56772 keep track of HTML ON/OFF tokens Regression introduced with

[PATCH libreoffice-4-0] resolved fdo#60468 no special tab case workaround for CSV im...

2013-05-14 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3905 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/05/3905/1 resolved fdo#60468 no special tab case workaround for CSV import This reverts

[PATCH libreoffice-3-6] resolved fdo#60468 no special tab case workaround for CSV im...

2013-05-14 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3906 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/06/3906/1 resolved fdo#60468 no special tab case workaround for CSV import This reverts

[PUSHED] Bin IsDigit method and use isAsciiDigit from CharClass

2013-05-13 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3888 Approvals: Eike Rathke: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3888 To unsubscribe, visit

[PATCH] resolved fdo#35756 import more than 64k HTML table cells

2013-05-10 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3838 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/38/3838/1 resolved fdo#35756 import more than 64k HTML table cells Enhanced EditEngine to be able to hold more than 64k

[PUSHED] resolved fdo#35756 import more than 64k HTML table cells

2013-05-10 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3838 Approvals: LibreOffice gerrit bot: Verified Eike Rathke: Verified; Looks good to me, approved -- To view, visit

[PATCH libreoffice-4-0] resolved fdo#64384 check subtotal row filtered also for sing...

2013-05-10 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3847 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/47/3847/1 resolved fdo#64384 check subtotal row filtered also for single reference (cherry picked from commit

[PATCH libreoffice-3-6] resolved fdo#64384 check subtotal row filtered also for sing...

2013-05-10 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3848 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/48/3848/1 resolved fdo#64384 check subtotal row filtered also for single reference (cherry picked from commit

[PUSHED] SW : Fix crash by checking find result

2013-05-06 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3783 Approvals: Eike Rathke: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3783 To unsubscribe, visit

[PUSHED] fdo#63878 fix the zoom problem when the sheet are RTL

2013-05-06 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3789 Approvals: Eike Rathke: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3789 To unsubscribe, visit

[PATCH libreoffice-4-0] adapt to ICU patch https://ssl.icu-project.org/trac/ticket/1...

2013-05-03 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3755 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/55/3755/1 adapt to ICU patch https://ssl.icu-project.org/trac/ticket/10107 do not call LayoutEngine::reset() Calling

[PATCH libreoffice-3-6] adapt to ICU patch https://ssl.icu-project.org/trac/ticket/1...

2013-05-03 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3756 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/56/3756/1 adapt to ICU patch https://ssl.icu-project.org/trac/ticket/10107 do not call LayoutEngine::reset() Calling

[PUSHED] disable ccache on windows/msc when building liblangtag

2013-05-03 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3760 Approvals: Eike Rathke: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3760 To unsubscribe, visit

[PATCH libreoffice-4-0] resolved fdo#63779 case-insensitive non-regex search broken

2013-05-02 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3741 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/41/3741/1 resolved fdo#63779 case-insensitive non-regex search broken Broken with

[PATCH libreoffice-4-0-3] resolved fdo#63779 case-insensitive non-regex search broken

2013-05-02 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3742 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/3742/1 resolved fdo#63779 case-insensitive non-regex search broken Broken with

[PUSHED] fdo#59850: Resolves invalid date changing by ICU's timezone ...

2013-05-02 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3637 Approvals: Eike Rathke: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3637 To unsubscribe, visit

[PATCH] new upstream release liblangtag-0.5.1

2013-04-30 Thread Eike Rathke (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3676 to look at the new patch set (#2). Change subject: new upstream release liblangtag-0.5.1 .. new upstream

[PATCH] new upstream release liblangtag-0.5.1

2013-04-30 Thread Eike Rathke (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3676 to look at the new patch set (#3). Change subject: new upstream release liblangtag-0.5.1 .. new upstream

[PATCH] new upstream release liblangtag-0.5.1

2013-04-30 Thread Eike Rathke (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3676 to look at the new patch set (#4). Change subject: new upstream release liblangtag-0.5.1 .. new upstream

[PATCH] new upstream release liblangtag-0.5.1

2013-04-30 Thread Eike Rathke (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3676 to look at the new patch set (#5). Change subject: new upstream release liblangtag-0.5.1 .. new upstream

[PUSHED] new upstream release liblangtag-0.5.1

2013-04-30 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3676 Approvals: LibreOffice gerrit bot: Verified Eike Rathke: Verified; Looks good to me, approved -- To view, visit

[PATCH] removed cruft, added instdir to filter

2013-04-29 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3664 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/64/3664/1 removed cruft, added instdir to filter Change-Id: I30b1b923658a851535f309c3773f5cbfa697d1bf --- M

[PATCH] introduced libi18nlangtagicu

2013-04-29 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3665 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/65/3665/1 introduced libi18nlangtagicu Change-Id: Ie80e989d55d465e127ccc20290d654acf222e5bb --- M Library_merged.mk M

[PATCH] use LanguageTagIcu

2013-04-29 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3666 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/3666/1 use LanguageTagIcu Change-Id: I048d72c0cd633e3aa9e6a74e4f111703969b1d77 --- M lotuswordpro/Library_lwpft.mk M

[PATCH] added LanguageTagIcu::getIcuLocale() with additional variant

2013-04-29 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3668 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/3668/1 added LanguageTagIcu::getIcuLocale() with additional variant Change-Id:

[PATCH] use LanguageTagIcu

2013-04-29 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3669 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/3669/1 use LanguageTagIcu Change-Id: I7b052a3f73740ff3a35f38dc2d96bc621b8d8deb --- M

[PATCH] use LanguageTagIcu

2013-04-29 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3670 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/3670/1 use LanguageTagIcu Change-Id: I1e66fa3edb2ddf2b6d6f4cdd25104772ff02c70a --- M

[PATCH] can we stick a with our naming conventions, just a little bi...

2013-04-29 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3671 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/71/3671/1 can we stick a with our naming conventions, just a little bit? Change-Id:

[PATCH] removed commented out code that wouldn't be correct anyway

2013-04-29 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3672 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/72/3672/1 removed commented out code that wouldn't be correct anyway Change-Id: I1fc5f6b7e779ae0c9ac5f30934c2c5d75757581d

[PATCH] ditch libi18nlangtagicu again

2013-04-29 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3674 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/74/3674/1 ditch libi18nlangtagicu again Thanks to Fridrich for finding the real cause for why I thought this was

[PATCH] use LanguageTag fallback

2013-04-29 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3675 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/75/3675/1 use LanguageTag fallback Change-Id: I34c532dc7d1c71724a5c0e29c113f2d6510cc2d7 --- M

[PATCH] remove non-existant module

2013-04-29 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3673 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/73/3673/1 remove non-existant module Change-Id: I7c4e2c9635f52f682595d95fca8a5f200a1074de --- M RepositoryModule_host.mk

[ABANDONED] removed cruft, added instdir to filter

2013-04-29 Thread Eike Rathke (via Code Review)
Eike Rathke has abandoned this change. Change subject: removed cruft, added instdir to filter .. Patch Set 1: Abandoned erroneous -- To view, visit https://gerrit.libreoffice.org/3664 To unsubscribe, visit

[ABANDONED] introduced libi18nlangtagicu

2013-04-29 Thread Eike Rathke (via Code Review)
Eike Rathke has abandoned this change. Change subject: introduced libi18nlangtagicu .. Patch Set 1: Abandoned erroneous -- To view, visit https://gerrit.libreoffice.org/3665 To unsubscribe, visit

[ABANDONED] use LanguageTagIcu

2013-04-29 Thread Eike Rathke (via Code Review)
Eike Rathke has abandoned this change. Change subject: use LanguageTagIcu .. Patch Set 1: Abandoned erroneous -- To view, visit https://gerrit.libreoffice.org/3666 To unsubscribe, visit

[ABANDONED] use LanguageTagIcu

2013-04-29 Thread Eike Rathke (via Code Review)
Eike Rathke has abandoned this change. Change subject: use LanguageTagIcu .. Patch Set 1: Abandoned erroneous -- To view, visit https://gerrit.libreoffice.org/3667 To unsubscribe, visit

[ABANDONED] added LanguageTagIcu::getIcuLocale() with additional variant

2013-04-29 Thread Eike Rathke (via Code Review)
Eike Rathke has abandoned this change. Change subject: added LanguageTagIcu::getIcuLocale() with additional variant .. Patch Set 1: Abandoned erroneous -- To view, visit https://gerrit.libreoffice.org/3668 To unsubscribe,

[ABANDONED] use LanguageTagIcu

2013-04-29 Thread Eike Rathke (via Code Review)
Eike Rathke has abandoned this change. Change subject: use LanguageTagIcu .. Patch Set 1: Abandoned erroneous -- To view, visit https://gerrit.libreoffice.org/3669 To unsubscribe, visit

[ABANDONED] use LanguageTagIcu

2013-04-29 Thread Eike Rathke (via Code Review)
Eike Rathke has abandoned this change. Change subject: use LanguageTagIcu .. Patch Set 1: Abandoned erroneous -- To view, visit https://gerrit.libreoffice.org/3670 To unsubscribe, visit

[ABANDONED] can we stick a with our naming conventions, just a little bi...

2013-04-29 Thread Eike Rathke (via Code Review)
Eike Rathke has abandoned this change. Change subject: can we stick a with our naming conventions, just a little bit? .. Patch Set 1: Abandoned erroneous -- To view, visit https://gerrit.libreoffice.org/3671 To unsubscribe,

[ABANDONED] removed commented out code that wouldn't be correct anyway

2013-04-29 Thread Eike Rathke (via Code Review)
Eike Rathke has abandoned this change. Change subject: removed commented out code that wouldn't be correct anyway .. Patch Set 1: Abandoned erroneous -- To view, visit https://gerrit.libreoffice.org/3672 To unsubscribe,

[ABANDONED] remove non-existant module

2013-04-29 Thread Eike Rathke (via Code Review)
Eike Rathke has abandoned this change. Change subject: remove non-existant module .. Patch Set 1: Abandoned erroneous -- To view, visit https://gerrit.libreoffice.org/3673 To unsubscribe, visit

[ABANDONED] ditch libi18nlangtagicu again

2013-04-29 Thread Eike Rathke (via Code Review)
Eike Rathke has abandoned this change. Change subject: ditch libi18nlangtagicu again .. Patch Set 1: Abandoned erroneous -- To view, visit https://gerrit.libreoffice.org/3674 To unsubscribe, visit

[ABANDONED] use LanguageTag fallback

2013-04-29 Thread Eike Rathke (via Code Review)
Eike Rathke has abandoned this change. Change subject: use LanguageTag fallback .. Patch Set 1: Abandoned erroneous -- To view, visit https://gerrit.libreoffice.org/3675 To unsubscribe, visit

[PATCH libreoffice-4-0] fixed out of bounds vector access

2013-04-23 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3584 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/84/3584/1 fixed out of bounds vector access in ScColumn::FindNextVisibleRowWithContent() if starting from the position

[PATCH libreoffice-4-0-3] fixed out of bounds vector access

2013-04-23 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3585 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/85/3585/1 fixed out of bounds vector access in ScColumn::FindNextVisibleRowWithContent() if starting from the position

[PATCH libreoffice-4-0] fixed a mess of out of bounds string accesses

2013-04-22 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3562 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/62/3562/1 fixed a mess of out of bounds string accesses (cherry picked from commit

[PATCH libreoffice-4-0-3] fixed a mess of out of bounds string accesses

2013-04-22 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3563 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/63/3563/1 fixed a mess of out of bounds string accesses (cherry picked from commit

[PUSHED] fdo#61541 : Count Number of selected Cells in calc

2013-04-19 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3213 Approvals: Eike Rathke: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3213 To unsubscribe, visit

[PATCH libreoffice-3-6] resolved rhbz#919020 Basic CDbl() and CSng() scan localized ...

2013-04-19 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3486 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/86/3486/1 resolved rhbz#919020 Basic CDbl() and CSng() scan localized number Code wrongly replaced decimal separator with

[PATCH libreoffice-3-6] resolved rhbz#918544 do not attempt to access non-existing f...

2013-04-18 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3460 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/60/3460/1 resolved rhbz#918544 do not attempt to access non-existing format Removing the last condition removes the

[PUSHED] fix fdo#47018 Impress paste destroy bullet

2013-04-18 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3369 Approvals: Julien Nabet: Looks good to me, but someone else must approve Eike Rathke: Verified; Looks good to me, approved -- To view,

[PUSHED] Remove a few unnecessary #includes

2013-04-18 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3448 Approvals: Eike Rathke: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3448 To unsubscribe, visit

[PATCH libreoffice-4-0] Revert svformatter already accept OUString input, fdo#6330...

2013-04-18 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3468 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/3468/1 Revert svformatter already accept OUString input, fdo#63306 This reverts commit

[PATCH libreoffice-4-0-3] Revert svformatter already accept OUString input, fdo#6330...

2013-04-18 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3469 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/3469/1 Revert svformatter already accept OUString input, fdo#63306 This reverts commit

[PUSHED] fdo#40100 make function YEARFRAC comply with ODFF Version1.2

2013-04-17 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3375 Approvals: Eike Rathke: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3375 To unsubscribe, visit

[PUSHED libreoffice-4-0] rhbz#867808 Do not throw RuntimeException by pointer

2013-04-16 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3418 Approvals: Eike Rathke: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3418 To unsubscribe, visit

[PATCH libreoffice-4-0] resolved fdo#63421 crash in pivot table with accessibility

2013-04-13 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3372 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/72/3372/1 resolved fdo#63421 crash in pivot table with accessibility The scenario of fdo#63421 (loading data and

[PATCH libreoffice-3-6] resolved fdo#63421 crash in pivot table with accessibility

2013-04-13 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3374 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/74/3374/1 resolved fdo#63421 crash in pivot table with accessibility The scenario of fdo#63421 (loading data and

[PUSHED] fdo#47018 Impress crashes when modifying bullet

2013-04-13 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3312 Approvals: Eike Rathke: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3312 To unsubscribe, visit

[PATCH libreoffice-4-0] prevent out of bounds vector access in ooo62493-1.xls recalc...

2013-04-11 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3336 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/36/3336/1 prevent out of bounds vector access in ooo62493-1.xls recalculation The document

[PATCH libreoffice-3-6] prevent out of bounds vector access in ooo62493-1.xls recalc...

2013-04-11 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3339 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/39/3339/1 prevent out of bounds vector access in ooo62493-1.xls recalculation The document

[PATCH libreoffice-4-0] prevent vector and sequence out of bounds access, fdo#60300

2013-04-11 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3340 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/3340/1 prevent vector and sequence out of bounds access, fdo#60300 This fixes the symptom of the crash but not the

[PATCH libreoffice-3-6] prevent vector and sequence out of bounds access, fdo#60300

2013-04-11 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3344 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/44/3344/1 prevent vector and sequence out of bounds access, fdo#60300 This fixes the symptom of the crash but not the

[PATCH libreoffice-4-0] resolved fdo#63403 do not create matrix with 0 rows or cols

2013-04-10 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3321 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/21/3321/1 resolved fdo#63403 do not create matrix with 0 rows or cols Change-Id:

[PATCH libreoffice-3-6] resolved fdo#63403 do not create matrix with 0 rows or cols

2013-04-10 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3322 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/22/3322/1 resolved fdo#63403 do not create matrix with 0 rows or cols (cherry picked from commit

[PATCH libreoffice-4-0] resolved fdo#63161 out of bounds string access

2013-04-05 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3211 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/11/3211/1 resolved fdo#63161 out of bounds string access Introduced with c7709b460394283fd5b1d2779b6af3585f80a991 String

[PATCH libreoffice-4-0] decimal and group separators were swapped

2013-04-03 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3194 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/94/3194/1 decimal and group separators were swapped See also https://ssl.icu-project.org/icu-bin/locexp?d_=en_=es_PE

[PATCH libreoffice-4-0] use es_AR separators when using es_AR formats

2013-04-03 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3195 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/95/3195/1 use es_AR separators when using es_AR formats Noticed due to the change in es_PE as of

[PATCH libreoffice-4-0] use matching separators and format codes of es_AR

2013-04-03 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3196 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/96/3196/1 use matching separators and format codes of es_AR Noticed due to the change in es_PE as of

[PUSHED] Use OUString and sal_Int32 in GetTextBreak()

2013-03-30 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3098 Approvals: Eike Rathke: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3098 To unsubscribe, visit

[PUSHED] Use OUString in basctl(basicide)

2013-03-30 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3116 Approvals: Eike Rathke: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3116 To unsubscribe, visit

[PUSHED] indexOf returns -1 not STRING_NOTFOUND

2013-03-28 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3115 Approvals: Eike Rathke: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3115 To unsubscribe, visit

[PUSHED] Kill double conversion from NumericBox

2013-03-26 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3035 Approvals: Eike Rathke: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3035 To unsubscribe, visit

[PUSHED libreoffice-4-0] URM_INSDEL we need to update the src position, fdo#62206

2013-03-25 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2986 Approvals: Eike Rathke: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2986 To unsubscribe, visit

[PATCH libreoffice-4-0] resolved fdo#44286 some historical dates were decremented

2013-03-25 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3036 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/36/3036/1 resolved fdo#44286 some historical dates were decremented Depending on historical timezone data with odd

[PATCH libreoffice-4-0-2] resolved fdo#44286 some historical dates were decremented

2013-03-25 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3037 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/37/3037/1 resolved fdo#44286 some historical dates were decremented Depending on historical timezone data with odd

[PATCH libreoffice-3-6] resolved fdo#44286 some historical dates were decremented

2013-03-25 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3039 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/39/3039/1 resolved fdo#44286 some historical dates were decremented Depending on historical timezone data with odd

[PATCH libreoffice-3-6-6] resolved fdo#44286 some historical dates were decremented

2013-03-25 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3040 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/3040/1 resolved fdo#44286 some historical dates were decremented Depending on historical timezone data with odd

[PUSHED] Remove RTL_CONSTASCII_STRINGPARAM in NeonUri.cxx

2013-03-25 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2975 Approvals: Eike Rathke: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2975 To unsubscribe, visit

[PATCH libreoffice-4-0-2] resolved rhbz#919020 Basic CDbl() and CSng() scan localized ...

2013-03-21 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2893 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/93/2893/1 resolved rhbz#919020 Basic CDbl() and CSng() scan localized number Code wrongly replaced decimal separator with

[PATCH libreoffice-3-6] fixed a possible crasher

2013-03-21 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2894 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/94/2894/1 fixed a possible crasher Change-Id: I3b67ba1a8896b4b291e009b4ad680e1342ba9460 --- M

[PATCH libreoffice-3-6-6] fixed a possible crasher

2013-03-21 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2895 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/95/2895/1 fixed a possible crasher Change-Id: I3b67ba1a8896b4b291e009b4ad680e1342ba9460 --- M

[PATCH libreoffice-4-0] resolved rhbz#919020 Basic CDbl() and CSng() scan localized ...

2013-03-19 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2859 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/59/2859/1 resolved rhbz#919020 Basic CDbl() and CSng() scan localized number Code wrongly replaced decimal separator with

[PATCH libreoffice-4-0] WaE: Werror=shadow

2013-03-19 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2861 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/61/2861/1 WaE: Werror=shadow Change-Id: I7f1bddbed85076f1c909d0d9f4ecdd1cda6f1880 (cherry picked from commit

[PUSHED libreoffice-4-0] WaE: Werror=shadow

2013-03-19 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2861 Approvals: Eike Rathke: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2861 To unsubscribe, visit

[PUSHED libreoffice-4-0-2] odk: fix IDL documentation:

2013-03-19 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2851 Approvals: Andras Timar: Looks good to me, but someone else must approve Eike Rathke: Verified; Looks good to me, approved -- To view,

[PUSHED] coverity#735382 Copy-paste error

2013-03-19 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2854 Approvals: Eike Rathke: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2854 To unsubscribe, visit

  1   2   3   >