Re: [Libreoffice] [REVIEW] bugfixes which break the string freeze for 3.4.3

2011-07-27 Thread Péter Rabi
Hi Michael, * 2011. 07. 26, kedd keltezéssel 17.06-kor Michael Meeks ezt írta: On Tue, 2011-07-26 at 15:17 +0200, Andras Timar wrote: I'd like to add the bugfix for https://bugs.freedesktop.org/show_bug.cgi?id=32895 Somebody some day marked it as critical. :-) So - I'm not a huge

Re: [Libreoffice] [REVIEW] bugfixes which break the string freeze for 3.4.3

2011-07-27 Thread Michael Meeks
Hi Peter, On Wed, 2011-07-27 at 13:21 +0200, Péter Rabi wrote: The bug (fdo#32895), which we are talking about affects 'dlgass' (the welcoming wizard of impress) and dialogue 'doctempl' (Impress - File - Templates - Save). Okay ! :-) While 'doctempl' uses the template handling

Re: [Libreoffice] [REVIEW] bugfixes which break the string freeze for 3.4.3

2011-07-26 Thread Andras Timar
2011/7/21 Andras Timar tima...@gmail.com: Hi, 2 or 3 weeks ago we agreed on the tech. steering call that we allow bugfixes which break the string freeze, providing that translators have enough time to catch up before release. So I suggest the following patches to be cherry-picked to

Re: [Libreoffice] [REVIEW] bugfixes which break the string freeze for 3.4.3

2011-07-26 Thread Michael Meeks
On Tue, 2011-07-26 at 15:17 +0200, Andras Timar wrote: I'd like to add the bugfix for https://bugs.freedesktop.org/show_bug.cgi?id=32895 Somebody some day marked it as critical. :-) So - I'm not a huge fan of the code. What does: + for( int i = 0; i nCount; ++i ) + { + if( rString

[Libreoffice] [REVIEW] bugfixes which break the string freeze for 3.4.3

2011-07-21 Thread Andras Timar
Hi, 2 or 3 weeks ago we agreed on the tech. steering call that we allow bugfixes which break the string freeze, providing that translators have enough time to catch up before release. So I suggest the following patches to be cherry-picked to libreoffice-3-4 branch. Update the operation of delete