Re: [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice
Pedro píše v Út 08. 01. 2013 v 17:16 -0800: Petr Mladek wrote I took the approval from Cor, Olivier, Adolfo, Michael, and pushed into 4-0 branch for 4.0.0.1 build. That means it should be available in the 4.0 daily builds tomorrow? Yup, it should be there. BTW if anyone is curious I played around with the Persona feature and created this http://www.getpersonas.com/en-US/persona/491370 You can use it in your FF browser as well :) Nice to see first persona created for LibreOffice :-) Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice
Jean-Baptiste Faure píše v St 09. 01. 2013 v 06:22 +0100: Le 09/01/2013 02:16, Pedro a écrit : Petr Mladek wrote I took the approval from Cor, Olivier, Adolfo, Michael, and pushed into 4-0 branch for 4.0.0.1 build. That means it should be available in the 4.0 daily builds tomorrow? BTW if anyone is curious I played around with the Persona feature and created this http://www.getpersonas.com/en-US/persona/491370 I saw, but it does not work for me after a make dev-install on Ubuntu 12.04 x86-64. Nothing changes when I choose an persona's url It works for me with the last build from 4-0 branch. and LO does not remember of this url if I reopen options panel. Hmm, it does not show the saved url in the options dialog. Instead, it shows URL template (http://www.getpersonas.com). I wonder if it is a feature. Kendy? Anyway, the setting is saved. I see the chosen persona even after restarting LO. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice
Hi all, so, some of you know, I have soem reservations about this feature... be that as it may, I have a small number of comments still: * there are some spelling/grammar errors: ** the button for selecting the background image has the word Backround on it ** the window for Select a persona has the sentence Find persona you like on it – lacks an a before persona ** also in that window: Then copy the URL of page [...] – lacking a the before page * I fear that enough people don't know what URL means, may I propose web address as a more accessible replacement? * What is the difference between default persona and no persona (currently, at least)? I would remove this option until we decide we want to ship a persona by default. * Downloading personas appears to be synchronous, leading to visible UI lag and Windows adding (doesn't respond) to the titlebar of the LibO window with my (admittedly somewhat slow (1000 Mb/s)) connection speed – it would be much better to make this ascynchronous. On 9 January 2013 09:54, Petr Mladek pmla...@suse.cz wrote: Hmm, it does not show the saved url in the options dialog. Instead, it shows URL template (http://www.getpersonas.com). I wonder if it is a feature. I agree that it would be nice to see the name and URL of the current persona somewhere, though not necessarily in the Persona Selection dialogue itself. I guess the name could be on the preferences page, e.g. directly after the use own persona option. Not sure about where to put the URL... Astron. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice
Hi Astron, Stefan Knorr (Astron) píše v St 09. 01. 2013 v 12:52 +0100: so, some of you know, I have soem reservations about this feature... :-) be that as it may, I have a small number of comments still: Thanks for that, very good points! * there are some spelling/grammar errors: ** the button for selecting the background image has the word Backround on it Fixed now: http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-4-0id=b020075fd33e0ad20571980d6e72bd86a05bcd2e ** the window for Select a persona has the sentence Find persona you like on it – lacks an a before persona ** also in that window: Then copy the URL of page [...] – lacking a the before page * I fear that enough people don't know what URL means, may I propose web address as a more accessible replacement? Reworded, I hope better now: http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-4-0id=c821a8ab11ff615737d98858a27ebf24803d7f61 * What is the difference between default persona and no persona (currently, at least)? I would remove this option until we decide we want to ship a persona by default. Reworded too: http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-4-0id=9b9d4a9472228a647d61edc428d542fd20bcb034 The aim is to be able to install a Persona using an extension even if we do not ship with a Persona by default; and while at that, provide the user with the possibility to switch that off (originally 'no persona'). Is it better now? * Downloading personas appears to be synchronous, leading to visible UI lag and Windows adding (doesn't respond) to the titlebar of the LibO window with my (admittedly somewhat slow (1000 Mb/s)) connection speed – it would be much better to make this ascynchronous. Actually - I am not sure why it is that slow; it shouldn't be. Either way, I'll try to do something about that make it async. I'd be able to do a progress bar too, though probably only with 3 steps (nothing, having loaded the page, having loaded the header, having loaded the footer). Is that worth that? On 9 January 2013 09:54, Petr Mladek pmla...@suse.cz wrote: Hmm, it does not show the saved url in the options dialog. Instead, it shows URL template (http://www.getpersonas.com). I wonder if it is a feature. I agree that it would be nice to see the name and URL of the current persona somewhere, though not necessarily in the Persona Selection dialogue itself. I guess the name could be on the preferences page, e.g. directly after the use own persona option. Not sure about where to put the URL... Yes - I plan to do a preview in the lower part of the Personalization dialog where you'd see (part of) the Persona bitmap. Not sure if I manage to do the async loading + preview for 4.0, though :-( But showing the URL at least should be doable - is that enough? Thank you, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice
Hi again, minor correction to my own post only LibO window with my (admittedly somewhat slow (1000 Mb/s)) connection Make that 1 MBit/s... Astron. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice
It's useless without support for font color settings. Black text on black persona isn't exactly great UX experience. Though to be fair, even with support for this, some of the personas have rather weird color combinations when checked in Firefox. On Wed, Jan 9, 2013 at 2:38 PM, Stefan Knorr (Astron) heinzless...@gmail.com wrote: Hi again, minor correction to my own post only LibO window with my (admittedly somewhat slow (1000 Mb/s)) connection Make that 1 MBit/s... Astron. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice
Hi Kendy, Le 09/01/2013 14:21, Jan Holesovsky a écrit : [...] Not sure if I manage to do the async loading + preview for 4.0, though :-( But showing the URL at least should be doable - is that enough? For me it is enough, because we have a preview in Firefox. It is not exactly the same, but it give a good idea. Some additional remarks or suggestions for a further version: 1/ if you do several tests with differents personas, each is stored in the gallery but never removed. 2/ you cannot change your persona when you are offline, even if the persona you want is already in your gallery. 3/ Perhaps the textfield for the url could be a dropdown list showing the last used personas, allowing to switch between stored personas. Best regards. JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice
Hi, Le 09/01/2013 09:54, Petr Mladek a écrit : Jean-Baptiste Faure píše v St 09. 01. 2013 v 06:22 +0100: Le 09/01/2013 02:16, Pedro a écrit : Petr Mladek wrote I took the approval from Cor, Olivier, Adolfo, Michael, and pushed into 4-0 branch for 4.0.0.1 build. That means it should be available in the 4.0 daily builds tomorrow? BTW if anyone is curious I played around with the Persona feature and created this http://www.getpersonas.com/en-US/persona/491370 I saw, but it does not work for me after a make dev-install on Ubuntu 12.04 x86-64. Nothing changes when I choose an persona's url It works for me with the last build from 4-0 branch. Now it works for me too, with the help of Kendy. I compiled LO without neon which is necessary to have access to http:// Nice feature :-) Best regards. JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice
Michael Meeks píše v Út 08. 01. 2013 v 14:21 +: Hi there, I had a quick read; it -looks- rather low-touch - and the graphic effect is really pleasant; so I'd be well up for merging this. ( git --no-pager log --numstat -u 255c03d6ad4ed13c456ee621e0af765684a475d2~..4a4627eba410df933d004170d9f5638526acaed2 ; git --no-pager log --numstat -u 540f090a68ae4375a36d0ee6dfbb4a82f28ac704~..540f090a68ae4375a36d0ee6dfbb4a82f28ac704 ; git --no-pager log --numstat -u c223e5ff859171adab1597025b30ec2501fc5771~..3f3d0c52ae29b6ab6b2c10a5557714361aa76a26 ) | less IIRC we had this feature already for 4.0 for Windows, and this extends it to Linux+Mac. Having seen some oddness around transparency for Mac in the past, it would be worth testing there. But +1 from me for the -4-0 branch - assuming we can get another couple of reviews. As a quibble, I'd prefer to see BitmapEx's instead of BitmapEx*'s being used in the settings - which would simplify the code and make it less error prone I suspect; BitmapEx::IsEmpty is your friend :-) I took the approval from Cor, Olivier, Adolfo, Michael, and pushed into 4-0 branch for 4.0.0.1 build. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice
Petr Mladek wrote I took the approval from Cor, Olivier, Adolfo, Michael, and pushed into 4-0 branch for 4.0.0.1 build. That means it should be available in the 4.0 daily builds tomorrow? BTW if anyone is curious I played around with the Persona feature and created this http://www.getpersonas.com/en-US/persona/491370 You can use it in your FF browser as well :) Enjoy :) -- View this message in context: http://nabble.documentfoundation.org/LATE-FEATURE-Personas-in-LibreOffice-tp4027571p4027880.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice
Le 09/01/2013 02:16, Pedro a écrit : Petr Mladek wrote I took the approval from Cor, Olivier, Adolfo, Michael, and pushed into 4-0 branch for 4.0.0.1 build. That means it should be available in the 4.0 daily builds tomorrow? BTW if anyone is curious I played around with the Persona feature and created this http://www.getpersonas.com/en-US/persona/491370 I saw, but it does not work for me after a make dev-install on Ubuntu 12.04 x86-64. Nothing changes when I choose an persona's url and LO does not remember of this url if I reopen options panel. Note: url depends on your locale, for me it's http://www.getpersonas.com/fr/persona/491370 You can use it in your FF browser as well :) A little too flashy for me ;-) Best regards. JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-ux-advise] [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice
Michael Meeks píše v Út 08. 01. 2013 v 14:21 +: Hi there, I had a quick read; it -looks- rather low-touch - and the graphic effect is really pleasant; so I'd be well up for merging this. ( git --no-pager log --numstat -u 255c03d6ad4ed13c456ee621e0af765684a475d2~..4a4627eba410df933d004170d9f5638526acaed2 ; git --no-pager log --numstat -u 540f090a68ae4375a36d0ee6dfbb4a82f28ac704~..540f090a68ae4375a36d0ee6dfbb4a82f28ac704 ; git --no-pager log --numstat -u c223e5ff859171adab1597025b30ec2501fc5771~..3f3d0c52ae29b6ab6b2c10a5557714361aa76a26 ) | less IIRC we had this feature already for 4.0 for Windows, and this extends it to Linux+Mac. Having seen some oddness around transparency for Mac in the past, it would be worth testing there. But +1 from me for the -4-0 branch - assuming we can get another couple of reviews. As a quibble, I'd prefer to see BitmapEx's instead of BitmapEx*'s being used in the settings - which would simplify the code and make it less error prone I suspect; BitmapEx::IsEmpty is your friend :-) I took the approval from Cor, Olivier, Adolfo, Michael, and pushed into 4-0 branch for 4.0.0.1 build. Best Regards, Petr ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
