Hi,
The Bug is filed and accepted at: https://bugs.freedesktop.org/show_bug.cgi?id=75243
Steps to reproduce:
1. Open Writer and use a document .doc
2. Add it a custom property. Don't enter any value for the property
3. Save it and close Writer
4. Open again Writer and use same
Hello,
Here is a patch that should fix bug 53508.
It apply the paragraph automatic formatting attributs to all the nodes
in the selection (SwPaM) instead of just the last node.
Sorry to take so much time to make this patch… I don't have much time to
code on LO. But each time I do it's a real
Hi Ricardo,
2012/8/18 Ricardo Montania rica...@linuxafundo.com.br:
Hello. First commit. :)
EasyHacking, unused code. Any problem, please tell me.
The pacth looks good, I'll integrate it soon. Would you mind sending a
blanket licence statement to this mailing list, such as
All of my past
Pushed, many thanks.
Andras
2012/8/18 Ricardo Montania rica...@linuxafundo.com.br:
Hello. First commit. :)
EasyHacking, unused code. Any problem, please tell me.
--
Ricardo Montania Prado de Campos
http://www.linuxafundo.com.br
___
On Wed, 2012-03-14 at 12:58 +0100, Maxime de Roucy wrote:
Hello
Here is 2 new patch :
0001-add-GetCurParAttr-and-GetPaMParAttr-in-SwEditShell.patch
Create the function GetCurParAttr and GetPaMParAttr in the SwEditShell
class. The function will be used in future patchs (on the format
On Wed, 2012-03-28 at 17:48 +0200, Maxime de Roucy wrote:
Hello,
I am writing this mail trying to prevent this thread from dying…
So, what do you think about changing the default behavior of the format
paintbrush ?
Re-reviewing this, it seems reasonable to me. So I've (finally) pushed
The patch 0003 introduce a bug :
-if ( SID_PRINTER_NAME == nId )
-{
-// just set a recorded printer name
-if ( pPrinter )
-SetPrinter( pPrinter, SFX_PRINTER_PRINTER );
-break;
-}
please wait
Hey, Michael.
Thanks for the notice. A shame that I bit off a bit more than I could
chew when I dove into LO, but I'm glad to keep up with the project and
I really appreciate all the great work the team is doing.
All of my past future contributions to LibreOffice may be licensed
under the
Hi Christoph,
On Mon, 2011-02-07 at 21:30 +0100, Christoph Herzog wrote:
Checked for the misspelled names via ./g grep, built master before and
after the changes and no error occurred. So hopefully it is ok.
...
patch under LGPLv3+/MPL.
I'm just working through the MPL/LGPLv3+
Am 2012-05-01 12:13, schrieb Michael Meeks:
Hi Martin,
On Thu, 2011-05-19 at 19:21 +0200, Martin Kepplinger wrote:
Translate german code comments in writer/sw/source/ui/lingu to english!
This is contributed under the terms of the MPL 1.1 / GPLv3+ / LGPLv3+ triple
license.
Thanks
Hi, Kendy
All of my past future contributions to LibreOffice may be licensed
under the MPL/LGPLv3+ dual license.
Thank you for the information!
Victor Lee
On Thu, Apr 5, 2012 at 1:42 AM, Jan Holesovsky ke...@suse.cz wrote:
Hi Victor,
Victor Lee píše v Ne 25. 12. 2011 v 01:41 +0900:
I've
Hi Victor,
Victor Lee píše v Ne 25. 12. 2011 v 01:41 +0900:
I've reformatted the patch.
The reason for deleting these IDs is stated here:
https://bugs.freedesktop.org/show_bug.cgi?id=39639
Sorry for the late reply, and thank you for the advice!
This is my first EasyHack.
While cleaning
Hi Maxime,
On Tue, 2012-03-27 at 18:57 +0200, Maxime de Roucy wrote:
I hope this clarified a bit my choice to remove the nSelectionType ==
nsSelectionType::SEL_TBL part from the lcl_CreateEmptyItemSet
function.
Thanks for the details, I pushed the patch and the others that were
needed (and
oops forgot to update title
On Wed, 2012-03-28 at 12:09 +0200, Cedric Bosdonnat wrote:
Hi Maxime,
On Tue, 2012-03-27 at 18:57 +0200, Maxime de Roucy wrote:
I hope this clarified a bit my choice to remove the nSelectionType ==
nsSelectionType::SEL_TBL part from the lcl_CreateEmptyItemSet
Hello,
I am writing this mail trying to prevent this thread from dying…
So, what do you think about changing the default behavior of the format
paintbrush ?
Regards
Maxime de Roucy
--
Maxime de Roucy
Groupe LINAGORA - OSSA
80 rue Roque de Fillol
92800 PUTEAUX
Tel. : 0 810 251 251
Le lundi
Hello,
Following my discussion with Cedric on IRC here is some other
explanations on why I chose to remove the nSelectionType ==
nsSelectionType::SEL_TBL case from the lcl_CreateEmptyItemSet function
in formatclipboard.cxx.
Without the patch : lcl_CreateEmptyItemSet is called only in the
Hello,
Is this change based on the idea, that people who use the paintbrush are
not that much looking at styles, and thus that copying those styles
might do more harm then good for them?
I was showing a modification I made to the format paintbrush in a
preview patch to a co-worker who work
Hello,
Is this change based on the idea, that people who use the paintbrush are
not that much looking at styles, and thus that copying those styles
might do more harm then good for them?
I was showing a modification I made to the format paintbrush in a
preview patch to a co-worker who work
Here a copy of the mail I send to Cedric Bosdonnat… forgot to add the
list as Cc:.
Hello
Thanks you for asking me…
When you select a cell in Writer the selection type is a mix of
nsSelectionType::SEL_TBL_CELLS, nsSelectionType::SEL_TBL and
nsSelectionType::SEL_TXT.
So when the
Hi Maxime,
Maxime de Roucy wrote (14-03-12 18:38)
Two new patchs that modify the default behaviour of the format
paintbrush.
0001-Format-paintbrush-default-behaviour.patch
To apply to the core repository.
0001-Change-format-paintbrush.patch
To apply to the help repository.
By default the
Hello
0001-add-SCWARN_EXPORT_MAXTAB-and-SCWARN_EXPORT_MAXCOL.patch
Add warning in the xls export filter in order to display different
messages when the number of column, row or tab are too high.
0002-rewrite-and-comment-SwEditShell-GetPaMTxtFmtColl.patch
comment, doxygen description, and rewrite
Hello Maxime,
On Tue, 2012-03-13 at 17:52 +0100, Maxime de Roucy wrote:
Feel free to comment my code !
Many thanks for your 4 patches. I fixed a few typos (or frenglish words)
and pushed them to master. Feel free to provide more patches like these.
--
Cedric
Hi Maxime,
On Wed, 2012-03-14 at 16:50 +0100, Maxime de Roucy wrote:
Here is some new patchs on the format clipboard. The first just add some
comment in the formatclipboard.hxx file. The second one depend on
modifications I made in the previous patch
oops, forgot to update the subject
On Thu, 2012-03-15 at 17:02 +0100, Cedric Bosdonnat wrote:
Hello Maxime,
On Tue, 2012-03-13 at 17:52 +0100, Maxime de Roucy wrote:
Feel free to comment my code !
Many thanks for your 4 patches. I fixed a few typos (or frenglish words)
and pushed them
Hello
Here is 2 new patch :
0001-add-GetCurParAttr-and-GetPaMParAttr-in-SwEditShell.patch
Create the function GetCurParAttr and GetPaMParAttr in the SwEditShell
class. The function will be used in future patchs (on the format
paintbrush) that I need to format correctly.
Attention : the patch
0001-add-GetCurParAttr-and-GetPaMParAttr-in-SwEditShell.patch need the
preview patch 0004-SwEditShell-use-of-the-STL-swap-function.patch which
is currently waiting for moderator approval to be published in the
mailing list.
--
Maxime de Roucy
Groupe LINAGORA - OSSA
80 rue
Hello
Here is some new patchs on the format clipboard. The first just add some
comment in the formatclipboard.hxx file. The second one depend on
modifications I made in the previous patch
0001-add-GetCurParAttr-and-GetPaMParAttr-in-SwEditShell.patch which is
itself dependant of the patch
Hello
Two new patchs that modify the default behaviour of the format
paintbrush.
0001-Format-paintbrush-default-behaviour.patch
To apply to the core repository.
0001-Change-format-paintbrush.patch
To apply to the help repository.
By default the paintbrush doesn't copy the paragraph formatting
Hi Stefan,
Stefan Knorr (Astron) wrote (06-03-12 14:40)
What specifically doesn't work for you? For me it's about okay ~today.
(I remember August promised you a better solution for later, though.)
It is about navigating through the various sections (left) with the
arrow keys. If that does
Hi Cor,
What specifically doesn't work for you? For me it's about okay ~today.
(I remember August promised you a better solution for later, though.)
Astron.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
Hi all,
Regarding this change, I remember I had some discussion (or a bug) about
the fact that navigation of the option page was broken by the patch.
And I see this commit in git: 064065985a24e2454234e929969cc2b1649b3d01
However, when I work in a build from last week (1), I see that
Cor Nouws wrote (03-03-12 22:29)
However, when I work in a build from last week (1), I see that
navigating the option pages (sections, left panel of the window) with
arrow keys does not work.
1) LibreOffice master 120116 3.6.0alpha0+
a9ebfbc-9eed775-f061262-libreoffice-3-5 branch-point
I
On 09/02/12 14:53, Albert Thuswaldner wrote:
Hi,
[...]
So I have improved the patch according to Kohei's suggestion above.
Now I store the prefix at each key-stroke and check for illegal
characters. When an illegal character is entered, the text is reverted
back to the last good prefix. (So
On 09/02/12 14:53, Albert Thuswaldner wrote:
If it was up to me I would go for the visual bell. Any thoughts on this?
actually thinking about it some more I don't find it unnatural to have
the whole ( reverted ) prefix selected after entering an illegal
character ( I think this is a technique
On Mon, Feb 13, 2012 at 12:23, Noel Power nopo...@suse.com wrote:
On 09/02/12 14:53, Albert Thuswaldner wrote:
2) When trying to delete text in the edit box, the last character
sticks (can't be deleted).
well that would seem to be because your code thinks a blank prefix is
illegal, I
On 09/02/12 14:53, Albert Thuswaldner wrote:
Hi,
[...]
So I have improved the patch according to Kohei's suggestion above.
Now I store the prefix at each key-stroke and check for illegal
characters. When an illegal character is entered, the text is reverted
back to the last good prefix. (So
On 09/02/12 14:53, Albert Thuswaldner wrote:
If it was up to me I would go for the visual bell. Any thoughts on this?
actually thinking about it some more I don't find it unnatural to have
the whole ( reverted ) prefix selected after entering an illegal
character ( I think this is a technique
On Mon, Feb 13, 2012 at 12:23, Noel Power nopo...@suse.com wrote:
On 09/02/12 14:53, Albert Thuswaldner wrote:
2) When trying to delete text in the edit box, the last character
sticks (can't be deleted).
well that would seem to be because your code thinks a blank prefix is
illegal, I
Hi,
Given that, I still think it's better (and easier) to check for every
key-press, but instead of launching an error dialog for an illegal name,
just put the old legal name back into the text box and sound an beep or
something. That's less intrusive than a big dialog being thrown right
Hi Albert,
At least I get two annoying bugs:
1) The cursor moves In front of the text when the Prefix is reverted.
2) When trying to delete text in the edit box, the last character
sticks (can't be deleted).
Does someone have a clue whats going on?
Hm, no (not a coder I am). But can you
Hi,
Given that, I still think it's better (and easier) to check for every
key-press, but instead of launching an error dialog for an illegal name,
just put the old legal name back into the text box and sound an beep or
something. That's less intrusive than a big dialog being thrown right
Hi Albert,
At least I get two annoying bugs:
1) The cursor moves In front of the text when the Prefix is reverted.
2) When trying to delete text in the edit box, the last character
sticks (can't be deleted).
Does someone have a clue whats going on?
Hm, no (not a coder I am). But can you
On 02/02/12 18:17, Muhammad Haggag wrote:
On Thu, Feb 2, 2012 at 5:13 PM, Muhammad Haggag mhag...@gmail.com
mailto:mhag...@gmail.com wrote:
On Thu, Feb 2, 2012 at 2:01 PM, Noel Power nopo...@suse.com
mailto:nopo...@suse.com wrote:
very nice patch, looking at the spec I agree
this patch is going to superceded soon by a cleaner one.
On 2012-02-02 14:57, Noel Grandin wrote:
Hi
Attached patch converts various places in the editeng, sc and sw
modules from using tools/table.hxx to using std::map
This patch should be easier to review, mostly because the logic using
Hi Albert,
Good to see you being active again. :-)
On Fri, 2012-02-03 at 11:47 +0100, Albert Thuswaldner wrote:
I have updated the patch according to Markus comments above, removing
the check to see if the keybinding option has been modified. A side
effect of the above is that return type
Noel Power píše v Út 31. 01. 2012 v 12:39 +:
ok, pushed,
Just marking the thread [PUSHED] :-)
Regards,
Kendy
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Hi,
This is an old topic again...
On Tue, Jul 12, 2011 at 00:26, Markus Mohrhard
markus.mohrh...@googlemail.com wrote:
Hello Albert,
nice work but I have some comments.
Operator== should have return type bool and not int(I saw that ScDocOptions
used int too, but I have changed that
On 01/02/12 19:21, Muhammad Haggag wrote:
Bug:
https://bugs.freedesktop.org/show_bug.cgi?id=43398
Cause:
dmapper used to treat the presence of a w:BiDi element in a
paragraph's properties as an indicator of RTL directionality, which is
incorrect. A w:BiDi element may have a value of 0,
Hi Barış
On 01/02/12 18:28, Barış Akkurt wrote:
Hi, everyone.
This is my first trial of sending a patch for LibreOffice. I worked on
this bug: https://bugs.freedesktop.org/show_bug.cgi?id=31022 My design
is not as good as the design by Andrew, but I think it looks better
than previous one.
On Thu, Feb 2, 2012 at 2:01 PM, Noel Power nopo...@suse.com wrote:
very nice patch, looking at the spec I agree and this looks like a
credible fix for me so pushed to master. Look forward to more like this,
thanks
Thanks for the review! If you'd pardon my absolute noobiness, do I have
access
On Thu, Feb 2, 2012 at 5:13 PM, Muhammad Haggag mhag...@gmail.com wrote:
On Thu, Feb 2, 2012 at 2:01 PM, Noel Power nopo...@suse.com wrote:
very nice patch, looking at the spec I agree and this looks like a
credible fix for me so pushed to master. Look forward to more like this,
thanks
Hello Norbert,
On Tue, Jan 31, 2012 at 00:52, Norbert Thiebaud nthieb...@gmail.com wrote:
this would be a run-time issue, so the test is not 'build_os' =
cygwin but $_os = WINNT
Thanks! :-) Fixed and pushed as
Hi Alexander
After applying this doesn't compile for me, at least in a couple of
instances there appear to be getEmptyTuple methods still referenced in
the code ( e.g. b32point.hxx:122 ), I knocked out a couple of those but
then some errors started appearing in some of the cxx files. Now
On 31/01/12 22:14, Lionel Elie Mamane wrote:
Attached patch fixes fdo#45453, which breaks datasheet display of all
queries/tables (with more than twice the number of rows than fit on
screen), if the database system does not properly support boolean
types.
The original bug report is about
Hi Lionel,
On 2012-01-31 at 23:14 +0100, Lionel Elie Mamane wrote:
Attached patch fixes fdo#45453, which breaks datasheet display of all
queries/tables (with more than twice the number of rows than fit on
screen), if the database system does not properly support boolean
types.
The
+1 from me too...
On 02/01/2012 03:58 PM, Noel Power wrote:
On 31/01/12 22:14, Lionel Elie Mamane wrote:
Attached patch fixes fdo#45453, which breaks datasheet display of all
queries/tables (with more than twice the number of rows than fit on
screen), if the database system does not properly
Hi Noel
On 31/01/12 14:24, Noel Grandin wrote:
sorry, that should be converted to std::vector
you mean boost::ptr_vector I think :-)
Hope I didn't miss anything this time, I made some minor changes ( see
attached patch )
e.g. I removed the maLayoutNames.clear() from :~SdPresLayoutDlg() as
On 2012-02-01 13:58, Noel Power wrote:
e.g. I removed the maLayoutNames.clear() from :~SdPresLayoutDlg() as
the vector will go out of scope here anyway and delete the container
contents.
Really?
I wasn't sure about that - the boost documentation isn't that great.
So I scanned the LibO
On 01/02/12 11:59, Noel Grandin wrote:
On 2012-02-01 13:58, Noel Power wrote:
e.g. I removed the maLayoutNames.clear() from :~SdPresLayoutDlg() as
the vector will go out of scope here anyway and delete the container
contents.
Really?
I wasn't sure about that - the boost documentation
Hi Caolán,
30.01.2012 21:08, Caolán McNamara пишет:
The original code with...
git show 7b0b5cdf source/ui/inc/scroll.hxx source/ui/uiview/scroll.cxx
it seems that this SwScrollbar had its own SwScrollbar::Show method and
inherits from Window which has a Window::Show method as well. The
Bug:
https://bugs.freedesktop.org/show_bug.cgi?id=43398
Cause:
dmapper used to treat the presence of a w:BiDi element in a paragraph's
properties as an indicator of RTL directionality, which is incorrect. A
w:BiDi element may have a value of 0, indicating LTR.
Fix: Inspect the integral value of
Hi Eike,
31.01.2012 17:41, Eike Rathke пишет:
Yup, good catch. Technically there's also the limitation that a ' single
quote character is not allowed as the very first or last character. The
message would get quite lengthy though if we added and not the
character ' at the beginning or end.
I
Hi,
please have a look at the comments marked with crossmanith. I can push
on my own but a short review (and feedback) would be nice.
Christina
From ac8d464245852f701478039f89ae876d6584fb88 Mon Sep 17 00:00:00 2001
From: Christina Rossmanith chrrossman...@web.de
Date: Tue, 31 Jan 2012
Hi Elton
First thanks for submitting your patch, it's appreciated however could I
ask if you could please repost your patch as an attachment [1] ? patch
content inline in a mail message just does't work as the mail client
breaks the lines in such a way as the patch program no longer
On 31/01/12 09:11, Chr. Rossmanith wrote:
Hi,
please have a look at the comments marked with crossmanith. I can
push on my own but a short review (and feedback) would be nice.
isn't it that nInc can only be either 2, 4, 10 or 20 so that line
indicated can't afaics be reached
and nSteps
Hi,
ImplSalLogFontToFontA() seems to be unused. I don't have a Windows build
environment I couldn't test whether it really builds after removing the
method. But I don't see why it shouldn't...
Christina
From 053a691750697916fd5cb176bec886b6da13b630 Mon Sep 17 00:00:00 2001
From: Christina
Am 31.01.2012 11:43, schrieb Noel Power:
On 31/01/12 09:11, Chr. Rossmanith wrote:
please have a look at the comments marked with crossmanith. I can
push on my own but a short review (and feedback) would be nice.
isn't it that nInc can only be either 2, 4, 10 or 20 so that line
indicated
Hi Noel, *,
I have attached the patch as an attachment. I also confirm that this
contribution, as well as future ones are licensed under MPL 1.1 / GPL
v3+ / LGPL v3+.
Best Regards,
Elton
--
Elton Chung
Administrator, sponsor of mirror.layerjet.com
Language Maintainer of ReactOS Open Source
Hi Christina
On 31/01/12 10:43, Chr. Rossmanith wrote:
Hi,
ImplSalLogFontToFontA() seems to be unused. I don't have a Windows
build environment I couldn't test whether it really builds after
removing the method. But I don't see why it shouldn't...
Christina
I'd say commit it, can't see this
On 30/01/12 22:53, Andreas Schierl wrote:
Hi, I found out that bugs
https://bugs.freedesktop.org/show_bug.cgi?id=34611
https://bugs.freedesktop.org/show_bug.cgi?id=45376
are caused by a missing call to
ClrContourCache( pObj );
in
/sw/source/core/layout/pagechg.cxx:
void
On 31/01/12 11:05, Elton Chung wrote:
Hi Noel, *,
I have attached the patch as an attachment. I also confirm that this
contribution, as well as future ones are licensed under MPL 1.1 / GPL
v3+ / LGPL v3+.
ok, pushed, thank, ps. next time don't chop off the header of the
formatted patch 'cause
---
basegfx/inc/basegfx/matrix/b2dhommatrixtools.hxx |3 -
basegfx/inc/basegfx/polygon/b2dpolygon.hxx | 20
basegfx/inc/basegfx/polygon/b3dpolygon.hxx |3 -
basegfx/inc/basegfx/polygon/b3dpolypolygon.hxx |3 -
basegfx/inc/basegfx/range/b1drange.hxx |
Noel Power wrote:
I cc some writer experts who may suggest some
alternative solution(s) or change ( or maybe say it is perfect )
The new patch in this e-mail should provide even better performance
(as it only clears the contour cache for contour wrapped drawing objects).
Can you confirm your
On 30/01/12 13:54, Noel Grandin wrote:
Hi
Attached patch converts SdCustomShow to use std::vector.
Code is contributed under MPL+/LGPL+/GPL+
Regards, Noel Grandin
Disclaimer: http://www.peralex.com/disclaimer.html
I hate these remove list etc. type patches as they tend to be tricky and
sorry, that should be converted to std::vector
On 2012-01-31 16:22, Noel Grandin wrote:
Hi
Attached patch converts SdPresLayoutDlg to use std::map.
Code is contributed under MPL+/LGPL+/GPL+
Regards, Noel Grandin
Disclaimer: http://www.peralex.com/disclaimer.html
On 31/01/12 12:46, openoff...@schierla.de wrote:
Noel Power wrote:
I cc some writer experts who may suggest some
alternative solution(s) or change ( or maybe say it is perfect )
The new patch in this e-mail should provide even better performance
(as it only clears the contour cache for contour
31.01.2012 18:22, Noel Power пишет:
On 30/01/12 13:54, Noel Grandin wrote:
Attached patch converts SdCustomShow to use std::vector.
I hate these remove list etc. type patches as they tend to be tricky and
time consuming to look at ;-) . The patch looked ok for me, hopefully if
I missed
On Tue, 2012-01-31 at 00:00 +0100, Regina Henschel wrote:
The term inverse is not correct in this context. It should be
reciprocal instead.
Example: The inverse of SIN is ASIN. The reciprocal of SIN is CSC.
I agree Regina, you have unusually good English :-)
Any chance of a
So I should be calling
maPages.erase( std::find(maPages.begin(), maPages.end(), pOldPage) );
??
On 2012-01-31 17:24, Ivan Timofeev wrote:
31.01.2012 18:22, Noel Power пишет:
On 30/01/12 13:54, Noel Grandin wrote:
Attached patch converts SdCustomShow to use std::vector.
I hate these remove
31.01.2012 19:42, Noel Grandin пишет:
So I should be calling
maPages.erase( std::find(maPages.begin(), maPages.end(), pOldPage) );
??
maPages.erase( std::remove(maPages.begin(), maPages.end(), pOldPage),
maPages.end() );
I'll fix that.
Ivan
___
On Tue, 2012-01-31 at 13:21 +, Caolán McNamara wrote:
On Tue, 2012-01-31 at 11:15 +, Noel Power wrote:
cc'ing Caolán as he might be interested because it doesn't turn up in
the unused.easy
Its windows only code, and callcatcher can only see what gets compiled
as its just a
thanks, still working out how this STL stuff hangs together.
On 2012-01-31 17:55, Ivan Timofeev wrote:
31.01.2012 19:42, Noel Grandin пишет:
So I should be calling
maPages.erase( std::find(maPages.begin(), maPages.end(), pOldPage) );
??
maPages.erase( std::remove(maPages.begin(),
On Tue, 2012-01-31 at 16:10 +, Michael Meeks wrote:
On Tue, 2012-01-31 at 13:21 +, Caolán McNamara wrote:
On Tue, 2012-01-31 at 11:15 +, Noel Power wrote:
cc'ing Caolán as he might be interested because it doesn't turn up in
the unused.easy
Its windows only code, and
Hello,
On 31/01/12 17:10, Michael Meeks wrote:
Interesting (in a world with infinite time); would the mingw
cross-compile be call-catcher-able such that we could get a more precise
and comprehensive list ?
Yes, at the level of callcatcher 1.1.3, I added the support for gnu
assembler for
On 01/31/2012 03:22 PM, Noel Power wrote:
I hate these remove list etc. type patches as they tend to be tricky and
time consuming to look at ;-) . The patch looked ok for me, hopefully if
I missed something ( 'cause these really are tricky ) then someone else
will spot it. Anyway thanks again
I ran make check at the global level - does that not invoke the
individual modules check targets?
On 2012-01-31 18:17, Stephan Bergmann wrote:
Looks like you missed to run make check:
LOG 1. removeByIndex(1) ...OK
LOG removing a non existent object to get an exception
LOG 2. removeByIndex():
31.01.2012 19:55, Ivan Timofeev пишет:
I'll fix that.
Hum; guys, what about
- mpSdCustomShow-Remove(pPage-GetSdrPage());
+ ::std::remove(mpSdCustomShow-PagesVector().begin(),
mpSdCustomShow-PagesVector().end(),
+ pPage-GetSdrPage());
mpSdCustomShow-Remove(pPage-GetSdrPage()); - using the
On 01/31/2012 05:19 PM, Noel Grandin wrote:
I ran make check at the global level - does that not invoke the
individual modules check targets?
It does. Strange anyway. This failure is consistently reproducible for
me and looks suspiciously like the remove problem discussed in this
thread...
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi
I fixed the english terminology, according to the justifications by Regina.
regards
Olivier
Em 31-01-2012 11:28, Regina Henschel escreveu:
Olivier Hallot schrieb:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi Regina
It has been
On 31/01/12 15:55, Ivan Timofeev wrote:
31.01.2012 19:42, Noel Grandin пишет:
So I should be calling
maPages.erase( std::find(maPages.begin(), maPages.end(), pOldPage) );
??
maPages.erase( std::remove(maPages.begin(), maPages.end(), pOldPage),
maPages.end() );
I'll fix that.
Ivan
nice
On 31/01/12 16:17, Stephan Bergmann wrote:
On 01/31/2012 03:22 PM, Noel Power wrote:
I hate these remove list etc. type patches as they tend to be tricky and
time consuming to look at ;-) . The patch looked ok for me, hopefully if
I missed something ( 'cause these really are tricky ) then
On 31/01/12 16:20, Ivan Timofeev wrote:
31.01.2012 19:55, Ivan Timofeev пишет:
I'll fix that.
Hum; guys, what about
- mpSdCustomShow-Remove(pPage-GetSdrPage());
+ ::std::remove(mpSdCustomShow-PagesVector().begin(),
mpSdCustomShow-PagesVector().end(),
+ pPage-GetSdrPage());
31.01.2012 21:12, Noel Power пишет:
should remove the first occurrence, care to fix ?
so the exact equivalent of
mpSdCustomShow-Remove(pPage-GetSdrPage())
will be:
SdCustomShow::PageVec::iterator it = std::find(
mpSdCustomShow-PagesVector().begin(),
On 31/01/12 17:31, Ivan Timofeev wrote:
31.01.2012 21:12, Noel Power пишет:
should remove the first occurrence, care to fix ?
so the exact equivalent of
mpSdCustomShow-Remove(pPage-GetSdrPage())
will be:
SdCustomShow::PageVec::iterator it = std::find(
Hi,
However something I noticed is that there are still some problems with
entering the 'Prefix name in the options, firstly the input box seems to be
overwritten by the label ( part of the input/edit field for the prefix is
missing until you type )
Hmm, strange, I haven't notice that myself.
This patch removes unused code as listed in unusedcode.easy
From 4eaa8adb17c0334f08c83509644b45553254376e Mon Sep 17 00:00:00 2001
From: Santiago Martinez smvar...@gmail.com
Date: Tue, 31 Jan 2012 19:59:31 +0100
Subject: [PATCH] Remove unused code.
---
Hi Ivan,
On Tuesday, 2012-01-31 21:31:11 +0400, Ivan Timofeev wrote:
should remove the first occurrence, care to fix ?
so the exact equivalent of
mpSdCustomShow-Remove(pPage-GetSdrPage())
will be:
SdCustomShow::PageVec::iterator it = std::find(
On 31/01/12 18:35, Albert Thuswaldner wrote:
Additionally you still can get the prefix name to
be blank ( or at least I managed to do that ) by attempting to change the
name by delete, when all the name is deleted you get a message saying the
sheet prefix is illegal ( actually I find that
On Tue, 2012-01-31 at 20:07 +, Noel Power wrote:
On 31/01/12 18:35, Albert Thuswaldner wrote:
Additionally you still can get the prefix name to
be blank ( or at least I managed to do that ) by attempting to change
the
name by delete, when all the name is deleted you get a
Hi Albert,
On Tuesday, 2012-01-31 19:35:54 +0100, Albert Thuswaldner wrote:
However something I noticed is that there are still some problems with
entering the 'Prefix name in the options, firstly the input box seems to be
overwritten by the label ( part of the input/edit field for the
1 - 100 of 3491 matches
Mail list logo
