[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

https://bugs.documentfoundation.org/show_bug.cgi?id=114939 Michael Stahl changed: What|Removed |Added CC|

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

https://bugs.documentfoundation.org/show_bug.cgi?id=114939 --- Comment #15 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master":

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

https://bugs.documentfoundation.org/show_bug.cgi?id=114939 --- Comment #13 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master":

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

https://bugs.documentfoundation.org/show_bug.cgi?id=114939 --- Comment #14 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master":

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

https://bugs.documentfoundation.org/show_bug.cgi?id=114939 --- Comment #12 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master":

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

https://bugs.documentfoundation.org/show_bug.cgi?id=114939 --- Comment #11 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master":

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

https://bugs.documentfoundation.org/show_bug.cgi?id=114939 Michael Stahl changed: What|Removed |Added CC|

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

https://bugs.documentfoundation.org/show_bug.cgi?id=114939 --- Comment #10 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master":

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

https://bugs.documentfoundation.org/show_bug.cgi?id=114939 --- Comment #9 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master":

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

https://bugs.documentfoundation.org/show_bug.cgi?id=114939 Commit Notification changed: What|Removed |Added Whiteboard|

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

https://bugs.documentfoundation.org/show_bug.cgi?id=114939 --- Comment #8 from JimF --- I am not able to write a review, but I too (as did Michael Stahl) would fail the code review. The code is fine, BUT since this function is used in the ODF encryption scheme, all files current

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

https://bugs.documentfoundation.org/show_bug.cgi?id=114939 --- Comment #7 from JimF --- To me, that patch looks good, and the test case is a 52 byte value, which was one of the lengths which would trigger this bug. NOTE, I am almost certain that the MD5 hash has the exact same

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

https://bugs.documentfoundation.org/show_bug.cgi?id=114939 Julien Nabet changed: What|Removed |Added CC|

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

https://bugs.documentfoundation.org/show_bug.cgi?id=114939 --- Comment #5 from JimF --- The legacy busted code on import sounds correct. As long as it is only used upon a hash failure and upon any write the correct code is used to update the file. but that is way beyond the

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

https://bugs.documentfoundation.org/show_bug.cgi?id=114939 --- Comment #4 from Mike Kaganski --- Or keep both for import, trying old code in case correct one fails, but only write correct. -- You are receiving this mail because: You are the assignee for the

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

https://bugs.documentfoundation.org/show_bug.cgi?id=114939 --- Comment #3 from Mike Kaganski --- ... and that data will fail to be interoperable with other compliant suites. I suppose we should simply fix it and make a notice to use older versions in case of

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

https://bugs.documentfoundation.org/show_bug.cgi?id=114939 --- Comment #2 from JimF --- Looking at the endMD5(), I am almost certain it has the same bug. the bug comes from incrementing the i variable to point past the end of the non-null data in the limb, and then comparing it

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

https://bugs.documentfoundation.org/show_bug.cgi?id=114939 Caolán McNamara changed: What|Removed |Added Status|UNCONFIRMED |NEW