https://bugs.freedesktop.org/show_bug.cgi?id=48549
V Stuart Foote vstuart.fo...@utsa.edu changed:
What|Removed |Added
CC|
https://bugs.freedesktop.org/show_bug.cgi?id=48549
Björn Michaelsen bjoern.michael...@canonical.com changed:
What|Removed |Added
See Also|
https://bugs.freedesktop.org/show_bug.cgi?id=48549
Rainer Bielefeld libreoff...@bielefeldundbuss.de changed:
What|Removed |Added
CC|
https://bugs.freedesktop.org/show_bug.cgi?id=48549
Thomas Arnhold tho...@arnhold.org changed:
What|Removed |Added
Attachment #64966|0 |1
is
https://bugs.freedesktop.org/show_bug.cgi?id=48549
Thomas Arnhold tho...@arnhold.org changed:
What|Removed |Added
Status|REOPENED|RESOLVED
https://bugs.freedesktop.org/show_bug.cgi?id=48549
--- Comment #14 from Meko Otar meko.o...@gmail.com 2012-07-30 22:18:43 UTC ---
As Thomas Arnhold suggested, I've removed the following methods:
WinSalFrame::Beep
GtkSalFrame::Beep
X11SalFrame::Beep
SalDisplay::Beep
IosSalFrame::Beep
https://bugs.freedesktop.org/show_bug.cgi?id=48549
--- Comment #15 from Meko Otar meko.o...@gmail.com 2012-07-30 22:21:06 UTC ---
Created attachment 64966
-- https://bugs.freedesktop.org/attachment.cgi?id=64966
patch removing unnecessary beep related methods
--
Configure bugmail:
https://bugs.freedesktop.org/show_bug.cgi?id=48549
--- Comment #10 from Meko Otar meko.o...@gmail.com 2012-07-29 22:03:11 UTC ---
I've written a new patch cleaning remaining calls to Sound::Beep and unused
include. I've also removed sound.hxx and sound.cxx as they were no more used.
I've built
https://bugs.freedesktop.org/show_bug.cgi?id=48549
--- Comment #11 from Meko Otar meko.o...@gmail.com 2012-07-29 22:04:33 UTC ---
Created attachment 64931
-- https://bugs.freedesktop.org/attachment.cgi?id=64931
Patch for fdo#48549 System::Beep() removal v3
--
Configure bugmail:
https://bugs.freedesktop.org/show_bug.cgi?id=48549
--- Comment #12 from Thomas Arnhold tho...@arnhold.org 2012-07-30 03:17:46
UTC ---
Nice work! Pushed it. The remaining calls you noticed could be removed, as well
as the corresponding implementations, meaning:
WinSalFrame::Beep
https://bugs.freedesktop.org/show_bug.cgi?id=48549
Thomas Arnhold tho...@arnhold.org changed:
What|Removed |Added
Attachment #64931|0 |1
is
https://bugs.freedesktop.org/show_bug.cgi?id=48549
tbehr...@suse.com changed:
What|Removed |Added
Attachment #64453|0 |1
is obsolete|
https://bugs.freedesktop.org/show_bug.cgi?id=48549
Thomas Arnhold tho...@arnhold.org changed:
What|Removed |Added
Status|RESOLVED|REOPENED
https://bugs.freedesktop.org/show_bug.cgi?id=48549
Caolán McNamara caol...@redhat.com changed:
What|Removed |Added
Status|NEW |RESOLVED
https://bugs.freedesktop.org/show_bug.cgi?id=48549
Meko Otar meko.o...@gmail.com changed:
What|Removed |Added
Attachment #64387|0 |1
is obsolete|
https://bugs.freedesktop.org/show_bug.cgi?id=48549
--- Comment #6 from Meko Otar meko.o...@gmail.com 2012-07-20 15:43:20 PDT ---
Hi, I've sent a new patch where I've removed the the two unused parameters
mentioned by Thomas.
--
Configure bugmail:
https://bugs.freedesktop.org/show_bug.cgi?id=48549
--- Comment #2 from Meko Otar meko.o...@gmail.com 2012-07-19 11:30:58 PDT ---
Created attachment 64387
-- https://bugs.freedesktop.org/attachment.cgi?id=64387
Patch for fdo#48549 System::Beep() removal
--
Configure bugmail:
https://bugs.freedesktop.org/show_bug.cgi?id=48549
--- Comment #3 from Meko Otar meko.o...@gmail.com 2012-07-19 11:34:44 PDT ---
I've written a patch that remove all call to Sound::Beep. There is still some
warnings about unused parameters but I didn't wanted to change function
prototypes.
I'm
https://bugs.freedesktop.org/show_bug.cgi?id=48549
--- Comment #4 from Thomas Arnhold tho...@arnhold.org 2012-07-19 13:11:49 PDT
---
Hi Meko,
nice work! Looks good to me. Here are some unused parameters:
vcl/source/window/menu.cxx: The definition of nKeyCode is now unused (above
your removal).
https://bugs.freedesktop.org/show_bug.cgi?id=48549
Florian Reisinger reisi...@gmail.com changed:
What|Removed |Added
Status|UNCONFIRMED |NEW
Status
20 matches
Mail list logo
