[Libreoffice] splitrepos query

2010-10-07 Thread Caolán McNamara
Would *splitting* an existing dir/module across two repos would be a real pain or trivial ?, e.g. moving say just part of the java dir of libs-core/scripting out of from libs-core/scripting into something like extensions/scriptingproviders I've no immediate need to do that, just curious if it's a

Re: [Libreoffice] soltools build failure

2010-10-10 Thread Caolán McNamara
On Sun, 2010-10-10 at 20:30 +0200, Thomas Klausner wrote: Compiling: soltools/mkdepend/cppsetup.c gcc: ../unxbsdx3.pro/obj/cppsetup.o: No such file or directory dmake: Error code 1, while making '../unxbsdx3.pro/obj/cppsetup.obj' 1 module(s): soltools need(s) to be rebuilt Any

Re: [Libreoffice] ixion breakage in sw

2010-10-10 Thread Caolán McNamara
On Sat, 2010-10-09 at 07:29 +0200, Miklos Vajna wrote: Looks like some '-lixion' is missing from ldflags or so. Do you have an idea what's going on? :) No idea, but I can tell that the ixion stuff isn't committed directly to the split repos, but is still as patches that get applied in one of

Re: [Libreoffice] Error Building, vcl segmentation fault

2010-10-10 Thread Caolán McNamara
On Sun, 2010-10-10 at 16:33 +0200, julien wrote: make Making:libvclplug_kdeli.so Segmentation fault dmake: Error code 1, while making '../unxlngi6.pro/lib/libvclplug_kdeli.so' An odd one, if you run make again does it break in the same place ? doing export VERBOSE=true before running

Re: [Libreoffice] [SCRIPT, EASYHACK] add-modelines, a script to add modelines to source files

2010-10-11 Thread Caolán McNamara
On Mon, 2010-10-11 at 01:30 -0600, Tor Lillqvist wrote: as well. It was the vim one at the bottom I was interested in. I don't think (though I'm open to correction) that emacs reads mode lines unless they are the start of the file, so those lines don't do anything. See

Re: [Libreoffice] [PATCH] ure/offapi/com/sun/star/document: Fix some typos in documentation

2010-10-11 Thread Caolán McNamara
On Mon, 2010-10-11 at 14:44 +0200, Thorsten Behrens wrote: Noel Power wrote: who should update http://www.openoffice.org/issues/show_bug.cgi?id=112563 but, should it be updated ? This is an excellent question ( and one I have asked myself about a different situation ) Unfortunately I

[Libreoffice] STLPort vs gcc STL performance

2010-10-12 Thread Caolán McNamara
There was a little discussion about gcc's STL vs STLPort from the perspective of performance, so I ported the test-suite at http://askldjd.wordpress.com/2010/07/24/stl-performance-comparison-round-2-vc9-vc10-stlport/ from windows to Linux and compared my x86_64 gcc 4.5.1's STL to the in-tree

Re: [Libreoffice] Error Building, vcl segmentation fault

2010-10-13 Thread Caolán McNamara
On Tue, 2010-10-12 at 22:30 +0200, julien wrote: Thread 1 (Thread 0xb7d276d0 (LWP 7585)): #0 0xb68061db in _STL::locale::locale() () from /usr/lib/libstlport_gcc.so.4.6 #1 0xb67d1414 in _STL::ios_base::ios_base() () from /usr/lib/libstlport_gcc.so.4.6 #2 0xb67e3a41 in

[Libreoffice] unable to create 'refs/heads/master.lock' in libs-extern-sys

2010-10-13 Thread Caolán McNamara
So, messages are... [libs-extern-sys]$ git push Counting objects: 75, done. Delta compression using up to 8 threads. Compressing objects: 100% (50/50), done. Writing objects: 100% (50/50), 14.41 KiB, done. Total 50 (delta 31), reused 0 (delta 0) fatal: unable to create 'refs/heads/master.lock':

Re: [Libreoffice] [PATCH] ww8graf.cxx: Translate German comments

2010-10-13 Thread Caolán McNamara
On Wed, 2010-10-13 at 17:24 +0200, Sebastian Spaeth wrote: While I was reading that function anyway to find a crasher. Pushed, your crasher is fixed too. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] C{,PP}FLAGS ignored in sal

2010-10-14 Thread Caolán McNamara
On Thu, 2010-10-14 at 08:37 +0200, Thomas Klausner wrote: On Wed, Oct 13, 2010 at 05:25:59PM +0200, Thomas Klausner wrote: I don't see my CFLAGS nor CPPFLAGS, which would make it find boost, in the gcc arguments. How can I make them used in this part of the build? I don't think we have any

Re: [Libreoffice] Error Building, vcl segmentation fault

2010-10-14 Thread Caolán McNamara
On Thu, 2010-10-14 at 10:04 +0100, Michael Meeks wrote: Nasty - so we could be in the position of choosing between KDE integration, and extension/plugin compatibility ? If there *is* something in the KDE headers which replies on the native STL which is triggering this, which I'm not

Re: [Libreoffice] unable to create 'refs/heads/master.lock' in libs-extern-sys

2010-10-14 Thread Caolán McNamara
On Wed, 2010-10-13 at 20:49 +0100, Caolán McNamara wrote: fatal: unable to create 'refs/heads/master.lock': File exists fatal: The remote end hung up unexpectedly This is cleared now, dunno if someone helped out, or if the lock got deleted automatically after some timeout. C

Re: [Libreoffice] Error Building, vcl segmentation fault

2010-10-14 Thread Caolán McNamara
On Wed, 2010-10-13 at 22:30 +0200, julien wrote: Thread 1 (Thread 0xb7d276d0 (LWP 15195)): #0 0xb68061db in _STL::locale::locale() () from /usr/lib/libstlport_gcc.so.4.6 #1 0xb67d1414 in _STL::ios_base::ios_base() () from /usr/lib/libstlport_gcc.so.4.6 #2 0xb67e3a41 in

Re: [Libreoffice] LO: Linux distro specific packages vs. universal build

2010-10-14 Thread Caolán McNamara
On Thu, 2010-10-14 at 16:45 +0200, Petr Mladek wrote: Hi, I think about what package names and paths use for the openSUSE LibreOffice packages. I wonder how they should conflict with the universal Linux Libre Office build and what they should share with it. +

Re: [Libreoffice] [LibreOffice][PATCH] compiler warnings inftxt.hxx

2010-10-18 Thread Caolán McNamara
On Sat, 2010-10-16 at 01:01 +0200, Kenneth Venken wrote: some shadows a member of 'this' and unused parameter warnings. The binfilter is rather unloved, its effectively a copy of older versions of sw/sd/sc and their dependencies, so if you see a warning in binfilter and want to fix it, you can

Re: [Libreoffice] boost exceptions

2010-10-18 Thread Caolán McNamara
On Sun, 2010-10-17 at 23:36 +0200, Thomas Klausner wrote: As you can see, I already added -fexceptions to the g++ arguments. Why did you add -fexceptions to the arguments ?, I ask because there are places in LibreOffice where its explicitly enabled, and others where its explicitly disabled, so

Re: [Libreoffice] boost exceptions

2010-10-18 Thread Caolán McNamara
On Mon, 2010-10-18 at 12:54 +0200, Thomas Klausner wrote: On Mon, Oct 18, 2010 at 11:14:25AM +0100, Caolán McNamara wrote: Why did you add -fexceptions to the arguments ?, I ask because there are places in LibreOffice where its explicitly enabled, and others where its explicitly disabled

Re: [Libreoffice] boost exceptions

2010-10-18 Thread Caolán McNamara
On Mon, 2010-10-18 at 13:15 +0200, Thomas Klausner wrote: On Mon, Oct 18, 2010 at 12:01:15PM +0100, Caolán McNamara wrote: Did you configure with --with-system-boost ? There's a test in configure.in for a broken boost header. Yes, I'm using system boost. I know you're using system boost

Re: [Libreoffice] [PATCH] shutdownicon.cxx: rename getDotAutostart() - getAutostartDir()

2010-10-20 Thread Caolán McNamara
On Wed, 2010-10-20 at 13:11 +0200, Sebastian Spaeth wrote: I was puzzled by the name and the new one is much clearer. Also add proper documentation to that function as to what it does and what the params mean. All callers have been adapted to the new name. Look ok to me, committed + pushed.

Re: [Libreoffice] Building on windows 7-64bit with Visual Studio 2010 Express

2010-10-20 Thread Caolán McNamara
On Tue, 2010-10-19 at 22:46 +0100, Martin Gallwey wrote: Okay! Most of the battle so far was figuring out what cygwin packages to install and how to get the correct cygdrive paths - can someone add a windows section to http://www.freedesktop.org/wiki/Software/LibreOffice/HowToBuild with the

Re: [Libreoffice] [PATCH] Fix for #i93300#: Crash when inserting 32 bit TIFF image

2010-10-20 Thread Caolán McNamara
On Tue, 2010-10-19 at 20:25 +0300, Harri Pitkänen wrote: This patch has been tested on a 64 bit Linux system using the samples in the bug and some images from libtiff sample collection at ftp://ftp.remotesensing.org/pub/libtiff/pics-3.8.0.tar.gz I ran through this one, and yeah fixes a pile of

Re: [Libreoffice] [Patch] SAL_N_ELEMENTS Easy Hack

2010-10-21 Thread Caolán McNamara
Great thanks, applied and pushed. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] damaged file: sysui's dummy/localize.sdf

2010-10-21 Thread Caolán McNamara
On Thu, 2010-10-21 at 02:32 -0400, Kevin Hunter wrote: Hullo List, I'm a noob to compiling LO, and am having a difficult time compiling it. I've done well enough so far by just waiting and the using the 'bin/g pull -r' tidbit. But this error seems to be recurring, and I can't

Re: [Libreoffice] [Patch] Several comment translations in svx/inc

2010-10-21 Thread Caolán McNamara
On Wed, 2010-10-20 at 22:29 +0200, Wolfgang Silbermayr wrote: I started translating comments in svx/inc from german to english. All files directyl in svx/inc have been translated and the files in svx/inc/svx from AccessibleControlShape.hxx to sdtaitm.hxx in alphabetical order. You can

Re: [Libreoffice] how can we import/export .cbz/.cbr files on LibreOffice Impress?

2010-10-21 Thread Caolán McNamara
On Wed, 2010-10-20 at 19:59 -0300, Joop Kiefte wrote: One feature in here (that I really liked about the newest powerpoint) is the ease to fill slides with just photo's. A coworker of mine wrote a photoalbum extension some while ago, e.g.

Re: [Libreoffice] [PATCH] Created installer::languages::shorten_language_string

2010-10-21 Thread Caolán McNamara
On Wed, 2010-10-20 at 08:20 -0700, Sean McMurray wrote: Replaced similar code in other loactions to point to here. Used Digest::MD5 instead of spawning a separate os process. A get a syntax error in there, i.e. installer: vs installer:: and I also get an uninitialized value $_ in scalar chomp

Re: [Libreoffice] [PATCH] Filters - Clean up comments in sw_unosett.cxx

2010-10-21 Thread Caolán McNamara
On Thu, 2010-10-21 at 00:37 +0100, jgraeme wrote: A patch to clean up comments. Oky doky, looks good, committed and pushed, thanks. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] update on OSL_LOG_PREFIX macro issue

2010-10-21 Thread Caolán McNamara
On Thu, 2010-10-21 at 16:08 +0200, Thomas Klausner wrote: Hi again, I've patched the OSL_LOG_PREFIX macro (see diff in previous mail) but now the compilation falls over in Entering /build/libreoffice-3.2.99.2/sfx2/source/doc Compiling: sfx2/source/doc/objmisc.cxx g++

Re: [Libreoffice] Quick Patch to Fix sfx2 compile error

2010-10-21 Thread Caolán McNamara
On Thu, 2010-10-21 at 07:36 -0700, Joseph Powers wrote: Not sure why no one else noticed this... com::sun::star:: was missing on two entries Possibly some koenig lookup or something similar failure in the compiler IMO. i.e. there's a using namespace ::com::sun::star; at the top of the file,

Re: [Libreoffice] [PATCH] sfx2: Simplify About dialog

2010-10-22 Thread Caolán McNamara
On Fri, 2010-10-22 at 11:22 +0200, Sebastian Spaeth wrote: Removed lots of code that was supposed to do scrolling in the about dialog. But the scolling in the about dialog is one of those cunning neato sort of easter egg things. Go to the about box and hold CTRL and type sdt. I'd be sad to

Re: [Libreoffice] [PATCH] remove pam in writer sw

2010-10-22 Thread Caolán McNamara
On Thu, 2010-10-21 at 06:42 +0200, Nadav Vinik wrote: remove pam in writer sw Thorsten applied this one I see, always good to remove includes of headers which aren't necessary to compile. Though just in case there's any confusion, pam.hxx in writer is the header for the Point and Mark class,

Re: [Libreoffice] build failure loading pythonloader.uno.so

2010-10-24 Thread Caolán McNamara
On Sun, 2010-10-24 at 01:26 +0200, Thomas Klausner wrote: I used build with the variable set for my original error and got: /build/libreoffice-3.2.99.2/solenv/bin/gdbtrycatchtrace:2: Error in sourced command file: Function __cxa_throw not defined. This sucks, looks like catch throw and

Re: [Libreoffice] easy task c++ to do

2010-10-24 Thread Caolán McNamara
On Sun, 2010-10-24 at 11:48 +0200, Joost Eekhoorn wrote: Hi, How can I contribute with an easy task? Well, you just have ;-). Mailing the patches to the list is perfectly fine. Our list of easy tasks are at http://wiki.documentfoundation.org/Easy_Hacks as you've already seen and comment

Re: [Libreoffice] Image Compression Patch

2010-10-24 Thread Caolán McNamara
On Fri, 2010-10-22 at 11:47 +0100, Andrew C. E. Dent wrote: Hi Kendy I've finished the process of lossless optimization for the default_images pack. What is the process btw, are you using some command line tools to do it which could be scripted. Or opening them up manually in a graphics

Re: [Libreoffice] oox compile failure ...

2010-10-25 Thread Caolán McNamara
On Mon, 2010-10-25 at 15:52 +0100, Michael Meeks wrote: I just got this: Compiling: oox/source/ppt/timenodelistcontext.cxx Making:ppt.lib Compiling: oox/source/ppt/dgmimport.cxx In file included from

Re: [Libreoffice] smoketest segfault

2010-10-25 Thread Caolán McNamara
On Sun, 2010-10-24 at 22:03 -0500, Norbert Thiebaud wrote: I have a segfault running smoketest. Its cold comfort, but smoketest works for me ok. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] First build error: segmentation fault on vcl

2010-10-26 Thread Caolán McNamara
On Mon, 2010-10-25 at 17:41 -0700, Dave Lacy Kusters wrote: I hit an error on my first compile that I haven't seen discussed in the archive or elsewhere online. See this thread: http://www.mail-archive.com/libreoffice@lists.freedesktop.org/msg00219.html I don't know why exactly this is

Re: [Libreoffice] yum-builddep question ...

2010-10-26 Thread Caolán McNamara
On Tue, 2010-10-26 at 02:32 -0400, Terrell Prude' Jr. wrote: Terrell Prude' Jr. wrote: Michael Meeks wrote: Glad to test, but a little tip would help. My other boxes, including the one I'm on now, are all running CentOS 5, and the yum-builddep openoffice.org command returns no

[Libreoffice] run tinderbox script in an English locale

2010-10-26 Thread Caolán McNamara
Any chance we could tweak the tinderbox build to run under export LANG=C or en_US or something. Getting build errors in Czech is a bit tricky for me. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[Libreoffice] rtl_uString/rtl::OUString and osl_getCommandArg

2010-10-26 Thread Caolán McNamara
FWIW rtl_uString * pFoo; osl_getCommandArg(0, pFoo); is a bit unsafe, this should at least be... rtl_uString * pFoo = 0; osl_getCommandArg(0, pFoo); But note that you have to call rtl_uString_release on that pFoo at some stage or its a memleak. Far easier altogether when in c++ code is to use

Re: [Libreoffice] howto for getting non-trivial cppunit tests up and running

2010-10-26 Thread Caolán McNamara
On Mon, 2010-10-25 at 21:58 -0400, Kohei Yoshida wrote: On Wed, 2010-10-20 at 20:44 +0100, Caolán McNamara wrote: So the sc test, while working reliably for me, is apparently not working for Kohei and others So, I came home and did a clean re-build of the latest source tree on my

Re: [Libreoffice] smoketest segfault

2010-10-28 Thread Caolán McNamara
On Wed, 2010-10-27 at 17:07 -0500, Norbert Thiebaud wrote: /lo/ref/rawbuild/solver/330/unxlngx6.pro/installation/opt/program/soffice: Isn't really useful to just get it crashed, so... in solenv/inc/settings.mk add gdb --args after AUGMENT_LIBRARY_PATH_LOCAL in the CPPUNITTESTER line run build

Re: [Libreoffice] howto for getting non-trivial cppunit tests up and running

2010-10-28 Thread Caolán McNamara
On Thu, 2010-10-28 at 11:17 +0200, Thorsten Behrens wrote: Caolan McNamara wrote: register component 'configmgr.uno.so' in registry '../../unxlngx6.pro/misc/qa_unit/services.rdb' failed! error (CannotRegisterImplementationException): loading component library failed:

[Libreoffice] [FIXED] First build error: segmentation fault on vcl

2010-10-29 Thread Caolán McNamara
On Fri, 2010-10-29 at 10:08 +0100, Caolán McNamara wrote: So, the question is, where's /usr/lib coming from in the ENABLE_KDE case, and can it be stuffed to the *end* of the compiler line and not the start. I don't build against KDE, but I guess I could make an exception for once and go see

[Libreoffice] [PUSHED] Re: [PATCH] Fix comments in filters/xmerge

2010-10-29 Thread Caolán McNamara
On Thu, 2010-10-28 at 13:33 +0100, Nigel Hawkins wrote: Hi, My first try at this. I'm still trying to get my head around git, so I hope I've made the patches correctly. They appear good to me, they definitely apply correctly :-) Then I noticed warnings that could be fixed by only touching

Re: [Libreoffice] How to write debug output to console or file?

2010-10-29 Thread Caolán McNamara
On Fri, 2010-10-29 at 09:52 +0200, Cedric Bosdonnat wrote: The problem here is to get a C string from them: here are some examples: * from OUString: rtl::OUStringToOString( sOUStr, RTL_TEXTENCODING_UTF8 ).getStr() * from String / UniString ByteString( sToolStr,

Re: [Libreoffice] Windows dependancies

2010-10-29 Thread Caolán McNamara
On Thu, 2010-10-21 at 21:19 +0100, Martin Gallwey wrote: Hi there! Just working further on getting a working build up and running, there are a bunch of files needed to get a build running, namely, these? Looking for /cygdrive/c/lo/src/msvcr80.dll ... ok Looking for

Re: [Libreoffice] Windows dependancies

2010-10-29 Thread Caolán McNamara
On Fri, 2010-10-29 at 07:41 -0600, Tor Lillqvist wrote: i.e. a script that downloads the installers, runs them and let the end-user click-through any relevant EULAs ? Do you really mean the LibreOffice end-user here? No I think what was wanted for us to have the files that are put

Re: [Libreoffice] Easy Hack solved: Remove mid-file emacs modelines

2010-10-29 Thread Caolán McNamara
On Fri, 2010-10-29 at 13:28 -0300, Joop Kiefte wrote: The wiki is Mediawiki, isn't it? Mediawiki has version-control/history. yes, but that's not really for reading, so I suggest it would be helpful to quickly scan back over the mediawiki history/version control and note the tasks which got

Re: [Libreoffice] Writer compatibility dialog options

2010-10-30 Thread Caolán McNamara
On Sat, 2010-10-30 at 12:34 +0200, Cor Nouws wrote: Hi Ron, Ron Faile wrote (30-10-10 02:36) All, I'm working on updating the documentation for Writer. Noticed that on the Options - LibreOffice Writer - Compatibility dialog, some options have OpenOffice.org 1.1 in the name. LibO 3.3

[Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro

2010-10-30 Thread Caolán McNamara
On Sat, 2010-10-30 at 17:08 +0200, Gert Faller wrote: Hi, a first try on that. Excellent, these are little mini-optimizations and they all help. Not sure if I let the original source (for control) Nah, don't bother keeping the old content as a comment, we can look at the git history to see

Re: [Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro

2010-10-30 Thread Caolán McNamara
On Sat, 2010-10-30 at 18:16 +0200, Gert Faller wrote: I've got 2388 files with 'createFromAscii'. That's a lot. The wiki says that this macro is 'faster'. Does it mean at running time ? Yes, ever so slightly, sal/inc/rtl/ustring.hxx has OUString::createFromAscii in it, and that calls

Re: [Libreoffice] [PATCH] cppcheck Common realloc mistake

2010-10-30 Thread Caolán McNamara
On Sat, 2010-10-30 at 17:26 +0200, Gert Faller wrote: Hi, The two cppcheck warnings in 'libs-core' about 'realloc'. Not sure about that : what to do on NULL ? There are others, for example in : 'sdk/odk/source/unoapploader/unx/unoapploader.c' but with 'exit(EXIT_FAILURE)' on NULL. Hmm,

[Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro bis

2010-10-30 Thread Caolán McNamara
On Sat, 2010-10-30 at 22:23 +0200, Gert Faller wrote: Hi, here are some more of them. Great, thanks. Looking at this createFromAscii_4.patch reminds me of something else. Nothing to do with you, the code was this way already, but rtl::OUString foo =

[Libreoffice] [PUSHED] Re: [PATCH] Include header file

2010-10-30 Thread Caolán McNamara
On Sat, 2010-10-30 at 21:04 +0300, Jani Monoses wrote: Just like the other .cxx files in starmath, make this one include unomodel.hxx and get the definition of the A2OU macro from there instead of redefining it. Doesn't hurt, so pushed, thanks. Looking at the A2OU define I see that it's just

[Libreoffice] [PUSHED] Re: [PATCH] EasyHack RTL_CONSTASCII_USTRINGPARAM in starmath

2010-10-30 Thread Caolán McNamara
On Sat, 2010-10-30 at 21:01 +0300, Jani Monoses wrote: Hello, This changes the only occurrence in writer/starmath. Thanks, Hmm, an empty string. I wonder why it using ::createFromAscii for the empty string case. I suggest that... +_GetNamespaceMap().Add( OUString(),

Re: [Libreoffice] Bug Triage Process

2010-10-30 Thread Caolán McNamara
On Thu, 2010-10-21 at 04:36 -0600, Muthu Subramanian wrote: Hi, I wrote a simple wiki for bug triage process, http://wiki.documentfoundation.org/BugTriage as a starting point. This would help anyone who is looking at doing bug triage for the LibreOffice bugzilla. Looks good, I'd like to

[Libreoffice] [PUSHED]Re: [PATCH] EasyHack RTL_CONSTASCII_USTRINGPARAM in desktop

2010-10-31 Thread Caolán McNamara
On Sun, 2010-10-31 at 11:56 +0100, Joost Eekhoorn wrote: MPL 1.1 / GPLv3+ / LGPLv3+ Excellent, pushed, thanks. About coding conventions: In /desktop/source/app/dispatchwatcher.cxx starts with using ::rtl::OUString; and then there are: ::rtl::OUString rtl::OUString OUString What is the

[Libreoffice] [PUSHED] Re: EasyHack RTL_CONSTASCII_USTRINGPARAM in cui

2010-10-31 Thread Caolán McNamara
On Sun, 2010-10-31 at 15:37 +0100, Joost Eekhoorn wrote: MPL 1.1 / GPLv3+ / LGPLv3+ All good, committed and pushed, thanks :-) In ./cui/source/tabpages/numpages.cxx (line 2852): String sMsg( RTL_CONSTASCII_USTRINGPARAM( Preview) ); Should that not be RTL_CONSTASCII_STRINGPARAM, because

[Libreoffice] [PUSHED]Re: [PATCH] EasyHack RTL_CONSTASCII_USTRINGPARAM 3

2010-10-31 Thread Caolán McNamara
On Sun, 2010-10-31 at 13:41 +0100, Gert Faller wrote: Hi, I'am not sure of my previous mail... This looks good. I pushed this patch as well. I see (again this was already there and not added by your patch) a few rather odd rtl::OUString sEmpty(OUString::createFromAscii()) in there to create

Re: [Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro bis

2010-10-31 Thread Caolán McNamara
On Sat, 2010-10-30 at 22:08 +0100, Caolán McNamara wrote: old: OUString sFoo(OUString::createFromAscii(bBool ? true : false)); new: OUString sFoo(RTL_CONSTASCII_USTRINGPARAM(bBool ? true : false)); would be expanded as... OUString sFoo(bBool ? true : false, ((sal_Int32)(sizeof(bBool

[Libreoffice] [PUSHED] Re: EasyHack RTL_CONSTASCII_USTRINGPARAM in sc

2010-10-31 Thread Caolán McNamara
On Sun, 2010-10-31 at 21:18 +0100, Joost Eekhoorn wrote: MPL 1.1 / GPLv3+ / LGPLv3+ Excellent, all good. Thanks for the stylistic improvement in cFA_joost_5.patch while you were adding the RTL_CONSTASCII_USTRINGPARAM's :-) C. ___ LibreOffice mailing

Re: [Libreoffice] Building on CentOS 5

2010-11-01 Thread Caolán McNamara
On Mon, 2010-11-01 at 01:03 -0400, Terrell Prude' Jr. wrote: - gperf - libXaw-devel - GConf2-devel - gnome-vfs2-devel Added these to the wiki. There is also one I'm not sure how to satisfy within CentOS 5's packaging. This would be Qt4. Here are the messages from make. Does

Re: [Libreoffice] build or rawbuild dir?

2010-11-01 Thread Caolán McNamara
On Mon, 2010-11-01 at 09:27 +0100, Sebastian Spaeth wrote: On Fri, 29 Oct 2010 21:41:26 +0100, Michael Meeks michael.me...@novell.com wrote: ...post the branch / freeze over the weekend... May I nag a little? Besides some rumours I did not know anything about a branching over the weekend

Re: [Libreoffice] suspect code in extentions/sdext/source/presenter/PresenterClock.cxx

2010-11-01 Thread Caolán McNamara
On Sun, 2010-10-31 at 23:04 -0500, Norbert Thiebaud wrote: ::osl::MutexGuard aSolarGuard (::osl::Mutex::getGlobalMutex()); Paint(rEvent.UpdateRect); I'm thinking I should change this guard with a SolarMutexGuard aSolarGuard; Someone has an opinion on this ? Because it's protecting

Re: [Libreoffice] [Review Request] remove a confusing use of GetMutex() when a SolarMutexGuard is really meant

2010-11-01 Thread Caolán McNamara
On Sun, 2010-10-31 at 23:07 -0500, Norbert Thiebaud wrote: The attached patches are pending... I am submitting them to the list for comments or objections before pushing them. Looks reasonable to me anyway, most of this is in toolkit, maybe Thorsten can have a double-check of that as I'd guess

[Libreoffice] [PUSHED] Re: [PUSHED, partially] Re: [PATCH] cppcheck Common realloc mistake

2010-11-01 Thread Caolán McNamara
On Mon, 2010-11-01 at 09:02 +0100, Gert Faller wrote: I was just wondering if freeing some bytes was worth while. A patch for this... re: realloc_patch_3.patch Yeah, it's probably a bit expensive to realloc in order to drop a tiny amount of bytes, but its an unlikely code path anyway so patch

Re: [Libreoffice] Bug Triage Process

2010-11-01 Thread Caolán McNamara
On Mon, 2010-11-01 at 11:29 +0100, Sophie Gautier wrote: Also, I would like to help on closing some issues that are fixed. Is it ok if I check them against a build provided by Cedric some days ago, or is it better to wait for the next beta? I reckon you can go ahead and close anything that you

Re: [Libreoffice] howto for getting non-trivial cppunit tests up and running

2010-11-01 Thread Caolán McNamara
On Thu, 2010-10-28 at 13:21 +0100, Caolán McNamara wrote: Hmm, sort of looks like the underlying cppu stuff, or something it uses, got pulled out from under it during the test. I don't think it could have gotten that far for the uno::sequence dtor (which looks up the type of its argument

Re: [Libreoffice] suspect code in extentions/sdext/source/presenter/PresenterClock.cxx

2010-11-01 Thread Caolán McNamara
On Mon, 2010-11-01 at 10:54 +0100, David Tardon wrote: Yes, but the situation here is different. The Paint method is actually defined in the same class and has nothing in common with VCL's Window::Paint. The actual painting is done through Canvas. Can anyone convince me that its not cargo-cult

Re: [Libreoffice] Apple Java update on Mac OSX breaks all java functionality in LibO - Issue 115180

2010-11-01 Thread Caolán McNamara
On Sun, 2010-10-24 at 21:35 +0200, Alexander Thurgood wrote: Hi all, Just a heads up coz I don't know whether you've heard about this yet. Reported in Issue 115180 on OOo Issue Tracker. The problem also affects LibO in its latest incarnations. The fix for this of issuezill#115180 is now

Re: [Libreoffice] [PATCH] bootstrap: disable-binfilter in inner configure by default

2010-11-01 Thread Caolán McNamara
On Mon, 2010-11-01 at 17:11 +0100, Sebastian Spaeth wrote: Currently the deprecated binfilter are build by default as the inner configure explicitely requires --disable-binfilter to get rid of them. This patch defaults to disabled and require --enable-binfilter to turn them on. Ran configure

Re: [Libreoffice] [PUSHED] Re: (no subject)

2010-11-01 Thread Caolán McNamara
On Mon, 2010-11-01 at 21:06 +0100, Rene Engelhard wrote: Hi, On Mon, Nov 01, 2010 at 10:11:07AM +, Caolán McNamara wrote: caolanm-rene: Think we should use AS_HELP_STRING everywhere ? Yeah. Good idea. Sounds like a easy hack :) oky doky, added as an easy hack. caolanm-ronkko

[Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro 4

2010-11-01 Thread Caolán McNamara
On Mon, 2010-11-01 at 20:28 +0100, Gert Faller wrote: Hi, more of that... Mostly good, though createFromAscii_7.patch has... OUString::createFromAscii( GetWindowState( WINDOWSTATE_MASK_POS ).GetBuffer() ) ); that one can't be changed to use RTL_CONSTASCII_USTRINGPARAM because

Re: [Libreoffice] [PUSHED] EasyHack RTL_CONSTASCII_USTRINGPARAM in sc

2010-11-02 Thread Caolán McNamara
On Mon, 2010-11-01 at 22:27 -0400, Kohei Yoshida wrote: Hello Joost, Thanks for the patch. Just pushed to the master branch. :-) Nothing to do with the patch, but I see a ConvertCountryCode which, depending on what it does, might be a candidate to be moved into i18npool/source/isolang beside

Re: [Libreoffice] LibreOffice and Java

2010-11-02 Thread Caolán McNamara
On Wed, 2010-10-20 at 01:50 +0200, Cesare Leonardi wrote: Hi all. There's a thing not clear to me and that involved go-oo too: the relationship between LibreOffice and Java. Here i'm referring to the Windows environment but under Linux/Mac should be the same. Java isn't provided with

Re: [Libreoffice] [PATCH] bootstrap: disable-binfilter in inner configure by default

2010-11-02 Thread Caolán McNamara
On Mon, 2010-11-01 at 12:27 -0500, Norbert Thiebaud wrote: The only draw-back its that even less people will build it, which means that breakage will go unnoticed longer (and yes it is possible to break binfilter without touching it -- been there, done that :-) ) That's the only reason I have

[Libreoffice] [PUSHED] Re: EasyHack RTL_CONSTASCII_USTRINGPARAM in sc

2010-11-02 Thread Caolán McNamara
On Tue, 2010-11-02 at 20:43 +0100, Joost Eekhoorn wrote: MPL 1.1 / GPLv3+ / LGPLv3+ All look good, thanks, now pushed :-) C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro 7

2010-11-02 Thread Caolán McNamara
On Tue, 2010-11-02 at 18:44 +0100, Gert Faller wrote: Hi, with this one, module 'impress' should be rather clean of that. Heh, good, liked the ? : rework to keep me pacified :-). Thanks for this. As an aside, stylistically I'd prefer rtl::OUString sFoo(RTL_CONSTASCII_USTRINGPARAM(apple));

Re: [Libreoffice] [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro 6

2010-11-02 Thread Caolán McNamara
On Tue, 2010-11-02 at 17:31 +0100, Gert Faller wrote: Hi, some more in impress Pushed, thanks for this again. Sure beats doing it myself :-) C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] PATCH: Add Tower labels

2010-11-03 Thread Caolán McNamara
On Wed, 2010-11-03 at 13:50 +0200, Dwayne Bailey wrote: We made this patch for Translate.org.za builds of OpenOffice.org. Tower is a label manufacturer in South Africa. The bug: http://www.openoffice.org/issues/show_bug.cgi?id=113803 The patch:

Re: [Libreoffice] LibreOffice and Java

2010-11-03 Thread Caolán McNamara
On Tue, 2010-11-02 at 14:30 +0100, Cedric Bosdonnat wrote: On Tue, 2010-11-02 at 12:47 +, Michael Meeks wrote: Quite; cf. such uncertainty - it probably makes considerable sense to look into a migration strategy from Java to (insert anything else). Some candidates might be python

[Libreoffice] [PUSHED] Re: PATCH: Add Tower labels

2010-11-03 Thread Caolán McNamara
On Wed, 2010-11-03 at 14:04 +, Caolán McNamara wrote: Done, for master, do we want this for 3.3 as well ? remail with PUSHED to make this thread easier to skip by subject :-) C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

[Libreoffice] [PUSHED] Re: [PATCH] Pretty print the configure help options with AS_HELP_STRING

2010-11-03 Thread Caolán McNamara
On Wed, 2010-11-03 at 14:59 +0200, Niko Rönkkö wrote: Use AS_HELP_STRING autoconf macro when suitable. Line feeds aren't possibles with AS_HELP_STRING. Alignment of configure --help looks right to me, pushed, thanks :-). Could you edit the wiki and move that easy hack to the completed page ?

Re: [Libreoffice] build failure in dbaccess/qa/complex/dbaccess

2010-11-03 Thread Caolán McNamara
On Mon, 2010-11-01 at 22:53 +0100, Thomas Klausner wrote: /usr/pkg/java/openjdk7/bin/javac -source 1.5 -target 1.5 -classpath

[Libreoffice] [PUSHED] Re: [PATCH] Fix a couple of simple compiler warnings

2010-11-03 Thread Caolán McNamara
On Wed, 2010-11-03 at 16:27 +, Nigel Hawkins wrote: Hi, A couple of simple one-line patches to remove a couple of compiler warnings (format not a string literal and no format arguments). All look good to me, much thanks. Pushed. c. ___

[Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro 8

2010-11-03 Thread Caolán McNamara
On Wed, 2010-11-03 at 17:16 +0100, Gert Faller wrote: Hi, this may be the last for module 'writer'. Excellent, all pushed, thanks. Remains 'sw/source/ui/vba/vbacheckbox.cxx:78'. When I google I find : #define ECMA_FORMCHECKBOX_CHECKED checked in '/xmloff/inc/xmloff/ecmaflds.hxx' but

Re: [Libreoffice] Building on CentOS 5

2010-11-04 Thread Caolán McNamara
On Wed, 2010-11-03 at 22:16 -0400, Terrell Prude' Jr. wrote: Two more. - cups-devel - gstreamer-plugins-base-devel Added to the wiki, feel free to add any other ones yourself to the list at http://wiki.documentfoundation.org/Development/How_to_build C.

Re: [Libreoffice] FOO_GTK error when running autogen.sh

2010-11-04 Thread Caolán McNamara
On Wed, 2010-11-03 at 16:28 -0400, Terrell Prude' Jr. wrote: Just checked. Looks like the file is there. Here's an ls -l, and the contents of the file. What's the output of... pkg-config --cflags --modversion gtk+-2.0 echo PKG_CONFIG_PATH= $PKG_CONFIG_PATH uname -m because 64bit

Re: [Libreoffice] [PATCH 3/3] use linux bridge code on all BSDs

2010-11-04 Thread Caolán McNamara
On Thu, 2010-11-04 at 14:06 +0100, Robert Nagy wrote: Share the linux bridge code with all the BSDs to avoid code duplication and the hassle of syncing. I'm totally in favour of this, especially as I know we fixed bugs in the Linux x86_64 uno bridge, and I strongly doubt those fixes got merged

Re: [Libreoffice] Problem with sal/cppunittester

2010-11-05 Thread Caolán McNamara
On Fri, 2010-11-05 at 21:10 +, Wols Lists wrote: Just doing an emerge cppunit. It shouldn't be necessary to use system cppunit, cppunit should be built as part of the build. So, lets just document debugging this... sal/cppunittester/makefile.mk has APP1STDLIBS = $(CPPUNITLIB) $(SALLIB)

Re: [Libreoffice] [PUSHED] Re: [PATCH] use linux bridge code on all BSDs

2010-11-06 Thread Caolán McNamara
On Sat, 2010-11-06 at 00:16 +0100, Thomas Klausner wrote: Pushed, thanks! Something of a historic moment when Linux, OpenBSD, FreeBSD and NetBSD unify something :-) C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] Problem with sal/cppunittester

2010-11-06 Thread Caolán McNamara
On Fri, 2010-11-05 at 21:36 +, Caolán McNamara wrote: so apparently for some reason having *two* lines with symlink: in it with the same target breaks (which is news to me). Someone should have a look at deliver in the solenv to find what it does on seeing a symlink: line and try and fix

Re: [Libreoffice] Duplicate ids in 'writer/sw/inc/cmdid.h'

2010-11-06 Thread Caolán McNamara
On Sat, 2010-11-06 at 00:25 +0100, Gert Faller wrote: Hi, just wondering if someone knows why there are duplicate ids in 'writer/sw/inc/cmdid.h' (FN_FORMAT + 129) , (FN_FORMAT + 130), (FN_FORMAT + 131) at line 537. Hmm, one of the + 129 is FN_NEW_PAGE_STYLE and appears (according to

Re: [Libreoffice] [PATCH] Adapt LibreOffice branding in LibO-SDK user installation script.

2010-11-08 Thread Caolán McNamara
On Fri, 2010-11-05 at 15:30 +0100, Giuseppe Castagno wrote: Hi all, I tried to install the LibO-SDK as generated in my build from master, and I noted that has some link/mingling with OOo. Looks good, pushed to head and I cherrypicked it for Libo 3.3 as well C.

Re: [Libreoffice] Questions about ./sdext/source/minimizer/unodialog.cxx

2010-11-08 Thread Caolán McNamara
On Sun, 2010-11-07 at 12:33 -0600, Norbert Thiebaud wrote: On Sun, Nov 7, 2010 at 7:00 AM, julien serval2...@yahoo.fr wrote: the if() can only be true if that value is not 0 so here you have a false positive. Julien, could you log a bug against cppcheck itself with this example, including the

Re: [Libreoffice] smoketest

2010-11-08 Thread Caolán McNamara
On Sat, 2010-11-06 at 10:13 -0500, Norbert Thiebaud wrote: There is some improvement on the smoketest front It run pass many more tests.. but still do not finish: The smoketest passes every time for me. FWIW # A fatal error has been detected by the Java Runtime Environment: # # SIGSEGV

[Libreoffice] [PUSHED] dev-install build improvement

2010-11-08 Thread Caolán McNamara
On Fri, 2010-11-05 at 20:19 +0530, surensp...@gmail.com wrote: Updated the second patch and tested it. Looks good to me, pushed this now. Thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[Libreoffice] [PUSHED] Re: [PATCH to test on Windows env] memory leak htags.cpp according to cppcheck

2010-11-08 Thread Caolán McNamara
On Sun, 2010-11-07 at 14:16 +0100, julien wrote: Hello, I can't test this patch since this part of code is for Windows but i think it's a true positive Yes, I agree, its a potential memory leak Is this ok or am I wrong ? Yeah, this is ok, and I've pushed this fix, thanks :-) Though, if

  1   2   3   4   5   6   7   8   9   10   >