Re: [Libreoffice] C{,PP}FLAGS ignored in sal

2010-10-15 Thread David Tardon
On Thu, Oct 14, 2010 at 09:33:45AM +0100, Caolán McNamara wrote: On Thu, 2010-10-14 at 08:37 +0200, Thomas Klausner wrote: On Wed, Oct 13, 2010 at 05:25:59PM +0200, Thomas Klausner wrote: I don't see my CFLAGS nor CPPFLAGS, which would make it find boost, in the gcc arguments. How can

Re: [Libreoffice] [LibreOffice][Patch] Replace ASSERT and DBG_ASSERT with OSL_ENSURE + some translations, comment removal

2010-10-15 Thread David Tardon
On Thu, Oct 14, 2010 at 09:11:26AM +0100, Caolán McNamara wrote: On Wed, 2010-10-13 at 22:34 +0200, Jacek Wolszczak wrote: http://wiki.services.openoffice.org/wiki/Debug_Levels. Some additional questions. What should I replace DBG_ERROR with? Hmm, DBG_ERROR takes no condition, and just

Re: [Libreoffice] [PATCH] final SAL_N_ELEMENTS

2010-10-19 Thread David Tardon
On Tue, Oct 19, 2010 at 09:42:17PM +0200, Kenneth Venken wrote: hi, these patches will replace the last occurrences of sizeof(foo)/sizeof(foo[0]) with SAL_N_ELEMENTS(foo) -- Kenneth Hi, I pushed sal_n_elements.libs-gui.diff and sal_n_elements.ure.diff. The changes the other two do seem

Re: [Libreoffice] suspect code in extentions/sdext/source/presenter/PresenterClock.cxx

2010-11-01 Thread David Tardon
On Mon, Nov 01, 2010 at 09:24:09AM +, Caolán McNamara wrote: On Sun, 2010-10-31 at 23:04 -0500, Norbert Thiebaud wrote: ::osl::MutexGuard aSolarGuard (::osl::Mutex::getGlobalMutex()); Paint(rEvent.UpdateRect); I'm thinking I should change this guard with a SolarMutexGuard

Re: [Libreoffice] [PUSHED] Easy Hacks : RTL_CONSTASCII_USTRINGPARAM in libs-core 1

2010-11-05 Thread David Tardon
On Thu, Nov 04, 2010 at 09:54:20PM +0100, Gert Faller wrote: Hi, here are some in 'libs-core'. Regards. Thanks! I removed some changes * in BasicManager::SetGlobalUNOConstant, because the variable is function parameter, not a string constant. * in ModuleContainer_Impl::getByName,

Re: [Libreoffice] [PUSHED] build.pl dead code, spelling fixes

2010-11-09 Thread David Tardon
On Mon, Nov 08, 2010 at 08:10:51PM -0600, Jordan Ayers wrote: Miscellaneous cleanup to build.pl. Mostly removal of dead code, with a few spelling / German-English fixes. LGPLv3+/MPL Pushed, thanks! D. ___ LibreOffice mailing list

Re: [Libreoffice] [PUSHED] 4 patches of rtl goodness

2010-11-09 Thread David Tardon
On Tue, Nov 09, 2010 at 03:11:40PM -0500, Kevin Hunter wrote: At 12:44pm -0500 Tue, 09 Nov 2010, Kevin Hunter wrote: Here are four more patch conversions from createFromAscii to RTL_CONST... applied against: basebmp/ binfilter/ bridges/ connectivity/ I apologize, I temporarily forgot

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM in svx

2010-11-09 Thread David Tardon
On Tue, Nov 09, 2010 at 09:30:22PM +0100, Joost Eekhoorn wrote: Is it correct to have the RTL_CONSTASCII_USTRINGPARAM directly in the *.hxx file. If so, why not do that also at other places? MPL 1.1 / GPLv3+ / LGPLv3+ Joost Pushed, thanks! D.

Re: [Libreoffice] [PUSHED] more spelling mistakes, dead code removal for Base

2010-11-09 Thread David Tardon
On Tue, Nov 09, 2010 at 10:24:20PM +, Wols Lists wrote: Cheers, Wol Looks fine. Pushed. From cb03ee788ea81661ae83ae611806c6050d16af57 Mon Sep 17 00:00:00 2001 -// use keys and indexes for excat postioning Would that mean positioning of a dead cat (aka ex-parrot)? :-D D.

[Libreoffice] script providers as extensions

2010-11-10 Thread David Tardon
Hi all, just a heads up: recently I was working on removing the script providers for BeanShell, JavaScript and Python from standard installation, as they are only marginally useful and (at least on Fedora) require quite a slew of dependencies. So, from now on, they are available as plain

Re: [Libreoffice] [PUSHED] Another bunch of misc spelling mistakes, translations, code removal for Base

2010-11-10 Thread David Tardon
On Wed, Nov 10, 2010 at 12:54:32PM +, Wols Lists wrote: Cheers, Wol Pushed. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] RTL_CONSTASCII_USTRINGPARAM in libs-core 5

2010-11-10 Thread David Tardon
On Wed, Nov 10, 2010 at 02:16:20PM +0100, Gert Faller wrote: Hi, some more... Regards. Pushed, with several changes from rtl::OUString foo = rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(blah)); or rtl::OUString foo(rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(blah))); to rtl::OUString

Re: [Libreoffice] [Patch] + Question about compilation warning on sd/source/ui/view/drviewsj.cxx

2010-11-10 Thread David Tardon
On Wed, Nov 10, 2010 at 11:53:07PM +0100, julien wrote: Hello, The patch contains only the removing of comments. I haven't removed 1 line of comment because i don't know what Wieder raus mean. Pushed. I would have like to remove a warning too since during compilation, I got this :

Re: [Libreoffice] [PUSHED] + Question about compilation warning on sd/source/ui/view/drviewsj.cxx

2010-11-10 Thread David Tardon
And now once more with PUSHED in subject... D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Replaced createFromAscii with RTL_CONSTASCII_USTRINGPARAM in /dbaccess/source/ in base repo

2010-11-11 Thread David Tardon
On Thu, Nov 11, 2010 at 06:03:31PM -0300, Santiago Alessandri wrote: Hi! I'm attaching the patch for changing the use of createFromAscii with RTL_CONSTASCII_USTRINGPARAM in the directories: /dbaccess/source/shared/ /dbaccess/source/ui/app/ /dbaccess/source/ui/browser/

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM for calc_ui

2010-11-11 Thread David Tardon
On Thu, Nov 11, 2010 at 07:45:53PM +0100, Julien Nabet wrote: Hello, Here's a patch for calc/sc/source/ui (except unoobj previously sent). Julien. (LGPLv3+ / MPL) Good, but I changed lines like rtl::OUString foo = rtl::OUString(RTL_CONSTASCII_STRINGPARAM(foo)); to rtl::OUString

Re: [Libreoffice] [PUSHED] Remove bogus comments in libs-gui

2010-11-12 Thread David Tardon
On Fri, Nov 12, 2010 at 12:50:37PM +0500, Alexander O. Anisimov wrote: Hi all, patch is in attachment .''`. With best regards, : :' : Alexander Anisimov `. `' JID alenyas...@gmail.com `- Debian - when you have better things to do than fixing systems Wonderful! Keep them coming!

Re: [Libreoffice] [PUSHED] Easy Hacks : RTL_CONSTASCII_USTRINGPARAM in libs-core 6

2010-11-13 Thread David Tardon
On Fri, Nov 12, 2010 at 07:44:28PM +0100, Gert Faller wrote: Hi, another patch for libs-core. Regards. Pushed, thanks! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM for writer_starmath

2010-11-13 Thread David Tardon
On Fri, Nov 12, 2010 at 11:22:06PM +0100, Julien Nabet wrote: Hello, Here's a small patch as there was only 1 file in the starmath part which needed modifications. Julien. (LGPLv3+ / MPL) Pushed, thanks! D. ___ LibreOffice mailing list

Re: [Libreoffice] [PUSH] Replaced createFromAscii with RTL_CONSTASCII_USTRINGPARAM in base repo

2010-11-13 Thread David Tardon
On Sat, Nov 13, 2010 at 12:53:43PM -0300, Santiago Alessandri wrote: With this patch I think there are no more misuses of createFromAscii in the base repository. It is released under MPL 1.1 / GPLv3+ / LGPLv3+ -- Santiago Alessandri Pushed, thanks! D.

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM in svx

2010-11-13 Thread David Tardon
On Sat, Nov 13, 2010 at 09:43:18PM +0100, Joost Eekhoorn wrote: MPL 1.1 / GPLv3+ / LGPLv3+ Joost Pushed. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM for libs-core/connectivity

2010-11-14 Thread David Tardon
On Sat, Nov 13, 2010 at 10:44:36PM +0100, Julien Nabet wrote: Hello, Here's again a small patch for the last changes to do that I've seen in libs-core/connectivity Julien. (LGPLv3+ / MPL) Pushed. I have changed two lines: -::rtl::OUStringBuffer sVal= (::rtl::OUStringBuffer)

Re: [Libreoffice] SW build error

2010-11-14 Thread David Tardon
On Sun, Nov 14, 2010 at 12:52:39PM +0100, Gert Faller wrote: Hi, I get a build error in sw : with : 'sw/source/filter/rtf/rtffly.cxx' 1311 error: 'PictPropertyNameValuePairs' has not been declared PictPropertyNameValuePairs is only a typedef in ' libs-core/editeng/inc/editeng/svxrtf.hxx'

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM in svx

2010-11-14 Thread David Tardon
On Sun, Nov 14, 2010 at 08:32:31PM +0100, Joost Eekhoorn wrote: MPL 1.1 / GPLv3+ / LGPLv3+ (Hope 13e patch on the 13 has no mistakes in it:) ) Joost Thanks, pushed. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM cleaning in components - dialogs

2010-11-14 Thread David Tardon
On Sun, Nov 14, 2010 at 09:36:08PM +0100, Pierre-André Jacquod wrote: regards MPL/ GPLv3+ / LGPLv3+ pjacquod Again, I changed lines like rtl::OUString foo = rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(foo)) to rtl::OUString foo(RTL_CONSTASCII_USTRINGPARAM(foo)) D.

Re: [Libreoffice] [PUSHED] + question RTL_CONSTASCII_USTRINGPARAM for libs-core/connectivity/source/drivers/adabas/

2010-11-14 Thread David Tardon
On Sun, Nov 14, 2010 at 10:57:57PM +0100, Julien Nabet wrote: Hello, Here's a patch (LGPLv3+ / MPL) for libs-core/connectivity/source/drivers/adabas/ Pushed. Concerning the file connectivity/source/drivers/adabas/Buser.cxx, in the function : ::rtl::OUString

Re: [Libreoffice] Preferred indentation for LibreOffice

2010-11-14 Thread David Tardon
On Sun, Nov 14, 2010 at 07:44:30PM -0300, Júlio Hoffimann wrote: Hi, I was looking Starmath code and see a new indentation style: */* vim:set shiftwidth=4 softtabstop=4 expandtab: */* * * This will be the preferred style for LibreOffice project? Yes, this is the preferred style. D.

Re: [Libreoffice] [PUSHED] Clean code at writer [source/core/layout]

2010-11-15 Thread David Tardon
On Mon, Nov 15, 2010 at 01:05:43PM -0800, Kayo Hamid wrote: Hello, please can someone review this? I do not known exactly what I need to remove or not, so I'll known a bit more after someone reviewing it. So I'll be able to clean better and at once. I pushed it. Nice big chunk of dead code

Re: [Libreoffice] [PUSHED] Re: Problem building sw (writer) in debug mode under Linux

2010-11-16 Thread David Tardon
On Tue, Nov 16, 2010 at 05:22:48PM +0100, Giuseppe Castagno wrote: Tor Lillqvist wrote: Now what it's the right flag to use to surround a debug specific code: OSL_DEBUG_LEVEL 1 or DBG_UTIL ? I recently did a build with --enable-dbgutil so that it would use the debugging C++ library on

Re: [Libreoffice] Disable GCC optimizations when building with --enable-symbols

2010-11-18 Thread David Tardon
On Thu, Nov 18, 2010 at 03:19:39AM -0700, Tor Lillqvist wrote: On a related note, what is your take on --enable-dbgutil vs. --enable-debug? Are they designed to do clearly separate things? IMHO no. Both allow to: * use assertions * insert arbitrary debugging code that is only present in

Re: [Libreoffice] Disable GCC optimizations when building with --enable-symbols

2010-11-18 Thread David Tardon
On Wed, Nov 17, 2010 at 03:50:33PM -0300, Santiago Bosio wrote: Hi! When LibO is built using --enable-symbols, it still uses -O2 optimizations, making hard to debug execution with GDB. You can export nopt=true before building to turn optimizations off. D.

[Libreoffice] use dbglevel=1 for --enable-debug builds?

2010-11-18 Thread David Tardon
Hi all, currently, configuring with --enable-debug means that dbglevel is set to 2, which in turns means that OSL_DEBUG_LEVEL is set to 2. This enables all the OSL_ debugging stuff there is (well, maybe there is some really rare stuff that is only enabled for OSL_DEBUG_LEVEL 2, but I don't know

Re: [Libreoffice] [PUSHED] More clean code at writer [source/core/{docnode, draw, edit}]

2010-11-19 Thread David Tardon
On Thu, Nov 18, 2010 at 12:12:41PM -0800, Kayo Hamid wrote: Sorry ;-) Hello, sending this for review. I think that cleaniness is better than the previous. revol_ Pushed. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] [PUSHED] RTL easy hack against bridges/

2010-11-20 Thread David Tardon
On Fri, Nov 19, 2010 at 10:11:49AM -0500, Kevin Hunter wrote: Hullo List, A simple one against but test cases, but, as I said in the commit message, they were in my (grep) road! Kevin Pushed. D. ___ LibreOffice mailing list

Re: [Libreoffice] Location of SfxPoolItem.Type() method

2010-11-21 Thread David Tardon
On Sun, Nov 21, 2010 at 12:21:08AM +1100, Mattias Johnsson wrote: Hello all, I've been trying to fix a bug in the search and replace code, and after a bit of hacking have discovered that in findattr.cxx there's a function int CmpAttr( const SfxPoolItem rItem1, const SfxPoolItem rItem2 )

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM for libs-core/framework

2010-11-21 Thread David Tardon
On Sun, Nov 21, 2010 at 08:39:42AM +0100, Julien Nabet wrote: Hello, Here's a patch for libs-core/framework Julien. (LGPLv3+ / MPL) Thanks, pushed. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] [PUSHED] some cleanup #if 0 deletion

2010-11-21 Thread David Tardon
On Sat, Nov 20, 2010 at 11:20:34PM +0100, Pierre-André Jacquod wrote: Hello, was just tired to try reading code like: #if 0 read a lot here #else cool I will be compiled #endif So I started to track it down systematically. Just hope I was not to much aggressive. So I

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM in svx

2010-11-21 Thread David Tardon
On Mon, Nov 22, 2010 at 07:37:28AM +0100, David Tardon wrote: On Sun, Nov 21, 2010 at 02:58:35PM +0100, Joost Eekhoorn wrote: MPL 1.1 / GPLv3+ / LGPLv3+ Joost The patch contains duplicate changes for svx/source/fmcomp/fmgridif.cxx and svx/source/gengal/gengal.cxx .-) Otherwise good

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM for libs-core/scripting + SAL_N_ELEMENTS (last one ?)

2010-11-21 Thread David Tardon
On Sun, Nov 21, 2010 at 04:20:26PM +0100, Julien Nabet wrote: Hello, Here's a patch for libs-core/scripting + 1 patch for filter_msfilter (I thought i did it before but i must have deleted it by mistake). It seems, by reading the result of grep, it's the last SAL_N_ELEMENTS macro to put in

Re: [Libreoffice] use dbglevel=1 for --enable-debug builds?

2010-11-22 Thread David Tardon
On Thu, Nov 18, 2010 at 01:08:49PM +0100, Sebastian Spaeth wrote: On Thu, 18 Nov 2010 13:01:42 +0100, David Tardon wrote: 1) one would just run build -- dbglevel=2 in the desired module similarly as one runs build -- debug=true today. 2) As an alternative, we could add optional level

[Libreoffice] quickstarter causes crash on end of desktop session

2010-11-22 Thread David Tardon
Hi all, we have been getting quite a lot of crashes from abrt (crash catching and reporting tool) on Fedora that had been caused by XIOError. After some investigation, we have found that they are caused by quickstarter continuing to run after end of desktop session (see

Re: [Libreoffice] quickstarter causes crash on end of desktop session

2010-11-22 Thread David Tardon
On Mon, Nov 22, 2010 at 11:45:16AM +, Michael Meeks wrote: On Mon, 2010-11-22 at 09:42 +, Caolán McNamara wrote: *I* think we should try and fix it in LibreOffice 3.3 seeing as we're flooded with these over in RH land. Agreed, if I never see the crash recovery dialog on

Re: [Libreoffice] [PUSHED] Removed some commented out code

2010-11-22 Thread David Tardon
On Mon, Nov 22, 2010 at 06:52:47PM +0200, Timo Heino wrote: Check attachment and comments please. (so i know can i search more these) Pushed, thanks! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] Location of SfxPoolItem.Type() method

2010-11-22 Thread David Tardon
On Tue, Nov 23, 2010 at 04:14:01PM +1100, Mattias Johnsson wrote: On a semi-related note, I'm doing a lot of stepping through the search and replace code trying to track the problem down. Because LO seems to be compiled using -O2 and -O3, there's a lot of optimization which means the way the

Re: [Libreoffice] OSL_DEBUG_LEVEL question

2010-11-22 Thread David Tardon
On Mon, Nov 22, 2010 at 11:33:42PM +0100, Miklos Vajna wrote: On Mon, Nov 22, 2010 at 10:38:31PM +0100, Miklos Vajna vmik...@frugalware.org wrote: Does anyone have an idea when (and why) this changed, and what's the new way of getting the OSL_TRACE() output? Oh, I guess this is related

Re: [Libreoffice] [PUSHED] remove dead codes and undesired comments

2010-11-22 Thread David Tardon
On Tue, Nov 23, 2010 at 02:01:57PM +0900, Takeshi Abe wrote: Hi, Easy Hacks on base, some of indentions are left unchanged for clarity. Thanks! I pushed it except one hunk containing the magical word TODO :) D. ___ LibreOffice mailing list

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM for components/cui

2010-11-23 Thread David Tardon
On Tue, Nov 23, 2010 at 10:14:03PM +0100, Julien Nabet wrote: Hello, Here's a patch for components/cui. I made this : git commit -a git format-patch HEAD~1 Hope it's ok. Julien. (LGPLv3+ / MPL) Nice, pushed! D. ___ LibreOffice

Re: [Libreoffice] timers in calc

2010-11-23 Thread David Tardon
On Wed, Nov 24, 2010 at 08:14:08AM +0100, Julien Nabet wrote: Le 24/11/2010 08:11, Julien Nabet a écrit : Date: Tue, 23 Nov 2010 22:20:36 -0500 From: Kohei Yoshidakyosh...@novell.com Subject: Re: [Libreoffice] [PATCH] try to correct some timers in sc + question

Re: [Libreoffice] quick starter applet/systray defaults and various confusion

2010-11-24 Thread David Tardon
Yet another argument for quickstarter not being on by default is that it doesn't survive update, i.e., 1. start quickstarter 2. update OO.o (or LibO) 3. try to create new text document through quickstarter (or click on existing one, or... do whatever else) - crash (see

Re: [Libreoffice] timers in calc

2010-11-24 Thread David Tardon
On Wed, Nov 24, 2010 at 11:37:53PM +0100, Julien Nabet wrote: You said that aSpellTimer is only restarted in SpellTimerHdl but i saw line 1915 in the function IMPL_LINK( ScModule, IdleHandler, Timer*, EMPTYARG ) BOOL bSpell = pDoc-ContinueOnlineSpelling(); if ( bSpell )

Re: [Libreoffice] [PUSHED] Clean code at writer [source/ui]

2010-11-24 Thread David Tardon
On Wed, Nov 24, 2010 at 12:52:19PM -0800, Kayo Hamid wrote: Covering source/ui/{app,cctrl,chrdlg,config,dbui,dialog,dochdll,docvw,envelp}, sending for review. Curiously 'ui' is the most clean I have seen. revol_ Pushed with some changes. D. ___

Re: [Libreoffice] Fwd: Extensions code cleanup with patch

2010-11-25 Thread David Tardon
On Thu, Nov 25, 2010 at 10:15:52PM +0200, Roth Robert wrote: -- Forwarded message -- From: Roth Robert robert.roth@gmail.com Date: Thu, Nov 25, 2010 at 9:27 PM Subject: Extensions code cleanup To: libreoffice@lists.freedesktop.org Some more dead code and bogus

Re: [Libreoffice] Are ISC/BSD-licensed contributions acceptable?

2010-11-26 Thread David Tardon
On Thu, Nov 25, 2010 at 12:52:49PM +, Michael Meeks wrote: On Mon, 2010-11-22 at 09:47 +0100, Gioele Barabucci wrote: in bug #31633 I proposed a patch to one of the export filters. I've just committed it; sorry for delay. It's great to have you prodding at this piece of

Re: [Libreoffice] [PUSHED] Remove dead codes and confusing comments

2010-11-26 Thread David Tardon
On Sat, Nov 27, 2010 at 01:56:33AM +0900, Takeshi Abe wrote: Hi, More cleanup on base. Cheers, -- Takeshi Abe Pushed, thanks! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] Are ISC/BSD-licensed contributions acceptable?

2010-11-26 Thread David Tardon
On Sat, Nov 27, 2010 at 12:02:18AM +, Wols Lists wrote: On 26/11/10 09:05, David Tardon wrote: I think that's not possible, because some of the filters (like WordprocessorML) use XSLT 2.0, which is not supported by libxslt (wasn't supported the last time I looked, at least). So either

Re: [Libreoffice] [PUSHED] Clean code at writer [source/ui]

2010-11-27 Thread David Tardon
On Fri, Nov 26, 2010 at 02:02:16PM -0800, Kayo Hamid wrote: Covering {fldui,fmtui,frmdlg,globdoc,index,lingu,misc}, sending for review. My patchs are ok? I see so many changes, I want to known if i'm doing something wrong. revol_ Pushed. D.

Re: [Libreoffice] opening oxt from command line

2010-11-30 Thread David Tardon
On Mon, Nov 29, 2010 at 05:02:06PM -0500, Arno Teigseth wrote: Hi I have LibreOffice 3.3.0 OOO330m9 (Build:1) libreoffice-build 3.2.99.2 It hangs when I do libreoffice extension.oxt from the command line. No error messages on stdout. Adding the extension from the menu

Re: [Libreoffice] [PATCH] Last patch to clean code at writer [source/ui]

2010-11-30 Thread David Tardon
I retained some hunks that IMHO have documentary value. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Last patch to clean code at writer [source/ui]

2010-11-30 Thread David Tardon
On Tue, Nov 30, 2010 at 04:46:47PM +0100, David Tardon wrote: I retained some hunks that IMHO have documentary value. ... and pushed the rest, too .-) D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org

Re: [Libreoffice] LO status bar annoyances

2010-12-01 Thread David Tardon
On Tue, Nov 30, 2010 at 11:26:54AM +0100, Sebastian Spaeth wrote: - I have to single-click on the INSRT and STD-EXT-ADD-BLK and language selection thingies, but to double-click on the Page 1/1 and Default for something to happen. I just found out by coincidence today that I can launch

Re: [Libreoffice] [PATCH] Use GtkStatusIcon instead of libegg

2010-12-07 Thread David Tardon
Hi, Michael, On Mon, Dec 06, 2010 at 03:59:17PM +, Michael Meeks wrote: Hi David, On Mon, 2010-12-06 at 15:18 +0100, David Tardon wrote: On Mon, Dec 06, 2010 at 02:08:36PM +, Michael Meeks wrote: Really ? as soon as the X server dies, we'll get all manner of XErrors

Re: [Libreoffice] [PATCH] Use GtkStatusIcon instead of libegg

2010-12-07 Thread David Tardon
On Tue, Dec 07, 2010 at 09:34:52AM +0100, David Tardon wrote: The problem is that SessionManagerClient is only initialized with the first sal frame (IOW, GtkSalFrame::Show calls SessionManagerClient::open). Obviously, if there has never been any frame opened, which, I suppose, happens in a lot

Re: [Libreoffice] [PATCH] Use GtkStatusIcon instead of libegg

2010-12-07 Thread David Tardon
On Tue, Dec 07, 2010 at 12:39:19PM +, Michael Meeks wrote: Hi David, On Tue, 2010-12-07 at 10:54 +0100, David Tardon wrote: I think the simplest thing here is to run SessionManagerClient::open when initializing the quickstarter (the function is exported, so there should

Re: [Libreoffice] libreoffice -quickstart

2010-12-07 Thread David Tardon
On Wed, Dec 08, 2010 at 02:19:02AM +0100, Miguel (ON) wrote: Hi : ) I've noticed that a process is added at the startup when LibreOffice is installed. The process is libreoffice -quickstart -nologo -nodefault and it must be removed in LibreOffice options (enable quick start in System

[Libreoffice] what's SfxMenuControl::aHelpText good for?

2010-12-13 Thread David Tardon
Hi all, recently I've been looking at fdo#31716 and have found out that the reading of help indexes that seems to cause the slowdown serves to no purpose, because the result is then just ignored. To be more precise, the result is assigned (through SfxMenuControl::Bind) to

Re: [Libreoffice] Fix for pdfimport (fdo#32330) needs review

2010-12-14 Thread David Tardon
On Wed, Dec 15, 2010 at 02:36:56AM +0100, Thorsten Behrens wrote: Hi, could someone quickly review attached patch - a fairly safe fix I'd like to include in -3-3, since it quite spectacularly break graphics on PDF import. Hi Thorsten, looks fine to me. Simple and clear :) D.

Re: [Libreoffice] Failed while building module nss

2010-12-15 Thread David Tardon
On Thu, Dec 16, 2010 at 02:25:41AM +0800, imacat wrote: Dear all, Hi. This is imacat from Taiwan. I try to compile LibreOffice on my Debian Lenny 5.0.6 x86_64, gcc 4.3.2, glibc 2.7. It fails when building module nss: == % make Making all in po

Re: [Libreoffice] Review needed - fix for 'wikihelp is not context sensitive'

2010-12-15 Thread David Tardon
On Wed, Dec 15, 2010 at 11:14:33PM +0100, Jan Holesovsky wrote: Hi, https://bugs.freedesktop.org/show_bug.cgi?id=32338 Can you please review, sign-off and push the attached patch to libreoffice-3-3? The root of the problem is that in case of the built-in help, when a help-id is not

Re: [Libreoffice] Failed at slideshow(fpicker) with ‘class KFileDialog’ has no member named ‘setConfirmOverwrite’

2010-12-16 Thread David Tardon
On Fri, Dec 17, 2010 at 02:18:04PM +0800, imacat wrote: Dear all, Hi. This is imacat from Taiwan. I tried to compile LibreOffice 3.3.0.1 on my Debian Lenny x86_64 5.0.6, gcc 4.3.2, glibc 2.7. It failed at the slideshow module, and when I digged inside as suggested, it complainted

Re: [Libreoffice] Failed at slideshow(fpicker) with ‘class KFileDialog’ has no member named ‘setConfirmOverwrite’

2010-12-17 Thread David Tardon
On Fri, Dec 17, 2010 at 09:27:40AM +0100, Rene Engelhard wrote: On Fri, Dec 17, 2010 at 07:27:12AM +0100, David Tardon wrote: On Fri, Dec 17, 2010 at 02:18:04PM +0800, imacat wrote: Dear all, Hi. This is imacat from Taiwan. I tried to compile LibreOffice 3.3.0.1 on my Debian

Re: [Libreoffice] Failed at slideshow(fpicker) with ‘class KFileDialog’ has no member named ‘setConfirmOverwrite’

2010-12-17 Thread David Tardon
On Fri, Dec 17, 2010 at 10:23:24AM +0100, Rene Engelhard wrote: On Fri, Dec 17, 2010 at 09:27:40AM +0100, Rene Engelhard wrote: On Fri, Dec 17, 2010 at 07:27:12AM +0100, David Tardon wrote: On Fri, Dec 17, 2010 at 02:18:04PM +0800, imacat wrote: Dear all, Hi. This is imacat

Re: [Libreoffice] [PUSHED] Re: [PATCH] RTL_CONSTASCII_USTRINGPARAM for framework properties

2010-12-19 Thread David Tardon
On Sun, Dec 19, 2010 at 09:40:19AM +0100, Julien Nabet wrote: Le 18/12/2010 13:47, Caolán McNamara a écrit : On Sat, 2010-12-18 at 02:41 +0100, Julien Nabet wrote: Hello, Here is a patch for properties.h of framework framework compiles ok. Looks good, thanks for this. Pushed. C.

Re: [Libreoffice] 3.4.4rc1 fails to build in kde4 vcl

2011-10-31 Thread David Tardon
On Sun, Oct 30, 2011 at 10:55:34PM +0100, Rene Engelhard wrote: On Sun, Oct 30, 2011 at 03:15:49AM +0100, Andrea Scarpino wrote: On Saturday 29 October 2011 21:30:29 Andreas Radke wrote: Compiling: vcl/unx/source/dtrans/config.cxx /build/src/build/vcl/unx/kde4/KDEXLib.cxx: In member

Re: [Libreoffice] [REVIEW 3-4] 3.4.4rc1 fails to build in kde4 vcl

2011-11-01 Thread David Tardon
On Mon, Oct 31, 2011 at 06:15:55PM +0100, Andreas Radke wrote: Am Mon, 31 Oct 2011 09:50:31 +0100 schrieb David Tardon dtar...@redhat.com: On Sun, Oct 30, 2011 at 10:55:34PM +0100, Rene Engelhard wrote: On Sun, Oct 30, 2011 at 03:15:49AM +0100, Andrea Scarpino wrote: On Saturday 29

Re: [Libreoffice] [PATCH][PUSHED] memory leaks found with valgrind

2011-11-30 Thread David Tardon
On Thu, Nov 17, 2011 at 09:12:49PM -0500, August Sodora wrote: I always forget [PATCH] August Sodora aug...@gmail.com (201) 280-8138 On Thu, Nov 17, 2011 at 9:12 PM, August Sodora aug...@gmail.com wrote: Hello, I was a little curious about valgrind so I ran it against soffice

Re: [Libreoffice] [ANNOUNCE] Branch libreoffice-3-5 created

2011-12-12 Thread David Tardon
On Wed, Dec 07, 2011 at 11:46:41AM +, Caolán McNamara wrote: On Wed, 2011-12-07 at 10:53 +, Michael Meeks wrote: + tripple cross-company code review for features until nearer RC1 + exceptions: artwork, unit-tests until RC1 FWIW, I don't personally feel that triple reviews have

[Libreoffice] [REVIEW 3-4-5] untranslated menu items

2011-12-22 Thread David Tardon
Hi all, commit 7248aaed7aca6c241683f6d83bb6caa00c447b0d reverts earlier commit, that caused some menu items to be left untranslated. If you are wondering why it is so, read my comment (I hope it is understandable) in commit a6511b9d9a3f13835510a9caffc837829b206d14 :-) How to reproduce: 1. start

[Libreoffice] feature/gbuild_java is finished

2011-12-26 Thread David Tardon
Hi all, I have converted 6 modules to gbuild on branch feature/gbuild_java: javaunohelper, jurt, jvmaccess, jvmfwk, ridljar and unoil. It builds fine here and smoketest finishes with status OK, but some of the modules contain platform specific stuff (e.g., unoil creates some .NET assemblies :) I

Re: [Libreoffice] [REVIEW-3-4-5] [PUSHED] Re: gcc 4.6.2 + boost 1.48.0 and unordered_map assignment operator const issues [was gcc 4.6.2]

2011-12-27 Thread David Tardon
On Wed, Dec 21, 2011 at 03:10:57PM +, Michael Meeks wrote: On Wed, 2011-12-21 at 13:15 +0100, Petr Mladek wrote: So, I have pushed it to the libreoffice-3-4 branch, see http://cgit.freedesktop.org/libreoffice/bootstrap/commit/?h=libreoffice-3-4id=9c2ab9f4febec2b2c5fac25469f1d0cfedc6af5e

Re: [Libreoffice] [REVIEW 3-5] [PUSHED 3-5] request to cherry pick fix for fdo44172

2012-01-06 Thread David Tardon
On Thu, Jan 05, 2012 at 03:31:02PM -0500, August Sodora wrote: Hello all, I recently fixed a pretty embarrassing regression in basic and I'm pretty sure it should cherry picked to the relevant branches. The commit is here:

Re: [Libreoffice] [PATCH] [PUSHED] If there's no java, don't do the java stuff

2012-01-09 Thread David Tardon
On Mon, Jan 09, 2012 at 12:24:25AM +0700, Korrawit Pruegsanusak wrote: Hello all, This attached patch fixes build on windows / cygwin. I'm building --without-java, and it breaks because not found java_uno_accessbridge, which seems java-related. So, I add a check whether we have SOLAR_JAVA

Re: [Libreoffice] [PATCH core] [PUSHED] Remove cruft in debug tools.

2012-01-09 Thread David Tardon
On Mon, Jan 09, 2012 at 06:41:52PM +0100, Marcel Metz wrote: Hello lo-devs, the define SV_MEMMGR in tools/source/debug/debug.cxx was commented out since 2001 and all of the memory related debugging code depends on this define. These patches removes all of the depending code. The ini

Re: [Libreoffice] [PATCH binfilter] [PUSHED] Remove cruft in debug tools.

2012-01-09 Thread David Tardon
On Mon, Jan 09, 2012 at 06:42:08PM +0100, Marcel Metz wrote: --- binfilter/bf_sfx2/source/bastyp/sfx2_bitset.cxx | 10 -- binfilter/bf_sfx2/source/bastyp/sfx2_minarray.cxx |6 -- 2 files changed, 0 insertions(+), 16 deletions(-) Pushed as well, thank you. D.

Re: [Libreoffice] [PATCH] [PUSHED] Removed unused DBG_WARNING{4, 5} macros, replaced DBG_WARNINGFILE.

2012-01-09 Thread David Tardon
On Mon, Jan 09, 2012 at 07:01:26PM +0100, Marcel Metz wrote: Hello lo-devs, this patch removes the unused DBG_WARNING4 and DBG_WARNING5 macros and replaces also the DBG_WARNINGFILE with SAL_INFO as suggested in the tools/debug.hxx headers. Pushed, thanks! Btw, could you use git

Re: [Libreoffice] [PATCH] If there's no java, don't do the java stuff

2012-01-11 Thread David Tardon
seems java-related. I noticed on the mailing list that David Tardon has already pushed your patch, but I'm still curious to know: did you have the Java Access Bridge [1] installed when you tested this patch (I assume you didn't have it because the build broke)? [1] http://www.oracle.com

[Libreoffice] [REVIEW: 3-4] possible missing translations

2012-01-12 Thread David Tardon
Hi, commit 196885980bbb51562264cb5aad9a3e01133d1d7d fixes a situation where some translated strings may be missing from installation because of a bug in one of our tools. I would like to see it in 3.4 . Details: The fast_merge.pl script creates hierarchy of localize.sdf files (one per source

Re: [Libreoffice] [PATCH] [PUSHED] Translate German comments

2012-01-12 Thread David Tardon
On Wed, Jan 11, 2012 at 04:10:36PM +0100, Philipp Weissenbacher wrote: Hi lo-devs, More translations. Business as usual. Thanks :) D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] [PATCH] Simple fix for frmsh.cxx to review (from cppcheck report)

2012-01-15 Thread David Tardon
On Sat, Jan 14, 2012 at 04:08:46AM -0800, julien2412 wrote: Hello, cppcheck reported this : core/sw/source/ui/shells/frmsh.cxx 516 duplicateExpression style Same expression on both sides of '' After a quick reading, i thought about this page but perhaps it's less straightforward

Re: [Libreoffice] [LibreOffice][Patch][PUSHED] translate comments to English frmedt

2012-01-16 Thread David Tardon
On Sun, Jan 15, 2012 at 10:56:38PM +0100, Luc Castermans wrote: Hi, Following yesterdays contribution here more translations. One more file to go and then /sw/source/core/frmedt is done. Too late to finish today. Pushed. Thank you for your great work :-) D.

Re: [Libreoffice] [PATCH] [PUSHED] Replaced DBG_ERRORFILE with SAL_INFO.

2012-01-16 Thread David Tardon
On Sun, Jan 15, 2012 at 10:11:36AM +0100, Marcel Metz wrote: Hello lo-devs, as mentioned in the subject these patches replace the DBG_ERRORFILE macro with SAL_INFO as suggested in the tools/debug.hxx header. The patches were created with git format-patch. Thanks, pushed. D.

Re: [Libreoffice] [PATCH] Removing unused code

2012-01-17 Thread David Tardon
On Tue, Jan 17, 2012 at 01:22:55PM +0100, Alexander Bergmann wrote: -vcl::PDFExtOutDevData::EndGroup() -vcl::PDFExtOutDevData::GetFormsFormat() const -vcl::PDFExtOutDevData::SetAutoAdvanceTime(unsigned int, int) -vcl::PDFExtOutDevData::SetOutlineItemDest(int, int)

Re: [Libreoffice] Structural QA activities

2012-01-18 Thread David Tardon
On Wed, Jan 18, 2012 at 02:13:24PM +, Michael Meeks wrote: It just needs someone from the project to liaise with them and get it set up. It'd be great to have someone that could run this for us and share the report (if their license allows that). It'd make some great fruit for

[Libreoffice] [REVIEW: 3.5] fdo#44947 not localizable strings

2012-01-20 Thread David Tardon
Hi all, commit a13d3436852a28c50a36c4ebd26c0e0c4fd9718c fixes https://bugs.freedesktop.org/show_bug.cgi?id=44947 , adding 12 localizable strings that were left out previously because they were passed as macro arguments (hey everyone: do not do this! Our tools are dumb and cannot handle it .-)

Re: [Libreoffice] [REVIEW: 3.5] fdo#44947 not localizable strings

2012-01-20 Thread David Tardon
On Fri, Jan 20, 2012 at 10:09:30AM +0100, David Tardon wrote: Hi all, commit a13d3436852a28c50a36c4ebd26c0e0c4fd9718c fixes Add commit 614feec5481ee618bea98dabab2df0281995385e to that, because I forgot git commit --amend -a -C HEAD before pushing... D

Re: [Libreoffice] Build error in helpcontent2

2012-01-23 Thread David Tardon
On Mon, Jan 23, 2012 at 10:02:43AM +0100, Riccardo Magliocchetti wrote: Hello, i'm trying to build libreoffice from git but it gives me an error in helpcontent2: Entering /home/rm/src/libo/helpcontent2/source/auxiliary echo aux_langdirs:=en-US ../../unxlngi6.pro/inc/aux_langs.mk echo

Re: [Libreoffice] Compiling question by a complete beginner

2012-01-23 Thread David Tardon
On Sat, Jan 21, 2012 at 10:49:10PM +0200, Barış Akkurt wrote: Hi, I'm a complete beginner in LibreOffice development and at the compiling step now. I tried instructions here: http://wiki.documentfoundation.org/Development/Native_Build But compilation failed while building the moz module. I

Re: [Libreoffice] [REVIEW] fdo#43932: try to fix paper tray settings

2012-01-24 Thread David Tardon
On Tue, Jan 24, 2012 at 03:36:23PM +0400, Ivan Timofeev wrote: 17.01.2012 16:05, Caolán McNamara пишет: On Fri, 2012-01-13 at 22:22 +0400, Ivan Timofeev wrote: Hi there, https://bugs.freedesktop.org/show_bug.cgi?id=43932 this patch partially reverts

Re: [Libreoffice] [PATCH] cppcheck prefix operator in components

2010-12-27 Thread David Tardon
On Sun, Dec 26, 2010 at 01:10:29PM +0100, Julien Nabet wrote: Hello, Here is a patch for cppcheck prefix operator in components Compiling was ok Julien (LGPLv3+ / MPL) Pushed, thanks! D. ___ LibreOffice mailing list

Re: [Libreoffice] [PATCH] cppcheck cleaning in writer

2010-12-27 Thread David Tardon
On Sun, Dec 26, 2010 at 05:07:37PM +0100, Julien Nabet wrote: Hello, Here is a patch for 2 memleaks + 1 assigned a value that is never used Compiling was ok Julien (LGPLv3+ / MPL) Pushed, thanks! D. ___ LibreOffice mailing list

Re: [Libreoffice] [PATCH] code cleanup and fix typos in comments

2010-12-27 Thread David Tardon
On Sun, Dec 26, 2010 at 01:26:40AM +0900, Takeshi Abe wrote: Hi, An Easy Hack at libs-core/desktop. Cheers, -- Takeshi Abe Pushed, thanks! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

  1   2   3   4   5   6   7   8   9   10   >