Re: [Libreoffice] Libreoffice Changes

? Thanks a lot! Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Improving the build experience in rawbuild

On Wed, 2010-10-13 at 15:33 +0200, Cedric Bosdonnat wrote: Do you have any strong opinion against that? Nope. I support this initiative. :-) Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list

Re: [Libreoffice] howto for getting non-trivial cppunit tests up and running

now that I'm home. Thanks, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] EasyHack RTL_CONSTASCII_USTRINGPARAM in sc

::OUString with no arguments i.e. rtl::OUString(). I made that change for you while applying your patch. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

Re: [Libreoffice] Help concerning code style and documentation

. ;-) Thanks a lot, and keep us informed of your progress. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Help concerning code style and documentation

Hi Regina, On Wed, 2010-11-03 at 10:35 +0100, Regina Henschel wrote: Hi Kohei, Kohei Yoshida schrieb: Hi Regina, On Sun, 2010-10-24 at 18:13 +0200, Regina Henschel wrote: Hi all, I'm currently working on LINEST and have attached a draft to issue http://www.openoffice.org/issues

[Libreoffice] [PUSHED] Warning free sc module

On Wed, 2010-11-03 at 17:12 +0100, René Kjellerup wrote: Hi I looked in to the warnings in 'sc' and changed a few things around to satisfy the compiler ^_^ Looks good! Pushed to master. Thanks much. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] Help concerning code style and documentation

On Wed, 2010-11-03 at 09:39 -0400, Kohei Yoshida wrote: You know, that I work on it in my spare time, so response time might be long. You should tell me, whether the mathematics I used are clear from the code or you want me to write a description. Understood. We certainly want you

[Libreoffice] SvxHyperlinkDlg still used?

/hyprlink.cxx:859 which led me to dig deeper... Kohei * libs-core/svx/source/dialog/hyprdlg.hxx -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org

[Libreoffice] LINEST, LOGEST, TREND and GROWTH patch merged

. Thanks a lot, Regina. :-) I've added several test cases to the contrib/test-files repository, which you can clone by http://cgit.freedesktop.org/libreoffice/contrib/test-files/ look under calc/function to find the new test cases I've just added. Cheers, Kohei -- Kohei Yoshida, LibreOffice

Re: [Libreoffice] Problem with sal/cppunittester

. ;-) And Perl is not exactly my cup of tea. I appreciate the right fix, Caolan. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [Libreoffice] Remove bogus comments in calc

. GetScCompilerNativeSymbol() was still used, but it could easily be substituted with ScCompiler::GetNativeSymbol(), so I replaced the former with the latter. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice

Re: [Libreoffice] [Patch] RTL_CONSTASCII_USTRINGPARAM for calc\sc\source\core\data

::OUString aStr(RTL_CONSTASCII_USTRINGPARAM(Text)); since that implicitly calls OUString's constructor with the RTL_... as its argument. But most other cases require explicit call to the constructor. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] [PUSHED] A typo in svx/source/gallery2/galtheme.src etc.

good, and I build-tested on master. Before cherry-picking this to libreoffice-3-3 branch, let me ask Andre to make sure if we are still before the string freeze.. Andre? :-) Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

[Libreoffice] [PATCH] [PUSHED, partial] Commented-out code for the day

::StackVar eType;\ That comment there was clearly used to annotate the defined macros immediately below it, so I considered it'd be better to keep that one. The other parts of your patch have not been reviewed yet. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh

[Libreoffice] [PATCH] [PUSHED, partial] Commented-out code for the day

that to be unnecessary and we don't normally do it in this code base. Other than that, all looks good. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org

Re: [Libreoffice] [libreoffice] [PATCH] Commented-out code for the day

On Mon, 2010-11-08 at 00:53 +0200, Ricardo Moreno wrote: here is more commented code removal. Ok. Just pushed the remaining chart2 part of the patch. All looks good. Thanks much. :-) Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] [PUSHED] A typo in svx/source/gallery2/galtheme.src etc.

On Mon, 2010-11-08 at 09:57 -0500, Kohei Yoshida wrote: On Mon, 2010-11-08 at 19:22 +0900, Takeshi Abe wrote: Hi, translating lo-build.pot to the Japanese .po, I found a typo in libs-core which affects a msgid (numbered as 277) in the .pot. It would be nice if we can apply the attached

[Libreoffice] [PUSHED] touch up work on the previous patch

On Mon, 2010-11-08 at 20:51 +0100, René Kjellerup wrote: hi', cleaned some coments and killed an unused function Looks good. Pushed. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice

Re: [Libreoffice] [Patch][EasyHacks] Replace ScfNoCopy in calc with boost::noncopyable

see namespaces used like that in this code base. HTH, Kohei Nigel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Kohei Yoshida, LibreOffice hacker, Calc kyosh

[Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM for calc_core_data

a couple of commits ago. :-) BTW, can we have your full name? I would be nice to check in your future patches with our full name, instead of just 'julien', to give you proper attribution. Thanks! Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] SvxHyperlinkDlg still used?

On Fri, 2010-11-12 at 12:26 +, Michael Meeks wrote: Hi there, On Fri, 2010-11-05 at 09:28 -0400, Kohei Yoshida wrote: On Fri, 2010-11-05 at 00:51 -0400, Kohei Yoshida wrote: Does anyone know if SvxHyperlinkDlg* is still used? Did a full git grep SvxHyperlinkDlg on all repos

Re: [Libreoffice] Calc usability improvements

spreadsheet app that warns about overwriting existing cells. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Calc usability improvements

packaged as OpenOffice.org. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Calc usability improvements

their custom key bindings in the newer versions. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Calc usability improvements

countries. While , might be correct for de_DE, it is commonly . for de_CH. Yup, that is accounted for when choosing the default setting. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice

Re: [Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for calc (datefunc, analysis and solver)

, and keep them coming! Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] SvxHyperlinkDlg still used?

On Fri, 2010-11-12 at 15:32 +, Michael Meeks wrote: On Fri, 2010-11-12 at 08:35 -0500, Kohei Yoshida wrote: Yes, I was aware of this, and even SvxHyperlinkDlgWrapper is never instantiated. It is registered by the applications on startup, but that's the only place I see it being used

Re: [Libreoffice] SvxHyperlinkDlg still used?

On Fri, 2010-11-12 at 11:12 -0500, Kohei Yoshida wrote: Did you do the unwinding to satisfy yourself that whatever mapping between SID_HYPERLINK_INSERT and this dialog is never exploited ? Heh! The short story is that this dialog code still *is* used, as a Hyperlink *toolbar*. Go

Re: [Libreoffice] SvxHyperlinkDlg still used?

On Fri, 2010-11-12 at 11:12 -0500, Kohei Yoshida wrote: On Fri, 2010-11-12 at 15:32 +, Michael Meeks wrote: On Fri, 2010-11-12 at 08:35 -0500, Kohei Yoshida wrote: Yes, I was aware of this, and even SvxHyperlinkDlgWrapper is never instantiated. It is registered by the applications

Re: [Libreoffice] Calc usability improvements

. And based on how I read all the inputs on this thread, 2) is the preferred solution by the vast majority of people. Is this a fair assessment? If so, I'd say let's make this change on the master branch. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] a few mixed patches to calc

files in one go if I understand this correctly. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Calc usability improvements

Hello Santiago, On Mon, 2010-11-15 at 16:04 -0300, Santiago Bosio wrote: El 15/11/10 11:47, Kohei Yoshida escribió: So, just to summarize this thread, we have three possible options for this: 1) no changes, 2) change the polarity of the current dialog so that the user *unchecks

Re: [Libreoffice] Calc usability improvements

On Mon, 2010-11-15 at 09:47 -0500, Kohei Yoshida wrote: If so, I'd say let's make this change on the master branch. Ok, done on master. Testing appreciated. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice

Re: [Libreoffice] SvxHyperlinkDlg still used?

://wiki.documentfoundation.org/Development/Easy_Hacks#Remove_obsolete_Hyperlink_Bar I look forward to having someone brave enough to step up for this task. :-) Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice

Re: [Libreoffice] Calc usability improvements

On Mon, 2010-11-15 at 16:06 -0500, Kohei Yoshida wrote: On Mon, 2010-11-15 at 09:47 -0500, Kohei Yoshida wrote: If so, I'd say let's make this change on the master branch. Ok, done on master. Testing appreciated. One implementation note. I've implemented this by making changes

[Libreoffice] Target in whiteboard

, this is not to suggest that our next release will be 3.3.1, as opposed to 3.4 or any other possible versions. For now I'm using 3.3.1 as the version after the 3.3. Honestly, I don't think anyone has any idea what our next version number will be. ;-) Kohei -- Kohei Yoshida, LibreOffice hacker, Calc

Re: [Libreoffice] Questions about Timers

On Thu, 2010-11-18 at 09:14 +, Caolán McNamara wrote: If you look at calc I think it has a timer which is launched off when calc is first started, and then that timer never ends, even when calc is actually closed down :-) Hmm... Not Good. Which timer in calc is doing this? -- Kohei

Re: [Libreoffice] Git server-side hooks

On Thu, 2010-11-18 at 10:30 +0100, Miklos Vajna wrote: On Wed, Nov 17, 2010 at 08:28:36PM -0500, Kohei Yoshida kyosh...@novell.com wrote: 3) When creating a feature branch, by default, the autosetuprebase option is set to true, which forces rebase when pulling from the master branch even

Re: [Libreoffice] Questions about Timers

On Thu, 2010-11-18 at 13:54 +, Caolán McNamara wrote: On Thu, 2010-11-18 at 08:05 -0500, Kohei Yoshida wrote: On Thu, 2010-11-18 at 09:14 +, Caolán McNamara wrote: If you look at calc I think it has a timer which is launched off when calc is first started

Re: [Libreoffice] Git server-side hooks

On Fri, 2010-11-19 at 12:31 +, Michael Meeks wrote: On Thu, 2010-11-18 at 08:28 -0500, Kohei Yoshida wrote: Now that we promote the concept of feature branches, I hope we can revert this. We should be using 'git merge' unless it is for a purely local branch that we are rebasing

Re: [Libreoffice] [PATCH] [PUSHED] update URLs

On Fri, 2010-11-19 at 23:35 +0900, Takeshi Abe wrote: Hi, Found a couple of links outdated in README. Thanks a lot! Pushed. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice

Re: [Libreoffice] Git server-side hooks

was merge in git universe... :-/ Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Git detached HEAD (no branch) was: newish to git: howto recover from bad merge?

rebase. Anyway, this knowledge helped me understand git a bit more. So, I hope this will help others too. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

Re: [Libreoffice] [Patch][EasyHacks] Replace ScfRef with boost::shared_ptr in calc filter code

. Agreed. That was my idea as well. In case using boost::shared_ptr causes any significant performance hit, we could easily replace that with boost::intrusive_ptr for better performance. Thanks a lot for your work. Really appreciated. :-) Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh

Re: [Libreoffice] [PUSHED] some cleanup #if 0 deletion

in the externalrefmgr.cxx is going to be re-enabled soon, which you correctly skipped. ;-) Regards, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org

Re: [Libreoffice] Discuss quot; Easy_Hacks: Remove Sheet From Filequot; ?

in on that. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Discuss quot; Easy_Hacks: Remove Sheet From Filequot; ?

On Mon, 2010-11-22 at 14:27 -0500, Kohei Yoshida wrote: On Mon, 2010-11-22 at 18:45 +, Joe Smith wrote: There should be some data from the Improvement Program on how often this item is used, no? Sure. But such data was not available to us mere mortals (or hackers as we might

Re: [Libreoffice] [PATCH] try to correct some timers in sc + question

itself. Thanks! Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] dead code removal etc from Base

On Tue, 2010-11-23 at 23:36 +, Wols Lists wrote: Cheers, Wol Looked good. Pushed. -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org

Re: [Libreoffice] [PATCH] [PUSHED] dead code, spelling mistakes in Base

On Tue, 2010-11-23 at 23:43 +, Wols Lists wrote: Another one... Pushed. Thanks. -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [Libreoffice] [PATCH] [PUSHED] Another dead code removal for Base

On Tue, 2010-11-23 at 23:57 +, Wols Lists wrote: Cheers, Wol Pushed, thanks. -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [Libreoffice] [PATCH] [PUSHED, partial] More dead code and spelling mistakes for Base

On Wed, 2010-11-24 at 01:08 +, Wols Lists wrote: Cheers, Wol Pushed, except for the hunk that removed the code that checks the format of dropped object. That one looked useful, so I decided to keep it. Thanks! Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] [PATCH] [PUSHED] More spelling mistakes and dead code removal for Base

On Wed, 2010-11-24 at 01:52 +, Wols Lists wrote: Cheers, Wol Pushed. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [Libreoffice] Discuss quot; Easy_Hacks: Remove Sheet From Filequot; ?

On Tue, 2010-11-23 at 23:39 +0100, Christoph Noack wrote: Hi all! Sorry for being a bit later ... yesterday, I had to fight against some electronic devices (what irony...). Am Montag, den 22.11.2010, 14:27 -0500 schrieb Kohei Yoshida: There should be some data from the Improvement

Re: [Libreoffice] Discussamp; amp; quot; Easy_Hacks: Remove Sheet From Fileamp; amp; quot; ?

world of Ribbon UI. Or maybe Excel 2010 no longer has this in the menu since it now has this quick sheet insertion button at the bottom (as LibO does). Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list

Re: [Libreoffice] [Patch] [PUSHED] Still cleaning out calc

later (with a todo marker). Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Discuss quot; Easy_Hacks: Remove Sheet From Filequot; ?

I'm a bit puzzled. The original issue was that it was extremely mind-numbingly hard to open a text csv file from Calc from File - Open (which I wholeheartedly agree), and the solution was to add Sheet From File... menu item in the Insert menu!? Hmm.. Okay. ;-) Kohei -- Kohei Yoshida

Re: [Libreoffice] [Crazy Ideas] Discuss

turns them off, and will give less noise, but I haven't checked. It's the debug=t part that turns off compiler optimization. dbglevel=# controls the amount of debug messages that other devs have put in (if I understand David's mail correctly, that is). Kohei -- Kohei Yoshida, LibreOffice hacker

Re: [Libreoffice] LO status bar annoyances

of us even think that we should turn on this option by default. Currently it's off by default. So, that's the background on this indicator. I'm afraid we can't remove this unless there is really really good reason to do so. ;-) Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh

Re: [Libreoffice] [UX] LO status bar annoyances

On Tue, 2010-11-30 at 16:11 +0100, Thorsten Behrens wrote: Kohei Yoshida wrote: b) We warn when closing a modified doc anyway, so there is no need to always warn me and use up precious space. I propose to just do away with it. Sorry I have to disagree there. I'm the one

Re: [Libreoffice] LO status bar annoyances

On Tue, 2010-11-30 at 10:34 -0500, Kevin Hunter wrote: At 9:54am -0500 Tue, 30 Nov 2010, Kohei Yoshida wrote: Sorry I have to disagree there. I'm the one who put that icon there, and the reason for that was to have a visually obvious way to tell whether or not the document is currently

Re: [Libreoffice] [UX] LO status bar annoyances

On Tue, 2010-11-30 at 16:42 +0100, Regina Henschel wrote: Hi Thorsten, Thorsten Behrens schrieb: Kohei Yoshida wrote: b) We warn when closing a modified doc anyway, so there is no need to always warn me and use up precious space. I propose to just do away

Re: [Libreoffice] Nominating bug 32002 as blocker for LibO-3.3.0 RC2

nothing to do with the platform as Caolan pointed out. I guess we can remove this from the list of blockers for 3.3. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

Re: [Libreoffice] LO status bar annoyances

On Tue, 2010-11-30 at 12:30 -0500, Joe Smith wrote: On 11/30/2010 09:54 AM, Kohei Yoshida wrote: Sorry I have to disagree there. I'm the one who put that icon there, and the reason for that was to have a visually obvious way to tell whether or not the document is currently modified

Re: [Libreoffice] [UX] LO status bar annoyances

On Tue, 2010-11-30 at 19:44 +0100, Cor Nouws wrote: Hi Kohei, Kohei Yoshida wrote (30-11-10 17:25) [...] Removing that would not radically improve the real estate of the status bar. Indeed. Plus that I guess there are quite some interesting Calc/Excel issues out

Re: [Libreoffice] [UX] LO status bar annoyances

to the current document status! Perhaps I should add this to the easy hacks page. Well, I hope this helped anyhow ... I don't know :-) It sure did. Thanks a lot. :-) Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing

Re: [Libreoffice] LO status bar annoyances

On Wed, 2010-12-01 at 20:28 +, Michael Meeks wrote: On Tue, 2010-11-30 at 13:03 -0500, Kohei Yoshida wrote: Is there a use case to justify exposing any of this to users? Can you expand on what you mean by 'any of this'? I guess the root problem is that you can do operations

Re: [Libreoffice] de-emphasisig java ... - summary so far ...

with disabling it by default. And indeed, as Caolan said, the java situation is somewhat messy on SUSE platforms, where multiple jdk implementations are provided, gcj, openjdk, sun-jdk, and ibm-jdk. Anyhow... Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] new credits up, now with less contributors

the 19 LO repos), and we are down to 307 individuals in total... (seems weirdly low, mmh) Hmm. My stat looks weird. Kohei Yoshida Commits: 643 Joined: 2009-06-19 In the previous stats my joined date was sometime in 2006 (which sounded right), with total commits somewhere in the neighborhood of 2200

Re: [Libreoffice] [REVIEWED] Re: Fix for fdo#31308 needs review

On Fri, 2010-12-03 at 16:13 +0100, Jan Holesovsky wrote: Hi Kohei, On 2010-12-03 at 09:46 -0500, Kohei Yoshida wrote: Fix for fdo#31308 needs review. The patch is very trivial, and looks safe enough to me. https://bugs.freedesktop.org/show_bug.cgi?id=31308 Reviewed, comment

Re: [Libreoffice] new credits up, now with less contributors

On Fri, 2010-12-03 at 16:44 +0100, Jan Holesovsky wrote: Hi Sebastian, On 2010-12-03 at 16:21 +0100, Sebastian Spaeth wrote: Hmm. My stat looks weird. Kohei Yoshida Commits: 643 Joined: 2009-06-19 Yep, incredible but true, One of the reasons is that during the cvs

Re: [Libreoffice] Script to find undocumented classes

with a commit hook, so that it does not allow you to commit _new_ files without (at least the high level) documentation? ;-) I'm actually NOT in favor of this. As much as I believe in providing good code documentation for new code, this is a bit too far. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc

Re: [Libreoffice] Script to find undocumented classes

On Fri, 2010-12-03 at 11:08 -0500, Kohei Yoshida wrote: On Fri, 2010-12-03 at 10:23 +0100, Jan Holesovsky wrote: Hi all, On 2010-12-02 at 21:59 +0100, Thorsten Behrens wrote: So just in case, let's agree to disagree keep the patches coming! :) As a conclusion, what about

Re: [Libreoffice] Localized readme's whereabouts

On Sat, 2010-12-04 at 00:47 -0500, Kohei Yoshida wrote: Hi there, I'm trying to locate the readme and license files that are shipped with the release. I'd like to fix some URL's in the Japanese translated version of these files, but I can't seem to find them in the build tree. Does

Re: [Libreoffice] Localized readme's whereabouts

On Sat, 2010-12-04 at 00:56 -0500, Kohei Yoshida wrote: On Sat, 2010-12-04 at 00:47 -0500, Kohei Yoshida wrote: Hi there, I'm trying to locate the readme and license files that are shipped with the release. I'd like to fix some URL's in the Japanese translated version of these files

Re: [Libreoffice] [libreoffice-design] Developers, Designers and Vice Versa?

me in CC to alert my attention. If unsure who the domain expert is, putting the developer list in CC is what I would recommend (or prod us directly on the dev list). Regards, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

[Libreoffice] Patch review requested

Please someone review my patch at https://bugs.freedesktop.org/show_bug.cgi?id=32133 which fixes the aforementioned bug for 3.3. The patch in comment 7 is the one that needs reviewing. Thanks! Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] LibreOffice WikiHelp

the sub-domain routing. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Release tag convention

? I certainly wouldn't mind as I was the one requesting this. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Help on removing a DECLARE_LIST()

(probably for speed reasons). http://opengrok.go-oo.org/xref/libs-gui/tools/source/memtools/contnr.cxx#1509 So, I'm willing to bet that there is nothing we need to do here to replace this call. I hope this helps. If not, let me know. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh

[Libreoffice] Patch review for Bug 32196 requested

I've attached a patch awaiting peer-review. https://bugs.freedesktop.org/show_bug.cgi?id=32196 The change is simple and innocuous enough that I would almost commit it without review, but I'd like someone to take a quick look and give me a go. Thanks, Kohei -- Kohei Yoshida, LibreOffice

Re: [Libreoffice] Patch review for Bug 32196 requested

Hi Norbert, On Tue, 2010-12-07 at 17:03 -0600, Norbert Thiebaud wrote: On Tue, Dec 7, 2010 at 4:45 PM, Kohei Yoshida kyosh...@novell.com wrote: I've attached a patch awaiting peer-review. https://bugs.freedesktop.org/show_bug.cgi?id=32196 The change is simple and innocuous enough

Re: [Libreoffice] Patch review for Bug 32196 requested

On Tue, 2010-12-07 at 21:38 -0600, Norbert Thiebaud wrote: On Tue, Dec 7, 2010 at 7:12 PM, Kohei Yoshida kyosh...@novell.com wrote: Hi Norbert, On Tue, 2010-12-07 at 17:03 -0600, Norbert Thiebaud wrote: On Tue, Dec 7, 2010 at 4:45 PM, Kohei Yoshida kyosh...@novell.com wrote: I've

Re: [Libreoffice] Easter eggs, was: Re: Comments on RC1

On Wed, 2010-12-08 at 11:09 +, Michael Meeks wrote: the embedded games were -so- bad, I can't imagine anyone getting that addicted :-) Not unless we embedd Tetris in Calc Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

[Libreoffice] README translation for 3.3

appreciate it. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com README_en-US.bz2 Description: application/bzip ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Removal of DECLARE_LIST() from Calc

of this in other places anyway. ;-) ps: Sorry about the size... but I had to change everything in one pass or not at all. Not a problem. :-) Ok. Now I've committed your patch and committed my own fix afterward. Thanks a lot for getting this piece done! Kohei -- Kohei Yoshida, LibreOffice hacker, Calc

Re: [Libreoffice] new Win32 size analysis ...

On Thu, 2010-12-09 at 19:47 +, Michael Meeks wrote: the new export-OLE-PDF feature This is cool! Awesome work Gart. :-) Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice

Re: [Libreoffice] [PATCH] EasyHacks 3.27 Change Sheet copy process

On Fri, 2010-12-10 at 20:31 -0500, Kohei Yoshida wrote: I'll CC Christoph in case he has some comments on this feature as well as on my comments above. Christoph, please feel free to add your comments as well if you have any. :-) And these are the screenshots of the new dialog. Rename

Re: [Libreoffice] Can we remove soldep module?

and/or no one will miss this module at all. I'll work on removing this module later today. Thanks! Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

Re: [Libreoffice] Can we remove soldep module?

On Mon, 2010-12-13 at 15:33 +, Caolán McNamara wrote: On Mon, 2010-12-13 at 10:31 -0500, Kohei Yoshida wrote: I'll work on removing this module later today. Remove it from the solenv/unx/*.mk list of modules with warnings that should be ignored while you're at it. Roger

[Libreoffice] Patch for ignoring preceding and trailing spaces in cell during csv import

number option *un*-checked, which is off by default. Patch reviews are appreciated. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com diff --git a/sc/inc/stringutil.hxx b/sc/inc/stringutil.hxx index dcf6d57..e9a60a5 100644 --- a/sc/inc/stringutil.hxx +++ b/sc/inc

Re: [Libreoffice] [PATCH] [PUSHED] EasyHacks 3.27 Change Sheet copy process

. :-) Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] EasyHacks 3.27 Change Sheet copy process

On Mon, 2010-12-13 at 23:53 -0500, Kohei Yoshida wrote: Hi Joost, On Sun, 2010-12-12 at 12:19 +0100, Joost Eekhoorn wrote: Hereby additional patch with: * Check on pName is NULL. * Showing original sheet name in input box, when Rename option is checked. Not implemented

Re: [Libreoffice] Patch for ignoring preceding and trailing spaces in cell during csv import

Hi Takeshi, On Tue, 2010-12-14 at 18:36 +0900, Takeshi Abe wrote: Hi Kohei, On Mon, 13 Dec 2010 16:28:34 -0500, Kohei Yoshida kyosh...@novell.com wrote: I'd like to port a patch to the libreoffice-3-3 branch to ignore preceding and trailing spaces in cells during csv import. The change

Re: [Libreoffice] Patch for ignoring preceding and trailing spaces in cell during csv import

character sequence twice in each number cell, which will make the import slower, especially with large csv files. So, this is the reason why I avoid it. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list

Re: [Libreoffice] Patch for ignoring preceding and trailing spaces in cell during csv import

On Tue, 2010-12-14 at 07:43 -0600, Norbert Thiebaud wrote: On Tue, Dec 14, 2010 at 7:18 AM, Kohei Yoshida kyosh...@novell.com wrote: Hi Takeshi, On Tue, 2010-12-14 at 18:36 +0900, Takeshi Abe wrote: Hi Kohei, On Mon, 13 Dec 2010 16:28:34 -0500, Kohei Yoshida kyosh...@novell.com

Re: [Libreoffice] Patch for ignoring preceding and trailing spaces in cell during csv import

On Tue, 2010-12-14 at 15:52 +, Michael Meeks wrote: Hi there, On Mon, 2010-12-13 at 16:28 -0500, Kohei Yoshida wrote: I'd like to port a patch to the libreoffice-3-3 branch to ignore preceding and trailing spaces in cells during csv import. I just wrote a set of unit tests

[Libreoffice] Any interest in porting this to 3.3?

this to 3.3. In case it's affirmative, I'd like someone to sign off of the change too. Here is the relevant change on master: http://cgit.freedesktop.org/libreoffice/calc/commit/?id=cdcd262ea4aa3c3e407b14ed533e514f75de2d3a Regards, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh

Re: [Libreoffice] Need review of the ooo/OOO330_m18 changes

On Tue, 2010-12-14 at 21:19 +0100, Jan Holesovsky wrote: filters I took care of the filters repo. The only change is for the xlsx import, and we don't modify this area much plus there was no conflict. So I went ahead and merged. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh

  1   2   3   4   5   6   7   8   9   10   >