On Sat, Jun 16, 2007 at 05:06:20AM -0400, Charles Wilson wrote:
Noah Misch wrote:
@@ -2561,6 +2620,7 @@
char *tmp_pathspec;
char *actual_cwrapper_path;
char *shwrapper_name;
+ intptr_t rval = 127;
Do all interesting versions of Cygwin and MinGW have intptr_t?
Yes, going back
Charles Wilson wrote:
This passes all expected tests on linux (native).
On cygwin (native) it fails 14,16,32, and 54, which is the expected
behavior.
I'll test
[with
export INSTALL=/usr/bin/install.exe
to ensure that I don't get spurious failures for 35 39 43 46]
on mingw (native)
Hi Charles,
* Charles Wilson wrote on Sun, Jun 17, 2007 at 08:01:20PM CEST:
Ralf Wildenhues wrote:
* Charles Wilson wrote on Sun, Jun 17, 2007 at 02:43:02AM CEST:
OK by me. Do you wat me to add your patch to mine and check it all in
at once (e.g. keep the new-testsuite .exe fixes to
Noah Misch wrote:
Overall, the patch looks suitable. Some minor comments:
+func_ltwrapper_executable_p_result=no
+if ! func_ltwrapper_script_p $1 ; then
The `!' operator is not portable; use `if X; then :; else'. You could instead
add a different magic string to executables,
* Ralf Wildenhues wrote on Sat, Jun 16, 2007 at 12:31:10PM CEST:
The new suite fails tests 25 26 32 54 now, which it
didn't back on 2007-02-24, which is when I last tested it. I haven't
localized it any further yet, so it may be completely independent of
this patch.
Oh, I forgot to attach
Ralf Wildenhues wrote:
Let's keep as much code once as possible, and kill some superfluous
quotes:
func_ltwrapper_executable_p ()
{
func_ltwrapper_exec_suffix=
case $1 in
*.exe) ;;
*) func_ltwrapper_exec_suffix=.exe ;;
esac
grep $magic $1$func_ltwrapper_exec_suffix /dev/null
}
Hi Charles,
Overall, the patch looks suitable. Some minor comments:
On Sun, Jun 10, 2007 at 02:23:58PM -0400, Charles Wilson wrote:
2007-04-22 Charles Wilson [EMAIL PROTECTED]
* libltdl/config/ltmain.m4sh (func_ltwrapper_script_p):
new function detects if $1 is a libtool sh
This patch is an updated version of the one posted here:
http://lists.gnu.org/archive/html/libtool-patches/2007-04/msg00052.html
It is updated to reflect ongoing changes in HEAD, and avoids the mingw
regressions mentioned in that email.
Theory:
