Re: [cygwin] Analysis for new testsuite failures 33,34.35

2007-03-26 Thread Ralf Wildenhues
Hi Charles,

Thanks for the bug report.

* Charles Wilson wrote on Fri, Mar 23, 2007 at 07:32:12AM CET:
 
 ../../libtool-HEAD/tests/subproject.at:56: $MAKE all $tst_dist
 + make all dist
[...]
 mkdir: cannot create directory 
 `/usr/src/libtool/cvs/_build/tests/testsuite.dir/33/subproject-demo-2.1a/sub/ltdl':
  
 File exists
 make[2]: *** [distdir] Error 1

AFAICS, this can only happen if libltdl was treated with automake-1.9
and the tests run with automake-1.10 in place, so that the toplevel
package (named subproject-demo-2.1a) is treated with 1.10.

Hmm.  This is kind of a backward incompatibility, unfortunately.
It can be helped by using the same Automake version for both
bootstrapping and testing, or by using 1.10 for libltdl.

[...]
 Now, I'm not sure how to solve this problem: I don't know what the policy 
 is on the required version of automake for libtool-HEAD, but I'm pretty sure 
 it isn't require 1.10.  But I also don't know if automake-1.9.x is still 
 under development, and would accept the above backport for some future 
 automake-1.9.7 release.

Alexandre said he did not want to continue 1.9.  If there were to be
another point release, this patch would certainly be a good candidate
IMHO.  For reference, below's the patch including ChangeLog entry.

Cheers,
Ralf

2007-03-26  Charles Wilson  ...

* lib/am/distdir.am (distdir): Do not fail if $(distdir) already
exists, for forward compatibility with Automake 1.10 that
overrides the removal due to $(am__remove_distdir).  Fixes `make
dist' failures in which the toplevel package uses 1.10, but a
subpackage 1.9 only.

Index: lib/am/distdir.am
===
RCS file: /cvs/automake/automake/lib/am/distdir.am,v
retrieving revision 1.60.2.1
diff -u -r1.60.2.1 distdir.am
--- lib/am/distdir.am   14 May 2005 20:29:20 -  1.60.2.1
+++ lib/am/distdir.am   26 Mar 2007 18:36:36 -
@@ -1,5 +1,5 @@
 ## automake - create Makefile.in from Makefile.am
-## Copyright (C) 2001, 2002, 2003, 2004  Free Software Foundation, Inc.
+## Copyright (C) 2001, 2002, 2003, 2004, 2007  Free Software Foundation, Inc.
 
 ## This program is free software; you can redistribute it and/or modify
 ## it under the terms of the GNU General Public License as published by
@@ -50,7 +50,7 @@
 ##
 if %?TOPDIR_P%
$(am__remove_distdir)
-   mkdir $(distdir)
+   test -d $(distdir) || mkdir $(distdir)
 endif %?TOPDIR_P%
 ##
 ##


___
http://lists.gnu.org/mailman/listinfo/libtool


Re: [cygwin] Analysis for new testsuite failures 33,34.35

2007-03-26 Thread libtool

On Mon, 26 Mar 2007 20:39:24 +0200, Ralf Wildenhues said:
 Hi Charles,
 
 Thanks for the bug report.
 
 * Charles Wilson wrote on Fri, Mar 23, 2007 at 07:32:12AM CET:
  
  ../../libtool-HEAD/tests/subproject.at:56: $MAKE all $tst_dist
  + make all dist
 [...]
  mkdir: cannot create directory 
  `/usr/src/libtool/cvs/_build/tests/testsuite.dir/33/subproject-demo-2.1a/sub/ltdl':
   
  File exists
  make[2]: *** [distdir] Error 1
 
 AFAICS, this can only happen if libltdl was treated with automake-1.9
 and the tests run with automake-1.10 in place, so that the toplevel
 package (named subproject-demo-2.1a) is treated with 1.10.

I'm not so sure; I believe I first encountered the problem using 1.9.6
exclusively, but I will rebootstrap explicitly with (unpatched) 1.9 and
make sure.

 Alexandre said he did not want to continue 1.9.  

That's what I thought.  If I am right (above), then this is bad, and
libtool/libltdl from HEAD/2.0 will require 1.10 (if one cares about the
facilities tested by 33,34,35: subproject libltdl).  I hope I'm wrong...

--
Chuck


___
http://lists.gnu.org/mailman/listinfo/libtool


Re: [cygwin] Analysis for new testsuite failures 33,34.35

2007-03-26 Thread Charles Wilson

[EMAIL PROTECTED] wrote:

On Mon, 26 Mar 2007 20:39:24 +0200, Ralf Wildenhues said:



AFAICS, this can only happen if libltdl was treated with automake-1.9
and the tests run with automake-1.10 in place, so that the toplevel
package (named subproject-demo-2.1a) is treated with 1.10.


I'm not so sure; I believe I first encountered the problem using 1.9.6
exclusively, but I will rebootstrap explicitly with (unpatched) 1.9 and
make sure.

...

I hope I'm wrong...


Fortunately, I was wrong.  This change:

http://sources.redhat.com/cgi-bin/cvsweb.cgi/automake/lib/am/distdir.am.diff?r1=1.63r2=1.64cvsroot=automakef=h

has two parts; the behavior I observed was because I was getting one 
part of it, without the other -- exactly as Ralf surmised.


After forcibly rebootstrapping[*] with 1.9.6, it worked fine.

I don't believe there is any need to worry about patching 1.9.6/7 or 
requiring 1.10 -- this problem has an easy solution: if using libltdl 
as a subproject, ensure that you use the same version of automake there 
as in the project that contains it: 1.9 or 1.10 (earlier? dunno), just 
be consistent.


--
Chuck

[*] this is where cygwin's slightly overgrown autotools system works 
well: we have a gentoo-derived smart wrapper for automake, but ALSO 
use alternatives, for when you absolutely positively have to use a 
specific version, and the smart wrapper is acting a little too smart 
for its own good...


automake - status is manual.
 link currently points to /usr/bin/automake-1.9
/usr/bin/automake-1.10 - priority 60
 slave aclocal: /usr/bin/aclocal-1.10
 slave automake-info: /usr/share/info/automake1.10.info.gz
/usr/share/autotools/am-wrapper.sh - priority 100
 slave aclocal: /usr/share/autotools/am-wrapper.sh
 slave automake-info: NONE
/usr/bin/automake-1.4 - priority 10
 slave aclocal: /usr/bin/aclocal-1.4
 slave automake-info: NONE
/usr/bin/automake-1.5 - priority 15
 slave aclocal: /usr/bin/aclocal-1.5
 slave automake-info: NONE
/usr/bin/automake-1.6 - priority 20
 slave aclocal: /usr/bin/aclocal-1.6
 slave automake-info: NONE
/usr/bin/automake-1.7 - priority 30
 slave aclocal: /usr/bin/aclocal-1.7
 slave automake-info: NONE
/usr/bin/automake-1.8 - priority 40
 slave aclocal: /usr/bin/aclocal-1.8
 slave automake-info: NONE
/usr/bin/automake-1.9 - priority 50
 slave aclocal: /usr/bin/aclocal-1.9
 slave automake-info: /usr/share/info/automake1.9.info.gz
Current `best' version is /usr/share/autotools/am-wrapper.sh.



___
http://lists.gnu.org/mailman/listinfo/libtool