Re: [Libvir] [PATCH] lxc: handle SIGCHLD from exiting container

2008-05-06 Thread Dave Leskovec
Jim Meyering wrote: Dave Leskovec [EMAIL PROTECTED] wrote: ... +#ifndef _SIGNAL_H +#include signal.h +#endif In practice it's fine to include signal.h unconditionally, and even multiple times. Have you encountered a version of signal.h that may not be included twice? If so, it probably

[Libvir] [PATCH] lxc: loop in tty forwarding process

2008-05-06 Thread Dave Leskovec
This patch changes the lxc tty forwarding process to use epoll instead of poll. This is done to avoid a cpu consuming loop when a user disconnects from the container console. During some testing, we found that when the slave end of a tty is closed, calls to poll() on the master end will return

[Libvir] ISCSI howto, example, etc?

2008-05-06 Thread Mark Dehus
The documentation on the new storage feature is either a little short, or I totally missed it. Anyway, I am looking for some help on how to use it. If anyone could maybe give me an example xml file that would be incredibly helpful, because based on the format description I can't exactly figure

Re: [Libvir] RFC 'xen like scripts'

2008-05-06 Thread Daniel P. Berrange
On Tue, May 06, 2008 at 07:53:29AM +0200, Stefan de Konink wrote: On Tue, 6 May 2008, Daniel P. Berrange wrote: Due to the reason all LUNs are exported over one connection, a rescan before usage a rescan is always required. LUN numbering is not stable, nor they can be found at the

Re: [Libvir] RFC 'xen like scripts'

2008-05-06 Thread Stefan de Konink
On Tue, 6 May 2008, Stefan de Konink wrote: The LUN probably is, as stable as the human readable path to it. If your suggestion is: /dev/disk/by-path/ip-172.16.103.200:3260-iscsi-iqn.1992-08.com.netapp:sn.118046347:vf.88fa4694-0ba6-11dd-b8a9-00a09807592f-lun-1034 Lets elaborate a bit further

Re: [Libvir] RFC 'xen like scripts'

2008-05-06 Thread Daniel P. Berrange
On Tue, May 06, 2008 at 02:52:40PM +0200, Stefan de Konink wrote: On Tue, 6 May 2008, Stefan de Konink wrote: The LUN probably is, as stable as the human readable path to it. If your suggestion is:

Re: [Libvir] RFC 'xen like scripts'

2008-05-06 Thread Daniel P. Berrange
On Tue, May 06, 2008 at 02:44:49PM +0200, Stefan de Konink wrote: On Tue, 6 May 2008, Daniel P. Berrange wrote: On Tue, May 06, 2008 at 07:53:29AM +0200, Stefan de Konink wrote: Having the daemon SSH into the filer is a non-starter. There's no way most admins will allow that as in any

Re: [Libvir] ISCSI howto, example, etc?

2008-05-06 Thread Daniel P. Berrange
On Tue, May 06, 2008 at 12:50:25AM -0600, Mark Dehus wrote: The documentation on the new storage feature is either a little short, or I totally missed it. Anyway, I am looking for some help on how to use it. If anyone could maybe give me an example xml file that would be incredibly helpful,

Re: [Libvir] RFC 'xen like scripts'

2008-05-06 Thread Stefan de Konink
On Tue, 6 May 2008, Daniel P. Berrange wrote: On Tue, May 06, 2008 at 02:44:49PM +0200, Stefan de Konink wrote: On Tue, 6 May 2008, Daniel P. Berrange wrote: On Tue, May 06, 2008 at 07:53:29AM +0200, Stefan de Konink wrote: Having the daemon SSH into the filer is a non-starter.

Re: [Libvir] RFC 'xen like scripts'

2008-05-06 Thread Daniel P. Berrange
On Tue, May 06, 2008 at 03:37:04PM +0200, Stefan de Konink wrote: On Tue, 6 May 2008, Daniel P. Berrange wrote: /* Now figure out the stable path * * XXX this method is O(N) because it scans the pool target * dir every time its run. Should figure out a more

Re: [Libvir] [PATCH] lxc: handle SIGCHLD from exiting container

2008-05-06 Thread Jim Meyering
Dave Leskovec [EMAIL PROTECTED] wrote: Jim Meyering wrote: Dave Leskovec [EMAIL PROTECTED] wrote: ... +#ifndef _SIGNAL_H +#include signal.h +#endif In practice it's fine to include signal.h unconditionally, and even multiple times. Have you encountered a version of signal.h that may not

Re: [Libvir] [PATCH] Add bus attribute to disk target definition

2008-05-06 Thread Soren Hansen
Hi, sorry for the delay. Here's the newest version of the patch which should address all the issues that have been raised so far. === modified file 'src/qemu_conf.c' --- old/src/qemu_conf.c 2008-04-30 12:30:55 + +++ new/src/qemu_conf.c 2008-05-06 17:58:44 + @@ -491,6 +491,8 @@

[libvirt] Changed mailing list subject line prefix

2008-05-06 Thread Daniel P. Berrange
I have just changed the mailing list subject line prefix from '[libvir] ' to '[libvirt] ', so if anyone is using that for filtering you'll need to update... Dan. -- |: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org

[libvirt] Re: [Libvir] make syntax-check fails with bzr checkouts

2008-05-06 Thread Soren Hansen
On Wed, Apr 30, 2008 at 12:19:51PM +0200, Jim Meyering wrote: Unfortunately, the above no longer applies, due to upstream (gnulib) changes to deal with non-srcdir (aka VPATH) builds. I updated libvirt from gnulib just yesterday, and will again, later today. Here's the new patch that seems to

[libvirt] Re: [Libvir] [PATCH] Add bus attribute to disk target definition

2008-05-06 Thread Daniel P. Berrange
On Tue, May 06, 2008 at 08:11:11PM +0200, Soren Hansen wrote: sorry for the delay. Here's the newest version of the patch which should address all the issues that have been raised so far. Yes no. It didn't address the redundant re-ordering of -drive parameters when using boot=on, nor re-add

Re: [libvirt] Re: [Libvir] make syntax-check fails with bzr checkouts

2008-05-06 Thread Jim Meyering
Soren Hansen [EMAIL PROTECTED] wrote: On Wed, Apr 30, 2008 at 12:19:51PM +0200, Jim Meyering wrote: Unfortunately, the above no longer applies, due to upstream (gnulib) changes to deal with non-srcdir (aka VPATH) builds. I updated libvirt from gnulib just yesterday, and will again, later

[libvirt] Re: [Libvir] [PATCH] sound support for qemu and xen

2008-05-06 Thread Daniel P. Berrange
On Tue, May 06, 2008 at 10:39:53AM -0400, Cole Robinson wrote: Cole Robinson wrote: The patch below adds xml support for the soundhw option to qemu and xen. Third iteration. Changes include: - Rediffd against current code - Reading 'all' from a xend sexpr or xm config does the right

[libvirt] PATCH: Add disk bus attribute for Xen driver

2008-05-06 Thread Daniel P. Berrange
To complement soren's patch adding a bus attribute to the QEMU driver, here is a minimal patch adding bus attribute to the Xen drivers. It merely adds it on when generating the XML. It isn't making any attempt to interpret it when creating a VM, since Xen does everything based off the disk node