Re: [libvirt] libvirt and 192.168.122.0/24

2008-12-18 Thread Mark McLoughlin
On Wed, 2008-12-17 at 22:53 -0800, H. Peter Anvin wrote: I'm kind of wondering why libvirt defaults to 192.168.122.0/24 by default. Randomly chosen out of pure ignorance :-) http://www.redhat.com/archives/libvir-list/2007-February/msg00208.html It is a piece of address space which is

Re: [libvirt] [PATCH] don't assume builddir == srcdir

2008-12-18 Thread Guido Günther
On Wed, Dec 17, 2008 at 03:18:16PM +0100, Jim Meyering wrote: Daniel P. Berrange berra...@redhat.com wrote: On Sat, Dec 13, 2008 at 12:23:30AM +0100, Guido G?nther wrote: Hi, Makefile.maint assumes this in some places. This doesn't make the world perfect but maybe a bit better?

Re: [libvirt] [PATCH] don't assume builddir == srcdir

2008-12-18 Thread Guido Günther
On Wed, Dec 17, 2008 at 03:31:45PM +0100, Jim Meyering wrote: Guido Günther a...@sigxcpu.org wrote: Makefile.maint assumes this in some places. This doesn't make the world perfect but maybe a bit better? Um, not really, since a pathological $(abs_srcdir) may contain ; rm -rf /; Best to

[libvirt] [PATCH] fix device hotplug

2008-12-18 Thread Guido Günther
Hi, due to some restructuring we free the device structure so devices are plugged correctly but dumpxml fails since the dev structure is already freed. Cheers, -- Guido From ba61f99ed3449cf2fbe44a994bd245425ec6087d Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Guido=20G=C3=BCnther?= a...@sigxcpu.org

Re: [libvirt] [PATCH 1/5] write pid file into stateDir

2008-12-18 Thread Guido Günther
On Mon, Dec 15, 2008 at 07:09:10PM +, Daniel P. Berrange wrote: [..snip..] I skipped this since -pidfile got introduced 2004 already with: Opps, my mistake - it was -daemon that was added in 0.9.0, not -pidfile svn://svn.savannah.nongnu.org/qemu/tr...@1166 Do we really support

Re: [libvirt] [PATCH 3/5] add XML parsing for vm status file

2008-12-18 Thread Guido Günther
On Mon, Dec 15, 2008 at 10:25:27AM +0100, Daniel Veillard wrote: On Fri, Dec 12, 2008 at 07:26:51PM +0100, Guido Günther wrote: Functions to read and write vm status in $(statedir)/qemu/domain.xml. Keeps the necessary to reconnect to a running domain state within domstate.../domstate. I

Re: [libvirt] [PATCH 4/5] save domain status during vm creation and remove it on shutdown.

2008-12-18 Thread Guido Günther
On Mon, Dec 15, 2008 at 11:22:52AM +, Daniel P. Berrange wrote: On Fri, Dec 12, 2008 at 07:27:08PM +0100, Guido G?nther wrote: This patch does the actual saving and removal of the vm status. It does so only at vm creation time at the moment. We need to update the config every time the

Re: [libvirt] [PATCH 4/5] save domain status during vm creation and remove it on shutdown.

2008-12-18 Thread Daniel P. Berrange
On Thu, Dec 18, 2008 at 10:37:55AM +0100, Guido G?nther wrote: On Mon, Dec 15, 2008 at 11:22:52AM +, Daniel P. Berrange wrote: On Fri, Dec 12, 2008 at 07:27:08PM +0100, Guido G?nther wrote: This patch does the actual saving and removal of the vm status. It does so only at vm creation

Re: [libvirt] [PATCH] Fix GCC hard-coding in python/

2008-12-18 Thread Daniel P. Berrange
On Wed, Dec 17, 2008 at 11:15:30AM +, Daniel P. Berrange wrote: On Wed, Dec 17, 2008 at 09:57:23AM +0100, Jim Meyering wrote: john.le...@sun.com wrote: Fix GCC hard-coding in python/ ... diff --git a/acinclude.m4 b/acinclude.m4 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -75,6

Re: [libvirt] PATCH 0/5: connection cloning support (WIP)

2008-12-18 Thread Daniel P. Berrange
On Wed, Dec 17, 2008 at 11:21:34AM -0500, David Lively wrote: It turned out to be a double-free. Trivial fix below. Dave diff --git a/src/remote_internal.c b/src/remote_internal.c index 9245a2a..d6b94ff 100644 --- a/src/remote_internal.c +++ b/src/remote_internal.c @@ -6423,10

Re: [libvirt] [PATCH] Fix compiler warnings in test code

2008-12-18 Thread Daniel P. Berrange
On Wed, Dec 17, 2008 at 03:17:35PM +, Daniel P. Berrange wrote: On Tue, Dec 16, 2008 at 06:51:14PM -0800, john.le...@sun.com wrote: # HG changeset patch # User john.le...@sun.com # Date 1229399267 28800 # Node ID 1b81ac255ad765ab782829e7fe0a55dc7bab72ab # Parent

Re: [libvirt] [PATCH] Unify pool-create-as and pool-define-as xml building

2008-12-18 Thread Daniel P. Berrange
On Wed, Dec 17, 2008 at 01:24:41PM -0500, Cole Robinson wrote: The attached patch unifies the xml building and command line option registering for the virsh pool-*-as commands, fixing a few bugs in the process: - pool-define-as was creating host without a name attribute (rhbz 476708) -

[libvirt] Re: how to connect LXC via libvirt

2008-12-18 Thread Daniel P. Berrange
On Thu, Dec 18, 2008 at 11:15:54AM +0800, Ian jonhson wrote: Hi Daniel, I followed the instructions in: https://lists.linux-foundation.org/pipermail/containers/2008-September/013237.html to try to connect with LXC which is built in my VM (ubuntu7.10 + kernel 2.6.27-rc8). Unfortunately,

Re: [libvirt] kvm: save / restore

2008-12-18 Thread Daniel P. Berrange
On Wed, Dec 17, 2008 at 01:46:43PM +0100, Matthias Pfafferodt wrote: Hallo, I use kvm-81 and libvirt 0.5.1. I can save a kvm donain but if I want to restore it I get the following error in the log file: unknown migration protocol: stdio I tried it using only kvm and got the same error.

Re: [libvirt] libvirtd crashing with network bridge configuration

2008-12-18 Thread Daniel P. Berrange
On Wed, Dec 17, 2008 at 02:05:33AM +0100, Emre Erenoglu wrote: Dear Developers, Users, I'm trying to package libvirt for our distribution, however, having some problems past the libvirt 0.4.3 series. Everything compiles and installs fine. With versions above and including 0.5.1, I'm

[libvirt] Website typo

2008-12-18 Thread Richard W.M. Jones
Spotted by 'aozturk' on #virt ... Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top Index:

Re: [libvirt] [OpenVZ]

2008-12-18 Thread Evgeniy Sokolov
Hi, attached patch fix problem. Guys, is it really an issue to fix also mac generation for OpenVZ? Vzctl generates different macs for host's and domain's eth devices. Libvirt creates them with equal macs. In this case there is a bridge support for OpenVZ in libvirt but it

[libvirt] libvirt remote connection failing

2008-12-18 Thread Shanmuga Rajan
hi I was trying to migrate KVM based vM between two machine. when i tried to make connection with destination machine but it is not working for me. i got some error. i tried the following uri qemu://192.168.1.22/ qemu://hostname/ everything is failed. Can any one help me with correct

Re: [libvirt] [PATCH] fix device hotplug

2008-12-18 Thread Guido Günther
On Thu, Dec 18, 2008 at 10:51:04AM +, Daniel P. Berrange wrote: On Thu, Dec 18, 2008 at 10:26:07AM +0100, Guido G?nther wrote: Hi, due to some restructuring we free the device structure so devices are plugged correctly but dumpxml fails since the dev structure is already This is a

[libvirt] [PATCH] avoid testcase failures due to LANG!=C

2008-12-18 Thread Guido Günther
Hi, some checks compare to the english error messages: --- out 2008-12-18 15:36:44.0 +0100 +++ exp 2008-12-18 15:36:44.0 +0100 @@ -1,3 +1,3 @@ -libvir: Domain Config Fehler : failed Xen syscall Topologie-Syntaxfehler beim Cpuset -Fehler: Fehler beim Definieren einer Domain von

Re: [libvirt] [PATCH 3/5] add XML parsing for vm status file

2008-12-18 Thread Guido Günther
On Thu, Dec 18, 2008 at 10:23:39AM +, Daniel P. Berrange wrote: No, not guarenteed to be safe because the 'config_xml' string could contain '%' sequences that'll be interpreted by sprintf. In any case why not just use virBufferAdd(buf, config_xml) Updated version using virBufferAdd

Re: [libvirt] [PATCH 1/5] write pid file into stateDir

2008-12-18 Thread Guido Günther
On Thu, Dec 18, 2008 at 10:24:57AM +, Daniel P. Berrange wrote: On Thu, Dec 18, 2008 at 10:31:35AM +0100, Guido G?nther wrote: On Mon, Dec 15, 2008 at 07:09:10PM +, Daniel P. Berrange wrote: [..snip..] I skipped this since -pidfile got introduced 2004 already with: Opps,

Re: [libvirt] PATCH: 0/28: Thread safety for libvirtd daemon and drivers

2008-12-18 Thread Richard W.M. Jones
On Wed, Dec 03, 2008 at 07:44:02PM +, Daniel P. Berrange wrote: On Wed, Dec 03, 2008 at 08:20:36PM +0100, Daniel Veillard wrote: On Wed, Dec 03, 2008 at 06:52:32PM +, Daniel P. Berrange wrote: On Wed, Dec 03, 2008 at 04:18:21PM +0100, Daniel Veillard wrote: On Mon, Dec 01, 2008

Re: [libvirt] [PATCH] 2/8 logging header and core implementation

2008-12-18 Thread Daniel Veillard
On Wed, Dec 17, 2008 at 04:21:48PM +, Daniel P. Berrange wrote: On Wed, Dec 17, 2008 at 04:12:20PM +0100, Daniel Veillard wrote: diff -u -r1.1 logging.h --- src/logging.h 6 Nov 2008 16:36:07 - 1.1 +++ src/logging.h 17 Dec 2008 14:25:57 - @@ -30,16 +30,87 @@ *

Re: [libvirt] PATCH: 0/28: Thread safety for libvirtd daemon and drivers

2008-12-18 Thread Richard W.M. Jones
On Wed, Dec 03, 2008 at 11:57:54PM +, Daniel P. Berrange wrote: let isLockableThingNull exp funcheck = match exp with | UnOp (op,exp,typ) - ( match op with LNot - ( match exp with Lval (lhost, off) - ( match

Re: [libvirt] libvirt remote connection failing

2008-12-18 Thread Richard W.M. Jones
On Thu, Dec 18, 2008 at 08:05:40PM +0530, Shanmuga Rajan wrote: I was trying to migrate KVM based vM between two machine. when i tried to make connection with destination machine but it is not working for me. i got some error. i tried the following uri qemu://192.168.1.22/

Re: [libvirt] libvirt remote connection failing

2008-12-18 Thread Daniel P. Berrange
On Thu, Dec 18, 2008 at 08:05:40PM +0530, Shanmuga Rajan wrote: hi I was trying to migrate KVM based vM between two machine. when i tried to make connection with destination machine but it is not working for me. i got some error. i tried the following uri qemu://192.168.1.22/

Re: [libvirt] Website typo

2008-12-18 Thread Daniel Veillard
On Thu, Dec 18, 2008 at 01:08:11PM +, Richard W.M. Jones wrote: Spotted by 'aozturk' on #virt ... yes, please commit, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/

Re: [libvirt] [PATCH] fix device hotplug

2008-12-18 Thread Daniel Veillard
On Thu, Dec 18, 2008 at 03:45:04PM +0100, Guido Günther wrote: On Thu, Dec 18, 2008 at 10:51:04AM +, Daniel P. Berrange wrote: On Thu, Dec 18, 2008 at 10:26:07AM +0100, Guido G?nther wrote: Hi, due to some restructuring we free the device structure so devices are plugged correctly

Re: [libvirt] [PATCH] fix device hotplug

2008-12-18 Thread Guido Günther
On Thu, Dec 18, 2008 at 05:35:28PM +0100, Daniel Veillard wrote: On Thu, Dec 18, 2008 at 03:45:04PM +0100, Guido Günther wrote: On Thu, Dec 18, 2008 at 10:51:04AM +, Daniel P. Berrange wrote: On Thu, Dec 18, 2008 at 10:26:07AM +0100, Guido G?nther wrote: Hi, due to some

Re: [libvirt] libvirtd crashing with network bridge configuration

2008-12-18 Thread Emre Erenoglu
Hi Daniel, On Thu, Dec 18, 2008 at 1:47 PM, Daniel P. Berrange berra...@redhat.comwrote: ps ax shows the following output right after the service is started: 3605 ?S 0:00 /usr/sbin/libvirtd --daemon 3624 ?Z 0:00 [libvirtd] defunct If I don't enable any