When passing a NULL tapfd argument to brAddTap, we need to close the fd
of the tap device. If we don't, libvirt will keep the fd open
indefinitely and renders the the guest unable to configure its side of
the tap device.
Signed-off-by: Soren Hansen so...@linux2go.dk
---
src/util/bridge.c |2
This patch does two things:
* It makes umlConnectTapDevice ask brAddTap for a persistent tap by
passing it a NULL tapfd argument.
* Stops umlConnectTapDevice from immediately dismantling the bridge
it just set up.
Signed-off-by: Soren Hansen so...@linux2go.dk
---
src/uml/uml_conf.c |
I've been trying to get UML working for the last couple of days. As it stands,
at least bridged networking doesn't work for me. I've got a fix, but I'm not
sure I'm doing it right.
I can get it to fail in three distinct ways:
* With the current code, it seems that the tap device disappears
The current check for the size of the response from the uml monitor is
problematic for a couple of reasons:
First of all, for me, the call to recvfrom returns 0, even though the
buffer actually is populated with the response from the monitor.
Second, it seems to me that (assuming recvfrom
It seems some virtual network card ROMs are this old/buggy so let's add
--dhcp-no-override as a workaround for them. We don't use extra DHCP
options so this should be safe.
Are we guaranteed that --dhcp-no-override is supported as far back as
the earliest version of dnsmasq that we claim
Basically a followup of the previous patch about balloon desactivation
if desactivated, to not ask for balloon information to qemu as we will
just get an error back.
This can make a huge difference in the time needed for domain
information or list when a machine is loaded, and balloon has been
On Thu, Aug 12, 2010 at 12:10:25AM +0200, Soren Hansen wrote:
This patch does two things:
* It makes umlConnectTapDevice ask brAddTap for a persistent tap by
passing it a NULL tapfd argument.
* Stops umlConnectTapDevice from immediately dismantling the bridge
it just set up.
On Thu, Aug 12, 2010 at 11:08:16AM +0200, Soren Hansen wrote:
I've been trying to get UML working for the last couple of days. As it stands,
at least bridged networking doesn't work for me. I've got a fix, but I'm not
sure I'm doing it right.
I can get it to fail in three distinct ways:
On Thu, Aug 12, 2010 at 02:07:41PM +0200, Daniel Veillard wrote:
Basically a followup of the previous patch about balloon desactivation
if desactivated, to not ask for balloon information to qemu as we will
just get an error back.
This can make a huge difference in the time needed for domain
On 12-08-2010 14:20, Daniel P. Berrange wrote:
-brShutdown(brctl);
brShutdown doesn't touch the bridge device at all. This simply closes
the socket file handle we used for talking to the kernel to create
the bridge. Removing this causes an FD leak
Hm, so it does. I'll put it back.
From: Soren Hansen so...@linux2go.dk
If umlBuildCommandLineChr fails (e.g. due to an unsupported chardev
type), it returns NULL. umlBuildCommandLine does not check for this and
sets this as an argument on the comand line, effectively ending the
argument list. This patch checks for this case and
Are we guaranteed that --dhcp-no-override is supported as far back as
the earliest version of dnsmasq that we claim to run with, or do we need
to add some --help parsing?
Hmm, good point. The option was added into dnsmasq-2.41 released on
12-Feb-2008. I'm not sure what version we claim
The problem is that on the source of the migration, libvirtd
is responsible for creating the unix socket over which the data
will flow. Since libvirtd is running as root, this file will
be created as root. When the qemu process running as qemu:qemu
goes to access the unix file to write data to
I changed virStorage[Open|Close] to virVIOSDriver[Open|Close] so
the network driver can use it - since the network driver deals
with Open/Close in the same way.
---
src/phyp/phyp_driver.c | 33 +
1 files changed, 29 insertions(+), 4 deletions(-)
diff --git
On Thu, Aug 12, 2010 at 01:36:06PM +0100, Daniel P. Berrange wrote:
On Thu, Aug 12, 2010 at 02:07:41PM +0200, Daniel Veillard wrote:
Basically a followup of the previous patch about balloon desactivation
if desactivated, to not ask for balloon information to qemu as we will
just get an
Since the qemu process is running as qemu:qemu, it can't actually
look at the unix socket in /var/run/libvirt/qemu which is owned by
root and has permission 700. Move the unix socket to
/var/lib/libvirt/qemu, which is already owned by qemu:qemu.
Thanks to Justin Clift for test this out for me.
Eric Blake wrote:
+p
+ on_crash supports these additional actions.
Should we add a since0.8.4/since tag here?
Hmm, not sure. None of the existing lifecycle documentation contains
since tags.
+++ b/src/conf/domain_conf.c
@@ -81,7 +81,9 @@
v2: Fixes to the nwfilter driver reload function that also needs a
valid virConnectPtr.
In this patch I am extending and fixing the nwfilter module's reload
support to stop all ongoing threads (for learning IP addresses of
interfaces) and rebuild the filtering rules of all interfaces of all
This patch fixes a couple of complaints from valgrind when tickling
libvirtd with SIGHUP.
The first two files contain fixes for memory leaks. The 3rd one
initializes an uninitialized variable. The 4th one is another memory leak.
Here are some example valgrind outputs (not in order of patch
On 08/12/2010 08:25 AM, Chris Lalancette wrote:
The problem is that on the source of the migration, libvirtd
is responsible for creating the unix socket over which the data
will flow. Since libvirtd is running as root, this file will
be created as root. When the qemu process running as
On 08/12/2010 10:57 AM, Chris Lalancette wrote:
Since the qemu process is running as qemu:qemu, it can't actually
look at the unix socket in /var/run/libvirt/qemu which is owned by
root and has permission 700. Move the unix socket to
/var/lib/libvirt/qemu, which is already owned by qemu:qemu.
On Thu, Aug 12, 2010 at 12:57:58PM -0400, Chris Lalancette wrote:
Since the qemu process is running as qemu:qemu, it can't actually
look at the unix socket in /var/run/libvirt/qemu which is owned by
root and has permission 700. Move the unix socket to
/var/lib/libvirt/qemu, which is already
On Thu, Aug 12, 2010 at 02:58:15PM -0400, Stefan Berger wrote:
This patch fixes a couple of complaints from valgrind when tickling
libvirtd with SIGHUP.
Index: libvirt-acl/src/conf/nwfilter_conf.c
===
---
libvir-list-boun...@redhat.com wrote on 08/12/2010 04:26:26 PM:
Please respond to Daniel P. Berrange
On Thu, Aug 12, 2010 at 02:58:15PM -0400, Stefan Berger wrote:
This patch fixes a couple of complaints from valgrind when tickling
libvirtd with SIGHUP.
[...]
ACK, all looks good
---
configure.ac|1 +
src/.gitignore |1 +
src/Makefile.am |9 -
3 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/configure.ac b/configure.ac
index cd48c1b..a762bae 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1866,6 +1866,7 @@ case $host in
# Also
---
configure.ac | 31 +++
1 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/configure.ac b/configure.ac
index a762bae..764405c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -111,18 +111,6 @@ dnl Availability of various common headers (non-fatal if
26 matches
Mail list logo
