Re: [libvirt] [libvirt-users] Help needed in simulating libvirt

2013-09-11 Thread Arun Viswanath
Hi Eric, Thanks for your response. I like to know how test driver works. In the libvirt.org for test driver it is mentioned as It can start with a pre-configured default config, or be given a path to an alternate config. Is the config is an xml file where we mentioned some dummy data so that the

Re: [libvirt] [PATCH] virBitmapFree: Change the function to a macro

2013-09-11 Thread Ján Tomko
On 09/11/2013 04:27 AM, Liuji (Jeremy) wrote: From: Liuji (Jeremy) jeremy@huawei.com Date: Tue, 10 Sep 2013 22:13:32 -0400 Subject: [PATCH] virDomainDefParseXML: set the argument of virBitmapFree to NULL after calling virBitmapFree After freeing the bitmap pointer, it must set the

[libvirt] [PATCH 1/2] LXC: umount the temporary filesystem

2013-09-11 Thread Gao feng
The devpts, dev and fuse filesystems are mounted temporarily. there is no need to export them to container. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_container.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/lxc/lxc_container.c

Re: [libvirt] [PATCH 2/2] LXC: introduce lxcContainerUnmountForSharedRoot

2013-09-11 Thread Gao feng
On 09/11/2013 04:00 PM, Gao feng wrote: Move the unmounting private or useless filesystem of host to this function. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- I forgot to remove the tmp in lxcContainerSetupPivotRoot,a new patchset will come soon. src/lxc/lxc_container.c | 96

[libvirt] [PATCH 2/2] LXC: introduce lxcContainerUnmountForSharedRoot

2013-09-11 Thread Gao feng
Move the unmounting private or useless filesystem of host to this function. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_container.c | 96 - 1 file changed, 55 insertions(+), 41 deletions(-) diff --git a/src/lxc/lxc_container.c

[libvirt] [PATCH v2 1/2] LXC: umount the temporary filesystem created by libvirt

2013-09-11 Thread Gao feng
The devpts, dev and fuse filesystems are mounted temporarily. there is no need to export them to container if container shares the root directory with host. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_container.c | 22 ++ 1 file changed, 22 insertions(+)

[libvirt] [PATCH v2 2/2] LXC: introduce lxcContainerUnmountForSharedRoot

2013-09-11 Thread Gao feng
Move the unmounting private or useless filesystems for container to this function. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_container.c | 98 +++-- 1 file changed, 55 insertions(+), 43 deletions(-) diff --git

Re: [libvirt] [PATCH 2/2] Ensure root filesystem is recursively mounted readonly

2013-09-11 Thread Gao feng
On 09/10/2013 08:46 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com If the guest is configured with filesystem type='mount' source dir='/'/ target dir='/'/ readonly/ /filesystem Then any submounts under / should also end up

Re: [libvirt] [PATCH] build: require libnl-3 if netcf uses it

2013-09-11 Thread Daniel P. Berrange
On Tue, Sep 10, 2013 at 11:52:00AM -0600, Eric Blake wrote: ping; I'm debating about pushing this under the build-breaker rule On 09/04/2013 03:19 PM, Eric Blake wrote: Commits 9298bfb and f6c2951 both tried to make it possible to select the correct libnl (1 vs. 3) according to what netcf

Re: [libvirt] memory pinning problem

2013-09-11 Thread David Weber
Am Freitag, 6. September 2013, 12:10:04 schrieb Daniel P. Berrange: On Tue, Aug 27, 2013 at 09:09:25AM +0200, David Weber wrote: Hi, we try to use vcpu pinning on a 2 socket server with Intel Xeon E5620 cpus, HT enabled and 2*6*16GiB Ram but experience problems if we try to start a

Re: [libvirt] [PATCH v2 3/5] cpu_models: add the support for qemu

2013-09-11 Thread Daniel P. Berrange
On Tue, Sep 10, 2013 at 05:55:57PM -0600, Eric Blake wrote: On 09/06/2013 05:11 PM, Giuseppe Scrivano wrote: Signed-off-by: Giuseppe Scrivano gscri...@redhat.com --- src/qemu/qemu_driver.c | 14 ++ 1 file changed, 14 insertions(+) ACK. Would any of the drivers besides

Re: [libvirt] [libvirt-users] Help needed in simulating libvirt

2013-09-11 Thread Daniel P. Berrange
On Wed, Sep 11, 2013 at 12:50:37PM +0530, Arun Viswanath wrote: Hi Eric, Thanks for your response. I like to know how test driver works. In the libvirt.org for test driver it is mentioned as It can start with a pre-configured default config, or be given a path to an alternate config. Is

[libvirt] [PATCH] Add test for the nodemask double free crash

2013-09-11 Thread Ján Tomko
Commit ef5d51d fixed a crash for numatune with auto placement and nodeset specified: numatune memory mode='preferred' placement='auto' nodeset='0'/ /numatune --- ...qemuxml2argv-numatune-auto-nodeset-invalid.args | 4 +++ .../qemuxml2argv-numatune-auto-nodeset-invalid.xml | 31

Re: [libvirt] memory pinning problem

2013-09-11 Thread Daniel P. Berrange
On Wed, Sep 11, 2013 at 10:47:08AM +0200, David Weber wrote: Am Freitag, 6. September 2013, 12:10:04 schrieb Daniel P. Berrange: On Tue, Aug 27, 2013 at 09:09:25AM +0200, David Weber wrote: Hi, we try to use vcpu pinning on a 2 socket server with Intel Xeon E5620 cpus, HT enabled

Re: [libvirt] [PATCH v2 4/5] cpu_models: add the support for the test protocol

2013-09-11 Thread Giuseppe Scrivano
Daniel P. Berrange berra...@redhat.com writes: +static int +testConnectGetCPUModelNames(virConnectPtr conn ATTRIBUTE_UNUSED, +const char *arch ATTRIBUTE_UNUSED, +char ***models, +unsigned int flags) +{ +

[libvirt] [PATCH v2] Add some notes about security considerations when using LXC

2013-09-11 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Describe some of the issues to be aware of when configuring LXC guests with security isolation as a goal. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- docs/drvlxc.html.in | 103 1 file

Re: [libvirt] [libvirt-users] Help needed in simulating libvirt

2013-09-11 Thread Arun Viswanath
Hi, Thanks for the response. I've used the URI: test+ssh://ipaddress/default and the connection is successful and with that connection I issued getCapabilities and its result is attached. I'm not sure how is result xml generated by the files in the /examples folder. Will you please explain how

Re: [libvirt] [PATCHv6 1/5] domifaddr: Implement the public APIs

2013-09-11 Thread Nehal J Wani
ping On Sun, Sep 8, 2013 at 2:42 PM, Osier Yang jy...@redhat.com wrote: [..] + * + * If 0 is passed as @flags, libvirt will choose the best way, and won't + * include agent in it. I'm thinking if we don't need to be so complicated, by defaulting to one of _LEASE or _SNOOP

Re: [libvirt] [libvirt-users] Help needed in simulating libvirt

2013-09-11 Thread Daniel P. Berrange
On Wed, Sep 11, 2013 at 04:30:13PM +0530, Arun Viswanath wrote: Hi, Thanks for the response. I've used the URI: test+ssh://ipaddress/default and the connection is successful and with that connection I issued getCapabilities and its result is attached. I'm not sure how is result xml

Re: [libvirt] [PATCH libvirt-python 06/17] Remove use of VIR_FREE from code

2013-09-11 Thread Guido Günther
On Mon, Sep 09, 2013 at 05:01:37PM +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com We don't have access to the libvirt memory APIs to replace VIR_FREE with free(). Wouldn't it be easier to port over VIR_FREE? It has some nice features after all. Cheers, --

Re: [libvirt] [PATCH libvirt-python 04/17] Remote compiler annotation attributes

2013-09-11 Thread Guido Günther
On Mon, Sep 09, 2013 at 05:01:35PM +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Remove ATTRIBUTE_NONNULL and ATTRIBUTE_UNUSED Is that because we don't have internal.h? Wouldn't it make sense to move these things over? Cheers, -- Guido Signed-off-by:

Re: [libvirt] [PATCH] Add test for the nodemask double free crash

2013-09-11 Thread Daniel P. Berrange
On Wed, Sep 11, 2013 at 10:58:53AM +0200, Ján Tomko wrote: Commit ef5d51d fixed a crash for numatune with auto placement and nodeset specified: numatune memory mode='preferred' placement='auto' nodeset='0'/ /numatune --- ...qemuxml2argv-numatune-auto-nodeset-invalid.args | 4 +++

Re: [libvirt] [PATCHv2 RESEND] Add forwarders attribute to dns / element.

2013-09-11 Thread Daniel P. Berrange
On Tue, Sep 10, 2013 at 05:26:10PM -0300, Diego Woitasen wrote: Useful to set custom forwarders instead of using the contents of /etc/resolv.conf. It helps me to setup dnsmasq as local nameserver to resolv VM domain names from domain 0, when domain option is used. Signed-off-by: Diego

Re: [libvirt] [libvirt-users] Help needed in simulating libvirt

2013-09-11 Thread Arun Viswanath
Hi Daniel, We are writing a scale test scenario for our client. So for the purpose of scale test with the real code we can't request them to change the URI's, so not too much scope on changing the client. Also we are having some simulated java object of Domain, hypervisor(kvm), etc for which we

[libvirt] [libvirt-tck PATCH] The PXE images moved

2013-09-11 Thread Guido Günther
Adjust to the new URL as describe in: http://dl.fedoraproject.org/pub/fedora/linux/releases/15/README --- conf/default.cfg | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/conf/default.cfg b/conf/default.cfg index a303d88..a8ffecd 100644 --- a/conf/default.cfg

Re: [libvirt] [PATCH] Add test for the nodemask double free crash

2013-09-11 Thread Ján Tomko
On 09/11/2013 01:17 PM, Daniel P. Berrange wrote: On Wed, Sep 11, 2013 at 10:58:53AM +0200, Ján Tomko wrote: Commit ef5d51d fixed a crash for numatune with auto placement and nodeset specified: numatune memory mode='preferred' placement='auto' nodeset='0'/ /numatune ---

Re: [libvirt] [libvirt-tck PATCH] The PXE images moved

2013-09-11 Thread Daniel P. Berrange
On Wed, Sep 11, 2013 at 01:41:21PM +0200, Guido Günther wrote: Adjust to the new URL as describe in: http://dl.fedoraproject.org/pub/fedora/linux/releases/15/README --- conf/default.cfg | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/conf/default.cfg

Re: [libvirt] [libvirt-tck PATCH] The PXE images moved

2013-09-11 Thread Guido Günther
On Wed, Sep 11, 2013 at 12:56:10PM +0100, Daniel P. Berrange wrote: On Wed, Sep 11, 2013 at 01:41:21PM +0200, Guido Günther wrote: Adjust to the new URL as describe in: http://dl.fedoraproject.org/pub/fedora/linux/releases/15/README --- conf/default.cfg | 8 1 file

Re: [libvirt] [libvirt-tck PATCH] The PXE images moved

2013-09-11 Thread Daniel P. Berrange
On Wed, Sep 11, 2013 at 02:13:43PM +0200, Guido Günther wrote: On Wed, Sep 11, 2013 at 12:56:10PM +0100, Daniel P. Berrange wrote: On Wed, Sep 11, 2013 at 01:41:21PM +0200, Guido Günther wrote: Adjust to the new URL as describe in:

Re: [libvirt] [PATCH v2 2/2] LXC: introduce lxcContainerUnmountForSharedRoot

2013-09-11 Thread Daniel P. Berrange
On Wed, Sep 11, 2013 at 04:07:54PM +0800, Gao feng wrote: Move the unmounting private or useless filesystems for container to this function. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_container.c | 98 +++-- 1 file changed,

[libvirt] [PATCH] api-docs: Fix description of virConnectGetType() API function

2013-09-11 Thread Michal Novotny
This fixes the description of virConnectGetType() API function in API documentation to match the real functionality that it can be used to get driver name. Signed-off-by: Michal Novotny minov...@redhat.com --- src/libvirt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [libvirt] [PATCH v2] DBus: introduce virDBusIsServiceEnabled

2013-09-11 Thread Daniel P. Berrange
On Wed, Sep 11, 2013 at 11:15:02AM +0800, Gao feng wrote: This patch introduces virDBusIsServiceEnabled, we can use this method to get if the service is supported. In one case, if org.freedesktop.machine1 is unavailable on host, we should skip creating machine through systemd.

[libvirt] Xen 4.1 misc issues

2013-09-11 Thread Roberto Sassu
Hi everyone I'm using Ubuntu 12.04.3 LTS with the Xen hypervisor installed (package version: 4.1.2-2ubuntu2.10), and Libvirt v0.10.2.2 (that interacts with Xen through the libxl driver). I performed some adjustments to have the required features: - Switch from Xend to libxl: I created

[libvirt] [PATCH] Fix polkit permission names for storage pools, vols node devices

2013-09-11 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The polkit access driver used the wrong permission names for checks on storage pools, volumes and node devices. This led to them always being denied access. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/access/viraccessdriverpolkit.c

Re: [libvirt] [PATCHv2 RESEND] Add forwarders attribute to dns / element.

2013-09-11 Thread Laine Stump
On 09/10/2013 04:26 PM, Diego Woitasen wrote: Useful to set custom forwarders instead of using the contents of /etc/resolv.conf. It helps me to setup dnsmasq as local nameserver to resolv VM domain names from domain 0, when domain option is used. Dang! I had promised to look at this last

[libvirt] [libvirt-tck PATCH v2] Fix path to PXE images

2013-09-11 Thread Guido Günther
The F15 PXE images were removed so switch to F19. --- conf/default.cfg | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/conf/default.cfg b/conf/default.cfg index a303d88..143fba9 100644 --- a/conf/default.cfg +++ b/conf/default.cfg @@ -69,8 +69,8 @@ kernels = (

Re: [libvirt] [libvirt-tck PATCH v2] Fix path to PXE images

2013-09-11 Thread Daniel P. Berrange
On Wed, Sep 11, 2013 at 03:36:31PM +0200, Guido Günther wrote: The F15 PXE images were removed so switch to F19. --- conf/default.cfg | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/conf/default.cfg b/conf/default.cfg index a303d88..143fba9 100644 ---

[libvirt] [v0.9.12-maint 00/11] Debian's 0.9.12 patches

2013-09-11 Thread Guido Günther
These are the patches Debian is currently carrying on 0.9.12. Most are straight cherry-picks. Since we're maintaining 0.9.12 for our current stable release I'm happy to push these to v0.9.12-maint. Ferenc Wágner (1): Fix race condition when destroying guests Guido Günther (1): Include

[libvirt] [v0.9.12-maint 02/11] security: Fix libvirtd crash possibility

2013-09-11 Thread Martin Kletzander
Fix for CVE-2012-4423. When generating RPC protocol messages, it's strictly needed to have a continuous line of numbers or RPC messages. However in case anyone tries backporting some functionality and will skip a number, there is a possibility to make the daemon segfault with newer virsh (version

[libvirt] [v0.9.12-maint 03/11] Include stdint.h for uint32_t

2013-09-11 Thread Guido Günther
to fix the build on kFreeBSD. References: https://buildd.debian.org/status/fetch.php?pkg=libvirtarch=kfreebsd-amd64ver=0.9.12-2stamp=1339698841 --- src/util/virnetlink.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/util/virnetlink.h b/src/util/virnetlink.h index bafe8ca..acd88b7

[libvirt] [v0.9.12-maint 04/11] Revert rpc: Discard non-blocking calls only when necessary

2013-09-11 Thread Jiri Denemark
This reverts commit b1e374a7ac56927cfe62435179bf0bba1e08b372, which was rather bad since I failed to consider all sides of the issue. The main things I didn't consider properly are: - a thread which sends a non-blocking call waits for the thread with the buck to process the call - the code

[libvirt] [v0.9.12-maint 01/11] daemon: Fix crash in virTypedParameterArrayClear

2013-09-11 Thread Jiri Denemark
Daemon uses the following pattern when dispatching APIs with typed parameters: VIR_ALLOC_N(params, nparams); virDomain*(dom, params, nparams, flags); virTypedParameterArrayClear(params, nparams); In case nparams was originally set to 0, virDomain* API would fill it with the number of

[libvirt] [v0.9.12-maint 07/11] qemu: Add support for -no-user-config

2013-09-11 Thread Jiri Denemark
Thanks to this new option we are now able to use modern CPU models (such as Westmere) defined in external configuration file. The qemu-1.1{,-device} data files for qemuhelptest are filled in with qemu-1.1-rc2 output for now. I will update those files with real qemu-1.1 output once it is released.

[libvirt] [v0.9.12-maint 05/11] qemu: Fix off-by-one error while unescaping monitor strings

2013-09-11 Thread Peter Krempa
While unescaping the commands the commands passed through to the monitor function qemuMonitorUnescapeArg() initialized lenght of the input string to strlen()+1 which is fine for alloc but not for iteration of the string. This patch fixes the off-by-one error and drops the pointless check for a

Re: [libvirt] [PATCHv2 RESEND] Add forwarders attribute to dns / element.

2013-09-11 Thread Ján Tomko
On 09/11/2013 03:36 PM, Laine Stump wrote: On 09/10/2013 04:26 PM, Diego Woitasen wrote: Useful to set custom forwarders instead of using the contents of /etc/resolv.conf. It helps me to setup dnsmasq as local nameserver to resolv VM domain names from domain 0, when domain option is used.

Re: [libvirt] [libvirt-tck PATCH v2] Fix path to PXE images

2013-09-11 Thread Guido Günther
On Wed, Sep 11, 2013 at 02:38:19PM +0100, Daniel P. Berrange wrote: On Wed, Sep 11, 2013 at 03:36:31PM +0200, Guido Günther wrote: The F15 PXE images were removed so switch to F19. --- conf/default.cfg | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[libvirt] [v0.9.12-maint 08/11] Make sure regree is called close to it's usage

2013-09-11 Thread Luca Tettamanti
This is a backport of 71da3b66a8455faf8019effe3cf504a31f91f54a. --- src/storage/storage_backend_logical.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/storage/storage_backend_logical.c b/src/storage/storage_backend_logical.c index 9a91dd9..7abb17b 100644 ---

[libvirt] [PATCH] Fix virsystemdtest for previous commit

2013-09-11 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The change to query org.freedesktop.DBus.ListActivatableNames to detect systemd broke the test suite, since we did not have stubs to respond to this dbus call. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- tests/virsystemdmock.c | 54

[libvirt] [v0.9.12-maint 06/11] rpc: Fix crash on error paths of message dispatching

2013-09-11 Thread Peter Krempa
This patch resolves CVE-2013-0170: https://bugzilla.redhat.com/show_bug.cgi?id=893450 When reading and dispatching of a message failed the message was freed but wasn't removed from the message queue. After that when the connection was about to be closed the pointer for the message was still

Re: [libvirt] [PATCH v2] DBus: introduce virDBusIsServiceEnabled

2013-09-11 Thread Daniel P. Berrange
On Wed, Sep 11, 2013 at 01:50:27PM +0100, Daniel P. Berrange wrote: On Wed, Sep 11, 2013 at 11:15:02AM +0800, Gao feng wrote: This patch introduces virDBusIsServiceEnabled, we can use this method to get if the service is supported. In one case, if org.freedesktop.machine1 is unavailable

Re: [libvirt] [Users] VNC/Spice console connection failure

2013-09-11 Thread Michal Skrivanek
On Sep 11, 2013, at 00:11 , Eric Blake ebl...@redhat.com wrote: On 09/10/2013 03:52 PM, Dan Kenigsberg wrote: On Tue, Sep 10, 2013 at 05:31:23PM +, SULLIVAN, Chris (WGK) wrote: Hi Itamar, BZ created: https://bugzilla.redhat.com/show_bug.cgi?id=1006490 Thanks, Thanks, but we

[libvirt] rpmbuild libvirt 1.1.2 problem

2013-09-11 Thread jsjshaowentao
hi: i build rpm in centos 6.2, libvirt version 1.1.2,i found an error FAIL: virsh-uriprecedence Details in the attachment,thanks ! Wait for a response---21CN手机邮Android客户端,邮件随身享! PASS: virshtest PASS: sockettest PASS: nodeinfotest PASS: virbuftest PASS:

[libvirt] [PATCH 4/4] net-dhcp-leases: Add virsh support

2013-09-11 Thread Nehal J Wani
Use virNetworkGetDHCPLeases and virNetworkGetDHCPLeaseForMAC in virsh. The new feature supports the follwing methods: 1. Retrieve leases info for a given virtual network 2. Retrieve leases info for given network interface tools/virsh-domain-monitor.c * Introduce new command :

[libvirt] [PATCH 2/4] net-dhcp-leases: Implement the remote protocol

2013-09-11 Thread Nehal J Wani
Implement RPC calls for virNetworkGetDHCPLeases, virNetworkGetDHCPLeaseForMAC daemon/remote.c * Define remoteSerializeNetworkDHCPLeases, remoteDispatchNetworkGetDHCPLeases * Define remoteDispatchNetworkGetDHCPLeaseForMAC src/remote/remote_driver.c * Define

[libvirt] [PATCH 1/4] net-dhcp-leases: Implement the public APIs

2013-09-11 Thread Nehal J Wani
Introduce 3 new APIs, virNetworkGetDHCPLeases, virNetworkGetDHCPLeaseForMAC and virNetworkDHCPLeaseFree. * virNetworkGetDHCPLeases: returns the dhcp leases information for a given virtual network. The information includes lease expirytime, MAC Address, IP Address, hostname and clientid.

[libvirt] [PATCH 3/4] net-dhcp-leases: Private implementation inside network driver

2013-09-11 Thread Nehal J Wani
By querying the driver for the path of the leases file for the given virtual network and parsing it to retrieve info. src/network/bridge_driver.c: * Implement networkGetDHCPLeases * Implement networkGetDHCPLeaseForMAC * Implement networkGetDHCPLeasesHelper --- src/network/bridge_driver.c

Re: [libvirt] [v0.9.12-maint 06/11] rpc: Fix crash on error paths of message dispatching

2013-09-11 Thread Eric Blake
On 09/11/2013 08:51 AM, Peter Krempa wrote: On 09/11/13 16:00, Peter Krempa wrote: Guido, you should recofigure your git-send-email or other mailer so that it sends patches in your name with a separate From: line in the body. This now looks as if I've sent

Re: [libvirt] [PATCHv2] netcf driver: use a single netcf handle for all connections

2013-09-11 Thread Doug Goldstein
On Wed, Sep 11, 2013 at 10:06 AM, Laine Stump la...@laine.org wrote: This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=983026 The netcf interface driver previously had no state driver associated with it - as a connection was opened, it would create a new netcf instance just for that

[libvirt] [v0.9.12-maint 09/11] conf: Remove callback from stream when freeing entries in console hash

2013-09-11 Thread Peter Krempa
When a domain has a active console connection and is destroyed the callback is called on private data that no longer exist causing a segfault. --- src/conf/virconsole.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/conf/virconsole.c b/src/conf/virconsole.c index 443d80d..e665149

[libvirt] [v0.9.12-maint 07/11] qemu: Add support for -no-user-config

2013-09-11 Thread Jiri Denemark
Thanks to this new option we are now able to use modern CPU models (such as Westmere) defined in external configuration file. The qemu-1.1{,-device} data files for qemuhelptest are filled in with qemu-1.1-rc2 output for now. I will update those files with real qemu-1.1 output once it is released.

[libvirt] [PATCHv2] netcf driver: use a single netcf handle for all connections

2013-09-11 Thread Laine Stump
This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=983026 The netcf interface driver previously had no state driver associated with it - as a connection was opened, it would create a new netcf instance just for that connection, and close it when it was finished. the problem with this is

[libvirt] [PATCH 0/4] Introduce APIs to extract DHCP leases info

2013-09-11 Thread Nehal J Wani
This API returns the information stored in the DHCP leases file created by dnsmasq for a given virtual network. It contacts the bridge network driver, which parses the leases file. It supports two methods: 1. Return info for all network interfaces connected to a given virtual network 2.

[libvirt] [PATCH v3 3/7] virConnectGetCPUModelNames: implement the remote protocol

2013-09-11 Thread Giuseppe Scrivano
Signed-off-by: Giuseppe Scrivano gscri...@redhat.com --- daemon/remote.c | 43 + src/remote/remote_driver.c | 57 src/remote/remote_protocol.x | 20 +++- src/remote_protocol-structs | 11

[libvirt] [v0.9.12-maint 10/11] conf: Remove console stream callback only when freeing console helper

2013-09-11 Thread Peter Krempa
Commit ba226d334acbc49f6751b430e0c4e00f69eef6bf tried to fix crash of the daemon when a domain with an open console was destroyed. The fix was wrong as it tried to remove the callback also when the stream was aborted, where at that point the fd stream driver was already freed and removed. This

[libvirt] [PATCH v3 1/7] libvirt: add new public API virConnectGetCPUModelNames

2013-09-11 Thread Giuseppe Scrivano
The new function virConnectGetCPUModelNames allows to retrieve the list of CPU models known by the hypervisor for a specific architecture. Signed-off-by: Giuseppe Scrivano gscri...@redhat.com --- include/libvirt/libvirt.h.in | 4 python/generator.py | 1 + src/driver.h

[libvirt] [PATCH v3 4/7] virConnectGetCPUModelNames: add the support for qemu

2013-09-11 Thread Giuseppe Scrivano
Signed-off-by: Giuseppe Scrivano gscri...@redhat.com --- src/qemu/qemu_driver.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index bbf2d23..c139daa 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -15880,6

Re: [libvirt] [PATCH] virsh domjobinfo: Do not return 1 if job is NONE

2013-09-11 Thread Ján Tomko
On 09/11/2013 04:16 PM, Jiri Denemark wrote: Commit 38ab1225 changed the default value of ret from true to false but forgot to set ret = true when job is NONE. Thus, virsh domjobinfo returned 1 when there was no job running for a domain but it used to (and should) return 0 in this case. ---

[libvirt] [PATCH] virsh domjobinfo: Do not return 1 if job is NONE

2013-09-11 Thread Jiri Denemark
Commit 38ab1225 changed the default value of ret from true to false but forgot to set ret = true when job is NONE. Thus, virsh domjobinfo returned 1 when there was no job running for a domain but it used to (and should) return 0 in this case. --- tools/virsh-domain.c | 1 + 1 file changed, 1

Re: [libvirt] [PATCH 1/4] net-dhcp-leases: Implement the public APIs

2013-09-11 Thread Daniel P. Berrange
On Wed, Sep 11, 2013 at 09:00:09PM +0530, Nehal J Wani wrote: diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index a47e33c..3885baf 100644 --- a/include/libvirt/libvirt.h.in +++ b/include/libvirt/libvirt.h.in @@ -2800,6 +2800,28 @@ int

Re: [libvirt] [PATCHv2] netcf driver: use a single netcf handle for all connections

2013-09-11 Thread Doug Goldstein
On Wed, Sep 11, 2013 at 10:43 AM, Michal Privoznik mpriv...@redhat.com wrote: On 11.09.2013 17:37, Doug Goldstein wrote: On Wed, Sep 11, 2013 at 10:06 AM, Laine Stump la...@laine.org wrote: This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=983026 The netcf interface driver previously

Re: [libvirt] [PATCHv2] netcf driver: use a single netcf handle for all connections

2013-09-11 Thread Daniel P. Berrange
On Wed, Sep 11, 2013 at 11:06:26AM -0400, Laine Stump wrote: +static void +interfaceDriverLock(virNetcfDriverStatePtr driver) +{ +virObjectLock(driver); +} + +static void +interfaceDriverUnlock(virNetcfDriverStatePtr driver) +{ +virObjectUnlock(driver); +} For everything else

[libvirt] cgroups issues when logind is running without systemd acting as init system

2013-09-11 Thread Laurent Bigonville
Hi, As explained in a bug on the debian BTS[0], I'm getting the following backtrace on my machine when trying to start a domain: Erreur lors du démarrage du domaine: At least one cgroup controller is required: No such device or address Traceback (most recent call last): File

Re: [libvirt] rpmbuild libvirt 1.1.2 problem

2013-09-11 Thread Nehal J Wani
On Wed, Sep 11, 2013 at 10:17 AM, jsjshaowen...@21cn.com wrote: hi: i build rpm in centos 6.2, libvirt version 1.1.2,i found an error FAIL: virsh-uriprecedence Details in the attachment,thanks !Wait for a response ---

Re: [libvirt] [RESEND][PATCHv5 0/4] write separate module for hostdev passthrough

2013-09-11 Thread Jim Fehlig
Chunyan Liu wrote: [rebased to latest libvirt code for applying and reviewing the patches] Odd, but I just noticed that this series is not in the list archives, nor is the original V5 you sent on Sept. 2. You're obviously subscribed to the list, so I wouldn't expect the mails to be held for

Re: [libvirt] [PATCH 1/4] net-dhcp-leases: Implement the public APIs

2013-09-11 Thread Nehal J Wani
On Wed, Sep 11, 2013 at 9:25 PM, Daniel P. Berrange berra...@redhat.com wrote: On Wed, Sep 11, 2013 at 09:00:09PM +0530, Nehal J Wani wrote: diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index a47e33c..3885baf 100644 --- a/include/libvirt/libvirt.h.in +++

[libvirt] [PATCH] Fix launching of VMs on when only logind part of systemd is present

2013-09-11 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Debian systems may run the 'systemd-logind' daemon, which causes the /sys/fs/cgroup/systemd mount to be setup, but no other cgroup controllers are created. While the LXC driver considers cgroups to be mandatory, the QEMU driver is supposed to accept

Re: [libvirt] [PATCH 1/4] net-dhcp-leases: Implement the public APIs

2013-09-11 Thread Laine Stump
On 09/11/2013 01:14 PM, Daniel P. Berrange wrote: On Wed, Sep 11, 2013 at 10:35:04PM +0530, Nehal J Wani wrote: On Wed, Sep 11, 2013 at 9:25 PM, Daniel P. Berrange berra...@redhat.com wrote: On Wed, Sep 11, 2013 at 09:00:09PM +0530, Nehal J Wani wrote: diff --git

Re: [libvirt] [PATCH 1/4] net-dhcp-leases: Implement the public APIs

2013-09-11 Thread Daniel P. Berrange
On Wed, Sep 11, 2013 at 02:18:04PM -0400, Laine Stump wrote: On 09/11/2013 01:14 PM, Daniel P. Berrange wrote: On Wed, Sep 11, 2013 at 10:35:04PM +0530, Nehal J Wani wrote: On Wed, Sep 11, 2013 at 9:25 PM, Daniel P. Berrange berra...@redhat.com wrote: On Wed, Sep 11, 2013 at 09:00:09PM

Re: [libvirt] Xen 4.1 misc issues

2013-09-11 Thread Jim Fehlig
Roberto Sassu wrote: Hi everyone I'm using Ubuntu 12.04.3 LTS with the Xen hypervisor installed (package version: 4.1.2-2ubuntu2.10), and Libvirt v0.10.2.2 (that interacts with Xen through the libxl driver). I performed some adjustments to have the required features: - Switch from Xend

Re: [libvirt] [PATCH 2/4] net-dhcp-leases: Implement the remote protocol

2013-09-11 Thread Nehal J Wani
+ +ret-leases.leases_len = nleases; + +for (i = 0; i nleases; i++) { +virNetworkDHCPLeasesPtr lease = leases[i]; +remote_network_dhcp_lease *lease_ret = (ret-leases.leases_val[i]); +lease_ret-expirytime = lease-expirytime; + +if

Re: [libvirt] [PATCH] Fix polkit permission names for storage pools, vols node devices

2013-09-11 Thread Eric Blake
On 09/11/2013 07:24 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The polkit access driver used the wrong permission names for checks on storage pools, volumes and node devices. This led to them always being denied access. Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH] Fix launching of VMs on when only logind part of systemd is present

2013-09-11 Thread Eric Blake
On 09/11/2013 12:54 PM, Doug Goldstein wrote: +if (got != want) { +fprintf(stderr, Expected cgroup %savailable, but state was wrong\n, Missing a space between the %s and available. +want ? : not ); Intentional; it gives: 'Expected cgroup available' or

Re: [libvirt] [PATCH] Fix launching of VMs on when only logind part of systemd is present

2013-09-11 Thread Doug Goldstein
On Wed, Sep 11, 2013 at 1:18 PM, Daniel P. Berrange berra...@redhat.com wrote: From: Daniel P. Berrange berra...@redhat.com Debian systems may run the 'systemd-logind' daemon, which causes the /sys/fs/cgroup/systemd mount to be setup, but no other cgroup controllers are created. While the

Re: [libvirt] [PATCH] Fix polkit permission names for storage pools, vols node devices

2013-09-11 Thread Eric Blake
On 09/11/2013 01:02 PM, Daniel P. Berrange wrote: action id=org.libvirt.api.node-device.dettach [Ugg - did we REALLY mean to mis-spell detach? Is it too late to fix that?] The bug with using 'nodedevice' instead of 'node-device' means no one could have made use of the permission

Re: [libvirt] [PATCH 1/4] net-dhcp-leases: Implement the public APIs

2013-09-11 Thread Daniel P. Berrange
On Wed, Sep 11, 2013 at 10:35:04PM +0530, Nehal J Wani wrote: On Wed, Sep 11, 2013 at 9:25 PM, Daniel P. Berrange berra...@redhat.com wrote: On Wed, Sep 11, 2013 at 09:00:09PM +0530, Nehal J Wani wrote: diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index

Re: [libvirt] [PATCH] Fix polkit permission names for storage pools, vols node devices

2013-09-11 Thread Daniel P. Berrange
On Wed, Sep 11, 2013 at 12:55:01PM -0600, Eric Blake wrote: On 09/11/2013 07:24 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The polkit access driver used the wrong permission names for checks on storage pools, volumes and node devices. This led to them

Re: [libvirt] [PATCHv2 RESEND] Add forwarders attribute to dns / element.

2013-09-11 Thread Daniel P. Berrange
On Wed, Sep 11, 2013 at 09:36:06AM -0400, Laine Stump wrote: On 09/10/2013 04:26 PM, Diego Woitasen wrote: Useful to set custom forwarders instead of using the contents of /etc/resolv.conf. It helps me to setup dnsmasq as local nameserver to resolv VM domain names from domain 0, when

Re: [libvirt] [PATCH 2/4] net-dhcp-leases: Implement the remote protocol

2013-09-11 Thread Daniel P. Berrange
On Wed, Sep 11, 2013 at 09:00:10PM +0530, Nehal J Wani wrote: diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x index a1c23da..75d2c60 100644 --- a/src/remote/remote_protocol.x +++ b/src/remote/remote_protocol.x @@ -232,6 +232,11 @@ const

Re: [libvirt] [PATCHv2] netcf driver: use a single netcf handle for all connections

2013-09-11 Thread Michal Privoznik
On 11.09.2013 17:37, Doug Goldstein wrote: On Wed, Sep 11, 2013 at 10:06 AM, Laine Stump la...@laine.org wrote: This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=983026 The netcf interface driver previously had no state driver associated with it - as a connection was opened, it would

Re: [libvirt] [v0.9.12-maint 06/11] rpc: Fix crash on error paths of message dispatching

2013-09-11 Thread Peter Krempa
On 09/11/13 16:00, Peter Krempa wrote: Guido, you should recofigure your git-send-email or other mailer so that it sends patches in your name with a separate From: line in the body. This now looks as if I've sent the mail which is not the case. Peter This patch

[libvirt] [v0.9.12-maint 08/11] Make sure regree is called close to it's usage

2013-09-11 Thread Luca Tettamanti
This is a backport of 71da3b66a8455faf8019effe3cf504a31f91f54a. --- src/storage/storage_backend_logical.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/storage/storage_backend_logical.c b/src/storage/storage_backend_logical.c index 9a91dd9..7abb17b 100644 ---

[libvirt] [PATCH v3 7/7] python: add bindings for virConnectGetCPUModelNames

2013-09-11 Thread Giuseppe Scrivano
Signed-off-by: Giuseppe Scrivano gscri...@redhat.com --- python/generator.py | 2 +- python/libvirt-override-api.xml | 7 ++ python/libvirt-override.c | 52 + python/libvirt-override.py | 11 + 4 files changed, 71

[libvirt] [PATCH v3 0/7] add new API virConnectGetCPUModelNames

2013-09-11 Thread Giuseppe Scrivano
This series adds a new API virConnectGetCPUModelNames that allows to retrieve the list of CPU models known by the hypervisor for a specific architecture. This new function is mainly needed by virt-manager to not read directly the cpu_map.xml file (it could also be different when accessing a

[libvirt] [v0.9.12-maint 11/11] Fix race condition when destroying guests

2013-09-11 Thread Ferenc Wágner
Backport of 81621f3e6e45e8681cc18ae49404736a0e772a11 and f1b4021b38f9485c50d386af6f682ecfc8025af5 to fix a race (resulting in a segfault) when destroying domains. --- src/qemu/qemu_driver.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git

[libvirt] [PATCH v3 5/7] virConnectGetCPUModelNames: add the support for the test protocol

2013-09-11 Thread Giuseppe Scrivano
Signed-off-by: Giuseppe Scrivano gscri...@redhat.com --- src/test/test_driver.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index f9eee44..fb4c1d9 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -54,6 +54,7

[libvirt] [PATCH v3 6/7] virsh: add function to get the CPU models for an arch

2013-09-11 Thread Giuseppe Scrivano
Signed-off-by: Giuseppe Scrivano gscri...@redhat.com --- tools/virsh-host.c | 54 ++ tools/virsh.pod| 5 + 2 files changed, 59 insertions(+) diff --git a/tools/virsh-host.c b/tools/virsh-host.c index 880ae4b..5d47428 100644 ---

[libvirt] [PATCH v3 2/7] cpu: add function to get the models for an arch

2013-09-11 Thread Giuseppe Scrivano
Signed-off-by: Giuseppe Scrivano gscri...@redhat.com --- src/cpu/cpu.c| 56 src/cpu/cpu.h| 3 +++ src/libvirt_private.syms | 1 + 3 files changed, 60 insertions(+) diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c index

Re: [libvirt] [v0.9.12-maint 08/11] Make sure regree is called close to it's usage

2013-09-11 Thread Eric Blake
On 09/11/2013 08:00 AM, Luca Tettamanti wrote: This is a backport of 71da3b66a8455faf8019effe3cf504a31f91f54a. --- src/storage/storage_backend_logical.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) This is not identical to the contents of 71da3b6 (it's missing the last hunk, but

Re: [libvirt] [v0.9.12-maint 10/11] conf: Remove console stream callback only when freeing console helper

2013-09-11 Thread Eric Blake
On 09/11/2013 08:17 AM, Peter Krempa wrote: Commit ba226d334acbc49f6751b430e0c4e00f69eef6bf tried to fix crash of the daemon when a domain with an open console was destroyed. The fix was wrong as it tried to remove the callback also when the stream was aborted, where at that point the fd

Re: [libvirt] [v0.9.12-maint 03/11] Include stdint.h for uint32_t

2013-09-11 Thread Eric Blake
On 09/11/2013 07:59 AM, Guido Günther wrote: to fix the build on kFreeBSD. References: https://buildd.debian.org/status/fetch.php?pkg=libvirtarch=kfreebsd-amd64ver=0.9.12-2stamp=1339698841 --- src/util/virnetlink.h | 2 ++ 1 file changed, 2 insertions(+) It looks like

  1   2   >