On 01/14/2014 09:40 PM, Daniel P. Berrange wrote:
On Mon, Jan 13, 2014 at 06:28:07PM +0800, m...@linux.vnet.ibm.com wrote:
From: Bing Bu Cao m...@linux.vnet.ibm.com
To retrieve node cpu statistics on Linux system, the
linuxNodeGetCPUstats function use STRPREFIX() to match the
cpuid with the
From: Bing Bu Cao m...@linux.vnet.ibm.com
To retrieve node cpu statistics on Linux system, the
linuxNodeGetCPUstats function simply uses STRPREFIX() to match the
cpuid with the cpuid read from /proc/stat, it will cause
obvious error.
For example:
'virsh nodecpustats 1' will display stats of
From: Bing Bu Cao m...@linux.vnet.ibm.com
To retrieve node cpu statistics on Linux system, the
linuxNodeGetCPUstats function simply uses STRPREFIX() to match the
cpuid with the cpuid read from /proc/stat, it will cause
obvious error.
For example:
'virsh nodecpustats 1' will display stats of
On Wed, Jan 15, 2014 at 01:47:48PM -0700, Eric Blake wrote:
On 01/15/2014 01:43 PM, Eric Blake wrote:
On 01/11/2014 07:27 AM, Guido Günther wrote:
Hi,
attached patches backport the fixes for CVE-2013-6458 to v0.9.12-maint. I
decided to cherry-pick the introduction of VIR_STRDUP and
If nodedev-detach with '--driver', it does not check whether host
currentlly supports vfio passthrough. That will cause the detached
node device failed to bind to vfio driver when iommu is off:
kernel: vfio-pci: probe of :01:00.0 failed with error -22
On 01/15/2014 06:50 PM, Daniel P. Berrange wrote:
On Wed, Jan 15, 2014 at 04:47:21PM +0800, Gao feng wrote:
the array params is allocated by VIR_ALLOC_N in cmdCPUStats.
it had been set to zero. No need to reset it to zero again,
and this reset here is incorrect too, nparams * ncpus is the
On Thu, Jan 16, 2014 at 16:59:50 +0800, Jincheng Miao wrote:
If nodedev-detach with '--driver', it does not check whether host
currentlly supports vfio passthrough. That will cause the detached
node device failed to bind to vfio driver when iommu is off:
kernel: vfio-pci: probe of :01:00.0
OK, hope it helpful.
- Original Message -
Thanks, I'll include a polished version of this patch in my series
fixing bug 1046919.
Jirka
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
- Original Message -
From: Doug Goldstein car...@cardoe.com
To: Francesco Romani from...@redhat.com
Cc: libvir-list@redhat.com, Francesco Romani from...@redhat.com
Sent: Thursday, January 16, 2014 4:24:51 AM
Subject: Re: [libvirt] [PATCH 2/2] spice: expose the QEMU disable file
Looks good to me with an amended commit log as pointed out by Doug.
ACK from me (and 1.2.1 has been released, so it no longer needs to wait for
end of freeze).
Christophe
On Wed, Jan 15, 2014 at 05:33:46PM +0100, Francesco Romani wrote:
Changes v4:
Addressed Christophe's comment and changed
As scheduled I just tagged the git tree and pushed the tarball and rpms
to the usual place:
ftp://libvirt.org/libvirt/
the next relase is planned at the end of February.
This is a bug fix release, we never had that many security advisories
closed in a single release, and there is a lot of
I also pushed a new release of libvirt python, it is available at:
ftp://libvirt.org/libvirt/python/
contains a few fixes and a number of improvement especially toward
portability and compatibility with python3:
Features:
- Add python3 to the automated build and RPM (Daniel P. Berrange)
-
---
Hey, I've raised libvirt version to 1.2.2 right after release
following
https://www.redhat.com/archives/libvir-list/2013-December/msg00657.html
I've pushed it directly as imo it qualifies as trivial.
Christophe
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Dear developers,
As we know libvirt.py using libvirtmod.so, eg:
def defineXML(self, xml):
Define a domain, but does not start it.
This definition is persistent, until explicitly undefined with
virDomainUndefine(). A previous definition for this domain would be
On Thu, Jan 16, 2014 at 11:19:57AM +0100, Christophe Fergeau wrote:
---
Hey, I've raised libvirt version to 1.2.2 right after release
following
https://www.redhat.com/archives/libvir-list/2013-December/msg00657.html
I've pushed it directly as imo it qualifies as trivial.
ACK, yes that's
On Thu, Jan 16, 2014 at 06:31:02PM +0800, me,apporc wrote:
Dear developers,
As we know libvirt.py using libvirtmod.so, eg:
def defineXML(self, xml):
Define a domain, but does not start it.
This definition is persistent, until explicitly undefined with
On 01/09/14 23:40, Eric Blake wrote:
On 01/06/2014 09:44 AM, Peter Krempa wrote:
Separate the steps to create libvirt's volume metadata from the actual
volume building process. This is already done for regular file based
pools to allow job support for storage APIs.
---
On 01/09/14 23:47, Eric Blake wrote:
On 01/09/2014 09:15 AM, Peter Krempa wrote:
To allow using the storage driver APIs to do operation on generic domain
disks we will need to introduce internal storage pools that will give is
a base to support this stuff even on files that weren't originally
On 15.01.2014 18:06, Yuto KAWAMURA(kawamuray) wrote:
From: Yuto KAWAMURA(kawamuray) kawamuray.dad...@gmail.com
Introduce Wireshark dissector plugin which adds support to Wireshark
for dissecting libvirt RPC protocol.
Added following files to build Wireshark dissector from libvirt source
On 15.01.2014 18:06, Yuto KAWAMURA(kawamuray) wrote:
From: Yuto KAWAMURA(kawamuray) kawamuray.dad...@gmail.com
Add directory tools/wireshark/samples/ and
libvirt-sample.pdml which is sample output of dissector.
---
tools/wireshark/samples/libvirt-sample.pdml | 206
On 01/16/2014 01:09 AM, Bing Bu Cao wrote:
Can you also provide a test case to validate this. You just
need to get a suitable /proc/cpustat file and save it in the
tests/ dir and then include linuxNodeGetCPUStats() using that
file.
I found there is no test case for linuxNodeGetCPUStats()
On 10.01.2014 01:20, Eric Blake wrote:
On 01/09/2014 05:12 PM, Eric Blake wrote:
On 01/07/2014 08:20 AM, Michal Privoznik wrote:
Currently, the @flags usage is a bit unclear at first sight to say the
least. There's no need for such unclear code especially when we can
borrow the working code
The temporary pool code will need to initialize some fields for the
temporary gluster volumes. This is done by the createVol function of
the storage backend. This patch implements only the metadata setting.
Attempts to create a regular volume yield an error.
---
If a VM driver wants to access stuff provided by a storage driver the
volume needs to be a part of a storage pool. As this wasn't designed in
from the beginning we need a way to convert generic domain disk and
snapshot disk definitions into temporary pools and volumes. This patch
allows that by
The new argument will be used when creating definitions for volumes that
already exist for the temporary storage volume APIs. The argument will
modify the expectations about the storage files and suppress some error
reports.
---
Notes:
Version 2:
- add commit message lost in a botched
Peter Krempa (9):
storage: Add new argument for createVol backend API
storage: gluster: Introduce dummy functions for creating a volume
storage: Add internal API to create temporary storage pools and vols
snapshot: Add support for specifying snapshot disk backing type
snapshot: Test
Add support for specifying various types when doing snapshots. This will
later allow to do snapshots on network backed volumes. Disks of type
'volume' are not supported by snapshots (yet).
---
Notes:
Version 2:
- always format disk type and fix fallout
docs/formatsnapshot.html.in
Add code to convert a regular guest volume into a ephemeral pool.
---
src/storage/storage_driver.c | 154 ++-
1 file changed, 151 insertions(+), 3 deletions(-)
diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c
index c82c620..00bf8a5
This patch implements the APIs for creating temporary storage pools for
the generic storage driver.
---
src/check-aclrules.pl| 3 +
src/storage/storage_driver.c | 253 +++
2 files changed, 256 insertions(+)
diff --git a/src/check-aclrules.pl
Use the new storage conversion APIs to delete garbage left behind after
a failed snapshot attempt using the storage driver.
---
src/qemu/qemu_driver.c | 60 ++
1 file changed, 46 insertions(+), 14 deletions(-)
diff --git a/src/qemu/qemu_driver.c
Amend tests to check parsing of the various new disk types that can now
be specified.
---
tests/domainsnapshotxml2xmlin/disk_snapshot.xml | 18 ++
tests/domainsnapshotxml2xmlout/disk_snapshot.xml | 18 ++
2 files changed, 36 insertions(+)
diff --git
Add support for gluster backed images as sources for snapshots in the
qemu driver. This will also simplify adding further network backed
volumes as sources for snapshot in case qemu will support them.
---
docs/formatsnapshot.html.in | 4 +-
src/qemu/qemu_command.c | 2 +-
On 01/16/2014 09:13 AM, m...@linux.vnet.ibm.com wrote:
From: Bing Bu Cao m...@linux.vnet.ibm.com
To retrieve node cpu statistics on Linux system, the
linuxNodeGetCPUstats function simply uses STRPREFIX() to match the
cpuid with the cpuid read from /proc/stat, it will cause
obvious error.
On Thu, Jan 16, 2014 at 06:06:57AM -0700, Eric Blake wrote:
On 01/16/2014 01:09 AM, Bing Bu Cao wrote:
Can you also provide a test case to validate this. You just
need to get a suitable /proc/cpustat file and save it in the
tests/ dir and then include linuxNodeGetCPUStats() using that
On 16/01/14 08:51, John Ferlan wrote:
On 01/08/2014 09:51 AM, Osier Yang wrote:
It doesn't make sense to fail if the SCSI host device is specified
as shareable explicitly between domains (NB, it works if and only
if the device is specified as shareable for *all* domains,
otherwise it fails).
In a for loop there are created two new strings and they may not
be freed if a target string cannot be obtained. We have to free
the two created strings to prevent the memory leak.
This has been found by coverity.
John also pointed out that we should somehow care about the type
and device and
From: Pradipta Kr. Banerjee bpra...@in.ibm.com
Creating a qemu VM with /dev/hwrng as backend RNG device throws the
following error - Could not open '/dev/hwrng': Permission denied
This patch fixes the issue
Signed-off-by: Pradipta Kr. Banerjee bpra...@in.ibm.com
---
v2: Added acl code as part of
On 01/16/2014 08:33 AM, Pavel Hrdina wrote:
In a for loop there are created two new strings and they may not
be freed if a target string cannot be obtained. We have to free
the two created strings to prevent the memory leak.
This has been found by coverity.
John also pointed out that we
[ shrinked ]
---
src/libvirt_private.syms | 2 +-
src/qemu/qemu_hostdev.c | 75 ++--
src/util/virscsi.c | 48 +--
src/util/virscsi.h | 7 +++--
4 files changed, 84 insertions(+), 48 deletions(-)
diff --git
On 16.1.2014 14:43, John Ferlan wrote:
On 01/16/2014 08:33 AM, Pavel Hrdina wrote:
In a for loop there are created two new strings and they may not
be freed if a target string cannot be obtained. We have to free
the two created strings to prevent the memory leak.
This has been found by
Hi all,
We've created a new wiki page [1] where we would like to create a list
of areas that we should focus on testing.
If there is something critical or important what you think that should
be really tested please feel free to update the wiki page. You should
write down what part or
On 01/16/2014 08:53 AM, Osier Yang wrote:
...snip...
It took some thinking, but I convinced myself that this path doesn't
need the shared check since it's only called from qemuProcessReconnect;
however, if something else did call it some day then that check may be
necessary. It may be
spice-server offers an API to disable file transfer messages
on the agent channel between the client and the guest.
This is supported in qemu through the disable-agent-file-xfer option.
This patch detects if QEMU supports this option, and add
a capability if does.
Signed-off-by: Francesco Romani
spice-server offers an API to disable file transfer messages
on the agent channel between the client and the guest.
This is supported in qemu through the disable-agent-file-xfer option.
This patch exposes this option to libvirt.
Adds a new element 'filetransfer', with one property,
'enable',
---
src/main/java/org/libvirt/Connect.java | 35 +++
src/main/java/org/libvirt/Domain.java | 46 -
src/test/java/org/libvirt/TestJavaBindings.java | 4 +++
3 files changed, 84 insertions(+), 1 deletion(-)
diff --git
The getSchedulerType method returns a String (the name of the
scheduler), not a String array containing a single element.
It's OK to just pass null for the second argument to
virDomainGetSchedulerType.
Ensure to free the returned string.
---
src/main/java/org/libvirt/Domain.java | 43
---
src/main/java/org/libvirt/StorageVol.java | 10 +-
src/main/java/org/libvirt/jna/Libvirt.java | 2 +-
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/src/main/java/org/libvirt/StorageVol.java
b/src/main/java/org/libvirt/StorageVol.java
index 1573070..7035c93 100644
These fields of the Error class are no longer used, no need to
keep them around.
---
src/main/java/org/libvirt/Error.java | 6 --
1 file changed, 6 deletions(-)
diff --git a/src/main/java/org/libvirt/Error.java
b/src/main/java/org/libvirt/Error.java
index 6f68f57..9da3a80 100644
---
We need to free the char* entries of the result array returned ourselves.
---
src/main/java/org/libvirt/Domain.java | 14 +++---
src/main/java/org/libvirt/jna/Libvirt.java | 2 +-
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/main/java/org/libvirt/Domain.java
On Thu, Jan 09, 2014 at 09:22:06AM +0100, Martin Kletzander wrote:
There is a number of reported issues when we fail starting a domain.
Turns out that, in some scenarios like high load, 3 second timeout is
not enough for qemu to start up to the phase where the socket is
created. Since the
Changes v6:
amended commit message for patch #2 as suggested by Doug.
Francesco Romani (2):
spice: detect if qemu can disable file transfer
spice: expose the QEMU disable file transfer option
docs/formatdomain.html.in | 8 +
docs/schemas/domaincommon.rng
On Thu, Jan 16, 2014 at 04:11:07PM +, Daniel P. Berrange wrote:
On Thu, Jan 09, 2014 at 09:22:06AM +0100, Martin Kletzander wrote:
There is a number of reported issues when we fail starting a domain.
Turns out that, in some scenarios like high load, 3 second timeout is
not enough for
We need to free the char* entries of the result array returned
ourselves.
---
src/main/java/org/libvirt/StoragePool.java | 13 ++---
src/main/java/org/libvirt/jna/Libvirt.java | 2 +-
2 files changed, 11 insertions(+), 4 deletions(-)
diff --git
This fixes a few memleaks and other errors.
Note, that the memleak patches depend on the error refactoring
patches I posted to this list[1]
[1] https://www.redhat.com/archives/libvir-list/2014-January/msg00415.html
Claudio Bley (10):
Implement equals and hashCode methods for Connect and
java/org/libvirt/Error.java:217:
The static method wrap(int) from the type Error.ErrorDomain should be
accessed in a static way
---
src/main/java/org/libvirt/Error.java | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/main/java/org/libvirt/Error.java
---
src/main/java/org/libvirt/StorageVol.java | 8 +++-
src/main/java/org/libvirt/jna/Libvirt.java | 2 +-
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/main/java/org/libvirt/StorageVol.java
b/src/main/java/org/libvirt/StorageVol.java
index 7035c93..47b79f6 100644
---
Eclipse generates this kind of warning:
org/libvirt/jna/virConnectCredential.java:20:
List is a raw type. References to generic type ListE should be parameterized
---
src/main/java/org/libvirt/jna/virConnectAuth.java | 4 ++--
src/main/java/org/libvirt/jna/virConnectCredential.java|
---
src/main/java/org/libvirt/DomainSnapshot.java | 10 +-
src/main/java/org/libvirt/jna/Libvirt.java| 2 +-
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/src/main/java/org/libvirt/DomainSnapshot.java
b/src/main/java/org/libvirt/DomainSnapshot.java
index
Ping? Can we at least change the default [2/2] or should I send a v2
for that one?
Martin
On Fri, Jan 10, 2014 at 04:27:40PM +0100, Martin Kletzander wrote:
On Fri, Jan 10, 2014 at 02:18:37PM +, Daniel P. Berrange wrote:
On Thu, Jan 09, 2014 at 09:22:05AM +0100, Martin Kletzander wrote:
On 01/15/2014 06:01 PM, John Ferlan wrote:
On 01/15/2014 04:07 PM, Eric Blake wrote:
On 01/15/2014 07:32 AM, John Ferlan wrote:
I don't see a reason other than proximity to release date to preclude
inclusion in 1.2.1
So more to the point, should I push now, or wait until post-release?
On Fri, Dec 6, 2013 at 11:13 AM, Christophe Fergeau cferg...@redhat.com wrote:
This class wraps creation of configuration data for the driver part of a
domain disk device. The methods needed for this are currently part of
GVirConfigDomainDisk, but since the disk driver is getting more and more
On Fri, Dec 6, 2013 at 11:13 AM, Christophe Fergeau cferg...@redhat.com wrote:
---
libvirt-gconfig/libvirt-gconfig-domain-disk.c | 42 +++
libvirt-gconfig/libvirt-gconfig-domain-disk.h | 58
+++
libvirt-gconfig/libvirt-gconfig.sym | 3 ++
On Fri, Dec 6, 2013 at 11:13 AM, Christophe Fergeau cferg...@redhat.com wrote:
They are replaced by equivalent methods in GVirConfigDomainDiskDriver.
Initially, we had only one or two attributes to set on the 'driver' child
of the 'disk' node. Nowadays, we more than 5 attributes to set on this
On Thu, Jan 2, 2014 at 11:03 AM, Christophe Fergeau cferg...@redhat.com wrote:
On Fri, Dec 06, 2013 at 12:10:29PM +0100, Christophe Fergeau wrote:
Commit 1c8ce29 added a way to unset a GVirConfigDomainClock set on a
GVirConfigDomain by calling gvir_config_domain_set_clock() with a NULL
On Fri, Dec 6, 2013 at 11:13 AM, Christophe Fergeau cferg...@redhat.com wrote:
---
ACK
--
Regards,
Zeeshan Ali (Khattak)
FSF member#5124
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
libvirt 0.9.12.3 maintenance release is now available. This is libvirt
0.9.12 with additional bugfixes that have accumulated upstream since the
initial release. It fixes CVE-2013-6458 and CVE-2014-1447.
This release can be downloaded at:
libvirt 1.1.3.3 maintenance release is now available. This is
libvirt 1.1.3 with additional bugfixes that have accumulated
upstream since the initial release.
This release can be downloaded at:
http://libvirt.org/sources/stable_updates/libvirt-1.1.3.3.tar.gz
Changes in this version:
*
libvirt 1.0.5.9 maintenance release is now available. This is
libvirt 1.0.5 with additional bugfixes that have accumulated
upstream since the initial release.
This release can be downloaded at:
http://libvirt.org/sources/stable_updates/libvirt-1.0.5.9.tar.gz
Changes in this version:
* Fix race
On Thu, Jan 16, 2014 at 9:07 AM, Doug Goldstein car...@cardoe.com wrote:
On Jan 14, 2014, at 2:09 PM, Nehal J Wani nehaljw.k...@gmail.com wrote:
Introduce helper program to catch events from dnsmasq and maintain a custom
lease file per network. It supports DHCPv4 and DHCPv6. The file is saved
Add VIR_DOMAIN_HOSTDEV_PCI_BACKEND_XEN. For legacy xen, it will use pciback as
stub driver.
Signed-off-by: Chunyan Liu cy...@suse.com
---
docs/schemas/domaincommon.rng |1 +
src/conf/domain_conf.c|3 ++-
src/conf/domain_conf.h|1 +
src/libxl/libxl_domain.c |9
These patches implements a separate module for hostdev passthrough so that it
could be shared by different drivers and can maintain a global state of a host
device.
patch 1/6: extract hostdev passthrough function from qemu_hostdev.c and make it
reusable by multiple drivers.
patch 2/6: add a unit
Change lxc driver to use hostdev common library instead of APIs in
lxc_hostdev.[ch]
Signed-off-by: Chunyan Liu cy...@suse.com
---
po/POTFILES.in|1 -
src/Makefile.am |1 -
src/lxc/lxc_conf.h|4 -
src/lxc/lxc_driver.c | 47 ---
src/lxc/lxc_hostdev.c | 416
Add pci passthrough to libxl driver, support attach-device, detach-device and
start a vm with pci hostdev specified.
Signed-off-by: Chunyan Liu cy...@suse.com
---
src/libxl/libxl_conf.c | 63 +++
src/libxl/libxl_conf.h |4 +
src/libxl/libxl_driver.c | 448
Add unit test for hostdev common library. Current tests are based on virpcimock.
Signed-off-by: Chunyan Liu cy...@suse.com
---
tests/Makefile.am |5 +
tests/virhostdevtest.c | 473
tests/virpcimock.c | 23 +++-
3 files changed, 500
On 16/01/14 23:39, John Ferlan wrote:
On 01/16/2014 08:53 AM, Osier Yang wrote:
...snip...
It took some thinking, but I convinced myself that this path doesn't
need the shared check since it's only called from qemuProcessReconnect;
however, if something else did call it some day then that
75 matches
Mail list logo
