g as simple as adding some sort of language=
> tag to feed to $(_sc_search_regexp (if not specified, run on all files,
> but if specified as C, the syntax-check is specific to C-like files, so
> it limits to .h, .c. .y).
>
> I'm adding the gnulib list to get feedback on the idea; maybe
sharing).
---
src/util/virstoragefile.c | 9 -
src/util/virstoragefile.h | 1 +
2 files changed, 9 insertions(+), 1 deletion(-)
Coreutils includes a rather extensive list of file systems (alas, it's
GPLv3+ code, so we can't use it verbatim without asking Jim Meyering and
other coreutils
tags 6004 + notabug
close 6004
thanks
Eric Blake wrote:
[adding bug-coreutils]
On 04/22/2010 04:37 AM, Daniel P. Berrange wrote:
- if (virAsprintf(dest, exec:%s %s 2/dev/null, argstr,
safe_target) 0) {
+if (virAsprintf(dest, exec:%s | dd of=%s seek=%llub,
+argstr,
Eric Blake wrote:
On 10/25/2012 05:12 PM, Laine Stump wrote:
What would be *really* nice is if git could give a *warning* if you
tried to do git add . and it found any of those files - it would prevent
the cases where you forget to save a file that you've modified.
If you write ChangeLog
When I run ./autogen.sh make, I see this:
(this arose because I had the latest automake.git/master tools --
commit c1b83e1af60b866cf5cdeebf77d0275019bad8b2 from today --
early in my path)
Generated 3 wrapper functions
CC libvirtmod_la-libvirt-override.lo
CC
Hello,
In case someone is interested in weeding out the inevitable false
positives, here is a slightly filtered list of misspelled words
in libvirt, as detected by the misspellings program from here:
http://github.com/lyda/misspell-check
Here's the output from this command:
misspellings $(git
Eric Blake wrote:
Any time we have a string with no % passed through gettext, a
translator can inject a % to cause a stack overread. When there
is nothing to format, it's easier to ask for a string that cannot
be used as a formatter, by using a trivial %s format instead.
In the past, we
Eric Blake wrote:
...
This [change-set] LOOKS huge, but is really just a couple of 'git mv'
commands and a change to nodeinfotest.c. Scroll to the bottom for
the real change; I've shortened boring parts of this mail to get past
the 100k mail cap enforced by the list.
If you set git diff's
When I built libvirt recently, I saw a warning go by:
(with cutting edge automake-1.12a)
configure.ac:83: warning: macro 'AM_PROG_CC_STDC' not found in library
This fixes it:
From 8f66a7e7f12efa2a60754f06627e94d96030ac78 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date
Eric Blake wrote:
On 05/26/2012 03:25 AM, Jim Meyering wrote:
When I built libvirt recently, I saw a warning go by:
(with cutting edge automake-1.12a)
configure.ac:83: warning: macro 'AM_PROG_CC_STDC' not found in library
This fixes it:
From 8f66a7e7f12efa2a60754f06627e94d96030ac78 Mon
Investigating a build problem reported by Laine,
I was surprised to see make check fail on F17 due to a
glibc invalid free abort. Ok to push to master?
From 61a559e0b2f4bded3059c5be7c958e2276f7fd16 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Mon, 7 May 2012 21:22:09
Eric Blake wrote:
On 05/07/2012 01:29 PM, Jim Meyering wrote:
Investigating a build problem reported by Laine,
I was surprised to see make check fail on F17 due to a
glibc invalid free abort. Ok to push to master?
From 61a559e0b2f4bded3059c5be7c958e2276f7fd16 Mon Sep 17 00:00:00 2001
From
Eric Blake wrote:
[adding bug-gnulib]
On 04/24/2012 06:22 AM, Eric Blake wrote:
On 04/24/2012 03:50 AM, Peter Krempa wrote:
Commit c9cd419caba9effa11ca53e8696e5f6a4b424d60 added copying of the
makefile for translation files from gnulib. The makefile from gnulib is
of version 0.18 but the
Eric Blake wrote:
On 03/01/2012 09:53 AM, Daniel P. Berrange wrote:
On Thu, Mar 01, 2012 at 11:43:04AM -0500, Laine Stump wrote:
Commit 7c90026 added #include conf/domain_conf.h to
util/virrandom.c. Fortunately it didn't actually use anything from
domain_conf.h, since as far as I'm aware,
Daniel P. Berrange wrote:
On Tue, Mar 29, 2011 at 02:55:28PM +0200, Jim Meyering wrote:
In case someone else encounters this...
Today none of my VMs would start on F15:
# virsh create rawhide.xml
error: Failed to create domain from rawhide.xml
error: Unable to create cgroup
In case someone else encounters this...
Today none of my VMs would start on F15:
# virsh create rawhide.xml
error: Failed to create domain from rawhide.xml
error: Unable to create cgroup for rawhide: No such file or directory
Luckily, I noticed that Rich Jones had the same problem
a
Eric Blake wrote:
[adding Jim to cc, as author of useless-if-before-free]
On 02/17/2011 02:14 PM, Christophe Fergeau wrote:
virHashFree follows the convention described in HACKING that
XXXFree() functions can be called with a NULL argument.
---
src/conf/domain_conf.c |6 +---
Eric Blake wrote:
On 01/28/2011 05:52 AM, Juerg Haefliger wrote:
---
docs/page.xsl | 350
1 files changed, 175 insertions(+), 175 deletions(-)
ACK, applied. po/ca.po is the only other file with bad line endings,
but that
Hi DV,
I ran this on a fresh clone of libvirt:
$ du -sh .git; git gc --aggressive; du -sh .git
54M .git
...
45M .git
I propose to do the same thing on the server, libvirt.org.
It's not a big deal, but decreased bandwidth wouldn't hurt,
and the slightly smaller on-disk
Daniel Veillard wrote:
...
xmlsoft:~ - cat bin/GitMaintainance
#!/bin/sh
# Garbage collect the libvirt GIT repository
git --git-dir /git/libvirt.git gc $HOME/tmp/GitMaintainance.log 21
xmlsoft:~ - crontab -l | grep GitMaintainance
4 4 * * Sun /u/veillard/bin/GitMaintainance
xmlsoft:~ -
Daniel Veillard wrote:
On Wed, Jan 12, 2011 at 12:01:12PM +0100, Jim Meyering wrote:
Daniel Veillard wrote:
...
xmlsoft:~ - cat bin/GitMaintainance
#!/bin/sh
# Garbage collect the libvirt GIT repository
git --git-dir /git/libvirt.git gc $HOME/tmp/GitMaintainance.log 21
xmlsoft
Justin Clift wrote:
On 30/11/2010, at 12:35 AM, Matthias Bolte wrote:
Looks like the system is missing pkg-config, or at least has the .m4
file is in an unexpected place so that autoconf can't find it.
bootstrap checks for pkg-config, so the binary is probably there, but
that doesn't mean
Eric Blake wrote:
[adding bug-gnulib]
On 10/28/2010 01:25 PM, Daniel Veillard wrote:
case 'v':
-/* FIXME - list a copyright blurb, as in GNU programs? */
-puts(VERSION);
+vshShowVersion(ctl);
exit(EXIT_SUCCESS);
Pre-existing bug
Bruno Haible wrote:
Hi Eric,
case 'v':
-/* FIXME - list a copyright blurb, as in GNU programs? */
-puts(VERSION);
+vshShowVersion(ctl);
exit(EXIT_SUCCESS);
The gnulib module closeout can automatically take care of this, but
Matthias Bolte wrote:
2010/7/13 Jim Meyering j...@meyering.net:
coverity spotted the expressions that could never be true:
(a b c) 0. Here's the fix:
From 6d61d90a6df81900f4b2be752403758175000973 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 13 Jul 2010 15
Matthias Bolte wrote:
2010/7/13 Jim Meyering j...@meyering.net:
The stray 0 removed by the fix below
would have made umlMonitorCommand always fail
with its incomplete reply ... diagnostic.
From 5f075332e33f7e9bf2d7979934b8dc7c3312b6e8 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer
coverity spotted the expressions that could never be true:
(a b c) 0. Here's the fix:
From 6d61d90a6df81900f4b2be752403758175000973 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 13 Jul 2010 15:15:04 -0500
Subject: [PATCH] qemuConnectMonitor: fix a bug that would
The stray 0 removed by the fix below
would have made umlMonitorCommand always fail
with its incomplete reply ... diagnostic.
From 5f075332e33f7e9bf2d7979934b8dc7c3312b6e8 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 13 Jul 2010 15:28:35 -0500
Subject: [PATCH
Justin Clift wrote:
On 06/19/2010 09:33 AM, Eric Blake wrote:
snip
+if (!(profile = phypGetLparProfile(conn, domain-id))) {
+VIR_ERROR(%s, Unable to get VIOS profile name.);
+goto err;
+}
Another case of a missing string translation. How come 'make
syntax-check'
Daniel P. Berrange wrote:
Disks with a trailing digit in their path (eg /dev/loop0 or
/dev/dm0) have an extra 'p' appended before the partition
number (eg, to form /dev/loop0p1 not /dev/loop01). Fix the
partition lookup to append this extra 'p' when required
* src/storage/parthelper.c: Add a
gnulib
library, for when c_isdigit is not a macro.
* src/storage/parthelper.c (main): Avoid out-of-bounds
dereference, noticed by Jim Meyering.
---
change in v3: earlier code already guarantees that path is non-null
if we got this far, but not whether it is non-empty
src/Makefile.am
it by pushing this change:
From ef77388ba4ba0bf37d426a7c2f7a983571acc3ea Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Sun, 6 Jun 2010 10:27:28 +0200
Subject: [PATCH] avoid syntax-check failure
* .mailmap: Map a stray commit-author email address to the canonical one.
Reported
it in time).
Patch that includes Jim's suggestions ...
...
Subject: [PATCH] Fixes for commit 211dd1e9
Fixes for issues in commit 211dd1e9 noted by by Jim Meyering.
1. Allocate content buffer of size content_length + 1 to ensure
NUL-termination.
2. Limit content buffer size to 64k
3. Fix
Jim Fehlig wrote:
...
Subject: [PATCH] Fixes for commit 211dd1e9
Fixes for issues in commit 211dd1e9 noted by by Jim Meyering.
1. Allocate content buffer of size content_length + 1 to ensure
NUL-termination.
2. Limit content buffer size to 64k
3. Fix whitespace issue
V2:
- Add
Jim Fehlig wrote:
...
Subject: [PATCH] Allocate buffer to hold xend response
There are cases when a response from xend can exceed 4096 bytes, in
which case anything beyond 4096 is ignored. This patch changes the
current fixed-size, stack-allocated buffer to a dynamically allocated
buffer
has only
been tested with a (dummy) server that 'behaves' similarly to how we
expect lldpad to 'behave'.
V13:
- Merging Scott's v13-pre1 patch
- Fixing endptr related bug while using virStrToLong_ui() pointed out
by Jim Meyering
...
+static uint32_t
+getLldpadPid(void) {
+int fd
FYI, I've pushed this:
From f9a4df5a5bc4ab9a645928430db84ec3807a996e Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Sat, 29 May 2010 09:45:21 +0200
Subject: [PATCH] build: make cpp indentation conform
* src/storage/storage_backend.h (VIR_STORAGE_VOL_OPEN_DEFAULT):
Adjust s
Stefan Berger wrote:
On Fri, 2010-05-28 at 23:17 +0200, Jim Meyering wrote:
Stefan Berger wrote:
This is now hopefully the final version of this patch that adds support
for configuring 802.1Qbg and 802.1Qbh switches. The 802.1Qbh part has
been successfully tested with real hardware
Stefan Berger wrote:
...
V12:
- Addressing Jim Meyering's comments to v11
- requiring mac address to the vpDisassociateProfileId() function to
pass it further to the 802.1Qbg disassociate part (802.1Qbh untouched)
Thanks for enduring so many iterations.
...
+static uint32_t
, .mailmap will not be obfuscated in the repository. ]
From e19a035f7c1a4ca5fcdcc58033b8a1c42ef19fa9 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Fri, 28 May 2010 11:27:12 +0200
Subject: [PATCH] maint: new syntax-check rule to ensure that AUTHORS stays in
sync
* cfg.mk
Eric Blake wrote:
On 05/28/2010 03:33 AM, Jim Meyering wrote:
Eric Blake wrote:
Eduardo Otubo contacted me off-list, noticing that his name was not yet
in AUTHORS even though he has had commits in the past. I've rectified
this situation with an obvious commit; not worth posting the diff
Stefan Berger wrote:
This is now hopefully the final version of this patch that adds support
for configuring 802.1Qbg and 802.1Qbh switches. The 802.1Qbh part has
been successfully tested with real hardware. The 802.1Qbg part has only
been tested with a (dummy) server that 'behaves' similarly
Cole Robinson wrote:
Fedora bug https://bugzilla.redhat.com/show_bug.cgi?id=235961
If using the default virtual network, an easy way to lose guest network
connectivity is to install libvirt inside the VM. The autostarted
default network inside the guest collides with host virtual network
Cole Robinson wrote:
Wireless NICs were being ignored because we weren't correctly handling
device type. Fix this, as well as wireless NIC net subtype.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/node_device/node_device_udev.c | 12 +++-
1 files changed, 11
Cole Robinson wrote:
'listen' isn't a valid qemu-dm option, as reported a long time ago here:
https://bugzilla.redhat.com/show_bug.cgi?id=492958
Matches the near identical logic in qemu_conf.c
...
diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c
index a99cc7b..e12bac7 100644
Dave Allan wrote:
On Wed, May 26, 2010 at 03:55:44PM -0400, Cole Robinson wrote:
Wireless NICs were being ignored because we weren't correctly handling
device type. Fix this, as well as wireless NIC net subtype.
Thanks for finding and fixing this. I made a v2 patch with the change
that
Eric Blake wrote:
On 05/12/2010 07:23 PM, Eric Blake wrote:
[trying to clear out some old mail]
From bc3404d9f12c42cf883a43395fee6fc14c952b2c Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 11 May 2010 15:43:32 +0200
Subject: [PATCH] lxcSetSchedulerParameters
Scott Feldman wrote:
From: Scott Feldman scofe...@cisco.com
...
diff --git a/configure.ac b/configure.ac
...
-if test $with_macvtap = yes; then
+if test $with_macvtap = yes || $with_virtualport = yes; then
Hi Scott,
The above introduces a syntax error.
Fix it by inserting a test after the
Chris Lalancette wrote:
Basic live migration was broken by the commit that added
non-shared block support in two ways:
1) It added a virCheckFlags() to doNativeMigrate(). Besides
...
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 77e71cc..941b482 100644
---
Scott Feldman wrote:
On 5/25/10 10:24 AM, Stefan Berger stef...@linux.vnet.ibm.com wrote:
Reposting due to malformatted patch.
Thanks for fixing the malformed issue.
My testing is done with this version v7 plus the other patches list below.
No issues.
ACK.
[PATCH v10] vepa:
Daniel P. Berrange wrote:
---
docs/Makefile.am | 12 ++--
docs/internals.html.in |9 +
docs/sitemap.html.in |4
3 files changed, 23 insertions(+), 2 deletions(-)
diff --git a/docs/Makefile.am b/docs/Makefile.am
...
+ liGuide to adding a
contains
an invalid line; before the addition of host_uuid, each
commented-out sample line was valid.
Here are the fixes.
From 11228f4b2dba1b43a9de97a575d1121eba2e8cf4 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 25 May 2010 20:56:18 +0200
Subject: [PATCH 1/2
Stefan Berger wrote:
This patch builds on the work recently posted by Stefan Berger. It builds
on top of Stefan's three posted patches:
Not a show-stopper, but your patch is corrupted due to split lines.
If you tell your mail client not to do that, it'll be easier
on folks who end up applying
Most of the following changes have been induced automatically.
The few outliers done manually are marked as such.
[PATCH 01/10] maint: use VIR_ERROR0 rather than VIR_ERROR with a bare %s
[PATCH 02/10] maint: mark translatable string args of VIR_ERROR0
[PATCH 03/10] maint: mark translatable string
From: Jim Meyering meyer...@redhat.com
Change VIR_ERROR(%s, ...
to VIR_ERROR0(...
and
Change VIR_ERROR(%s, _(...)
to VIR_ERROR0(_(...)
Use this command:
git grep -E -l 'VIR_ERROR\(%s, (_\()?'|xargs perl -pi -e \
's/VIR_ERROR\(%s, (_\()?/VIR_ERROR0($1/'
---
daemon/libvirtd.c
From: Jim Meyering meyer...@redhat.com
Run this:
git grep -l 'VIR_ERROR0\s*('|xargs perl -pi -e \
's/(VIR_ERROR0)\s*\((.*?)\)/$1(_($2))/'
---
daemon/libvirtd.c |6 +++---
src/esx/esx_driver.c |4 ++--
src/node_device/node_device_hal.c
From: Jim Meyering meyer...@redhat.com
* po/POTFILES.in: Add 3 files.
---
po/POTFILES.in |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/po/POTFILES.in b/po/POTFILES.in
index e08b8c8..baaf56f 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -18,6 +18,7 @@ src
From: Jim Meyering meyer...@redhat.com
Run this:
git grep -l 'VIR_ERROR\s*('|xargs perl -pi -e \
's/(VIR_ERROR)\s*\((.*?),/$1(_($2),/'
---
daemon/libvirtd.c |2 +-
src/driver.c |6 +++---
src/libvirt.c
From: Jim Meyering meyer...@redhat.com
---
daemon/libvirtd.c |3 +--
src/phyp/phyp_driver.c | 12 +---
2 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
index 04af58f..afa10fb 100644
--- a/daemon/libvirtd.c
+++ b/daemon
From: Jim Meyering meyer...@redhat.com
These changes avoid false-positive syntax-check failure,
and also make the resulting diagnostics more comprehensible.
---
src/qemu/qemu_driver.c |8
src/secret/secret_driver.c |4 ++--
src/uml/uml_driver.c |2 +-
3 files
From: Jim Meyering meyer...@redhat.com
Handle concatenated strings manually.
---
src/esx/esx_vi.c | 10 +-
src/node_device/node_device_udev.c | 20 ++--
2 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/src/esx/esx_vi.c b/src/esx
From: Jim Meyering meyer...@redhat.com
* cfg.mk (sc_prohibit_gettext_markup): Just like VIR_WARN*.
---
cfg.mk |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/cfg.mk b/cfg.mk
index a26285f..2909e3e 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -425,7 +425,7 @@ sc_copyright_format
From: Jim Meyering meyer...@redhat.com
Run this command:
git grep -l VIR_DEBUG|xargs perl -pi -e \
's/(VIR_DEBUG0?)\s*\(_\((.*?)\)/$1($2/'
---
...-Step-7-of-8-Implement-the-driver-methods.patch |4 +-
src/node_device/node_device_driver.c |2 +-
src/node_device
From: Jim Meyering meyer...@redhat.com
* cfg.mk (msg_gen_function): Add VIR_ERROR and VIR_ERROR0,
so that sc_libvirt_unmarked_diagnostics will check them, too.
---
cfg.mk |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/cfg.mk b/cfg.mk
index 04719d4..a26285f 100644
Saw these while fixing the previous bug:
From ab3d0ba4f5c004a45da5b5a240a0b5caef21df99 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 20 May 2010 10:01:32 +0200
Subject: [PATCH] libvirtd: mark strings for translation, including --help output
* daemon/libvirtd.c
I almost missed this; it was so similar to what I though
was the sole ignore-virInitialize-failure bug (in python set-up)
that I thought I'd already fixed it.
From f48e364b6f2182f7fa88862b2e1a789e2d83a027 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 20 May 2010 09:52
of the message is more than 2 lines after the function name).
Currently there are no false positives.
From 122b1e31fb33c092a53802b56a0f2f5586c95bd5 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 20 May 2010 11:12:17 +0200
Subject: [PATCH 1/2] maint: remove unwanted
.
Now, my only question is about which errno values to ignore.
Obviously, EMFILE, EFAULT, etc. must not be ignored.
I doubt EINTR and EBADF should be ignored, but haven't
tried to prove the case.
From 6dcd15b0aa594f3d89e810e0a92aa75dab22903e Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer
Chris Wright wrote:
* Eric Blake (ebl...@redhat.com) wrote:
On 05/19/2010 04:37 PM, Chris Wright wrote:
Looks like some cut'n paste error to me.
While we're at it, there have been some complaints, at least on IRC,
that some recent qemu builds changed -help output to start with QEMU
Jim Meyering wrote:
Initially I proposed a similar patch here:
http://thread.gmane.org/gmane.comp.emulators.libvirt/20607
That thread languished, and Eric proposed a nearly identical patch:
http://thread.gmane.org/gmane.comp.emulators.libvirt/21630
Here's a patch that should
Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 20 May 2010 11:13:41 +0200
Subject: [PATCH 2/2] maint: prohibit newline at end of diagnostic
* cfg.mk (sc_prohibit_newline_at_end_of_diagnostic): New rule.
Idea proposed by Jiri Denemark.
ACK to both patches.
While
Chris Lalancette wrote:
Subject: [PATCH] libvirtd: don't ignore virInitialize failure
* daemon/libvirtd.c (main): Diagnose virInitialize failure
and exit nonzero.
---
daemon/libvirtd.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/daemon/libvirtd.c
might even provide this in a
reliably parsable format like JSON...
FYI, here's the complete patch I'll push in an hour or so.
Note that I reordered, so that we check the new string before
the old one.
From 3b7179866bd9e495332335df74b327cc156a298c Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer
Chris Lalancette wrote:
...
- _(Failed to create inactive domain %s\n), def-name);
+ _(Failed to create inactive domain %s), def-name);
goto error;
}
ACK to this part, certainly.
I'm not sure a new syntax-check rule (which may have
Eric Blake wrote:
On 05/20/2010 01:11 AM, Jim Meyering wrote:
Most of the following changes have been induced automatically.
The few outliers done manually are marked as such.
[PATCH 01/10] maint: use VIR_ERROR0 rather than VIR_ERROR with a bare %s
[PATCH 02/10] maint: mark translatable
Eric Blake wrote:
On 05/20/2010 02:02 AM, Jim Meyering wrote:
+++ b/daemon/libvirtd.c
@@ -484,8 +484,8 @@ static int daemonForkIntoBackground(void) {
if (ret == 1 status != 0) {
fprintf(stderr,
-error: %s. Check /var/log/messages
Eric Blake wrote:
On 05/20/2010 01:42 PM, Jim Meyering wrote:
Should we also do a followup that passes argv[0] to this method, so that
the error message can start with the program name?
Might as well.
patch below.
Didn't see any signature change to daemonForkIntoBackground...
Missed
Chris Lalancette wrote:
On 05/18/2010 01:15 PM, Jim Meyering wrote:
Daniel P. Berrange wrote:
On Tue, May 18, 2010 at 06:30:34PM +0200, Jim Meyering wrote:
I noticed a typo in a public interface.
IMHO it's well worth fixing, so propose this:
(imagine someone searching for all occurrences
that this solves the problem
when using your older pdwtags program?
From a8d8ff6ba4791972483093215291eef5fa87cf5d Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Wed, 19 May 2010 15:36:27 +0200
Subject: [PATCH] tests: the remote_protocol check also accommodates older
pdwtags
Jiri Denemark wrote:
Nonetheless, many of my manual changes highlighted
existing (bogus) attempts to translate VIR_WARN0? diagnostics.
Those should be addressed regardless.
Considering the large number of existing VIR_WARN uses with strings
marked for translation, do you want to
From: Jim Meyering meyer...@redhat.com
Run this command:
git grep -l 'VIR_WARN(%s, '|xargs perl -pi -e \
's/VIR_WARN\(%s, /VIR_WARN0(/'
* src/phyp/phyp_driver.c (phypDomainGetInfo): Perform the above.
(phypDomainCreateAndStart, phypUUIDTable_ReadFile): Likewise.
---
src/phyp/phyp_driver.c
From: Jim Meyering meyer...@redhat.com
Approximately 60 messages were marked. Since these diagnostics are
intended solely for developers and maintainers, encouraging translation
is deemed to be counterproductive:
http://thread.gmane.org/gmane.comp.emulators.libvirt/25050/focus=25052
Run
From: Jim Meyering meyer...@redhat.com
* po/POTFILES.in: Remove src/util/logging.c and src/util/uuid.c.
* src/phyp/phyp_driver.c (phypUUIDTable_ReadFile): Correct more
VIR_WARN uses, now manually.
(phypUUIDTable_Init, phypUUIDTable_Pull): Likewise.
---
po/POTFILES.in |2 --
src/phyp
From: Jim Meyering meyer...@redhat.com
* cfg.mk (sc_prohibit_gettext_markup): New rule, to enforce
this policy. Contrary to most diagnostic-emitting functions,
where we require _(...) markup, here, we require that _() *not*
be used for certain functions (or function-like macros).
---
cfg.mk
From: Jim Meyering meyer...@redhat.com
* src/util/uuid.c (virUUIDGenerate): Remove _(...) manually.
---
src/util/uuid.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/util/uuid.c b/src/util/uuid.c
index 459273a..9c626ce 100644
--- a/src/util/uuid.c
+++ b/src
Here are 5 patches, mostly mechanical,
to straighten out the VIR_WARN and VIR_WARN0 situation.
1: mechanically remove all _(...) uses in VIR_WARN*.
2: remove the few remaining _(...) uses manually
3: add syntax-check rule to enforce the policy
4 clean up bogosity I noticed along the way, first
Daniel P. Berrange wrote:
On Wed, May 19, 2010 at 04:47:16PM +0200, Jim Meyering wrote:
From: Jim Meyering meyer...@redhat.com
Approximately 60 messages were marked. Since these diagnostics are
intended solely for developers and maintainers, encouraging translation
is deemed
This is very similar to ones I fixed yesterday.
The difference is that I'm adding ATTRIBUTE_RETURN_CHECK, now.
Here, it's easy, since the function is private.
From cfce459e9aebae840356e62473f550f358834f30 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Wed, 19 May 2010 17:48
Matthias Bolte wrote:
...
Yes, this patch solves the problem.
...
+ -e ' warn WARNING: your pdwtags program is too old\n;' \
+ -e ' warn WARNING: skipping the $@ test\n;' \
+ -e ' warn WARNING: install dwarves-1.8 or newer\n;' \
Eric Blake wrote:
* src/Makefile.am (EXTRA_DIST): Add THREADS.txt.
---
I noticed this while working on back-porting a patch to RHEL-6 - the
qemu tree in my git repository had more files than were in the
unpacked 0.8.1 tarball.
src/Makefile.am |3 ++-
1 file changed, 2 insertions(+),
the code harder to abuse must be an improvement.
From 837732f1e307208b52721ffba83102e0edc361a7 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 18 May 2010 07:53:31 +0200
Subject: [PATCH] initialize meta in virStorageFileGetMetadata, not in each
caller
Do not require each
Eric Blake wrote:
On 05/17/2010 11:33 AM, Jim Meyering wrote:
Here's the fix, followed by the endjob/cleanup code:
From d696f6067d6e802714adbf3e36bf53c9fcf3ec76 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Mon, 17 May 2010 19:28:44 +0200
Subject: [PATCH
the fix:
From b7c6593b3a8b59d49b492cd45fbf5f9c706bb78f Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 18 May 2010 10:11:23 +0200
Subject: [PATCH] ebiptablesWriteToTempFile: don't close a negative file
descriptor
* src/nwfilter/nwfilter_ebiptables_driver.c
virNWFilterParseParamAttributes call.
From 8659fb1ae879befe360e1ec7b8b62434c22698cd Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 18 May 2010 10:19:30 +0200
Subject: [PATCH] virDomainNetDefParseXML: avoid leak upon multiple filterref
* src/conf/domain_conf.c
See the comment:
From 1b200ba22d742e685de0b9853c8cd276df8e129f Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 18 May 2010 11:58:32 +0200
Subject: [PATCH] linuxNodeInfoCPUPopulate: avoid used-uninitialized via a test
* tests/nodeinfotest.c (linuxTestCompareFiles
4c13990a15b33f03595d58b46b6e34e03bfffa65 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 18 May 2010 12:05:53 +0200
Subject: [PATCH] virNWFilterDefParseXML: avoid leak on error paths
* src/conf/nwfilter_conf.c (virNWFilterDefParseXML): Also free ret
via cleanup.
---
src/conf/nwfilter_conf.c
Jim Meyering wrote:
See the comment:
From 1b200ba22d742e685de0b9853c8cd276df8e129f Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 18 May 2010 11:58:32 +0200
Subject: [PATCH] linuxNodeInfoCPUPopulate: avoid used-uninitialized via a test
* tests/nodeinfotest.c
Fix a minor leak:
From 0fc88bfcae06346e871d2a4a89febb160bc0857e Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 18 May 2010 12:17:23 +0200
Subject: [PATCH] qemuMonitorTextMigrate: avoid leak on OOM-error path
* src/qemu/qemu_monitor_text.c (qemuMonitorTextMigrate
Simple...
From f5ee09ed08473478b3ea3135d51125fbf687e402 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 18 May 2010 12:32:39 +0200
Subject: [PATCH] tests: do not ignore virInitialize failure
* tests/nodeinfotest.c (mymain): Do not ignore virInitialize failure.
Most
I've just fixed code in a test that ignored virInitialize failure.
Looking at all uses, I saw one other: in python/libvirt-override.c,
where the initialization function ignores virInitialize failure:
void
#ifndef __CYGWIN__
initlibvirtmod
#else
initcygvirtmod
#endif
(void)
{
1 - 100 of 1568 matches
Mail list logo
