[libvirt] [PATCH] virsh: A bit smarter attach-disk

2012-03-15 Thread Osier Yang
Detects the file type of source path if no --sourcetype and driver is specified, instead of always set the disk type as block. And previous virCommandOptString ensures source is not NULL, remove the conditional checking. --- tools/virsh.c | 14 +- 1 files changed, 9 insertions(+),

Re: [libvirt] [PATCH] virsh: A bit smarter attach-disk

2012-03-15 Thread Osier Yang
On 03/15/2012 05:12 PM, Michal Privoznik wrote: On 15.03.2012 10:13, Osier Yang wrote: Detects the file type of source path if no --sourcetype and driver is specified, instead of always set the disk type as block. And previous virCommandOptString ensures source is not NULL, remove the

Re: [libvirt] [PATCH] virsh: A bit smarter attach-disk

2012-03-15 Thread Michal Privoznik
On 15.03.2012 10:13, Osier Yang wrote: Detects the file type of source path if no --sourcetype and driver is specified, instead of always set the disk type as block. And previous virCommandOptString ensures source is not NULL, remove the conditional checking. --- tools/virsh.c | 14