Re: [libvirt] [PATCH 6/7] Break out FS volume build routines to their own functions.

2009-05-12 Thread Cole Robinson
On 05/11/2009 08:58 AM, Daniel P. Berrange wrote: On Mon, May 04, 2009 at 01:43:01PM -0400, Cole Robinson wrote: Improves readability, particularly wrt the pending CreateFromXML changes. This will also help implementing File-Block volume creation in the future, since some of this code will

Re: [libvirt] [PATCH 6/7] Break out FS volume build routines to their own functions.

2009-05-11 Thread Daniel P. Berrange
On Mon, May 04, 2009 at 01:43:01PM -0400, Cole Robinson wrote: Improves readability, particularly wrt the pending CreateFromXML changes. This will also help implementing File-Block volume creation in the future, since some of this code will need to be moved to a backend agnostic file. This is

[libvirt] [PATCH 6/7] Break out FS volume build routines to their own functions.

2009-05-04 Thread Cole Robinson
Improves readability, particularly wrt the pending CreateFromXML changes. This will also help implementing File-Block volume creation in the future, since some of this code will need to be moved to a backend agnostic file. Signed-off-by: Cole Robinson crobi...@redhat.com ---