Re: [libvirt] [PATCHv3 2/4] net-dhcp-leases: Implement the remote protocol

2013-09-16 Thread Nehal J Wani
+static int +remoteSerializeNetworkDHCPLeases(virNetworkDHCPLeasesPtr *leases, + int nleases, + remote_network_get_dhcp_leases_ret *ret) +{ +size_t i; + +if (nleases REMOTE_NETWORK_DHCP_LEASES_MAX) { +

Re: [libvirt] [PATCHv3 2/4] net-dhcp-leases: Implement the remote protocol

2013-09-16 Thread Daniel P. Berrange
On Mon, Sep 16, 2013 at 11:31:27PM +0530, Nehal J Wani wrote: +static int +remoteSerializeNetworkDHCPLeases(virNetworkDHCPLeasesPtr *leases, + int nleases, + remote_network_get_dhcp_leases_ret *ret) +{ +size_t i; +

Re: [libvirt] [PATCHv3 2/4] net-dhcp-leases: Implement the remote protocol

2013-09-16 Thread Eric Blake
On 09/16/2013 12:01 PM, Nehal J Wani wrote: + +for (i = 0; i nleases; i++) { +virNetworkDHCPLeasesPtr lease = leases[i]; +remote_network_dhcp_lease *lease_ret = (ret-leases.leases_val[i]); +error: +for (i = 0; i nleases; i++) { +remote_network_dhcp_lease

Re: [libvirt] [PATCHv3 2/4] net-dhcp-leases: Implement the remote protocol

2013-09-16 Thread Eric Blake
On 09/15/2013 11:49 PM, Nehal J Wani wrote: Implement RPC calls for virNetworkGetDHCPLeases, virNetworkGetDHCPLeasesForMAC A lot of my comments below are similar to what I did on Guiseppe's patch; you may want to closely study:

[libvirt] [PATCHv3 2/4] net-dhcp-leases: Implement the remote protocol

2013-09-15 Thread Nehal J Wani
Implement RPC calls for virNetworkGetDHCPLeases, virNetworkGetDHCPLeasesForMAC daemon/remote.c * Define remoteSerializeNetworkDHCPLeases, remoteDispatchNetworkGetDHCPLeases * Define remoteDispatchNetworkGetDHCPLeasesForMAC src/remote/remote_driver.c * Define