Re: [libvirt] PATCH: Don't blindly reorder disk drives

2009-09-02 Thread Daniel Veillard
On Mon, Aug 17, 2009 at 03:34:38PM +0100, Daniel P. Berrange wrote: Calling qsort() on the disks array causes disk to be unneccessarily re-ordered, potentially breaking the ability to boot if the boot disk gets moved later in the list. The new algorithm will insert a new disk as far to the

[libvirt] PATCH: Don't blindly reorder disk drives

2009-08-17 Thread Daniel P. Berrange
Calling qsort() on the disks array causes disk to be unneccessarily re-ordered, potentially breaking the ability to boot if the boot disk gets moved later in the list. The new algorithm will insert a new disk as far to the end of the list as possible, while being ordered correctly wrt other disks