Re: [libvirt] [PATCH] init cont-idx correctly

2011-01-31 Thread Daniel Veillard
On Mon, Jan 31, 2011 at 02:15:41PM +0800, Wen Congyang wrote: Steps to reproduce this bug: 1. # virsh attach-disk --target sdb ... 2. # virsh attach-disk --target sdh ... error: Failed to attach disk error: operation failed: target scsi:0 already exists sdh uses scsi:1, rather than

Re: [libvirt] [PATCH] qemu: More clear error parsing domain def failure of tunneled migration

2011-01-31 Thread Osier Yang
于 2011年01月31日 15:39, Daniel Veillard 写道: On Mon, Jan 31, 2011 at 12:52:55PM +0800, Osier Yang wrote: * src/qemu/qemu_driver.c --- src/qemu/qemu_driver.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

[libvirt] [PATCH] storage: Allow to delete device mapper disk partition

2011-01-31 Thread Osier Yang
From: root r...@amd-1352-8-2.englab.nay.redhat.com The name convention of device mapper disk is different, and 'parted' can't be used to delete a device mapper disk partition. e.g. [root@amd-1352-8-2 ~]# virsh vol-list --pool osier Name Path

Re: [libvirt] [PATCH] qemu: More clear error parsing domain def failure of tunneled migration

2011-01-31 Thread Daniel P. Berrange
On Sun, Jan 30, 2011 at 04:46:39PM +0800, Osier Yang wrote: * src/qemu/qemu_driver.c --- src/qemu/qemu_driver.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 84d339b..929dc94 100644 ---

Re: [libvirt] [PATCH] Split all QEMU process mangement code into separate file

2011-01-31 Thread Daniel P. Berrange
On Sat, Jan 29, 2011 at 11:41:33AM -0700, Eric Blake wrote: On 01/28/2011 06:21 AM, Daniel P. Berrange wrote: -static int qemudStartVMDaemon(virConnectPtr conn, - struct qemud_driver *driver, ... -if (!(cmd = qemuBuildCommandLine(conn, driver, vm-def,

Re: [libvirt] [PATCH] Move all the QEMU migration code to a new file

2011-01-31 Thread Daniel P. Berrange
On Sat, Jan 29, 2011 at 11:44:39AM -0700, Eric Blake wrote: On 01/28/2011 06:22 AM, Daniel P. Berrange wrote: The introduction of the v3 migration protocol, along with support for migration cookies, will significantly expand the size of the migration code. Move it all to a separate file

[libvirt] callback question

2011-01-31 Thread arnaud.champion
?Hi, Something I need to understant about callbacks: if I install 2 callback via DomainEventRegisterAny (lifecycle for the first and graphics for the second for example), am I right if I said that the AddHandleFunc should be called 2 times ? Regards, Arnaud-- libvir-list mailing list

Re: [libvirt] Google Summer of Code 2011

2011-01-31 Thread Luiz Capitulino
On Sun, 30 Jan 2011 16:06:20 +0100 Alexander Graf ag...@suse.de wrote: On 28.01.2011, at 21:10, Luiz Capitulino wrote: Hi there, GSoC 2011 has been announced[1]. As we were pretty successful last year, I think we should participate again. I've already created a wiki page:

Re: [libvirt] callback question

2011-01-31 Thread Daniel P. Berrange
On Mon, Jan 31, 2011 at 12:16:24PM +0100, arnaud.champ...@devatom.fr wrote: ?Hi, Something I need to understant about callbacks: if I install 2 callback via DomainEventRegisterAny (lifecycle for the first and graphics for the second for example), am I right if I said that the

Re: [libvirt] callback question

2011-01-31 Thread arnaud.champion
Okay, I understand. When the AddHandle function, I receive a fd (FileDescription), its value is 3... always... Is that normal ? Is that file descriptor on a socket or on a file ? (In windows, when can use the WSAPoll function but it works on ly on sockets) Regards, Arnaud

Re: [libvirt] fork of php-libvirt

2011-01-31 Thread Michal Novotny
Guys, in fact I did a fork of PHP libvirt and I informed Radek as well, my fork can be found on github at my profile page: https://github.com/MigNov/php-libvirt Also, sorry for having the root in some commits but I used wrong user-name with git unset to merge it. I've been testing it in my

Re: [libvirt] [PATCH] qemu: More clear error parsing domain def failure of tunneled migration

2011-01-31 Thread Osier Yang
于 2011年01月31日 18:50, Daniel P. Berrange 写道: On Sun, Jan 30, 2011 at 04:46:39PM +0800, Osier Yang wrote: * src/qemu/qemu_driver.c --- src/qemu/qemu_driver.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

[libvirt] interface description

2011-01-31 Thread arnaud.champion
?Hi, I have an interface xml description the model is missing, is that normal ? if it is normal, what is the exposed model ? interface type=network mac address=52:54:00:50:3a:98 / source network=default / target dev=vnet0 / alias name=net0 / address type=pci

Re: [libvirt] [PATCH] docs: update docs for cpu_shares setting

2011-01-31 Thread Eric Blake
On 01/29/2011 10:43 PM, Osier Yang wrote: * tools/virsh.pod --- tools/virsh.pod |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 441ca8a..d3262b6 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -566,7 +566,11 @@

Re: [libvirt] Raising events for testing

2011-01-31 Thread Eric Blake
On 01/30/2011 05:21 AM, arnaud.champ...@devatom.fr wrote: Hi, One thing I need to understand, in the callback python or c samples, the fileDescriptor is on a socket or on a pipe ? Libvirt uses gnulib to guarantee that poll() works on file descriptors; all socket operations are magically

Re: [libvirt] Raising events for testing

2011-01-31 Thread Daniel P. Berrange
On Sun, Jan 30, 2011 at 01:21:37PM +0100, arnaud.champ...@devatom.fr wrote: Hi, One thing I need to understand, in the callback python or c samples, the fileDescriptor is on a socket or on a pipe ? Internally libvirt may have a opened pipe, file, socket, or something else. In all cases, the

Re: [libvirt] [PATCH] tests: handle backspace-newline pairs in test input files

2011-01-31 Thread Eric Blake
On 01/31/2011 05:24 AM, Haefliger, Juerg wrote: From 04856f4c830a5f40d44bb67e908a1cbf88c18ce5 Mon Sep 17 00:00:00 2001 From: Juerg Haefliger juerg.haefli...@hp.com Date: Mon, 31 Jan 2011 06:42:57 -0500 Subject: [PATCH] tests: handle backspace-newline pairs in test input files This patch

Re: [libvirt] interface description

2011-01-31 Thread Laine Stump
On 01/31/2011 12:10 PM, arnaud.champ...@devatom.fr wrote: Hi, I have an interface xml description the model is missing, is that normal ? if it is normal, what is the exposed model ? It's not required to specify model type=.../ in the XML. If you don't give a model, it looks like it defaults

Re: [libvirt] Raising events for testing

2011-01-31 Thread arnaud.champ...@devatom.fr
There is - it involves using gnulib. But that is only for C and C++ - I have no idea how this translates over to C# So if I understand well, are you saying that if I use gnulib windows version via C# (pinvoke, this kind of magic) I will have access to poll function ? Intersting, I'll take a look.

Re: [libvirt] [PATCH] Split all QEMU process mangement code into separate file

2011-01-31 Thread Eric Blake
On 01/31/2011 04:05 AM, Daniel P. Berrange wrote: - -if (qemuDomainSnapshotSetCurrentInactive(vm, driver-snapshotDir) 0) -goto cleanup; Why was the SetCurrentInactive line commented out in the move? It is already invoked in the caller, so it should be redundant here, and it

Re: [libvirt] Raising events for testing

2011-01-31 Thread Eric Blake
On 01/31/2011 11:52 AM, arnaud.champ...@devatom.fr wrote: There is - it involves using gnulib. But that is only for C and C++ - I have no idea how this translates over to C# So if I understand well, are you saying that if I use gnulib windows version via C# (pinvoke, this kind of magic) I

Re: [libvirt] Raising events for testing

2011-01-31 Thread arnaud.champ...@devatom.fr
Yep that's what I've just seen. I've decided to try via mingwin which seems to implement a poll function...Callbacks implementation are really hard for a noob :) Regards, Arnaud De: Eric Blake ebl...@redhat.com Envoyé: lundi 31 janvier 2011 20:12 A:

[libvirt] [PATCHv4] bridge_driver: handle DNS over IPv6

2011-01-31 Thread Paweł Krześniak
* dnsmasq listens on all defined IPv[46] addresses for network * Add ip6tables rules to allow DNS traffic to host --- src/network/bridge_driver.c | 51 ++ 1 files changed, 41 insertions(+), 10 deletions(-) diff --git a/src/network/bridge_driver.c

Re: [libvirt] [PATCH] Move all the QEMU migration code to a new file

2011-01-31 Thread Eric Blake
On 01/31/2011 04:06 AM, Daniel P. Berrange wrote: The functions are not moved 100%. The API entry points remain in the main QEMU driver, but once the public virDomainPtr is resolved to the internal virDomainObjPtr, all following code is moved. This will allow the new v3 API entry points to

Re: [libvirt] [PATCH] qemu: Build command line for incoming tunneled migration

2011-01-31 Thread Eric Blake
On 01/30/2011 01:10 AM, Osier Yang wrote: This patch is race with: http://www.redhat.com/archives/libvir-list/2011-January/msg00681.html , if patch above works, but it was not pushed yet, will it be pushed? I've been kind of sitting on that patch - it's an optimization rather than a

Re: [libvirt] [PATCH] qemu: Build command line for incoming tunneled migration

2011-01-31 Thread Eric Blake
On 01/30/2011 12:58 AM, Osier Yang wrote: Command line building for imcoming tunneled migration is missed, s/imcoming/incoming/ as a result, all the tunneled migration will fail with unknown migration protocol. * src/qemu/qemu_command.c --- src/qemu/qemu_command.c |8 1

Re: [libvirt] [PATCH] storage: Allow to delete device mapper disk partition

2011-01-31 Thread Eric Blake
On 01/31/2011 03:16 AM, Osier Yang wrote: From: root Fix your ~/.gitconfig, then 'git commit --amend --author=Osier' to reclaim authorship of this file; this patch is showing up with the wrong author information, and even though we could .mailmap around a bad commit, I'd rather not have bogus

[libvirt] [PATCH] build: fix parted detection at configure time

2011-01-31 Thread Eric Blake
* configure.ac (PARTED_FOUND): Issue configure error if --with-storage-disk=yes but no parted is found. --- As pointed out while reviewing Osier's patch, we were unconditionally nuking with_storage_disk=no if parted was not found, then trying to issue AC_MSG_ERROR if the user had passed in yes.

Re: [libvirt] [PATCH 1/2] Get cpuMhz of virNodeGetInfo() from cpufreq/cpuinfo_max_freq, if exist

2011-01-31 Thread Eric Blake
On 01/27/2011 02:51 AM, Minoru Usui wrote: virNodeGetInfo() gets from /sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_max_freq, first. Signed-off-by: Minoru Usui u...@mxm.nes.nec.co.jp I haven't looked closely at this series yet... +/* + * nodeinfo-mhz should return maximum

Re: [libvirt] [PATCHv3 1/5] smartcard: add XML support for smartcard device

2011-01-31 Thread Eric Blake
On 01/26/2011 11:29 AM, Alon Levy wrote: yes, the db is a directory name, treated as normal (can be absolute or relative to cwd, I don't check, just feed it to NSS). From qemu's point of view, it can be relative; but how does a libvirt user know what directory libvirt will be running in?

Re: [libvirt] [PATCHv3 1/5] smartcard: add XML support for smartcard device

2011-01-31 Thread Eric Blake
On 01/26/2011 11:29 AM, Alon Levy wrote: yes, the db is a directory name, treated as normal (can be absolute or relative to cwd, I don't check, just feed it to NSS). It defaults to /etc/pki/nssdb: Hmm; given Osier's recent commit cc4447b to allow $HOME/.pki/libvirt to be tried first for

[libvirt] libvirt 0.8.7 LOCALSTATEDIR ubuntu patch

2011-01-31 Thread Philipp Schmid
Hi, I'm using ubuntu for our libvirt/kvm host server and needed IPv6 connectivity, so I started to update the latest ubuntu libvirt package (0.8.5) to 0.8.7. I got all but one ubuntu specific patch to apply. The patch moves the ebiptables script from /tmp to LOCALSTATEDIR /lib/libvirt. I

Re: [libvirt] libvirt 0.8.7 LOCALSTATEDIR ubuntu patch

2011-01-31 Thread Eric Blake
On 01/31/2011 04:57 PM, Philipp Schmid wrote: -Wall -Wformat -Wformat-security -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wextra -Wshadow -Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes -Winline -Wredundant-decls -Wno-sign-compare -Wlogical-op

Re: [libvirt] [PATCH 1/2] Get cpuMhz of virNodeGetInfo() from cpufreq/cpuinfo_max_freq, if exist

2011-01-31 Thread Minoru Usui
Hi, Eric On Mon, 31 Jan 2011 15:46:39 -0700 Eric Blake ebl...@redhat.com wrote: On 01/27/2011 02:51 AM, Minoru Usui wrote: virNodeGetInfo() gets from /sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_max_freq, first. Signed-off-by: Minoru Usui u...@mxm.nes.nec.co.jp I haven't looked

Re: [libvirt] [PATCHv4] bridge_driver: handle DNS over IPv6

2011-01-31 Thread Laine Stump
On 01/31/2011 03:31 PM, Paweł Krześniak wrote: * dnsmasq listens on all defined IPv[46] addresses for network * Add ip6tables rules to allow DNS traffic to host --- src/network/bridge_driver.c | 51 ++ 1 files changed, 41 insertions(+), 10

Re: [libvirt] [PATCH 2/4 v2] cgroup: Implement blkio.weight tuning API.

2011-01-31 Thread Nikunj A. Dadhania
On Thu, 27 Jan 2011 13:18:44 +0800, Gui Jianfeng guijianf...@cn.fujitsu.com wrote: Implement blkio.weight tuning API. Signed-off-by: Gui Jianfeng guijianf...@cn.fujitsu.com --- src/libvirt_private.syms |2 ++ src/util/cgroup.c| 39 +++

Re: [libvirt] [PATCHv3 1/5] smartcard: add XML support for smartcard device

2011-01-31 Thread Alon Levy
On Mon, Jan 31, 2011 at 04:33:46PM -0700, Eric Blake wrote: On 01/26/2011 11:29 AM, Alon Levy wrote: yes, the db is a directory name, treated as normal (can be absolute or relative to cwd, I don't check, just feed it to NSS). From qemu's point of view, it can be relative; but how does a

Re: [libvirt] [PATCHv3 1/5] smartcard: add XML support for smartcard device

2011-01-31 Thread Alon Levy
On Mon, Jan 31, 2011 at 04:40:06PM -0700, Eric Blake wrote: On 01/26/2011 11:29 AM, Alon Levy wrote: yes, the db is a directory name, treated as normal (can be absolute or relative to cwd, I don't check, just feed it to NSS). It defaults to /etc/pki/nssdb: Hmm; given Osier's recent

Re: [libvirt] [PATCH] build: fix parted detection at configure time

2011-01-31 Thread Laine Stump
On 01/31/2011 05:10 PM, Eric Blake wrote: * configure.ac (PARTED_FOUND): Issue configure error if --with-storage-disk=yes but no parted is found. --- As pointed out while reviewing Osier's patch, we were unconditionally nuking with_storage_disk=no if parted was not found, then trying to issue