Re: [libvirt] [PATCH 1/4] vcpupin: inroduce a new libvir API (virDomainPinVcpuFlags)

2011-04-11 Thread Taku Izumi
Wen-san, Hu-san, Osier-san, Thank you for reviewing. I'll update this. to Wen-san, + +if (flags ~(VIR_DOMAIN_VCPU_LIVE | VIR_DOMAIN_VCPU_CONFIG)) { +virLibDomainError(VIR_ERR_INVALID_ARG, __FUNCTION__); +virDispatchError(NULL); +return -1; +} Why we

Re: [libvirt] [PATCH 1/4] vcpupin: inroduce a new libvir API (virDomainPinVcpuFlags)

2011-04-11 Thread Wen Congyang
At 04/11/2011 01:56 PM, Taku Izumi Write: Wen-san, Hu-san, Osier-san, Thank you for reviewing. I'll update this. to Wen-san, + +if (flags ~(VIR_DOMAIN_VCPU_LIVE | VIR_DOMAIN_VCPU_CONFIG)) { +virLibDomainError(VIR_ERR_INVALID_ARG, __FUNCTION__); +

Re: [libvirt] [PATCH v2 0/4] RFC: vcpupin: configure inactive domains' CPU affinity setting

2011-04-11 Thread Taku Izumi
Two suggestions: - when vcpupin an inactive domain, it gives an error message like this: error: Requested operation is not valid: cannot pin vcpus on an inactive domain After applying this series, this is not true anymore. I think a message like this is more helpful:

Re: [libvirt] Paused networking on VM up/down with NAT fwd

2011-04-11 Thread Laine Stump
On 04/10/2011 06:32 PM, Serge Hallyn wrote: Hi all, some time ago bug https://bugs.launchpad.net/ubuntu/maverick/+source/qemu-kvm/+bug/584048 was fixed in libvirt. It's the one where when a VM is started or stopped which has a lower macaddr than what the bridge currently has, the bridge

Re: [libvirt] [PATCH 1/4] vcpupin: inroduce a new libvir API (virDomainPinVcpuFlags)

2011-04-11 Thread Taku Izumi
This patch introduces a new libvirt API (virDomainPinVcpuFlags) Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com --- include/libvirt/libvirt.h.in |6 +++ src/driver.h |7 +++ src/esx/esx_driver.c |1 src/libvirt.c| 83

Re: [libvirt] [PATCH 2/4] vcpupin: implement the code to address the new API in the qemu driver

2011-04-11 Thread Taku Izumi
This patch implements the code to address the new API (virDomainPinVcpuFlags) in the qemu driver. Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com --- src/qemu/qemu_driver.c | 100 + 1 file changed, 76 insertions(+), 24 deletions(-) Index:

Re: [libvirt] [PATCH] migrate VMs between different-endian hosts

2011-04-11 Thread Daniel Veillard
On Mon, Apr 11, 2011 at 06:32:21AM -0400, Stefan Berger wrote: On 04/10/2011 11:09 PM, Daniel Veillard wrote: On Sat, Apr 09, 2011 at 11:48:41AM -0400, Stefan Berger wrote: This patch enables the migration of Qemu VMs between hosts of different endianess. I tested this by migrating a i686 VM

[libvirt] IPv6 DNS and domain details

2011-04-11 Thread Neil Wilson
Hi all, I notice that the current IPv6 auto address implementation doesn't pass down any DNS details to the guest machine - which means that an 'IPv6 only' guest that works automatically is currently just out of reach. Support for handing out these details depends upon the version of 'radvd'

Re: [libvirt] [PATCH] docs: document freecell --all

2011-04-11 Thread Eric Blake
On 04/10/2011 09:12 PM, Daniel Veillard wrote: On Wed, Apr 06, 2011 at 11:28:37AM -0600, Eric Blake wrote: Based on a smaller patch developed by Moritoshi Oshiro: https://bugzilla.redhat.com/show_bug.cgi?id=693963 * tools/virsh.pod (freecell): Mention all, and clarify that optional cellno

Re: [libvirt] IPv6 DNS and domain details

2011-04-11 Thread Laine Stump
On 04/11/2011 09:48 AM, Neil Wilson wrote: Hi all, I notice that the current IPv6 auto address implementation doesn't pass down any DNS details to the guest machine - which means that an 'IPv6 only' guest that works automatically is currently just out of reach. Support for handing out these

Re: [libvirt] [PATCH] esx: Mark error message in macros for translation

2011-04-11 Thread Eric Blake
On 04/10/2011 05:28 AM, Matthias Bolte wrote: --- src/esx/esx_vi_types.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/esx/esx_vi_types.c b/src/esx/esx_vi_types.c index 9e23030..29a3c39 100644 --- a/src/esx/esx_vi_types.c +++

Re: [libvirt] [PATCH] virsh: Add --name and --description options to snapshot-create

2011-04-11 Thread Eric Blake
On 04/10/2011 05:31 AM, Matthias Bolte wrote: This options are shortcuts to set name and description of a snapshot. Suggested by Elias Probst --- I'm not sure if this is be best approach. In case of the vol-* commands there is vol-create that takes and XML file and vol-create-as that

Re: [libvirt] [PATCH] docs: Serial and parallel device target ports actually start from 0

2011-04-11 Thread Eric Blake
On 04/10/2011 07:03 AM, Matthias Bolte wrote: Reported by Igor Galić --- docs/formatdomain.html.in |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 574fee5..ea021e8 100644 ---

Re: [libvirt] [PATCH] esx: Make the parsed URI part of the private connection data

2011-04-11 Thread Eric Blake
On 04/10/2011 09:18 AM, Matthias Bolte wrote: This will be used to make esxVI_Context clonable. Also move cleanup code for esxPrivate to esxFreePrivate(). --- src/esx/esx_driver.c | 103 - src/esx/esx_private.h |4 +- 2 files

Re: [libvirt] [PATCH] migrate VMs between different-endian hosts

2011-04-11 Thread Eric Blake
On 04/11/2011 07:36 AM, Daniel Veillard wrote: @@ -3097,6 +3107,11 @@ qemuDomainSaveImageOpen(struct qemud_dri } if (header.version QEMUD_SAVE_VERSION) { +/* convert endianess and try again */ +bswap_header(header); +} Hum, isn't there a more reliable way

Re: [libvirt] [PATCH] migrate VMs between different-endian hosts

2011-04-11 Thread Stefan Berger
On 04/11/2011 01:46 PM, Eric Blake wrote: On 04/11/2011 07:36 AM, Daniel Veillard wrote: @@ -3097,6 +3107,11 @@ qemuDomainSaveImageOpen(struct qemud_dri } if (header.version QEMUD_SAVE_VERSION) { +/* convert endianess and try again */ +bswap_header(header); +}

Re: [libvirt] [PATCH 2/3] maxmem: implement virDomainSetMaxMemory API of the qemu driver

2011-04-11 Thread Eric Blake
+static int qemudDomainSetMaxMemory(virDomainPtr dom, unsigned long memory) { +return qemudDomainSetMemoryFlags(dom, memory, + VIR_DOMAIN_MEM_MAXIMUM | VIR_DOMAIN_MEM_LIVE); Hmm. Given the above implementation, this will _always_ fail. Then

Re: [libvirt] snapshots += domain description?

2011-04-11 Thread Eric Blake
On 12/07/2010 09:00 AM, Philipp Hahn wrote: Hello, I just encountered a problem with the current snapshot implementation for qemu/kvm: To revert back to a snapshot, the domain description must closely match the domain description when the snapshot was created. If the ram-size doesn't

Re: [libvirt] [BUG] qemu: snapshots no longer shown after migration^2

2011-04-11 Thread Eric Blake
On 04/04/2011 12:08 AM, Philipp Hahn wrote: Hello, when a domain is migrated to another host and than back again, snapshots of this domain are no longer shown. I think that is because qemuDomainSnapshotLoad() is only called once from qemudStartup() during startup, but not after migration

Re: [libvirt] [PATCH 1/6] Add new API virDomainStreamDisk[Info] to header and drivers

2011-04-11 Thread Daniel P. Berrange
On Fri, Apr 08, 2011 at 02:26:48PM -0500, Anthony Liguori wrote: On 04/08/2011 11:02 AM, Stefan Hajnoczi wrote: On Fri, Apr 8, 2011 at 2:31 PM, Daniel P. Berrangeberra...@redhat.com wrote: I have CCed Anthony and Kevin. Anthony drove the QED image streaming and Kevin will probably be

[libvirt] [PATCH] maint: fix grammar errors

2011-04-11 Thread Eric Blake
Jim recently improved gnulib to catch various grammar errors during 'make syntax-check'. * .gnulib: Update to latest, for syntax-check improvements. * include/libvirt/libvirt.h.in (virConnectAuthCallbackPtr): Use cannot rather than two words. * src/driver.c: Likewise. * src/driver.h

Re: [libvirt] [PATCH] maint: fix grammar errors

2011-04-11 Thread Wen Congyang
At 04/12/2011 06:27 AM, Eric Blake Write: Jim recently improved gnulib to catch various grammar errors during 'make syntax-check'. * .gnulib: Update to latest, for syntax-check improvements. * include/libvirt/libvirt.h.in (virConnectAuthCallbackPtr): Use cannot rather than two words. *