Interestingly, we had codefloorcode ... /codeoutbound/code which
results in much larger block of text to be written in code style that
intended.
---
docs/formatdomain.html.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/formatdomain.html.in
The outbound/@peak is ignored (since QoS was introduced). This is due to
kernel limitation of know allowing ingress filters to have peak just
average rate. However, we should document this limitation to not confuse
users.
---
docs/formatdomain.html.in | 4 +++-
1 file changed, 3 insertions(+), 1
On 26.07.2013 11:19, Alex Jia wrote:
Signed-off-by: Alex Jia a...@redhat.com
---
src/conf/domain_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 10cb7f6..0e74039 100644
--- a/src/conf/domain_conf.c
+++
On 26.07.2013 12:28, Ján Tomko wrote:
Leaving it at -1 causes invalid free in virNetworkDefUpdateDNSHost
if virNetworkDNSHostDefParseXML fails and virNetworkDNSHostDefClear
gets called twice.
---
src/conf/network_conf.c | 4
1 file changed, 4 insertions(+)
diff --git
On 26.07.2013 12:28, Ján Tomko wrote:
---
src/conf/network_conf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
index 5faac92..2561c35 100644
--- a/src/conf/network_conf.c
+++ b/src/conf/network_conf.c
@@ -920,7
On 26.07.2013 12:28, Ján Tomko wrote:
This fixes a crash if one of them is missing.
https://bugzilla.redhat.com/show_bug.cgi?id=988718
---
src/conf/network_conf.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
On 26.07.2013 12:28, Ján Tomko wrote:
ip has to be NULL at this point.
---
src/conf/network_conf.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
index 2561c35..2040d26 100644
--- a/src/conf/network_conf.c
+++
On 26.07.2013 12:54, Ján Tomko wrote:
Decrementing it when it was already 0 causes an invalid free
in virNetworkDefUpdateDNSHost if virNetworkDNSHostDefParseXML
fails and virNetworkDNSHostDefClear gets called twice.
virNetworkForwardDefClear left the number untouched even if it
freed all
https://bugzilla.redhat.com/show_bug.cgi?id=979477
Since 1.0.3 we are using the new way to copy non shared storage during
migration (the NBD way). However, whether the new or old way is used is
not controllable by user but unconditionally turned on if both sides of
migration support it. Moreover,
On 05.08.2013 14:46, Richard Hughes wrote:
On 5 August 2013 12:15, Daniel P. Berrange berra...@redhat.com wrote:
What is the replacement ? We need to be able to query whether
each of suspend, hibernate, or suspend-hybrid are supported on
a host, and then report that upto the mgmt app using
On 05.08.2013 15:41, Daniel P. Berrange wrote:
On Mon, Aug 05, 2013 at 03:07:15PM +0200, Michal Privoznik wrote:
On 05.08.2013 14:46, Richard Hughes wrote:
On 5 August 2013 12:15, Daniel P. Berrange berra...@redhat.com wrote:
What is the replacement ? We need to be able to query whether
each
On 06.08.2013 13:35, Daniel P. Berrange wrote:
This series fixes the CA certificate validation so that it
correctly works when a client and server cert are both signed
by intermediate CAs, sharing a common ancestor CA.
--
libvir-list mailing list
libvir-list@redhat.com
On 06.08.2013 13:35, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Currently every test case in the TLS test suite generates the
certs fresh. This is a waste of time, since its parameters
don't change across test cases. Create certs once in main
method.
On 06.08.2013 13:35, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The code added to validate CA certificates did not take into
account the possibility that the cacert.pem file can contain
multiple (concatenated) cert data blocks. Extend the code for
loading CA
On 08.08.2013 13:27, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The gendispatch.pl script puts comments at the top of files
it creates, saying that it auto-generated them. Also include
the name of the source data file which it reads when doing
the
On 09.08.2013 01:41, Jim Fehlig wrote:
Currently, only one log file is created by the libxl driver, with
all output from libxl for all domains going to this one file.
Create a per-domain log file based on domain name, making sifting
through the logs a bit easier. This required deferring
On 08.08.2013 13:27, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
This adds two new pages to the website, acl.html describing
the general access control framework and permissions models,
and aclpolkit.html describing the use of polkit as an
access control driver.
This function is to guess the correct limit for maximal memory
usage by qemu for given domain. This can never be guessed
correctly, not to mention all the pains and sleepless nights this
code has caused. Once somebody discovers algorithm to solve the
Halting Problem, we can compute the limit
This function is to guess the correct limit for maximal memory
usage by qemu for given domain. This can never be guessed
correctly, not to mention all the pains and sleepless nights this
code has caused. Once somebody discovers algorithm to solve the
Halting Problem, we can compute the limit
[CC'ing qemu-devel list]
On 09.08.2013 15:17, Daniel P. Berrange wrote:
On Fri, Aug 09, 2013 at 07:13:58AM -0600, Eric Blake wrote:
On 08/09/2013 06:56 AM, Michal Privoznik wrote:
This function is to guess the correct limit for maximal memory
usage by qemu for given domain. This can never
On 18.08.2013 16:46, David Weber wrote:
Hi,
we recently ran into a problem when trying to start more than 20 guests if
direct locking with virtlockd was enabled. The error message locked like this:
# start test7
error: Failed to start domain test7
error: Cannot recv data: Connection reset
On 09.08.2013 18:29, Daniel P. Berrange wrote:
On Fri, Aug 09, 2013 at 10:58:55AM -0500, Anthony Liguori wrote:
Michal Privoznik mpriv...@redhat.com writes:
[CC'ing qemu-devel list]
On 09.08.2013 15:17, Daniel P. Berrange wrote:
On Fri, Aug 09, 2013 at 07:13:58AM -0600, Eric Blake wrote
In one of my previous patches I am removing the hard_limit heuristic to
guess the correct value if none set. However, it turned out, this limit
is hard to guess even for users. We should advise them to not set the
limit as their domains may be OOM killed. Sigh.
---
docs/formatdomain.html.in | 5
On 19.08.2013 11:06, Daniel P. Berrange wrote:
On Mon, Aug 19, 2013 at 10:29:10AM +0200, Michal Privoznik wrote:
On 09.08.2013 18:29, Daniel P. Berrange wrote:
On Fri, Aug 09, 2013 at 10:58:55AM -0500, Anthony Liguori wrote:
Michal Privoznik mpriv...@redhat.com writes:
[CC'ing qemu-devel
On 19.08.2013 12:06, Daniel P. Berrange wrote:
On Mon, Aug 19, 2013 at 12:02:47PM +0200, Michal Privoznik wrote:
In one of my previous patches I am removing the hard_limit heuristic to
guess the correct value if none set. However, it turned out, this limit
is hard to guess even for users. We
On 08.08.2013 16:38, Tomas Meszaros wrote:
completer and completer_flags added to the _vshCmdDef and _vshCmdOptDef
structures so it will be possible for completion generators to
conveniently call completer functions with desired flags.
---
tools/virsh-domain.c | 10 +-
tools/virsh.h
On 08.08.2013 16:38, Tomas Meszaros wrote:
New completion generators responsible for advances command
and command options completions.
vshReadlineCommandCompletionGenerator - generator for advanced
command completions. This function will call some vshCmdCompleter
function (e.g.
On 08.08.2013 16:38, Tomas Meszaros wrote:
Function vshDomainCompler returns domains names.
Michal Privoznik recommended to add global variable __my_conn
so we can get the list of domains from the virConnecTListAllDomains().
vshReconnect() is called before the first command is executed
On 08.08.2013 16:38, Tomas Meszaros wrote:
Hi, this patch series is a prototype for my GSoC project (Michal Privoznik
is my mentor).
I'm working on virsh auto-completion, trying to make it more intelligent.
At this stage, prototype is capable of command and option completion. Three
On 08.08.2013 16:38, Tomas Meszaros wrote:
Add .completer and .completer_flags to domManagementCmds.
vshDomainCompleter (with appropriate flags) is enabled for
commands requiring only single domain argument.
---
tools/virsh-domain.c | 230
---
docs/formatdomain.html.in | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 4a927cc..12a756c 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -677,8 +677,9 @@
dd The optional
Since 16bcb3 we have a regression. The hard_limit is set
unconditionally. By default, the limit is zero. Hence, if user hasn't
configured any, we set the zero in cgroup subsystem making the kernel
kill the corresponding qemu process immediately. The proper fix is to
set hard_limit iff user has
If there's no hard_limit set and domain uses VFIO we still must lock the
guest memory (prerequisite from qemu). Hence, we should compute the
amount to be locked from max_baloon.
---
src/qemu/qemu_command.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git
On 20.08.2013 14:11, Ján Tomko wrote:
On 08/20/2013 11:10 AM, Michal Privoznik wrote:
Since 16bcb3 we have a regression. The hard_limit is set
unconditionally. By default, the limit is zero. Hence, if user hasn't
configured any, we set the zero in cgroup subsystem making the kernel
kill
On 21.08.2013 07:31, Naor Shlomo wrote:
Hello experts,
Could anyone please tell me if Multi Queue it fully supported in Libvirt
and if so what version contains it?
Do you mean multiqueue network? It's supported from 1.0.6. You can set
it in /domain/devices/interface/driver/@queues
If user requested multiqueue networking, beside multiple /dev/tap and
/dev/vhost-net openings, we forgot to pass mq=on onto the -device
virtio-net-pci command line. This is advised at:
http://www.linux-kvm.org/page/Multiqueue#Enable_MQ_feature
---
Notes:
Maybe worth backporting to
On 20.08.2013 22:02, Tomas Meszaros wrote:
* vshMalloc is now used in vshDetermineCommandName
* vshStrdup instead of vshMalloc + snprintf
* joined if's in vshReadlineOptionsCompletionGenerator
---
tools/virsh.c | 395
++
1 file
On 20.08.2013 22:02, Tomas Meszaros wrote:
* label cleanup renamed to error
* vshSuspendTargetCompleter added to opts_dom_pm_suspend
---
tools/virsh-domain.c | 3 ++-
tools/virsh.c| 28
tools/virsh.h| 1 +
3 files changed, 31 insertions(+), 1
On 20.08.2013 22:02, Tomas Meszaros wrote:
vshRebootShutdownModeCompleter returns available modes
for reboot/shutdown commands.
---
tools/virsh.c | 28
tools/virsh.h | 1 +
2 files changed, 29 insertions(+)
Again, you should add .completer =
On 20.08.2013 22:02, Tomas Meszaros wrote:
* global variable __my_conn renamed to vshConn
* @name is now const char *
* label cleanup renamed to error
---
tools/virsh.c | 53 +
tools/virsh.h | 2 ++
2 files changed, 55 insertions(+)
On 22.08.2013 13:39, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The virDomainOpenGraphics method accepts a UNIX socket FD from
the client app. It must set the label on this FD otherwise QEMU
will be prevented from receiving it with recvmsg.
Signed-off-by:
With the rising number of signed-off patches appearing on the list,
we should have policy what signed-off means, and advice (enforce?)
contributors to use it.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
HACKING | 8 ++--
docs/hacking.html.in | 12
2
Yet another advice appeared on the Multiqueue wiki page:
http://www.linux-kvm.org/page/Multiqueue#Enable_MQ_feature
We should add vectors=N onto the qemu command line, where
N = 2 * (number of queues) + 1.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/qemu/qemu_command.c | 13
On 26.08.2013 17:34, Eric Blake wrote:
On 08/26/2013 09:28 AM, Michal Privoznik wrote:
If there's no hard_limit set and domain uses VFIO we still must lock
the guest memory (prerequisite from qemu). Hence, we should compute
the amount to be locked from max_balloon.
Signed-off-by: Michal
If there's no hard_limit set and domain uses VFIO we still must lock
the guest memory (prerequisite from qemu). Hence, we should compute
the amount to be locked from max_balloon.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/qemu/qemu_hotplug.c | 7 +--
1 file changed, 5
On 27.08.2013 10:58, Alex Jia wrote:
On 08/27/2013 04:47 PM, Peter Krempa wrote:
On 08/27/13 09:53, Alex Jia wrote:
The flag VIR_DOMAIN_BLOCK_COMMIT_DELETE is missed by
qemuDomainBlockCommit(),
and then will hit error unsupported flags (0x2) in function
qemuDomainBlockCommit if users run
On 27.08.2013 14:03, Laine Stump wrote:
On 08/26/2013 09:39 AM, Ján Tomko wrote:
If the network has not been found, virNetworkFree(NULL)
was called, resulting in an extra error:
error: invalid network pointer in virNetworkFree
The patch is okay, but all vir*Free() functions should be NOPs
On 23.08.2013 09:16, Ján Tomko wrote:
On 08/15/2013 01:30 PM, Ján Tomko wrote:
v3:
use pcihole64 sub-element of the root PCI controller
with 'unit' attribute, defaulting to KiB
v2:
https://www.redhat.com/archives/libvir-list/2013-August/msg00565.html
Use 'pcihole64' attribute of the root
]
goto asprintf_failure;
^
virsh-pool.c:1308:1: note: label 'asprintf_failure' defined here
asprintf_failure:
^
virsh-pool.c:1267:11: note: 'outputStr' declared here
char *outputStr = NULL;
Signed-off-by: Michal Privoznik mpriv...@redhat.com
On 28.08.2013 08:22, Ján Tomko wrote:
On 08/28/2013 03:39 AM, Eric Blake wrote:
On 08/27/2013 06:27 AM, Martin Kletzander wrote:
diff --git a/tools/virsh.c b/tools/virsh.c
index ac77156..34f5c4a 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -2321,10 +2321,9 @@ vshInitDebug(vshControl
For now, only three APIs are implemented:
virFileGetACL to retrieve permission for a specific user
virFileSetACL for setting requested permissions for a specific user,
virFileRemoveACL to remove those permissions.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
configure.ac
-existing, it shouldn't block this
set, should it?
Michal Privoznik (3):
virFile: Add APIs for extended attributes handling
virfile: Introduce internal API for managing ACL
security_dac: Favour ACLs over chown()
configure.ac| 2 +
libvirt.spec.in | 1 +
m4
-by: Michal Privoznik mpriv...@redhat.com
---
src/libvirt_private.syms | 3 ++
src/util/virfile.c | 111 +++
src/util/virfile.h | 13 ++
3 files changed, 127 insertions(+)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index
owner of file.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/security/security_dac.c | 297 +++-
1 file changed, 268 insertions(+), 29 deletions(-)
diff --git a/src/security/security_dac.c b/src/security/security_dac.c
index 8cbb083..913b68e
Similarly to qemu_driver.c, we can join often repeating code of looking
up network into one function: networkObjFromNetwork.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/network/bridge_driver.c | 76 ++---
1 file changed, 31 insertions
On 28.08.2013 14:31, Christophe Fergeau wrote:
These symbols are in public headers, but were not listed in the
corresponding .sym file, causing them to be unavailable from
the resulting shared library.
I would have preferred not to export gvir_config_object_new_from_xml()
at all, but since
On 28.08.2013 15:14, Peter Krempa wrote:
Version 2 contains a fix of more callers in qemu and a whitespace cleanup.
Peter Krempa (2):
qemu: Remove hostdev entry when freeing the depending network entry
qemu_hotplug: Fix whitespace around addition in argument
src/conf/domain_conf.c
On 17.08.2013 00:14, Eric Blake wrote:
Noticed while reviewing another patch that had an accidental
mismatch due to refactoring. An audit of the code showed that
very few callers of vshCommandOpt were expecting a return of
-2, indicating programmer error, and of those that DID check,
they
On 29.08.2013 08:07, Naor Shlomo wrote:
Hi Michal
First of all thanks for your reply.
I followed your advice and the guideline you sent and did the following:
interface type='bridge'
mac address='52:54:00:43:6e:3f'/
source bridge='clients'/
model type='virtio'/
On 29.08.2013 08:55, Naor Shlomo wrote:
How odd.
The Kernel is the first thing I upgraded, here's the output of uname -r:
3.10.9
I searched for IFF_MULTI_QUEUE in /usr/include/linux/if_tun.h and indeed it
wasn't there.
I believe Kernel 3.10 should support the Multi Queue, do I need to
On 28.08.2013 23:05, Oskari Saarenmaa wrote:
Interface names do not have to be numerical (or veth + number) and trying to
assign them to that format is susceptible to race conditions. Instead,
assign the parent interface name according to the mac address (the last
three bytes) if no name was
On 28.08.2013 23:53, Doug Goldstein wrote:
Sometimes a serial port might not be actually wired to a device when the
user does not have the VM powered on and we should not consider this a
fatal error.
---
src/vmx/vmx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On 28.08.2013 23:53, Doug Goldstein wrote:
A user came into #virt the other day and was trying to get libvirtd
to work with VMWare Fusion 5, which is basically the Mac OS X version of
VMWare Workstation. In helping him out I noticed a few limitations of our
VMX parser so I've added support
On 28.08.2013 23:53, Doug Goldstein wrote:
A user was having an issue with this specific VMWare Fusion config and
he gave me permission to add it as part of our test suite to further
expand our VMX test coverage. Unfortunately our VMX parser and
generator does not support many features
On 28.08.2013 23:53, Doug Goldstein wrote:
According to VMWare's documentation 'cdrom-raw' is an acceptable value
for deviceType for a CD-ROM drive. The documentation states that the VMX
configuration for a CD-ROM deviceType is as follows:
ide|scsi(n):(n).deviceType =
On 28.08.2013 23:53, Doug Goldstein wrote:
virVMXFormatHardDisk() and virVMXFormatCDROM() duplicated a lot of code
from each other and made a lot of nested if checks to build each part of
the VMX file. This hopefully simplifies the code path while combining
the two functions with no net
One of my previous patches 5cfe0d37cd0be tried to handle the case when
libvirt is a submodule of another project. In that case, the .git is
just a link to the parent .git directory (which the autogen.sh script
didn't count on). The fix was missing 'test' though.
Signed-off-by: Michal Privoznik
On 29.08.2013 12:49, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The parameters for the virDomainMigrate*Params RPC calls were
not bounds checks, meaning a malicious client can cause libvirtd
to consume arbitrary memory
This issue was introduced in the 1.1.0
On 29.08.2013 14:55, Daniel P. Berrange wrote:
On Thu, Aug 29, 2013 at 02:34:15PM +0200, Michal Privoznik wrote:
On 29.08.2013 12:49, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The parameters for the virDomainMigrate*Params RPC calls were
not bounds checks
On 29.08.2013 13:24, Daniel P. Berrange wrote:
As everyone knows, we have historically always shipped the python binding
as part of the libvirt primary tar.gz distribution. In some ways that has
simplified life for people, since we know they'll always have a libvirt
python that matches their
On 30.08.2013 23:46, Jim Fehlig wrote:
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
src/libxl/libxl_conf.h | 2 +-
src/libxl/libxl_driver.c | 10 --
2 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/src/libxl/libxl_conf.h b/src/libxl/libxl_conf.h
index
On 30.08.2013 23:46, Jim Fehlig wrote:
libxlDomainGetInfo() uses the driver-wide libxl ctx when
it would be more appropriate to use the per-domain ctx
associated with the domain. Switch to using the per-domain
libxl ctx.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
On 30.08.2013 23:46, Jim Fehlig wrote:
The libxlDriverPrivate struct contains an variety of data with
varying access needs. Similar to the QEMU and LXC drivers,
move all the static config data into a dedicated libxlDriverConfig
object. The only locking requirement is to hold the driver lock
On 30.08.2013 23:46, Jim Fehlig wrote:
Now that most fields of libxlDriverPrivate struct are immutable
or self-locking, there is no need to acquire the driver lock in
much of the libxl driver.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
src/libxl/libxl_conf.c | 7 +-
On 30.08.2013 23:46, Jim Fehlig wrote:
libxlMakeDomCreateInfo() uses the driver-wide libxl ctx when
it would be more appropriate to use the per-domain ctx
associated with the domain. Switch to using the per-domain
libxl ctx.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
On 30.08.2013 23:46, Jim Fehlig wrote:
Move the libxl driver lock/unlock functions from libxl_driver.c
to libxl_conf.h so they can be used by other source files.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
src/libxl/libxl_conf.h | 12
src/libxl/libxl_driver.c | 12
On 30.08.2013 23:46, Jim Fehlig wrote:
Create libxl_domain.[ch] and move all functions operating on
libxlDomainObjPrivate to these files. This will be useful for
future patches that e.g. add job support for libxlDomainObjPrivate.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
On 30.08.2013 23:46, Jim Fehlig wrote:
Similar to the QEMU and LXC drivers, add a helper function to
lookup a domain, and use it instead of much copy and paste.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
src/libxl/libxl_driver.c | 269
++-
On 30.08.2013 23:46, Jim Fehlig wrote:
libxl version info is static data as far as the libxl driver
is concerned, so retrieve this info when the driver is initialized
and stash it in the libxlDriverPrivate object. Subsequently use
the stashed info instead of repeatedly calling
On 30.08.2013 23:46, Jim Fehlig wrote:
Detecting whether or not to autoballoon is configuration related,
so move the code to libxl_conf.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
src/libxl/libxl_conf.c | 22 ++
src/libxl/libxl_conf.h | 3 +++
On 30.08.2013 23:46, Jim Fehlig wrote:
Detect early on in libxl driver initialization if the driver
should be loaded at all, avoiding needless initialization steps
that only have to be undone later. While at it, move th
s/th/the/
detection to a helper function to improve readability.
On 30.08.2013 23:46, Jim Fehlig wrote:
Similar to the QEMU and LXC drivers, annotate the fields of
libxlDriverPrivate struct to indicate the locking rules for
their use.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
src/libxl/libxl_conf.h | 7 +++
1 file changed, 7 insertions(+)
of error. Then, its caller, the
virNetDevTapCreateInBridgePort() iterates over the FD array and tries to
close them too. And so does qemuNetworkIfaceConnect() and
qemuBuildInterfaceCommandLine().
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/qemu/qemu_command.c | 10 +++---
src
On 29.08.2013 17:52, Peter Krempa wrote:
This patch adds instrumentation to allow modification of config of the
terminal in virsh and successful reset of the state afterwards.
The added helpers allow to disable receiving of SIGINT when pressing the
key sequence (Ctrl+C usualy). This normally
On 29.08.2013 17:52, Peter Krempa wrote:
The vshWatchJob function registers a SIGINT handler that is used to
abort the active job and does not terminate virsh. Unfortunately, this
breaks when using the ssh transport as SIGINT is sent to the foreground
process group including the ssh transport
On 03.09.2013 06:42, Naor Shlomo wrote:
Hi Michal
First of all I want to let you know that I really appreciate your guidance.
Second thing, after I successfully installed the kernel headers I was able to
compile libvirt again, this time it let me start the Guest with queues='5'
The Guest
On 29.08.2013 18:36, Peter Krempa wrote:
This series has to be applied on top of virsh: Handle interrupting of jobs
manually.
Peter Krempa (3):
tools: rename console.[ch] to virsh-console.[ch] and fix coding style
virsh: Rename vshMakeStdinRaw to vshTTYMakeRaw and move it to virsh.c
On 29.08.2013 18:36, Peter Krempa wrote:
---
cfg.mk | 2 +-
po/POTFILES.in | 2 +-
tools/Makefile.am| 2 +-
tools/{console.c = virsh-console.c} | 73
++--
tools/{console.h =
The test should refer to Virtlockd.lns, which is the name of
the module + lens in virtlockd.aug.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/locking/test_virtlockd.aug.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/locking/test_virtlockd.aug.in
b/src
On 03.09.2013 17:35, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The VIR_FREE() macro will cast away any const-ness. This masked a
number of places where we passed a 'const char *' string to
VIR_FREE. Fortunately in all of these cases, the variable was not
in fact
On 03.09.2013 17:35, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The VIR_FREE() macro will cast away any const-ness. This masked a
number of places where we passed a 'const char *' string to
VIR_FREE. Fortunately in all of these cases, the variable was not
in fact
The @profile_name variable can be used uninitialized.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
Pushing under trivial and build breaker rules.
src/security/security_apparmor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/security/security_apparmor.c b
The @qemunbd variable can be used uninitialized.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
Pushing under trivial and build breaker rules.
src/util/virfile.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virfile.c b/src/util/virfile.c
index 2b07ac9
On 04.09.2013 09:24, arun abhinay wrote:
Hi,
In reference to comment28 in below link
https://bugzilla.redhat.com/show_bug.cgi?id=911609#c28
The issue was fixed in libvirt-0.10.2-19.el6 version. I am facing
similar crash and want to check with libvirt-0.10.2-19.el6 version. But
i
On 04.09.2013 08:37, Jim Fehlig wrote:
Change libxlGetAutoballoonConf() function to return an int
for success/failure, and fail if regcomp fails.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
src/libxl/libxl_conf.c | 30 +++---
1 file changed, 19 insertions(+), 11
On 04.09.2013 10:29, Michal Privoznik wrote:
On 04.09.2013 08:37, Jim Fehlig wrote:
Change libxlGetAutoballoonConf() function to return an int
for success/failure, and fail if regcomp fails.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
src/libxl/libxl_conf.c | 30
On 04.09.2013 04:41, Eric Blake wrote:
Automake has builtin support to prevent botched conditional nesting,
but only if you use:
if FOO
else !FOO
endif !FOO
An example error message when using the wrong name:
daemon/Makefile.am:378: error: else reminder
On 28.08.2013 22:56, Eric Blake wrote:
Failure to attach to a domain during 'virsh qemu-attach' left
the list of domains in an odd state:
$ virsh qemu-attach 4176
error: An error occurred, but the cause is unknown
$ virsh list --all
IdName State
On 28.08.2013 06:00, Eric Blake wrote:
In Fedora 19, 'qemu-kvm' is a simple wrapper that calls
'qemu-system-x86_64 -machine accel=kvm'. Attempting
to use 'virsh qemu-attach $pid' to a machine started as:
qemu-kvm -cdrom /var/lib/libvirt/images/foo.img \
-monitor
On 29.08.2013 00:38, Eric Blake wrote:
While debugging a failure of 'virsh qemu-attach', I noticed that
we were leaking the count of active domains on failure. This
means that a libvirtd session that is supposed to quit after
active domains disappear will hang around forever.
*
801 - 900 of 15045 matches
Mail list logo
