[libvirt] [python PATCH] Implement new virNetworkGetDHCPLeases{ForMAC} APIs

2014-06-25 Thread Nehal J Wani
These APIs return a list of dhcp leases for all network interfaces connected to the given virtual network or limited output just for one interface if mac is specified. Example Output: [{'iface': 'virbr3', 'ipaddr': '192.168.150.181', 'hostname': 'ubuntu14', 'expirytime': 1403737495L,

Re: [libvirt] Entering freeze for libvirt-1.2.6

2014-06-26 Thread Nehal J Wani
Python bindings can't be built, but that's just because virNetwork*DHCPLease* are not covered. I have sent a patch for the python bindings for virNetwork*DHCPLease* APIs: http://www.redhat.com/archives/libvir-list/2014-June/msg01300.html Regards, Nehal J Wani -- libvir-list mailing list

Re: [libvirt] [for 1.2.6] Redundancy of virNetworkGetDHCPLeases and virNetworkGetDHCPLeasesForMAC

2014-06-26 Thread Nehal J Wani
an optional macaddr parameter, but I think it is nicer to just have clear APIs for the list many vs get one tasks. Regards, Daniel Regards, Nehal J Wani -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] RFC: 'old' event for leaseshelper.c when lease renews

2014-06-27 Thread Nehal J Wani
that we will have to add to leaseshelper if we go with (i). The easier option is to go with (ii), since Simon is already willing to add that functionality. -- Nehal J Wani -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] RFC: 'old' event for leaseshelper.c when lease renews

2014-06-30 Thread Nehal J Wani
On Mon, Jun 30, 2014 at 1:52 PM, Daniel P. Berrange berra...@redhat.com wrote: On Sat, Jun 28, 2014 at 05:06:26AM +0530, Nehal J Wani wrote: In the current version of dnsmasq, the leases helper script/program specified by --dhcp-script to dnsmasq is invoked on three events, 'add', 'old', 'del

Re: [libvirt] RFC: 'old' event for leaseshelper.c when lease renews

2014-06-30 Thread Nehal J Wani
, hostname: Wani-PC, client-id: 01:52:54:00:11:56:b3, expiry-time: 1393244248 } ] Do we want this in 1.2.6? Regards, Nehal J Wani -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] RFC: 'old' event for leaseshelper.c when lease renews

2014-07-01 Thread Nehal J Wani
/interface1 and the script finds the basename of argv[0[: scripts/interface1 - interface1 and prepends the directory where the lease files are interface1 -leasefiles/interface1 That works in the absence on the DNSMASQ_INTERFACE variable. Is this hack acceptable? -- Nehal J Wani -- libvir

Re: [libvirt] RFC: 'old' event for leaseshelper.c when lease renews

2014-07-03 Thread Nehal J Wani
/interface1 - interface1 and prepends the directory where the lease files are interface1 -leasefiles/interface1 That works in the absence on the DNSMASQ_INTERFACE variable. Is this hack acceptable? Ping! -- Nehal J Wani -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com

Re: [libvirt] [PATCH 0/2] docs: hacking and formatdomain fixes

2014-07-04 Thread Nehal J Wani
docs/hacking.html.in | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) -- 1.9.3 ACK Series Regards, Nehal J Wani -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] leaseshelper: add enhancements to support all events

2014-07-10 Thread Nehal J Wani
This patch enables the helper program to detect event(s) triggered when there is a change in lease length or expiry and client-id. This transfers complete control of leases database to libvirt and suppresses use of the lease database file (network-name.leases). That file will not be created, read,

Re: [libvirt] [PATCH] leaseshelper: add enhancements to support all events

2014-07-11 Thread Nehal J Wani
On Fri, Jul 11, 2014 at 5:49 AM, Nehal J Wani nehaljw.k...@gmail.com wrote: This patch enables the helper program to detect event(s) triggered when there is a change in lease length or expiry and client-id. This transfers complete control of leases database to libvirt and suppresses use

Re: [libvirt] python bindings links?

2014-07-14 Thread Nehal J Wani
, which is a html page. We should convert it to php, probably? So that http://libvirt.org/python doesn't give a 404 ? or some kind of rewrite rule in .htaccess to redirect http://libvirt.org/python to http://libvirt.org/python.html ? -- Nehal J Wani -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] leaseshelper: add enhancements to support all events

2014-07-16 Thread Nehal J Wani
On Fri, Jul 11, 2014 at 5:49 AM, Nehal J Wani nehaljw.k...@gmail.com wrote: This patch enables the helper program to detect event(s) triggered when there is a change in lease length or expiry and client-id. This transfers complete control of leases database to libvirt and suppresses use

Re: [libvirt] [PATCH] leaseshelper: add enhancements to support all events

2014-07-16 Thread Nehal J Wani
. But then again, the use of --leasefile-ro is mandatory, so that all events are captured by our helper program. For example, renew of a lease. Regards, Nehal J Wani -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] leaseshelper: add enhancements to support all events

2014-07-17 Thread Nehal J Wani
My concerns are whether this will work in the case you already used the leases helper as the patch is adding a few fields to the stored format. In this patch, I am only adding server-duid as an extra JSON object. I am not adding more fields to an existing JSON object. The old leases file will

Re: [libvirt] [PATCH] leaseshelper: add enhancements to support all events

2014-07-21 Thread Nehal J Wani
the lease expired. This patch rectifies it. I'll send a v2 shortly. Regards, Nehal J Wani -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v2] leaseshelper: improvements to support all events

2014-07-21 Thread Nehal J Wani
This patch enables the helper program to detect event(s) triggered when there is a change in lease length or expiry and client-id. This transfers complete control of leases database to libvirt and obsoletes use of the lease database file (network-name.leases). That file will not be created, read,

Re: [libvirt] [PATCH v2] leaseshelper: improvements to support all events

2014-07-23 Thread Nehal J Wani
PACKAGE_VERSION) so that whenever a new field is added in the future, we don't have trouble finding out which version of leaseshelper added it. Regards, Nehal J Wani -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] leaseshelper: avoid mem leak after storing lease entries

2014-07-23 Thread Nehal J Wani
Contents of existing lease file were being stored in a variable which was never freed. --- src/network/leaseshelper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/network/leaseshelper.c b/src/network/leaseshelper.c index e4b5283..c8543a2 100644 --- a/src/network/leaseshelper.c +++

[libvirt] [PATCH v3] leaseshelper: improvements to support all events

2014-08-04 Thread Nehal J Wani
This patch enables the helper program to detect event(s) triggered when there is a change in lease length or expiry and client-id. This transfers complete control of leases database to libvirt and obsoletes use of the lease database file (network-name.leases). That file will not be created, read,

Re: [libvirt] Error

2014-08-06 Thread Nehal J Wani
On Wed, Aug 6, 2014 at 6:55 PM, Eric Blake ebl...@redhat.com wrote: On 08/05/2014 10:55 PM, ahmad jan wrote: I want to configure Libvirt-1.2.7 on ubuntu and found the following Error Could not find linxml2 anywhere That's not the actual error message you saw, as the string linxml2 does not

Re: [libvirt] [PATCH v3] leaseshelper: improvements to support all events

2014-08-10 Thread Nehal J Wani
On Mon, Aug 4, 2014 at 1:29 PM, Nehal J Wani nehaljw.k...@gmail.com wrote: This patch enables the helper program to detect event(s) triggered when there is a change in lease length or expiry and client-id. This transfers complete control of leases database to libvirt and obsoletes use

Re: [libvirt] [PATCH v3] leaseshelper: improvements to support all events

2014-08-20 Thread Nehal J Wani
On Mon, Aug 11, 2014 at 1:14 AM, Nehal J Wani nehaljw.k...@gmail.com wrote: On Mon, Aug 4, 2014 at 1:29 PM, Nehal J Wani nehaljw.k...@gmail.com wrote: This patch enables the helper program to detect event(s) triggered when there is a change in lease length or expiry and client-id

Re: [libvirt] [PATCH v3] leaseshelper: improvements to support all events

2014-08-29 Thread Nehal J Wani
On Wed, Aug 20, 2014 at 4:23 PM, Roman Bogorodskiy bogorods...@gmail.com wrote: Nehal J Wani wrote: This patch enables the helper program to detect event(s) triggered when there is a change in lease length or expiry and client-id. This transfers complete control of leases database

Re: [libvirt] [PATCH 2/2] maint: syntax check for double semicolons

2014-09-04 Thread Nehal J Wani
) -return -1;; +return -1; if (xenFormatCDROM(conf, def, xendConfigVersion) 0) return -1; -- 1.9.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list ACK -- Nehal J Wani -- libvir-list mailing list

Re: [libvirt] [PATCH v3] leaseshelper: improvements to support all events

2014-09-10 Thread Nehal J Wani
On Wed, Aug 20, 2014 at 4:23 PM, Roman Bogorodskiy bogorods...@gmail.com wrote: Nehal J Wani wrote: This patch enables the helper program to detect event(s) triggered when there is a change in lease length or expiry and client-id. This transfers complete control of leases database

Re: [libvirt] [PATCH v3] leaseshelper: improvements to support all events

2014-09-11 Thread Nehal J Wani
On Thu, Sep 11, 2014 at 8:38 PM, Peter Krempa pkre...@redhat.com wrote: On 08/04/14 09:59, Nehal J Wani wrote: This patch enables the helper program to detect event(s) triggered when there is a change in lease length or expiry and client-id. This transfers complete control of leases database

Re: [libvirt] [PATCH] Fix API docs for header file re-organization

2014-11-17 Thread Nehal J Wani
)/html/libvirt-libvirt-lxc.html \ $(srcdir)/html/libvirt-libvirt-qemu.html \ $(srcdir)/html/libvirt-virterror.html \ -- Nehal J Wani -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v4] leaseshelper: improvements to support all events

2014-11-18 Thread Nehal J Wani
This patch enables the helper program to detect event(s) triggered when there is a change in lease length or expiry and client-id. This transfers complete control of leases database to libvirt and obsoletes use of the lease database file (network-name.leases). That file will not be created, read,

Re: [libvirt] [libvirt-python PATCH] fix examples

2014-11-28 Thread Nehal J Wani
: print(str(err)) # will print something like option -a not recognized usage() -- 2.0.4 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list ACK -- Nehal J Wani -- libvir-list mailing list libvir-list@redhat.com https

Re: [libvirt] [PATCHv5 0/3] leaseshelper: Couple of improvements

2014-12-01 Thread Nehal J Wani
On Thu, Nov 20, 2014 at 7:28 PM, Peter Krempa pkre...@redhat.com wrote: Nehal J Wani (1): leaseshelper: improvements to support all events Peter Krempa (2): leaseshelper: Refactor control flow network: dnsmasq: Don't format lease file path src/network/bridge_driver.c

[libvirt] [RFC] The Quest for Domain-IP Mapping Continues...

2014-12-04 Thread Nehal J Wani
prefer OP1. What do you guys think? -- Nehal J Wani -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [RFC] The Quest for Domain-IP Mapping Continues...

2014-12-05 Thread Nehal J Wani
On Fri, Dec 5, 2014 at 3:33 PM, Daniel P. Berrange berra...@redhat.com wrote: On Fri, Dec 05, 2014 at 12:20:03AM +0530, Nehal J Wani wrote: If you remember correctly, about 1.2 years ago, we had... https://www.redhat.com/archives/libvir-list/2013-September/msg00351.html In short, the patch

Re: [libvirt] [RFC] The Quest for Domain-IP Mapping Continues...

2014-12-14 Thread Nehal J Wani
On Fri, Dec 5, 2014 at 4:33 PM, Daniel P. Berrange berra...@redhat.com wrote: On Fri, Dec 05, 2014 at 04:28:10PM +0530, Nehal J Wani wrote: On Fri, Dec 5, 2014 at 3:33 PM, Daniel P. Berrange berra...@redhat.com wrote: On Fri, Dec 05, 2014 at 12:20:03AM +0530, Nehal J Wani wrote: If you

[libvirt] [PATCHv7 0/4] Introduce API to query IP addresses for given domain

2014-12-16 Thread Nehal J Wani
://www.redhat.com/archives/libvir-list/2013-July/msg01553.html Nehal J Wani (4): domifaddr: Implement the public APIs domifaddr: Implement the remote protocol domifaddr: Implement the API for qemu domifaddr: Add virsh support daemon/remote.c | 134

[libvirt] [PATCHv7 1/4] domifaddr: Implement the public APIs

2014-12-16 Thread Nehal J Wani
: * Export the new symbols Signed-off-by: Nehal J Wani nehaljw.k...@gmail.com --- include/libvirt/libvirt-domain.h | 27 src/driver-hypervisor.h |5 ++ src/libvirt-domain.c | 129 ++ src/libvirt_public.syms |2 + 4

[libvirt] [PATCHv7 2/4] domifaddr: Implement the remote protocol

2014-12-16 Thread Nehal J Wani
per interface were removed after kernel v2.0, and theoretically, at present, there are no upper limits on number of interfaces per virtual machine and on the number of IP addresses per interface. src/remote_protocol-structs * New structs added Signed-off-by: Nehal J Wani

[libvirt] [PATCHv7 3/4] domifaddr: Implement the API for qemu

2014-12-16 Thread Nehal J Wani
new test: testQemuAgentGetInterfaces Test cases for IP aliases, 0 or multiple ipv4/ipv6 address(es) Signed-off-by: Nehal J Wani nehaljw.k...@gmail.com --- src/qemu/qemu_agent.c | 202 src/qemu/qemu_agent.h |4 + src/qemu/qemu_driver.c

[libvirt] [PATCHv7 4/4] domifaddr: Add virsh support

2014-12-16 Thread Nehal J Wani
:f101::2/64 eth0 52:54:00:2e:45:ceipv6 fe80::5054:ff:fe2e:45ce/64 tools/virsh.pod * Document new command Signed-off-by: Nehal J Wani nehaljw.k...@gmail.com --- tools/virsh-domain-monitor.c | 141 ++ tools/virsh.pod

Re: [libvirt] [PATCHv7 3/4] domifaddr: Implement the API for qemu

2014-12-17 Thread Nehal J Wani
On Wed, Dec 17, 2014 at 11:56 AM, Wang Rui moon.wang...@huawei.com wrote: On 2014/12/17 8:16, Nehal J Wani wrote: By querying the qemu guest agent with the QMP command guest-network-get-interfaces and converting the received JSON output to structured objects. Although ifconfig is deprecated

[libvirt] [PATCH v8 0/4] Introduce API to query IP addresses for given domain

2015-01-25 Thread Nehal J Wani
.html v1: * http://www.redhat.com/archives/libvir-list/2013-July/msg01553.html Nehal J Wani (4): domifaddr: Implement the public APIs domifaddr: Implement the remote protocol domifaddr: Implement the API for qemu domifaddr: Add virsh support daemon/remote.c | 134

[libvirt] [PATCH v8 2/4] domifaddr: Implement the remote protocol

2015-01-25 Thread Nehal J Wani
per interface were removed after kernel v2.0, and theoretically, at present, there are no upper limits on number of interfaces per virtual machine and on the number of IP addresses per interface. src/remote_protocol-structs * New structs added Signed-off-by: Nehal J Wani

[libvirt] [PATCH v8 3/4] domifaddr: Implement the API for qemu

2015-01-25 Thread Nehal J Wani
new test: testQemuAgentGetInterfaces Test cases for IP aliases, 0 or multiple ipv4/ipv6 address(es) Signed-off-by: Nehal J Wani nehaljw.k...@gmail.com --- src/qemu/qemu_agent.c | 202 + src/qemu/qemu_agent.h | 4 + src/qemu/qemu_driver.c

[libvirt] [PATCH v8 4/4] domifaddr: Add virsh support

2015-01-25 Thread Nehal J Wani
:f101::2/64 eth0 52:54:00:2e:45:ceipv6 fe80::5054:ff:fe2e:45ce/64 tools/virsh.pod * Document new command Signed-off-by: Nehal J Wani nehaljw.k...@gmail.com --- tools/virsh-domain-monitor.c | 141 +++ tools/virsh.pod

[libvirt] [PATCH v8 1/4] domifaddr: Implement the public APIs

2015-01-25 Thread Nehal J Wani
: * Export the new symbols Signed-off-by: Nehal J Wani nehaljw.k...@gmail.com --- include/libvirt/libvirt-domain.h | 27 src/driver-hypervisor.h | 5 ++ src/libvirt-domain.c | 129 +++ src/libvirt_public.syms | 6 ++ 4 files

[libvirt] Query: Implementation of virNetworkGetDHCPLeases

2015-01-05 Thread Nehal J Wani
to get leases info for default error: internal error: no lease with matching MAC address: 00:50:56:c0:00:01 -- Nehal J Wani -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCHv7 3/4] domifaddr: Implement the API for qemu

2015-01-05 Thread Nehal J Wani
new test: testQemuAgentGetInterfaces Test cases for IP aliases, 0 or multiple ipv4/ipv6 address(es) Signed-off-by: Nehal J Wani nehaljw.k...@gmail.com --- These are very minor changes, and rest of the patches in the series haven't been reviewed yet. Hence sending fix in the same version

Re: [libvirt] [PATCHv7 0/4] Introduce API to query IP addresses for given domain

2015-01-13 Thread Nehal J Wani
On Wed, Dec 17, 2014 at 5:46 AM, Nehal J Wani nehaljw.k...@gmail.com wrote: This feature has been requested for a very long time. Since qemu guest agent gives us reliable results, now the wait is over. The RFC was first proposed by Michal Privoznik: http://www.redhat.com/archives/libvir

Re: [libvirt] [PATCH v8 0/4] Introduce API to query IP addresses for given domain

2015-02-09 Thread Nehal J Wani
On Mon, Jan 26, 2015 at 12:08 AM, Nehal J Wani nehaljw.k...@gmail.com wrote: This feature has been requested for a very long time. Since qemu guest agent and leaseshelper give us reliable results, now the wait is over. The RFC was first proposed by Michal Privoznik: http://www.redhat.com

[libvirt] [PATCH] networkGetDHCPLeases: Remove unnecessary error reporting

2015-01-05 Thread Nehal J Wani
Lack of a lease (whether mac is given or not) is a normal expected scenario. There is no need to raise an error. Signed-off-by: Nehal J Wani nehaljw.k...@gmail.com --- src/network/bridge_driver.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network

[libvirt] [PATCH] Add vircgroupdata dir to tests/Makefile.am

2015-03-18 Thread Nehal J Wani
The folder vircgroupdata was introduced in commit 2dbfa716 as part of the test suite for virCgroupDetectMounts --- tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/Makefile.am b/tests/Makefile.am index 9277c13..27cee63 100644 --- a/tests/Makefile.am +++

Re: [libvirt] [PATCH python v10] Expose virDomainInterfacesAddresses to python binding

2015-03-17 Thread Nehal J Wani
On Mon, Mar 16, 2015 at 8:25 PM, Daniel P. Berrange berra...@redhat.com wrote: From: Nehal J Wani nehaljw.k...@gmail.com examples/Makefile.am: * Add new file domipaddrs.py examples/README: * Add documentation for the python example libvirt-override-api.xml: * Add new symbol

Re: [libvirt] [PATCH v10 0/4] Introduce API to query IP addresses for given domain

2015-03-17 Thread Nehal J Wani
-list/2012-June/msg00904.html), resumed in July 2013 (http://www.redhat.com/archives/libvir-list/2013-July/msg01553.html) and was granted entry in March 2015 :) Quite a long journey! -- Nehal J Wani -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH python v10] Expose virDomainInterfacesAddresses to python binding

2015-03-17 Thread Nehal J Wani
On Wed, Mar 18, 2015 at 2:50 AM, Nehal J Wani nehaljw.k...@gmail.com wrote: On Mon, Mar 16, 2015 at 8:25 PM, Daniel P. Berrange berra...@redhat.com wrote: From: Nehal J Wani nehaljw.k...@gmail.com examples/Makefile.am: * Add new file domipaddrs.py examples/README: * Add documentation

Re: [libvirt] [RFC] Add uptime to API returning Dom Info

2015-03-30 Thread Nehal J Wani
On Mon, Mar 30, 2015 at 1:16 PM, Peter Krempa pkre...@redhat.com wrote: On Mon, Mar 30, 2015 at 03:29:40 +0530, Nehal J Wani wrote: This is an attempt to fix: https://bugzilla.redhat.com/show_bug.cgi?id=812911 Calculate vm uptime by subtracting process starttime from system uptime: Almost

[libvirt] [RFC] Add uptime to API returning Dom Info

2015-03-29 Thread Nehal J Wani
This is an attempt to fix: https://bugzilla.redhat.com/show_bug.cgi?id=812911 Calculate vm uptime by subtracting process starttime from system uptime: Almost equivalent to: echo $(($(($(awk '{print $1}' /proc/uptime)*1e9 - $(($(cut -d -f22 /proc/$PID/stat)*1e7/(1.0 * 1e9))) ---

[libvirt] Repo link for libvirt-cim throws 404

2015-04-28 Thread Nehal J Wani
The repository link for libvirt-cim at http://libvirt.org/CIM/downloads.html seems outdated. Shouldn't it be: git clone git://libvirt.org/libvirt-cim instead of hg clone http://libvirt.org/hg/libvirt-cim -- Nehal J Wani -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

2016-09-24 Thread Nehal J Wani
> libvirt previously allowed dnsmasq to handle the lease files, but apparently > they didn't have enough information for the APIs that report guest IP info, > so Nehal replaced dnsmasq's automatic leasefile handling with custom > handling that stores the extra data in addition to what dnsmasq needs. He > can provide more info if you need it. There was quite an amount of discussion on this dating back to 2013, involving IRC as well as mailing list. All the discussion on the mailing list is available at: https://www.mail-archive.com/search?l=libvir-list%40redhat.com=from%3A%22Nehal%22=1=oldest . If there are any specific queries, I am available on email/IRC. -- Nehal J Wani -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Don't drop expired lease while reading custom leases file

2016-09-30 Thread Nehal J Wani
On Fri, Sep 30, 2016 at 5:47 PM, Michal Privoznik <mpriv...@redhat.com> wrote: > On 28.09.2016 21:39, Nehal J Wani wrote: >> Libvirt, on its own, shouldn't decide whether an expired lease should >> stay in the custom leases database or not. It should rather rely on >> t

[libvirt] [PATCH] network: Add support for configuring dhcp lease time

2016-09-23 Thread Nehal J Wani
The default dhcp lease time set by dnsmasq is only one hour, which can be pretty small for developers relying on ip address(es) to be consistent across reboots. This patch adds support for setting a lease time in the network definition. For now, all IP ranges under one will share a common

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

2016-09-23 Thread Nehal J Wani
On Fri, Sep 23, 2016 at 1:20 PM, Peter Krempa <pkre...@redhat.com> wrote: > On Fri, Sep 23, 2016 at 12:19:49 +0530, Nehal J Wani wrote: >> The default dhcp lease time set by dnsmasq is only one hour, which can be >> pretty small for developers relying on ip address(es) to be

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

2016-09-23 Thread Nehal J Wani
On Fri, Sep 23, 2016 at 4:51 PM, Peter Krempa <pkre...@redhat.com> wrote: > On Fri, Sep 23, 2016 at 15:33:46 +0530, Nehal J Wani wrote: >> On Fri, Sep 23, 2016 at 1:20 PM, Peter Krempa <pkre...@redhat.com> wrote: >> > On Fri, Sep 23, 2016 at 12:19:49 +0530, Nehal J

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

2016-09-23 Thread Nehal J Wani
On Fri, Sep 23, 2016 at 9:26 PM, Laine Stump <la...@laine.org> wrote: > On 09/23/2016 08:24 AM, Nehal J Wani wrote: >> >> On Fri, Sep 23, 2016 at 4:51 PM, Peter Krempa <pkre...@redhat.com> wrote: >>> >>> On Fri, Sep 23, 2016 at 15:33:46 +0530, Nehal

[libvirt] [PATCH] Don't drop expired lease while reading custom leases file

2016-09-28 Thread Nehal J Wani
Libvirt, on its own, shouldn't decide whether an expired lease should stay in the custom leases database or not. It should rather rely on the 'DEL' event from dnsmasq. --- src/util/virlease.c | 8 1 file changed, 8 deletions(-) diff --git a/src/util/virlease.c b/src/util/virlease.c

[libvirt] [PATCH] NSS: Add explicit check to not report expired lease

2016-09-28 Thread Nehal J Wani
The NSS module shouldn't rely on custom leases database to not have entries for leases which have expired. --- tools/nss/libvirt_nss.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/tools/nss/libvirt_nss.c b/tools/nss/libvirt_nss.c index 54c4a2a..57ba473 100644 ---

Re: [libvirt] [PATCH v2 1/2] NSS: Add explicit check to not report expired lease

2016-10-03 Thread Nehal J Wani
On Mon, Oct 3, 2016 at 1:19 PM, Michal Privoznik <mpriv...@redhat.com> wrote: > On 30.09.2016 17:11, Nehal J Wani wrote: >> The NSS module shouldn't rely on custom leases database to not have >> entries for leases which have expired. >> >> Change-Id: Ic3e0430

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

2016-09-26 Thread Nehal J Wani
On Sun, Sep 25, 2016 at 12:58 AM, Laine Stump <la...@laine.org> wrote: > On 09/24/2016 10:51 AM, Nehal J Wani wrote: >> >> On Sat, Sep 24, 2016 at 3:01 AM, Laine Stump <la...@laine.org> wrote: >>> >>> On 09/23/2016 02:43 PM, Martin Wilck wrote: >&

[libvirt] [PATCH v2 2/2] Don't drop expired lease while reading custom leases file

2016-09-30 Thread Nehal J Wani
Libvirt, on its own, shouldn't decide whether an expired lease should stay in the custom leases database or not. It should rather rely on the 'DEL' event from dnsmasq. --- src/util/virlease.c | 8 1 file changed, 8 deletions(-) diff --git a/src/util/virlease.c b/src/util/virlease.c

[libvirt] [PATCH v2 1/2] NSS: Add explicit check to not report expired lease

2016-09-30 Thread Nehal J Wani
The NSS module shouldn't rely on custom leases database to not have entries for leases which have expired. Change-Id: Ic3e043003d33ded0da74696a1d27ed4967ddbfb8 --- tools/nss/libvirt_nss.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/tools/nss/libvirt_nss.c

[libvirt] [PATCH] Add support for parsing -vga virtio

2016-11-17 Thread Nehal J Wani
Since a94f0c5c qemu supports '-vga virtio'. Libvirt also supports it since 21373feb. This patch enables libvirt to parse the qemu-argv: virsh domxml-from-native qemu-argv <(echo '/usr/bin/qemu-system-x86_64 -vga virtio') Signed-off-by: Nehal J Wani <nehaljw.k...@gmail.com> ---

Re: [libvirt] [PATCH 0/5] qemu: parse: Fix parsing of weird cpu topology specifications

2016-11-17 Thread Nehal J Wani
-- > 2.10.2 > > -- > libvir-list mailing list > libvir-list@redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list ACK Series. Fixes everything mentioned in the thread: https://www.redhat.com/archives/libvir-list/2016-November/msg00627.html -- Nehal J Wani -- libvir-

[libvirt] Segfault in qemuDomainDefVcpusPostParse:2480

2016-11-13 Thread Nehal J Wani
), which returns NULL. I'd be happy to send a patch, but I am not sure what the right solution is. - Should not specifying n to -smp allowed? - Should -cpus=n also be parsed in qemuParseCommandLineSmp()? Cheers! Nehal J Wani -- libvir-list mailing list libvir-list@redhat.com https://www.re

Re: [libvirt] [PATCH] Add support for parsing -vga virtio

2016-12-05 Thread Nehal J Wani
On Fri, Nov 18, 2016 at 12:27 PM, Nehal J Wani <nehaljw.k...@gmail.com> wrote: > Since a94f0c5c qemu supports '-vga virtio'. > Libvirt also supports it since 21373feb. > > This patch enables libvirt to parse the qemu-argv: > > virsh domxml-from-native qemu-argv <(echo '

[libvirt] [PATCH] Fix location of blkid.h in include header

2017-03-03 Thread Nehal J Wani
, the compilation for libvirt succeeded because of pure luck, as it had -I/usr/include as a CFLAG. This issue was faced while compiling libvirt on Ubuntu 16.04.2 with bare minimum dev packages and a custom compiled blkid kept in a non-standard $prefix. Signed-off-by: Nehal J Wani <nehalj

<    1   2   3