[Libvir] Re: libvirt on mingw

2008-01-30 Thread Richard W.M. Jones
Brecht Sanders wrote: Hello again, Note that I am using gcc (mingw) 3.4.5, and not 4 as you recommend. The attached patch got rid of the warnings though. Maybe there is a compiler switch to fix it in a cleaner way though. Anyway, with the attached patch it does compile. Basically it casts to

Re: [Libvir] Libvirt on windows

2008-01-31 Thread Richard W.M. Jones
Gabriel Kaufmann wrote: Hi, How stable is this compiled DLL? I understand that this is from version 0.4.0, Do you have a 0.3 version that is not experimental (as you put it ...) By the way I'm using the DLL without problems if anyone needs the dynamic binding code, I can send it to him in

[Libvir] Re: libvirt on mingw

2008-01-31 Thread Richard W.M. Jones
Brecht Sanders wrote: I wasn't able to run virt-manager yet because of Python dependancy issues, but I'm sure I'll be able to work that out. Did you have virt-manager running on win32 yet? No, I wasn't able to get virt-manager running. Probably the same problems as you are having: building

Re: [Libvir] [PATCH] Pull vc-list-files from gnulib, and update.

2008-02-01 Thread Richard W.M. Jones
Jim Meyering wrote: Now that I've added the vc-list-files script to gnulib, this patch makes libvirt's bootstrap pull it from there. Changes from the previous version of the script: I reintroduced support for mercurial (only lightly tested), and rearranged the directory-existence tests so

Re: [Libvir] removing trailing blanks (and keeping them away)

2008-02-04 Thread Richard W.M. Jones
Jim Meyering wrote: Any objection to a mass removal of trailing blanks? [ If you haven't yet been adversely affected by e.g., pointless conflicts due solely to differences in white space, count yourself lucky, and chalk it up to not having to deal with many branches. The sooner we do this

Re: [Libvir] PATCH: Allow Xen HVM kernel+initrd booting

2008-02-04 Thread Richard W.M. Jones
Daniel P. Berrange wrote: [...] Looks good, but needs to update the documentation too. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in

Re: [Libvir] mark more translatable messages

2008-02-04 Thread Richard W.M. Jones
Jim Meyering wrote: This change marks for translation some more messages. It adds a few new ones, too, e.g., replacing domain with _(failed to parse domain description) in two places. Likewise, there are some like this: -virXendError (conn, VIR_ERR_NO_MEMORY, strdup); +

Re: [Libvir] mark some diagnostics for translation

2008-02-04 Thread Richard W.M. Jones
Jim Meyering wrote: -error (flags REMOTE_CALL_IN_OPEN ? NULL : conn, VIR_ERR_RPC, xdr_int (length word)); +error (flags REMOTE_CALL_IN_OPEN ? NULL : conn, VIR_ERR_RPC, _(xdr_int (length word))); +1 to the patch, but I wonder what translators will make of errors like the

Re: [Libvir] don't use virBufferAdd with string literals

2008-02-05 Thread Richard W.M. Jones
Jim Meyering wrote: I noticed a little glitch here: src/xml.c: virBufferAdd(buf, (usbdevice tablet), 13); src/xml.c: virBufferAdd(buf, (usbdevice tablet), 18); Ouch, that's a how did that ever work. I see from that patch that you know about passing -1 as the length, in which

[Libvir] Re: libvirt adding new methods to the xenUnifiedDriver

2008-02-05 Thread Richard W.M. Jones
Roman Divacky wrote: hi I am messing with libvirt and I need to add some methods to the xenUnifiedDriver structure. I do it this way: (currently #ifdef-ed out) struct xenUnifiedDriver { virDrvOpen open; virDrvClose close;

[Libvir] Re: libvirt on mingw

2008-02-06 Thread Richard W.M. Jones
Brecht Sanders wrote: Hello again, Note that I am using gcc (mingw) 3.4.5, and not 4 as you recommend. The attached patch got rid of the warnings though. Maybe there is a compiler switch to fix it in a cleaner way though. Anyway, with the attached patch it does compile. Basically it casts to

Re: [Libvir] Re: libvirt on mingw

2008-02-06 Thread Richard W.M. Jones
Richard W.M. Jones wrote: Brecht Sanders wrote: Hello again, Note that I am using gcc (mingw) 3.4.5, and not 4 as you recommend. The attached patch got rid of the warnings though. Maybe there is a compiler switch to fix it in a cleaner way though. Anyway, with the attached patch it does compile

[Libvir] Re: libvirt for Python on Windows

2008-02-06 Thread Richard W.M. Jones
Brecht Sanders wrote: Hi Richard, I have finally compiled a libvirt Python module. Attached are the files that need to go into python 2.4 homelib/site-packages, in case you want to try this. How did you build _libvirtmod though? Rich. -- Emerging Technologies, Red Hat -

Re: [Libvir] [PATCH] change a Disk/Nic of inactive domain

2008-02-06 Thread Richard W.M. Jones
Daniel Veillard wrote: On Tue, Feb 05, 2008 at 04:00:14PM -0800, Ryan Scott wrote: Resurrecting a two-week old thread... Was a version of this patch ever committed? I don't see it, but I may have missed it. I used an earlier version of the patch to fix a problem we've noticed, but I would

Re: [Libvir] PATCH: 1/16: public API

2008-02-20 Thread Richard W.M. Jones
On Wed, Feb 20, 2008 at 04:39:31PM +, Daniel P. Berrange wrote: On Wed, Feb 20, 2008 at 04:10:30PM +, Daniel P. Berrange wrote: On Wed, Feb 20, 2008 at 02:52:54AM -0500, Daniel Veillard wrote: So let's push this ! All committed. Now to find out what I broke :-) It passes an

Re: [Libvir] [RFC] 1/3 Base linux container support

2008-02-21 Thread Richard W.M. Jones
This patch all looks sensible. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No.

Re: [Libvir] [RFC] 2/3 Config functions for managing linux containers

2008-02-21 Thread Richard W.M. Jones
The code looks sensible, and its self-contained so +1. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company

Re: [Libvir] [RFC] 3/3 Driver functions for linux container support

2008-02-21 Thread Richard W.M. Jones
Looks good. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903 -- Libvir-list

Re: [Libvir] default hypervisor selection

2008-02-21 Thread Richard W.M. Jones
I'm mostly with Dan Berrange here. Surely an environment variable is the right thing to do, and then later we can add some advanced probing if the environment variable alone doesn't satisfy users. The only problem I see is making the NULL case unpredictable or introducing unreproducible bugs.

Re: [libvir] [PATCH] Double free in openvzGetVPSInfo

2008-02-21 Thread Richard W.M. Jones
On Thu, Feb 21, 2008 at 06:07:48PM +0300, Anton Protopopov wrote: Hi, without this openvzGetVPSInfo() will cause double free when parse bad (i.e., really bad or empty) output from vzlist. Patch applied, thanks. Can you send patches as attachments next time please. That one had the spaces

[Libvir] [Discussion] 0/4 Implement DHCP host mappings for virtual networks

2008-02-21 Thread Richard W.M. Jones
This is a series of patches to implement DHCP IP hostname mappings for libvirt virtual networks. ** NOTE: This patch is not to be applied. There is some memory corruption bug which I'm still tracking down. What this patch allows you to do is to create a table of IP address to host

[Libvir] 2/4 QEMU driver

2008-02-21 Thread Richard W.M. Jones
This patch implements the QEMU driver part of the change. We run dnsmasq with the extra --dhcp-hostsfile=... parameter, and then include functions to read and write this file. When the file changes we send SIGHUP to dnsmasq. Rich. -- Emerging Technologies, Red Hat -

[Libvir] 3/4 Remote driver

2008-02-21 Thread Richard W.M. Jones
This implements the changes in the client server ends of the remote driver. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England

[Libvir] 4/4 virsh

2008-02-21 Thread Richard W.M. Jones
This adds four new subcommands to virsh allowing you to control the new functionality. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in

[Libvir] 1/4 Additions to the public API

2008-02-21 Thread Richard W.M. Jones
This just adds the four new functions to the public API. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under

Re: [Libvir] 1/4 Additions to the public API

2008-02-22 Thread Richard W.M. Jones
[... Struct versus 3 arrays discussion snipped ...] I think both representations have their merits, and DV's 3 arrays approach is much easier to marshal through the remote code, and simpler to produce OCaml bindings for (no idea about Python). The reason for using the struct was to provide

Re: [Libvir] [Discussion] 0/4 Implement DHCP host mappings for virtual networks

2008-02-22 Thread Richard W.M. Jones
On Fri, Feb 22, 2008 at 08:04:26AM +, Mark McLoughlin wrote: On Thu, 2008-02-21 at 20:54 +, Richard W.M. Jones wrote: What this patch allows you to do is to create a table of IP address to host (defined by its hardware / MAC address) for each virtual network. Optionally you can also

Re: [Libvir] Why QEMU?

2008-02-22 Thread Richard W.M. Jones
On Fri, Feb 22, 2008 at 01:47:44PM +0300, Anton Protopopov wrote: When I executing virsh to connect to openvz I get the following: [EMAIL PROTECTED] ~]# virsh -c openvz:///system libvir: QEMU error : cannot create bridge 'virbr0' : File exists Failed to autostart network 'default': cannot

Re: [Libvir] avoid new warnings

2008-02-22 Thread Richard W.M. Jones
+1 -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903 -- Libvir-list mailing list

Re: [Libvir] 1/4 Additions to the public API

2008-02-22 Thread Richard W.M. Jones
On Fri, Feb 22, 2008 at 10:47:44AM +, Mark McLoughlin wrote: On Fri, 2008-02-22 at 05:16 -0500, Daniel Veillard wrote: I also agree to some extend with Mark, the on disk storage should probably go in the network description. But that's orthogonal to the API side :) Heh, no

Re: [Libvir] tons of format string warnings on rawhide

2008-02-22 Thread Richard W.M. Jones
On Fri, Feb 22, 2008 at 03:38:25PM +0100, Jim Meyering wrote: Avoid warnings like this: file:nnn:format not a string literal and no format arguments +1. Strangely I compiled libvirt on Rawhide only yesterday with no problems. Maybe something to do with the new gcc 4.3 upgrade ...? Rich.

Re: [Libvir] [PATCH] 1/2: Move safewrite and saferead to a separate file.

2008-02-22 Thread Richard W.M. Jones
Should we consider moving the buf.[ch] functions into this mini-util library too? +1 Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in

Re: [Libvir] [PATCH] 2/2: Use safewrite in place of write, in many cases.

2008-02-22 Thread Richard W.M. Jones
All good stuff. PCLSRing++ Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

Re: [Libvir] Why QEMU?

2008-02-22 Thread Richard W.M. Jones
On Fri, Feb 22, 2008 at 07:30:23PM +0300, Mikhail A. Pokidko wrote: offtopic As i`ve almost sawed enough libvirtd to pack for ALTLinux, should i send you ALT-specific init-script and|or specs? /offtopic It'd certainly be interesting to see them, but normally we leave it up to the distributors

Re: [Libvir] 1/4 Additions to the public API

2008-02-25 Thread Richard W.M. Jones
On Sun, Feb 24, 2008 at 10:20:24PM +, Daniel P. Berrange wrote: We can't change the semantics of these calls. virNetworkDefineXML() explicitly does not affect the current live config, saving the config to take effect next time the network is started. This is the same semantics as the

Re: [Libvir] Error - when compiling sample libvirt program - Failed to find libvirt proxy

2008-02-25 Thread Richard W.M. Jones
On Sun, Feb 24, 2008 at 01:55:29PM +0530, Sunil Lingappa wrote: While i am able to compile it with success, when i run it i get the following error : * failed to find libvirt_proxy * But the output is still displayed. That old version of libvirt is trying to find libvirt_proxy (an old

[Libvir] [PATCH] (for discussion) DHCP host mappings using 3 arrays API

2008-02-25 Thread Richard W.M. Jones
This patch is an evolution of the previous patch for implementing DHCP host mappings. The virNetworkListDHCPHostMappings calls has been changed to take three arrays of strings: int virNetworkListDHCPHostMappings (virNetworkPtr network, char **const hwaddrs,

Re: [Libvir] [PATCH] (for discussion) DHCP host mappings using 3 arrays API

2008-02-25 Thread Richard W.M. Jones
On Mon, Feb 25, 2008 at 04:49:00PM +, Richard W.M. Jones wrote: [...] Thanks to Jim for pointing me in the right direction here. If you try this patch you'll need to insert memset() calls at the two places indicated below. That fixes all the problems I can see and it appears to all work

Re: [Libvir] [PATCH]Change MAC address to case insensitive

2008-02-26 Thread Richard W.M. Jones
I'll apply this today (using our STRCASEEQ macros) if no one else objects. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen

Re: [Libvir] [PATCH 1/2] Add internal API for managing capabilities data

2008-02-26 Thread Richard W.M. Jones
Yes, this all looks good. Another advantage of doing this is that we can be sure that the capabilities XML generated by each driver will have the same schema. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual

Re: [Libvir] [PATCH 2/2] Refactor drivers to use capabilities API

2008-02-26 Thread Richard W.M. Jones
On Tue, Feb 26, 2008 at 05:13:51AM +, Daniel P. Berrange wrote: This patch refactors the Xen, QEMU and Test drivers to use the new API for dealing with capabilities data. Yes, +1 to this patch as well. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones

Re: [Libvir] [PATCH]check NULL of mac

2008-02-26 Thread Richard W.M. Jones
+1. I'll apply this today if no one else objects. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc.

[Libvir] How to stop 'make install' clobbering /etc/libvirt/libvirtd.conf

2008-02-26 Thread Richard W.M. Jones
Currently 'make install' clobbers configuration files, in particular /etc/libvirt/libvirtd.conf. It shouldn't. Does anyone know how to persuade automake to stop it from doing this? As far as I can see the only way would be to write a custom install rule. Rich. -- Richard Jones, Emerging

[Libvir] [PATCH] Implement virDomainBlockStats for QEMU/KVM

2008-02-26 Thread Richard W.M. Jones
This little patch just implements the virDomainBlockStats call for qemu kvm. It does this by using the new 'info blockstats' monitor command which I added to qemu KVM upstream some months back, and (hopefully) it does the right thing if this command is not available. Rich. -- Richard Jones,

Re: [Libvir] [PATCH] (for discussion) DHCP host mappings using 3 arrays API

2008-02-26 Thread Richard W.M. Jones
On Tue, Feb 26, 2008 at 11:43:59AM +0100, Jim Meyering wrote: Richard W.M. Jones [EMAIL PROTECTED] wrote: This patch is an evolution of the previous patch for implementing DHCP ... +if (maxmappings == 0) return 0; ... +if (col == 0) hwaddr = token

Re: [Libvir] [PATCH]Change MAC address to case insensitive

2008-02-26 Thread Richard W.M. Jones
On Tue, Feb 26, 2008 at 12:54:15PM +, Daniel P. Berrange wrote: On Tue, Feb 26, 2008 at 12:13:43PM +0100, Jim Meyering wrote: Richard W.M. Jones [EMAIL PROTECTED] wrote: I'll apply this today (using our STRCASEEQ macros) if no one else objects. Hi, What do you think about

Re: [Libvir] [PATCH]check NULL of mac

2008-02-26 Thread Richard W.M. Jones
Committed. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v -- Libvir-list

Re: [Libvir] [PATCH] Implement virDomainBlockStats for QEMU/KVM

2008-02-26 Thread Richard W.M. Jones
Thanks everyone. I've committed that with the suggested changes. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc.

Re: [Libvir] [PATCH]Change MAC address to case insensitive

2008-02-27 Thread Richard W.M. Jones
On Wed, Feb 27, 2008 at 02:27:30PM +0900, S.Sakamoto wrote: OK, try this patch. I tried this patch. It works fine to me. Yes, the patch works for me too. I'll commit this end of today unless anyone objects. Rich. -- Richard Jones, Emerging Technologies, Red Hat

Re: [Libvir] [PATCH] (for discussion) DHCP host mappings using 3 arrays API

2008-02-27 Thread Richard W.M. Jones
Here's the final version of the 3 arrays version of the patch, with the memory corruptor fixed. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn

Re: [Libvir] [PATCH]Change MAC address to case insensitive

2008-02-27 Thread Richard W.M. Jones
This patch has been committed now. Thanks for your contribution to libvirt. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen

Re: [Libvir] [PATCH] (for discussion) DHCP host mappings using 3 arrays API

2008-02-27 Thread Richard W.M. Jones
On Wed, Feb 27, 2008 at 05:27:33PM +0100, Jim Meyering wrote: Whoops. You'll want to close that file descriptor. E.g., put this right before argv = NULL;: if (close (ret)) return -1; It'd be nice to declare a new variable, say fd, for that bit. Oh yes, that would be a good

Re: [Libvir] [PATCH] make qemud/'s rpcgen rules work

2008-02-27 Thread Richard W.M. Jones
On Wed, Feb 27, 2008 at 07:26:15PM +0100, Jim Meyering wrote: I applied Rich's patch and found that qemud/remote_protocol.c was not automatically rebuilt. Since the Makefile rule is an implicit one using a non-default suffix (.x), you have to tell make about the new suffix. In straight make,

Re: [Libvir] [Q] gnulib comment

2008-02-28 Thread Richard W.M. Jones
On Thu, Feb 28, 2008 at 03:54:00PM +0900, Atsushi SAKAI wrote: Hi, Jim I have two questions on gnulib in libvirt. 1)tupe is typo?(I attach a patch.) (I do not guess the correct words, it is jargon?) That's a typo, I'll apply the patch. 2)many NUL appeared on comment. Is the normal

Re: [Libvir] [PATCH] Fix Xen-3.2 hypercalls

2008-02-28 Thread Richard W.M. Jones
On Thu, Feb 28, 2008 at 06:22:35AM -0500, Daniel Veillard wrote: While testing against Xen-3.2 I found out that the Xen hypercalls failed, this patches fixes it by checking the newer sysctl versions when initializing the driver. I also merged the associated debugging with the DEBUG from

[Libvir] Re: ignore leading zeros, too [Change MAC address to case insensitive

2008-02-29 Thread Richard W.M. Jones
On Fri, Feb 29, 2008 at 12:59:39PM +0100, Jim Meyering wrote: diff --git a/src/util.c b/src/util.c index 4d61540..edaa5aa 100644 --- a/src/util.c +++ b/src/util.c @@ -35,6 +35,7 @@ #include sys/stat.h #include sys/wait.h #include string.h +#include ctype.h I thought we're not supposed

[Libvir] Re: ignore leading zeros, too [Change MAC address to case insensitive

2008-02-29 Thread Richard W.M. Jones
On Fri, Feb 29, 2008 at 01:33:42PM +0100, Jim Meyering wrote: Richard W.M. Jones [EMAIL PROTECTED] wrote: I thought we're not supposed to be using ctype? As far as i know, #include ctype.h is still the only way to use the things it specifies (tolower, isupper, isxdigit, etc.) Maybe

Re: [Libvir] [PATCH] fix typos (part3)

2008-02-29 Thread Richard W.M. Jones
On Fri, Feb 29, 2008 at 07:06:08PM +0900, Atsushi SAKAI wrote: Hi, I guess this is the last one for libvirt. docs/errors.html |6 +++--- docs/format.html | 14 +++--- docs/index.html |2 +- docs/news.html|2 +-

Re: [Libvir] many more translatable strings need to be marked

2008-02-29 Thread Richard W.M. Jones
On Fri, Feb 29, 2008 at 10:02:35AM -0500, Daniel Veillard wrote: While I undertand the point maybe it's pushed a bit too much, or not enough if (args-maxnames REMOTE_DOMAIN_NAME_LIST_MAX) { remoteDispatchError (client, req, - maxnames

Support for other platforms (was: Re: [Libvir] OS X Compile Issue)

2008-03-03 Thread Richard W.M. Jones
On Mon, Mar 03, 2008 at 04:02:49PM -0500, Pat Wendorf wrote: endian.h does exist on OS X, but under a bits directory, but byteswap.h and mntent.h don't exist at all on the default X-Code install. Any ideas? Yes ... Basic problem is that we develop extensions to libvirt and only ever test them

Re: [Libvir] virsh list

2008-03-03 Thread Richard W.M. Jones
On Mon, Mar 03, 2008 at 09:09:49PM +, John Levon wrote: Am I the only one who finds the default behaviour of virsh list really confusing and annoying? That is, I would like --all to be the default. Me too, but can we change it without breaking scripts or similar? Rich. -- Richard

Re: [Libvir] Need more information on virDomainBlockStats, virDomainInterfaceStats and virNodeGetCellsFreeMemory

2008-03-03 Thread Richard W.M. Jones
On Mon, Mar 03, 2008 at 11:31:10AM +0530, Ajishrao.r wrote: Hi, I am trying to use libvirt, any one please help more about virDomainBlockStats, virDomainInterfaceStats and virNodeGetCellsFreeMemory any pointer or docs? Is there anything in particular you want to know? If you want to

Re: [Libvir] Any API available for renaming the guest OS

2008-03-03 Thread Richard W.M. Jones
On Mon, Mar 03, 2008 at 12:14:33PM +0530, Ajishrao.r wrote: I couldn't direct API to rename Guest OS? We don't have an API to do this. I'm not even sure that virt technologies generally support this. It seems Xen doesn't. Rich. -- Richard Jones, Emerging Technologies, Red Hat

Re: [Libvir] API Question...

2008-03-03 Thread Richard W.M. Jones
On Mon, Mar 03, 2008 at 02:52:05PM -0700, Spencer Parker wrote: Okay...so I am still trying to get what this says I can get. But I want to do it with Python. I am looking at this: virDomainInterfaceStatsStruct and wondering if I can grab this info with Python or not. I looked at the

Re: [Libvir] a couple of questions -Newbie

2008-03-03 Thread Richard W.M. Jones
On Mon, Mar 03, 2008 at 11:14:05AM -0700, Spencer Parker wrote: I am really excited to start using this, but I have a couple of questions about how to use it exactly. I want to be able to pull a list of stats out of my Xen machines. I need to get something like network i/o. I just need

Re: [Libvir] a couple of questions -Newbie

2008-03-03 Thread Richard W.M. Jones
On Mon, Mar 03, 2008 at 03:38:46PM -0700, Spencer Parker wrote: I actually just saw this and started playing around with it. Should actually do what I need to do for that part. The next thing I need to monitor is disk usage. Disk usage is tricky to monitor from the hypervisor. Have a look

Re: [Libvir] Any API available for renaming the guest OS

2008-03-04 Thread Richard W.M. Jones
On Tue, Mar 04, 2008 at 11:43:10AM +0530, Ajishrao.r wrote: xm has rename option, without reboot. Right, but not in the manpage. Is theirs any specific reason why we don't have rename API? Not particularly, just waiting for a patch. The QEMU driver looks like it could be easily modified to

Re: [Libvir] [PATCH] add error message for the case of the vcpupin command fails.

2008-03-04 Thread Richard W.M. Jones
On Tue, Mar 04, 2008 at 06:30:46PM +0900, S.Sakamoto wrote: Hi, I try follow, # virsh vcpupin guest_dom AAA 0,1 [no error messages] # echo $? 1 There is no processing to output an error-message, when vshCommandOptInt become an error. I make the patch to solve this

Re: [Libvir] [PATCH] add error message for the case of the vcpupin command fails.

2008-03-04 Thread Richard W.M. Jones
OK, I'm going to qualify that a bit. Is it always safe to access arg-data? I think probably it is, but I'm not sure so I modified the patch slightly just to print an error message like this: $ src/virsh -c test:///default vcpupin test AAA 0,1 error: vcpupin: Invalid or missing vCPU number.

Re: [Libvir] a couple of questions -Newbie

2008-03-04 Thread Richard W.M. Jones
On Mon, Mar 03, 2008 at 10:48:01PM +, Richard W.M. Jones wrote: On Mon, Mar 03, 2008 at 03:38:46PM -0700, Spencer Parker wrote: I actually just saw this and started playing around with it. Should actually do what I need to do for that part. The next thing I need to monitor is disk

Re: [Libvir] a couple of questions -Newbie

2008-03-04 Thread Richard W.M. Jones
On Tue, Mar 04, 2008 at 09:01:22AM -0700, Spencer Parker wrote: Now when I run virt-top with the script option it just hangs...how long till it dies? Or is there a way to daemonize it? Which version of virt-top is this? Script mode is designed to run forever. If used in conjunction with

Re: [Libvir] [PATCH]: Make iSCSI login actually work

2008-03-04 Thread Richard W.M. Jones
On Tue, Mar 04, 2008 at 02:16:25PM -0500, Chris Lalancette wrote: Chris Lalancette wrote: Hello, I mentioned this before, but this patch must have been dropped when Dan committed storage stuff to CVS. In order for iSCSI login to work properly, you must properly --sendtargets

Re: [Libvir] [PATCH] add error message for the case of the vcpupin command fails.

2008-03-04 Thread Richard W.M. Jones
On Tue, Mar 04, 2008 at 11:03:25AM +, Richard W.M. Jones wrote: OK, I'm going to qualify that a bit. Is it always safe to access arg-data? I think probably it is, but I'm not sure so I modified the patch slightly just to print an error message like this: $ src/virsh -c test:///default

Re: [Libvir] Updating to the newest libvirt

2008-03-07 Thread Richard W.M. Jones
On Thu, Mar 06, 2008 at 09:53:45AM -0700, Spencer Parker wrote: I am running CentOS 5 on a 64 bit system and when I try to install via Yum...the newest version I can get is 0.2.3-9.el5. When I try to install with RPM's it just throws up conflicts. is there a newer version of libvirt that

Re: [Libvir] Trouble getting console

2008-03-07 Thread Richard W.M. Jones
On Thu, Mar 06, 2008 at 02:23:40PM -0700, Spencer Parker wrote: I have setup a virtual machine, but am not able to connect to the console for it. I type in virsh console name and it give me a new line with no output...I hit enter a few time to see it kicks in, but nothing. here is my xml

Re: [Libvir] [PATCH] Another Report error in virsh.c code.

2008-03-07 Thread Richard W.M. Jones
On Fri, Mar 07, 2008 at 04:43:37PM +0900, S.Sakamoto wrote: Hi, I am watching through the virsh code for same type bug check. http://git.et.redhat.com/?p=libvirt.git;a=commit;h=c857ace66df5a5068ed561aad913b29fd36160f9 And I found another point it should report error. Thanks, Shigeki

Re: [Libvir] PATCH: Allow Xen HVM kernel+initrd booting

2008-03-10 Thread Richard W.M. Jones
On Sun, Mar 09, 2008 at 09:11:49PM +, Daniel P. Berrange wrote: The problem is that the Xen driver expects the OS type to be 'linux' but the capabilities XML is advertising the OS type as 'xen'. Technically 'xen' is the correct value, since its refering to a guest ABI the ABI is xen, not

Re: [Libvir] virsh start problem + patch

2008-03-10 Thread Richard W.M. Jones
On Sat, Mar 08, 2008 at 09:47:43AM +0100, Toth Istvan wrote: I've looked into the virsh code, and it seems that it was written with only only old-style xen in mind, and xen 3.1's managed domains break the logic. I don't understand this statement. The current 'cmdStart' code checks if the

Re: [Libvir] Need Help on Error handling.

2008-03-10 Thread Richard W.M. Jones
On Sun, Mar 09, 2008 at 10:52:33PM +0530, Ajishrao.r wrote: Hi, I am using libvirt to manage, The Hypervisor, Can Any one Help me about handling error? My main questions are. --- What is Library level Error Handling? --- Any Example to use void virSetErrorFunc

Re: [Libvir] PATCH: Fix libvirtd to not shutdown at startup

2008-03-10 Thread Richard W.M. Jones
On Sun, Mar 09, 2008 at 08:59:24PM +, Daniel P. Berrange wrote: Changes to the daemon to make it called qemudShutdown() broke the network driver when run in --daemon mode. This is because the main daemon forks into the background, and the original PID then exits destroying any active

Re: [Libvir] PATCH: Remove use of polkit-grant

2008-03-10 Thread Richard W.M. Jones
On Sun, Mar 09, 2008 at 09:02:36PM +, Daniel P. Berrange wrote: Index: src/libvirt.c === RCS file: /data/cvs/libvirt/src/libvirt.c,v retrieving revision 1.125 diff -u -p -r1.125 libvirt.c --- src/libvirt.c 26 Feb 2008

Re: [Libvir] Not able to access the network.

2008-03-10 Thread Richard W.M. Jones
On Fri, Mar 07, 2008 at 03:56:45PM -0700, Spencer Parker wrote: I have set up a machine using virsh, but I can't access it over the network. It has valid IP and everything like that. It is all running over eth1 and not eth0. Any idea as to why I can't get network access on it? I have

Re: [Libvir] virsh start problem + patch

2008-03-11 Thread Richard W.M. Jones
OK, I think that's a good explanation but I'll leave it to Dan to comment 'coz he wrote the code ... Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and

Re: [Libvir] [PATCH] Another Report error in virsh.c code.

2008-03-11 Thread Richard W.M. Jones
On Tue, Mar 11, 2008 at 05:09:45PM +0900, S.Sakamoto wrote: BTW, I think another message is needed here to inform the internal error to user. For example, the migrate command shows the following message when desturi is missing: migrate: Missing desturi But it does not show the

Re: [Libvir] [PATCH] Another Report error in virsh.c code.

2008-03-11 Thread Richard W.M. Jones
On Tue, Mar 11, 2008 at 07:19:57PM +0900, S.Sakamoto wrote: I wish it is unified as follows. ***migrate*** 2225desturi = vshCommandOptString (cmd, desturi, found); 2226if (!found) { 2227vshError (ctl, FALSE, %s, _(migrate: Missing desturi)); 2228goto done; 2229

Re: [Libvir] Snapshots for Xen and KVM

2008-03-11 Thread Richard W.M. Jones
On Tue, Mar 11, 2008 at 12:54:37PM +0200, Gabriel Kaufmann wrote: Does anyone knows if Xen and KVM support snapshots (regardless if Libvirt provides the API for them). It's currently on the Xen to-do list, but apart from some research papers I'm not aware of them implementing it. Perhaps

Re: [Libvir] Accessing qemu from windows

2008-03-11 Thread Richard W.M. Jones
On Tue, Mar 11, 2008 at 01:00:23PM +0200, Gabriel Kaufmann wrote: I'm running virsh from linux machine with the URI qemu+tcp://user:password@ip/system From a linux machine (not the same that runs the libvirtd deamon) with libvirt 0.3.0, this URI allows me to connect. In the other hand,

Re: [Libvir] Accessing qemu from windows

2008-03-11 Thread Richard W.M. Jones
On Tue, Mar 11, 2008 at 06:00:31PM +0200, Gabriel Kaufmann wrote: I'm sure it actually makes a remote TCP connection since on the server side I get the error: 'libvir: error : could not connect to qemu:///system?' It actually prints this out on the server side? Can you run the server with

Re: [Libvir] question about informations

2008-03-14 Thread Richard W.M. Jones
On Fri, Mar 14, 2008 at 06:19:31PM +0900, Atsushi SAKAI wrote: I have a question about informations. Is this english word usual? Since this informations exists in many places. (over 100 in libvirt code) I do not want to change this to information. Those are all mistakes. They should be

Re: [PATCH] fix information*s* to information. Re: [Libvir] question about informations

2008-03-14 Thread Richard W.M. Jones
On Fri, Mar 14, 2008 at 07:23:45PM +0900, Atsushi SAKAI wrote: Hi, I fix this typo. I'll have a look at this and apply it. Thanks! Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a

Re: [Libvir] regarding libvirt windows support...

2008-03-17 Thread Richard W.M. Jones
On Mon, Mar 17, 2008 at 12:03:31PM +0530, [EMAIL PROTECTED] wrote: We are not able to execute make command The errors we ae getting make[2]: *** [libvirt_la-libvirt.lo] Error 1 make[2]: Leaving directory `/cygdrive/d/libvirt-0.4.1/src' make[1]: *** [all-recursive] Error 1 make[1]:

Re: [Libvir] [PATCH] fix typos (part?)

2008-03-17 Thread Richard W.M. Jones
On Mon, Mar 17, 2008 at 11:29:56AM +0900, Atsushi SAKAI wrote: Various typos fix. priviledged = privileged neccessary = necessary hve = have advertizement = advertisement supervizing = supervising (Saori Fukuta suggest us as typo) poool = pool persitent = persistent

Re: [Libvir] [PATCH] Implement memory operations for qemu driver

2008-03-18 Thread Richard W.M. Jones
On Mon, Mar 17, 2008 at 04:21:04PM -0400, Cole Robinson wrote: The attached patch implements the following operations for the qemu driver: virDomainGetMaxMemory virDomainSetMaxMemory virDomainSetMemory The patch itself, +1. Maybe we should investigate whether qemu/kvm does or will support

Re: [Libvir] [PATCH] Fix MAC address parsing for 1-digit case

2008-03-18 Thread Richard W.M. Jones
On Tue, Mar 18, 2008 at 02:36:02PM +0900, Hiroyuki Kaguchi wrote: Index: src/xml.c [...] + * parseMacAddr: Since all hypervisors support MAC addresses, and we already have a shared MAC address function (__virMacAddrCompare), this should go in file src/util.c. Rich. -- Richard Jones, Emerging

Re: [libvir] How to seek a running QEMU instance

2008-03-18 Thread Richard W.M. Jones
On Tue, Mar 18, 2008 at 05:47:38PM +0300, Anton Protopopov wrote: I have the following question. How can virsh (or, more accurately, libvirt) detect a running QEMU vm, when latter was already started? For example, I have got the following: As Dan says, it doesn't, but this is kind of a bug in

Re: [Libvir] [PATCH] Fix MAC address parsing for 1-digit case

2008-03-19 Thread Richard W.M. Jones
On Wed, Mar 19, 2008 at 04:07:34PM +0900, Hiroyuki Kaguchi wrote: Hi, Jim and Rich Thank you for your suggestions. I apply the following changes to the patch. 1) Initialize errno to 0 before the loop. 2) Use isxdigit instead of isdigit and isalpha, and add a comment. 3) Test errno != 0.

Re: [Libvir] [PATCH] * qemud/remote.c: Don't include getopt.h. Not used.

2008-03-19 Thread Richard W.M. Jones
On Wed, Mar 19, 2008 at 02:08:44PM +0100, Jim Meyering wrote: I had a few in-progress changes from a week or two ago, and am clearing the decks. I added a new build-checking rule (coming separately) and it exposed an unnecessary include: +1 So we have a way to find header files which are

Re: [Libvir] Accessing qemu from windows

2008-03-19 Thread Richard W.M. Jones
On Wed, Mar 19, 2008 at 03:14:44PM +0200, Gabriel Kaufmann wrote: Hi, Sorry for my late reply, I was having technical problems with the machine that has the KVM installed in. I run libvirtd with the --verbose flag, but I still receive the same message with no extra details libvirtd

Re: [Libvir] [PATCH] * qemud/remote.c: Don't include getopt.h. Not used.

2008-03-19 Thread Richard W.M. Jones
On Wed, Mar 19, 2008 at 01:25:33PM +, Daniel P. Berrange wrote: On Wed, Mar 19, 2008 at 01:11:18PM +, Richard W.M. Jones wrote: On Wed, Mar 19, 2008 at 02:08:44PM +0100, Jim Meyering wrote: I had a few in-progress changes from a week or two ago, and am clearing the decks. I

Re: [Libvir] [PATCH] * qemud/remote.c: Don't include getopt.h. Not used.

2008-03-19 Thread Richard W.M. Jones
On Wed, Mar 19, 2008 at 02:21:26PM +0100, Jim Meyering wrote: The hard part is coming up with a regular expression to indicate whether a particular header is used. The following are simple-minded, but so far they seem to do the job... However, for a header with many functions and macros, the

  1   2   3   4   5   6   7   8   9   10   >