[PATCH 0/1] The virJSONValueObjectGetString function can return NULL, there are no checks

The devAlias check is performed in the "if (!devAlias && !devid) {", so the situation is not handled when devAlias is NULL, and devid is not NULL Sergey Mironov (1): The virJSONValueObjectGetString function can return NULL, there are no checks src/qemu/qemu_monitor_j

[PATCH 1/1] The virJSONValueObjectGetString function can return NULL, there are no checks

The devAlias check is performed in the "if (!devAlias && !devid) {", so the situation is not handled when devAlias is NULL, and devid is not NULL Signed-off-by: Sergey Mironov --- src/qemu/qemu_monitor_json.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/qemu/q

[PATCHv2 1/1] Changes from [v1]:

- now checked devAlias and making the code more robust in case when qemu stop sending a devAlias [v1] https://listman.redhat.com/archives/libvir-list/2023-October/242544.html Signed-off-by: Sergey Mironov --- v2: devAlias pointer was checked --- src/qemu/qemu_monitor_json.c | 2 +- 1 file

[PATCHv2 0/1] qemu: added additional devAlias check

Now checked devAlias and making the code more robust in case when qemu stop sending a devAlias Sergey Mironov (1): Changes from [v1]: src/qemu/qemu_monitor_json.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.31.1

[PATCH 0/1] Dead code in the virSecuritySELinuxSetImageLabelInternal function

The virSecuritySELinuxSetFilecon function (by definition) always return values 0 or -1. Sergey Mironov (1): Checking the value returned by the function src/security/security_selinux.c | 11 --- 1 file changed, 11 deletions(-) -- 2.31.1

[PATCH 1/1] Checking the value returned by the function

(by definition) can only return 0 or -1, I suggest removing the "dead code" in the current patch. Co-developed-by: sdl.qemu Signed-off-by: Sergey Mironov --- src/security/security_selinux.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/src/security/security_selin

[PATCH 0/1] Checking the value returned by the function

The code compares the value of the variable 'ret' with 1. I assume that it is necessary to compare the value of 'ret' with -1 in this code fragment. Sergey Mironov (1): Checking the value returned by the function src/security/security_selinux.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 1/1] Checking the value returned by the function

The virSecuritySELinuxSetFilecon function (by definition) always returns values 0 or -1. The result of this function is written to 'ret'. The code compares the value of the variable 'ret' with 1. Signed-off-by: Sergey Mironov --- src/security/security_selinux.c | 2 +- 1 file changed, 1