On Sun, May 10, 2009 at 02:06:54AM +0300, Zvi Dubitzky wrote:
running blcokStats() with Java binding (libvirt-java-0.2.1 ) I get an
exception
Inspecting the src/jni/org_libvirt_Domain.c is see the following lines of
code :
[...]
The bold line should be replaced by :
jclass
Hi,
On Mon, May 11, 2009 at 10:26 AM, Ryota Ozaki ozaki.ry...@gmail.com wrote:
Hi,
On Sun, May 10, 2009 at 8:49 AM, Ryota Ozaki ozaki.ry...@gmail.com wrote:
Hi Serge and Daniel,
On Sat, May 9, 2009 at 4:03 AM, Serge E. Hallyn se...@us.ibm.com wrote:
Quoting Daniel P. Berrange
Seems I didn't send any reminder about the next release plans on
Friday, so here is a recap:
- feature freeze on the 22nd so we have 2 more week to work on
reviewing and adding OpenNebula/Power drivers and try to get the
NPIV, netcf and secure migration patches in. It's likely not
On Wed, May 06, 2009 at 06:11:42PM +0200, Pritesh Kothari wrote:
Hi All,
As discussed on the list resending the networking patch's. the patch's are as
below:
[PATCH 1/3]: contains support for Internal network in libvirt
[...]
+case VIR_DOMAIN_NET_TYPE_INTERNAL:
+if (internal
On Wed, May 06, 2009 at 06:11:50PM +0200, Pritesh Kothari wrote:
[PATCH 2/3]: contains support for Host only and Internal networks in
VirtualBox driver
Okay, standalone, looks fine, so applied and commited too,
thanks !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit
On Wed, May 06, 2009 at 06:12:21PM +0200, Pritesh Kothari wrote:
+
+static virNetworkPtr vboxNetworkCreateXML(virConnectPtr conn, const char
*xml) {
+vboxGlobalData *data = conn-privateData;
+virNetworkDefPtr def = NULL;
+virNetworkPtr ret = NULL;
+nsID *iid
On Wed, May 06, 2009 at 06:12:21PM +0200, Pritesh Kothari wrote:
Hi All,
As discussed on the list resending the networking patch's. the patch's are as
below:
[PATCH 3/3]: contains networking API for hostonly networks in VirtualBox
driver in libvirt (it contains all the fix's proposed on
On Thu, May 07, 2009 at 03:49:28PM +0200, Pritesh Kothari wrote:
Hi All,
I have added support for vrdp/sdl/gui modes for VirtualBox driver in libvirt.
Tha patch's are as below:
[PATCH 1/3]: contains support for vrdp/sdl/gui while defining a machine.
[PATCH 2/3]: contains support for
On Thu, May 07, 2009 at 03:49:38PM +0200, Pritesh Kothari wrote:
Hi All,
I have added support for vrdp/sdl/gui modes for VirtualBox driver in libvirt.
Tha patch's are as below:
[PATCH 1/3]: contains support for vrdp/sdl/gui while defining a machine.
[PATCH 2/3]: contains support for
On Thu, May 07, 2009 at 03:50:13PM +0200, Pritesh Kothari wrote:
Hi All,
I have added support for vrdp/sdl/gui modes for VirtualBox driver in libvirt.
Tha patch's are as below:
[PATCH 1/3]: contains support for vrdp/sdl/gui while defining a machine.
[PATCH 2/3]: contains support for
On Fri, May 08, 2009 at 01:52:23PM -0400, Laine Stump wrote:
diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in
index 2f7076f..cee3d94 100644
--- a/include/libvirt/libvirt.h.in
+++ b/include/libvirt/libvirt.h.in
@@ -854,6 +854,90 @@ int
On Fri, May 08, 2009 at 01:52:24PM -0400, Laine Stump wrote:
From: Laine Stump la...@redhat.com
---
include/libvirt/libvirt.h| 18 ++
include/libvirt/libvirt.h.in | 18 ++
include/libvirt/virterror.h |4 +
src/datatypes.h | 25 ++
src/driver.h
On Fri, May 08, 2009 at 01:52:27PM -0400, Laine Stump wrote:
From: Laine Stump la...@redhat.com
---
configure.in| 35 ---
src/Makefile.am |5 +
2 files changed, 37 insertions(+), 3 deletions(-)
diff --git a/configure.in b/configure.in
index
On Mon, May 11, 2009 at 12:17:17PM +0200, Daniel Veillard wrote:
On Wed, May 06, 2009 at 06:12:21PM +0200, Pritesh Kothari wrote:
+/**
+ * The Network Functions here on
+ */
+static virDrvOpenStatus vboxNetworkOpen(virConnectPtr conn,
+
On Sat, May 09, 2009 at 11:07:46PM +0200, libv...@pivert.org wrote:
Hi,
I'm fighting to configure the keyboard on libvirt (kvm) (0.6.1-0ubuntu5).
I'm using a belgian keyboard, so, my question is :
- Which keyboard layout should I place in the xml file (or through the vm
display
On Fri, May 08, 2009 at 01:52:25PM -0400, Laine Stump wrote:
---
qemud/remote.c | 235
qemud/remote_dispatch_args.h |8 +
qemud/remote_dispatch_prototypes.h | 63 +++
qemud/remote_dispatch_ret.h|6 +
On Fri, May 08, 2009 at 01:52:26PM -0400, Laine Stump wrote:
---
src/libvirt_public.syms | 20
1 files changed, 20 insertions(+), 0 deletions(-)
diff --git a/src/libvirt_public.syms b/src/libvirt_public.syms
index b8f9128..cd369cb 100644
---
Back in March I attempted to fix the event loop handling of deleted file
handles
http://www.redhat.com/archives/libvir-list/2009-March/msg00246.html
but have merely succeeded in screwing it up in a different fun exciting
way. That patch fixed a case where there was a deleted file handle in the
The qemudSetNonBlock() and qemudSetCloseExec() should not exist anymore
since we have impls virSetNonBlock virSetCloseExec in util.h. Removing
these makes it possible to link directly to qemud/event.c for a later
test case.
Daniel
diff -r d5dc15adcbea qemud/event.c
--- a/qemud/event.c Fri
Several methods forgot to call virEventInterruptLocked() in critical
times, or called it at the wrong point. This fixes that problem.
It also changes watch and timer numbers to start from 1, instead of 0.
This is because we've had a number of bugs where code has passed an
uninitialized
This patch fixes handling of deleted file handles. First of all it reverts
the patch http://www.redhat.com/archives/libvir-list/2009-March/msg00246.html
As an alternative solution to that original problem, the first thing that
virEventRunOnce() does, is to purge all timers/watches which were
This patch adds a new test case to validate the various wierd scenarios that
can occur when adding/removing/updating watches timers in the event loop.
In particular it checks
- Handling of watches marked as deleted before virEventRunOnce
- Handling of watches marked as deleted during dispatch
+
+strcpy (networkNameUtf8, HostInterfaceNetworking-);
+strcat (networkNameUtf8, def-name);
That said, how about just using virAsprintf(nmetworkNameUtf8..
instead of alloc+strcpy
Done.
+DEBUG(Network Name: %s, def-name);
+DEBUG(Network UUID:
+
On Mon, 2009-05-11 at 12:11 +0100, Daniel P. Berrange wrote:
Back in March I attempted to fix the event loop handling of deleted file
handles
http://www.redhat.com/archives/libvir-list/2009-March/msg00246.html
but have merely succeeded in screwing it up in a different fun exciting
way.
On Mon, May 11, 2009 at 12:47:38PM +0100, Mark McLoughlin wrote:
On Mon, 2009-05-11 at 12:11 +0100, Daniel P. Berrange wrote:
Back in March I attempted to fix the event loop handling of deleted file
handles
http://www.redhat.com/archives/libvir-list/2009-March/msg00246.html
but have
You really don't need to keep any data about the networking driver
in libvirt(d) itself ?
as danpb explained it :)
+/* Currently support only one dhcp server per
network + * with contigious address space from
start to end +
On Mon, May 04, 2009 at 01:42:56PM -0400, Cole Robinson wrote:
Signed-off-by: Cole Robinson crobi...@redhat.com
---
include/libvirt/libvirt.h|4 +++
include/libvirt/libvirt.h.in |4 +++
src/driver.h |6
src/libvirt.c| 61
On Fri, May 08, 2009 at 01:52:23PM -0400, Laine Stump wrote:
From: Laine Stump la...@redhat.com
---
include/libvirt/libvirt.h| 84
++
include/libvirt/libvirt.h.in | 84
++
2 files changed, 168
On Mon, May 04, 2009 at 01:42:57PM -0400, Cole Robinson wrote:
Signed-off-by: Cole Robinson crobi...@redhat.com
---
qemud/remote.c | 34 ++
qemud/remote_dispatch_args.h |1 +
qemud/remote_dispatch_prototypes.h |7 +++
On Mon, May 04, 2009 at 01:42:58PM -0400, Cole Robinson wrote:
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/test.c | 95
1 files changed, 95 insertions(+), 0 deletions(-)
+
+if
On Mon, May 04, 2009 at 01:43:00PM -0400, Cole Robinson wrote:
There is some funkiness here, since we are either dealing with 2 different
pools (which means validation x 2) or the same pool, where we have to be
careful not to deadlock.
Ahhh, tricky stuff.
+
+newvol-building = 1;
+
On Mon, May 04, 2009 at 01:43:01PM -0400, Cole Robinson wrote:
Improves readability, particularly wrt the pending CreateFromXML changes.
This will also help implementing File-Block volume creation in the future,
since some of this code will need to be moved to a backend agnostic file.
This is
On Fri, May 08, 2009 at 05:42:07PM +0100, Daniel P. Berrange wrote:
The patches we just applied for the VirtualBox open method still were
not quite right. It would return VIR_DRV_OPEN_DECLINED when uri==NULL,
but before doing so it would have set conn-uri to vbox:///session. So
even though
On Mon, May 04, 2009 at 01:43:02PM -0400, Cole Robinson wrote:
Add an extra 'inputvol' parameter to the file volume building routines. This
allows us to easily reuse the duplicate functionality.
@@ -1032,15 +1046,68 @@ static int createRaw(virConnectPtr conn,
On Mon, May 11, 2009 at 02:19:06PM +0200, Pritesh Kothari wrote:
You really don't need to keep any data about the networking driver
in libvirt(d) itself ?
+static int vboxListNetworks(virConnectPtr conn, char **const names, int
nnames) {
+vboxGlobalData *data = conn-privateData;
+
[PATCH 1/3]: contains support for vrdp/sdl/gui while defining a machine.
+guiDisplay =
strdup(def-graphics[i]-data.desktop.display); +}
+
+if ((def-graphics[i]-type ==
VIR_DOMAIN_GRAPHICS_TYPE_SDL) (sdlPresent == 0)) { +
-def-graphics-data.rdp.autoport = 1;
+valueDisplayUtf8 = getenv(DISPLAY);
+valueDisplayFree = 0;
}
Using getenv() here is not right, since that's running in the
Same issue about use of 'getenv' strdup OOM handling here.
Fixed these two and reposting the patch.
Regards,
Pritesh
diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c
index 85a336a..274afd8 100644
--- a/src/vbox/vbox_tmpl.c
+++ b/src/vbox/vbox_tmpl.c
@@ -2343,20 +2343,12 @@ static
When refreshing a file based pool, errors hit when determining a
volume's format were being squashed, reporting OOM instead. The attached
patch fixes the error reporting here.
Reported by Jason Guiditta.
Thanks,
Cole
diff --git a/src/storage_backend.c b/src/storage_backend.c
index
On Mon, May 11, 2009 at 10:03:24AM -0400, Cole Robinson wrote:
When refreshing a file based pool, errors hit when determining a
volume's format were being squashed, reporting OOM instead. The attached
patch fixes the error reporting here.
Reported by Jason Guiditta.
ACK.
Daniel
--
|:
On Fri, May 08, 2009 at 09:04:35AM +0900, Ryota Ozaki wrote:
Hi,
Current lxc driver unexpectedly allows users inside containers to reboot
host physical machine. This patch prevents this by dropping CAP_SYS_BOOT
capability in the bounding set of the init processes in every containers.
Note
On Fri, May 08, 2009 at 11:39:28AM +0100, Daniel P. Berrange wrote:
The -help output from KVM = 85 is now large than we expected. This patch
increases the buffer from 8k to 64k when reading help. It also provides
more detailed error messages should something go wrong in the future.
Two
On Mon, May 11, 2009 at 08:54:23AM -0400, Cole Robinson wrote:
Daniel P. Berrange wrote:
On Mon, May 04, 2009 at 01:42:58PM -0400, Cole Robinson wrote:
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/test.c | 95
On Fri, May 08, 2009 at 05:42:07PM +0100, Daniel P. Berrange wrote:
The patches we just applied for the VirtualBox open method still were
not quite right. It would return VIR_DRV_OPEN_DECLINED when uri==NULL,
but before doing so it would have set conn-uri to vbox:///session. So
even though
On Mon, May 11, 2009 at 10:03:24AM -0400, Cole Robinson wrote:
When refreshing a file based pool, errors hit when determining a
volume's format were being squashed, reporting OOM instead. The attached
patch fixes the error reporting here.
Looks fine, though if you start to add function
On Mon, May 11, 2009 at 04:27:36PM +0200, Daniel Veillard wrote:
On Fri, May 08, 2009 at 05:42:07PM +0100, Daniel P. Berrange wrote:
[...]
+if (conn-uri == NULL ||
+conn-uri-scheme == NULL ||
+STRNEQ (conn-uri-scheme, vbox) ||
+conn-uri-server != NULL)
+
There's a strdup() call here that's not checked for failure, and quite a
few more in other functions in the patch.
Hopefully covered all the strdup's and fixed it
Reposting the patch.
This reminds me that we really need to make a wrapper for strdup, as we did
for malloc() to validate
- If the user gives a URI with a vbox:/// prefix, we should always
handle it, unless a 'server' is set when we leave it to the remote
driver
- If an invalid path is given we must give back a real error code
- If after deciding the URI is for us, any initialization fails
we must
This is a simpler version of
http://www.redhat.com/archives/libvir-list/2009-April/msg00523.html
just overriding the LIBTOOL variable in configure.in, instead of in each
Makefile.am
As before you still need 'make -s' to get full effect
Daniel
diff -r f94c0624da5c configure.in
---
Hi,
I needed to apply the following two small changes to get it compile.
On my system (Ubuntu 9.04) I don't have a sys/capability.h header, but
a linux/capability.h header as part of the linux-libc-dev package.
The second change makes the code compile with -Werror, because vmDef
is not used in
Daniel Veillard wrote:
On Fri, May 08, 2009 at 09:04:35AM +0900, Ryota Ozaki wrote:
Hi,
Current lxc driver unexpectedly allows users inside containers to reboot
host physical machine. This patch prevents this by dropping CAP_SYS_BOOT
capability in the bounding set of the init processes in
On Mon, May 11, 2009 at 05:59:45PM +0200, Matthias Bolte wrote:
Hi,
I needed to apply the following two small changes to get it compile.
On my system (Ubuntu 9.04) I don't have a sys/capability.h header, but
a linux/capability.h header as part of the linux-libc-dev package.
That is
2009/5/11 Daniel P. Berrange berra...@redhat.com:
On Mon, May 11, 2009 at 05:59:45PM +0200, Matthias Bolte wrote:
Hi,
I needed to apply the following two small changes to get it compile.
On my system (Ubuntu 9.04) I don't have a sys/capability.h header, but
a linux/capability.h header as
Matthias Bolte wrote:
2009/5/11 Daniel P. Berrange berra...@redhat.com:
On Mon, May 11, 2009 at 05:59:45PM +0200, Matthias Bolte wrote:
Hi,
I needed to apply the following two small changes to get it compile.
On my system (Ubuntu 9.04) I don't have a sys/capability.h header, but
a
On Mon, May 11, 2009 at 12:37:25PM -0400, Dave Allan wrote:
Matthias Bolte wrote:
2009/5/11 Daniel P. Berrange berra...@redhat.com:
On Mon, May 11, 2009 at 05:59:45PM +0200, Matthias Bolte wrote:
Hi,
I needed to apply the following two small changes to get it compile.
On my system
On Mon, May 11, 2009 at 05:22:15PM +0100, Daniel P. Berrange wrote:
On Mon, May 11, 2009 at 05:59:45PM +0200, Matthias Bolte wrote:
Hi,
I needed to apply the following two small changes to get it compile.
On my system (Ubuntu 9.04) I don't have a sys/capability.h header, but
a
On 05/11/2009 06:35 AM, Daniel P. Berrange wrote:
On Fri, May 08, 2009 at 01:52:24PM -0400, Laine Stump wrote:
From: Laine Stump la...@redhat.com
---
include/libvirt/libvirt.h| 18 ++
include/libvirt/libvirt.h.in | 18 ++
include/libvirt/virterror.h |4 +
src/datatypes.h
On Wed, 2009-04-08 at 13:34 -0500, Anthony Liguori wrote:
Right now only one monitor device can be enabled at a time. In order to
support
asynchronous notification of events, I would like to introduce a 'wait'
command
that waits for an event to occur. This implies that we need an
Hollis Blanchard wrote:
On Wed, 2009-04-08 at 13:34 -0500, Anthony Liguori wrote:
Right now only one monitor device can be enabled at a time. In order to support
asynchronous notification of events, I would like to introduce a 'wait' command
that waits for an event to occur. This implies
59 matches
Mail list logo
