Re: [libvirt] [PATCH] qemu: Fix USB by product with security enabled

2010-03-15 Thread Laurent Léonard
Le vendredi 12 mars 2010 à 18:49, Cole Robinson a écrit : We need to call PrepareHostdevs to determine the USB device path before any security calls. PrepareHostUSBDevices was also incorrectly skipping all USB devices. Signed-off-by: Cole Robinson crobi...@redhat.com ---

[libvirt] [PATCH] Fix error messages in qemu text monitor

2010-03-15 Thread Jiri Denemark
Signed-off-by: Jiri Denemark jdene...@redhat.com --- src/qemu/qemu_monitor_text.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_monitor_text.c b/src/qemu/qemu_monitor_text.c index e629c6b..b7c41a1 100644 --- a/src/qemu/qemu_monitor_text.c +++

Re: [libvirt] [PATCH] esx: Move username and password helper functions to util.c

2010-03-15 Thread Daniel P. Berrange
On Sun, Mar 14, 2010 at 10:07:24PM +0100, Matthias Bolte wrote: --- src/esx/esx_driver.c |8 ++-- src/esx/esx_util.c | 83 -- src/esx/esx_util.h |7 src/util/util.c | 89 ++

[libvirt] [PATCH] Fix syntax-check errors

2010-03-15 Thread Jiri Denemark
Signed-off-by: Jiri Denemark jdene...@redhat.com --- src/nodeinfo.c |4 ++-- src/xenapi/xenapi_driver.c | 27 ++--- src/xenapi/xenapi_utils.c |4 ++-- 3 files changed, 17 insertions(+), 18 deletions(-) Actually, one more error is reported by

[libvirt] [PATCH] Allow suspend during live migration

2010-03-15 Thread Jiri Denemark
Currently no command can be sent to a qemu process while another job is active. This patch adds support for signaling long-running jobs (such as migration) so that other threads may request predefined operations to be done during such jobs. Two signals are defined so far: -

Re: [libvirt] [PATCH] esx: Move username and password helper functions to util.c

2010-03-15 Thread Matthias Bolte
2010/3/15 Daniel P. Berrange berra...@redhat.com: On Sun, Mar 14, 2010 at 10:07:24PM +0100, Matthias Bolte wrote: ---  src/esx/esx_driver.c |    8 ++--  src/esx/esx_util.c   |   83 --  src/esx/esx_util.h   |    7  src/util/util.c      |   89

[libvirt] [PATCH 3/5] Implement virDomainMigrateSetDowntime in remote driver

2010-03-15 Thread Jiri Denemark
Signed-off-by: Jiri Denemark jdene...@redhat.com --- src/remote/remote_driver.c | 28 +++- 1 files changed, 27 insertions(+), 1 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index e654610..00158a6 100644 ---

[libvirt] [PATCH 2/5] Public virDomainMigrateSetDowntime API

2010-03-15 Thread Jiri Denemark
Signed-off-by: Jiri Denemark jdene...@redhat.com --- include/libvirt/libvirt.h.in |3 ++ src/libvirt.c| 46 ++ src/libvirt_public.syms |5 3 files changed, 54 insertions(+), 0 deletions(-) diff --git

[libvirt] [PATCH 0/5] Introduce virDomainMigrateSetDowntime API

2010-03-15 Thread Jiri Denemark
This API call is supposed to change maximum tolerable downtime for live migrations. Jiri Denemark (5): Internal driver API for virDomainMigrateSetDowntime Public virDomainMigrateSetDowntime API Implement virDomainMigrateSetDowntime in remote driver Wire protocol and dispatcher for

[libvirt] [PATCH 4/5] Wire protocol and dispatcher for virDomainMigrateSetDowntime

2010-03-15 Thread Jiri Denemark
Signed-off-by: Jiri Denemark jdene...@redhat.com --- daemon/remote.c | 29 ++ daemon/remote_dispatch_args.h |1 + daemon/remote_dispatch_prototypes.h |8 +++ daemon/remote_dispatch_table.h |5 ++ src/remote/remote_protocol.c| 11

Re: [libvirt] [PATCH] Fix error messages in qemu text monitor

2010-03-15 Thread Matthias Bolte
2010/3/15 Jiri Denemark jdene...@redhat.com: Signed-off-by: Jiri Denemark jdene...@redhat.com --- ACK. Matthias -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 1/5] Internal driver API for virDomainMigrateSetDowntime

2010-03-15 Thread Jiri Denemark
Signed-off-by: Jiri Denemark jdene...@redhat.com --- src/driver.h|5 + src/esx/esx_driver.c|1 + src/lxc/lxc_driver.c|1 + src/opennebula/one_driver.c |1 + src/openvz/openvz_driver.c |1 + src/phyp/phyp_driver.c |1 +

[libvirt] [PATCH 5/5] Implement virDomainMigrateSetDowntime in qemu driver

2010-03-15 Thread Jiri Denemark
Signed-off-by: Jiri Denemark jdene...@redhat.com --- src/qemu/qemu_driver.c | 48 +- src/qemu/qemu_monitor.c | 15 + src/qemu/qemu_monitor.h |3 ++ src/qemu/qemu_monitor_json.c | 29 +

Re: [libvirt] [PATCH] Fix syntax-check errors

2010-03-15 Thread Matthias Bolte
2010/3/15 Jiri Denemark jdene...@redhat.com: Signed-off-by: Jiri Denemark jdene...@redhat.com --- ACK. Matthias -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Fix syntax-check errors

2010-03-15 Thread Jiri Denemark
Signed-off-by: Jiri Denemark jdene...@redhat.com --- ACK. Matthias Thanks. I pushed both this patch and the fix of error messages in qemu monitor code. Jirka -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] qemudDomainAttachSCSIDisk: handle empty controller list

2010-03-15 Thread Wolfgang Mauerer
Jim Meyering wrote: Clang found something that might be a real bug. I suspect that ...drive.controller will always be at least one, it can - explanation below. but we should not have to dive into the code trying to figure that out. It's easier/better here just to handle the potential

Re: [libvirt] [PATCH] qemudDomainAttachSCSIDisk: handle empty controller list

2010-03-15 Thread Daniel P. Berrange
On Mon, Mar 15, 2010 at 03:56:55PM +0100, Wolfgang Mauerer wrote: Jim Meyering wrote: Clang found something that might be a real bug. I suspect that ...drive.controller will always be at least one, it can - explanation below. but we should not have to dive into the code trying to figure

Re: [libvirt] [PATCH] esx: Move username and password helper functions to util.c

2010-03-15 Thread Daniel P. Berrange
On Mon, Mar 15, 2010 at 02:29:55PM +0100, Matthias Bolte wrote: 2010/3/15 Daniel P. Berrange berra...@redhat.com: On Sun, Mar 14, 2010 at 10:07:24PM +0100, Matthias Bolte wrote: ---  src/esx/esx_driver.c |    8 ++--  src/esx/esx_util.c   |   83

Re: [libvirt] [PATCH] esx: Move username and password helper functions to util.c

2010-03-15 Thread Matthias Bolte
2010/3/15 Daniel P. Berrange berra...@redhat.com: On Mon, Mar 15, 2010 at 02:29:55PM +0100, Matthias Bolte wrote: 2010/3/15 Daniel P. Berrange berra...@redhat.com: On Sun, Mar 14, 2010 at 10:07:24PM +0100, Matthias Bolte wrote: ---  src/esx/esx_driver.c |    8 ++--  src/esx/esx_util.c  

Re: [libvirt] [PATCH] xenapi: Check for valid private data in xenapiSessionErrorHandle

2010-03-15 Thread Daniel P. Berrange
On Sun, Mar 14, 2010 at 10:08:05PM +0100, Matthias Bolte wrote: --- src/xenapi/xenapi_utils.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/xenapi/xenapi_utils.c b/src/xenapi/xenapi_utils.c index 4b9a6d8..bfd53ed 100644 --- a/src/xenapi/xenapi_utils.c

Re: [libvirt] [PATCH] xenapi: Request a username if there is non in the URI

2010-03-15 Thread Daniel P. Berrange
On Sun, Mar 14, 2010 at 10:08:30PM +0100, Matthias Bolte wrote: Use virRequestUsername and virRequestPassword. --- src/xenapi/xenapi_driver.c | 119 +++- 1 files changed, 84 insertions(+), 35 deletions(-) diff --git a/src/xenapi/xenapi_driver.c

Re: [libvirt] [PATCH] xenapi: Check for NULL before accessing the scheme

2010-03-15 Thread Daniel P. Berrange
On Sun, Mar 14, 2010 at 10:09:01PM +0100, Matthias Bolte wrote: --- src/xenapi/xenapi_driver.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/xenapi/xenapi_driver.c b/src/xenapi/xenapi_driver.c index 00b62b3..9a38e3f 100644 --- a/src/xenapi/xenapi_driver.c

Re: [libvirt] [PATCH] phyp: Use virRequestUsername and virRequestPassword

2010-03-15 Thread Daniel P. Berrange
On Sun, Mar 14, 2010 at 10:18:05PM +0100, Matthias Bolte wrote: --- src/phyp/phyp_driver.c | 73 --- src/phyp/phyp_driver.h |1 - 2 files changed, 31 insertions(+), 43 deletions(-) diff --git a/src/phyp/phyp_driver.c

Re: [libvirt] [PATCH] xenapi: Don't leak url and caps in case of error

2010-03-15 Thread Daniel P. Berrange
On Sun, Mar 14, 2010 at 10:09:45PM +0100, Matthias Bolte wrote: --- src/xenapi/xenapi_driver.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/xenapi/xenapi_driver.c b/src/xenapi/xenapi_driver.c index 9a38e3f..7d0b748 100644 --- a/src/xenapi/xenapi_driver.c

Re: [libvirt] [PATCH 2/2] virsh: support VISUAL, and allow metacharacters in EDITOR

2010-03-15 Thread Daniel P. Berrange
On Fri, Mar 12, 2010 at 09:50:01AM -0700, Eric Blake wrote: Common Unix practice is to prefer VISUAL over EDITOR, particularly if the editor of choice spawns a new window. Thus, it is also common to see settings like EDITOR='emacs -nw', with the expectation that the shell will parse this as

Re: [libvirt] [PATCH] security: Set permissions for kernel/initrd

2010-03-15 Thread Daniel P. Berrange
On Fri, Mar 12, 2010 at 02:01:44PM -0500, Cole Robinson wrote: Fixes URL installs when running virt-install as root on Fedora. Signed-off-by: Cole Robinson crobi...@redhat.com --- src/qemu/qemu_security_dac.c| 21 + src/security/security_selinux.c | 16

Re: [libvirt] [PATCH] esx: Improve documentation about remote URIs

2010-03-15 Thread Daniel P. Berrange
On Fri, Mar 12, 2010 at 10:34:07PM +0100, Matthias Bolte wrote: --- docs/drvesx.html.in |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/docs/drvesx.html.in b/docs/drvesx.html.in index 9b413ab..6855298 100644 --- a/docs/drvesx.html.in +++

Re: [libvirt] [PATCH] esx: Allow 'lsisas1068' as SCSI controller type

2010-03-15 Thread Daniel P. Berrange
On Fri, Mar 12, 2010 at 09:19:02PM +0100, Matthias Bolte wrote: diff --git a/tests/xml2vmxdata/xml2vmx-scsi-driver.xml b/tests/xml2vmxdata/xml2vmx-scsi-driver.xml new file mode 100644 index 000..797a26e --- /dev/null +++ b/tests/xml2vmxdata/xml2vmx-scsi-driver.xml @@ -0,0 +1,25 @@

Re: [libvirt] libvirt regression in managing qemu-system-arm

2010-03-15 Thread Daniel P. Berrange
On Thu, Mar 11, 2010 at 11:39:29PM -0500, Chris Tyler wrote: I've been experimenting with using libvirt to manage qemu-system-arm VMs, and it's working fine in F12. However, in F13Alpha, the wrong arguments are passed to the emulator -- I suspect that the x86 platform versions of qemu accept

Re: [libvirt] [PATCH] qemu: pass the information when disks are read-only

2010-03-15 Thread Daniel P. Berrange
On Thu, Mar 11, 2010 at 06:14:01PM +0100, Daniel Veillard wrote: The problem is that even when the user indicates that a drive has to be opened as read-only (for example a cd-rom) qemu didn't get the information and tried to open read-write. This could get really nasty in case SELinux is

Re: [libvirt] How to differentiate creation from migration?

2010-03-15 Thread Daniel P. Berrange
On Wed, Mar 10, 2010 at 04:11:30PM +0100, Daniel Veillard wrote: On Wed, Mar 10, 2010 at 11:40:44AM -0300, Richard Maciel wrote: Hi, I work on a project that makes use of libvirt (called libvirt-cim) and we created an algorithm to detect when a new machine is created. However, I need

Re: [libvirt] [PATCH] qemudDomainAttachSCSIDisk: handle empty controller list

2010-03-15 Thread Jim Meyering
Daniel P. Berrange wrote: On Mon, Mar 15, 2010 at 03:56:55PM +0100, Wolfgang Mauerer wrote: Jim Meyering wrote: Clang found something that might be a real bug. I suspect that ...drive.controller will always be at least one, it can - explanation below. but we should not have to dive into

Re: [libvirt] eject ISO from cdrom

2010-03-15 Thread Daniel P. Berrange
On Tue, Mar 09, 2010 at 02:06:02PM -0800, Shi Jin wrote: Hi there, I am using libvirt+qemu/kvm. For a guest VM that is running, I could change its cdrom media by running the following virsh command: virsh attach-disk vm-id path-to-iso-file hdc --driver file --type cdrom --mode readonly

Re: [libvirt] [PATCH] qemudDomainAttachSCSIDisk: handle empty controller list

2010-03-15 Thread Daniel P. Berrange
On Mon, Mar 15, 2010 at 04:46:31PM +0100, Jim Meyering wrote: However, there's more to it than that. The controller index, while technically unsigned, may be derived from an expression like -1 / 7, since virDomainDiskDefAssignAddress does this: void

Re: [libvirt] [PATCH] qemudDomainAttachSCSIDisk: handle empty controller list

2010-03-15 Thread Wolfgang Mauerer
Jim Meyering wrote: Daniel P. Berrange wrote: On Mon, Mar 15, 2010 at 03:56:55PM +0100, Wolfgang Mauerer wrote: Jim Meyering wrote: Clang found something that might be a real bug. I suspect that ...drive.controller will always be at least one, it can - explanation below. but we should not

Re: [libvirt] [PATCH] qemu: pass the information when disks are read-only

2010-03-15 Thread Daniel Veillard
On Mon, Mar 15, 2010 at 03:41:34PM +, Daniel P. Berrange wrote: On Thu, Mar 11, 2010 at 06:14:01PM +0100, Daniel Veillard wrote: The problem is that even when the user indicates that a drive has to be opened as read-only (for example a cd-rom) qemu didn't get the information and tried

Re: [libvirt] emulation failed (pagetable) rip

2010-03-15 Thread Daniel P. Berrange
On Sun, Mar 14, 2010 at 10:17:53AM -0400, Adam Mooz wrote: Good morning list, I run a few VM's using libvirt on a C2Q 6600, have been steadily and happily since November, most of the VM's have been happily chugging away since then as well. I woke on Thursday to find one of the VM's had

Re: [libvirt] libvirt modifying iptables rules

2010-03-15 Thread Daniel P. Berrange
On Sun, Mar 07, 2010 at 07:39:59PM +0530, Varrun Ramani wrote: Hi I am right now undertaking a project which deals with verification of firewall rules. I wish to know which applications/libraries modify/query firewall rules. I came to know that libvirt modifies iptables rules. Can anyone

Re: [libvirt] [PATCH] qemu: Fix USB by product with security enabled

2010-03-15 Thread Cole Robinson
On 03/12/2010 12:49 PM, Cole Robinson wrote: We need to call PrepareHostdevs to determine the USB device path before any security calls. PrepareHostUSBDevices was also incorrectly skipping all USB devices. Signed-off-by: Cole Robinson crobi...@redhat.com --- src/qemu/qemu_driver.c | 11

Re: [libvirt] [PATCH] security: Set permissions for kernel/initrd

2010-03-15 Thread Cole Robinson
On 03/15/2010 11:33 AM, Daniel P. Berrange wrote: On Fri, Mar 12, 2010 at 02:01:44PM -0500, Cole Robinson wrote: Fixes URL installs when running virt-install as root on Fedora. Signed-off-by: Cole Robinson crobi...@redhat.com --- src/qemu/qemu_security_dac.c| 21 +

Re: [libvirt] emulation failed (pagetable) rip

2010-03-15 Thread Adam Mooz
Thanks, I'll re-post to that list, hopefully they'll have an answer. -- Adam Mooz Blog: http://www.adammooz.com LinkedIn: http://www.linkedin.com/ln/adammooz On Mon, Mar 15, 2010 at 12:26 PM, Daniel P. Berrange berra...@redhat.com wrote:

[libvirt] XenAPI remote storage - target path

2010-03-15 Thread Sharadha Prabhakar (3P)
Hi, I'm trying to write a Remote Storage driver for XenAPI. I see that target-path is used for both storage pools and volumes. In the case of XenAPI remote storage, the storage is not mounted on the local host where libvirt is running. Storage is maintained in a remote location only. In this case

Re: [libvirt] 'build' on FS pool now unconditionally formats?

2010-03-15 Thread Dave Allan
On 02/26/2010 06:28 PM, Dave Allan wrote: On 02/26/2010 06:23 AM, Daniel P. Berrange wrote: On Thu, Feb 25, 2010 at 10:01:09PM -0500, Dave Allan wrote: On 02/25/2010 08:25 AM, Daniel P. Berrange wrote: On Thu, Feb 25, 2010 at 01:19:54PM +0100, Daniel Veillard wrote: On Wed, Feb 24, 2010 at

[libvirt] [PATCH 1/9] Add public API for volume wiping

2010-03-15 Thread David Allan
--- include/libvirt/libvirt.h.in |2 ++ src/libvirt_public.syms |5 + 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index 0d1b5b5..1430a95 100644 --- a/include/libvirt/libvirt.h.in +++

[libvirt] [PATCH 0/9] Rebased volume wiping API patches

2010-03-15 Thread David Allan
Nobody ack'd (because of general lack of time, I hope) what I think is the final version of the volume wiping API patches, so here is the set again, rebased to the current head. I don't think there is anything controversial in here, as they incorporate all the feedback on previous versions.

[libvirt] [PATCH 6/9] Implement RPC client for vol wiping

2010-03-15 Thread David Allan
--- src/remote/remote_driver.c | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 11513bd..0ee038e 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -5538,6

[libvirt] [PATCH 5/9] Define wire protocol format for vol wiping

2010-03-15 Thread David Allan
--- src/remote/remote_protocol.c | 11 +++ src/remote/remote_protocol.h |9 + src/remote/remote_protocol.x |8 +++- 3 files changed, 27 insertions(+), 1 deletions(-) diff --git a/src/remote/remote_protocol.c b/src/remote/remote_protocol.c index 701acab..6bd9019

Re: [libvirt] [PATCH 1/2] virsh: improve man page

2010-03-15 Thread Eric Blake
On 03/13/2010 07:35 AM, Matthias Bolte wrote: +=item EDITOR + +The editor to use by the Bedit and Bnet-edit options. + There is also a pool-edit and iface-edit command. Good point; I missed them because they did not have the same level of documentation to begin with. Should I respin the

[libvirt] [PATCH 2/9] Define the internal driver API for vol wiping

2010-03-15 Thread David Allan
--- src/driver.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/src/driver.h b/src/driver.h index a64bba0..1a511eb 100644 --- a/src/driver.h +++ b/src/driver.h @@ -723,6 +723,10 @@ typedef int unsigned int flags);

[libvirt] [PATCH 9/9] Virsh support for vol wiping

2010-03-15 Thread David Allan
--- tools/virsh.c | 42 ++ 1 files changed, 42 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index aa85ee6..37ff471 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -5271,6 +5271,47 @@ cmdVolDelete(vshControl *ctl, const

[libvirt] [PATCH 3/9] Add vol wiping to ESX storage driver struct

2010-03-15 Thread David Allan
--- src/esx/esx_storage_driver.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/esx/esx_storage_driver.c b/src/esx/esx_storage_driver.c index b920f3b..7b073a6 100644 --- a/src/esx/esx_storage_driver.c +++ b/src/esx/esx_storage_driver.c @@ -102,6 +102,7 @@ static

[libvirt] [PATCH 4/9] Implement the public API for vol wiping

2010-03-15 Thread David Allan
--- src/libvirt.c | 47 +++ 1 files changed, 47 insertions(+), 0 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 1d9b878..74b075b 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -8479,6 +8479,53 @@ error: /** + * virStorageVolWipe:

[libvirt] [PATCH 7/9] Implement the remote dispatch bits of vol wiping

2010-03-15 Thread David Allan
* I had to remove daemon/remote_dispatch* and do a make remote.c in daemon in order to get the dispatch files regenerated properly. The make was failing before I did that. --- daemon/remote.c | 32 daemon/remote_dispatch_args.h |

[libvirt] [PATCH 8/9] Simplified version of volume wiping based on feedback from the list.

2010-03-15 Thread David Allan
--- src/storage/storage_driver.c | 224 ++ 1 files changed, 224 insertions(+), 0 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index ca2540f..1961fa0 100644 --- a/src/storage/storage_driver.c +++