[libvirt] Unable to setup qemu-guest-agent

2013-06-17 Thread Nehal J. Wani
,prefix:64}],hardware-address:52:54:00:14:99:98}]} Actual result: error: unknown procedure: 3 Where am I going wrong? -- Nehal J. Wani UG2, BTech CS+MS(CL) IIIT-Hyderabad http://commanlinewani.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman

Re: [libvirt] Unable to setup qemu-guest-agent

2013-06-17 Thread Nehal J. Wani
-agent-command f18 '{execute:guest-network-get-interfaces}' (null) On 6/17/13, Osier Yang jy...@redhat.com wrote: On 17/06/13 14:00, Nehal J. Wani wrote: Could anyone please list out the steps required to run the command $virsh qemu-agent-command Steps that I followed: 1. Clone the latest source

Re: [libvirt] Unable to setup qemu-guest-agent

2013-06-17 Thread Nehal J. Wani
I was able to solve the error. It was a stupid mistake. There was a mismatch between versions of virsh and the libvirt daemon. On Mon, Jun 17, 2013 at 3:56 PM, Michal Privoznik mpriv...@redhat.comwrote: On 17.06.2013 09:21, Nehal J. Wani wrote: The error: # ./tools/virsh qemu-agent-command

[libvirt] RFC: Introduce API to query IP addresses for given domain

2013-06-28 Thread Nehal J. Wani
side allocate appropriate memory and return the result once in for all. In the latter case, I'll be using something of the kind virTypedParameterPtr ***params. Thanking You, Nehal J. Wani UG2, BTech CS+MS(CL) IIIT-Hyderabad http://commanlinewani.blogspot.com -- libvir-list mailing list libvir-list

Re: [libvirt] RFC: Introduce API to query IP addresses for given domain

2013-07-02 Thread Nehal J. Wani
:56:10PM +0530, Nehal J. Wani wrote: Hello, fellow developers! I am a GSoC candidate this year working for libvirt.org. My project is Introduce API to query IP addresses for given domain. The discussion regarding this feature had started here: http://www.mail-archive.com/libvir-list

Re: [libvirt] RFC: Introduce API to query IP addresses for given domain

2013-07-08 Thread Nehal J. Wani
, Nehal J. Wani wrote: Hello, fellow developers! I am a GSoC candidate this year working for libvirt.org. My project is Introduce API to query IP addresses for given domain. The discussion regarding this feature had started here: http://www.mail-archive.com/**libvir-list@redhat.com

[libvirt] RFC: Introduce API to return configuration/state paths of the network driver

2013-07-25 Thread Nehal J. Wani
, VIR_RADVD_STATE_DIR * All the above will of the type VIR_TYPED_PARAM_STRING */ int virNetworkGetConfigFileName(virConnectPtr conn, virTypedParameterPtr params, int nparams, unsigned int flags) Nehal J. Wani UG3

Re: [libvirt] RFC: Introduce API to return configuration/state paths of the network driver

2013-08-13 Thread Nehal J. Wani
)) goto cleanup; for (i = 0; i nleases; i++) { VIR_FREE(leases[i].macaddr); VIR_FREE(leases[i].ipaddr); VIR_FREE(leases[i].hostname); VIR_FREE(leases[i].clientid); } -- Nehal J. Wani UG3, BTech CS+MS(CL) IIIT-Hyderabad http://commandlinewani.blogspot.com -- libvir-list mailing

Re: [libvirt] [PATCHv3 3/5] domifaddr: Implement the API for qemu

2013-08-22 Thread Nehal J. Wani
always be called last */ -- 1.7.11.7 -- Nehal J. Wani UG3, BTech CS+MS(CL) IIIT-Hyderabad http://commandlinewani.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv3 4/5] domifaddr: Add virsh support

2013-08-23 Thread Nehal J Wani
default 16-08-2013 03:53:11 52:54:00:89:4e:97 192.168.101.130 f18 * default 16-08-2013 03:45:20 52:54:00:fe:4c:4f 192.168.101.197 ** -- Nehal J Wani UG3, BTech CS+MS(CL) IIIT-Hyderabad http

Re: [libvirt] [PATCHv3 4/5] domifaddr: Add virsh support

2013-08-24 Thread Nehal J Wani
On Sat, Aug 24, 2013 at 6:46 AM, Doug Goldstein car...@gentoo.org wrote: On Fri, Aug 23, 2013 at 10:45 AM, Nehal J Wani nehaljw.k...@gmail.com wrote: On Fri, Aug 23, 2013 at 8:16 PM, Doug Goldstein car...@gentoo.org wrote: On Thu, Aug 22, 2013 at 5:18 PM, nehaljwani nehaljw.k

[libvirt] [PATCHv4 2/5] domifaddr: Implement the remote protocol

2013-08-24 Thread Nehal J Wani
Implement RPC calls for virDomainInterfacesAddresses daemon/remote.c * Define remoteSerializeDomainInterfacePtr, remoteDispatchDomainInterfacesAddresses src/remote/remote_driver.c * Define remoteDomainInterfacesAddresses src/remote/remote_protocol.x * New RPC procedure:

[libvirt] [PATCHv4 0/5] Introduce API to query IP addresses for given domain

2013-08-24 Thread Nehal J Wani
associated interfaces with MAC address and IP addresses) of all of the domain interfaces by default (if no interface name is provided) * Return information for the specified interface (if an interface name is provided) Nehal J Wani (5): domifaddr: Implement the public API domifaddr

[libvirt] [PATCHv4 5/5] domifaddr: Expose python binding

2013-08-24 Thread Nehal J Wani
Expose virDomainInterfacesAddresses to python binding examples/python/Makefile.am: * Add new file domipaddrs.py examples/python/README: * Add documentation for the python example python/libvirt-override-api.xml: * Add new symbol for virDomainInterfacesAddresses python/libvirt-override.c:

[libvirt] [PATCHv4 1/5] domifaddr: Implement the public API

2013-08-24 Thread Nehal J Wani
Define a new API virDomainInterfacesAddresses, which returns the address information of a running domain's interfaces(s). If no interface name is specified, it returns the information of all interfaces, otherwise it only returns the information of the specificed interface. The address information

[libvirt] [PATCHv4 3/5] domifaddr: Implement the API for qemu

2013-08-24 Thread Nehal J Wani
By querying the qemu guest agent with the QMP command guest-network-get-interfaces and converting the received JSON output to structured objects. src/qemu/qemu_agent.h: * Define qemuAgentGetInterfaces src/qemu/qemu_agent.c: * Implement qemuAgentGetInterface src/qemu/qemu_driver.c: * New

[libvirt] [PATCHv4 4/5] domifaddr: Add virsh support

2013-08-24 Thread Nehal J Wani
Use virDomainInterfacesAddresses in virsh tools/virsh-domain-monitor.c * Introduce new command : domifaddr virsh # domifaddr f18 Name MAC address IPv4 addressIPv6 address --- lo

Re: [libvirt] [PATCHv4 1/5] domifaddr: Implement the public API

2013-08-27 Thread Nehal J Wani
On Tue, Aug 27, 2013 at 6:06 PM, Daniel P. Berrange berra...@redhat.com wrote: On Sun, Aug 25, 2013 at 04:45:41AM +0530, Nehal J Wani wrote: diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index a47e33c..deb1e1f 100644 --- a/include/libvirt/libvirt.h.in +++ b

Re: [libvirt] [PATCHv4 4/5] domifaddr: Add virsh support

2013-08-27 Thread Nehal J Wani
On Tue, Aug 27, 2013 at 6:20 PM, Daniel P. Berrange berra...@redhat.com wrote: On Sun, Aug 25, 2013 at 04:45:44AM +0530, Nehal J Wani wrote: Use virDomainInterfacesAddresses in virsh tools/virsh-domain-monitor.c * Introduce new command : domifaddr virsh # domifaddr f18 Name

Re: [libvirt] [PATCHv4 4/5] domifaddr: Add virsh support

2013-08-27 Thread Nehal J Wani
:| -- Nehal J Wani UG3, BTech CS+MS(CL) IIIT-Hyderabad http://commandlinewani.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv4 2/5] domifaddr: Implement the remote protocol

2013-08-27 Thread Nehal J Wani
and removed them after kernel 2.0. I have tested creating multiple ipv4 aliases on the same interface and was able to achieve the count of 1010 without any warnings/errors. -- Nehal J Wani -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCHv5 1/5] domifaddr: Implement the public APIs

2013-09-01 Thread Nehal J Wani
Define a new API virDomainInterfaceAddresses, which returns the address information of a running domain's interfaces(s). If no interface name is specified, it returns the information of all interfaces, otherwise it only returns the information of the specificed interface. The address information

[libvirt] [PATCHv5 0/5] Introduce API to query IP addresses for given domain

2013-09-01 Thread Nehal J Wani
/2013-July/msg01553.html Nehal J Wani (5): domifaddr: Implement the public APIs domifaddr: Implement the remote protocol domifaddr: Implement the API for qemu domifaddr: Add virsh support domifaddr: Expose python binding daemon/remote.c | 131

[libvirt] [PATCHv5 2/5] domifaddr: Implement the remote protocol

2013-09-01 Thread Nehal J Wani
daemon/remote.c * Define remoteSerializeDomainInterface, remoteDispatchDomainInterfaceAddresses src/remote/remote_driver.c * Define remoteDomainInterfaceAddresses src/remote/remote_protocol.x * New RPC procedure: REMOTE_PROC_DOMAIN_INTERFACE_ADDRESSES * Define structs

[libvirt] [PATCHv5 4/5] domifaddr: Add virsh support

2013-09-01 Thread Nehal J Wani
Use virDomainInterfaceAddresses in virsh tools/virsh-domain-monitor.c * Introduce new command : domifaddr Usage: domifaddr domain [interface] [full] Example output: virsh # domifaddr f18 Name MAC address Protocol IP Address

[libvirt] [PATCHv5 5/5] domifaddr: Expose python binding

2013-09-01 Thread Nehal J Wani
Expose virDomainInterfaceAddresses to python binding examples/python/Makefile.am: * Add new file domipaddrs.py examples/python/README: * Add documentation for the python example python/libvirt-override-api.xml: * Add new symbol for virDomainInterfaceAddresses python/libvirt-override.c:

[libvirt] [PATCHv5 3/5] domifaddr: Implement the API for qemu

2013-09-01 Thread Nehal J Wani
By querying the qemu guest agent with the QMP command guest-network-get-interfaces and converting the received JSON output to structured objects. Although ifconfig is deprecated, IP aliases created by ifconfig are supported by this API. The legacy syntax of an IP alias is: ifname:alias-name.

Re: [libvirt] [PATCHv5 1/5] domifaddr: Implement the public APIs

2013-09-02 Thread Nehal J Wani
On Sun, Sep 1, 2013 at 7:13 PM, Nehal J Wani nehaljw.k...@gmail.com wrote: Define a new API virDomainInterfaceAddresses, which returns the address information of a running domain's interfaces(s). If no interface name is specified, it returns the information of all interfaces, otherwise it only

Re: [libvirt] [PATCHv5 5/5] domifaddr: Expose python binding

2013-09-02 Thread Nehal J Wani
On Sun, Sep 1, 2013 at 7:13 PM, Nehal J Wani nehaljw.k...@gmail.com wrote: Expose virDomainInterfaceAddresses to python binding examples/python/Makefile.am: * Add new file domipaddrs.py examples/python/README: * Add documentation for the python example python/libvirt-override-api.xml

Re: [libvirt] [PATCHv5 2/5] domifaddr: Implement the remote protocol

2013-09-03 Thread Nehal J Wani
On Mon, Sep 2, 2013 at 5:11 PM, Daniel P. Berrange berra...@redhat.com wrote: On Sun, Sep 01, 2013 at 07:13:32PM +0530, Nehal J Wani wrote: daemon/remote.c * Define remoteSerializeDomainInterface, remoteDispatchDomainInterfaceAddresses src/remote/remote_driver.c * Define

Re: [libvirt] [PATCHv5 3/5] domifaddr: Implement the API for qemu

2013-09-03 Thread Nehal J Wani
, - unexpected return values for interface: eth1); + unexpected return values for IP address values); goto cleanup; } -- Nehal J Wani 3.diff Description: Binary data -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com

Re: [libvirt] [PATCHv5 3/5] domifaddr: Implement the API for qemu

2013-09-03 Thread Nehal J Wani
On Tue, Sep 3, 2013 at 7:46 PM, Osier Yang jy...@redhat.com wrote: Except what Daniel pointed out: On 01/09/13 21:43, Nehal J Wani wrote: By querying the qemu guest agent with the QMP command guest-network-get-interfaces and converting the received JSON output to structured objects

Re: [libvirt] [PATCHv5 3/5] domifaddr: Implement the API for qemu

2013-09-03 Thread Nehal J Wani
On Tue, Sep 3, 2013 at 8:21 PM, Osier Yang jy...@redhat.com wrote: On 03/09/13 22:37, Nehal J Wani wrote: On Tue, Sep 3, 2013 at 7:46 PM, Osier Yang jy...@redhat.com wrote: Except what Daniel pointed out: On 01/09/13 21:43, Nehal J Wani wrote: By querying the qemu guest agent

[libvirt] [PATCH] Fix: Syle issues (daemon/remote.c)

2013-09-03 Thread Nehal J Wani
Fix for argument layouts of various functions in daemon/remote.c. Refer: https://www.redhat.com/archives/libvir-list/2013-September/msg00057.html --- daemon/remote.c | 117 ++-- 1 file changed, 55 insertions(+), 62 deletions(-) diff --git

Re: [libvirt] [PATCHv5 1/5] domifaddr: Implement the public APIs

2013-09-05 Thread Nehal J Wani
On Wed, Sep 4, 2013 at 8:05 PM, Osier Yang jy...@redhat.com wrote: On 04/09/13 03:13, Eric Blake wrote: On 09/03/2013 01:07 PM, Eric Blake wrote: On 09/01/2013 07:43 AM, Nehal J Wani wrote: Define a new API virDomainInterfaceAddresses, which returns the address information of a running

Re: [libvirt] [PATCHv5 1/5] domifaddr: Implement the public APIs

2013-09-06 Thread Nehal J Wani
On Tue, Sep 3, 2013 at 6:51 PM, Osier Yang jy...@redhat.com wrote: On 01/09/13 21:43, Nehal J Wani wrote: Define a new API virDomainInterfaceAddresses, which returns the address information of a running domain's interfaces(s). If no interface name is specified, it returns the information

[libvirt] [PATCHv6 3/5] domifaddr: Implement the API for qemu

2013-09-06 Thread Nehal J Wani
By querying the qemu guest agent with the QMP command guest-network-get-interfaces and converting the received JSON output to structured objects. Although ifconfig is deprecated, IP aliases created by ifconfig are supported by this API. The legacy syntax of an IP alias is: ifname:alias-name.

[libvirt] [PATCHv6 2/5] domifaddr: Implement the remote protocol

2013-09-06 Thread Nehal J Wani
daemon/remote.c * Define remoteSerializeDomainInterface, remoteDispatchDomainInterfaceAddresses src/remote/remote_driver.c * Define remoteDomainInterfaceAddresses src/remote/remote_protocol.x * New RPC procedure: REMOTE_PROC_DOMAIN_INTERFACE_ADDRESSES * Define structs

[libvirt] [PATCHv6 5/5] domifaddr: Expose python binding

2013-09-06 Thread Nehal J Wani
Expose virDomainInterfacesAddresses to python binding examples/python/Makefile.am: * Add new file domipaddrs.py examples/python/README: * Add documentation for the python example python/libvirt-override-api.xml: * Add new symbol for virDomainInterfacesAddresses python/libvirt-override.c:

[libvirt] [PATCHv6 0/5] Introduce API to query IP addresses for given domain

2013-09-06 Thread Nehal J Wani
.html v2: * Logical errors, memory leaks and few other errors fixed. * https://www.redhat.com/archives/libvir-list/2013-August/msg00631.html v1: * http://www.redhat.com/archives/libvir-list/2013-July/msg01553.html Nehal J Wani (5): domifaddr: Implement the public APIs domifaddr: Implement

[libvirt] [PATCHv6 4/5] domifaddr: Add virsh support

2013-09-06 Thread Nehal J Wani
Use virDomainInterfaceAddresses in virsh tools/virsh-domain-monitor.c * Introduce new command : domifaddr Usage: domifaddr domain [interface] [--full] [--snoop] [--lease] [--agent] Example outputs: virsh # domifaddr f18 Name MAC address Protocol Address

[libvirt] [PATCHv6 1/5] domifaddr: Implement the public APIs

2013-09-06 Thread Nehal J Wani
Define helper function virDomainInterfaceFree, which allows the upper layer application to free the domain interface object conveniently. The API is going to provide multiple methods by flags, e.g. * Query guest agent * Parse lease file of dnsmasq * DHCP snooping At this stage, it will

Re: [libvirt] [PATCHv6 1/5] domifaddr: Implement the public APIs

2013-09-11 Thread Nehal J Wani
-- Nehal J Wani UG3, BTech CS+MS(CL) IIIT-Hyderabad http://commandlinewani.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 4/4] net-dhcp-leases: Add virsh support

2013-09-11 Thread Nehal J Wani
Use virNetworkGetDHCPLeases and virNetworkGetDHCPLeaseForMAC in virsh. The new feature supports the follwing methods: 1. Retrieve leases info for a given virtual network 2. Retrieve leases info for given network interface tools/virsh-domain-monitor.c * Introduce new command :

[libvirt] [PATCH 2/4] net-dhcp-leases: Implement the remote protocol

2013-09-11 Thread Nehal J Wani
Implement RPC calls for virNetworkGetDHCPLeases, virNetworkGetDHCPLeaseForMAC daemon/remote.c * Define remoteSerializeNetworkDHCPLeases, remoteDispatchNetworkGetDHCPLeases * Define remoteDispatchNetworkGetDHCPLeaseForMAC src/remote/remote_driver.c * Define

[libvirt] [PATCH 1/4] net-dhcp-leases: Implement the public APIs

2013-09-11 Thread Nehal J Wani
Introduce 3 new APIs, virNetworkGetDHCPLeases, virNetworkGetDHCPLeaseForMAC and virNetworkDHCPLeaseFree. * virNetworkGetDHCPLeases: returns the dhcp leases information for a given virtual network. The information includes lease expirytime, MAC Address, IP Address, hostname and clientid.

[libvirt] [PATCH 3/4] net-dhcp-leases: Private implementation inside network driver

2013-09-11 Thread Nehal J Wani
By querying the driver for the path of the leases file for the given virtual network and parsing it to retrieve info. src/network/bridge_driver.c: * Implement networkGetDHCPLeases * Implement networkGetDHCPLeaseForMAC * Implement networkGetDHCPLeasesHelper --- src/network/bridge_driver.c

[libvirt] [PATCH 0/4] Introduce APIs to extract DHCP leases info

2013-09-11 Thread Nehal J Wani
. Return information for a particular network interface in a given virtual network by providing its MAC Address * The need for these APIs were result of a RFC was proposed on the list. Refer: http://www.redhat.com/archives/libvir-list/2013-July/msg01603.html Nehal J Wani (4): net-dhcp-leases

Re: [libvirt] rpmbuild libvirt 1.1.2 problem

2013-09-11 Thread Nehal J Wani
随身享! -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list Reproducible on Cent OS 6.4 x86_64 See attached log for details. -- Nehal J Wani PASS: virshtest PASS: sockettest PASS: nodeinfotest PASS: virbuftest PASS: commandtest PASS

Re: [libvirt] [PATCH 1/4] net-dhcp-leases: Implement the public APIs

2013-09-11 Thread Nehal J Wani
On Wed, Sep 11, 2013 at 9:25 PM, Daniel P. Berrange berra...@redhat.com wrote: On Wed, Sep 11, 2013 at 09:00:09PM +0530, Nehal J Wani wrote: diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index a47e33c..3885baf 100644 --- a/include/libvirt/libvirt.h.in +++ b

Re: [libvirt] [PATCH 2/4] net-dhcp-leases: Implement the remote protocol

2013-09-11 Thread Nehal J Wani
this function to some place in /src/util, so that code redundancy can be removed? -- Nehal J Wani -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv6 1/5] domifaddr: Implement the public APIs

2013-09-12 Thread Nehal J Wani
AGENT could mean too much than guest agent -- Nehal J Wani UG3, BTech CS+MS(CL) IIIT-Hyderabad http://commandlinewani.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] rpmbuild libvirt 1.1.2 problem

2013-09-12 Thread Nehal J Wani
Message - From: Martin Kletzander mklet...@redhat.com To: Nehal J Wani nehaljw.k...@gmail.com Cc: libvir-list libvir-list@redhat.com, jsjshaowen...@21cn.com Sent: Thursday, September 12, 2013 4:29:32 PM Subject: Re: [libvirt] rpmbuild libvirt 1.1.2 problem On 09/11/2013 07:18 PM, Nehal J

[libvirt] [PATCHv2 2/4] net-dhcp-leases: Implement the remote protocol

2013-09-12 Thread Nehal J Wani
Implement RPC calls for virNetworkGetDHCPLeases, virNetworkGetDHCPLeasesForMAC daemon/remote.c * Define remoteSerializeNetworkDHCPLeases, remoteDispatchNetworkGetDHCPLeases * Define remoteDispatchNetworkGetDHCPLeasesForMAC src/remote/remote_driver.c * Define

[libvirt] [PATCHv2 1/4] net-dhcp-leases: Implement the public APIs

2013-09-12 Thread Nehal J Wani
Introduce 3 new APIs, virNetworkGetDHCPLeases, virNetworkGetDHCPLeasesForMAC and virNetworkDHCPLeaseFree. * virNetworkGetDHCPLeases: returns the dhcp leases information for a given virtual network. The information includes lease expirytime, MAC Address, IP Address, hostname and

[libvirt] [PATCHv2 4/4] net-dhcp-leases: Add virsh support

2013-09-12 Thread Nehal J Wani
Use virNetworkGetDHCPLeases and virNetworkGetDHCPLeasesForMAC in virsh. The new feature supports the follwing methods: 1. Retrieve leases info for a given virtual network 2. Retrieve leases info for given network interface tools/virsh-domain-monitor.c * Introduce new command :

[libvirt] [PATCHv2 0/4] Introduce APIs to extract DHCP leases info

2013-09-12 Thread Nehal J Wani
://www.redhat.com/archives/libvir-list/2013-September/msg00620.html * The need for these APIs were result of a RFC was proposed on the list. Refer: http://www.redhat.com/archives/libvir-list/2013-July/msg01603.html Nehal J Wani (4): net-dhcp-leases: Implement the public APIs net-dhcp-leases: Implement

Re: [libvirt] [PATCHv2 3/4] net-dhcp-leases: Private implementation inside network driver

2013-09-13 Thread Nehal J Wani
Just realized that obj should be non-null. Small diff to fix this: diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 2cdea56..3e93893 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -3020,7 +3020,8 @@ networkGetDHCPLeases(virNetworkPtr

[libvirt] [PATCHv2 3/4] net-dhcp-leases: Private implementation inside network driver

2013-09-13 Thread Nehal J Wani
By querying the driver for the path of the leases file for the given virtual network and parsing it to retrieve info. src/network/bridge_driver.c: * Implement networkGetDHCPLeases * Implement networkGetDHCPLeasesForMAC * Implement networkGetDHCPLeasesHelper --- src/network/bridge_driver.c

[libvirt] [PATCHv3 0/4] Introduce APIs to extract DHCP leases info

2013-09-15 Thread Nehal J Wani
of a RFC was proposed on the list. Refer: http://www.redhat.com/archives/libvir-list/2013-July/msg01603.html Nehal J Wani (4): net-dhcp-leases: Implement the public APIs net-dhcp-leases: Implement the remote protocol net-dhcp-leases: Private implementation inside network driver net-dhcp

[libvirt] [PATCHv3 1/4] net-dhcp-leases: Implement the public APIs

2013-09-15 Thread Nehal J Wani
Introduce 3 new APIs, virNetworkGetDHCPLeases, virNetworkGetDHCPLeasesForMAC and virNetworkDHCPLeaseFree. * virNetworkGetDHCPLeases: returns the dhcp leases information for a given virtual network. The information includes lease expirytime, MAC Address, IP Address (with type and

[libvirt] [PATCHv3 3/4] net-dhcp-leases: Private implementation inside network driver

2013-09-15 Thread Nehal J Wani
By querying the driver for the path of the leases file for the given virtual network and parsing it to retrieve info. src/network/bridge_driver.c: * Implement networkGetDHCPLeases * Implement networkGetDHCPLeasesForMAC * Implement networkGetDHCPLeasesHelper --- src/network/bridge_driver.c

[libvirt] [PATCHv3 2/4] net-dhcp-leases: Implement the remote protocol

2013-09-15 Thread Nehal J Wani
Implement RPC calls for virNetworkGetDHCPLeases, virNetworkGetDHCPLeasesForMAC daemon/remote.c * Define remoteSerializeNetworkDHCPLeases, remoteDispatchNetworkGetDHCPLeases * Define remoteDispatchNetworkGetDHCPLeasesForMAC src/remote/remote_driver.c * Define

[libvirt] [PATCHv3 4/4] net-dhcp-leases: Add virsh support

2013-09-15 Thread Nehal J Wani
Use virNetworkGetDHCPLeases and virNetworkGetDHCPLeasesForMAC in virsh. The new feature supports the follwing methods: 1. Retrieve leases info for a given virtual network 2. Retrieve leases info for given network interface tools/virsh-domain-monitor.c * Introduce new command :

Re: [libvirt] [PATCHv3 1/4] net-dhcp-leases: Implement the public APIs

2013-09-16 Thread Nehal J Wani
On Mon, Sep 16, 2013 at 3:22 PM, Daniel P. Berrange berra...@redhat.com wrote: On Mon, Sep 16, 2013 at 11:19:13AM +0530, Nehal J Wani wrote: +int +virNetworkGetDHCPLeasesForMAC(virNetworkPtr network, + const char *mac

Re: [libvirt] [PATCHv3 1/4] net-dhcp-leases: Implement the public APIs

2013-09-16 Thread Nehal J Wani
PFA: Diff On Mon, Sep 16, 2013 at 8:44 PM, Nehal J Wani nehaljw.k...@gmail.com wrote: On Mon, Sep 16, 2013 at 3:22 PM, Daniel P. Berrange berra...@redhat.com wrote: On Mon, Sep 16, 2013 at 11:19:13AM +0530, Nehal J Wani wrote: +int +virNetworkGetDHCPLeasesForMAC(virNetworkPtr network

[libvirt] [PATCH] Add helper program to create custom leases

2013-12-19 Thread Nehal J Wani
of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * http://www.gnu.org/licenses/. + * + * Author: Nehal J Wani

[libvirt] [PATCH] Fix memory leak in testDomainCreateXMLMixed()

2014-01-14 Thread Nehal J Wani
While running objecteventtest, it was found that valgrind pointed out the following memory leak: ==13025== 538 (56 direct, 482 indirect) bytes in 1 blocks are definitely lost in loss record 216 of 226 ==13025==at 0x4A06B6F: calloc (vg_replace_malloc.c:593) ==13025==by 0x4C65D8D:

Re: [libvirt] [PATCH] Add helper program to create custom leases

2014-01-14 Thread Nehal J Wani
Ignore this. It has missing lines for compilation and addition in network driver. I am sending Patch v2. On Thu, Dec 19, 2013 at 1:09 PM, Nehal J Wani nehaljw.k...@gmail.com wrote: Introduce helper program to catch events from dnsmasq and maintain a custom lease file per network. It supports

[libvirt] [PATCH v2] Add helper program to create custom leases

2014-01-14 Thread Nehal J Wani
+ * http://www.gnu.org/licenses/. + * + * Author: Nehal J Wani nehaljw.k...@gmail.com + * + */ + +#include config.h + +#include stdio.h +#include stdlib.h + +#include virutil.h +#include virthread.h +#include virfile.h +#include virbuffer.h +#include virstring.h +#include virerror.h +#include viralloc.h

Re: [libvirt] [PATCH v2] Add helper program to create custom leases

2014-01-16 Thread Nehal J Wani
On Thu, Jan 16, 2014 at 9:07 AM, Doug Goldstein car...@cardoe.com wrote: On Jan 14, 2014, at 2:09 PM, Nehal J Wani nehaljw.k...@gmail.com wrote: Introduce helper program to catch events from dnsmasq and maintain a custom lease file per network. It supports DHCPv4 and DHCPv6. The file is saved

Re: [libvirt] [PATCH v2] Add helper program to create custom leases

2014-01-27 Thread Nehal J Wani
as the format for storing leases. -- Nehal J Wani -- Nehal J Wani -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v2] Add helper program to create custom leases

2014-01-27 Thread Nehal J Wani
PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * http://www.gnu.org/licenses/. + * + * Author: Nehal J Wani nehaljw.k...@gmail.com

Re: [libvirt] [PATCH v2] Add helper program to create custom leases

2014-02-02 Thread Nehal J Wani
On Mon, Jan 27, 2014 at 2:17 PM, Nehal J Wani nehaljw.k...@gmail.com wrote: Introduce helper program to catch events from dnsmasq and maintain a custom lease file per network. It supports dhcpv4 and dhcpv6. The file is saved as interface-name.status. Each lease contains the following info

[libvirt] [PATCH] Fix memory leak in virDomainSnapshotDiskDefClear()

2014-02-22 Thread Nehal J Wani
While running domainsnapshotxml2xmltest, it was found that valgrind pointed out the following memory leaks: ==32176== 42 (32 direct, 10 indirect) bytes in 1 blocks are definitely lost in loss record 42 of 66 ==32176==at 0x4A069EE: malloc (vg_replace_malloc.c:270) ==32176==by 0x4A06B62:

[libvirt] [PATCH] Fix memory leak in virSCSIDeviceListDel()

2014-02-22 Thread Nehal J Wani
While running virscsitest, it was found that valgrind pointed out the following memory leak: ==320== 5 bytes in 1 blocks are definitely lost in loss record 4 of 37 ==320==at 0x4A069EE: malloc (vg_replace_malloc.c:270) ==320==by 0x3E6CE81171: strdup (strdup.c:43) ==320==by 0x4CB28DF:

[libvirt] [PATCH v3] Add helper program to create custom leases

2014-02-24 Thread Nehal J Wani
://www.gnu.org/licenses/. + * + * Author: Nehal J Wani nehaljw.k...@gmail.com + */ + +#include config.h + +#include stdio.h +#include stdlib.h +#include sys/stat.h + +#include virutil.h +#include virthread.h +#include virfile.h +#include virbuffer.h +#include virstring.h +#include virerror.h +#include viralloc.h

Re: [libvirt] [PATCH v3] Add helper program to create custom leases

2014-03-03 Thread Nehal J Wani
On Mon, Feb 24, 2014 at 5:27 PM, Nehal J Wani nehaljw.k...@gmail.com wrote: Introduce helper program to catch events from dnsmasq and maintain a custom lease file per network. It supports dhcpv4 and dhcpv6. The file is saved as interface-name.status. Each lease contains the following info

Re: [libvirt] [PATCH] Fix memory leak in virDomainSnapshotDiskDefClear()

2014-03-03 Thread Nehal J Wani
this function is called? -- Nehal J Wani -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3] Add helper program to create custom leases

2014-03-10 Thread Nehal J Wani
On Tue, Mar 4, 2014 at 12:18 AM, Nehal J Wani nehaljw.k...@gmail.com wrote: On Mon, Feb 24, 2014 at 5:27 PM, Nehal J Wani nehaljw.k...@gmail.com wrote: Introduce helper program to catch events from dnsmasq and maintain a custom lease file per network. It supports dhcpv4 and dhcpv6. The file

Re: [libvirt] [PATCHv3 2/4] net-dhcp-leases: Implement the remote protocol

2013-09-16 Thread Nehal J Wani
+static int +remoteSerializeNetworkDHCPLeases(virNetworkDHCPLeasesPtr *leases, + int nleases, + remote_network_get_dhcp_leases_ret *ret) +{ +size_t i; + +if (nleases REMOTE_NETWORK_DHCP_LEASES_MAX) { +

Re: [libvirt] [PATCHv3 1/4] net-dhcp-leases: Implement the public APIs

2013-09-16 Thread Nehal J Wani
On Mon, Sep 16, 2013 at 8:55 PM, Daniel P. Berrange berra...@redhat.com wrote: On Mon, Sep 16, 2013 at 08:45:09PM +0530, Nehal J Wani wrote: PFA: Diff On Mon, Sep 16, 2013 at 8:44 PM, Nehal J Wani nehaljw.k...@gmail.com wrote: On Mon, Sep 16, 2013 at 3:22 PM, Daniel P. Berrange berra

Re: [libvirt] [PATCH] build: ensure 'make check' sees up-to-date config.h

2013-09-23 Thread Nehal J Wani
On Thu, Sep 19, 2013 at 4:02 AM, Eric Blake ebl...@redhat.com wrote: Nehal J. Wani reported on IRC a rather interesting build failure: In file included from util/virnetdevbridge.c:53:0: /usr/include/linux/in6.h:30:8: error: redefinition of 'struct in6_addr' struct in6_addr { ^ I

Re: [libvirt] [PATCH] build: ensure 'make check' sees up-to-date config.h

2013-09-23 Thread Nehal J Wani
On Mon, Sep 23, 2013 at 9:13 PM, Eric Blake ebl...@redhat.com wrote: On 09/23/2013 09:07 AM, Nehal J Wani wrote: On Thu, Sep 19, 2013 at 4:02 AM, Eric Blake ebl...@redhat.com wrote: Nehal J. Wani reported on IRC a rather interesting build failure: In file included from util/virnetdevbridge.c

[libvirt] [PATCHv4 0/4] Introduce APIs to extract DHCP leases info

2013-09-26 Thread Nehal J Wani
-September/msg00732.html v1 * Refer: https://www.redhat.com/archives/libvir-list/2013-September/msg00620.html * The need for these APIs were result of a RFC was proposed on the list. Refer: http://www.redhat.com/archives/libvir-list/2013-July/msg01603.html Nehal J Wani (4): net-dhcp-leases

[libvirt] [PATCHv4 2/4] net-dhcp-leases: Implement the remote protocol

2013-09-26 Thread Nehal J Wani
Implement RPC calls for virNetworkGetDHCPLeases, virNetworkGetDHCPLeasesForMAC daemon/remote.c * Define remoteSerializeNetworkDHCPLeases, remoteDispatchNetworkGetDHCPLeases * Define remoteDispatchNetworkGetDHCPLeasesForMAC * Define helper function make_dhcp_lease

[libvirt] [PATCHv4 3/4] net-dhcp-leases: Private implementation inside network driver

2013-09-26 Thread Nehal J Wani
By querying the driver for the path of the leases file for the given virtual network and parsing it to retrieve info. src/network/bridge_driver.c: * Implement networkGetDHCPLeases * Implement networkGetDHCPLeasesForMAC * Implement networkGetDHCPLeasesHelper --- src/network/bridge_driver.c | 240

[libvirt] [PATCHv4 1/4] net-dhcp-leases: Implement the public APIs

2013-09-26 Thread Nehal J Wani
Introduce 3 new APIs, virNetworkGetDHCPLeases, virNetworkGetDHCPLeasesForMAC and virNetworkDHCPLeaseFree. * virNetworkGetDHCPLeases: returns the dhcp leases information for a given virtual network. For DHCPv4, the information includes: - Expirytime - MAC Address - IPv4

[libvirt] [PATCHv4 4/4] net-dhcp-leases: Add virsh support

2013-09-26 Thread Nehal J Wani
Use virNetworkGetDHCPLeases and virNetworkGetDHCPLeasesForMAC in virsh. The new feature supports the follwing methods: 1. Retrieve leases info for a given virtual network 2. Retrieve leases info for given network interface tools/virsh-domain-monitor.c * Introduce new command :

Re: [libvirt] [PATCHv4 1/4] net-dhcp-leases: Implement the public APIs

2013-10-01 Thread Nehal J Wani
Since we have lost the train for 1.1.3, changes in a/src/libvirt_public.syms attached. -- Nehal J Wani UG3, BTech CS+MS(CL) IIIT-Hyderabad 1.diff Description: Binary data -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv4 2/4] net-dhcp-leases: Implement the remote protocol

2013-10-01 Thread Nehal J Wani
In accordance with latest changes in rules for making building src/remote_protocol-structs, diff attached. -- Nehal J Wani UG3, BTech CS+MS(CL) IIIT-Hyderabad 2.diff Description: Binary data -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv4 3/4] net-dhcp-leases: Private implementation inside network driver

2013-10-01 Thread Nehal J Wani
Removing redundant if, diff attached. -- Nehal J Wani UG3, BTech CS+MS(CL) IIIT-Hyderabad 3.diff Description: Binary data -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv4 4/4] net-dhcp-leases: Add virsh support

2013-10-01 Thread Nehal J Wani
In accordance with latest rule: use VIR_STRDUP instead of virAsprintf with %s Diff attached. -- Nehal J Wani UG3, BTech CS+MS(CL) IIIT-Hyderabad 4.diff Description: Binary data -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv4 4/4] net-dhcp-leases: Add virsh support

2013-10-01 Thread Nehal J Wani
Rectified attachment. -- Nehal J Wani UG3, BTech CS+MS(CL) IIIT-Hyderabad 4.diff Description: Binary data -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv4 1/4] net-dhcp-leases: Implement the public APIs

2013-10-01 Thread Nehal J Wani
Rectified attachment. -- Nehal J Wani UG3, BTech CS+MS(CL) IIIT-Hyderabad 1.diff Description: Binary data -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv4 3/4] net-dhcp-leases: Private implementation inside network driver

2013-10-01 Thread Nehal J Wani
Rectified attachment. -- Nehal J Wani UG3, BTech CS+MS(CL) IIIT-Hyderabad 3.diff Description: Binary data -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv4 2/4] net-dhcp-leases: Implement the remote protocol

2013-10-01 Thread Nehal J Wani
Rectified attachment. -- Nehal J Wani UG3, BTech CS+MS(CL) IIIT-Hyderabad 2.diff Description: Binary data -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv4 1/4] net-dhcp-leases: Implement the public APIs

2013-10-01 Thread Nehal J Wani
we should be supporting DHCPv6 or not, and how should IAID be exposed, if we do. -- Nehal J Wani UG3, BTech CS+MS(CL) IIIT-Hyderabad -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv4 1/4] net-dhcp-leases: Implement the public APIs

2013-10-01 Thread Nehal J Wani
, it might be difficult to add it in the future by modifying the API. To understand the format for DHCPv6 better, one can follow the conversation: http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2013q3/007538.html and the RFC: https://tools.ietf.org/html/rfc3315 -- Nehal J Wani -- libvir

Re: [libvirt] [PATCHv4 1/4] net-dhcp-leases: Implement the public APIs

2013-10-02 Thread Nehal J Wani
On Wed, Oct 2, 2013 at 1:43 PM, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Oct 01, 2013 at 05:39:02PM -0600, Eric Blake wrote: On 09/26/2013 02:08 AM, Nehal J Wani wrote: Introduce 3 new APIs, virNetworkGetDHCPLeases, virNetworkGetDHCPLeasesForMAC and virNetworkDHCPLeaseFree

  1   2   3   >