Re: [Libvir] Patch for routed virtual networks

physically separated in which case the bridge will need to proxy the arp requests for hosts on the one side to hosts on the other side (and vice versa, obviously). -- Soren Hansen | Virtualisation specialist | Ubuntu Server Team Canonical Ltd. | http://www.ubuntu.com

[Libvir] [PATCH] Ancient libparted

PED_PARTITION_PROTECTED) content = protected; +#endif else content = data; } -- Soren Hansen | Virtualisation specialist | Ubuntu Server Team Canonical Ltd. | http://www.ubuntu.com/ signature.asc Description: Digital signature

[Libvir] [PATCH] Add bus attribute to disk target definition

+ +++ src/util.h 2008-04-29 06:59:57 + @@ -92,4 +92,6 @@ int virParseMacAddr(const char* str, unsigned char *addr); +int virDiskNameToIndex(const char* str); + #endif /* __VIR_UTIL_H__ */ -- Soren Hansen | Virtualisation specialist | Ubuntu Server Team Canonical Ltd

Re: [Libvir] [PATCH] Allow selection of the NIC model in QEMU/KVM

{ struct { char ifname[BR_IFNAME_MAXLEN]; -- Soren Hansen | Virtualisation specialist | Ubuntu Server Team Canonical Ltd. | http://www.ubuntu.com/ signature.asc Description: Digital signature -- Libvir-list mailing list Libvir-list@redhat.com https

Re: [Libvir] [PATCH] Add bus attribute to disk target definition

': +case 'h': +case 'v': You need a case 's' there to allow for SCSI... Good point. I suppose I do so in qemudParseDiskXml as well (when checking the target). -- Soren Hansen | Virtualisation specialist | Ubuntu Server Team Canonical Ltd. | http://www.ubuntu.com

Re: [Libvir] [PATCH] Add bus attribute to disk target definition

that will be fixed at some point, and when that happy day comes, I've either guessed correctly as to how it will derive boot priorities and we won't have to fix anything, or I've guessed wrong, and then we'll be no worse off than if we didn't adopt this approach right now, AFAICS. -- Soren Hansen

[Libvir] make syntax-check fails with bzr checkouts

in in vc-list-files-maybe-fixed.log, which is the output after I patched vc-list-files. I tried CVS, too, and that also fails (see cvs-syntax-check.log). Is it only meant to work with git? [1]: http://bazaar.launchpad.net/~vcs-imports/libvirt/trunk -- Soren Hansen

Re: [Libvir] make syntax-check fails with bzr checkouts

${*:-*} -name Entries -print) /dev/null; fi else echo $0: Failed to determine type of version control used in `pwd` 12 -- Soren Hansen | Virtualisation specialist | Ubuntu Server Team Canonical Ltd. | http://www.ubuntu.com/ signature.asc Description: Digital

Re: [Libvir] make syntax-check fails with bzr checkouts

. If you care about the CVS-oriented cases, there are two more patches. Not really. :) It just popped up when I was trying to determine why my bzr case was failing. -- Soren Hansen | Virtualisation specialist | Ubuntu Server Team Canonical Ltd. | http://www.ubuntu.com

Re: [Libvir] PATCH: Support network interface model in Xen and QEMU driver

it causes. Somehow. :) -- Soren Hansen | Virtualisation specialist | Ubuntu Server Team Canonical Ltd. | http://www.ubuntu.com/ signature.asc Description: Digital signature -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir

Re: [Libvir] PATCH: Support network interface model in Xen and QEMU driver

caused and I have every intention of making sure it won't happen again. I myself have posted ideas more than 1 year before actually getting around to implementing them, so there's no requirement to follow through with code immediately :-) :) -- Soren Hansen | Virtualisation

Re: [Libvir] [PATCH] Add bus attribute to disk target definition

*addr); +int virDiskNameToIndex(const char* str); + #endif /* __VIR_UTIL_H__ */ -- Soren Hansen | Virtualisation specialist | Ubuntu Server Team Canonical Ltd. | http://www.ubuntu.com/ signature.asc Description: Digital signature -- Libvir-list mailing list Libvir

[libvirt] Re: [Libvir] make syntax-check fails with bzr checkouts

/*' $postprocess +elif test -d .bzr; then + test $postprocess = '' postprocess=| sed 's|^\./||' + eval exec bzr ls --versioned '$dir' $postprocess elif test -d CVS; then test $postprocess = '' postprocess=| sed 's|^\./||' if test -x build-aux/cvsu; then -- Soren Hansen

Re: [libvirt] Re: [Libvir] [PATCH] Add bus attribute to disk target definition

device, but we can revisit this when that day comes. Your patch looks fine to me. Oh, and thanks for doing all the test cases as well. I didn't want to get started on those until we had agreed on the logic that should be applied. -- Soren Hansen | Virtualisation specialist

Re: [libvirt] PATCH: Pass -name argument to QEMU

something like disk-drive in a descriptive text making libvirt think that -drive was a valid option. -- Soren Hansen | Virtualisation specialist | Ubuntu Server Team Canonical Ltd. | http://www.ubuntu.com/ signature.asc Description: Digital signature -- Libvir-list

Re: [libvirt] PATCH: Pass -name argument to QEMU

of -drive, so I coded defensively instead. :) What versions of QEmu does libvirt actually claim to support? If we only support recent versions, then we're probably fine. -- Soren Hansen | Virtualisation specialist | Ubuntu Server Team Canonical Ltd. | http://www.ubuntu.com

Re: [Libvir] [PATCH] Keyboard layout support for QEMU/KVM

%40codemonkey.wsforum_name=gtk-vnc-devel -- Soren Hansen Ubuntu Server Team http://www.ubuntu.com/ signature.asc Description: Digital signature -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] Don't treat pci_system_init failure as fatal if no PCI bus is present

there are plenty of valid virtualisation options that work there (LXC, UML, and QEmu spring to mind) https://bugzilla.redhat.com/show_bug.cgi?id=709471 Signed-off-by: Soren Hansen so...@linux2go.dk --- src/node_device/node_device_udev.c |2 +- 1 files changed, 1 insertions(+), 1 deletions

[libvirt] Eventtest unit test failure

:-/ -- Soren Hansen | Lead virtualisation engineer | Ubuntu Server Team Canonical Ltd. | http://www.ubuntu.com/ signature.asc Description: Digital signature -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Eventtest unit test failure

? Is there a known fix? -- Soren Hansen | Lead virtualisation engineer | Ubuntu Server Team Canonical Ltd. | http://www.ubuntu.com/ signature.asc Description: Digital signature -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir

[libvirt] [PATCH] Make virDomainGetXMLDesc output cache settings even if no special driverName is set

-by: Soren Hansen so...@linux2go.dk --- src/conf/domain_conf.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 96ba0b0..56c5239 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -4718,8 +4718,10

[libvirt] Improve heuristic for default guest architecture

) { xenXMError(conn, VIR_ERR_INTERNAL_ERROR, _(no supported architecture for os type '%s'), -- Soren Hansen | Lead Virtualisation Engineer | Ubuntu Server Team Canonical Ltd. | http://www.ubuntu.com/ signature.asc Description: Digital signature

[libvirt] Supporting dynamic bridge names

virNetworkBridgeInUse thinks the bridge name is in use. This should be easy to fix, though. I'm perfectly willing to work on this, but I'd like to get you guys' gut feeling on this first. -- Soren Hansen | Lead Virtualisation Engineer | Ubuntu Server Team Canonical Ltd

Re: [libvirt] Supporting dynamic bridge names

(virConnectPtr conn, const virNetworkObjListPtr nets, -- Soren Hansen | Lead Virtualisation Engineer | Ubuntu Server Team Canonical Ltd. | http://www.ubuntu.com/ -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman

Re: [libvirt] Supporting dynamic bridge names

virNetworkSetBridgeName(virConnectPtr conn, const virNetworkObjListPtr nets, -- Soren Hansen | Lead Virtualisation Engineer | Ubuntu Server Team Canonical Ltd. | http://www.ubuntu.com/ -- Libvir-list mailing list Libvir-list@redhat.com

[libvirt] [PATCH] Add ubd to the list of disk prefixes

virDiskNameToIndex has a list of disk name prefixes that it uses in the process of finding the disk's index. This list is missing ubd which is the disk prefix used for UML domains. Signed-off-by: Soren Hansen so...@linux2go.dk --- src/util/util.c |2 +- 1 files changed, 1 insertions(+), 1

Re: [libvirt] [PATCH] Add ubd to the list of disk prefixes

. so...@canonical.com is no longer valid, so I won't be submitting any more patches from that address. Let's go with so...@linux2go.dk as the primary one and leave so...@ubuntu.com as an alias. -- Soren Hansen so...@linux2go.dk Systems Architect, The Rackspace Cloud Ubuntu Developer -- libvir

[libvirt] [PATCH 1/3] Close fd's of persistent tap devices

When passing a NULL tapfd argument to brAddTap, we need to close the fd of the tap device. If we don't, libvirt will keep the fd open indefinitely and renders the the guest unable to configure its side of the tap device. Signed-off-by: Soren Hansen so...@linux2go.dk --- src/util/bridge.c |2

[libvirt] [PATCH 2/3] Make umlConnectTapDevice ask brAddTap for a persistent tap device.

This patch does two things: * It makes umlConnectTapDevice ask brAddTap for a persistent tap by passing it a NULL tapfd argument. * Stops umlConnectTapDevice from immediately dismantling the bridge it just set up. Signed-off-by: Soren Hansen so...@linux2go.dk --- src/uml/uml_conf.c

[libvirt] [PATCH 0/3] A couple of UML-related fixes

, but I'm not sure right now. Also, I've had problems connecting to the domain's console. These three patches seem to fix everything for me. Soren Hansen (3): Close fd's of persistent tap devices Make umlConnectTapDevice ask brAddTap for a persistent tap device. Remove wrong check for uml monitor

[libvirt] [PATCH 3/3] Remove wrong check for uml monitor response size

that. Signed-off-by: Soren Hansen so...@linux2go.dk --- src/uml/uml_driver.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/src/uml/uml_driver.c b/src/uml/uml_driver.c index 04493ba..9cf669f 100644 --- a/src/uml/uml_driver.c +++ b/src/uml/uml_driver.c @@ -737,10 +737,6

Re: [libvirt] [PATCH 2/3] Make umlConnectTapDevice ask brAddTap for a persistent tap device.

On 12-08-2010 14:20, Daniel P. Berrange wrote: -brShutdown(brctl); brShutdown doesn't touch the bridge device at all. This simply closes the socket file handle we used for talking to the kernel to create the bridge. Removing this causes an FD leak Hm, so it does. I'll put it back.

Re: [libvirt] [PATCH 3/3] Remove wrong check for uml monitor response size

really going to send a max sized datagram each time? I would have expected it to only send a datagram the size of the header + the length of the data. -- Soren Hansen so...@linux2go.dk Systems Architect, The Rackspace Cloud Ubuntu Developer -- libvir-list mailing list libvir-list@redhat.com https

Re: [libvirt] [PATCH 3/3] Remove wrong check for uml monitor response size

On Sun, Aug 15, 2010 at 11:08:43PM +0200, Soren Hansen wrote: Unless multiple threads are reading from the fd (?), I'm quite confident in my data. I dumped the whole monitor_response buffer right before and right after the recvfrom call along with the return value of recvfrom. I'll rerun

Re: [libvirt] [PATCH 3/3] Remove wrong check for uml monitor response size

On Mon, Aug 16, 2010 at 11:37:07AM +0200, Soren Hansen wrote: I'm running this on another kernel right now and I'm not seeing the problem. I'll try again with the kernel I used a couple of days ago. Ok, found the other kernel. Same diff as in my previous e-mail, same action. These are my

Re: [libvirt] [PATCH 3/3] Remove wrong check for uml monitor response size

On 16-08-2010 18:08, Eric Blake wrote: On 08/16/2010 03:54 AM, Soren Hansen wrote: 09:41:01.134: debug : umlMonitorCommand:698 : Run command 'config con0' 09:41:01.134: debug : umlMonitorCommand:733 : res.error: 6, res.extra: 0, res.length: 4096, res.data: 09:41:01.134: debug

Re: [libvirt] [PATCH 3/3] Remove wrong check for uml monitor response size

); + (struct sockaddr *)addr, addrlen)0; if (nbytes 0) { Henceforth, nbytes was 0. Sorry about the wasted brain cycles on this. -- Soren Hansen Ubuntu Developer http://www.ubuntu.com/ signature.asc Description: OpenPGP digital signature -- libvir-list mailing

Re: [libvirt] [PATCH 3/3] Remove wrong check for uml monitor response size

, this looks good. But before I write such a patch, I'm going to look in more details at your other reply. Let's just forget all about that one, shall we? Please? :) -- Soren Hansen Ubuntu Developer http://www.ubuntu.com/ signature.asc Description: OpenPGP digital signature -- libvir-list

Re: [libvirt] Add new API for accessing remote guest text console

to see? Perhaps such a list already exists and I just don't know about it? -- Soren Hansen Ubuntu Developer http://www.ubuntu.com/ -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Allow chardev of type 'file' for UML domains.

) { virReportSystemError(0, _(invalid length in reply %s), cmd); goto error; Whoops, this bit wasn't meant to be included. /me reposts without it. -- Soren Hansen Ubuntu Developer http://www.ubuntu.com/ signature.asc Description: OpenPGP digital signature -- libvir-list mailing list libvir

Re: [libvirt] [PATCH] Support virDomainAttachDevice and virDomainDetachDevice for disks in UML

the DeviceFlags variants at the same time. You can just do a dumb wrapper like QEMU driver does, for simplicity. Right you are. I misunderstood what those were for. -- Soren Hansen Ubuntu Developer http://www.ubuntu.com/ -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman

Re: [libvirt] [PATCH] Allow chardev of type 'file' for UML domains.

. There's no existing code which ever closes the FDs in keepfd after spawning UML later on in the function. True. I somehow thought virExecWhatever took care of that, but I see now that it doesn't, and I guess that would be troublesome. I'll handle this in the uml driver. -- Soren Hansen Ubuntu

[libvirt] [PATCH] Allow chardev of type 'file' for UML domains.

Like the comment suggested, we just open the file and pass the file descriptor to uml. The input stream is set to null, since I couldn't find any useful way to actually use a file for input for a chardev and this also mimics what e.g. QEmu does internally. Signed-off-by: Soren Hansen so

Re: [libvirt] [PATCH] Allow chardev of type 'file' for UML domains.

descriptor between FD_SETSIZE and _SC_OPEN_MAX that we don't want to close? -- Soren Hansen Ubuntu Developer http://www.ubuntu.com/ -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Allow chardev of type 'file' for UML domains.

likely have an array overflow / out of bounds, so just stop at FD_SETSIZE. Oh, of course. How silly of me. Thanks :) -- Soren Hansen Ubuntu Developer http://www.ubuntu.com/ -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] Allow chardev of type 'file' for UML domains.

Like the comment suggested, we just open the file and pass the file descriptor to uml. The input stream is set to null, since I couldn't find any useful way to actually use a file for input for a chardev and this also mimics what e.g. QEmu does internally. Signed-off-by: Soren Hansen so

Re: [libvirt] [PATCH 2/2] Support virDomainAttachDevice and virDomainDetachDevice for disks in UML

. :) -- Soren Hansen Ubuntu Developer http://www.ubuntu.com/ -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] Explicitly pass uml_dir argument to user-mode-linux

at the code, it seems it's meant to emit a warning, but alas, it doesn't for some reason. If running libvirtd from upstart, HOME is not set, so any system using upstart will need this change. Signed-off-by: Soren Hansen so...@linux2go.dk --- src/uml/uml_conf.c |4 ++-- 1 files changed, 2 insertions

Re: [libvirt] [PATCH] Explicitly pass uml_dir argument to user-mode-linux

On 25-08-2010 16:07, Cole Robinson wrote: On 08/25/2010 05:03 AM, Soren Hansen wrote: uml_dir overrides user-mode-linux's default of ~/.uml. This is needed for a couple of different reasons: I think this should also solve this long standing fedora/selinux bug: https://bugzilla.redhat.com

[libvirt] [PATCH] Use global directory as UML's monitorDir for privileged connections

For privileged UML connections (uml:///system), we shouldn't use root's home dir, but rather somewhre in /var/run/libvirt/uml. https://bugzilla.redhat.com/show_bug.cgi?id=499536 Signed-off-by: Soren Hansen so...@linux2go.dk --- src/uml/uml_driver.c | 12 1 files changed, 8

Re: [libvirt] [PATCH] Explicitly pass uml_dir argument to user-mode-linux

:///session. It integrates well with the existing, well-known uml-utilities (e.g. uml_mconsole domain name Just Works[tm]). -- Soren Hansen Ubuntu Developer http://www.ubuntu.com/ -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Use global directory as UML's monitorDir for privileged connections

/uml/lib' I understand your desire to be consistent, but I really think integrating well with existing management tools for the hypervisor (in this case uml-utilities) is more important. -- Soren Hansen Ubuntu Developer http://www.ubuntu.com/ -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] Explicitly pass uml_dir argument to user-mode-linux

On 25-08-2010 11:03, Soren Hansen wrote: uml_dir overrides user-mode-linux's default of ~/.uml. This is needed for a couple of different reasons: Any comments on this patch? It seems perfectly reasonable to me to get this in regardless of the outcome of this discussion: https

Re: [libvirt] [PATCH] Use global directory as UML's monitorDir for privileged connections

this. Excellent again. I'll make these adjustments. -- Soren Hansen Ubuntu Developer http://www.ubuntu.com/ -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] Use global directory as UML's monitorDir for privileged connections

For privileged UML connections (uml:///system), we shouldn't use root's home dir, but rather somewhere in /var/run/libvirt/uml-guest. https://bugzilla.redhat.com/show_bug.cgi?id=499536 Signed-off-by: Soren Hansen so...@linux2go.dk --- src/uml/uml_driver.c | 12 1 files changed, 8

[libvirt] [PATCH] Default to qemu:///system if accessible

, W_OK) so that users with access to the qemu:///system UNIX socket connect to that one by default instead of spawning a new libvirtd daemon. Signed-off-by: Soren Hansen so...@linux2go.dk --- src/remote/remote_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src

Re: [libvirt] [PATCH] Default to qemu:///system if accessible

(or to et-mgmt-tools) before (and if not, why not), but that's the lay of the land, and I've had nothing but good feedback on it. Now I just wanted to fix it properly (directly in libvirt) and get it upstream. It's certainly saved me a lot of typing. -- Soren Hansen Ubuntu Developer http

Re: [libvirt] [PATCH] Default to qemu:///system if accessible

it. -- Soren Hansen Ubuntu Developer http://www.ubuntu.com/ -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Default to qemu:///system if accessible

variable to do this, which is called LIBVIRT_DEFAULT_URI, by the way :) -- Soren Hansen Ubuntu Developer http://www.ubuntu.com/ -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Default to qemu:///system if accessible

On 06-09-2010 12:24, Daniel P. Berrange wrote: On Mon, Sep 06, 2010 at 12:16:40PM +0200, Soren Hansen wrote: On 06-09-2010 11:17, Daniel P. Berrange wrote: Our goal is to improve qemu://session's networking such that this isn't a reason to use qemu://system anymore Fair enough, but when

Re: [libvirt] [PATCH] Default to qemu:///system if accessible

On 06-09-2010 13:22, Daniel P. Berrange wrote: On Mon, Sep 06, 2010 at 01:07:34PM +0200, Soren Hansen wrote: On 06-09-2010 12:24, Daniel P. Berrange wrote: On Mon, Sep 06, 2010 at 12:16:40PM +0200, Soren Hansen wrote: On 06-09-2010 11:17, Daniel P. Berrange wrote: Our goal is to improve qemu

Re: [libvirt] [PATCH] Default to qemu:///system if accessible

for setting yourself up with access to qemu:///system disappears. When that motivation is gone, any admin worth his salt will immediately revoke said access (in the shared scenario) (since it's a gaping security hole) and voilà, libvirt will go back to using qemu:///session by default. -- Soren

[libvirt] [PATCH] Add nwfilter support to UML driver

Extend user-mode-linux driver to support nwfilter. Signed-off-by: Soren Hansen so...@linux2go.dk --- src/uml/uml_conf.c | 16 +--- src/uml/uml_driver.c |8 +++- 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/src/uml/uml_conf.c b/src/uml/uml_conf.c index

Re: [libvirt] [PATCH] Add nwfilter support to UML driver

On 07-09-2010 10:32, Daniel Veillard wrote: We are supposed to be in feature freeze mode this week, Apologies. I didn't realise. Where could I have learned this? -- Soren Hansen Ubuntu Developer http://www.ubuntu.com/ -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com

Re: [libvirt] [PATCH] [RFC] nwfilter: resolve deadlock between VM operations and filter update

I had trouble applying the patch (I think maybe Thunderbird may have fiddled with the formatting :( ), but after doing it manually, it works excellently. Thanks! -- Soren Hansen Ubuntu Developerhttp://www.ubuntu.com/ OpenStack Developer http://www.openstack.org/ -- libvir-list mailing list

[libvirt] [PATCH] Pass virSecurityManagerPtr to virSecurityDAC{Set, Restore}ChardevCallback

virSecurityDAC{Set,Restore}ChardevCallback expect virSecurityManagerPtr, but are passed virDomainObjPtr instead. This makes virSecurityDACSetChardevLabel set a wrong uid/gid on chardevs. This patch fixes this behaviour. Signed-off-by: Soren Hansen so...@linux2go.dk --- src/security