Re: [libvirt] [PATCH] Compressed save image format for Qemu.

2009-08-28 Thread Charles Duffy
If CPU time is one of the major disincentives towards use of compression -- any reason lzop wasn't included? $ time lzop ramsave ramsave.lzo real0m13.515s user0m7.500s sys 0m1.340s $ time gzip -c ramsave ramsave.gz real0m46.327s user0m37.690s sys 0m1.360s $ ls -lh

Re: [libvirt] [PATCH] Compressed save image format for Qemu.

2009-08-28 Thread Daniel P. Berrange
On Thu, Aug 27, 2009 at 05:47:13PM -0500, Charles Duffy wrote: If CPU time is one of the major disincentives towards use of compression -- any reason lzop wasn't included? Never heard of it before - if its useful to support it, then do send patches... $ time lzop ramsave ramsave.lzo real

Re: [libvirt] [PATCH] Compressed save image format for Qemu.

2009-08-17 Thread Chris Lalancette
Daniel P. Berrange wrote: On Thu, Aug 13, 2009 at 10:47:18AM +0200, Chris Lalancette wrote: Implement a compressed save image format for qemu. While ideally we would have the choice between compressed/non-compressed available to the libvirt API, unfortunately there is no flags parameter to

Re: [libvirt] [PATCH] Compressed save image format for Qemu.

2009-08-13 Thread Chris Lalancette
Daniel P. Berrange wrote: On Wed, Aug 12, 2009 at 12:21:48PM +0100, Mark McLoughlin wrote: On Wed, 2009-08-12 at 12:04 +0100, Daniel P. Berrange wrote: On Tue, Aug 11, 2009 at 01:25:59PM +0200, Chris Lalancette wrote: struct qemud_save_header { char magic[sizeof(QEMUD_SAVE_MAGIC)-1];

[libvirt] [PATCH] Compressed save image format for Qemu.

2009-08-13 Thread Chris Lalancette
Implement a compressed save image format for qemu. While ideally we would have the choice between compressed/non-compressed available to the libvirt API, unfortunately there is no flags parameter to the virDomainSave() API. Therefore, implement this as a qemu.conf option. Both gzip and bzip2

Re: [libvirt] [PATCH] Compressed save image format for Qemu.

2009-08-13 Thread Daniel P. Berrange
On Thu, Aug 13, 2009 at 10:47:18AM +0200, Chris Lalancette wrote: Implement a compressed save image format for qemu. While ideally we would have the choice between compressed/non-compressed available to the libvirt API, unfortunately there is no flags parameter to the virDomainSave() API.

Re: [libvirt] [PATCH] Compressed save image format for Qemu.

2009-08-12 Thread Daniel P. Berrange
On Tue, Aug 11, 2009 at 01:25:59PM +0200, Chris Lalancette wrote: Implement a compressed save image format for qemu. While ideally we would have the choice between compressed/non-compressed available to the libvirt API, unfortunately there is no flags parameter to the virDomainSave() API.

Re: [libvirt] [PATCH] Compressed save image format for Qemu.

2009-08-12 Thread Mark McLoughlin
On Wed, 2009-08-12 at 12:04 +0100, Daniel P. Berrange wrote: On Tue, Aug 11, 2009 at 01:25:59PM +0200, Chris Lalancette wrote: struct qemud_save_header { char magic[sizeof(QEMUD_SAVE_MAGIC)-1]; int version; int xml_len; int was_running; -int unused[16]; +

Re: [libvirt] [PATCH] Compressed save image format for Qemu.

2009-08-12 Thread Daniel P. Berrange
On Wed, Aug 12, 2009 at 12:21:48PM +0100, Mark McLoughlin wrote: On Wed, 2009-08-12 at 12:04 +0100, Daniel P. Berrange wrote: On Tue, Aug 11, 2009 at 01:25:59PM +0200, Chris Lalancette wrote: struct qemud_save_header { char magic[sizeof(QEMUD_SAVE_MAGIC)-1]; int version;

Re: [libvirt] [PATCH] Compressed save image format for Qemu.

2009-08-11 Thread Daniel P. Berrange
On Fri, Aug 07, 2009 at 03:56:29PM +0200, Chris Lalancette wrote: diff --git a/src/qemu_driver.c b/src/qemu_driver.c index 3c92635..b146330 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c Is part of the change missing ? Nothing is added the 'compressed' field to the struct

[libvirt] [PATCH] Compressed save image format for Qemu.

2009-08-11 Thread Chris Lalancette
Implement a compressed save image format for qemu. While ideally we would have the choice between compressed/non-compressed available to the libvirt API, unfortunately there is no flags parameter to the virDomainSave() API. Therefore, implement this as a qemu.conf option. Both gzip and bzip2

[libvirt] [PATCH] Compressed save image format for Qemu.

2009-08-07 Thread Chris Lalancette
Implement a compressed save image format for qemu. While ideally we would have the choice between compressed/non-compressed available to the libvirt API, unfortunately there is no flags parameter to the virDomainSave() API. Therefore, implement this as a qemu.conf option. Both gzip and bzip2

[libvirt] [PATCH] Compressed save image format for Qemu.

2009-08-07 Thread Chris Lalancette
Implement a compressed save image format for qemu. While ideally we would have the choice between compressed/non-compressed available to the libvirt API, unfortunately there is no flags parameter to the virDomainSave() API. Therefore, implement this as a qemu.conf option. Both gzip and bzip2