Re: Make doc broken - 1d9a73b13ee576d28c0f41f5b243f2ebb1ff9fcf

2011-10-24 Thread Graham Percival
On Sat, Oct 22, 2011 at 04:41:35PM +0200, David Kastrup wrote: Dingdingding. I don't think dev/staging should be _merged_, only fast-forwarded (do the merge using --ff-only). If it is not forwardable, the dev/staging master should rebase it on master (so that it becomes fast-forwardable) and

Re: Rename \markuplines to \markuplist (before running convert-ly) (issue 5312050)

2011-10-24 Thread m...@apollinemike.com
On Oct 23, 2011, at 11:26 PM, d...@gnu.org wrote: Reviewers: Bertrand Bordage, Message: On 2011/10/23 21:08:09, Bertrand Bordage wrote: LGTM. You'll be happy to know that Mike and I are currently trying to get rid of \markuplines, so that there will only be a \markup command. No, I am

Re: Make doc broken - 1d9a73b13ee576d28c0f41f5b243f2ebb1ff9fcf

2011-10-24 Thread Graham Percival
On Mon, Oct 24, 2011 at 08:53:16AM +0200, David Kastrup wrote: Graham Percival gra...@percival-music.ca writes: Hmm. At the moment, master and dev/staging cannot be combined (to use hopefully non-specific terminology) with --ff-only. Bertrand's 6ee8c04678442855cb794d4598c056c15c42673b

Re: Make doc broken - 1d9a73b13ee576d28c0f41f5b243f2ebb1ff9fcf

2011-10-24 Thread David Kastrup
Graham Percival gra...@percival-music.ca writes: On Mon, Oct 24, 2011 at 08:53:16AM +0200, David Kastrup wrote: Graham Percival gra...@percival-music.ca writes: Hmm. At the moment, master and dev/staging cannot be combined (to use hopefully non-specific terminology) with --ff-only.

Re: Rename \markuplines to \markuplist (before running convert-ly) (issue 5312050)

2011-10-24 Thread m...@apollinemike.com
On Oct 24, 2011, at 8:57 AM, David Kastrup wrote: m...@apollinemike.com m...@apollinemike.com writes: \markup { \column { \italic foo bar }} would use line as its layout manager and have two elements, one markup that used nothing as its layout manager (markups with 1 element cannot have

Re: [translations] Re: CG 5.8.3: updating committish of lsr snippets

2011-10-24 Thread Francisco Vila
2011/10/23 Federico Bruni fedel...@gmail.com: I've almost gave up here. I don't have skills nor time to spend on this issue, sorry. I understand it. It is probably my fault, to be unable of explaining it more clearly. _I_ am sorry. The attached patch fixes the bad object error. I have no

Re: musicexp.py: Fix for issue 1985 (issue 5303063)

2011-10-24 Thread reinhold . kainhofer
LGTM. http://codereview.appspot.com/5303063/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

\markup* and Guile V2 - was Re: Rename \markuplines to \markuplist (before running convert-ly) (issue 5312050)

2011-10-24 Thread Ian Hulin
Hi Bertrand, Mike, David, Reinhold and everyone in the \markup rewrite gang, Here is a bulletin from the Guile V2 migration cave. I am currently brewing a patch for Tracer 1686. The markup facility as written is a major PITA when running with Guile V2, and is currently blocking progress on this

Re: \markup* and Guile V2 - was Re: Rename \markuplines to \markuplist (before running convert-ly) (issue 5312050)

2011-10-24 Thread David Kastrup
Ian Hulin i...@hulin.org.uk writes: Hi Bertrand, Mike, David, Reinhold and everyone in the \markup rewrite gang, Here is a bulletin from the Guile V2 migration cave. I am currently brewing a patch for Tracer 1686. The markup facility as written is a major PITA when running with Guile V2,

convert-ly rules to destencil Flags

2011-10-24 Thread David Kastrup
Mike has pushed directly 671b7b63408893c33b4c1f196e87db19a7dbcd1e to master, as far as I can see without any discussion and without going through staging. I changed the rules somewhat in order make them get useful output for \once\override as well, and pushed this directly to master as a

Re: convert-ly rules to destencil Flags

2011-10-24 Thread m...@apollinemike.com
On Oct 24, 2011, at 4:29 PM, David Kastrup wrote: Mike has pushed directly 671b7b63408893c33b4c1f196e87db19a7dbcd1e to master, as far as I can see without any discussion and without going through staging. This got to patch push after going through a countdown. As for staging, I'm still

Re: convert-ly rules to destencil Flags

2011-10-24 Thread David Kastrup
m...@apollinemike.com m...@apollinemike.com writes: On Oct 24, 2011, at 4:29 PM, David Kastrup wrote: Mike has pushed directly 671b7b63408893c33b4c1f196e87db19a7dbcd1e to master, as far as I can see without any discussion and without going through staging. This got to patch push after

Re: convert-ly rules to destencil Flags

2011-10-24 Thread m...@apollinemike.com
On Oct 24, 2011, at 5:12 PM, David Kastrup wrote: m...@apollinemike.com m...@apollinemike.com writes: On Oct 24, 2011, at 4:29 PM, David Kastrup wrote: Mike has pushed directly 671b7b63408893c33b4c1f196e87db19a7dbcd1e to master, as far as I can see without any discussion and without

Re: convert-ly rules to destencil Flags

2011-10-24 Thread David Kastrup
m...@apollinemike.com m...@apollinemike.com writes: On Oct 24, 2011, at 5:12 PM, David Kastrup wrote: m...@apollinemike.com m...@apollinemike.com writes: On Oct 24, 2011, at 4:29 PM, David Kastrup wrote: Mike has pushed directly 671b7b63408893c33b4c1f196e87db19a7dbcd1e to master, as

Re: convert-ly rules to destencil Flags

2011-10-24 Thread m...@apollinemike.com
On Oct 24, 2011, at 5:29 PM, David Kastrup wrote: m...@apollinemike.com m...@apollinemike.com writes: On Oct 24, 2011, at 5:12 PM, David Kastrup wrote: m...@apollinemike.com m...@apollinemike.com writes: On Oct 24, 2011, at 4:29 PM, David Kastrup wrote: Mike has pushed directly

Re: convert-ly rules to destencil Flags

2011-10-24 Thread David Kastrup
m...@apollinemike.com m...@apollinemike.com writes: On Oct 24, 2011, at 5:29 PM, David Kastrup wrote: The problem is that eventually, somebody else _will_ run scripts/auxiliar/update-with-convert-ly and then those files get fixed again if the version string indicates they have not yet been

Does the LilyPond build generate shared libraries you can use with Guile (load-extension) ?

2011-10-24 Thread Ian Hulin
Hi all, Is there am easy way of generating a shared library with all the scheme definitions generated in code by the C++ macro LY_DEFINE and friends? I would like have a way of testing scheme files from the Guile repl. It would take some of the grief out of hacking for the Guile V2 scheme port

Horizontal spacing change between 2.15.9 and 2.15.10 (regression?)

2011-10-24 Thread Xavier Scheuer
Dear developers, I compiled yesterday (with 2.15.14) a file that was first compiled with 2.15.5. I was surprised to see that the default line breaks were quite different and some measures were really ugly (speaking of horizontal spacing) with the latest version! I have a passage with many 32th

Re: MetronomeMark #'break-align-symbols sometimes fails

2011-10-24 Thread Xavier Scheuer
On 14 October 2011 00:33, Kieren MacMillan kieren_macmil...@sympatico.ca wrote: This is a little frustrating, as it was part of a bounty fix from some time ago. I understand the ultimate fix is [apparently] difficult — and Neil generously gave me a hack to tweak certain issues, especially at

Re: convert-ly rules to destencil Flags

2011-10-24 Thread m...@apollinemike.com
On Oct 24, 2011, at 5:53 PM, David Kastrup wrote: m...@apollinemike.com m...@apollinemike.com writes: On Oct 24, 2011, at 5:29 PM, David Kastrup wrote: The problem is that eventually, somebody else _will_ run scripts/auxiliar/update-with-convert-ly and then those files get fixed again if

Re: MetronomeMark #'break-align-symbols sometimes fails

2011-10-24 Thread David Kastrup
Xavier Scheuer x.sche...@gmail.com writes: On 14 October 2011 00:33, Kieren MacMillan kieren_macmil...@sympatico.ca wrote: This is a little frustrating, as it was part of a bounty fix from some time ago. I understand the ultimate fix is [apparently] difficult — and Neil generously gave me

Re: convert-ly rules to destencil Flags

2011-10-24 Thread David Kastrup
m...@apollinemike.com m...@apollinemike.com writes: 3) When patches come out and are on review, especially when the patches go through the review cycle more than once, it'd be great if this sort of thing were addressed. Originally I didn't add convert-ly rules because I wasn't 100% sure on

Re: Horizontal spacing change between 2.15.9 and 2.15.10 (regression?)

2011-10-24 Thread m...@apollinemike.com
On Oct 24, 2011, at 8:44 PM, Xavier Scheuer wrote: Dear developers, I compiled yesterday (with 2.15.14) a file that was first compiled with 2.15.5. I was surprised to see that the default line breaks were quite different and some measures were really ugly (speaking of horizontal spacing)

Re: convert-ly rules to destencil Flags

2011-10-24 Thread David Kastrup
m...@apollinemike.com m...@apollinemike.com writes: I now see what the problem is. I had updated the version number all the snippets that needed updating, but all of the offending snippets are in the .tely files. The \version statement for these snippets is not in the snippets themselves (I

Uses convert-ly to update changes stemming from the creation of a Flag grob. (issue 5309059)

2011-10-24 Thread dak
Seems like my suggestion to update the version numbers of files with manual fixes (in a separate commit) in order not to get them updated again got lost, as well as the bit about rereading the diff for problems. http://codereview.appspot.com/5309059/diff/1/Documentation/es/learning/tweaks.itely

Re: Add support for custom ledger positions, using two new staff-symbol properties (issue 4974075)

2011-10-24 Thread k-ohara5a5a
One obvious change to get it to compile, and then it looks good to me. If you email me a patch from `git format-patch` I'll push it with you as author; otherwise I'll just push it after countdown. http://codereview.appspot.com/4974075/diff/33001/lily/staff-symbol.cc File lily/staff-symbol.cc

Fixes slope errors from incorrect X extents in Beam::print. (issue 5293060)

2011-10-24 Thread k-ohara5a5a
http://codereview.appspot.com/5293060/diff/2001/lily/beam.cc File lily/beam.cc (right): http://codereview.appspot.com/5293060/diff/2001/lily/beam.cc#newcode987 lily/beam.cc:987: Beam::calc_x_span (Grob *me_non_spanner, Grob *commonx) Why should the x-span of a line-broken beam depend on whether

Re: convert-ly rules to destencil Flags

2011-10-24 Thread m...@apollinemike.com
On Oct 24, 2011, at 5:12 PM, David Kastrup wrote: git fetch git rebase origin/dev/staging git push origin HEAD:dev/staging From the rebase command on my local branch, I got: fatal: Needed a single revision invalid upstream origin/dev/staging Any hints on what to do? Cheers, MS

Re: Uses convert-ly to update changes stemming from the creation of a Flag grob. (issue 5309059)

2011-10-24 Thread m...@apollinemike.com
On Oct 24, 2011, at 11:41 PM, d...@gnu.org wrote: Seems like my suggestion to update the version numbers of files with manual fixes (in a separate commit) in order not to get them updated again got lost, as well as the bit about rereading the diff for problems. I'll redo the patch - I

Re: convert-ly rules to destencil Flags

2011-10-24 Thread David Kastrup
m...@apollinemike.com m...@apollinemike.com writes: On Oct 24, 2011, at 5:12 PM, David Kastrup wrote: git fetch git rebase origin/dev/staging git push origin HEAD:dev/staging From the rebase command on my local branch, I got: fatal: Needed a single revision invalid upstream

Fix 1377: looser spacing for ragged-last-bottom. (issue 5241047)

2011-10-24 Thread k-ohara5a5a
LGTM and makes just about every output score look much better. http://codereview.appspot.com/5241047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: convert-ly rules to destencil Flags

2011-10-24 Thread m...@apollinemike.com
On Oct 25, 2011, at 7:08 AM, David Kastrup wrote: m...@apollinemike.com m...@apollinemike.com writes: On Oct 24, 2011, at 5:12 PM, David Kastrup wrote: git fetch git rebase origin/dev/staging git push origin HEAD:dev/staging From the rebase command on my local branch, I got: fatal:

Re: Fixes slope errors from incorrect X extents in Beam::print. (issue 5293060)

2011-10-24 Thread m...@apollinemike.com
On Oct 25, 2011, at 5:52 AM, k-ohara5...@oco.net wrote: http://codereview.appspot.com/5293060/diff/2001/lily/beam.cc File lily/beam.cc (right): http://codereview.appspot.com/5293060/diff/2001/lily/beam.cc#newcode987 lily/beam.cc:987: Beam::calc_x_span (Grob *me_non_spanner, Grob

Re: convert-ly rules to destencil Flags

2011-10-24 Thread m...@apollinemike.com
On Oct 24, 2011, at 11:05 PM, David Kastrup wrote: 2) A reminder in 10.9.5 to change versions when moving stuff to Documents/snippets/new would be great too. I am not sure whether that is not something Graham wants to do himself. However, I think it is harmless enough to do it on his