Han-Wen Nienhuys hanw...@gmail.com writes:
On Fri, Dec 16, 2011 at 3:46 PM, Ian Hulin i...@hulin.org.uk wrote:
Why can't the validation procedure look in multiple places?
Because this means serious fiddling with the maoing markup code. I
really hope you didn't write it because I agree
Original Message
Subject:Re: Markup module patch (Issue 2026)
Date: Mon, 19 Dec 2011 11:54:29 +
From: Ian Hulin i...@hulin.org.uk
To: han...@xs4all.nl
CC: Han-Wen Nienhuys hanw...@gmail.com, nicolas.sce...@gmail.com
Hi Han-Wen,
On 19/12/11 02:52,
Hi Werner,
On 19/12/11 05:47, Werner LEMBERG wrote:
So either I interpret something wrong into what you are saying, or
you interpret something wrong into what the Guile developers are
saying, or the Guile developers interpret something wrong into what
usability should be saying. Or a bit of
Ian Hulin i...@hulin.org.uk writes:
For example, there is a lot of discussion on guile-developers on how
to support a feature which has been deprecated (local-eval), and it
turns out it was useful to David K in his parser spring-clean, so I
flagged it with Guile and it's now in their
Reviewers: Graham Percival,
Message:
Please review
Description:
Directs output of texi2html to log files (GOP 9) for translated docs.
There is a slight gotcha with this change, that if there is an error in
running texi2html, then the dev has to know to look at the relevant log
file. However,
On my build Ubuntu machine, make is currently failing with the following
output:
/home/phil/lilypond-git/lily/score-engraver.cc: In member function 'virtual
void Score_engraver::announce_grob(Grob_info)':
/home/phil/lilypond-git/lily/score-engraver.cc:164: error:
'VALGRIND_PRINTF_BACKTRACE'
Phil Holmes em...@philholmes.net writes:
On my build Ubuntu machine, make is currently failing with the
following output:
/home/phil/lilypond-git/lily/score-engraver.cc: In member function
virtual void Score_engraver::announce_grob(Grob_info)':
On Dec 19, 2011, at 6:25 PM, Phil Holmes wrote:
- Original Message - From: David Kastrup d...@gnu.org
To: lilypond-devel@gnu.org
Sent: Monday, December 19, 2011 5:04 PM
Subject: Re: Make failing
Phil Holmes em...@philholmes.net writes:
On my build Ubuntu machine, make is
- Original Message -
From: m...@apollinemike.com
To: Phil Holmes m...@philholmes.net
Cc: lilypond-devel@gnu.org; David Kastrup d...@gnu.org
Sent: Monday, December 19, 2011 5:29 PM
Subject: Re: Make failing
On Dec 19, 2011, at 6:25 PM, Phil Holmes wrote:
- Original Message -
On 13/12/11 19:56, Ian Hulin wrote:
Hi all, The patch had to get pulled from staging as although it
passed reg. tests it wouldn't compile the doc. I can easily fix
the snippet in /Documentation/snippets/three-sided-box.ly, but this
leaves one more problem in the docs, this time in
On Mon, Dec 19, 2011 at 06:04:36PM +0100, David Kastrup wrote:
Phil Holmes em...@philholmes.net writes:
/home/phil/lilypond-git/lily/score-engraver.cc: In member function
virtual void Score_engraver::announce_grob(Grob_info)':
/home/phil/lilypond-git/lily/score-engraver.cc:164: error:
Ian Hulin i...@hulin.org.uk writes:
On 13/12/11 19:56, Ian Hulin wrote:
Hi all, The patch had to get pulled from staging as although it
passed reg. tests it wouldn't compile the doc. I can easily fix
the snippet in /Documentation/snippets/three-sided-box.ly, but this
leaves one more problem
Phil Holmes m...@philholmes.net writes:
David or Graham are probably better able to comment, but it seems to
me we need a patch pushed to master to get that back in shape.
staging moves to master fast enough, I should think. Too bad Patchy is
not running on a minimal system.
--
David
- Original Message -
From: Graham Percival gra...@percival-music.ca
To: David Kastrup d...@gnu.org
Cc: lilypond-devel@gnu.org
Sent: Monday, December 19, 2011 5:58 PM
Subject: Re: Make failing
On Mon, Dec 19, 2011 at 06:04:36PM +0100, David Kastrup wrote:
Phil Holmes
LGTM
http://codereview.appspot.com/5489072/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Hi Ian,
I feel pretty much unqualified to comment on this, since the details are
way over my head. Since it works (and you've tested it on both 1.8 and
2), I assume that most things about it are OK.
I have a couple of questions:
1) How do we decide when we need to include (use-modules (scm
On 2011/12/19 19:38:04, Carl wrote:
1) How do we decide when we need to include (use-modules (scm
markup-facility-defs)) in our input files? Is it to be included any
time we
define our own markup commands?
I feel rather strongly that this should not be required in user LilyPond
files but
Phil Holmes m...@philholmes.net writes:
Yeah - warning: valgrind.h. No such file or directory.
That's a _warning_ rather than an error? Crazy.
--
David Kastrup
___
lilypond-devel mailing list
lilypond-devel@gnu.org
On Sun, 18 Dec 2011 23:31:23 -0800, m...@apollinemike.com
m...@apollinemike.com wrote:
And while you're at it, in the same patch, could you try removing line 170 from
hairpin.cc (the if condition for direction equaling left)
That would pull the hairpin back from the entire non-musical
On 2011/12/19 16:37:10, PhilEHolmes wrote:
Please review
Hi Phil,
I was just looking at the translated manuals recently, please see
http://code.google.com/p/lilypond/issues/detail?id=2125
Among the suggested changes in issue 2125 is to remove all the TEXI2HTML
calls in
patch rebased
http://codereview.appspot.com/5434061/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On Mon, Dec 19, 2011 at 08:21:32PM +0100, David Kastrup wrote:
Phil Holmes m...@philholmes.net writes:
Yeah - warning: valgrind.h. No such file or directory.
That's a _warning_ rather than an error? Crazy.
I'd be *overjoyed* to make patchy compile with -Werror, but it'll
probably take
http://codereview.appspot.com/5464045/diff/2001/Documentation/snippets/three-sided-box.ly
File Documentation/snippets/three-sided-box.ly (right):
http://codereview.appspot.com/5464045/diff/2001/Documentation/snippets/three-sided-box.ly#newcode20
Documentation/snippets/three-sided-box.ly:20:
On 2011/12/19 20:34:31, mail_philholmes.net wrote:
- Original Message -
From: mailto:julien.ri...@gmail.com
To: philehol...@googlemail.com; mailto:gra...@percival-music.ca
Cc: re...@codereview-hr.appspotmail.com;
mailto:lilypond-devel@gnu.org
Sent: Monday, December 19, 2011 8:23 PM
- Original Message -
From: julien.ri...@gmail.com
To: philehol...@googlemail.com; gra...@percival-music.ca
Cc: re...@codereview-hr.appspotmail.com; lilypond-devel@gnu.org
Sent: Monday, December 19, 2011 8:23 PM
Subject: Re: Directs output of texi2html to log files (GOP 9) (issue
Hi,
I've finished the draft of the lilypond language file for
source-highlight (task 1 of issue 1005):
http://code.google.com/p/lilypond/issues/detail?id=1005
I need some feedback and tips from you, please test it.
How-to
==
You must install the source-highlight package.
You don't
Reviewers: ,
Message:
This could possibly fix the recurring issues with parallel make. However
if `make -jX' does not obey the .SECONDARY: construct then we are not
any better off.
Description:
Build: Try to convince `make' to keep intermediate files.
Possible fix to issue 1906.
Please review
I seem to recall that spaces were going to be used instead of tabs
wherever possible in source files. Is there a reason that parser.yy
uses tabs instead of spaces?
--
Michael Welsh Duggan
(m...@md5i.com)
___
lilypond-devel mailing list
On Mon, Dec 19, 2011 at 08:04:49PM -0500, Michael Welsh Duggan wrote:
I seem to recall that spaces were going to be used instead of tabs
wherever possible in source files. Is there a reason that parser.yy
uses tabs instead of spaces?
I didn't run astyle on parser.yy because the extension
wow, I'd love to enable -Werror!
You'll probably find a ton of more errors when running 'make check' --
apparently that compiles some stuff in flower/ that isn't compiled
during a normal make.
http://codereview.appspot.com/5489092/diff/1/lily/beaming-pattern.cc
File lily/beaming-pattern.cc
http://codereview.appspot.com/5489092/diff/1/lily/beaming-pattern.cc
File lily/beaming-pattern.cc (right):
http://codereview.appspot.com/5489092/diff/1/lily/beaming-pattern.cc#newcode187
lily/beaming-pattern.cc:187: I64 count = 1; //default -- 1 base moments
in a beam
On 2011/12/20 01:54:29,
On 2011/12/20 01:54:29, Graham Percival wrote:
You'll probably find a ton of more errors when running 'make check' --
apparently that compiles some stuff in flower/ that isn't compiled
during a
normal make.
In point of fact, I found no additional errors when running make check.
Please
This patch will collide with the outstanding patch fixing beaming, as
the variables have changed and are treated as int.
Personally, I see no reason to use I64 instead of int. Neil Puttock
changed the numerator and denominators to be I64 in 2008, with commit
Reviewers: ,
Message:
I'm abandoning this because it is not efficient for me to work on this
given my limited understanding of Scheme and of LilyPond's
bootstrapping.
Description:
Add support for easier use of arrowed accidentals and retuning
Please review this at
34 matches
Mail list logo
