Reviewers: dak, Graham Percival, Trevor Daniels, J_lowe,
Message:
Please review - especially changes to Documentation/notation/wind.itely
Description:
This patch has a couple of files from the LSR, which had minor changes
from my last LSR patch. I've included them to keep the system in step.
Hey all,
I see a shortcut for utf-8-strings in pango-font.cc. This is all well and good
except that it is hard to do box approximations on these guys (it'd require
adding lots of code). How mad would LilyPond be if I just deleted all of the
utf-8-string business? I don't think it'd change
http://codereview.appspot.com/5636048/diff/1/Documentation/snippets/new/woodwind-diagrams-key-lists.ly
File Documentation/snippets/new/woodwind-diagrams-key-lists.ly (right):
http://codereview.appspot.com/5636048/diff/1/Documentation/snippets/new/woodwind-diagrams-key-lists.ly#newcode16
- Original Message -
From: d...@gnu.org
To: philehol...@googlemail.com; gra...@percival-music.ca;
tdanielsmu...@googlemail.com; pkx1...@gmail.com
Cc: re...@codereview-hr.appspotmail.com; lilypond-devel@gnu.org
Sent: Monday, February 06, 2012 1:28 PM
Subject: Re: Stops woodwind diagram
On 2012/02/06 14:07:54, mail_philholmes.net wrote:
I didn't do that because I had no idea it would work. As a snippet, I
think
it's easier to leave as is because the average user (e.g. me) would
not
understand the lambda stuff.
Well, the thing is that you could also write
http://codereview.appspot.com/5633048/diff/1/Documentation/changes.tely
File Documentation/changes.tely (right):
http://codereview.appspot.com/5633048/diff/1/Documentation/changes.tely#newcode67
Documentation/changes.tely:67: following stencil commands have been
suppressed:
removed or
- Original Message -
From: Graham Percival gra...@percival-music.ca
To: Phil Holmes em...@philholmes.net
Cc: Devel lilypond-devel@gnu.org
Sent: Sunday, February 05, 2012 2:20 PM
Subject: Re: Where to document patchy?
On Sun, Feb 05, 2012 at 02:15:31PM -, Phil Holmes wrote:
Phil Holmes em...@philholmes.net writes:
- Original Message -
From: Graham Percival gra...@percival-music.ca
To: Phil Holmes em...@philholmes.net
Cc: Devel lilypond-devel@gnu.org
Sent: Sunday, February 05, 2012 2:20 PM
Subject: Re: Where to document patchy?
On Sun, Feb 05, 2012
- Original Message -
From: Graham Percival gra...@percival-music.ca
To: Phil Holmes em...@philholmes.net
Cc: Devel lilypond-devel@gnu.org
Sent: Sunday, February 05, 2012 3:08 PM
Subject: Re: Errors in examples
On Sun, Feb 05, 2012 at 02:43:45PM -, Phil Holmes wrote:
In the source
Hey all,
Could people please try this patch out on a couple real world scores and
do some benchmarking compared to current master? It adds a lot of
calculations to lilypond and a lot of them happen in Scheme, so I wanna
make sure lilypond doesn't take a large processing hit.
Cheers,
MS
On Mon, Feb 06, 2012 at 04:12:55PM -, Phil Holmes wrote:
- Original Message - From: Graham Percival
gra...@percival-music.ca
To: Phil Holmes em...@philholmes.net
Cc: Devel lilypond-devel@gnu.org
Sent: Sunday, February 05, 2012 3:08 PM
Subject: Re: Errors in examples
Users
Should have added before: the most recent patch set is not bug free.
I'm fixing all of the regtest issues, but what I need most from other
people who have a few minutes are benchmarks.
Cheers,
MS
http://codereview.appspot.com/5626052/
___
- Original Message -
From: mts...@gmail.com
To: mts...@gmail.com
Cc: re...@codereview-hr.appspotmail.com; lilypond-devel@gnu.org
Sent: Monday, February 06, 2012 4:59 PM
Subject: Re: Gets vertical skylines from grob stencils (issue 5626052)
Should have added before: the most recent
Graham Percival gra...@percival-music.ca writes:
On Mon, Feb 06, 2012 at 04:12:55PM -, Phil Holmes wrote:
- Original Message - From: Graham Percival
gra...@percival-music.ca
To: Phil Holmes em...@philholmes.net
Cc: Devel lilypond-devel@gnu.org
Sent: Sunday, February 05, 2012
On 6 February 2012 16:59, mts...@gmail.com wrote:
Should have added before: the most recent patch set is not bug free.
Cyclic dependencies for TextScript Y-offset.
But you've just fixed that by the look of it. ;)
I'm fixing all of the regtest issues, but what I need most from other
people
David Kastrup d...@gnu.org writes:
Graham Percival gra...@percival-music.ca writes:
On Mon, Feb 06, 2012 at 04:12:55PM -, Phil Holmes wrote:
- Original Message - From: Graham Percival
gra...@percival-music.ca
To: Phil Holmes em...@philholmes.net
Cc: Devel lilypond-devel@gnu.org
On Feb 6, 2012, at 6:36 PM, Neil Puttock wrote:
On 6 February 2012 16:59, mts...@gmail.com wrote:
Should have added before: the most recent patch set is not bug free.
Cyclic dependencies for TextScript Y-offset.
But you've just fixed that by the look of it. ;)
fixed is a generous
- Original Message -
From: David Kastrup d...@gnu.org
To: lilypond-devel@gnu.org
Sent: Monday, February 06, 2012 5:01 PM
Subject: Re: Errors in examples
Graham Percival gra...@percival-music.ca writes:
On Mon, Feb 06, 2012 at 04:12:55PM -, Phil Holmes wrote:
- Original
- Original Message -
From: David Kastrup d...@gnu.org
To: lilypond-devel@gnu.org
Sent: Monday, February 06, 2012 5:40 PM
Subject: Re: Errors in examples
David Kastrup d...@gnu.org writes:
Graham Percival gra...@percival-music.ca writes:
On Mon, Feb 06, 2012 at 04:12:55PM -,
Phil Holmes m...@philholmes.net writes:
No. The real problem is that \voiceOne and/or \voiceTwo do not take
hold for some reason. If they did, the example would just work fine.
Probably something grace-related.
Please let us find and fix the real problem instead of meddling with its
L'Isle joyeuse:
master: 0m30.432s
patched: 0m46.997s
Psalm 94 (Reubke):
master: 1m31.692s
patched: 2m0.817s
In my opinion, these times are too high to justify the gain that one
gets from using fine-tuned vertical skylines.
Yes, unfortunately.
Werner
On Mon, Feb 06, 2012 at 07:45:47PM +0100, Werner LEMBERG wrote:
In my opinion, these times are too high to justify the gain that one
gets from using fine-tuned vertical skylines.
Yes, unfortunately.
+1
is it at all possible to make this a user-configurable option?
I know this would add
Could you publicize work-in-progress patches like this as a git branch
instead of a Rietveld issue? Git branches are easy for reviewers to check
out, fast-forward, revert, etc. That way, people can offer broad comments.
When the patch is finished (ie. you can't think of anything you need to
On Feb 6, 2012, at 8:00 PM, Joe Neeman wrote:
Could you publicize work-in-progress patches like this as a git branch
instead of a Rietveld issue?
Ok. For the git-handicapped (me), how does one do this?
Cheers,
MS
___
lilypond-devel mailing list
m...@apollinemike.com m...@apollinemike.com writes:
On Feb 6, 2012, at 8:00 PM, Joe Neeman wrote:
Could you publicize work-in-progress patches like this as a git
branch instead of a Rietveld issue?
Ok. For the git-handicapped (me), how does one do this?
Assuming you have a feature branch
m...@apollinemike.com m...@apollinemike.com writes:
L'Isle joyeuse:
master: 0m30.432s
patched: 0m46.997s
Psalm 94 (Reubke):
master: 1m31.692s
patched: 2m0.817s
Thanks!
In my opinion, these times are too high to justify the gain that one
gets from using fine-tuned vertical
On Feb 6, 2012, at 8:37 PM, David Kastrup wrote:
It is rare that I encounter an algorithm that I can't speed up by a
factor of at least 10 once I seriously try (and that does not mean
coding in assembly or similar bad deals).
Have at it!
To all interested parties, this work is now up on:
To all interested parties, this work is now up on:
dev/skylines
Thanks. A minor thing which causes me grief each time I see it:
Please configure your editor so that it automatically inserts a
newline character at EOF.
Werner
___
2012/2/6 m...@apollinemike.com m...@apollinemike.com:
Hey all,
I see a shortcut for utf-8-strings in pango-font.cc. This is all well and
good except that it is hard to do box approximations on these guys (it'd
require adding lots of code). How mad would LilyPond be if I just deleted
all
On 2012/02/06 19:25:34, mike_apollinemike.com wrote:
On Feb 6, 2012, at 8:00 PM, Joe Neeman wrote:
Could you publicize work-in-progress patches like this as a git
branch instead
of a Rietveld issue?
Ok. For the git-handicapped (me), how does one do this?
Push a private branch to our
m...@apollinemike.com m...@apollinemike.com writes:
I'll look into doing 1. Meanwhile, if someone can tell me how to push
changes to a remote branch (after having created the branch), I'd be
much obliged!
If it is a fast forward, just push like the initial push. If it is not,
you can't push
My local repository wasn't created with git clone, and i have only one
remote branch ('origin/master'); i cannot push to staging because of
that. I've tried 'git fetch --all', but the other remote branches do
not appear, and i don't see a solution in git fetch description. Any
help?
thanks in
32 matches
Mail list logo
