LGTM
http://codereview.appspot.com/5650064/diff/4001/scripts/build/run-and-check.sh
File scripts/build/run-and-check.sh (right):
http://codereview.appspot.com/5650064/diff/4001/scripts/build/run-and-check.sh#newcode2
scripts/build/run-and-check.sh:2: eval $1 $2 21
I know this has already been
LGTM
http://codereview.appspot.com/5504092/diff/20001/scripts/auxiliar/lily-git.tcl
File scripts/auxiliar/lily-git.tcl (right):
http://codereview.appspot.com/5504092/diff/20001/scripts/auxiliar/lily-git.tcl#newcode248
scripts/auxiliar/lily-git.tcl:248: git remote add -t $originHead \
This
http://codereview.appspot.com/5650064/diff/4001/scripts/build/run-and-check.sh
File scripts/build/run-and-check.sh (right):
http://codereview.appspot.com/5650064/diff/4001/scripts/build/run-and-check.sh#newcode2
scripts/build/run-and-check.sh:2: eval $1 $2 21
On 2012/02/13 10:53:44, Graham
- Original Message -
From: gra...@percival-music.ca
To: philehol...@googlemail.com; d...@gnu.org; julien.ri...@gmail.com;
m...@philholmes.net
Cc: lilypond-devel@gnu.org; re...@codereview-hr.appspotmail.com
Sent: Monday, February 13, 2012 10:53 AM
Subject: Re: Final redirection of texi
Comments added describing eval line.
http://codereview.appspot.com/5650064/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
http://codereview.appspot.com/5651069/diff/1/lily/note-collision.cc
File lily/note-collision.cc (right):
http://codereview.appspot.com/5651069/diff/1/lily/note-collision.cc#newcode536
lily/note-collision.cc:536: s[LEFT]--; // why LEFT and RIGHT instead of
UP and DOWN?
sometimes i liked to
http://codereview.appspot.com/5651069/diff/1/lily/note-collision.cc
File lily/note-collision.cc (right):
http://codereview.appspot.com/5651069/diff/1/lily/note-collision.cc#newcode587
lily/note-collision.cc:587: for_UP_and_DOWN (d)
On 2012/02/13 11:33:48, hanwenn wrote:
after reading some of
On Mon, Feb 13, 2012 at 11:05:56AM +, d...@gnu.org wrote:
scripts/build/run-and-check.sh:2: eval $1 $2 21
Actually, it is totally basic shell scripting here.
Well, apparently you don't need basic shell scripting for 7
years of full-time linux use and 4 years of macosx use, and
On Sat, Feb 11, 2012 at 8:31 AM, janek.lilyp...@gmail.com wrote:
somebody proposed a change, it was resisted because the do{}
flip(d)!=UP idiom
seemed simple enough to be acceptable.
It took us a while to figure out what's going on with the do{}
flip(d)!=UP thing.
If it was up to me,
On Sat, Feb 11, 2012 at 10:27 AM, milimet...@gmail.com wrote:
Yes - someone who knows this code :] Possibly one day someone will try
to refactor this code, what will mean that he understands it well.
For me it's really hard to understand whats going on here. Me and Janek
recently spent a
On Sun, Feb 12, 2012 at 9:03 AM, Janek Warchoł janek.lilyp...@gmail.com wrote:
Hi all,
SUMMARY: in order to participate in Google Summer of Code ($$$), we
need an Ideas List.
I think the most interesting is probably #1 (grace note
synchronization) and #2 (musicxml). Of those, I recommend #2
Han-Wen Nienhuys hanw...@gmail.com writes:
On Sat, Feb 11, 2012 at 8:31 AM, janek.lilyp...@gmail.com wrote:
Well, the main point of the comment is not describing parameters, but
the function itself. Believe me or not, we spent 10 minutes figuring
out _what the hell_ are apes doing here and
On Mon, Feb 13, 2012 at 9:52 AM, David Kastrup d...@gnu.org wrote:
I disagree. Reading code the first time is hard, that is true, but
unless anything surprising is happening, it does not deserve a
comment. The more you read code, the easier it becomes, and think of
this as you learning how
On Sun, Feb 12, 2012 at 09:39:59PM +0100, Christian Hitz wrote:
Am 11.02.2012 um 19:57 schrieb Carl Sorensen:
Yes, and I'm aware of that two-line fix. It gives ppc support, but I
think it also gives a bad version of LilyPond when the About menu item is
checked. I may be wrong on this.
On Feb 13, 2012, at 5:41 AM, Joe Neeman wrote:
On Thu, Feb 9, 2012 at 9:50 AM, m...@apollinemike.com m...@apollinemike.com
wrote:
On Feb 7, 2012, at 6:47 PM, m...@apollinemike.com wrote:
I did some experiments with caching that are up on:
dev/skylines-cached
Hey all,
Fresh
Looks good, I just have a few suggestions to avoid clashing log file
names and I wonder how this part of GOP 9 might be implemented down the
road:
All other logfiles will go in the @file{build/logfiles/} directory.
http://codereview.appspot.com/5650064/diff/5003/Documentation/GNUmakefile
File
Graham Percival gra...@percival-music.ca writes:
On Mon, Feb 13, 2012 at 11:05:56AM +, d...@gnu.org wrote:
scripts/build/run-and-check.sh:2: eval $1 $2 21
Actually, it is totally basic shell scripting here.
Well, apparently you don't need basic shell scripting for 7
years of
On Mon, Feb 13, 2012 at 12:47:22PM +0100, David Kastrup wrote:
Graham Percival gra...@percival-music.ca writes:
My rule of thumb is that if I don't understand something easily,
then at least 50% of future lilypond contributors won't understand
it either.
eval is ugly and a
Le 13/02/2012 14:56, julien.ri...@gmail.com disait :
Looks good, I just have a few suggestions to avoid clashing log file
names and I wonder how this part of GOP 9 might be implemented down the
road:
All other logfiles will go in the @file{build/logfiles/} directory.
Am 13.02.2012 um 13:36 schrieb Graham Percival:
On Sun, Feb 12, 2012 at 09:39:59PM +0100, Christian Hitz wrote:
Am 11.02.2012 um 19:57 schrieb Carl Sorensen:
Yes, and I'm aware of that two-line fix. It gives ppc support, but I
think it also gives a bad version of LilyPond when the About
On Mon, Feb 13, 2012 at 02:46:01PM -0500, Julien Rioux wrote:
On Mon, Feb 13, 2012 at 2:38 PM, Francisco Vila paconet@gmail.com wrote:
Images should be pushed along other changes, and also to our branch.
Graham has to authorize something afterwards for those to be visible.
Forwarding to
2012/2/13 Graham Percival gra...@percival-music.ca:
... that said, I see those files in lilypond-extra/pictures/, so
maybe they _are_ needed. Hmm, the only way to find out is to try
reading make/website.make, and/or doing a few experiments.
I'm afraid I will not have time for this before
- Ursprüngliche Mitteilung -
Von: LilyPond Development lilyp...@fam.tuwien.ac.at
Gesendet : Di., 14. Feb. 2012 01:39:05 CET
An: reinh...@fam.tuwien.ac.at
Betreff: GDP Docs compilation FAILED (2012.02.14-01:39)
Preprocessing graphical objects...
Calculating line breaks...
Drawing
Reinhold Kainhofer reinh...@kainhofer.com writes:
[...]
It is not clear where this mail hails from, which commands were used to
get this error under which circumstances.
--
David Kastrup
___
lilypond-devel mailing list
lilypond-devel@gnu.org
24 matches
Mail list logo
