Re: Corrected comments and a function check_meshing_chords divided in two. (issue 5975054)

2012-04-01 Thread k-ohara5a5a
On 2012/04/01 05:00:25, Graham Percival wrote: Ouch. I don't find that for loop to be particularly easy to understand; No-one has found a clearer way to write this loop in C++. The best we can do is choose a consistent idiom that we can learn to recognize. Any of the suggested for()-forms

Re: Corrected comments and a function check_meshing_chords divided in two. (issue 5975054)

2012-04-01 Thread Graham Percival
On Sun, Apr 01, 2012 at 06:12:27AM +, k-ohara5...@oco.net wrote: On 2012/04/01 05:00:25, Graham Percival wrote: it would be much nicer if there was a macro for this. It is better to define macros for just the part inside the for(...) . Then we can write, and auto-indenters can indent,

my GSoC application - please review! (also, who will be my mentor?)

2012-04-01 Thread Janek Warchoł
Hi all, below is my application, written according to GNU guidelines (http://www.gnu.org/software/soc-projects/guidelines.html). What do you think about it? Also, since this is a new project not mentioned on our GSoC page, i need to know who will mentor me - Mike? :) (it would be great if

Re: issues 2266 and 1721

2012-04-01 Thread Jean-Charles Malahieude
Le 01/04/2012 00:23, Colin Hall disait : On Mar 31, 2012 at 07:47PM, Jean-Charles Malahieude wrote: [...] My questioning is: Why a same macro could behave differently when in LM or in NR, and why, though they look identical do they work differently according to the target manual? Hi

Re: my GSoC application - please review! (also, who will be my mentor?)

2012-04-01 Thread Werner LEMBERG
Janek, please do s/syllabe/syllable/ Besides this, it looks nice, and hopefully everything runs fine! BTW, expect delays with the schedule :-) Werner ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Corrected style of comments (issue 5862052)

2012-04-01 Thread Łukasz Czerwiński
Thanku you, Janek and James. Wouldn't it be nicer for git cl to ask for an issue number in case it is unknown? Default value (e.g. 0) could mean a new issue, but the programmer would have an opportunity to type the right issue number. Łukasz On 31 March 2012 22:46, James pkx1...@gmail.com

Re: Corrected style of comments (issue 5862052)

2012-04-01 Thread Graham Percival
On Sun, Apr 01, 2012 at 10:46:01AM +0200, Łukasz Czerwiński wrote: Thanku you, Janek and James. Don't add replies to the top an email. Wouldn't it be nicer for git cl to ask for an issue number in case it is unknown? It does. I suggest you update your git-cl to get this addition

Re: Corrected style of comments (issue 5862052)

2012-04-01 Thread Janek Warchoł
On Sun, Apr 1, 2012 at 10:57 AM, Graham Percival gra...@percival-music.ca wrote: On Sun, Apr 01, 2012 at 10:46:01AM +0200, Łukasz Czerwiński wrote:    Thanku you, Janek and James. Don't add replies to the top an email.    Wouldn't it be nicer for git cl to ask for an issue number in case it

Re: my GSoC application - please review! (also, who will be my mentor?)

2012-04-01 Thread m...@apollinemike.com
On Apr 1, 2012, at 9:39 AM, Janek Warchoł wrote: Also, since this is a new project not mentioned on our GSoC page, i need to know who will mentor me - Mike? :) Doable, although if I mentor you you may wind up breaking more things than you fix! Below is a diff with some corrections. It's

Re: Corrected style of comments (issue 5862052)

2012-04-01 Thread Graham Percival
On Sun, Apr 01, 2012 at 11:00:44AM +0200, Janek Warchoł wrote: On Sun, Apr 1, 2012 at 10:57 AM, Graham Percival gra...@percival-music.ca wrote: On Sun, Apr 01, 2012 at 10:46:01AM +0200, Łukasz Czerwiński wrote:    Wouldn't it be nicer for git cl to ask for an issue number in case it    is

Re: Corrected style of comments (issue 5862052)

2012-04-01 Thread Phil Holmes
- Original Message - From: Graham Percival gra...@percival-music.ca To: Janek Warchoł janek.lilyp...@gmail.com Cc: k-ohara5...@oco.net; re...@codereview-hr.appspotmail.com; julien.ri...@gmail.com; lilypond-devel@gnu.org Sent: Sunday, April 01, 2012 10:21 AM Subject: Re: Corrected style

Re: Corrected style of comments (issue 5862052)

2012-04-01 Thread Graham Percival
On Sun, Apr 01, 2012 at 11:09:59AM +0100, Phil Holmes wrote: - Original Message - From: Graham Percival gra...@percival-music.ca To: Janek Warchoł janek.lilyp...@gmail.com Cc: k-ohara5...@oco.net; re...@codereview-hr.appspotmail.com; julien.ri...@gmail.com; lilypond-devel@gnu.org

Re: my GSoC application - please review! (also, who will be my mentor?)

2012-04-01 Thread Janek Warchoł
On Sun, Apr 1, 2012 at 10:40 AM, Werner LEMBERG w...@gnu.org wrote: please do s/syllabe/syllable/ done, thanks! Besides this, it looks nice, and hopefully everything runs fine! BTW, expect delays with the schedule :-) i know :) On Sun, Apr 1, 2012 at 11:16 AM, m...@apollinemike.com

Re: my GSoC application - please review! (also, who will be my mentor?)

2012-04-01 Thread m...@apollinemike.com
On Apr 1, 2012, at 1:24 PM, Janek Warchoł wrote: Do you think i've chosen a good order of attach in my plan? My problem is that i will have significantly more time in the second half of the project. However, i've read that it's better to start with the most important (on thus often most

Changes .tex files to get rid of warning (issue 5976055)

2012-04-01 Thread PhilEHolmes
Reviewers: Julien Rioux, Graham Percival, dak, Message: Please review Description: These files used what appears to be a deprecated syntax to invoke lilypond-book, resulting in these warnings: lilypond-book.py: warning: deprecated ly-option used: 11pt=None lilypond-book.py: warning:

Re: Changes .tex files to get rid of warning (issue 5976055)

2012-04-01 Thread graham
The .latex file just says upload in progress. Could you add it to the exceptions (like .scm and .ps) as discussed somewhere in the CG? Assuming that the change to the .latex file is just like the .lytex ones, please push the whole thing directly to staging. (I'd still like the .latex extension

Re: Issue 2391 in lilypond: Add Appendix entry for Predefined Paper Sizes

2012-04-01 Thread Jean-Charles Malahieude
Hi all! Unfortunately, the rewriting of NR-4.1.2 Paper size and automatic scaling results in disappearance of the standard paper sizes which now get only mentioned in an appendix. This appendix needs a @ref (will be there in French after I have committed). Cheers, Jean-Charles

Re: Changes .tex files to get rid of warning (issue 5976055)

2012-04-01 Thread Phil Holmes
- Original Message - From: gra...@percival-music.ca To: philehol...@googlemail.com; julien.ri...@gmail.com; d...@gnu.org Cc: lilypond-devel@gnu.org; re...@codereview-hr.appspotmail.com Sent: Sunday, April 01, 2012 2:23 PM Subject: Re: Changes .tex files to get rid of warning (issue

Re: LSR is now on 2.14

2012-04-01 Thread David Nalesnik
Hi, Simplest way might be for Harm, David and myself to put these in the LSR. Don't think it'll take that long. I'd then check and approve them - so if I took 10 and you 2 share the others out, that should be fair? What do you think? Sure, I'll be happy to take a share. -David

Re: LSR is now on 2.14

2012-04-01 Thread Phil Holmes
Thanks. Currently working on sorting out the problem with the headers - once that's done we'll set about this. Phil Holmes - Original Message - From: David Nalesnik To: Phil Holmes Cc: Thomas Morley ; lilypond-devel Sent: Sunday, April 01, 2012 3:49 PM Subject: Re:

Re: Changes .tex files to get rid of warning (issue 5976055)

2012-04-01 Thread Graham Percival
On Sun, Apr 01, 2012 at 03:16:52PM +0100, Phil Holmes wrote: It looked fine on Rietveld when I looked, and I couldn't find the exceptions bit in the CG, so it's pushed to staging as is. Oops, we were smarter than I thought -- the exceptions are built into git-cl precisely to avoid problems of

Directs pnmtopng stderr output to dev/null (issue 5973044)

2012-04-01 Thread PhilEHolmes
Reviewers: Julien Rioux, Graham Percival, dak, Message: Please review. Description: I'm directing this to dev null because there's no point in using a logfile here. The message from pnmtopng is: pnmtopng: 256 colors found and it displays this for greyscale images. If this line fails, it

Re: LSR is now on 2.14

2012-04-01 Thread Thomas Morley
Am 1. April 2012 16:57 schrieb Phil Holmes m...@philholmes.net: Thanks.  Currently working on sorting out the problem with the headers - once that's done we'll set about this. Phil Holmes - Original Message - From: David Nalesnik To: Phil Holmes Cc: Thomas Morley ;

Re: Directs pnmtopng stderr output to dev/null (issue 5973044)

2012-04-01 Thread Graham Percival
Sure, go ahead and push. ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Doc: NR 1.2.3 Expl. manual accidentals + cadenzas (issue 5976056)

2012-04-01 Thread graham
LGTM, please push immediately assuming it passes make doc. http://codereview.appspot.com/5976056/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: LSR is now on 2.14

2012-04-01 Thread Phil Holmes
From: Thomas Morley thomasmorle...@googlemail.com To: Phil Holmes m...@philholmes.net Cc: David Nalesnik david.nales...@gmail.com; lilypond-devel lilypond-devel@gnu.org Sent: Sunday, April 01, 2012 6:19 PM Subject: Re: LSR is now on 2.14 Am 1. April 2012 16:57 schrieb Phil Holmes

Re: LSR is now on 2.14

2012-04-01 Thread David Nalesnik
Hi Harm, On Sun, Apr 1, 2012 at 3:23 PM, Phil Holmes m...@philholmes.net wrote: From: Thomas Morley thomasmorle...@googlemail.com** To: Phil Holmes m...@philholmes.net Cc: David Nalesnik david.nales...@gmail.com; lilypond-devel lilypond-devel@gnu.org Sent: Sunday, April 01, 2012 6:19 PM

Reducing make doc output

2012-04-01 Thread Phil Holmes
One of the warnings showing in make doc now is: langdefs.py: warning: lilypond-doc gettext domain not found. I'm not sure what to do about this. There's no point in sending it to a logfile. I'm not sure the value the warning has? I could get rid of it? I could make it depend on warning

Re: Reducing make doc output

2012-04-01 Thread Carl Sorensen
On Apr 1, 2012, at 2:42 PM, Phil Holmes em...@philholmes.net wrote: One of the warnings showing in make doc now is: langdefs.py: warning: lilypond-doc gettext domain not found. I'm not sure what to do about this. IIUC, this warning shows that we are not handling localization properly.

No LilyPond Report today

2012-04-01 Thread Valentin Villenave
Hello folks, you may have noticed that there **isn't** a new LilyPond Report out today. Nope. None at all. Sorry. And if anything, you will certainly **not** find it here: http://news.lilynet.net/?The-LilyPond-Report-25 But I didn't tell you that. Cheers, Valentin.

Re: issues 2266 and 1721

2012-04-01 Thread Colin Hall
On Sun, Apr 01, 2012 at 10:35:15AM +0200, Jean-Charles Malahieude wrote: Le 01/04/2012 00:23, Colin Hall disait : On Mar 31, 2012 at 07:47PM, Jean-Charles Malahieude wrote: [...] My questioning is: Why a same macro could behave differently when in LM or in NR, and why, though they look

Re: Doc: NR 1.2.3 Expl. manual accidentals + cadenzas (issue 5976056)

2012-04-01 Thread tdanielsmusic
A couple of these changes are actually misleading, so I think they at least should be corrected. Trevor http://codereview.appspot.com/5976056/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right):

Re: Issue 2391 in lilypond: Add Appendix entry for Predefined Paper Sizes

2012-04-01 Thread Colin Hall
On Sun, Apr 01, 2012 at 03:34:27PM +0200, Jean-Charles Malahieude wrote: Unfortunately, the rewriting of NR-4.1.2 Paper size and automatic scaling results in disappearance of the standard paper sizes which now get only mentioned in an appendix. This appendix needs a @ref (will be there in

Doc: NR 1.8.2 - add \abs-fontsize to main doc (issue 5969060)

2012-04-01 Thread tdanielsmusic
LGTM, apart from the one change suggested. Trevor http://codereview.appspot.com/5969060/diff/2001/Documentation/notation/text.itely File Documentation/notation/text.itely (right): http://codereview.appspot.com/5969060/diff/2001/Documentation/notation/text.itely#newcode544

Re: LSR is now on 2.14

2012-04-01 Thread Thomas Morley
Am 1. April 2012 22:23 schrieb Phil Holmes m...@philholmes.net: From: Thomas Morley thomasmorle...@googlemail.com I downloaded todays LSR-tarball and removed all unnecessary headers and versions manually. Compiling-tests showed no problems. I'd like to create a new tarball and send it back to

Re: my GSoC application - please review! (also, who will be my mentor?)

2012-04-01 Thread Carl Sorensen
On 4/1/12 1:39 AM, Janek Warchoł janek.lilyp...@gmail.com wrote: Hi all, below is my application, written according to GNU guidelines (http://www.gnu.org/software/soc-projects/guidelines.html). What do you think about it? Also, since this is a new project not mentioned on our GSoC page, i need

Re: Corrected comments and a function check_meshing_chords divided in two. (issue 5975054)

2012-04-01 Thread hanwenn
http://codereview.appspot.com/5975054/diff/1/lily/include/note-collision.hh File lily/include/note-collision.hh (right): http://codereview.appspot.com/5975054/diff/1/lily/include/note-collision.hh#newcode56 lily/include/note-collision.hh:56: int down_ball_type; this doesnt make sense? The

Update Rietveld patches

2012-04-01 Thread Colin Campbell
The items below are the result of a search on Rietveld for open items associated with the lilypond trunk. In some cases, the tracker item has been closed, so the Rietveld item should also be closed. In others, work continues but it would be good to cross-reference the tracker item in the