Re: Design flaw in Rest_collision

2012-11-05 Thread David Kastrup
m...@mikesolomon.org m...@mikesolomon.org writes: On 5 nov. 2012, at 06:51, m...@mikesolomon.org wrote: 1) rest-extent (common, Y_AXIS) 2) Rest::height 3) Rest::generic_extent_callback 4) Rest::brew_internal_stencil 5) Rest::glyph_name 6) Staff_symbol_referencer::get_position 7)

Re: Design flaw in Rest_collision

2012-11-05 Thread m...@mikesolomon.org
On 5 nov. 2012, at 09:19, David Kastrup d...@gnu.org wrote: m...@mikesolomon.org m...@mikesolomon.org writes: On 5 nov. 2012, at 06:51, m...@mikesolomon.org wrote: 1) rest-extent (common, Y_AXIS) 2) Rest::height 3) Rest::generic_extent_callback 4) Rest::brew_internal_stencil 5)

Re: Design flaw in Rest_collision

2012-11-05 Thread David Kastrup
m...@mikesolomon.org m...@mikesolomon.org writes: On 5 nov. 2012, at 09:19, David Kastrup d...@gnu.org wrote: m...@mikesolomon.org m...@mikesolomon.org writes: On 5 nov. 2012, at 06:51, m...@mikesolomon.org wrote: 1) rest-extent (common, Y_AXIS) 2) Rest::height 3)

Re: Design flaw in Rest_collision

2012-11-05 Thread m...@mikesolomon.org
On 5 nov. 2012, at 09:26, David Kastrup d...@gnu.org wrote: m...@mikesolomon.org m...@mikesolomon.org writes: On 5 nov. 2012, at 09:19, David Kastrup d...@gnu.org wrote: m...@mikesolomon.org m...@mikesolomon.org writes: On 5 nov. 2012, at 06:51, m...@mikesolomon.org wrote: 1)

Re: Design flaw in Rest_collision

2012-11-05 Thread David Kastrup
m...@mikesolomon.org m...@mikesolomon.org writes: On 5 nov. 2012, at 09:26, David Kastrup d...@gnu.org wrote: m...@mikesolomon.org m...@mikesolomon.org writes: On 5 nov. 2012, at 09:19, David Kastrup d...@gnu.org wrote: m...@mikesolomon.org m...@mikesolomon.org writes: On 5 nov. 2012,

Re: Design flaw in Rest_collision

2012-11-05 Thread m...@mikesolomon.org
On 5 nov. 2012, at 09:34, David Kastrup d...@gnu.org wrote: m...@mikesolomon.org m...@mikesolomon.org writes: On 5 nov. 2012, at 09:26, David Kastrup d...@gnu.org wrote: m...@mikesolomon.org m...@mikesolomon.org writes: On 5 nov. 2012, at 09:19, David Kastrup d...@gnu.org wrote:

Re: Design flaw in Rest_collision

2012-11-05 Thread David Kastrup
m...@mikesolomon.org m...@mikesolomon.org writes: Do the different rest glyphs actually have different height? Would it be possible to stipulate that they are not supposed to, and just let the code for rest height in general return the height of the standard rest glyph without bothering to

Re: Design flaw in Rest_collision

2012-11-05 Thread m...@mikesolomon.org
On 5 nov. 2012, at 09:45, David Kastrup d...@gnu.org wrote: m...@mikesolomon.org m...@mikesolomon.org writes: Do the different rest glyphs actually have different height? Would it be possible to stipulate that they are not supposed to, and just let the code for rest height in general

Re: Gub pango-1.26.0-darwin-cx-font.patch

2012-11-05 Thread Phil Holmes
- Original Message - From: Jeremiah Benham jjben...@chicagoguitar.com To: lilypond-devel@gnu.org Sent: Monday, November 05, 2012 3:50 AM Subject: Gub pango-1.26.0-darwin-cx-font.patch Does anyone know what happened to this patch pango-1.26.0-darwin-cx-font.patch. I don't see it in

Re: Design flaw in Rest_collision

2012-11-05 Thread Werner LEMBERG
Do the different rest glyphs actually have different height? Would it be possible to stipulate that they are not supposed to, and just let the code for rest height in general return the height of the standard rest glyph without bothering to check the on-staffiness? I don't understand. A

Re: Design flaw in Rest_collision

2012-11-05 Thread m...@mikesolomon.org
On 5 nov. 2012, at 10:11, Werner LEMBERG w...@gnu.org wrote: Do the different rest glyphs actually have different height? Would it be possible to stipulate that they are not supposed to, and just let the code for rest height in general return the height of the standard rest glyph without

Re: Allows optional octavation for clefs (issue 6813044)

2012-11-05 Thread Marc Hohl
Am 03.11.2012 23:20, schrieb Janek WarchoĊ‚: On Fri, Nov 2, 2012 at 10:20 PM, Marc Hohl m...@hohlart.de wrote: Am 02.11.2012 09:58, schrieb janek.lilyp...@gmail.com: http://codereview.appspot.com/6813044/diff/6001/lily/clef-engraver.cc#newcode125 lily/clef-engraver.cc:125: if (ly_is_procedure

Re: Design flaw in Rest_collision

2012-11-05 Thread Werner LEMBERG
No, we're talking about the height of something like rests.1 compared to rests.1o in the Feta font. OK. The question is if these two glyphs have a different Y-extent (rests.1 versus rests.1o). From feta20.log, beautified: whole rest 0 7.5 3.12507.5 0 0

Gobble empty strings passed as arguments to python scripts. (issue 6819066)

2012-11-05 Thread janek . lilypond
I think it would be helpful to not-so-advanced English speakers if a word more ordinary than gobble was used. Janek https://codereview.appspot.com/6819066/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Document symbol list changes. (issue 6813079)

2012-11-05 Thread janek . lilypond
LGTM Janek https://codereview.appspot.com/6813079/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Gobble empty strings passed as arguments to python scripts. (issue 6819066)

2012-11-05 Thread dak
On 2012/11/05 10:58:37, janek wrote: I think it would be helpful to not-so-advanced English speakers if a word more ordinary than gobble was used. I am not sure of that. gobble is actually pretty established in programmer jargon: From The Jargon File (version 4.4.7, 29 Dec 2003) [jargon]:

Re: Design flaw in Rest_collision

2012-11-05 Thread m...@mikesolomon.org
On 5 nov. 2012, at 11:15, Werner LEMBERG w...@gnu.org wrote: No, we're talking about the height of something like rests.1 compared to rests.1o in the Feta font. OK. The question is if these two glyphs have a different Y-extent (rests.1 versus rests.1o). From feta20.log, beautified:

Allow (closed) scheme function calls as text scripts. (issue 6812088)

2012-11-05 Thread lemzwerg
Very nice! http://codereview.appspot.com/6812088/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Allow (closed) scheme function calls as text scripts. (issue 6812088)

2012-11-05 Thread thomasmorley65
On 2012/11/05 22:40:36, lemzwerg wrote: Very nice! Can't review the code. But from description: GREAT http://codereview.appspot.com/6812088/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Allow (closed) scheme function calls as text scripts. (issue 6812088)

2012-11-05 Thread dak
Reviewers: lemzwerg, thomasmorley65, Message: On 2012/11/05 22:45:06, thomasmorley65 wrote: On 2012/11/05 22:40:36, lemzwerg wrote: Very nice! Can't review the code. But from description: GREAT It's actually more a fix of a shortcoming. Scheme functions should have worked in most places

Re: Design flaw in Rest_collision

2012-11-05 Thread Keith OHara
mike at mikesolomon.org mike at mikesolomon.org writes: On 5 nov. 2012, at 11:15, Werner LEMBERG wl at gnu.org wrote: So the answer is yes: The height (resp. the depth) is larger for outside-staff glyphs. So we officially have a circular dependency: in order to know the height

Re: Design flaw in Rest_collision

2012-11-05 Thread m...@mikesolomon.org
On 6 nov. 2012, at 04:51, Keith OHara k-ohara5...@oco.net wrote: mike at mikesolomon.org mike at mikesolomon.org writes: On 5 nov. 2012, at 11:15, Werner LEMBERG wl at gnu.org wrote: So the answer is yes: The height (resp. the depth) is larger for outside-staff glyphs. So we